[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1158052306 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8937: boardioc: Reset & poweroff are protected by critical section.

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8937: URL: https://github.com/apache/nuttx/pull/8937#issuecomment-1496952148 > > But, this change doesn't work for SMP, and the thread may suspend and switch to new thread even you hold critical section since the thread may block self or wake high priority

[GitHub] [nuttx] yamt commented on pull request #8868: fs/hostfs: add sim hostfs path convert

2023-04-04 Thread via GitHub
yamt commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1496884086 > > > > > > > ls /data will report the error. This patch ensures the user get the consistent result regardless he launches the program from anywhere. > > > > > > > > > > > > > > > >

[GitHub] [nuttx] dishilov commented on issue #8933: FS_LARGEFILE config disabled is causing issue with df -h output.

2023-04-04 Thread via GitHub
dishilov commented on issue #8933: URL: https://github.com/apache/nuttx/issues/8933#issuecomment-1496804311 @acassis @laoniaokkk I was under impression the 'df' command has nothing to do with file sizes and is used to display volume information - which it does correctly when used without

[nuttx-apps] branch master updated (f58c87e7e -> b93aa0cb8)

2023-04-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from f58c87e7e nshlib/README.md: add uptime command description add b93aa0cb8 ostest: Fixed use of

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1705: ostest: Fixed use of uninitialized variable.

2023-04-04 Thread via GitHub
pkarashchenko merged PR #1705: URL: https://github.com/apache/nuttx-apps/pull/1705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] pkarashchenko commented on pull request #8965: Fixed improper access of g_pidhash.

2023-04-04 Thread via GitHub
pkarashchenko commented on PR #8965: URL: https://github.com/apache/nuttx/pull/8965#issuecomment-1496778255 This change might be not needed with https://github.com/apache/nuttx/pull/8951 as pid hash table will not be accessed there. This is just FYI. -- This is an automated message from

[GitHub] [nuttx] acassis commented on issue #8933: FS_LARGEFILE config disabled is causing issue with df -h output.

2023-04-04 Thread via GitHub
acassis commented on issue #8933: URL: https://github.com/apache/nuttx/issues/8933#issuecomment-1496776044 Good point @laoniaokkk it is not a BUG! Maybe we should select FS_LARGEFILE automatically when enabling SD/MMC driver because probably most of users will be using a SDCard bigger than

[GitHub] [nuttx] acassis opened a new issue, #8966: NuttX is broken to LPC2378 (and probably others ARM7TDMI)

2023-04-04 Thread via GitHub
acassis opened a new issue, #8966: URL: https://github.com/apache/nuttx/issues/8966 I decide to test NuttX running it in the first board that I used almost 13 years ago, more info here: https://acassis.wordpress.com/2023/04/01/testing-nuttx-again-on-olimex-lpc2378-stk-board/

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 95af4b35cf569079d37b0036b04d145b30fb038c

2023-04-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 152d8984 Publishing web:

[GitHub] [nuttx] patacongo merged pull request #8965: Fixed improper access of g_pidhash.

2023-04-04 Thread via GitHub
patacongo merged PR #8965: URL: https://github.com/apache/nuttx/pull/8965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated (553fe83abf -> 95af4b35cf)

2023-04-04 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 553fe83abf boards: refresh boards that use usbmsc add 95af4b35cf Fixed improper access of g_pidhash. No new

[GitHub] [nuttx-apps] fjpanag opened a new pull request, #1705: ostest: Fixed use of uninitialized variable.

2023-04-04 Thread via GitHub
fjpanag opened a new pull request, #1705: URL: https://github.com/apache/nuttx-apps/pull/1705 ## Summary Fixes an uninitialized variable in ostest (and stops the corresponding compiler warning). ## Impact Bug fix. ## Testing Build test. -- This is

[GitHub] [nuttx] fjpanag commented on a diff in pull request #8965: Fixed improper access of g_pidhash.

2023-04-04 Thread via GitHub
fjpanag commented on code in PR #8965: URL: https://github.com/apache/nuttx/pull/8965#discussion_r1157807727 ## sched/task/task_setup.c: ## @@ -83,6 +83,7 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb) FAR struct tcb_s **pidhash; pid_t next_pid; int hash_ndx;

[GitHub] [nuttx] patacongo commented on a diff in pull request #8965: Fixed improper access of g_pidhash.

2023-04-04 Thread via GitHub
patacongo commented on code in PR #8965: URL: https://github.com/apache/nuttx/pull/8965#discussion_r1157801931 ## sched/task/task_setup.c: ## @@ -83,6 +83,7 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb) FAR struct tcb_s **pidhash; pid_t next_pid; int

[GitHub] [nuttx] fjpanag opened a new pull request, #8965: Fixed improper access of g_pidhash.

2023-04-04 Thread via GitHub
fjpanag opened a new pull request, #8965: URL: https://github.com/apache/nuttx/pull/8965 ## Summary Fixes potential garbage access to `g_pidhash`. Also see [here](https://lists.apache.org/list.html?d...@nuttx.apache.org). ## Impact Bug fix. ## Testing

[GitHub] [nuttx] fjpanag commented on pull request #8937: boardioc: Reset & poweroff are protected by critical section.

2023-04-04 Thread via GitHub
fjpanag commented on PR #8937: URL: https://github.com/apache/nuttx/pull/8937#issuecomment-1496593341 > But, this change doesn't work for SMP, and the thread may suspend and switch to new thread even you hold critical section since the thread may block self or wake high priority thread

[GitHub] [nuttx] tmedicci commented on pull request #8926: xtensa/sigdeliver: fix signal deliver when task is running on ther CPU

2023-04-04 Thread via GitHub
tmedicci commented on PR #8926: URL: https://github.com/apache/nuttx/pull/8926#issuecomment-1496554989 Converted to Draft to run more testing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157706422 ## fsutils/romloader/Makefile: ## @@ -0,0 +1,106 @@ + +#

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157703592 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach SDIR,

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157692604 ## fsutils/romloader/Makefile: ## @@ -0,0 +1,106 @@ + +#

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157687516 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157687516 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1496486630 Please revert https://github.com/apache/nuttx/pull/8938 and apply your change after it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8937: boardioc: Reset & poweroff are protected by critical section.

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8937: URL: https://github.com/apache/nuttx/pull/8937#issuecomment-1496480193 But, this change doesn't work for SMP, and the thread may suspend and switch to new thread even you hold critical section since the thread may block self or wake high priority

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157663494 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach SDIR,

[GitHub] [nuttx-apps] lucasssvaz commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
lucasssvaz commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157663494 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach SDIR,

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #8951: URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157655350 ## sched/semaphore/sem_holder.c: ## @@ -102,21 +102,17 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb) else { serr("ERROR:

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1496467067 > @xiaoxiang781216 do you have any idea how we can debug this? I mean is that an issue of a build system or some interference with compiler version. I never expect that the

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157647208 ## Makefile: ## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach

[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1704: nshlib: Add switchboot command

2023-04-04 Thread via GitHub
xiaoxiang781216 opened a new pull request, #1704: URL: https://github.com/apache/nuttx-apps/pull/1704 ## Summary switchboot Switch to the updated or specified boot system. This command depends on hardware support CONFIG_BOARDCTL_SWITCH_BOOT. `` point to a partion or file

[GitHub] [nuttx] hartmannathan merged pull request #8962: boards: refresh boards that use usbmsc

2023-04-04 Thread via GitHub
hartmannathan merged PR #8962: URL: https://github.com/apache/nuttx/pull/8962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated: boards: refresh boards that use usbmsc

2023-04-04 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 553fe83abf boards: refresh boards that

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157602509 ## fsutils/romloader/README.md: ## @@ -0,0 +1,56 @@ +# ROMLoader + +ROMLoader is a utility application that creates and mounts a ROM File System based on the

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157602509 ## fsutils/romloader/README.md: ## @@ -0,0 +1,56 @@ +# ROMLoader + +ROMLoader is a utility application that creates and mounts a ROM File System based on the

[GitHub] [nuttx-apps] hartmannathan commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
hartmannathan commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157583267 ## fsutils/romloader/README.md: ## @@ -0,0 +1,56 @@ +# ROMLoader + +ROMLoader is a utility application that creates and mounts a ROM File System based on the

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1698: fsutils: Add ROMLoader utility

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157572245 ## fsutils/romloader/.gitignore: ## @@ -0,0 +1,3 @@ +/romfs.img +/rom.c +/rom Review Comment: ```suggestion /rom ``` ##

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8952: boards/stm32: add composite device configurations

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #8952: URL: https://github.com/apache/nuttx/pull/8952#discussion_r1157569097 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_composite.c: ## @@ -0,0 +1,347 @@ +/ + *

[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8949: drivers/video: passthrough unknown ioctl cmd to fb driver

2023-04-04 Thread via GitHub
gustavonihei commented on code in PR #8949: URL: https://github.com/apache/nuttx/pull/8949#discussion_r1157531709 ## drivers/video/fb.c: ## @@ -674,8 +674,15 @@ static int fb_ioctl(FAR struct file *filep, int cmd, unsigned long arg) break; default: -

[nuttx] 03/03: stm32h7/otg: add support for external ULPI

2023-04-04 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 83cdaeb593b18e5bc6e6408059b033e32f8ae498 Author: raiden00pl AuthorDate: Sun Apr 2 13:01:14 2023 +0200 stm32h7/otg:

[nuttx] 01/03: stm32h7: update ULPI pins

2023-04-04 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit d76b7c20ad334c06aa2cc467c5cf183ab61eabe1 Author: raiden00pl AuthorDate: Sat Apr 1 09:08:47 2023 +0200 stm32h7:

[nuttx] branch master updated (84ddfb5455 -> 83cdaeb593)

2023-04-04 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 84ddfb5455 sched/assert: Simplify the fatal detection logic new d76b7c20ad stm32h7: update ULPI pins new

[nuttx] 02/03: stm32h7/rcc: OTGHS ULPI works only in VOS0

2023-04-04 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit f89d2be99f5113794e58e1a354bee9b8ec9ce425 Author: raiden00pl AuthorDate: Sun Apr 2 12:58:57 2023 +0200 stm32h7/rcc:

[GitHub] [nuttx] davids5 merged pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-04 Thread via GitHub
davids5 merged PR #8945: URL: https://github.com/apache/nuttx/pull/8945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx-apps] branch master updated: nshlib/README.md: add uptime command description

2023-04-04 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new f58c87e7e nshlib/README.md: add

[GitHub] [nuttx-apps] hartmannathan merged pull request #1699: nshlib/README.md: add uptime command description

2023-04-04 Thread via GitHub
hartmannathan merged PR #1699: URL: https://github.com/apache/nuttx-apps/pull/1699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] raiden00pl commented on pull request #8952: boards/stm32: add composite device configurations

2023-04-04 Thread via GitHub
raiden00pl commented on PR #8952: URL: https://github.com/apache/nuttx/pull/8952#issuecomment-1496254106 Yes, they were all tested. They are based on the same IP core (dwc2 from Synopsys) and I hoped that one stm32 would work as a composite device. Unfortunately, the main problems were in

[GitHub] [nuttx] davids5 commented on pull request #8952: boards/stm32: add composite device configurations

2023-04-04 Thread via GitHub
davids5 commented on PR #8952: URL: https://github.com/apache/nuttx/pull/8952#issuecomment-1496224839 @raiden00pl Did you rest this on the all the effected HW? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8939: fs: Flush the file system cache in BOARDIOC_POWEROFF too

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8939: URL: https://github.com/apache/nuttx/pull/8939#issuecomment-1496214814 OK, let's remove SYS_DOWN to avoid any potential issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nuttx] hartmannathan commented on pull request #8939: fs: Flush the file system cache in BOARDIOC_POWEROFF too

2023-04-04 Thread via GitHub
hartmannathan commented on PR #8939: URL: https://github.com/apache/nuttx/pull/8939#issuecomment-1496209742 > > `SYS_DOWN` does not need `sync()`? > > `SYS_DOWN` will call `sync()` since it uses the same value as `SYS_RESTART`: > > ```c > #define SYS_RESTART SYS_DOWN

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8956: Let BOARDIOC_SOFTRESETCAUSE_ASSERT equals to the default value of BOARD_ASSERT_RESET_VALUE

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8956: URL: https://github.com/apache/nuttx/pull/8956#issuecomment-1496203140 With this new patch, that patch isn't needed anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nuttx] fjpanag commented on pull request #8939: fs: Flush the file system cache in BOARDIOC_POWEROFF too

2023-04-04 Thread via GitHub
fjpanag commented on PR #8939: URL: https://github.com/apache/nuttx/pull/8939#issuecomment-1496195094 > `SYS_DOWN` does not need `sync()`? `SYS_DOWN` will call `sync()` since it uses the same value as `SYS_RESTART`: ```c #define SYS_RESTART SYS_DOWN ``` But IMO,

[GitHub] [nuttx] hartmannathan commented on pull request #8956: Let BOARDIOC_SOFTRESETCAUSE_ASSERT equals to the default value of BOARD_ASSERT_RESET_VALUE

2023-04-04 Thread via GitHub
hartmannathan commented on PR #8956: URL: https://github.com/apache/nuttx/pull/8956#issuecomment-1496187671 > > This does not solve the probem. > > What's problem? @xiaoxiang781216 I think @davids5 is referring to the comment:

[GitHub] [nuttx] hartmannathan merged pull request #8955: sched/assert: Simplify the fatal detection logic

2023-04-04 Thread via GitHub
hartmannathan merged PR #8955: URL: https://github.com/apache/nuttx/pull/8955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated (4fbf5f7a4b -> 84ddfb5455)

2023-04-04 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4fbf5f7a4b libs/libc: correct config define of arch functions add 84ddfb5455 sched/assert: Simplify the

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8868: fs/hostfs: add sim hostfs path convert

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1496175434 > > > > > > ls /data will report the error. This patch ensures the user get the consistent result regardless he launches the program from anywhere. > > > > > > > > > > >

[GitHub] [nuttx] xiaoxiang781216 closed pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

2023-04-04 Thread via GitHub
xiaoxiang781216 closed pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT URL: https://github.com/apache/nuttx/pull/8940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8940: URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1496136783 > > Ok, I fix the problem with a different method, @davids5 please review this patch: #8956. > > I think I must not be explaining the issues clearly. Let me try again >

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8956: Let BOARDIOC_SOFTRESETCAUSE_ASSERT equals to the default value of BOARD_ASSERT_RESET_VALUE

2023-04-04 Thread via GitHub
xiaoxiang781216 commented on PR #8956: URL: https://github.com/apache/nuttx/pull/8956#issuecomment-1496131051 > This does not solve the probem. What's problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8964: board: define boardioc_softreset_subreason_e in CONFIG_BOARDCTL_RESET

2023-04-04 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8964: URL: https://github.com/apache/nuttx/pull/8964 ## Summary so user could pass boardioc_softreset_subreason_e to board_reset too, found by https://github.com/apache/nuttx-apps/pull/1696 ## Impact minor ## Testing

[GitHub] [nuttx] wengzhe commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

2023-04-04 Thread via GitHub
wengzhe commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157322549 ## libs/libc/string/lib_strerror.c: ## @@ -392,5 +399,12 @@ FAR char *strerror(int errnum) #else UNUSED(errnum); #endif - return "Unknown error"; +#ifdef

[GitHub] [nuttx-apps] Junbo-Zheng commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-04 Thread via GitHub
Junbo-Zheng commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157288783 ## netutils/dhcpd/dhcpd.c: ## @@ -23,6 +23,8 @@ / #ifdef

[GitHub] [nuttx-apps] Junbo-Zheng closed pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-04 Thread via GitHub
Junbo-Zheng closed pull request #1700: Replace OK/ERROR macro with sys/types.h enum URL: https://github.com/apache/nuttx-apps/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nuttx] tmedicci opened a new pull request, #8963: esp32/wifi: Fix Wi-Fi driver parameter settings

2023-04-04 Thread via GitHub
tmedicci opened a new pull request, #8963: URL: https://github.com/apache/nuttx/pull/8963 ## Summary This PR fixes [#7857](https://github.com/apache/nuttx/issues/7857) and [#7193](https://github.com/apache/nuttx/issues/7193) by saving Wi-Fi parameters and setting them at once,

[GitHub] [nuttx] FASTSHIFT commented on a diff in pull request #8961: sim_x11eventloop: fix X11 event accumulation

2023-04-04 Thread via GitHub
FASTSHIFT commented on code in PR #8961: URL: https://github.com/apache/nuttx/pull/8961#discussion_r1157215850 ## arch/sim/src/sim/posix/sim_x11eventloop.c: ## @@ -105,7 +105,7 @@ void sim_x11events(void) /* Check if there are any pending, queue X11 events. */ Review

[GitHub] [nuttx-apps] pkarashchenko commented on pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-04-04 Thread via GitHub
pkarashchenko commented on PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#issuecomment-1495905252 Could you please take a look into CI failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157185299 ## netutils/dhcpd/dhcpd.c: ## @@ -23,6 +23,8 @@ / #ifdef

[nuttx] branch master updated: libs/libc: correct config define of arch functions

2023-04-04 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4fbf5f7a4b libs/libc: correct config

[GitHub] [nuttx] gustavonihei merged pull request #8958: libs/libc: correct config define of arch functions

2023-04-04 Thread via GitHub
gustavonihei merged PR #8958: URL: https://github.com/apache/nuttx/pull/8958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8961: sim_x11eventloop: fix X11 event accumulation

2023-04-04 Thread via GitHub
gustavonihei commented on code in PR #8961: URL: https://github.com/apache/nuttx/pull/8961#discussion_r1157178896 ## arch/sim/src/sim/posix/sim_x11eventloop.c: ## @@ -105,7 +105,7 @@ void sim_x11events(void) /* Check if there are any pending, queue X11 events. */ Review

[GitHub] [nuttx] raiden00pl opened a new pull request, #8962: boards: refresh boards that use usbmsc

2023-04-04 Thread via GitHub
raiden00pl opened a new pull request, #8962: URL: https://github.com/apache/nuttx/pull/8962 ## Summary boards: refresh boards that use usbmsc ## Impact ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1703: system/usbmsc: set stack size to DEFAULT_TASK_STACKSIZE

2023-04-04 Thread via GitHub
raiden00pl opened a new pull request, #1703: URL: https://github.com/apache/nuttx-apps/pull/1703 ## Summary system/usbmsc: set stack size to DEFAULT_TASK_STACKSIZE 768 for stack is too small to work ## Impact ## Testing CI -- This is an automated message from the

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #8951: URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157170933 ## sched/semaphore/sem_holder.c: ## @@ -103,20 +103,18 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb) { serr("ERROR: Insufficient

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #8951: URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157158812 ## sched/semaphore/sem_holder.c: ## @@ -103,20 +103,18 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb) { serr("ERROR: Insufficient

[GitHub] [nuttx] wengzhe commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

2023-04-04 Thread via GitHub
wengzhe commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157148086 ## libs/libc/string/lib_strerror.c: ## @@ -392,5 +399,12 @@ FAR char *strerror(int errnum) #else UNUSED(errnum); #endif - return "Unknown error"; +#ifdef

[GitHub] [nuttx] wengzhe commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

2023-04-04 Thread via GitHub
wengzhe commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157141267 ## libs/libc/netdb/lib_gaistrerror.c: ## @@ -105,5 +116,12 @@ FAR const char *gai_strerror(int errnum) } while (ndxlow <= ndxhi); #endif - return "Unknown

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-04 Thread via GitHub
raiden00pl commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1157139762 ## arch/arm/src/stm32h7/hardware/stm32h7x3xx_pinmap.h: ## @@ -737,20 +737,20 @@ #define GPIO_OTGHS_ID

[GitHub] [nuttx] fjpanag commented on pull request #8943: stm32_eth: Added error handling for abnormal interrupts.

2023-04-04 Thread via GitHub
fjpanag commented on PR #8943: URL: https://github.com/apache/nuttx/pull/8943#issuecomment-1495842857 I am also tempted to rename `stm32_txtimeout_work()` as it now serves two purposes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nuttx] FASTSHIFT opened a new pull request, #8961: sim_x11eventloop: fix X11 event accumulation

2023-04-04 Thread via GitHub
FASTSHIFT opened a new pull request, #8961: URL: https://github.com/apache/nuttx/pull/8961 ## Summary `sim_x11events` should process all x11 events in each event loop, otherwise it will cause events to accumulate in the queue and affect the interaction, as shown in the following

[GitHub] [nuttx] fjpanag commented on a diff in pull request #8943: stm32_eth: Added error handling for abnormal interrupts.

2023-04-04 Thread via GitHub
fjpanag commented on code in PR #8943: URL: https://github.com/apache/nuttx/pull/8943#discussion_r1157130474 ## arch/arm/src/stm32/stm32_eth.c: ## @@ -2027,17 +2027,13 @@ static void stm32_interrupt_work(void *arg) stm32_putreg(ETH_DMAINT_NIS, STM32_ETH_DMASR); }

[GitHub] [nuttx-apps] Junbo-Zheng commented on a diff in pull request #1700: Replace OK/ERROR macro with sys/types.h enum

2023-04-04 Thread via GitHub
Junbo-Zheng commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157121311 ## system/zmodem/host/nuttx/config.h: ## @@ -34,8 +36,6 @@ /* Environment stuff */ -#define OK 0 -#define ERROR -1 Review Comment: > shold we keep

[GitHub] [nuttx] ALTracer commented on pull request #8906: MiniF4 peripherals support improvements

2023-04-04 Thread via GitHub
ALTracer commented on PR #8906: URL: https://github.com/apache/nuttx/pull/8906#issuecomment-1495794851 @pkarashchenko I rewrote the `stm32_composite.c` slightly, including your change, n/dev_idx rename and moving inline commits below the 80 char limit. Consider reviewing if necessary.

[GitHub] [nuttx] davids5 commented on pull request #8922: eMMC driver support

2023-04-04 Thread via GitHub
davids5 commented on PR #8922: URL: https://github.com/apache/nuttx/pull/8922#issuecomment-1495789587 @radek-pesina Have you tested both 1 bit, 4 bit on non MMC hw? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nuttx] davids5 commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-04 Thread via GitHub
davids5 commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1157090661 ## arch/arm/src/stm32h7/hardware/stm32h7x3xx_pinmap.h: ## @@ -737,20 +737,20 @@ #define GPIO_OTGHS_ID

[GitHub] [nuttx] davids5 commented on a diff in pull request #8945: stm32h7/otg: support for OTG HS external ULPI

2023-04-04 Thread via GitHub
davids5 commented on code in PR #8945: URL: https://github.com/apache/nuttx/pull/8945#discussion_r1157090661 ## arch/arm/src/stm32h7/hardware/stm32h7x3xx_pinmap.h: ## @@ -737,20 +737,20 @@ #define GPIO_OTGHS_ID

[GitHub] [nuttx] davids5 commented on a diff in pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
davids5 commented on code in PR #8951: URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157074834 ## sched/semaphore/sem_holder.c: ## @@ -103,20 +103,18 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb) { serr("ERROR: Insufficient pre-allocated

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

2023-04-04 Thread via GitHub
pkarashchenko commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157076843 ## libs/libc/string/lib_strerror.c: ## @@ -392,5 +399,12 @@ FAR char *strerror(int errnum) #else UNUSED(errnum); #endif - return "Unknown error"; +#ifdef

[nuttx-apps] branch master updated (c694d8d90 -> 49418d6de)

2023-04-04 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from c694d8d90 system/composite_main.c: Convert fprintf -> dprintf add 4f7dd7be7 nshlib: Add boot command

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1697: nshlib: Add boot command

2023-04-04 Thread via GitHub
pkarashchenko merged PR #1697: URL: https://github.com/apache/nuttx-apps/pull/1697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] pkarashchenko opened a new issue, #8960: Code does not rebuild properly after 'make menuconfig'

2023-04-04 Thread via GitHub
pkarashchenko opened a new issue, #8960: URL: https://github.com/apache/nuttx/issues/8960 Initially observed during testing of https://github.com/apache/nuttx/pull/8951 Steps to reproduce: 1. `tools/configure.sh spresense:smp` 2. `make menuconfig` -> set

[GitHub] [nuttx-apps] pussuw commented on pull request #1702: nsh/nsh_parse: Fix handling of back-quotes

2023-04-04 Thread via GitHub
pussuw commented on PR #1702: URL: https://github.com/apache/nuttx-apps/pull/1702#issuecomment-1495752877 Seems like github wants to re-format the back-quotes from the PR title. The commit message has the correct description. -- This is an automated message from the Apache Git Service.

[GitHub] [nuttx-apps] pussuw opened a new pull request, #1702: nsh/nsh_parse: Fix handling of back-quotes

2023-04-04 Thread via GitHub
pussuw opened a new pull request, #1702: URL: https://github.com/apache/nuttx-apps/pull/1702 ## Summary The logic that handles back-quotes was faulty, i.e. example command set FOO `ls -l` would be split into two tokens as follows: - set FOO `ls - -l` This results in nsh:

[GitHub] [nuttx] pkarashchenko commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
pkarashchenko commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495745894 I will fill a ticket related to build problem. Anyway it is not directly related to this PR -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [nuttx] davids5 commented on pull request #8940: assert: Replace CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT

2023-04-04 Thread via GitHub
davids5 commented on PR #8940: URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1495682152 > Ok, I fix the problem with a different method, @davids5 please review this patch: #8956. I think I must not be explaining the issues clearly. Let me try again We had a

[GitHub] [nuttx] pkarashchenko commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
pkarashchenko commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495592669 @xiaoxiang781216 do you have any idea how we can debug this? I mean is that an issue of a build system or some interference with compiler version. -- This is an automated message

[GitHub] [nuttx] pkarashchenko commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
pkarashchenko commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495587971 @masayuki2009 seems like we have some issue with the build system. The map file generated after `make menuconfig` and after `make clean` with the sam config are different (and

[GitHub] [nuttx] masayuki2009 commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
masayuki2009 commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495585959 >It is strange. I just rebuilt the code and can't reproduce the crash. I will do more experiments. @pkarashchenko I tried this PR with ``` ---

[GitHub] [nuttx] GooTal opened a new issue, #8959: Enabling sinfo printing and disabling CONFIG_SYSLOG_TIMESTAMP_REALTIME caused a recursive calling bug?

2023-04-04 Thread via GitHub
GooTal opened a new issue, #8959: URL: https://github.com/apache/nuttx/issues/8959 I enabled sinfo printing: ![图片](https://user-images.githubusercontent.com/40800103/229732968-65422dbe-1ae7-4bd5-a722-ff7e2e28a15a.png) I found that sinfo called nx_vsyslog, then called clock_gettime

[GitHub] [nuttx] pkarashchenko commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
pkarashchenko commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495548897 > > Just reproduced the crash > > @pkarashchenko What version of the arm gcc are you using? `arm-none-eabi-gcc (Arm GNU Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1

[GitHub] [nuttx] masayuki2009 commented on pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

2023-04-04 Thread via GitHub
masayuki2009 commented on PR #8951: URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495545586 > Just reproduced the crash @pkarashchenko What version of the arm gcc are you using? -- This is an automated message from the Apache Git Service. To respond to the

  1   2   >