xiaoxiang781216 commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1158052306
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach
xiaoxiang781216 commented on PR #8937:
URL: https://github.com/apache/nuttx/pull/8937#issuecomment-1496952148
> > But, this change doesn't work for SMP, and the thread may suspend and
switch to new thread even you hold critical section since the thread may block
self or wake high priority
yamt commented on PR #8868:
URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1496884086
> > > > > > > ls /data will report the error. This patch ensures the user
get the consistent result regardless he launches the program from anywhere.
> > > > > >
> > > > > >
> > > >
dishilov commented on issue #8933:
URL: https://github.com/apache/nuttx/issues/8933#issuecomment-1496804311
@acassis @laoniaokkk I was under impression the 'df' command has nothing to
do with file sizes and is used to display volume information - which it does
correctly when used without
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
from f58c87e7e nshlib/README.md: add uptime command description
add b93aa0cb8 ostest: Fixed use of
pkarashchenko merged PR #1705:
URL: https://github.com/apache/nuttx-apps/pull/1705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pkarashchenko commented on PR #8965:
URL: https://github.com/apache/nuttx/pull/8965#issuecomment-1496778255
This change might be not needed with
https://github.com/apache/nuttx/pull/8951 as pid hash table will not be
accessed there. This is just FYI.
--
This is an automated message from
acassis commented on issue #8933:
URL: https://github.com/apache/nuttx/issues/8933#issuecomment-1496776044
Good point @laoniaokkk it is not a BUG! Maybe we should select FS_LARGEFILE
automatically when enabling SD/MMC driver because probably most of users will
be using a SDCard bigger than
acassis opened a new issue, #8966:
URL: https://github.com/apache/nuttx/issues/8966
I decide to test NuttX running it in the first board that I used almost 13
years ago, more info here:
https://acassis.wordpress.com/2023/04/01/testing-nuttx-again-on-olimex-lpc2378-stk-board/
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 152d8984 Publishing web:
patacongo merged PR #8965:
URL: https://github.com/apache/nuttx/pull/8965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 553fe83abf boards: refresh boards that use usbmsc
add 95af4b35cf Fixed improper access of g_pidhash.
No new
fjpanag opened a new pull request, #1705:
URL: https://github.com/apache/nuttx-apps/pull/1705
## Summary
Fixes an uninitialized variable in ostest (and stops the corresponding
compiler warning).
## Impact
Bug fix.
## Testing
Build test.
--
This is
fjpanag commented on code in PR #8965:
URL: https://github.com/apache/nuttx/pull/8965#discussion_r1157807727
##
sched/task/task_setup.c:
##
@@ -83,6 +83,7 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb)
FAR struct tcb_s **pidhash;
pid_t next_pid;
int hash_ndx;
patacongo commented on code in PR #8965:
URL: https://github.com/apache/nuttx/pull/8965#discussion_r1157801931
##
sched/task/task_setup.c:
##
@@ -83,6 +83,7 @@ static int nxtask_assign_pid(FAR struct tcb_s *tcb)
FAR struct tcb_s **pidhash;
pid_t next_pid;
int
fjpanag opened a new pull request, #8965:
URL: https://github.com/apache/nuttx/pull/8965
## Summary
Fixes potential garbage access to `g_pidhash`.
Also see [here](https://lists.apache.org/list.html?d...@nuttx.apache.org).
## Impact
Bug fix.
## Testing
fjpanag commented on PR #8937:
URL: https://github.com/apache/nuttx/pull/8937#issuecomment-1496593341
> But, this change doesn't work for SMP, and the thread may suspend and
switch to new thread even you hold critical section since the thread may block
self or wake high priority thread
tmedicci commented on PR #8926:
URL: https://github.com/apache/nuttx/pull/8926#issuecomment-1496554989
Converted to Draft to run more testing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lucasssvaz commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157706422
##
fsutils/romloader/Makefile:
##
@@ -0,0 +1,106 @@
+
+#
lucasssvaz commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157703592
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach SDIR,
xiaoxiang781216 commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157692604
##
fsutils/romloader/Makefile:
##
@@ -0,0 +1,106 @@
+
+#
xiaoxiang781216 commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157687516
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach
xiaoxiang781216 commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157687516
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach
xiaoxiang781216 commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1496486630
Please revert https://github.com/apache/nuttx/pull/8938 and apply your
change after it.
--
This is an automated message from the Apache Git Service.
To respond to the message,
xiaoxiang781216 commented on PR #8937:
URL: https://github.com/apache/nuttx/pull/8937#issuecomment-1496480193
But, this change doesn't work for SMP, and the thread may suspend and switch
to new thread even you hold critical section since the thread may block self or
wake high priority
lucasssvaz commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157663494
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach SDIR,
lucasssvaz commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157663494
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach SDIR,
xiaoxiang781216 commented on code in PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157655350
##
sched/semaphore/sem_holder.c:
##
@@ -102,21 +102,17 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb)
else
{
serr("ERROR:
xiaoxiang781216 commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1496467067
> @xiaoxiang781216 do you have any idea how we can debug this? I mean is
that an issue of a build system or some interference with compiler version.
I never expect that the
xiaoxiang781216 commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157647208
##
Makefile:
##
@@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
-$(BIN): $(foreach
xiaoxiang781216 opened a new pull request, #1704:
URL: https://github.com/apache/nuttx-apps/pull/1704
## Summary
switchboot
Switch to the updated or specified boot system. This command depends on
hardware support CONFIG_BOARDCTL_SWITCH_BOOT. `` point to a partion
or file
hartmannathan merged PR #8962:
URL: https://github.com/apache/nuttx/pull/8962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 553fe83abf boards: refresh boards that
pkarashchenko commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157602509
##
fsutils/romloader/README.md:
##
@@ -0,0 +1,56 @@
+# ROMLoader
+
+ROMLoader is a utility application that creates and mounts a ROM File System
based on the
pkarashchenko commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157602509
##
fsutils/romloader/README.md:
##
@@ -0,0 +1,56 @@
+# ROMLoader
+
+ROMLoader is a utility application that creates and mounts a ROM File System
based on the
hartmannathan commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157583267
##
fsutils/romloader/README.md:
##
@@ -0,0 +1,56 @@
+# ROMLoader
+
+ROMLoader is a utility application that creates and mounts a ROM File System
based on the
pkarashchenko commented on code in PR #1698:
URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1157572245
##
fsutils/romloader/.gitignore:
##
@@ -0,0 +1,3 @@
+/romfs.img
+/rom.c
+/rom
Review Comment:
```suggestion
/rom
```
##
pkarashchenko commented on code in PR #8952:
URL: https://github.com/apache/nuttx/pull/8952#discussion_r1157569097
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_composite.c:
##
@@ -0,0 +1,347 @@
+/
+ *
gustavonihei commented on code in PR #8949:
URL: https://github.com/apache/nuttx/pull/8949#discussion_r1157531709
##
drivers/video/fb.c:
##
@@ -674,8 +674,15 @@ static int fb_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
break;
default:
-
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 83cdaeb593b18e5bc6e6408059b033e32f8ae498
Author: raiden00pl
AuthorDate: Sun Apr 2 13:01:14 2023 +0200
stm32h7/otg:
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit d76b7c20ad334c06aa2cc467c5cf183ab61eabe1
Author: raiden00pl
AuthorDate: Sat Apr 1 09:08:47 2023 +0200
stm32h7:
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 84ddfb5455 sched/assert: Simplify the fatal detection logic
new d76b7c20ad stm32h7: update ULPI pins
new
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit f89d2be99f5113794e58e1a354bee9b8ec9ce425
Author: raiden00pl
AuthorDate: Sun Apr 2 12:58:57 2023 +0200
stm32h7/rcc:
davids5 merged PR #8945:
URL: https://github.com/apache/nuttx/pull/8945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new f58c87e7e nshlib/README.md: add
hartmannathan merged PR #1699:
URL: https://github.com/apache/nuttx-apps/pull/1699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
raiden00pl commented on PR #8952:
URL: https://github.com/apache/nuttx/pull/8952#issuecomment-1496254106
Yes, they were all tested. They are based on the same IP core (dwc2 from
Synopsys) and I hoped that one stm32 would work as a composite device.
Unfortunately, the main problems were in
davids5 commented on PR #8952:
URL: https://github.com/apache/nuttx/pull/8952#issuecomment-1496224839
@raiden00pl Did you rest this on the all the effected HW?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 commented on PR #8939:
URL: https://github.com/apache/nuttx/pull/8939#issuecomment-1496214814
OK, let's remove SYS_DOWN to avoid any potential issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hartmannathan commented on PR #8939:
URL: https://github.com/apache/nuttx/pull/8939#issuecomment-1496209742
> > `SYS_DOWN` does not need `sync()`?
>
> `SYS_DOWN` will call `sync()` since it uses the same value as
`SYS_RESTART`:
>
> ```c
> #define SYS_RESTART SYS_DOWN
xiaoxiang781216 commented on PR #8956:
URL: https://github.com/apache/nuttx/pull/8956#issuecomment-1496203140
With this new patch, that patch isn't needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
fjpanag commented on PR #8939:
URL: https://github.com/apache/nuttx/pull/8939#issuecomment-1496195094
> `SYS_DOWN` does not need `sync()`?
`SYS_DOWN` will call `sync()` since it uses the same value as `SYS_RESTART`:
```c
#define SYS_RESTART SYS_DOWN
```
But IMO,
hartmannathan commented on PR #8956:
URL: https://github.com/apache/nuttx/pull/8956#issuecomment-1496187671
> > This does not solve the probem.
>
> What's problem?
@xiaoxiang781216 I think @davids5 is referring to the comment:
hartmannathan merged PR #8955:
URL: https://github.com/apache/nuttx/pull/8955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
hartmannathan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 4fbf5f7a4b libs/libc: correct config define of arch functions
add 84ddfb5455 sched/assert: Simplify the
xiaoxiang781216 commented on PR #8868:
URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1496175434
> > > > > > ls /data will report the error. This patch ensures the user get
the consistent result regardless he launches the program from anywhere.
> > > > >
> > > > >
>
xiaoxiang781216 closed pull request #8940: assert: Replace
CONFIG_BOARD_ASSERT_RESET_VALUE with BOARDIOC_SOFTRESETCAUSE_ASSERT
URL: https://github.com/apache/nuttx/pull/8940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiaoxiang781216 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1496136783
> > Ok, I fix the problem with a different method, @davids5 please review
this patch: #8956.
>
> I think I must not be explaining the issues clearly. Let me try again
>
xiaoxiang781216 commented on PR #8956:
URL: https://github.com/apache/nuttx/pull/8956#issuecomment-1496131051
> This does not solve the probem.
What's problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xiaoxiang781216 opened a new pull request, #8964:
URL: https://github.com/apache/nuttx/pull/8964
## Summary
so user could pass boardioc_softreset_subreason_e to board_reset too, found
by https://github.com/apache/nuttx-apps/pull/1696
## Impact
minor
## Testing
wengzhe commented on code in PR #8946:
URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157322549
##
libs/libc/string/lib_strerror.c:
##
@@ -392,5 +399,12 @@ FAR char *strerror(int errnum)
#else
UNUSED(errnum);
#endif
- return "Unknown error";
+#ifdef
Junbo-Zheng commented on code in PR #1700:
URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157288783
##
netutils/dhcpd/dhcpd.c:
##
@@ -23,6 +23,8 @@
/
#ifdef
Junbo-Zheng closed pull request #1700: Replace OK/ERROR macro with sys/types.h
enum
URL: https://github.com/apache/nuttx-apps/pull/1700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tmedicci opened a new pull request, #8963:
URL: https://github.com/apache/nuttx/pull/8963
## Summary
This PR fixes [#7857](https://github.com/apache/nuttx/issues/7857) and
[#7193](https://github.com/apache/nuttx/issues/7193) by saving Wi-Fi parameters
and setting them at once,
FASTSHIFT commented on code in PR #8961:
URL: https://github.com/apache/nuttx/pull/8961#discussion_r1157215850
##
arch/sim/src/sim/posix/sim_x11eventloop.c:
##
@@ -105,7 +105,7 @@ void sim_x11events(void)
/* Check if there are any pending, queue X11 events. */
Review
pkarashchenko commented on PR #1623:
URL: https://github.com/apache/nuttx-apps/pull/1623#issuecomment-1495905252
Could you please take a look into CI failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pkarashchenko commented on code in PR #1700:
URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157185299
##
netutils/dhcpd/dhcpd.c:
##
@@ -23,6 +23,8 @@
/
#ifdef
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4fbf5f7a4b libs/libc: correct config
gustavonihei merged PR #8958:
URL: https://github.com/apache/nuttx/pull/8958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gustavonihei commented on code in PR #8961:
URL: https://github.com/apache/nuttx/pull/8961#discussion_r1157178896
##
arch/sim/src/sim/posix/sim_x11eventloop.c:
##
@@ -105,7 +105,7 @@ void sim_x11events(void)
/* Check if there are any pending, queue X11 events. */
Review
raiden00pl opened a new pull request, #8962:
URL: https://github.com/apache/nuttx/pull/8962
## Summary
boards: refresh boards that use usbmsc
## Impact
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
raiden00pl opened a new pull request, #1703:
URL: https://github.com/apache/nuttx-apps/pull/1703
## Summary
system/usbmsc: set stack size to DEFAULT_TASK_STACKSIZE
768 for stack is too small to work
## Impact
## Testing
CI
--
This is an automated message from the
pkarashchenko commented on code in PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157170933
##
sched/semaphore/sem_holder.c:
##
@@ -103,20 +103,18 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb)
{
serr("ERROR: Insufficient
pkarashchenko commented on code in PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157158812
##
sched/semaphore/sem_holder.c:
##
@@ -103,20 +103,18 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb)
{
serr("ERROR: Insufficient
wengzhe commented on code in PR #8946:
URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157148086
##
libs/libc/string/lib_strerror.c:
##
@@ -392,5 +399,12 @@ FAR char *strerror(int errnum)
#else
UNUSED(errnum);
#endif
- return "Unknown error";
+#ifdef
wengzhe commented on code in PR #8946:
URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157141267
##
libs/libc/netdb/lib_gaistrerror.c:
##
@@ -105,5 +116,12 @@ FAR const char *gai_strerror(int errnum)
}
while (ndxlow <= ndxhi);
#endif
- return "Unknown
raiden00pl commented on code in PR #8945:
URL: https://github.com/apache/nuttx/pull/8945#discussion_r1157139762
##
arch/arm/src/stm32h7/hardware/stm32h7x3xx_pinmap.h:
##
@@ -737,20 +737,20 @@
#define GPIO_OTGHS_ID
fjpanag commented on PR #8943:
URL: https://github.com/apache/nuttx/pull/8943#issuecomment-1495842857
I am also tempted to rename `stm32_txtimeout_work()` as it now serves two
purposes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
FASTSHIFT opened a new pull request, #8961:
URL: https://github.com/apache/nuttx/pull/8961
## Summary
`sim_x11events` should process all x11 events in each event loop, otherwise
it will cause events to accumulate in the queue and affect the interaction, as
shown in the following
fjpanag commented on code in PR #8943:
URL: https://github.com/apache/nuttx/pull/8943#discussion_r1157130474
##
arch/arm/src/stm32/stm32_eth.c:
##
@@ -2027,17 +2027,13 @@ static void stm32_interrupt_work(void *arg)
stm32_putreg(ETH_DMAINT_NIS, STM32_ETH_DMASR);
}
Junbo-Zheng commented on code in PR #1700:
URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157121311
##
system/zmodem/host/nuttx/config.h:
##
@@ -34,8 +36,6 @@
/* Environment stuff */
-#define OK 0
-#define ERROR -1
Review Comment:
> shold we keep
ALTracer commented on PR #8906:
URL: https://github.com/apache/nuttx/pull/8906#issuecomment-1495794851
@pkarashchenko I rewrote the `stm32_composite.c` slightly, including your
change, n/dev_idx rename and moving inline commits below the 80 char limit.
Consider reviewing if necessary.
davids5 commented on PR #8922:
URL: https://github.com/apache/nuttx/pull/8922#issuecomment-1495789587
@radek-pesina Have you tested both 1 bit, 4 bit on non MMC hw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
davids5 commented on code in PR #8945:
URL: https://github.com/apache/nuttx/pull/8945#discussion_r1157090661
##
arch/arm/src/stm32h7/hardware/stm32h7x3xx_pinmap.h:
##
@@ -737,20 +737,20 @@
#define GPIO_OTGHS_ID
davids5 commented on code in PR #8945:
URL: https://github.com/apache/nuttx/pull/8945#discussion_r1157090661
##
arch/arm/src/stm32h7/hardware/stm32h7x3xx_pinmap.h:
##
@@ -737,20 +737,20 @@
#define GPIO_OTGHS_ID
davids5 commented on code in PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157074834
##
sched/semaphore/sem_holder.c:
##
@@ -103,20 +103,18 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb)
{
serr("ERROR: Insufficient pre-allocated
pkarashchenko commented on code in PR #8946:
URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157076843
##
libs/libc/string/lib_strerror.c:
##
@@ -392,5 +399,12 @@ FAR char *strerror(int errnum)
#else
UNUSED(errnum);
#endif
- return "Unknown error";
+#ifdef
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
from c694d8d90 system/composite_main.c: Convert fprintf -> dprintf
add 4f7dd7be7 nshlib: Add boot command
pkarashchenko merged PR #1697:
URL: https://github.com/apache/nuttx-apps/pull/1697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pkarashchenko opened a new issue, #8960:
URL: https://github.com/apache/nuttx/issues/8960
Initially observed during testing of
https://github.com/apache/nuttx/pull/8951
Steps to reproduce:
1. `tools/configure.sh spresense:smp`
2. `make menuconfig` -> set
pussuw commented on PR #1702:
URL: https://github.com/apache/nuttx-apps/pull/1702#issuecomment-1495752877
Seems like github wants to re-format the back-quotes from the PR title. The
commit message has the correct description.
--
This is an automated message from the Apache Git Service.
pussuw opened a new pull request, #1702:
URL: https://github.com/apache/nuttx-apps/pull/1702
## Summary
The logic that handles back-quotes was faulty, i.e. example command
set FOO `ls -l` would be split into two tokens as follows:
- set FOO `ls
- -l`
This results in nsh:
pkarashchenko commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495745894
I will fill a ticket related to build problem. Anyway it is not directly
related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message,
davids5 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1495682152
> Ok, I fix the problem with a different method, @davids5 please review this
patch: #8956.
I think I must not be explaining the issues clearly. Let me try again
We had a
pkarashchenko commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495592669
@xiaoxiang781216 do you have any idea how we can debug this? I mean is that
an issue of a build system or some interference with compiler version.
--
This is an automated message
pkarashchenko commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495587971
@masayuki2009 seems like we have some issue with the build system. The map
file generated after `make menuconfig` and after `make clean` with the sam
config are different (and
masayuki2009 commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495585959
>It is strange. I just rebuilt the code and can't reproduce the crash. I
will do more experiments.
@pkarashchenko
I tried this PR with
```
---
GooTal opened a new issue, #8959:
URL: https://github.com/apache/nuttx/issues/8959
I enabled sinfo printing:
![图片](https://user-images.githubusercontent.com/40800103/229732968-65422dbe-1ae7-4bd5-a722-ff7e2e28a15a.png)
I found that sinfo called nx_vsyslog, then called clock_gettime
pkarashchenko commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495548897
> > Just reproduced the crash
>
> @pkarashchenko What version of the arm gcc are you using?
`arm-none-eabi-gcc (Arm GNU Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1
masayuki2009 commented on PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#issuecomment-1495545586
> Just reproduced the crash
@pkarashchenko
What version of the arm gcc are you using?
--
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 107 matches
Mail list logo