[GitHub] [nuttx] jturnsek commented on a diff in pull request #9024: i.MX RT FlexIO support

2023-04-20 Thread via GitHub
jturnsek commented on code in PR #9024: URL: https://github.com/apache/nuttx/pull/9024#discussion_r1172165894 ## arch/arm/src/imxrt/imxrt_flexio.c: ## @@ -0,0 +1,851 @@ +/ + * arch/arm/src/imxrt/imxrt_fl

[GitHub] [nuttx] pkarashchenko opened a new pull request, #9054: boards/lm3s6432-s2e: reduce size of NSH configuration binary

2023-04-20 Thread via GitHub
pkarashchenko opened a new pull request, #9054: URL: https://github.com/apache/nuttx/pull/9054 ## Summary Reduce size of NSH configuration binary by disabling environment variable support and System V message queue support ## Impact Make CI mighty again ## Testing Pass

[GitHub] [nuttx] wengzhe commented on pull request #9041: net/tcp: Fix clear condition in ofoseg input

2023-04-20 Thread via GitHub
wengzhe commented on PR #9041: URL: https://github.com/apache/nuttx/pull/9041#issuecomment-1515913562 > @wengzhe please explain the issue you were facing (like you started to do in the Testing comment: "We have a case that an http server gives an out-of-ordered ACK, and triggers problem on

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9026: i.mx6 with ar8031

2023-04-20 Thread via GitHub
pkarashchenko commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1172228877 ## include/nuttx/net/mii.h: ## @@ -841,6 +845,17 @@ #define MII_DP83848C_FHF_INT_EN (1 << 1) /* Enable Interrupt on False Carrier Counter Register half-ful

[GitHub] [nuttx] davids5 commented on a diff in pull request #9024: i.MX RT FlexIO support

2023-04-20 Thread via GitHub
davids5 commented on code in PR #9024: URL: https://github.com/apache/nuttx/pull/9024#discussion_r1172247895 ## arch/arm/src/imxrt/hardware/imxrt_flexio.h: ## @@ -0,0 +1,677 @@ +/ + * arch/arm/src/imxrt/

[GitHub] [nuttx] jturnsek commented on a diff in pull request #9024: i.MX RT FlexIO support

2023-04-20 Thread via GitHub
jturnsek commented on code in PR #9024: URL: https://github.com/apache/nuttx/pull/9024#discussion_r1172254033 ## arch/arm/src/imxrt/hardware/imxrt_flexio.h: ## @@ -0,0 +1,677 @@ +/ + * arch/arm/src/imxrt

[GitHub] [nuttx] jturnsek commented on a diff in pull request #9024: i.MX RT FlexIO support

2023-04-20 Thread via GitHub
jturnsek commented on code in PR #9024: URL: https://github.com/apache/nuttx/pull/9024#discussion_r1172254033 ## arch/arm/src/imxrt/hardware/imxrt_flexio.h: ## @@ -0,0 +1,677 @@ +/ + * arch/arm/src/imxrt

[GitHub] [nuttx] davids5 commented on a diff in pull request #9019: arch/arm: change up_saveusercontext to assembly code

2023-04-20 Thread via GitHub
davids5 commented on code in PR #9019: URL: https://github.com/apache/nuttx/pull/9019#discussion_r1172271476 ## arch/arm/src/armv6-m/arm_saveusercontext.S: ## @@ -0,0 +1,108 @@ +/ + * arch/arm/src/armv6-

[GitHub] [nuttx] davids5 commented on a diff in pull request #8743: nxmutex: mutex priority inheritance optimization

2023-04-20 Thread via GitHub
davids5 commented on code in PR #8743: URL: https://github.com/apache/nuttx/pull/8743#discussion_r1172275393 ## include/semaphore.h: ## @@ -113,7 +113,7 @@ struct sem_s # if CONFIG_SEM_PREALLOCHOLDERS > 0 FAR struct semholder_s *hhead; /* List of holders of semaphore counts

[GitHub] [nuttx] pkarashchenko commented on pull request #9002: sched/pthread: repalce sched_lock to enter_critical_section

2023-04-20 Thread via GitHub
pkarashchenko commented on PR #9002: URL: https://github.com/apache/nuttx/pull/9002#issuecomment-151591 Can issue be easily reproduced? What are the steps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [nuttx] davids5 commented on pull request #9049: tty:support tty c_cc VMIN & VTIME

2023-04-20 Thread via GitHub
davids5 commented on PR #9049: URL: https://github.com/apache/nuttx/pull/9049#issuecomment-1515967692 >Impact >Noting,if use termos,to pay attention to whether to set VMIN and VTIME That there is a code size and ram size change unless this has a Kconfig knob. What is it? -- This

[GitHub] [nuttx] zyfeier commented on a diff in pull request #9019: arch/arm: change up_saveusercontext to assembly code

2023-04-20 Thread via GitHub
zyfeier commented on code in PR #9019: URL: https://github.com/apache/nuttx/pull/9019#discussion_r1172299455 ## arch/arm/src/armv6-m/arm_saveusercontext.S: ## @@ -0,0 +1,108 @@ +/ + * arch/arm/src/armv6-

[GitHub] [nuttx] anjiahao1 commented on pull request #9049: tty:support tty c_cc VMIN & VTIME

2023-04-20 Thread via GitHub
anjiahao1 commented on PR #9049: URL: https://github.com/apache/nuttx/pull/9049#issuecomment-1516000751 > > Impact > > Noting,if use termos,to pay attention to whether to set VMIN and VTIME > > That there is a code size and ram size change unless this has a Kconfig knob. What is it

[GitHub] [nuttx] anjiahao1 commented on pull request #9049: tty:support tty c_cc VMIN & VTIME

2023-04-20 Thread via GitHub
anjiahao1 commented on PR #9049: URL: https://github.com/apache/nuttx/pull/9049#issuecomment-1516002103 The posix standard stipulates a minimum value that accepts data and returns instead of returning data. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [nuttx] TimJTi commented on pull request #8479: Fix sam_udphs to allow RNDIS to work

2023-04-20 Thread via GitHub
TimJTi commented on PR #8479: URL: https://github.com/apache/nuttx/pull/8479#issuecomment-1516025652 @baggio63446333 - standard Windows driver (win11). I used the default NuttX VID and PID and also my own with no difference. Is this on SAMA5? If not, it is highly likely the issue is v

[nuttx] branch master updated: boards/lm3s6432-s2e: reduce size of NSH configuration binary

2023-04-20 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new ff376ceb1f boards/lm3s6432-s2e: reduce size of N

[GitHub] [nuttx] davids5 merged pull request #9054: boards/lm3s6432-s2e: reduce size of NSH configuration binary

2023-04-20 Thread via GitHub
davids5 merged PR #9054: URL: https://github.com/apache/nuttx/pull/9054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] davids5 commented on a diff in pull request #9019: arch/arm: change up_saveusercontext to assembly code

2023-04-20 Thread via GitHub
davids5 commented on code in PR #9019: URL: https://github.com/apache/nuttx/pull/9019#discussion_r1172360505 ## arch/arm/src/armv6-m/arm_saveusercontext.S: ## @@ -0,0 +1,108 @@ +/ + * arch/arm/src/armv6-

[GitHub] [nuttx] davids5 commented on pull request #9019: arch/arm: change up_saveusercontext to assembly code

2023-04-20 Thread via GitHub
davids5 commented on PR #9019: URL: https://github.com/apache/nuttx/pull/9019#issuecomment-1516048089 @masayuki2009 Any feedback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [nuttx] davids5 commented on pull request #9051: mempool:fix bug, use incorrect free in mempool init

2023-04-20 Thread via GitHub
davids5 commented on PR #9051: URL: https://github.com/apache/nuttx/pull/9051#issuecomment-1516051234 @anjiahao1 Please rebase to fix CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [nuttx] davids5 commented on a diff in pull request #9024: i.MX RT FlexIO support

2023-04-20 Thread via GitHub
davids5 commented on code in PR #9024: URL: https://github.com/apache/nuttx/pull/9024#discussion_r1172371271 ## arch/arm/src/imxrt/hardware/imxrt_flexio.h: ## @@ -0,0 +1,677 @@ +/ + * arch/arm/src/imxrt/

[GitHub] [nuttx] jturnsek commented on a diff in pull request #9024: i.MX RT FlexIO support

2023-04-20 Thread via GitHub
jturnsek commented on code in PR #9024: URL: https://github.com/apache/nuttx/pull/9024#discussion_r1172400915 ## arch/arm/src/imxrt/hardware/imxrt_flexio.h: ## @@ -0,0 +1,677 @@ +/ + * arch/arm/src/imxrt

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1718: netutils/iperf: Support local/RPMsg socket test

2023-04-20 Thread via GitHub
pkarashchenko commented on code in PR #1718: URL: https://github.com/apache/nuttx-apps/pull/1718#discussion_r1172415878 ## netutils/iperf/iperf.c: ## @@ -77,6 +79,12 @@ struct iperf_udp_pkt_t uint32_t usec; }; +typedef CODE int (*iperf_client_func_t)(FAR struct iperf_ctrl_

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9045: drivers/video: Support spot position setting

2023-04-20 Thread via GitHub
pkarashchenko commented on code in PR #9045: URL: https://github.com/apache/nuttx/pull/9045#discussion_r1172422327 ## drivers/video/isx012.c: ## @@ -1981,6 +1995,70 @@ static int isx012_get_supported_value(FAR struct imgsensor_s *sensor, return ret; } +static void get_cur

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
pkarashchenko commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172450737 ## graphics/twm4nx/src/cresize.cxx: ## @@ -424,8 +426,8 @@ void CResize::updateSizeLabel(FAR struct nxgl_size_s &windowSize) } FAR char *str; - asp

[GitHub] [nuttx] pussuw opened a new pull request, #9055: mm/mm_map: Give the mm_map as parameter to the mm_map functions

2023-04-20 Thread via GitHub
pussuw opened a new pull request, #9055: URL: https://github.com/apache/nuttx/pull/9055 ## Summary This way the mappings can be modified for any vm area, not only the process that is running. Why? This allows mapping pages to kernel dynamically, this functionality will be presente

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172763218 ## netutils/ftpc/ftpc_transfer.c: ## @@ -247,7 +247,10 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else if (relpath[1] == '/')

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172764901 ## graphics/twm4nx/src/ctwm4nx.cxx: ## @@ -382,7 +382,10 @@ void CTwm4Nx::genMqName(void) unsigned long randvalue = (unsigned long)std::random() & 0x00ff

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172766445 ## netutils/ftpc/ftpc_transfer.c: ## @@ -264,7 +267,10 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else if (strncmp(relpath, "./", 2)

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172766891 ## netutils/ftpc/ftpc_transfer.c: ## @@ -278,7 +284,10 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else { - asprintf(&ptr, "

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172772865 ## graphics/twm4nx/src/cresize.cxx: ## @@ -424,8 +426,8 @@ void CResize::updateSizeLabel(FAR struct nxgl_size_s &windowSize) } FAR char *str; - asprintf(

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172773713 ## system/critmon/critmon.c: ## @@ -136,11 +135,9 @@ static int critmon_process_directory(FAR struct dirent *entryp) entryp->d_name); if (ret <

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172774118 ## system/critmon/critmon.c: ## @@ -189,10 +186,8 @@ static int critmon_process_directory(FAR struct dirent *entryp) entryp->d_name); if (ret <

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172774609 ## system/stackmonitor/stackmonitor.c: ## @@ -136,11 +135,9 @@ static int stkmon_process_directory(FAR struct dirent *entryp) entryp->d_name);

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172775045 ## system/critmon/critmon.c: ## @@ -326,10 +321,8 @@ static void critmon_global_crit(void) CONFIG_SYSTEM_CRITMONITOR_MOUNTPOINT "/critmon"); if

[GitHub] [nuttx-apps] fjpanag commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
fjpanag commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172775908 ## system/stackmonitor/stackmonitor.c: ## @@ -191,10 +188,8 @@ static int stkmon_process_directory(FAR struct dirent *entryp) entryp->d_name);

[GitHub] [nuttx] simbit18 opened a new pull request, #9056: nuttx/boards/arm/cxd56xx/drivers/sensors/Kconfig: Fix bmp280 texts in Kconfig

2023-04-20 Thread via GitHub
simbit18 opened a new pull request, #9056: URL: https://github.com/apache/nuttx/pull/9056 ## Summary Fix SENSORS_BMP280_SCU texts in Kconfig ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [nuttx] gustavonihei closed pull request #8744: [ESP32-S3] Fix build of WebAssembly applications

2023-04-20 Thread via GitHub
gustavonihei closed pull request #8744: [ESP32-S3] Fix build of WebAssembly applications URL: https://github.com/apache/nuttx/pull/8744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
pkarashchenko commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172945100 ## netutils/ftpc/ftpc_transfer.c: ## @@ -247,7 +247,10 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else if (relpath[1] == '/

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1713: Fixes in asprintf usage.

2023-04-20 Thread via GitHub
pkarashchenko commented on code in PR #1713: URL: https://github.com/apache/nuttx-apps/pull/1713#discussion_r1172945965 ## netutils/ftpc/ftpc_transfer.c: ## @@ -264,7 +267,10 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else if (strncmp(relpath, "./

[GitHub] [nuttx] tmedicci commented on pull request #9022: libc/string: add option to force arch implementations on kernel

2023-04-20 Thread via GitHub
tmedicci commented on PR #9022: URL: https://github.com/apache/nuttx/pull/9022#issuecomment-1516863601 The code was rebased to pass the CI. @pkarashchenko and @xiaoxiang781216 , could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [nuttx-apps] tmedicci commented on pull request #1707: apps/examples/pipe: check POSIX-compliant behavior of NuttX's FIFOs

2023-04-20 Thread via GitHub
tmedicci commented on PR #1707: URL: https://github.com/apache/nuttx-apps/pull/1707#issuecomment-1516864158 CI is (finally) fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[nuttx-website] branch asf-site updated: Publishing web: e36cef39aad5bf1e82697e4e034530ddb77fcf7f docs: ff376ceb1f4f6f737e5ed1153f1ae01cafb3029f

2023-04-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 698b2ae1 Publishing web: e36cef39

[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #9026: i.mx6 with ar8031

2023-04-20 Thread via GitHub
masayuki2009 commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173218515 ## arch/arm/src/imx6/imx_enet.c: ## @@ -2487,7 +2529,7 @@ int imx_netinitialize(int intf) #endif priv->dev.d_private = g_enet; /* Used to recover private

[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #9026: i.mx6 with ar8031

2023-04-20 Thread via GitHub
masayuki2009 commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173218874 ## include/nuttx/net/mii.h: ## @@ -841,6 +845,17 @@ #define MII_DP83848C_FHF_INT_EN (1 << 1) /* Enable Interrupt on False Carrier Counter Register half-full

[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #9026: i.mx6 with ar8031

2023-04-20 Thread via GitHub
masayuki2009 commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173219789 ## arch/arm/src/imx6/hardware/imx_enet.h: ## @@ -248,7 +248,8 @@ #define ENET_RCR_PROM(1 << 3) /* Bit 3: Promiscuous mode */ #define ENET_RCR_BC_

[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #9026: i.mx6 with ar8031

2023-04-20 Thread via GitHub
masayuki2009 commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173219898 ## arch/arm/src/imx6/imx_enet.c: ## @@ -200,6 +201,16 @@ # define BOARD_PHY_10BASET(s) (((s) & MII_DP83825I_PHYSTS_SPEED) != 0) # define BOARD_PHY_100BASET(s) (

[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #9026: i.mx6 with ar8031

2023-04-20 Thread via GitHub
masayuki2009 commented on code in PR #9026: URL: https://github.com/apache/nuttx/pull/9026#discussion_r1173220201 ## arch/arm/src/imx6/imx_enet.c: ## @@ -1327,12 +1338,18 @@ static int imx_ifup_action(struct net_driver_s *dev, bool resetphy) regval = imx_enet_getreg32(pri

[GitHub] [nuttx] no1wudi commented on pull request #8950: driver/telnet: Remove TELNET_CHARACTER_MODE

2023-04-20 Thread via GitHub
no1wudi commented on PR #8950: URL: https://github.com/apache/nuttx/pull/8950#issuecomment-1517167259 @pkarashchenko @xiaoxiang781216 Could you review this PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nuttx-apps] wengzhe commented on a diff in pull request #1718: netutils/iperf: Support local/RPMsg socket test

2023-04-20 Thread via GitHub
wengzhe commented on code in PR #1718: URL: https://github.com/apache/nuttx-apps/pull/1718#discussion_r1173263033 ## netutils/iperf/iperf.c: ## @@ -77,6 +79,12 @@ struct iperf_udp_pkt_t uint32_t usec; }; +typedef CODE int (*iperf_client_func_t)(FAR struct iperf_ctrl_t *ctr

[GitHub] [nuttx-apps] wengzhe commented on a diff in pull request #1718: netutils/iperf: Support local/RPMsg socket test

2023-04-20 Thread via GitHub
wengzhe commented on code in PR #1718: URL: https://github.com/apache/nuttx-apps/pull/1718#discussion_r1173263642 ## netutils/iperf/iperf.c: ## @@ -196,6 +204,47 @@ static int iperf_show_socket_error_reason(FAR const char *str, int sockfd) return err; } +/

[GitHub] [nuttx] zhang-2019 opened a new pull request, #9057: dma support 16550 uart

2023-04-20 Thread via GitHub
zhang-2019 opened a new pull request, #9057: URL: https://github.com/apache/nuttx/pull/9057 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [nuttx] wengzhe commented on pull request #9042: net/rpmsg: Set family for rpaddr in ns_bind

2023-04-20 Thread via GitHub
wengzhe commented on PR #9042: URL: https://github.com/apache/nuttx/pull/9042#issuecomment-1517324941 Rebased to current master and retrigger the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9058: Add some network-related definitions

2023-04-20 Thread via GitHub
zhhyu7 opened a new pull request, #9058: URL: https://github.com/apache/nuttx/pull/9058 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data ty