[incubator-nuttx] branch master updated: boards/Board.mk: Fix MSYS build problem w/ ZDS-II Toolchain

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new f801d04 boards/Board.mk: Fix

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #986: Userspace errno

2020-05-07 Thread GitBox
xiaoxiang781216 commented on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625612125 @patacongo Ok. I will look at the change in that branch. This is an automated message from the Apache

[GitHub] [incubator-nuttx-apps] liuguo09 opened a new pull request #239: CI: use 'git diff $commits' as a whole patchset to do checkpatch

2020-05-07 Thread GitBox
liuguo09 opened a new pull request #239: URL: https://github.com/apache/incubator-nuttx-apps/pull/239 ## Summary Use 'git diff $commits' as a whole patchset instead of 'git show $commits' to avoid checkpatch with duplicate error/warning logs sometimes and rename file not opened issue.

[incubator-nuttx] branch master updated: arch/sim/src/nuttx-names.dat: Add __errno()

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2d78ed7

[GitHub] [incubator-nuttx] patacongo opened a new pull request #999: arch/sim/src/nuttx-names.dat: Add __errno()

2020-05-07 Thread GitBox
patacongo opened a new pull request #999: URL: https://github.com/apache/incubator-nuttx/pull/999 ## Summary Needed to avoid collision with the host on simulator build. ## Impact Needed for reliable simulator build. ## Testing sim:nsh

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #998: arch/mips/src/common/mips_usestack.c: Include tls.h header.

2020-05-07 Thread GitBox
Ouss4 opened a new pull request #998: URL: https://github.com/apache/incubator-nuttx/pull/998 ## Summary An include was missing from the mips_usestack.c file. ## Impact ## Testing This is an

[incubator-nuttx-apps] branch master updated (ed54b89 -> b2d8c50)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from ed54b89 graphics/littlevgl: Add missing configs add 8a92862 Remove CONFIG_TLS add b2d8c50

[incubator-nuttx] branch master updated (930a446 -> 26a1e76)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 930a446 sched/init/nx_start.c: Reinstate logic to remove compiler warning add c2244a2 Remove

[incubator-nuttx] 01/01: Merge branch 'errno' of github.com:apache/incubator-nuttx into errno

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 26a1e76092b39af4d3e83bac780f04eabb9f4d92 Merge: 930a446 3dca5eb Author: Gregory Nutt AuthorDate: Thu May 7

[incubator-nuttx] branch errno updated: Completes the Implementation of the TLS-based errno

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/errno by this push: new 3dca5eb Completes the

[incubator-nuttx-apps] branch errno updated: Remove use of set_errno() from application code.

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/errno by this push: new b2d8c50 Remove use of

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #238: Remove use of set_errno() from application code.

2020-05-07 Thread GitBox
Ouss4 commented on pull request #238: URL: https://github.com/apache/incubator-nuttx-apps/pull/238#issuecomment-625504875 > This PR will NOT compile on all architectures without the matching nuttx/ PR 997 The matching PR is in a separate branch. The check will pull in master.

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #997: Completes the Implementation of the TLS-based errno

2020-05-07 Thread GitBox
Ouss4 commented on a change in pull request #997: URL: https://github.com/apache/incubator-nuttx/pull/997#discussion_r421795375 ## File path: arch/risc-v/src/rv32im/riscv_sigdeliver.c ## @@ -115,7 +115,7 @@ void up_sigdeliver(void) regs[REG_EPC], regs[REG_INT_CTX]);

[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #238: Remove use of set_errno() from application code.

2020-05-07 Thread GitBox
patacongo edited a comment on pull request #238: URL: https://github.com/apache/incubator-nuttx-apps/pull/238#issuecomment-625481281 This PR will NOT compile on all architectures without the matching nuttx/ PR 997 This is

[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #238: Remove use of set_errno() from application code.

2020-05-07 Thread GitBox
patacongo commented on pull request #238: URL: https://github.com/apache/incubator-nuttx-apps/pull/238#issuecomment-625481281 This PR will NOT compile on all architectures with the matching nuttx/ PR 997 This is an

[GitHub] [incubator-nuttx] patacongo commented on pull request #997: Completes the Implementation of the TLS-based errno

2020-05-07 Thread GitBox
patacongo commented on pull request #997: URL: https://github.com/apache/incubator-nuttx/pull/997#issuecomment-625477447 This PR has the common nxstyle warning that must be ignored: syscall/syscall_funclookup.c:113:3: warning: #include outside of 'Included Files' section

[GitHub] [incubator-nuttx] patacongo opened a new pull request #997: Completes the Implementation of the TLS-based errno

2020-05-07 Thread GitBox
patacongo opened a new pull request #997: URL: https://github.com/apache/incubator-nuttx/pull/997 - Remove per-thread errno from the TCB structure (pterrno) - Remove get_errno() and set_errno() as functions. The macros are still available as stubs and will be needed in the future if we

[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #238: Remove use of set_errno() from application code.

2020-05-07 Thread GitBox
patacongo opened a new pull request #238: URL: https://github.com/apache/incubator-nuttx-apps/pull/238 ## Summary The normal assignment errno = errcode should work fine now. This is an automated message from the

[GitHub] [incubator-nuttx] patacongo commented on pull request #996: sched/init/nx_start.c: Reinstate logic to remove compiler warning

2020-05-07 Thread GitBox
patacongo commented on pull request #996: URL: https://github.com/apache/incubator-nuttx/pull/996#issuecomment-625461994 > Does it make sense to generate some warning for the wrong configuration at least? Or it is better to use #error to stop the compiling ifthe wrong configuraton is

[incubator-nuttx] branch master updated: sched/init/nx_start.c: Reinstate logic to remove compiler warning

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 930a446 sched/init/nx_start.c:

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #996: sched/init/nx_start.c: Reinstate logic to remove compiler warning

2020-05-07 Thread GitBox
xiaoxiang781216 commented on a change in pull request #996: URL: https://github.com/apache/incubator-nuttx/pull/996#discussion_r421749510 ## File path: sched/init/nx_start.c ## @@ -545,6 +545,8 @@ void nx_start(void) nxsem_initialize(); +#if

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #996: sched/init/nx_start.c: Reinstate logic to remove compiler warning

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #996: URL: https://github.com/apache/incubator-nuttx/pull/996#issuecomment-625457767 Does it make sense to generate some warning for the wrong configuration at least? Or it is better to use #error to stop the compiling ifthe wrong configuraton is

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #996: sched/init/nx_start.c: Reinstate logic to remove compiler warning

2020-05-07 Thread GitBox
hartmannathan opened a new pull request #996: URL: https://github.com/apache/incubator-nuttx/pull/996 Revert a portion of eca70597858bc619d3114901d16e4a30f1ebffbe that causes compiler warnings about unused variables if nx_start() is not initializing any of the user-mode heap,

[incubator-nuttx] 02/03: arch/risc-v/src/common/riscv_createstack.c: Fix the stack_color name.

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e74899ff6d73faa05f548b8d92a28c2f44dd72f2 Author: Ouss4 AuthorDate: Thu May 7 18:31:02 2020 +0100

[incubator-nuttx] 01/03: Remove CONFIG_TLS

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit c2244a2382cf9c62937cc558cc947fae9f211b81 Author: Gregory Nutt AuthorDate: Thu May 7 09:46:47 2020 -0600

[incubator-nuttx] 03/03: arch/*/*_checkstack.c: Get aligned address only when CONFIG_TLS_ALIGNED is enabled.

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a6da3c2cb6a214b642fa09c48638f1442fdf9117 Author: Ouss4 AuthorDate: Thu May 7 18:50:07 2020 +0100

[incubator-nuttx] branch errno updated (1ad03a5 -> a6da3c2)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1ad03a5 syscall: Generate STUB prototype automatically new c2244a2 Remove CONFIG_TLS new e74899f

[incubator-nuttx] branch errno updated (4fc126f -> 1ad03a5)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. discard 4fc126f arch/*/*_checkstack.c: Get aligned address only when CONFIG_TLS_ALIGNED is enabled. discard

[incubator-nuttx] 02/03: arch/risc-v/src/common/riscv_createstack.c: Fix the stack_color name.

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 21f4a5aedbd264d6869a8c4bcb40e7c031fc363f Author: Ouss4 AuthorDate: Thu May 7 18:31:02 2020 +0100

[incubator-nuttx] 01/03: Remove CONFIG_TLS

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 5e71eb1c723465372d38d7490530a9242ec25f90 Author: Gregory Nutt AuthorDate: Thu May 7 09:46:47 2020 -0600

[incubator-nuttx] branch errno updated (2c9f912 -> 4fc126f)

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2c9f912 tools/pic32: update pic32 scripts to fix jobserver unavailable warning new 5e71eb1

[incubator-nuttx] 03/03: arch/*/*_checkstack.c: Get aligned address only when CONFIG_TLS_ALIGNED is enabled.

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4fc126f290b89495998485607078ee84c57b14af Author: Ouss4 AuthorDate: Thu May 7 18:50:07 2020 +0100

[incubator-nuttx] branch master updated (608e092 -> 1ad03a5)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 608e092 boards/arm/stm32h7/stm32h747i-disco: fix style issues new 2c0381d syscall: Apply the new

[incubator-nuttx] 01/04: syscall: Apply the new vararg syntax to fcntl

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 2c0381da87c10a9f9806cbe6dc0acb0302f484a1 Author: Xiang Xiao AuthorDate: Wed May 6 23:36:16 2020 +0800

[incubator-nuttx] 03/04: syscall: Generate SYS_ number from syscall_lookup.h

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 32cec2a439d5d66544312d45b2cbbedb392906b4 Author: Xiang Xiao AuthorDate: Thu May 7 14:42:52 2020 +0800

[incubator-nuttx] 02/04: syscall: Fix typo error in cvs and header file

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a2d924eea4764056c6614732377b7cd589a3ff73 Author: Xiang Xiao AuthorDate: Wed May 6 17:24:42 2020 +0800

[incubator-nuttx] 04/04: syscall: Generate STUB prototype automatically

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1ad03a5a13c81d15c70ba3969b4f6145986a510d Author: Xiang Xiao AuthorDate: Wed May 6 12:20:26 2020 +0800

[incubator-nuttx-apps] branch errno updated: Remove CONFIG_TLS

2020-05-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/errno by this push: new 8a92862 Remove CONFIG_TLS

[incubator-nuttx] 01/02: boards/arm/stm32h7/stm32h747i-disco: support for FMC SDRAM

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8d8ceee838a592ae833fb3a956dd633ad36f4096 Author: Pierre-Olivier Vauboin AuthorDate: Wed May 6 17:28:39 2020

[incubator-nuttx] branch master updated (2c9f912 -> 608e092)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2c9f912 tools/pic32: update pic32 scripts to fix jobserver unavailable warning new 8d8ceee

[incubator-nuttx] 02/02: boards/arm/stm32h7/stm32h747i-disco: fix style issues

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 608e0920d409fd6d8556228843be82096b299a7d Author: Pierre-Olivier Vauboin AuthorDate: Wed May 6 17:50:50 2020

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #995: Remove CONFIG_TLS

2020-05-07 Thread GitBox
Ouss4 commented on a change in pull request #995: URL: https://github.com/apache/incubator-nuttx/pull/995#discussion_r421629643 ## File path: libs/libc/tls/tls_setelem.c ## @@ -31,7 +31,7 @@ #include #include -#ifdef CONFIG_TLS +#ifdef CONFIG_TLS_NELEM > 0 Review

[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #237: Remove CONFIG_TLS

2020-05-07 Thread GitBox
patacongo opened a new pull request #237: URL: https://github.com/apache/incubator-nuttx-apps/pull/237 ## Summary A first step in implementing the user-space error is force TLS to be enabled at all times. It is no longer optional. ## Impact Risky all architectures are

[GitHub] [incubator-nuttx] patacongo opened a new pull request #995: Remove CONFIG_TLS

2020-05-07 Thread GitBox
patacongo opened a new pull request #995: URL: https://github.com/apache/incubator-nuttx/pull/995 ## Summary A first step in implementing the user-space error is force TLS to be enabled at all times. It is no longer optional ## Impact High risk... Effects just about

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625326953 @btashton It sounds good to me. Should we support 64bit r/w natively? This is an automated

[GitHub] [incubator-nuttx] btashton edited a comment on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
btashton edited a comment on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625323858 > I am quite uncertain that `pci_cfg_read` should directly return the value or not. > Need suggestions. > > Yes, it more convenient to use and the

[GitHub] [incubator-nuttx] btashton commented on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
btashton commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625323858 > I am quite uncertain that `pci_cfg_read` should directly return the value or not. > Need suggestions. > > Yes, it more convenient to use and the semantics

[GitHub] [incubator-nuttx] patacongo commented on issue #986: Userspace errno

2020-05-07 Thread GitBox
patacongo commented on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625313012 @xiaoxiang781216 I have created an errno feature branch. Feel free to contribute to this branch via PRs.

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #994: Naming of OS Internal Functions

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #994: URL: https://github.com/apache/incubator-nuttx/issues/994#issuecomment-625311599 Once the rule is lockdown, the rule is the justification, we don't need more. Once the community approve: __ I will modify the name which doesn't confirm

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #994: Naming of OS Internal Functions

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #994: URL: https://github.com/apache/incubator-nuttx/issues/994#issuecomment-625311599 Once the rule is lockdown, the rule is the justification, we don't need more. Once the community approve: ``` __ ``` I will modify the name which

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #994: Naming of OS Internal Functions

2020-05-07 Thread GitBox
xiaoxiang781216 commented on issue #994: URL: https://github.com/apache/incubator-nuttx/issues/994#issuecomment-625311599 Once the rule is lockdown, the rule is the justification, we don't need more. This is an automated

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #986: Userspace errno

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625306304 > ## TLS interfaces > TLS is a non-standard, but more general interface. It differs from pthread-specific data only in that is semantics are general; the

[incubator-nuttx-apps] branch errno created (now ed54b89)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. at ed54b89 graphics/littlevgl: Add missing configs No new revisions were added by this update.

[incubator-nuttx] branch errno created (now 2c9f912)

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch errno in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 2c9f912 tools/pic32: update pic32 scripts to fix jobserver unavailable warning No new revisions were added

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #986: Userspace errno

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625306304 > ## TLS interfaces > TLS is a non-standard, but more general interface. It differs from pthread-specific data only in that is semantics are general; the

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #986: Userspace errno

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625306304 > ## TLS interfaces > TLS is a non-standard, but more general interface. It differs from pthread-specific data only in that is semantics are general; the

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #986: Userspace errno

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625306304 > ## TLS interfaces > TLS is a non-standard, but more general interface. It differs from pthread-specific data only in that is semantics are general; the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #986: Userspace errno

2020-05-07 Thread GitBox
xiaoxiang781216 commented on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625306304 > ## TLS interfaces > TLS is a non-standard, but more general interface. It differs from pthread-specific data only in that is semantics are general; the semantics

[GitHub] [incubator-nuttx] patacongo commented on issue #994: Naming of OS Internal Functions

2020-05-07 Thread GitBox
patacongo commented on issue #994: URL: https://github.com/apache/incubator-nuttx/issues/994#issuecomment-625289240 > Any rule is fine, the most important thing is try the best to follow the rule once the community make the decision. The consistence is much more important than any

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #986: Userspace errno

2020-05-07 Thread GitBox
patacongo edited a comment on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625278735 > > > > Linux (actual GDB) does not provide a good mechanism; it relies on a storage class that is specific to ELF binaries. That is not useful in an embedded

[incubator-nuttx] branch master updated: tools/pic32: update pic32 scripts to fix jobserver unavailable warning

2020-05-07 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2c9f912 tools/pic32: update pic32

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #994: Naming of OS Internal Functions

2020-05-07 Thread GitBox
xiaoxiang781216 edited a comment on issue #994: URL: https://github.com/apache/incubator-nuttx/issues/994#issuecomment-625278657 Any rule is fine, the most important thing is try the best to follow the rule once the community make the decision. The consistence is much more important than

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #994: Naming of OS Internal Functions

2020-05-07 Thread GitBox
xiaoxiang781216 commented on issue #994: URL: https://github.com/apache/incubator-nuttx/issues/994#issuecomment-625278657 Any rule is fine, the most important thing is try the best to follow the rule once the community make the decision. The consistence is much more important than any

[GitHub] [incubator-nuttx] patacongo commented on issue #986: Userspace errno

2020-05-07 Thread GitBox
patacongo commented on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625278735 > > > > Linux (actual GDB) does not provide a good mechanism; it relies on a storage class that is specific to ELF binaries. That is not useful in an embedded

[GitHub] [incubator-nuttx] patacongo commented on pull request #990: Refine syscall generation

2020-05-07 Thread GitBox
patacongo commented on pull request #990: URL: https://github.com/apache/incubator-nuttx/pull/990#issuecomment-625275654 I added Issue #994 to address this. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #990: Refine syscall generation

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #990: URL: https://github.com/apache/incubator-nuttx/pull/990#issuecomment-625265577 It's unavoidable to include header file out side the include section: ``` syscall/syscall_funclookup.c:124:3: warning: #include outside of 'Included Files'

[GitHub] [incubator-nuttx] povauboin opened a new pull request #993: boards/arm/stm32h7/stm32h747i-disco: support for FMC SDRAM

2020-05-07 Thread GitBox
povauboin opened a new pull request #993: URL: https://github.com/apache/incubator-nuttx/pull/993 ## Summary Declare the pins and timings to use the external FMC SDRAM on STM32H747 Discovery board. ## Impact ## Testing CONFIG_MM_REGIONS=5 CONFIG_STM32H7_FMC=y

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625252903 This is all very annoying to me. It is difficult to work in an environment where people are making many, arbitrary changes that are not improvements that but just

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625250198 Please remove the controversional name changes from this PR and lets deal with that separately. I definitely want to keep the name sched_get_stackinfo(). I just wrote

[GitHub] [incubator-nuttx] xiaoxiang781216 removed a comment on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
xiaoxiang781216 removed a comment on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625249238 > But this is hard to have a real technical discussion because this is about your ego, not about the engineering work. This is a name for that: NIH

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625249238 > But this is hard to have a real technical discussion because this is about your ego, not about the engineering work. This is a name for that: NIH But

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625249087 > But there are many name already violative your rule: > sched_getaffinity > sched_getcpu > sched_getparam > sched_getscheduler > sched_getstreams >

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo edited a comment on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625244585 But this is hard to have a real technical discussion because this is about your ego, not about the engineering work. This is a name for that: NIH

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625244585 But this is hard to have a real technical discussion because this is about your ego, not about the engineering work.

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo edited a comment on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625240973 Also I do not like the name clock_systimetick(). It feels like bad English to me. I have seen naming conventions that put the units at the end of the name

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625242960 > Also I do not like the name clock_systimetick(). It feels like bad English to me. Ok, I will drop clock_systimer from PR.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625242733 > > Here is another example you need decide: > > [4bb943a](https://github.com/apache/incubator-nuttx/commit/4bb943a0c0ab173d7f5eb0178fd3a332726ce861) > >

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625240973 Also I do not like the name clock_systimetick(). It feels like bad English to me. This is an

[GitHub] [incubator-nuttx] patacongo commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
patacongo commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625237776 > Here is another example you need decide: > [4bb943a](https://github.com/apache/incubator-nuttx/commit/4bb943a0c0ab173d7f5eb0178fd3a332726ce861) Yes, that is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #969: Refine the nuttx internal function

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #969: URL: https://github.com/apache/incubator-nuttx/pull/969#issuecomment-625233186 Actually, I don't have any personal preference:). Following the rule(either state in document explicitly or represent in the code base) as much as possible is my

[incubator-nuttx-apps] branch master updated: graphics/littlevgl: Add missing configs

2020-05-07 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ed54b89 graphics/littlevgl: Add

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #991: tools/pic32: update pic32 scripts to fix jobserver unavailable warning

2020-05-07 Thread GitBox
liuguo09 opened a new pull request #991: URL: https://github.com/apache/incubator-nuttx/pull/991 ## Summary Add + make to fix jobserver unavailable warning. And always build mkpichex to make sure it newest, also correct target name. ## Impact ## Testing Test and

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625210301 I am quite uncertain that `pci_cfg_read` should directly return the value or not. Need suggestions. Yes, it more convenient to use and the semantics are much

[GitHub] [incubator-nuttx] sonicyang commented on issue #986: Userspace errno

2020-05-07 Thread GitBox
sonicyang commented on issue #986: URL: https://github.com/apache/incubator-nuttx/issues/986#issuecomment-625205581 > Linux (actual GDB) does not provide a good mechanism; it relies on a storage class that is specific to ELF binaries. That is not useful in an embedded system. This

[GitHub] [incubator-nuttx] sonicyang edited a comment on pull request #974: x86_64: Jailhouse support

2020-05-07 Thread GitBox
sonicyang edited a comment on pull request #974: URL: https://github.com/apache/incubator-nuttx/pull/974#issuecomment-624523205 @btashton Here is the patch. Nan, that's not your fault. I did this patch while you were fixing the 4M -> 1M issue. I should have check and found out

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625203136 Seems quite good. I will try it out on my jailhuose machine with a serial PCI-E card on weekend. Hope it works.

[GitHub] [incubator-nuttx] sonicyang commented on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
sonicyang commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625201838 @btashton Sounds fantastic! I will take a look, but I am kinda of exhausted today. I will reply on weekend

[GitHub] [incubator-nuttx] sonicyang commented on a change in pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
sonicyang commented on a change in pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#discussion_r421437126 ## File path: drivers/pcie/pcie_root.c ## @@ -0,0 +1,446 @@ +/ + *

[GitHub] [incubator-nuttx] btashton edited a comment on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
btashton edited a comment on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625159985 @sonicyang I did some work here https://github.com/btashton/incubator-nuttx/tree/pci-btashton I have ported over a good chunk of the code that I wrote before in

[GitHub] [incubator-nuttx] btashton commented on pull request #979: PCI-E support with x86_64/qemu example

2020-05-07 Thread GitBox
btashton commented on pull request #979: URL: https://github.com/apache/incubator-nuttx/pull/979#issuecomment-625159985 @sonicyang I did some work here https://github.com/btashton/incubator-nuttx/tree/pci-btashton I have ported over a good chunk of the code that I wrote before in place

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #990: Refine syscall generation

2020-05-07 Thread GitBox
xiaoxiang781216 opened a new pull request #990: URL: https://github.com/apache/incubator-nuttx/pull/990 ## Summary The first three patch fix the minor issue found during review The last two patch reduce the files need to be modified when we add/delete/modify syscall function

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #989: Fix syscall lookup table

2020-05-07 Thread GitBox
xiaoxiang781216 commented on pull request #989: URL: https://github.com/apache/incubator-nuttx/pull/989#issuecomment-625122871 LGMT, I am refactoring the syscall generation logic, the similar error will eliminate in the furture.

[incubator-nuttx] branch master updated: Fix syscall lookup table

2020-05-07 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d07fde0 Fix syscall lookup table

[GitHub] [incubator-nuttx] YuuichiNakamura opened a new pull request #989: Fix syscall lookup table

2020-05-07 Thread GitBox
YuuichiNakamura opened a new pull request #989: URL: https://github.com/apache/incubator-nuttx/pull/989 ## Summary This PR fixes syscall names in the syscall lookup table. ## Impact Affected in PROTECTED or KERNEL build with SMP. At this moment there is no such existing

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #236: graphics/littlevgl: Add missing configs

2020-05-07 Thread GitBox
no1wudi opened a new pull request #236: URL: https://github.com/apache/incubator-nuttx-apps/pull/236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-nuttx] branch master updated: arch: k210: Fix cpu1 hangup during boot with qemu

2020-05-07 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1cf62c7 arch: k210: Fix cpu1 hangup