[GitHub] [nuttx] no1wudi commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
no1wudi commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1463379480 > Ok got it, however don't we have some regression here? while this is perfectly working in release/12.0? Emm, I think current implementation is not the real solution. I'll

[GitHub] [nuttx] janantos commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
janantos commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1463371001 I am in work now, but tomorrow I will test if this error is acceptable for time of being as it gives you instantly console. However I will test tomorrow if this does not affect login

[nuttx-apps] branch master updated: Using poll instead of epoll by default

2023-03-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new b67b56111 Using poll instead of epoll by

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1648: Using poll instead of epoll in NNG library

2023-03-09 Thread via GitHub
xiaoxiang781216 merged PR #1648: URL: https://github.com/apache/nuttx-apps/pull/1648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1132008935 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1132008935 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor

[GitHub] [nuttx] janantos commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
janantos commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1463354171 Ok got it, however don't we have some regression here? while this is perfectly working in release/12.0 ? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [nuttx] anjiahao1 opened a new pull request, #8786: sig_timewait:changes the macro for waitticks

2023-03-09 Thread via GitHub
anjiahao1 opened a new pull request, #8786: URL: https://github.com/apache/nuttx/pull/8786 use SYSTEM_TIME64 inside of LONG LONG better Sometimes longlong and system_time64 are not uniform ## Summary changes the macro for waitticks ## Impact signal ## Testing sim nsh

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
no1wudi commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1131933197 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor position */ -

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1131932472 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
no1wudi commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1131927901 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor position */ -

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
no1wudi commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1131927901 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor position */ -

[GitHub] [nuttx] no1wudi commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
no1wudi commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1463225073 @janantos With latest patch, you don't need to press enter 11 times anymore, but may get some error message at first line: ยทยทยท ) NuttX-12.0.0 nsh> nsh: nsh_session: cle

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1131924268 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor

[GitHub] [nuttx] masayuki2009 commented on pull request #8762: Support for Kernel build with vexriscv-smp.

2023-03-09 Thread via GitHub
masayuki2009 commented on PR #8762: URL: https://github.com/apache/nuttx/pull/8762#issuecomment-1463213402 >qemu for whatever reason allows/handles the access from S -> M mode, maybe @masayuki2009 can explain how that >actually works. I think there is something in the command line options

[GitHub] [nuttx] wengzhe opened a new pull request, #8785: net/icmpv6: align structs to 2 bytes.

2023-03-09 Thread via GitHub
wengzhe opened a new pull request, #8785: URL: https://github.com/apache/nuttx/pull/8785 ## Summary Fix following misaligned errors: ``` icmpv6/icmpv6_radvertise.c:145:21: runtime error: member access within misaligned address 0x573da9e6 for type 'struct icmpv6_router_advertise_s',

[GitHub] [nuttx] Donny9 opened a new pull request, #8784: fs/mmap: try rammap when filesystem mmap don't support

2023-03-09 Thread via GitHub
Donny9 opened a new pull request, #8784: URL: https://github.com/apache/nuttx/pull/8784 ## Summary fs/mmap: try rammap when filesystem mmap don't support ## Impact using mmap for romfs. ## Testing local test -- This is an automated message from the Apache Git

[GitHub] [nuttx] donghengqaz opened a new pull request, #8783: xtensa/esp32: Tasks use PSRAM as stack can do SPI flash read/write/erase/map/unmap

2023-03-09 Thread via GitHub
donghengqaz opened a new pull request, #8783: URL: https://github.com/apache/nuttx/pull/8783 ## Summary Tasks use PSRAM as stack can do SPI flash read/write/erase/map/unmap. ## Impact ## Testing -- This is an automated message from the Apache Git

[GitHub] [nuttx] zhhyu7 opened a new pull request, #8782: tcp: add TCP_MAXSEG support

2023-03-09 Thread via GitHub
zhhyu7 opened a new pull request, #8782: URL: https://github.com/apache/nuttx/pull/8782 ## Summary tcp: add TCP_MAXSEG support tcp: accept conn inherits some properties of listener conn ## Impact ## Testing sim:rpserver with iperf2 -- This is an automated message

[GitHub] [nuttx-apps] tmedicci opened a new pull request, #1652: nxplayer: read file completely until 0 bytes are returned

2023-03-09 Thread via GitHub
tmedicci opened a new pull request, #1652: URL: https://github.com/apache/nuttx-apps/pull/1652 ## Summary Previously, if the read bytes were less than the requested, the file was closed immediately. This behavior, however, does not consider the fact that the read operation may be

[GitHub] [nuttx] qiaohaijiao commented on a diff in pull request #8775: audio: add audio_dma device driver.

2023-03-09 Thread via GitHub
qiaohaijiao commented on code in PR #8775: URL: https://github.com/apache/nuttx/pull/8775#discussion_r1131844745 ## drivers/audio/Kconfig: ## @@ -439,4 +439,10 @@ config AUDIO_I2S depends on AUDIO depends on I2S +config AUDIO_DMA +bool "Audio Dma"

[GitHub] [nuttx] qiaohaijiao commented on a diff in pull request #8775: audio: add audio_dma device driver.

2023-03-09 Thread via GitHub
qiaohaijiao commented on code in PR #8775: URL: https://github.com/apache/nuttx/pull/8775#discussion_r1131841250 ## drivers/audio/audio_dma.c: ## @@ -0,0 +1,607 @@ +/ + * drivers/audio/audio_dma.c + * +

[GitHub] [nuttx] qiaohaijiao commented on a diff in pull request #8775: audio: add audio_dma device driver.

2023-03-09 Thread via GitHub
qiaohaijiao commented on code in PR #8775: URL: https://github.com/apache/nuttx/pull/8775#discussion_r1131841479 ## drivers/audio/audio_dma.c: ## @@ -0,0 +1,607 @@ +/ + * drivers/audio/audio_dma.c + * +

[GitHub] [nuttx] no1wudi commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
no1wudi commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1463057515 @janantos https://user-images.githubusercontent.com/9030616/224195723-1582cca5-8e15-4bba-9653-e2979070269a.png;> Emm, too many getch here without timeout in `cle_getcursor`, this

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 61e996af33100cbf2774ef8911d874bcd99ff393

2023-03-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a24d3403 Publishing web:

[GitHub] [nuttx-apps] tmedicci opened a new pull request, #1651: apps/netutils: Add RTP tools

2023-03-09 Thread via GitHub
tmedicci opened a new pull request, #1651: URL: https://github.com/apache/nuttx-apps/pull/1651 ## Summary Add an application to receive/send RTP protocol. > RTP Tools is a set of small applications that can be used for processing RTP data. > > * **rtpplay**: play back

[GitHub] [nuttx] yamt commented on pull request #8777: Migrate sim board README.txt to Documentation

2023-03-09 Thread via GitHub
yamt commented on PR #8777: URL: https://github.com/apache/nuttx/pull/8777#issuecomment-1462948840 > Hi @yamt maybe you can merge it with existing SIM documenation: Documentation/platforms/sim/sim/index.rst i followed the structure of other archs. -- This is an automated message

[GitHub] [nuttx] acassis commented on pull request #8779: arch: Remove up_[early]serialinit from arm64, riscv-v and x86[_64]

2023-03-09 Thread via GitHub
acassis commented on PR #8779: URL: https://github.com/apache/nuttx/pull/8779#issuecomment-1462675801 @xiaoxiang781216 please consider including in the log message the motivation to change the function name, as people suggested in the mailing list. I think a good benefit of getting rid of

[GitHub] [nuttx] tmedicci commented on a diff in pull request #8775: audio: add audio_dma device driver.

2023-03-09 Thread via GitHub
tmedicci commented on code in PR #8775: URL: https://github.com/apache/nuttx/pull/8775#discussion_r1131504738 ## drivers/audio/audio_dma.c: ## @@ -0,0 +1,607 @@ +/ + * drivers/audio/audio_dma.c + * + *

[GitHub] [nuttx] acassis merged pull request #8774: Fix misc issues in code

2023-03-09 Thread via GitHub
acassis merged PR #8774: URL: https://github.com/apache/nuttx/pull/8774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[nuttx] branch master updated (75ecbd4382 -> 61e996af33)

2023-03-09 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 75ecbd4382 net/local: Return the unblock handle correctly in local_accept add 4581a84064 nuttx: fix indentation

[GitHub] [nuttx] acassis commented on a diff in pull request #8775: audio: add audio_dma device driver.

2023-03-09 Thread via GitHub
acassis commented on code in PR #8775: URL: https://github.com/apache/nuttx/pull/8775#discussion_r1131487798 ## drivers/audio/Kconfig: ## @@ -439,4 +439,10 @@ config AUDIO_I2S depends on AUDIO depends on I2S +config AUDIO_DMA +bool "Audio Dma" Review

[GitHub] [nuttx] acassis commented on pull request #8777: Migrate sim board README.txt to Documentation

2023-03-09 Thread via GitHub
acassis commented on PR #8777: URL: https://github.com/apache/nuttx/pull/8777#issuecomment-1462628263 Hi @yamt maybe you can merge it with existing SIM documenation: Documentation/platforms/sim/sim/index.rst -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] acassis commented on a diff in pull request #8781: Add MPU60x0 IMU sensors support for ESP32C3

2023-03-09 Thread via GitHub
acassis commented on code in PR #8781: URL: https://github.com/apache/nuttx/pull/8781#discussion_r1131470647 ## boards/risc-v/esp32c3/common/src/esp32c3_board_mpu60x0_i2c.c: ## @@ -0,0 +1,124 @@ +/ + *

[GitHub] [nuttx] AuroraRAS opened a new pull request, #8781: Add MPU60x0 IMU sensors support for ESP32C3

2023-03-09 Thread via GitHub
AuroraRAS opened a new pull request, #8781: URL: https://github.com/apache/nuttx/pull/8781 ## Summary Add MPU60x0 IMU sensors support for ESP32C3 ## Impact ESP32C3 ## Testing ESP32-C3-WROOM-02 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [nuttx] patacongo commented on issue #8780: ARMV7-M MPU base region not configured correctly

2023-03-09 Thread via GitHub
patacongo commented on issue #8780: URL: https://github.com/apache/nuttx/issues/8780#issuecomment-1462566415 > I made a protected build on NXP 1052 chip which uses the ARMV7-M MCU. > The user region has a base address of 0x80800048 with a size of > 0xd15620. The alignedbase is

[GitHub] [nuttx] vome101 opened a new issue, #8780: ARMV7-M MPU base region not configured correctly

2023-03-09 Thread via GitHub
vome101 opened a new issue, #8780: URL: https://github.com/apache/nuttx/issues/8780 I made a protected build on NXP 1052 chip which uses the ARMV7-M MCU. The user region has a base address of 0x80800048 with a size of 0xd15620. The alignedbase is 0x8000 because the l2size is 0x19. The

[GitHub] [nuttx] TimJTi closed issue #8778: Ctrl-C from app causing major crash on subsequent re-run of app

2023-03-09 Thread via GitHub
TimJTi closed issue #8778: Ctrl-C from app causing major crash on subsequent re-run of app URL: https://github.com/apache/nuttx/issues/8778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nuttx] TimJTi commented on issue #8778: Ctrl-C from app causing major crash on subsequent re-run of app

2023-03-09 Thread via GitHub
TimJTi commented on issue #8778: URL: https://github.com/apache/nuttx/issues/8778#issuecomment-1462484338 Well - I learned how to bisect which is good...but all along it was my app mishandling console input :( -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8779: arch: Remove up_[early]serialinit from arm64, riscv-v and x86[_64]

2023-03-09 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8779: URL: https://github.com/apache/nuttx/pull/8779 ## Summary continue the change from: commit a8fa51e6bf51791272a0a65a69e029aa9eb8d1ba Author: zhangyuan21 Date: Thu Nov 17 18:17:40 2022 +0800 arch: rename arch

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #6704: driver/sensors[1]: enhance sensor driver

2023-03-09 Thread via GitHub
xiaoxiang781216 commented on PR #6704: URL: https://github.com/apache/nuttx/pull/6704#issuecomment-1462367310 Yes, the old sensor developed before the new sensor driver framework need rewrite to integrate with uORB. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [nuttx] TimJTi commented on issue #8778: Ctrl-C from app causing major crash on subsequent re-run of app

2023-03-09 Thread via GitHub
TimJTi commented on issue #8778: URL: https://github.com/apache/nuttx/issues/8778#issuecomment-1462348535 I'll give it a go - never done it before so it all adds to the learning :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nuttx] patacongo commented on issue #8778: Ctrl-C from app causing major crash on subsequent re-run of app

2023-03-09 Thread via GitHub
patacongo commented on issue #8778: URL: https://github.com/apache/nuttx/issues/8778#issuecomment-1462343705 It is time consuming, but if what you say is correct, then you should be able to use git bisect to isolate the change that introduced the problem.

[GitHub] [nuttx] TimJTi opened a new issue, #8778: Ctrl-C from app causing major crash on subsequent re-run of app

2023-03-09 Thread via GitHub
TimJTi opened a new issue, #8778: URL: https://github.com/apache/nuttx/issues/8778 I have a test app for a sensor driver I'm writing. I have enabled signals and SIGINT support on the serial driver (console) for to allow ctrl-c to kill the app in case of problems. I am finding that if

[GitHub] [nuttx] janantos commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
janantos commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1462332386 @no1wudi Lua works, but CLE is still sort of dodgy on my esp32c3 olimex board. The nsh prompt does not show, but is shows after exactly 11 enter presses, it does not matter how

[GitHub] [nuttx] tmedicci commented on a diff in pull request #8771: esp32s3/wifi: Add Wi-Fi driver (STA mode) for ESP32-S3

2023-03-09 Thread via GitHub
tmedicci commented on code in PR #8771: URL: https://github.com/apache/nuttx/pull/8771#discussion_r1131153859 ## arch/xtensa/src/esp32s3/esp32s3_systemreset.h: ## @@ -0,0 +1,105 @@ +/ + *

[GitHub] [nuttx] tmedicci commented on a diff in pull request #8771: esp32s3/wifi: Add Wi-Fi driver (STA mode) for ESP32-S3

2023-03-09 Thread via GitHub
tmedicci commented on code in PR #8771: URL: https://github.com/apache/nuttx/pull/8771#discussion_r1131154015 ## arch/xtensa/src/esp32s3/esp32s3_wifi_utils.h: ## @@ -0,0 +1,104 @@ +/ + *

[GitHub] [nuttx-apps] gustavonihei commented on a diff in pull request #1649: Add another batch of missing headers throughout the repository

2023-03-09 Thread via GitHub
gustavonihei commented on code in PR #1649: URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1131100578 ## testing/ostest/suspend.c: ## @@ -22,14 +22,18 @@ * Included Files /

[GitHub] [nuttx] pkarashchenko commented on pull request #8645: mutex: move nxmutex to sched

2023-03-09 Thread via GitHub
pkarashchenko commented on PR #8645: URL: https://github.com/apache/nuttx/pull/8645#issuecomment-1462173918 I will take a look over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nuttx-apps] gustavonihei commented on a diff in pull request #1649: Add another batch of missing headers throughout the repository

2023-03-09 Thread via GitHub
gustavonihei commented on code in PR #1649: URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1131100578 ## testing/ostest/suspend.c: ## @@ -22,14 +22,18 @@ * Included Files /

[GitHub] [nuttx-apps] gustavonihei commented on a diff in pull request #1649: Add another batch of missing headers throughout the repository

2023-03-09 Thread via GitHub
gustavonihei commented on code in PR #1649: URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1131100578 ## testing/ostest/suspend.c: ## @@ -22,14 +22,18 @@ * Included Files /

[GitHub] [nuttx] masayuki2009 commented on pull request #8776: arch: fixed error in the calculation of nwords caused an out of bounds

2023-03-09 Thread via GitHub
masayuki2009 commented on PR #8776: URL: https://github.com/apache/nuttx/pull/8776#issuecomment-1462062767 >@masayuki2009 can this cause an issue that needs your workaround for stm32discovery? @pkarashchenko Let me check this PR tomorrow but I think this PR just fixes stack

[GitHub] [nuttx] pkarashchenko commented on pull request #8776: arch: fixed error in the calculation of nwords caused an out of bounds

2023-03-09 Thread via GitHub
pkarashchenko commented on PR #8776: URL: https://github.com/apache/nuttx/pull/8776#issuecomment-1462037664 @masayuki2009 can this cause an issue that needs your workaround for stm32discovery? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nuttx] zyfeier commented on pull request #8645: mutex: move nxmutex to sched

2023-03-09 Thread via GitHub
zyfeier commented on PR #8645: URL: https://github.com/apache/nuttx/pull/8645#issuecomment-1462041929 @xiaoxiang781216 @pkarashchenko Any comments on this PR? Please help to review it again. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nuttx] yamt commented on a diff in pull request #8772: Add sim:toywasm config

2023-03-09 Thread via GitHub
yamt commented on code in PR #8772: URL: https://github.com/apache/nuttx/pull/8772#discussion_r1131003534 ## boards/sim/sim/sim/README.txt: ## @@ -1245,6 +1245,18 @@ touchscreen See apps/examples/README.txt for further information about build requirements and

[GitHub] [nuttx] yamt opened a new pull request, #8777: Migrate sim board README.txt to Documentation

2023-03-09 Thread via GitHub
yamt opened a new pull request, #8777: URL: https://github.com/apache/nuttx/pull/8777 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nuttx-apps] jturnsek commented on a diff in pull request #1648: Using poll instead of epoll in NNG library

2023-03-09 Thread via GitHub
jturnsek commented on code in PR #1648: URL: https://github.com/apache/nuttx-apps/pull/1648#discussion_r1131002363 ## netutils/nng/Makefile: ## @@ -88,7 +91,8 @@ CSRCS += $(NNG_SRCDIR)/platform/posix/posix_tcpdial.c CSRCS += $(NNG_SRCDIR)/platform/posix/posix_tcplisten.c

[GitHub] [nuttx] zyfeier opened a new pull request, #8776: arch: fixed error in the calculation of nwords caused an out of bounds

2023-03-09 Thread via GitHub
zyfeier opened a new pull request, #8776: URL: https://github.com/apache/nuttx/pull/8776 ## Summary Fixed an error in the calculation of nwords caused an out of bounds. ## Impact stack ## Testing ostest pass -- This is an automated message from the

[GitHub] [nuttx] zouboan commented on pull request #6704: driver/sensors[1]: enhance sensor driver

2023-03-09 Thread via GitHub
zouboan commented on PR #6704: URL: https://github.com/apache/nuttx/pull/6704#issuecomment-1461991273 Thanks so much for your explanation! I think i misread the role of `usensor`, I thought the `usensor `is used for sensors(e.g. mpu60x0) that didn't registered under the `sensor.c` in the

[GitHub] [nuttx] Tvveeck commented on issue #8767: ESP32-devkitc ble problem

2023-03-09 Thread via GitHub
Tvveeck commented on issue #8767: URL: https://github.com/apache/nuttx/issues/8767#issuecomment-1461945430 yes, apps are also updated from master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nuttx] qiaohaijiao opened a new pull request, #8775: audio: add audio_dma device driver.

2023-03-09 Thread via GitHub
qiaohaijiao opened a new pull request, #8775: URL: https://github.com/apache/nuttx/pull/8775 ## Summary add audio dma driver which base on common dma ops. ## Impact ## Testing local -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] pussuw commented on pull request #8762: Support for Kernel build with vexriscv-smp.

2023-03-09 Thread via GitHub
pussuw commented on PR #8762: URL: https://github.com/apache/nuttx/pull/8762#issuecomment-1461671859 > I can't seem to set the compare register for m-timer. As a workaround, I'm using the peripheral timer, timer0. Like I said in the issue you posted, you need an SBI implemenation in

[GitHub] [nuttx-apps] yamt commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-09 Thread via GitHub
yamt commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1130693256 ## interpreters/wamr/Toolchain.defs: ## @@ -0,0 +1,149 @@ + +#

[GitHub] [nuttx] yamt commented on pull request #8744: [ESP32-S3] Fix build of WebAssembly applications

2023-03-09 Thread via GitHub
yamt commented on PR #8744: URL: https://github.com/apache/nuttx/pull/8744#issuecomment-1461614096 > ## Summary > > This PR intends to fix the build of WebAssembly applications for the **ESP32-S3**, which currently fails due to the following error: > > ``` >

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
no1wudi commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1130683171 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor position */ -

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
xiaoxiang781216 commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1130676745 ## system/cle/cle.c: ## @@ -1124,11 +1149,20 @@ int cle_fd(FAR char *line, FAR const char *prompt, uint16_t linelen, /* Get the current cursor

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8247: tools/ci: Update docker to ubuntu 22.04

2023-03-09 Thread via GitHub
pkarashchenko commented on code in PR #8247: URL: https://github.com/apache/nuttx/pull/8247#discussion_r1130676073 ## tools/ci/docker/linux/Dockerfile: ## @@ -13,7 +13,7 @@ # License for the specific language governing permissions and limitations # under the License. -FROM

[GitHub] [nuttx] no1wudi commented on issue #8731: ESP32C3 risc-v usb-serial not working correctly

2023-03-09 Thread via GitHub
no1wudi commented on issue #8731: URL: https://github.com/apache/nuttx/issues/8731#issuecomment-1461575806 @janantos Could you try this patch https://github.com/apache/nuttx-apps/pull/1650? I confirmed `cle` and `lua` works correctly with usbconsole now. -- This is an automated

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
no1wudi commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1130654745 ## system/cle/cle.c: ## @@ -82,6 +84,14 @@ # define COLOR_OUTPUT VT100_GREEN #endif +/* Poll timeout during getcursor, + * 50ms should be enough to fetch a

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
pkarashchenko commented on code in PR #1650: URL: https://github.com/apache/nuttx-apps/pull/1650#discussion_r1130648696 ## system/cle/cle.c: ## @@ -82,6 +84,14 @@ # define COLOR_OUTPUT VT100_GREEN #endif +/* Poll timeout during getcursor, + * 50ms should be enough to

[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1650: system/cle: Enhance error handling for cle_getcursor

2023-03-09 Thread via GitHub
no1wudi opened a new pull request, #1650: URL: https://github.com/apache/nuttx-apps/pull/1650 ## Summary Fix https://github.com/apache/nuttx/issues/8731, and also prevent shell freezing without any information if character lost during cle_getcursor in some case (serial line

[nuttx] branch master updated: net/local: Return the unblock handle correctly in local_accept

2023-03-09 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 75ecbd4382 net/local: Return the unblock

[GitHub] [nuttx] jerpelea merged pull request #8749: net/local: Return the unblock handle correctly in local_accept

2023-03-09 Thread via GitHub
jerpelea merged PR #8749: URL: https://github.com/apache/nuttx/pull/8749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nuttx] jerpelea commented on pull request #8691: drivers/serial: Echo input in driver layer

2023-03-09 Thread via GitHub
jerpelea commented on PR #8691: URL: https://github.com/apache/nuttx/pull/8691#issuecomment-1461532346 I think that all breaking changes should be discussed on the dev mailing list before merging them ! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx-apps] jerpelea commented on a diff in pull request #1648: Using poll instead of epoll in NNG library

2023-03-09 Thread via GitHub
jerpelea commented on code in PR #1648: URL: https://github.com/apache/nuttx-apps/pull/1648#discussion_r1130623906 ## netutils/nng/Makefile: ## @@ -88,7 +91,8 @@ CSRCS += $(NNG_SRCDIR)/platform/posix/posix_tcpdial.c CSRCS += $(NNG_SRCDIR)/platform/posix/posix_tcplisten.c

[GitHub] [nuttx] pkarashchenko opened a new pull request, #8774: Fix misc issues in code

2023-03-09 Thread via GitHub
pkarashchenko opened a new pull request, #8774: URL: https://github.com/apache/nuttx/pull/8774 ## Summary Fix misc issues in code (style mostly) ## Impact N/A ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx-apps] CV-Bowen commented on pull request #1625: Initial load for nng library

2023-03-09 Thread via GitHub
CV-Bowen commented on PR #1625: URL: https://github.com/apache/nuttx-apps/pull/1625#issuecomment-1461516214 @jturnsek Got, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nuttx] thebolt commented on pull request #8755: ramlog: optimize ramlog_addchar, copy as much content as possible at a time

2023-03-09 Thread via GitHub
thebolt commented on PR #8755: URL: https://github.com/apache/nuttx/pull/8755#issuecomment-1461515106 The implementation looks ok, at least as far as I can tell without actually running it; however the removal of CONFIG_RAMLOG_CRLF and associated logic seems to be to be the type of