Re: [PR] apps: Select PIPES when enabling system popen [nuttx-apps]

2023-12-22 Thread via GitHub
xiaoxiang781216 commented on PR #2239: URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868183721 But, there are other path which directly use pipes, if someday the project decides to avoid use popen to save the code size, the end user will surprise that the linker can't

Re: [I] Make OPEN option select FIFO and named pipes configuration [nuttx]

2023-12-22 Thread via GitHub
xiaoxiang781216 commented on issue #11435: URL: https://github.com/apache/nuttx/issues/11435#issuecomment-1868182241 But you must enable CONFIG_PIPES in defconfig, otherwise CONFIG_EXAMPLES_POPEN/CONFIG_SYSTEM_POPEN will be ignored by kconfig tool since the dependence requirement isn't

Re: [I] use SDCard on NuttX question。 [nuttx]

2023-12-22 Thread via GitHub
xiaoxiang781216 closed issue #11420: use SDCard on NuttX question。 URL: https://github.com/apache/nuttx/issues/11420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Update mode.h to add CSR_TVEC [nuttx]

2023-12-22 Thread via GitHub
yf13 opened a new pull request, #11441: URL: https://github.com/apache/nuttx/pull/11441 ## Summary this adds CSR_TVEC definition for trap vector base address register to risc-v mode.h ## Impact None for existing RiscV ports -- This is an automated message from

Re: [I] use SDCard on NuttX question。 [nuttx]

2023-12-22 Thread via GitHub
GC-20-20 commented on issue #11420: URL: https://github.com/apache/nuttx/issues/11420#issuecomment-1868170193 @acassis Thanks for your reply, I have now successfully mounted it. The cause was a hardware problem, two modules were mounted on the SDIO bus, masking one of them worked. --

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: 804f713c862cc5e8c1dae5067b8f8781165b1bd2

2023-12-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9f84c75d Publishing web:

(nuttx) branch master updated: Update riscv_mmu.h to fix typo in comment

2023-12-22 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 804f713c86 Update riscv_mmu.h to fix typo in

Re: [I] Make OPEN option select FIFO and named pipes configuration [nuttx]

2023-12-22 Thread via GitHub
gus-soares19 commented on issue #11435: URL: https://github.com/apache/nuttx/issues/11435#issuecomment-1868072093 No, I did not. I enabled both CONFIG_EXAMPLES_POPEN and CONFIG_SYSTEM_POPEN using menuconfig. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Update riscv_mmu.h to fix typo in comment [nuttx]

2023-12-22 Thread via GitHub
acassis merged PR #11439: URL: https://github.com/apache/nuttx/pull/11439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] CMake version.h compilation error [nuttx]

2023-12-22 Thread via GitHub
acassis commented on issue #11438: URL: https://github.com/apache/nuttx/issues/11438#issuecomment-1868071409 @maxikrie thank you for reporting, I think the error is here: ``` cmake/nuttx_mkversion.cmake: file(APPEND ${VERSION_H} "#define CONFIG_VERSION_STRING

Re: [I] Make OPEN option select FIFO and named pipes configuration [nuttx]

2023-12-22 Thread via GitHub
acassis commented on issue #11435: URL: https://github.com/apache/nuttx/issues/11435#issuecomment-1868068167 @xiaoxiang781216 actually the issue that @gus-soares19 was facing should exist according with current Kconfig settings: -> CONFIG_EXAMPLES_POPEN depends on CONFIG_SYSTEM_POPEN

Re: [PR] apps: Select PIPES when enabling system popen [nuttx-apps]

2023-12-22 Thread via GitHub
acassis commented on PR #2239: URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1868064014 @xiaoxiang781216 right, but in this case here it is a direct dependence: Let's say assume Features: A = popen example app B = system popen C = pipes -> A depends on B

Re: [PR] boards/fvp-armv8r: Update defconfig after running refresh.sh [nuttx]

2023-12-22 Thread via GitHub
acassis commented on PR #11440: URL: https://github.com/apache/nuttx/pull/11440#issuecomment-1867807624 I will close this PR, but please guys run the same build script to confirm it is failing. I don't remember if I ran make distclean before running it, probably it was configured to

Re: [PR] boards/fvp-armv8r: Update defconfig after running refresh.sh [nuttx]

2023-12-22 Thread via GitHub
acassis commented on PR #11440: URL: https://github.com/apache/nuttx/pull/11440#issuecomment-1867805024 > it's strange that ci doesn't catch this problem. Could you please run: ``` ./tools/refresh.sh --silent --defaults all ``` And see if same issue file will be

Re: [PR] boards/fvp-armv8r: Update defconfig after running refresh.sh [nuttx]

2023-12-22 Thread via GitHub
acassis commented on code in PR #11440: URL: https://github.com/apache/nuttx/pull/11440#discussion_r1435152381 ## boards/arm64/fvp-v8r/fvp-armv8r/configs/nsh/defconfig: ## @@ -5,74 +5,46 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes

Re: [PR] boards/fvp-armv8r: Update defconfig after running refresh.sh [nuttx]

2023-12-22 Thread via GitHub
raiden00pl commented on code in PR #11440: URL: https://github.com/apache/nuttx/pull/11440#discussion_r1435148421 ## boards/arm64/fvp-v8r/fvp-armv8r/configs/nsh/defconfig: ## @@ -5,74 +5,46 @@ # You can then do "make savedefconfig" to generate a new defconfig file that

Re: [PR] Add MTD for AT25 eeprom [nuttx]

2023-12-22 Thread via GitHub
TimJTi commented on code in PR #11423: URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435124953 ## drivers/mtd/Kconfig: ## @@ -382,10 +384,10 @@ config AT24XX_SIZE int "AT24xx size (Kbit)" default 64 ---help--- - This is the

Re: [PR] Add MTD for AT25 eeprom [nuttx]

2023-12-22 Thread via GitHub
TimJTi commented on code in PR #11423: URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435117709 ## drivers/mtd/at25ee.c: ## @@ -0,0 +1,1033 @@ +/ + * drivers/mtd/at25ee.c + * + * Licensed

Re: [PR] boards/fvp-armv8r: Update defconfig after running refresh.sh [nuttx]

2023-12-22 Thread via GitHub
xiaoxiang781216 commented on PR #11440: URL: https://github.com/apache/nuttx/pull/11440#issuecomment-1867750958 it's strange that ci doesn't catch this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] apps: Select PIPES when enabling system popen [nuttx-apps]

2023-12-22 Thread via GitHub
xiaoxiang781216 commented on PR #2239: URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1867747126 We found that select expose some bad effect, for example: 1. Feature A depends on Feature C 2. Feature B select Feature C The initial defconfig set both A and C

Re: [I] use SDCard on NuttX question。 [nuttx]

2023-12-22 Thread via GitHub
acassis commented on issue #11420: URL: https://github.com/apache/nuttx/issues/11420#issuecomment-1867735114 @GC-20-20 please double check you board config, I suggest you to look the SDCARD examples for stm32f4discovery and stm32f401rc-rs485. Double checkout all pins and notice that your

Re: [PR] Add MTD for AT25 eeprom [nuttx]

2023-12-22 Thread via GitHub
acassis commented on code in PR #11423: URL: https://github.com/apache/nuttx/pull/11423#discussion_r1435077054 ## drivers/mtd/Kconfig: ## @@ -382,10 +384,10 @@ config AT24XX_SIZE int "AT24xx size (Kbit)" default 64 ---help--- - This is the

Re: [PR] xtensa/espressif/rmt: Implement a common RMT (Remote Control) driver for xtensa-based devices. [nuttx]

2023-12-22 Thread via GitHub
tmedicci commented on code in PR #11428: URL: https://github.com/apache/nuttx/pull/11428#discussion_r1435073212 ## drivers/leds/ws2812.c: ## @@ -55,15 +55,7 @@ * Pre-processor Definitions /

Re: [PR] xtensa/espressif/rmt: Implement a common RMT (Remote Control) driver for xtensa-based devices. [nuttx]

2023-12-22 Thread via GitHub
acassis commented on code in PR #11428: URL: https://github.com/apache/nuttx/pull/11428#discussion_r1435064219 ## drivers/leds/ws2812.c: ## @@ -55,15 +55,7 @@ * Pre-processor Definitions / -#ifdef

Re: [PR] apps: Select PIPES when enabling system popen [nuttx-apps]

2023-12-22 Thread via GitHub
acassis commented on PR #2239: URL: https://github.com/apache/nuttx-apps/pull/2239#issuecomment-1867679286 > here is some recommendation for `select` from zephyr: https://docs.zephyrproject.org/latest/build/kconfig/tips.html#select-recommendations @xiaoxiang781216 in this case

Re: [PR] xtensa/espressif/rmt: Implement a common RMT (Remote Control) driver for xtensa-based devices. [nuttx]

2023-12-22 Thread via GitHub
tmedicci commented on PR #11428: URL: https://github.com/apache/nuttx/pull/11428#issuecomment-1867668719 > but, it's good to use the vendor hal file directly I'm sorry, I didn't understand what you meant. Could you please elaborate a little further? -- This is an automated message

Re: [PR] xtensa/espressif/rmt: Implement a common RMT (Remote Control) driver for xtensa-based devices. [nuttx]

2023-12-22 Thread via GitHub
xiaoxiang781216 commented on PR #11428: URL: https://github.com/apache/nuttx/pull/11428#issuecomment-1867604232 but, it's good to use the vendor hal file directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(nuttx) branch master updated: xtensa/esp32s2: Add xtwdt and rwdt support

2023-12-22 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c15392d9b7 xtensa/esp32s2: Add xtwdt and rwdt

Re: [PR] xtensa/esp32s2: Add xtwdt and rwdt support [nuttx]

2023-12-22 Thread via GitHub
xiaoxiang781216 merged PR #11431: URL: https://github.com/apache/nuttx/pull/11431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update riscv_mmu.h to fix typo in comment [nuttx]

2023-12-22 Thread via GitHub
yf13 opened a new pull request, #11439: URL: https://github.com/apache/nuttx/pull/11439 fix typo in comment of mmu_get_region_size function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(nuttx) branch master updated: fs/fat: Fix number of data clusters usable for fat driver

2023-12-22 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 26b7de0f34 fs/fat: Fix number of data clusters

Re: [PR] fs/fat: Fix number of data clusters usable for fat driver [nuttx]

2023-12-22 Thread via GitHub
jerpelea merged PR #11433: URL: https://github.com/apache/nuttx/pull/11433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated: espressif/mcuboot: Fix dependency of the Espressif's port MCUboot.

2023-12-22 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new daec4cf408 espressif/mcuboot: Fix dependency of

(nuttx) branch master updated: xtensa/esp32s3: Support reading encrypted partitions

2023-12-22 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2cb14c55f0 xtensa/esp32s3: Support reading

Re: [PR] espressif/mcuboot: Fix dependency of the Espressif's port MCUboot. [nuttx]

2023-12-22 Thread via GitHub
anchao merged PR #11437: URL: https://github.com/apache/nuttx/pull/11437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] xtensa/esp32s3: Support reading encrypted partitions [nuttx]

2023-12-22 Thread via GitHub
anchao merged PR #11434: URL: https://github.com/apache/nuttx/pull/11434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: