Re: [PR] apps/nshlib: Never disable HELP and ? [nuttx-apps]
xiaoxiang781216 merged PR #2344: URL: https://github.com/apache/nuttx-apps/pull/2344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx-apps) branch master updated: apps/nshlib: Never disable HELP and ?
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8d14f4eaa apps/nshlib: Never disable HELP and ? 8d14f4eaa is described below commit 8d14f4eaacc679a44158c23288c408ba36f6ffec Author: Alan Carvalho de Assis AuthorDate: Tue Apr 2 15:35:08 2024 -0300 apps/nshlib: Never disable HELP and ? --- nshlib/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nshlib/Kconfig b/nshlib/Kconfig index 40fdceea1..2a183068a 100644 --- a/nshlib/Kconfig +++ b/nshlib/Kconfig @@ -406,7 +406,7 @@ config NSH_DISABLE_GET config NSH_DISABLE_HELP bool "Disable help" - default DEFAULT_SMALL + default n config NSH_DISABLE_ERROR_PRINT bool "Disable NSH Error Printing"
[PR] Minor can driver improvement [nuttx]
xiaoxiang781216 opened a new pull request, #12078: URL: https://github.com/apache/nuttx/pull/12078 ## Summary - can: Remove CANIOC_XXX macro from include/nuttx/can.h - can: Add g_ prefix to can_dlc_to_len and len_to_can_dlc - can: Merge cd_error and rx_overflow into rx_error ## Impact can driver ## Testing internal test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: the bug about rwbuffer causing mem overflow [nuttx]
xiaoxiang781216 commented on PR #12056: URL: https://github.com/apache/nuttx/pull/12056#issuecomment-2040970781 @ChenChuangForLinux please squash into one patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated (7d28420c0b -> 42091492c5)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7d28420c0b xtensa/esp32s3: Fix one page program span over 2 pages add 42091492c5 boards: Fix board configs after disabling NSH_DISABLE_HELP No new revisions were added by this update. Summary of changes: boards/arm/phy62xx/phy6222/configs/phy_sbp/defconfig | 1 - boards/arm/stm32/nucleo-f302r8/configs/qenco/defconfig | 1 - boards/arm/stm32/stm32f103-minimum/configs/nsh/defconfig | 1 - boards/arm/stm32/stm32f103-minimum/configs/ssd1306/defconfig | 1 - boards/arm/stm32/stm32f334-disco/configs/powerled/defconfig | 1 - boards/arm/tlsr82/tlsr8278adk80d/configs/nsh/defconfig | 1 - boards/risc-v/fe310/hifive1-revb/configs/nsh/defconfig | 1 - boards/risc-v/hpm6000/hpm6360evk/configs/nsh/defconfig | 1 - boards/risc-v/hpm6750/hpm6750evk2/configs/nsh/defconfig | 1 - boards/risc-v/qemu-rv/rv-virt/configs/smp/defconfig | 1 - boards/risc-v/qemu-rv/rv-virt/configs/smp64/defconfig| 1 - 11 files changed, 11 deletions(-)
(nuttx) branch releases/12.5 updated: SMP: Fix returning uninitialized variable in nxsched_add_readytorun()
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new 95c5426a18 SMP: Fix returning uninitialized variable in nxsched_add_readytorun() 95c5426a18 is described below commit 95c5426a1872d027e6f4c1babeb3242ce13eeb5c Author: Mingjie Shen AuthorDate: Mon Apr 1 20:36:37 2024 -0400 SMP: Fix returning uninitialized variable in nxsched_add_readytorun() Prior to this commit, doswitch is returned uninitialized if (task_state == TSTATE_TASK_ASSIGNED || task_state == TSTATE_TASK_RUNNING) && no context switch occurs && (cpu == me). Signed-off-by: Mingjie Shen --- sched/sched/sched_addreadytorun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sched/sched/sched_addreadytorun.c b/sched/sched/sched_addreadytorun.c index 46c0ef9d4d..eb0957c92a 100644 --- a/sched/sched/sched_addreadytorun.c +++ b/sched/sched/sched_addreadytorun.c @@ -366,6 +366,7 @@ bool nxsched_add_readytorun(FAR struct tcb_s *btcb) btcb->cpu= cpu; btcb->task_state = TSTATE_TASK_ASSIGNED; + doswitch = false; } /* All done, restart the other CPU (if it was paused). */
Re: [PR] {bp-12031} SMP: Fix returning uninitialized variable in nxsched_add_readytorun() [nuttx]
xiaoxiang781216 merged PR #12062: URL: https://github.com/apache/nuttx/pull/12062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated: boards: raspberrypi-pico: Fix nshsram build error
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new cb00232b70 boards: raspberrypi-pico: Fix nshsram build error cb00232b70 is described below commit cb00232b700055b5beaa4cb559663bcb50708b49 Author: Masayuki Ishikawa AuthorDate: Sun Mar 31 13:45:57 2024 +0900 boards: raspberrypi-pico: Fix nshsram build error Summary: - This commit fixes https://github.com/apache/nuttx/issues/11956. - The issue was introduced by https://github.com/apache/nuttx/pull/6118. Impact: - None Testing: - Tested with raspberrypi-pico. - NOTE: the ci should be fixed later. Signed-off-by: Masayuki Ishikawa --- boards/arm/rp2040/raspberrypi-pico/configs/nshsram/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boards/arm/rp2040/raspberrypi-pico/configs/nshsram/defconfig b/boards/arm/rp2040/raspberrypi-pico/configs/nshsram/defconfig index 5a5342830e..fc30f62f79 100644 --- a/boards/arm/rp2040/raspberrypi-pico/configs/nshsram/defconfig +++ b/boards/arm/rp2040/raspberrypi-pico/configs/nshsram/defconfig @@ -5,6 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # +# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set # CONFIG_LIBC_LONG_LONG is not set # CONFIG_NSH_ARGCAT is not set # CONFIG_NSH_CMDOPT_HEXDUMP is not set
Re: [PR] {bp-11992} esp32[c3|c6|h2]: Fix filesystem test support [nuttx]
xiaoxiang781216 merged PR #12069: URL: https://github.com/apache/nuttx/pull/12069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {Bp-12028} boards: rp2040: Fix build errors for nshsram configurations [nuttx]
xiaoxiang781216 merged PR #12063: URL: https://github.com/apache/nuttx/pull/12063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated (42091492c5 -> 5ef9a003c4)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from 42091492c5 boards: Fix board configs after disabling NSH_DISABLE_HELP add 5ef9a003c4 risc-v/espressif: Fix empty cpuint number No new revisions were added by this update. Summary of changes: arch/risc-v/src/common/espressif/esp_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(nuttx) branch releases/12.5 updated (36e94457ef -> 54352dab2c)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from 36e94457ef all: Fix accessing uninitialized local variables add 54352dab2c drivers/net/lan9250: Fix crash issue of sending packets by lan9250 driver under SMP and multi-thread No new revisions were added by this update. Summary of changes: drivers/net/lan9250.c | 29 ++--- 1 file changed, 2 insertions(+), 27 deletions(-)
(nuttx) branch releases/12.5 updated: all: Fix accessing uninitialized local variables
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new 36e94457ef all: Fix accessing uninitialized local variables 36e94457ef is described below commit 36e94457ef0c2f00c207f4b18808fd259ff13230 Author: Mingjie Shen AuthorDate: Wed Apr 3 14:57:12 2024 -0400 all: Fix accessing uninitialized local variables Prior to this commit, in elf_emit() and elf_emit_align(), ret was uninitialized if total was 0. Signed-off-by: Mingjie Shen --- arch/arm/src/cxd56xx/cxd56_nxaudio.c | 4 ++-- arch/arm/src/kinetis/kinetis_usbdev.c | 2 +- binfmt/libelf/libelf_coredump.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/src/cxd56xx/cxd56_nxaudio.c b/arch/arm/src/cxd56xx/cxd56_nxaudio.c index 655157..2831b6e0cf 100644 --- a/arch/arm/src/cxd56xx/cxd56_nxaudio.c +++ b/arch/arm/src/cxd56xx/cxd56_nxaudio.c @@ -2020,8 +2020,8 @@ static int cxd56_set_mic_gains(uint8_t gain, enum cxd56_mic_type_e mic_dev, static void cxd56_get_mic_config(uint8_t *count, uint8_t *dev, uint8_t *mode) { uint8_t i; - uint8_t is_dmic; - uint8_t is_amic; + bool is_dmic = false; + bool is_amic = false; uint8_t mic_sel = 0; uint8_t mic_count = 0; diff --git a/arch/arm/src/kinetis/kinetis_usbdev.c b/arch/arm/src/kinetis/kinetis_usbdev.c index f60a074651..ccf5f1ba42 100644 --- a/arch/arm/src/kinetis/kinetis_usbdev.c +++ b/arch/arm/src/kinetis/kinetis_usbdev.c @@ -3370,7 +3370,7 @@ static int khci_epconfigure(struct usbdev_ep_s *ep, uint32_t regval; uint8_t epno; bool epin; - bool bidi; + bool bidi = false; int index; #ifdef CONFIG_DEBUG_FEATURES diff --git a/binfmt/libelf/libelf_coredump.c b/binfmt/libelf/libelf_coredump.c index 868deab9d8..4e3e85783a 100644 --- a/binfmt/libelf/libelf_coredump.c +++ b/binfmt/libelf/libelf_coredump.c @@ -91,7 +91,7 @@ static int elf_emit(FAR struct elf_dumpinfo_s *cinfo, { FAR const uint8_t *ptr = buf; size_t total = len; - int ret; + int ret = 0; while (total > 0) { @@ -122,7 +122,7 @@ static int elf_emit_align(FAR struct elf_dumpinfo_s *cinfo) ELF_PAGESIZE) - cinfo->stream->nput; unsigned char null[256]; off_t total = align; - off_t ret; + off_t ret = 0; memset(null, 0, sizeof(null));
(nuttx) branch releases/12.5 updated (9ee6928382 -> 47f2bf5788)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9ee6928382 stm32h7:Serial Fix Logic error in up_dma_txavailable add 47f2bf5788 arch/arm/src/s32k3xx: Fix incorrect check for invalid port or pin number No new revisions were added by this update. Summary of changes: arch/arm/src/s32k3xx/s32k3xx_pin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [PR] {bp-12046} arch/arm/src/s32k3xx: Fix incorrect check for invalid port or pin number [nuttx]
xiaoxiang781216 merged PR #12072: URL: https://github.com/apache/nuttx/pull/12072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {Bp-12036} risc-v/espressif: Fix empty cpuint number [nuttx]
xiaoxiang781216 merged PR #12061: URL: https://github.com/apache/nuttx/pull/12061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-11990} stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]
xiaoxiang781216 merged PR #12070: URL: https://github.com/apache/nuttx/pull/12070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-11998} mm/kmap.h: fix typo in comments [nuttx]
xiaoxiang781216 merged PR #12068: URL: https://github.com/apache/nuttx/pull/12068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-12038} boards: Fix board configs after disabling NSH_DISABLE_HELP [nuttx]
xiaoxiang781216 merged PR #12060: URL: https://github.com/apache/nuttx/pull/12060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-11994} drivers/video/isx019: Fix default_value of 3A status [nuttx]
xiaoxiang781216 merged PR #12067: URL: https://github.com/apache/nuttx/pull/12067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated: xtensa/esp32s3: Fix one page program span over 2 pages
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new 7d28420c0b xtensa/esp32s3: Fix one page program span over 2 pages 7d28420c0b is described below commit 7d28420c0b5408063f33d3c2c3986b7025cabe4c Author: Dong Heng AuthorDate: Tue Mar 19 14:35:53 2024 +0800 xtensa/esp32s3: Fix one page program span over 2 pages One page program can't span over 2 pages. --- arch/xtensa/src/esp32s3/esp32s3_spiflash.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/xtensa/src/esp32s3/esp32s3_spiflash.c b/arch/xtensa/src/esp32s3/esp32s3_spiflash.c index 3054e60815..f17408631f 100644 --- a/arch/xtensa/src/esp32s3/esp32s3_spiflash.c +++ b/arch/xtensa/src/esp32s3/esp32s3_spiflash.c @@ -99,6 +99,7 @@ /* SPI flash hardware definition */ +# define FLASH_PAGE_SIZE (256) # define FLASH_SECTOR_SIZE (4096) /* SPI flash command */ @@ -1181,10 +1182,11 @@ int spi_flash_write(uint32_t dest_addr, const void *buffer, uint32_t size) spiflash_start(); - for (int i = 0; i < size; i += SPI_BUFFER_BYTES) + while (tx_bytes) { uint32_t spi_buffer[SPI_BUFFER_WORDS]; - uint32_t n = MIN(tx_bytes, SPI_BUFFER_BYTES); + uint32_t n = FLASH_PAGE_SIZE - tx_addr % FLASH_PAGE_SIZE; + n = MIN(n, MIN(tx_bytes, SPI_BUFFER_BYTES)); #ifdef CONFIG_ESP32S3_SPIRAM
Re: [PR] {bp-12008} xtensa/esp32s3: Fix one page program span over 2 pages [nuttx]
xiaoxiang781216 merged PR #12065: URL: https://github.com/apache/nuttx/pull/12065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-12024} boards: raspberrypi-pico: Fix nshsram build error [nuttx]
xiaoxiang781216 merged PR #12064: URL: https://github.com/apache/nuttx/pull/12064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated: boards: rp2040: Fix build errors for nshsram configurations
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new cfe6d0bcbe boards: rp2040: Fix build errors for nshsram configurations cfe6d0bcbe is described below commit cfe6d0bcbe3555ff13037b5b1dd2e3d66a29cc9e Author: Masayuki Ishikawa AuthorDate: Mon Apr 1 12:45:22 2024 +0900 boards: rp2040: Fix build errors for nshsram configurations Summary: - This commit applies the fix in https://github.com/apache/nuttx/pull/12025 Impact: - None Testing: - Build only Signed-off-by: Masayuki Ishikawa --- boards/arm/rp2040/adafruit-feather-rp2040/configs/nshsram/defconfig | 1 + boards/arm/rp2040/adafruit-kb2040/configs/nshsram/defconfig | 1 + boards/arm/rp2040/pimoroni-tiny2040/configs/nshsram/defconfig | 1 + boards/arm/rp2040/raspberrypi-pico-w/configs/nshsram/defconfig| 1 + boards/arm/rp2040/waveshare-rp2040-lcd-1.28/configs/nshsram/defconfig | 1 + 5 files changed, 5 insertions(+) diff --git a/boards/arm/rp2040/adafruit-feather-rp2040/configs/nshsram/defconfig b/boards/arm/rp2040/adafruit-feather-rp2040/configs/nshsram/defconfig index e7e942bb5d..afe57d66cb 100644 --- a/boards/arm/rp2040/adafruit-feather-rp2040/configs/nshsram/defconfig +++ b/boards/arm/rp2040/adafruit-feather-rp2040/configs/nshsram/defconfig @@ -5,6 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # +# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set # CONFIG_LIBC_LONG_LONG is not set # CONFIG_NSH_ARGCAT is not set # CONFIG_NSH_CMDOPT_HEXDUMP is not set diff --git a/boards/arm/rp2040/adafruit-kb2040/configs/nshsram/defconfig b/boards/arm/rp2040/adafruit-kb2040/configs/nshsram/defconfig index 6f36d88406..0de8616254 100644 --- a/boards/arm/rp2040/adafruit-kb2040/configs/nshsram/defconfig +++ b/boards/arm/rp2040/adafruit-kb2040/configs/nshsram/defconfig @@ -5,6 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # +# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set # CONFIG_LIBC_LONG_LONG is not set # CONFIG_NSH_ARGCAT is not set # CONFIG_NSH_CMDOPT_HEXDUMP is not set diff --git a/boards/arm/rp2040/pimoroni-tiny2040/configs/nshsram/defconfig b/boards/arm/rp2040/pimoroni-tiny2040/configs/nshsram/defconfig index 5915108f7e..19a92fc897 100644 --- a/boards/arm/rp2040/pimoroni-tiny2040/configs/nshsram/defconfig +++ b/boards/arm/rp2040/pimoroni-tiny2040/configs/nshsram/defconfig @@ -5,6 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # +# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set # CONFIG_LIBC_LONG_LONG is not set # CONFIG_NSH_ARGCAT is not set # CONFIG_NSH_CMDOPT_HEXDUMP is not set diff --git a/boards/arm/rp2040/raspberrypi-pico-w/configs/nshsram/defconfig b/boards/arm/rp2040/raspberrypi-pico-w/configs/nshsram/defconfig index f69cc43740..5f3d066d51 100644 --- a/boards/arm/rp2040/raspberrypi-pico-w/configs/nshsram/defconfig +++ b/boards/arm/rp2040/raspberrypi-pico-w/configs/nshsram/defconfig @@ -5,6 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # +# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set # CONFIG_LIBC_LONG_LONG is not set # CONFIG_NSH_ARGCAT is not set # CONFIG_NSH_CMDOPT_HEXDUMP is not set diff --git a/boards/arm/rp2040/waveshare-rp2040-lcd-1.28/configs/nshsram/defconfig b/boards/arm/rp2040/waveshare-rp2040-lcd-1.28/configs/nshsram/defconfig index f4e28c41f2..850afe706d 100644 --- a/boards/arm/rp2040/waveshare-rp2040-lcd-1.28/configs/nshsram/defconfig +++ b/boards/arm/rp2040/waveshare-rp2040-lcd-1.28/configs/nshsram/defconfig @@ -5,6 +5,7 @@ # You can then do "make savedefconfig" to generate a new defconfig file that includes your # modifications. # +# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set # CONFIG_LIBC_LONG_LONG is not set # CONFIG_NSH_ARGCAT is not set # CONFIG_NSH_CMDOPT_HEXDUMP is not set
(nuttx) branch releases/12.5 updated (a406de7868 -> 2806667491)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from a406de7868 arch/arm/src/am335x: Fix incorrect signedness of variable add 2806667491 esp32[c3|c6|h2]: Fix filesystem test support No new revisions were added by this update. Summary of changes: arch/risc-v/src/common/espressif/Make.defs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(nuttx) branch releases/12.5 updated (54352dab2c -> a406de7868)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from 54352dab2c drivers/net/lan9250: Fix crash issue of sending packets by lan9250 driver under SMP and multi-thread add a406de7868 arch/arm/src/am335x: Fix incorrect signedness of variable No new revisions were added by this update. Summary of changes: arch/arm/src/am335x/am335x_lcdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Re: [PR] {bp-12047} arch/arm/src/am335x: Fix incorrect signedness of variable [nuttx]
xiaoxiang781216 merged PR #12071: URL: https://github.com/apache/nuttx/pull/12071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-12042} drivers/net/lan9250: Fix crash issue of sending packets by lan9250 dr… [nuttx]
xiaoxiang781216 merged PR #12074: URL: https://github.com/apache/nuttx/pull/12074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] {bp-12045} all: Fix accessing uninitialized local variables [nuttx]
xiaoxiang781216 merged PR #12073: URL: https://github.com/apache/nuttx/pull/12073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated (42f8a9b48f -> 9ee6928382)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from 42f8a9b48f mm/kmap.h: fix typo in comments add 9ee6928382 stm32h7:Serial Fix Logic error in up_dma_txavailable No new revisions were added by this update. Summary of changes: arch/arm/src/stm32h7/stm32_serial.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
(nuttx) branch releases/12.5 updated (cbd322c6f4 -> 42f8a9b48f)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git from cbd322c6f4 drivers/video/isx019: Fix default_value of 3A status add 42f8a9b48f mm/kmap.h: fix typo in comments No new revisions were added by this update. Summary of changes: include/nuttx/mm/kmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(nuttx) branch releases/12.5 updated: drivers/video/isx019: Fix default_value of 3A status
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new cbd322c6f4 drivers/video/isx019: Fix default_value of 3A status cbd322c6f4 is described below commit cbd322c6f4c2bc0409efb5541c63d053a21d97b2 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate: Tue Mar 12 19:50:58 2024 +0900 drivers/video/isx019: Fix default_value of 3A status Fix default_value of ioctl(VIDIOC_QUERYCTRL)(id=V4L2_CID_3A_STATUS) to AE operating and AWB operating, because both AE and AWB are automatical adjustment mode by default. --- drivers/video/isx019.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/video/isx019.c b/drivers/video/isx019.c index bd1a5938b9..75b8ba1fc6 100644 --- a/drivers/video/isx019.c +++ b/drivers/video/isx019.c @@ -196,15 +196,12 @@ struct isx019_default_value_s int32_t vflip_still; int32_t sharpness; int32_t ae; - int32_t exptime; int32_t wbmode; int32_t hdr; - int32_t iso; int32_t iso_auto; int32_t meter; int32_t spot_pos; int32_t threealock; - int32_t threeastatus; int32_t jpgquality; }; @@ -1355,15 +1352,12 @@ static void store_default_value(FAR isx019_dev_t *priv) def->vflip_still = get_value32(priv, IMGSENSOR_ID_VFLIP_STILL); def->sharpness= get_value32(priv, IMGSENSOR_ID_SHARPNESS); def->ae = get_value32(priv, IMGSENSOR_ID_EXPOSURE_AUTO); - def->exptime = get_value32(priv, IMGSENSOR_ID_EXPOSURE_ABSOLUTE); def->wbmode = get_value32(priv, IMGSENSOR_ID_AUTO_N_PRESET_WB); def->hdr = get_value32(priv, IMGSENSOR_ID_WIDE_DYNAMIC_RANGE); - def->iso = get_value32(priv, IMGSENSOR_ID_ISO_SENSITIVITY); def->iso_auto = get_value32(priv, IMGSENSOR_ID_ISO_SENSITIVITY_AUTO); def->meter= get_value32(priv, IMGSENSOR_ID_EXPOSURE_METERING); def->spot_pos = get_value32(priv, IMGSENSOR_ID_SPOT_POSITION); def->threealock = get_value32(priv, IMGSENSOR_ID_3A_LOCK); - def->threeastatus = get_value32(priv, IMGSENSOR_ID_3A_STATUS); def->jpgquality = get_value32(priv, IMGSENSOR_ID_JPEG_QUALITY); } @@ -2045,8 +2039,10 @@ static int isx019_get_supported_value(FAR struct imgsensor_s *sensor, case IMGSENSOR_ID_3A_STATUS: val->type = IMGSENSOR_CTRL_TYPE_INTEGER; -SET_RANGE(val->u.range, MIN_3ASTATUS, MAX_3ASTATUS, -STEP_3ASTATUS, def->threeastatus); +SET_RANGE(val->u.range, MIN_3ASTATUS, +MAX_3ASTATUS, STEP_3ASTATUS, +IMGSENSOR_3A_STATUS_AE_OPERATING +| IMGSENSOR_3A_STATUS_AWB_OPERATING); break; case IMGSENSOR_ID_JPEG_QUALITY:
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller and I2S pin selection range fixed [nuttx]
xiaoxiang781216 commented on code in PR #12076: URL: https://github.com/apache/nuttx/pull/12076#discussion_r1554526338 ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE config ESP32S3_I2S0_BCLKPIN int "I2S0 BCLK pin" default 4 - range 0 33 if ESP32S3_I2S0_ROLE_MASTER - range 0 39 if ESP32S3_I2S0_ROLE_SLAVE + range 0 48 if ESP32S3_I2S0_ROLE_MASTER + range 0 48 if ESP32S3_I2S0_ROLE_SLAVE config ESP32S3_I2S0_WSPIN int "I2S0 WS pin" default 5 - range 0 33 if ESP32S3_I2S0_ROLE_MASTER - range 0 39 if ESP32S3_I2S0_ROLE_SLAVE + range 0 48 if ESP32S3_I2S0_ROLE_MASTER + range 0 48 if ESP32S3_I2S0_ROLE_SLAVE Review Comment: merge to `range 0 48` ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -478,26 +478,26 @@ config ESP32S3_I2S1_SAMPLE_RATE config ESP32S3_I2S1_BCLKPIN int "I2S1 BCLK pin" default 22 - range 0 33 if ESP32S3_I2S1_ROLE_MASTER - range 0 39 if ESP32S3_I2S1_ROLE_SLAVE + range 0 48 if ESP32S3_I2S1_ROLE_MASTER + range 0 48 if ESP32S3_I2S1_ROLE_SLAVE config ESP32S3_I2S1_WSPIN int "I2S1 WS pin" default 23 - range 0 33 if ESP32S3_I2S1_ROLE_MASTER - range 0 39 if ESP32S3_I2S1_ROLE_SLAVE + range 0 48 if ESP32S3_I2S1_ROLE_MASTER + range 0 48 if ESP32S3_I2S1_ROLE_SLAVE Review Comment: merge to `range 0 48` ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -478,26 +478,26 @@ config ESP32S3_I2S1_SAMPLE_RATE config ESP32S3_I2S1_BCLKPIN int "I2S1 BCLK pin" default 22 - range 0 33 if ESP32S3_I2S1_ROLE_MASTER - range 0 39 if ESP32S3_I2S1_ROLE_SLAVE + range 0 48 if ESP32S3_I2S1_ROLE_MASTER + range 0 48 if ESP32S3_I2S1_ROLE_SLAVE Review Comment: merge to `range 0 48` ## arch/xtensa/src/esp32s3/Kconfig: ## @@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE config ESP32S3_I2S0_BCLKPIN int "I2S0 BCLK pin" default 4 - range 0 33 if ESP32S3_I2S0_ROLE_MASTER - range 0 39 if ESP32S3_I2S0_ROLE_SLAVE + range 0 48 if ESP32S3_I2S0_ROLE_MASTER + range 0 48 if ESP32S3_I2S0_ROLE_SLAVE Review Comment: merge to `range 0 48` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch releases/12.5 updated: drivers/video/isx019: Fix the default_value of some parameters
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch releases/12.5 in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/releases/12.5 by this push: new 64ab05457a drivers/video/isx019: Fix the default_value of some parameters 64ab05457a is described below commit 64ab05457abeb7e638a55311cb818a6b3b9998f4 Author: SPRESENSE <41312067+sprese...@users.noreply.github.com> AuthorDate: Thu Feb 29 22:18:47 2024 +0900 drivers/video/isx019: Fix the default_value of some parameters Because the exposure time and ISO sensitivity are adjusted automatically by default, the default value can not be defined. So, return the value out of range as the default_value of ioctl(VIDIOC_QUERYCTRL). --- drivers/video/isx019.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/isx019.c b/drivers/video/isx019.c index 794cbc3736..bd1a5938b9 100644 --- a/drivers/video/isx019.c +++ b/drivers/video/isx019.c @@ -1984,7 +1984,7 @@ static int isx019_get_supported_value(FAR struct imgsensor_s *sensor, case IMGSENSOR_ID_EXPOSURE_ABSOLUTE: val->type = IMGSENSOR_CTRL_TYPE_INTEGER; SET_RANGE(val->u.range, MIN_EXPOSURETIME, MAX_EXPOSURETIME, -STEP_EXPOSURETIME, def->exptime); +STEP_EXPOSURETIME, 0); /* 0 means undefined */ break; case IMGSENSOR_ID_AUTO_N_PRESET_WB: @@ -2006,7 +2006,7 @@ static int isx019_get_supported_value(FAR struct imgsensor_s *sensor, SET_DISCRETE(val->u.discrete, NR_ISO, g_isx019_iso, - def->iso); + 0); /* 0 means undefined */ break; case IMGSENSOR_ID_ISO_SENSITIVITY_AUTO:
(nuttx) branch master updated: arch/arm/src/samv7/sam_pwm.c: adjust arch driver to DCPOL options
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new bf3a5bb4cb arch/arm/src/samv7/sam_pwm.c: adjust arch driver to DCPOL options bf3a5bb4cb is described below commit bf3a5bb4cbbd760112216ca87f79a0577cd29262 Author: Pressl, Štěpán AuthorDate: Fri Apr 5 16:56:05 2024 +0200 arch/arm/src/samv7/sam_pwm.c: adjust arch driver to DCPOL options Signed-off-by: Stepan Pressl --- arch/arm/src/samv7/sam_pwm.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/arch/arm/src/samv7/sam_pwm.c b/arch/arm/src/samv7/sam_pwm.c index 662db65854..2bfc60377d 100644 --- a/arch/arm/src/samv7/sam_pwm.c +++ b/arch/arm/src/samv7/sam_pwm.c @@ -332,7 +332,7 @@ static void pwm_set_deadtime(struct pwm_lowerhalf_s *dev, uint8_t channel, ub16_t duty); #endif static void pwm_set_polarity(struct pwm_lowerhalf_s *dev, uint8_t channel, - uint8_t cpol); + uint8_t cpol, uint8_t dcpol); / * Private Functions @@ -631,6 +631,7 @@ static void pwm_set_deadtime(struct pwm_lowerhalf_s *dev, uint8_t channel, * dev - A reference to the lower half PWM driver state structure * channel - Channel to by updated * cpol- Desired polarity + * dcpol - Desired default polarity of a disabled channel * * Returned Value: * None @@ -638,18 +639,26 @@ static void pwm_set_deadtime(struct pwm_lowerhalf_s *dev, uint8_t channel, / static void pwm_set_polarity(struct pwm_lowerhalf_s *dev, uint8_t channel, - uint8_t cpol) + uint8_t cpol, uint8_t dcpol) { struct sam_pwm_s *priv = (struct sam_pwm_s *)dev; uint16_t regval; regval = pwm_getreg(priv, SAMV7_PWM_CMRX + (channel * CHANNEL_OFFSET)); regval &= ~CMR_CPOL; + regval &= ~CMR_DPOLI; + if (cpol == PWM_CPOL_HIGH) { regval |= CMR_CPOL; } + if ((dcpol == PWM_DCPOL_LOW && cpol == PWM_CPOL_HIGH) || + (dcpol == PWM_DCPOL_HIGH && cpol == PWM_CPOL_LOW)) +{ + regval |= CMR_DPOLI; +} + pwm_putreg(priv, SAMV7_PWM_CMRX + (channel * CHANNEL_OFFSET), regval); } @@ -846,7 +855,8 @@ static int pwm_start(struct pwm_lowerhalf_s *dev, info->channels[i].duty); #endif pwm_set_polarity(dev, priv->channels[index - 1].channel, - info->channels[i].cpol); + info->channels[i].cpol, + info->channels[i].dcpol); pwm_set_output(dev, priv->channels[index - 1].channel, info->channels[i].duty); #ifdef CONFIG_PWM_OVERWRITE @@ -879,7 +889,7 @@ static int pwm_start(struct pwm_lowerhalf_s *dev, info->dead_time_a, info->dead_time_b); #endif pwm_set_polarity(dev, priv->channels[0].channel, - info->cpol); + info->cpol, info->dcpol); pwm_set_output(dev, priv->channels[0].channel, info->duty); #endif
Re: [PR] {bp-11999} drivers/video/isx019: Fix the default_value of some parameters [nuttx]
xiaoxiang781216 merged PR #12066: URL: https://github.com/apache/nuttx/pull/12066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm/src/samv7/sam_pwm.c: adjust arch driver to DCPOL options [nuttx]
xiaoxiang781216 merged PR #12077: URL: https://github.com/apache/nuttx/pull/12077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] sched: Introduce Bound Multi-Processing (BMP) into NuttX [nuttx]
zouboan commented on PR #12020: URL: https://github.com/apache/nuttx/pull/12020#issuecomment-2040954735 What is the difference between this approach and the pthread_setaffinity_np functions implemented by NuttX?Does threads spawned by a task bound to a specific processor can also be automatically bound to that processor with this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] sched: Introduce Bound Multi-Processing (BMP) into NuttX [nuttx]
zouboan commented on PR #12020: URL: https://github.com/apache/nuttx/pull/12020#issuecomment-2040954483 What is the difference between this approach and the pthread_setaffinity_np functions implemented by NuttX?Does threads spawned by a task bound to a specific processor can also be automatically bound to that processor with this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx-website) branch asf-site updated: Publishing web: 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f docs: 21de46a4d12087fda42e982dd9745fe926376b31
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 2affede95 Publishing web: 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f docs: 21de46a4d12087fda42e982dd9745fe926376b31 2affede95 is described below commit 2affede9511293451efdf9a82fc14949cc3dfaad Author: Alin Jerpelea AuthorDate: Sat Apr 6 00:16:19 2024 + Publishing web: 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f docs: 21de46a4d12087fda42e982dd9745fe926376b31 --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.0/searchindex.js | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/10.0.1/searchindex.js | 2 +- content/docs/10.1.0/index.html | 2 +- content/docs/10.1.0/searchindex.js | 2 +- content/docs/10.2.0/index.html | 2 +- content/docs/10.2.0/searchindex.js | 2 +- content/docs/10.3.0/index.html | 2 +- content/docs/10.3.0/searchindex.js | 2 +- content/docs/11.0.0/index.html | 2 +- content/docs/11.0.0/searchindex.js | 2 +- content/docs/12.0.0/index.html | 2 +- content/docs/12.0.0/searchindex.js | 2 +- content/docs/12.1.0/index.html | 2 +- content/docs/12.1.0/searchindex.js | 2 +- content/docs/12.2.0/index.html | 2 +- content/docs/12.2.0/searchindex.js | 2 +- content/docs/12.2.1/index.html | 2 +- content/docs/12.2.1/searchindex.js | 2 +- content/docs/12.3.0/index.html | 2 +- content/docs/12.3.0/searchindex.js | 2 +- content/docs/12.4.0/index.html | 2 +- content/docs/12.4.0/searchindex.js | 2 +- content/docs/12.5.0/index.html | 2 +- content/docs/12.5.0/searchindex.js | 2 +- content/docs/latest/index.html | 2 +- content/docs/latest/searchindex.js | 2 +- content/feed.xml | 4 ++-- 29 files changed, 30 insertions(+), 30 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 17f69e7c5..7a30647a1 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -131,7 +131,7 @@ by following these NuttX Documentation NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 05 April 24 at 12:31 +Last Updated: 06 April 24 at 00:09 Table of Contents diff --git a/content/docs/10.0.0/searchindex.js b/content/docs/10.0.0/searchindex.js index 99ee4f3a3..310e3988b 100644 --- a/content/docs/10.0.0/searchindex.js +++ b/content/docs/10.0.0/searchindex.js @@ -1 +1 @@ -Search.setIndex({"docnames": ["applications/index", "boards/index", "components/binfmt", "components/drivers/block/index", "components/drivers/character/analog", "components/drivers/character/can", "components/drivers/character/index", "components/drivers/character/keypad", "components/drivers/character/pwm", "components/drivers/character/quadrature", "components/drivers/character/rtc", "components/drivers/character/serial", "components/drivers/character/timer", "components/drivers/chara [...] \ No newline at end of file +Search.setIndex({"docnames": ["applications/index", "boards/index", "components/binfmt", "components/drivers/block/index", "components/drivers/character/analog", "components/drivers/character/can", "components/drivers/character/index", "components/drivers/character/keypad", "components/drivers/character/pwm", "components/drivers/character/quadrature", "components/drivers/character/rtc", "components/drivers/character/serial", "components/drivers/character/timer", "components/drivers/chara [...] \ No newline at end of file diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 09f3ab19c..45bad61d2 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -157,7 +157,7 @@ by following these NuttX Documentation NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 05 April 24 at 12:31 +Last Updated: 06 April 24 at 00:09 Table of Contents diff --git a/content/docs/10.0.1/searchindex.js b/content/docs/10.0.1/searchindex.js index 591a14918..943223bb7 100644
[PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller.and I2s pin selection range fixed [nuttx]
omar-faruk opened a new pull request, #12076: URL: https://github.com/apache/nuttx/pull/12076 ## Summary 1. ESP32S3 GPIO pin 19 or 20 by default connected to USB/JTAG controller. When using pin 19 or 20 as GPIO, disable USB/JTAG 2. arch/xtensa/src/esp32s3/Kconfig updated: I2S BCLK, WSPIN, DINPIN, DOUTPIN pin range changed to 0 48 ## Impact pin 19, 20 can be used for other purposes. pins > 33 can now be used for I2S0 and I2S1 in ESP32S3 ## Testing Tested on ESP32S3-WROOM-1, ESP32S3-MINI-1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
omar-faruk commented on PR #12055: URL: https://github.com/apache/nuttx/pull/12055#issuecomment-2040682101 @acassis I accidentally deleted the commit on my repo and closed the pull request. I'll create a new pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
omar-faruk closed pull request #12055: ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. URL: https://github.com/apache/nuttx/pull/12055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] include/nuttx/timers/pwm.h: add dcpol attribute to pwm_chan_s [nuttx]
acassis merged PR #12075: URL: https://github.com/apache/nuttx/pull/12075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch master updated (17e1d43f6d -> 21de46a4d1)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 17e1d43f6d ioexpander/icjx: add support for change of input interrupts on NINT add 21de46a4d1 include/nuttx/timers/pwm.h: add dcpol attribute to pwm_chan_s No new revisions were added by this update. Summary of changes: include/nuttx/timers/pwm.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-)
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
jlaitine commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554229290 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: Actually the interesting part here is that the PWM interface doesn't really define what is exactly the range of the input - it is between 0x. and 0x. for sure, but what are the expected pulses at the limits? Many of the PWM HW blocks actually output one-clock pulses if duty is set to 0, and valid range is from 0x0 - 0x.. And again, they produce one clock inactive cycle if the duty is set to maximum. That is, there is no real possibility to turn off the PWM by setting duty to 0 or to max, which would be intuitive. And is there any REAL reason for the + 0.5 rounding ( + 0x.8000 or b16HALF), which is there in every PWM driver. +/-1 doesn't really make any difference in the 16-bit output (lack of rounding would produce an error which is just theoretical...) Anyhow, this implementation follows the same math as (most of the) other pwm drivers, and works in practice for us (running drone pwm ESCs / motors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
jlaitine commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554229290 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: Actually the interesting part here is that the PWM interface doesn't really define what is exactly the range of the input - it is between 0x. and 0x for sure, but what are the expected pulses at the limits? Many of the PWM HW blocks actually output one-clock pulses if duty is set to 0, and valid range is from 0x0 - 0x.. And again, they produce one clock inactive cycle if the duty is set to maximum. That is, there is no real possibility to turn off the PWM by setting duty to 0 or to max, which would be intuitive. And is there any REAL reason for the + 0.5 rounding ( + 0x.8000 or b16HALF), which is there in every PWM driver. +/-1 doesn't really make any difference in the 16-bit output (lack of rounding would produce an error which is just theoretical...) Anyhow, this implementation follows the same math as (most of the) other pwm drivers, and works in practice for us (running drone pwm ESCs / motors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
jlaitine commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554193299 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: The equation is basically the same... ub16 is just fixed point value packed in 32 bits in form 16bits.16bits (16 bits integer + 16 bits decimal). The mask just takes the decimal part; and is not strictly needed as the input value is between 0-1 (upper 16 bits should be 0). After multiplication, the result is then shifted right 16 bits (since there were 16 digits for decimals and we want to discard them after the multiplication). IMHO using ub macros makes it more confusing here; the ub16toui just does the shift, and obviously b16half is 0.5 in decimal and 0.1 in binary (.8000 in ub16 hex...) This is the same form as what i used in the tpm_pwm driver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
jlaitine commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554193299 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: The equation is basically the same... ub16 is just fixed point value packed in 32 bits in form 16bits.16bits (16 bits integer + 16 bits decimal). The mask just takes the decimal part; and is not strictly needed as the input value is between 0-1 (upper 16 bits should be 0). After multiplication, the result is then shifted right 16 bits (since there were 16 digits for decimals). IMHO using ub macros makes it more confusing here; the ub16toui just does the shift, and obviously b16half is 0.5 in decimal and 0.1 in binary (.8000 in ub16 hex...) This is the same form as what i used in the tpm_pwm driver -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
pkarashchenko commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554166675 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: SAMv7 uses ` width = b16toi(duty * period + b16HALF);`. Maybe we can use the same approach here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
pkarashchenko commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554159979 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: I've been looking into SAMv7 PWM while in the past and need to refresh my knowledge. I will try to look today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
acassis commented on PR #12055: URL: https://github.com/apache/nuttx/pull/12055#issuecomment-2040440733 @omar-faruk @tmedicci as I predicted : Error: /home/runner/work/nuttx/nuttx/nuttx/arch/xtensa/src/esp32s3/esp32s3_gpio.c:217:51: error: Dangling whitespace at the end of line Please remove space after "|" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
acassis commented on code in PR #12055: URL: https://github.com/apache/nuttx/pull/12055#discussion_r1554095287 ## arch/xtensa/src/esp32s3/esp32s3_gpio.c: ## @@ -207,6 +208,17 @@ int esp32s3_configgpio(uint32_t pin, gpio_pinattr_t attr) func = 0; cntrl = 0; + /* if pin 19 or 20 disable the USB/JTAG function and pull-up */ + + if (pin == 19 || pin == 20) +{ + uint32_t regval; + regval = getreg32(USB_SERIAL_JTAG_CONF0_REG); + regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE | + USB_SERIAL_JTAG_DP_PULLUP); Review Comment: @tmedicci I think we don't need to add empty line at end of the line, otherwise checkpatch.sh will report it as an issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch master updated (16b30ea659 -> 17e1d43f6d)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 16b30ea659 boards/arm64/imx9/imx93-evk: Enable PWM from TPM3ch3 on imx93-evk pin GPIO_IO24 add 17e1d43f6d ioexpander/icjx: add support for change of input interrupts on NINT No new revisions were added by this update. Summary of changes: drivers/ioexpander/icjx.c | 261 +++- drivers/ioexpander/icjx.h | 24 include/nuttx/ioexpander/icjx.h | 14 +++ 3 files changed, 294 insertions(+), 5 deletions(-)
Re: [PR] ioexpander/icjx: add support for change of input interrupts on NINT [nuttx]
acassis merged PR #12058: URL: https://github.com/apache/nuttx/pull/12058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
acassis commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554085934 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: @pkarashchenko ub16toi() will discard the lower 16 bits, actually I'm more confused about the "ub16_t" type, it seems to be something NuttX specific. It is like an uint16_t but using higher 16 bits instead of lower 16 bits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] arch/arm64/src/imx9/imx9_flexio_pwm.c: Fix wrong input scale [nuttx]
pkarashchenko commented on code in PR #12059: URL: https://github.com/apache/nuttx/pull/12059#discussion_r1554069013 ## arch/arm64/src/imx9/imx9_flexio_pwm.c: ## @@ -444,7 +444,7 @@ static int pwm_update_frequency(struct imx9_pwmtimer_s *priv, int freq) static int pwm_update_duty(struct imx9_pwmtimer_s *priv, int pwm_ch, ub16_t duty16) { - uint64_t duty = ub16toi(duty16); + uint32_t duty = duty16 & 0x; Review Comment: I do not fully understand this change. Why you don't use `ub16toX` interface, but mask here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
kisvegabor commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2040284250 I'm not an expert on NuttX, so please forgive me the silly question: why don't you have the same issue with other 3rd party libraries used in NuttX? I think LVGL uses Kconfig in a rather standard way, which should be similar to other libs in this regard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] include/nuttx/timers/pwm.h: add dcpol attribute to pwm_chan_s [nuttx]
zdebanos commented on PR #12075: URL: https://github.com/apache/nuttx/pull/12075#issuecomment-2040272471 @acassis Thanks. Update pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] include/nuttx/timers/pwm.h: add dcpol attribute to pwm_chan_s [nuttx]
acassis commented on PR #12075: URL: https://github.com/apache/nuttx/pull/12075#issuecomment-2040195688 @zdebanos please run the check the coding style issues: $ ./tools/configure.sh -f include/nuttx/timers/pwm.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ioexpander/icjx: add support for change of input interrupts on NINT [nuttx]
acassis commented on PR #12058: URL: https://github.com/apache/nuttx/pull/12058#issuecomment-2040192347 > > @michallenc just a comment: NINT means Negated Interrupt, not not an interrupt :-) > > Usually yes, but in iC-JX datasheet they really call it Not Interrupt :) So I decided to keep their name. So it was their mistake, not yours! Hehehe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] include/nuttx/timers/pwm.h: add dcpol attribute to pwm_chan_s [nuttx]
zdebanos opened a new pull request, #12075: URL: https://github.com/apache/nuttx/pull/12075 `PWM_CPOL_` helper defines and `uint8_t cpol` in the `struct pwm_chan_s` have been added to define the polarity of the running PWM. The only driver that has supported it up to this day was the samv7's one. However, as with SAMV7 when the channels get turned off, the output polarity of the PWM channel (even if it's not running) also depend on the `cpol` field. This may cause the following problem: - a certain polarity during runtime is desired, the user sets it - however when the PWM operation is turned off, a default value should be set (for example a logical zero). If the default value of the disabled channel is undefined, it can cause trouble (undesired high outputs, etc...). This new attribute extends the `struct pwm_chan_s` (and `struct pwm_info_s`) that defines PWM's output value in disable state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ioexpander/icjx: add support for change of input interrupts on NINT [nuttx]
michallenc commented on code in PR #12058: URL: https://github.com/apache/nuttx/pull/12058#discussion_r1553830316 ## drivers/ioexpander/icjx.c: ## @@ -463,15 +487,80 @@ static int icjx_option(FAR struct ioexpander_dev_s *dev, uint8_t pin, int opt, FAR void *value) { /* TODO: Implementation of iC-JX options should be here. This includes - * setup of filters, ADC, interrupts etc. The right way to implement + * setup of filters, ADC etc. The right way to implement * this would probably be to introduce config structure to * include/nuttx/ioexpanders/icjx.h that the user could use for the * nibbles configuration. + * + * Currently only interrupts are implemented. */ - gpiowarn("ERROR: iC-JX options are not yet implemted!\n"); + FAR struct icjx_dev_s *priv = (FAR struct icjx_dev_s *)dev; + uint8_t data; + uint8_t reg; + int ret; + + DEBUGASSERT(priv != NULL && priv->config != NULL); + + gpioinfo("Expander id=%02x pin=%u option=%u\n", + priv->config->id, pin, opt); + + if (opt == IOEXPANDER_OPTION_INTCFG) +{ + unsigned int ival = (unsigned int)((uintptr_t)value); + ret = nxmutex_lock(>lock); + if (ret < 0) +{ + return ret; +} + + switch (ival) +{ + case IOEXPANDER_VAL_HIGH: + case IOEXPANDER_VAL_LOW: + case IOEXPANDER_VAL_RISING: + case IOEXPANDER_VAL_FALLING: Review Comment: Good catch, I've missed that one. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ioexpander/icjx: add support for change of input interrupts on NINT [nuttx]
michallenc commented on PR #12058: URL: https://github.com/apache/nuttx/pull/12058#issuecomment-2040043178 > @michallenc just a comment: NINT means Negated Interrupt, not not an interrupt :-) Usually yes, but in iC-JX datasheet they really calls it Not Interrupt :) So I decided to keep their name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
tmedicci commented on code in PR #12055: URL: https://github.com/apache/nuttx/pull/12055#discussion_r1553683202 ## arch/xtensa/src/esp32s3/esp32s3_gpio.c: ## @@ -207,6 +208,17 @@ int esp32s3_configgpio(uint32_t pin, gpio_pinattr_t attr) func = 0; cntrl = 0; + /* if pin 19 or 20 disable the USB/JTAG function and pull-up */ + + if (pin == 19 || pin == 20) +{ + uint32_t regval; + regval = getreg32(USB_SERIAL_JTAG_CONF0_REG); + regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE | + USB_SERIAL_JTAG_DP_PULLUP); Review Comment: ```suggestion regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE | USB_SERIAL_JTAG_DP_PULLUP); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
tmedicci commented on code in PR #12055: URL: https://github.com/apache/nuttx/pull/12055#discussion_r1553683202 ## arch/xtensa/src/esp32s3/esp32s3_gpio.c: ## @@ -207,6 +208,17 @@ int esp32s3_configgpio(uint32_t pin, gpio_pinattr_t attr) func = 0; cntrl = 0; + /* if pin 19 or 20 disable the USB/JTAG function and pull-up */ + + if (pin == 19 || pin == 20) +{ + uint32_t regval; + regval = getreg32(USB_SERIAL_JTAG_CONF0_REG); + regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE | + USB_SERIAL_JTAG_DP_PULLUP); Review Comment: ```suggestion regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE | USB_SERIAL_JTAG_DP_PULLUP); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
cederom commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039915221 Right, keeping things minimal is important, additional repository with necessary libs seems best solution (either as nuttx/libs or apache/nuttx-libs), just to have all in one place, to clone burn to disk and be prepared for offline work :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
acassis commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039902048 > What about full copy of external library (i.e. LVGL) to our source tree so everything is always in one place and ready do build offline with no additional downloads? Would that be acceptable? Hmm, should be nice to have an alternative to not penalize people that doesn't require these external libs (imagine the time to clone it when you are a bad internet connection). Maybe we could put it in a reparated repository, i.e. https://github.com/nuttx/libs (yes using our not currently used nuttx github) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
cederom commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039892107 What about full copy of external library (i.e. LVGL) to our source tree so everything is always in one place and ready do build offline with no additional downloads? Would that be acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
acassis commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039858663 > > Yes, I think we could have a "make download" to download all libraries to let user compile it online. > > This can be also achieved with `git submodule` if the code is in external git repo..? > > Or just copy the sources to out repo and have all in one place? Git submodules was discussed many times and the conclusion is that is generates more issues than benefits. Yes, that idea of copying the files to some place before building could be nice. Actually yocto and others building systems have this option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
acassis commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039853557 @XuNeo I think this is a limitation of Kconfig (or the way our build system works), it is not dynamic. If we modify some Kconfig and don't run "make menuconfig" our .config will not be updated during the make command. Maybe an alternative we could do it during the board config we run the lib download to extract the need Kconfig before running the process config phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
cederom commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039849580 > Yes, I think we could have a "make download" to download all libraries to let user compile it online. This can be also achieved with `git submodule` if the code is in external git repo..? Or just copy the sources to out repo and have all in one place? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
acassis commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039836079 > I also thought about that and in a perfect situation we have all source code modules etc as part of repository do no additional downloads are necessary and everything should work out of the box in full offline mode..? :-) Yes, I think we could have a "make download" to download all libraries to let user compile it online. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] apps/lvgl: upgrade to lvgl version v9 [nuttx-apps]
cederom commented on PR #2312: URL: https://github.com/apache/nuttx-apps/pull/2312#issuecomment-2039824816 I also thought about that and in a perfect situation we have all source code modules etc as part of repository do no additional downloads are necessary and everything should work out of the box in full offline mode..? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx) branch master updated (65bd548521 -> 16b30ea659)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 65bd548521 esp32[c3|c6|h2]: Fix RTC data placement add 0f596ec496 arch/arm64/src/imx9: Add TPM based PWM driver for IMX9 add 16b30ea659 boards/arm64/imx9/imx93-evk: Enable PWM from TPM3ch3 on imx93-evk pin GPIO_IO24 No new revisions were added by this update. Summary of changes: arch/arm64/src/imx9/Kconfig| 101 arch/arm64/src/imx9/Make.defs | 4 + arch/arm64/src/imx9/hardware/imx9_tpm.h| 206 .../src/imx9/{imx9_flexio_pwm.c => imx9_tpm_pwm.c} | 523 + .../src/imx9/{imx9_usbdev.h => imx9_tpm_pwm.h} | 37 +- boards/arm64/imx9/imx93-evk/configs/nsh/defconfig | 2 + boards/arm64/imx9/imx93-evk/include/board.h| 4 + boards/arm64/imx9/imx93-evk/src/imx9_pwm.c | 19 + 8 files changed, 590 insertions(+), 306 deletions(-) create mode 100644 arch/arm64/src/imx9/hardware/imx9_tpm.h copy arch/arm64/src/imx9/{imx9_flexio_pwm.c => imx9_tpm_pwm.c} (51%) copy arch/arm64/src/imx9/{imx9_usbdev.h => imx9_tpm_pwm.h} (75%)
Re: [PR] Imx9 lptpm pwm [nuttx]
acassis merged PR #12054: URL: https://github.com/apache/nuttx/pull/12054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ioexpander/icjx: add support for change of input interrupts on NINT [nuttx]
acassis commented on code in PR #12058: URL: https://github.com/apache/nuttx/pull/12058#discussion_r1553598166 ## drivers/ioexpander/icjx.c: ## @@ -463,15 +487,80 @@ static int icjx_option(FAR struct ioexpander_dev_s *dev, uint8_t pin, int opt, FAR void *value) { /* TODO: Implementation of iC-JX options should be here. This includes - * setup of filters, ADC, interrupts etc. The right way to implement + * setup of filters, ADC etc. The right way to implement * this would probably be to introduce config structure to * include/nuttx/ioexpanders/icjx.h that the user could use for the * nibbles configuration. + * + * Currently only interrupts are implemented. */ - gpiowarn("ERROR: iC-JX options are not yet implemted!\n"); + FAR struct icjx_dev_s *priv = (FAR struct icjx_dev_s *)dev; + uint8_t data; + uint8_t reg; + int ret; + + DEBUGASSERT(priv != NULL && priv->config != NULL); + + gpioinfo("Expander id=%02x pin=%u option=%u\n", + priv->config->id, pin, opt); + + if (opt == IOEXPANDER_OPTION_INTCFG) +{ + unsigned int ival = (unsigned int)((uintptr_t)value); + ret = nxmutex_lock(>lock); + if (ret < 0) +{ + return ret; +} + + switch (ival) +{ + case IOEXPANDER_VAL_HIGH: + case IOEXPANDER_VAL_LOW: + case IOEXPANDER_VAL_RISING: + case IOEXPANDER_VAL_FALLING: Review Comment: Isn't IOEXPANDER_VAL_BOTH supported? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: the bug about rwbuffer causing mem overflow [nuttx]
acassis commented on PR #12056: URL: https://github.com/apache/nuttx/pull/12056#issuecomment-2039747255 @ChenChuangForLinux please check coding style issues: $ ./tools/checkpatch.sh -f drivers/misc/rwbuffer.c And fix the issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ioexpander/icjx: add support for change of input interrupts on NINT [nuttx]
acassis commented on PR #12058: URL: https://github.com/apache/nuttx/pull/12058#issuecomment-2039750256 @michallenc just a comment: NINT means Negated Interrupt, not not an interrupt :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx-website) branch asf-site updated: Publishing web: 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f docs: 65bd54852175d8f6a167c2ecdf3663073ef22349
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ea8d8ff35 Publishing web: 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f docs: 65bd54852175d8f6a167c2ecdf3663073ef22349 ea8d8ff35 is described below commit ea8d8ff35a61ec70dc92e4d39ec183e7ed129661 Author: Alin Jerpelea AuthorDate: Fri Apr 5 12:37:47 2024 + Publishing web: 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f docs: 65bd54852175d8f6a167c2ecdf3663073ef22349 --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.0/searchindex.js | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/10.0.1/searchindex.js | 2 +- content/docs/10.1.0/index.html | 2 +- content/docs/10.1.0/searchindex.js | 2 +- content/docs/10.2.0/index.html | 2 +- content/docs/10.2.0/searchindex.js | 2 +- content/docs/10.3.0/index.html | 2 +- content/docs/10.3.0/searchindex.js | 2 +- content/docs/11.0.0/index.html | 2 +- content/docs/11.0.0/searchindex.js | 2 +- content/docs/12.0.0/index.html | 2 +- content/docs/12.0.0/searchindex.js | 2 +- content/docs/12.1.0/index.html | 2 +- content/docs/12.1.0/searchindex.js | 2 +- content/docs/12.2.0/index.html | 2 +- content/docs/12.2.0/searchindex.js | 2 +- content/docs/12.2.1/index.html | 2 +- content/docs/12.2.1/searchindex.js | 2 +- content/docs/12.3.0/index.html | 2 +- content/docs/12.3.0/searchindex.js | 2 +- content/docs/12.4.0/index.html | 2 +- content/docs/12.4.0/searchindex.js | 2 +- content/docs/12.5.0/index.html | 2 +- content/docs/12.5.0/searchindex.js | 2 +- content/docs/latest/index.html | 2 +- content/docs/latest/searchindex.js | 2 +- content/download/index.html| 12 ++-- content/feed.xml | 4 ++-- content/releases/12.5.0/index.html | 8 31 files changed, 40 insertions(+), 40 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 2daf1d30c..17f69e7c5 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -131,7 +131,7 @@ by following these NuttX Documentation NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 05 April 24 at 11:48 +Last Updated: 05 April 24 at 12:31 Table of Contents diff --git a/content/docs/10.0.0/searchindex.js b/content/docs/10.0.0/searchindex.js index 151f45509..99ee4f3a3 100644 --- a/content/docs/10.0.0/searchindex.js +++ b/content/docs/10.0.0/searchindex.js @@ -1 +1 @@ -Search.setIndex({"docnames": ["applications/index", "boards/index", "components/binfmt", "components/drivers/block/index", "components/drivers/character/analog", "components/drivers/character/can", "components/drivers/character/index", "components/drivers/character/keypad", "components/drivers/character/pwm", "components/drivers/character/quadrature", "components/drivers/character/rtc", "components/drivers/character/serial", "components/drivers/character/timer", "components/drivers/chara [...] \ No newline at end of file +Search.setIndex({"docnames": ["applications/index", "boards/index", "components/binfmt", "components/drivers/block/index", "components/drivers/character/analog", "components/drivers/character/can", "components/drivers/character/index", "components/drivers/character/keypad", "components/drivers/character/pwm", "components/drivers/character/quadrature", "components/drivers/character/rtc", "components/drivers/character/serial", "components/drivers/character/timer", "components/drivers/chara [...] \ No newline at end of file diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index fda21b9c4..09f3ab19c 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -157,7 +157,7 @@ by following these NuttX Documentation NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 05 April 24 at 11:48 +Last Updated: 05 April 24 at 12:31 Table
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
acassis commented on code in PR #12055: URL: https://github.com/apache/nuttx/pull/12055#discussion_r1553585262 ## arch/xtensa/src/esp32s3/esp32s3_gpio.c: ## @@ -207,6 +208,17 @@ int esp32s3_configgpio(uint32_t pin, gpio_pinattr_t attr) func = 0; cntrl = 0; + /* if pin 19 or 20 disable the USB/JTAG function and pull-up */ + + if (pin == 19 || pin == 20) +{ + uint32_t regval; + regval = getreg32(USB_SERIAL_JTAG_CONF0_REG); + regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE | + USB_SERIAL_JTAG_DP_PULLUP); Review Comment: Please align to let USB_SERIAL_JTAG_DP_PULLUP start exactly under USB_SERIAL_JTAG_USB_PAD_ENABLE to improve readability -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller. [nuttx]
acassis commented on PR #12055: URL: https://github.com/apache/nuttx/pull/12055#issuecomment-2039741555 Thank you @omar-faruk ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx-website) branch master updated: 12.5.0.md: typo fix
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new 64ae20e5a 12.5.0.md: typo fix 64ae20e5a is described below commit 64ae20e5a4df5e2feedb7e48b9ccd7cbb790aa4f Author: Alin Jerpelea AuthorDate: Fri Apr 5 14:29:00 2024 +0200 12.5.0.md: typo fix Signed-off-by: Alin Jerpelea --- _releases/12.5.0.md | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/_releases/12.5.0.md b/_releases/12.5.0.md index d1a571ade..71efff136 100644 --- a/_releases/12.5.0.md +++ b/_releases/12.5.0.md @@ -2,19 +2,19 @@ layout: page released: true apache: true -title: 12.4.0 -date: 2024-01-15 +title: 12.5.0 +date: 2024-04-05 summary: > -Release v12.4.0 +Release v12.5.0 -artifact-root: "https://www.apache.org/dyn/closer.lua/nuttx/12.4.0; -checksum-root: "https://downloads.apache.org/nuttx/12.4.0; +artifact-root: "https://www.apache.org/dyn/closer.lua/nuttx/12.5.0; +checksum-root: "https://downloads.apache.org/nuttx/12.5.0; key-file: "https://downloads.apache.org/nuttx/KEYS; source-os-dist: -- "apache-nuttx-12.4.0.tar.gz" +- "apache-nuttx-12.5.0.tar.gz" source-app-dist: -- "apache-nuttx-apps-12.4.0.tar.gz" +- "apache-nuttx-apps-12.5.0.tar.gz" --- @@ -40,7 +40,7 @@ limitations under the License. {% include JB/setup %} -# Apache NuttX-12.4.0 Release Notes +# Apache NuttX-12.5.0 Release Notes * TOC {:toc}
[PR] 12.5.0.md: typo fix [nuttx-website]
jerpelea opened a new pull request, #112: URL: https://github.com/apache/nuttx-website/pull/112 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 12.5.0.md: typo fix [nuttx-website]
jerpelea merged PR #112: URL: https://github.com/apache/nuttx-website/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-12042} drivers/net/lan9250: Fix crash issue of sending packets by lan9250 dr… [nuttx]
jerpelea opened a new pull request, #12074: URL: https://github.com/apache/nuttx/pull/12074 ## Summary …iver under SMP and multi-thread ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-12045} all: Fix accessing uninitialized local variables [nuttx]
jerpelea opened a new pull request, #12073: URL: https://github.com/apache/nuttx/pull/12073 ## Summary Prior to this commit, in elf_emit() and elf_emit_align(), ret was uninitialized if total was 0. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-12046} arch/arm/src/s32k3xx: Fix incorrect check for invalid port or pin number [nuttx]
jerpelea opened a new pull request, #12072: URL: https://github.com/apache/nuttx/pull/12072 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {12047} arch/arm/src/am335x: Fix incorrect signedness of variable [nuttx]
jerpelea opened a new pull request, #12071: URL: https://github.com/apache/nuttx/pull/12071 ## Summary The check `if (delta < 0)` in line 353 and 407 would always be false if delta were unsigned. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-11-992} esp32[c3|c6|h2]: Fix filesystem test support [nuttx]
jerpelea opened a new pull request, #12069: URL: https://github.com/apache/nuttx/pull/12069 ## Summary Bugfix for file system test ## Impact ESP32-C3, ESP32-C6, ESP32-H2 ## Testing fstest example with using esp32c6-devkit:spiflash config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] stm32h7:Serial Fix Logic error in up_dma_txavailable [nuttx]
jerpelea opened a new pull request, #12070: URL: https://github.com/apache/nuttx/pull/12070 ## Summary Fixed logic error as noted by @kk-thrane ## Impact Correct logic ## Testing px4_fmu-v6x serial_test / gps / qgc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-11998} mm/kmap.h: fix typo in comments [nuttx]
jerpelea opened a new pull request, #12068: URL: https://github.com/apache/nuttx/pull/12068 ## Summary Fix typo in comments for kmm_map() function. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-11999} drivers/video/isx019: Fix the default_value of some parameters [nuttx]
jerpelea opened a new pull request, #12066: URL: https://github.com/apache/nuttx/pull/12066 ## Summary Because the exposure time and ISO sensitivity are adjusted automatically by default, the default value can not be defined. So, return the value out of range as the default_value of ioctl(VIDIOC_QUERYCTRL). ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] drivers/video/isx019: Fix default_value of 3A status [nuttx]
jerpelea opened a new pull request, #12067: URL: https://github.com/apache/nuttx/pull/12067 ## Summary Fix default_value of ioctl(VIDIOC_QUERYCTRL)(id=V4L2_CID_3A_STATUS) to AE operating and AWB operating, because both AE and AWB are automatical adjustment mode by default. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {bp-12008} xtensa/esp32s3: Fix one page program span over 2 pages [nuttx]
jerpelea opened a new pull request, #12065: URL: https://github.com/apache/nuttx/pull/12065 ## Summary One page program can't span over 2 pages. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] boards: raspberrypi-pico: Fix nshsram build error [nuttx]
jerpelea opened a new pull request, #12064: URL: https://github.com/apache/nuttx/pull/12064 Summary: - This commit fixes https://github.com/apache/nuttx/issues/11956. - The issue was introduced by https://github.com/apache/nuttx/pull/6118. Impact: - None Testing: - Tested with raspberrypi-pico. - NOTE: the ci should be fixed later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] {Bp-12028} boards: rp2040: Fix build errors for nshsram configurations [nuttx]
jerpelea opened a new pull request, #12063: URL: https://github.com/apache/nuttx/pull/12063 Summary: - This commit applies the fix in https://github.com/apache/nuttx/pull/12025 Impact: - None Testing: - Build only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(nuttx-website) branch master updated: Add NuttX 12.5.0 release
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new 3cc5b0942 Add NuttX 12.5.0 release 3cc5b0942 is described below commit 3cc5b0942f661f440f6dd8b58b89bb1e71d7a95d Author: Alin Jerpelea AuthorDate: Fri Apr 5 08:17:52 2024 +0200 Add NuttX 12.5.0 release Signed-off-by: Alin Jerpelea --- _releases/12.5.0.md | 505 1 file changed, 505 insertions(+) diff --git a/_releases/12.5.0.md b/_releases/12.5.0.md new file mode 100644 index 0..d1a571ade --- /dev/null +++ b/_releases/12.5.0.md @@ -0,0 +1,505 @@ +--- +layout: page +released: true +apache: true +title: 12.4.0 +date: 2024-01-15 +summary: > +Release v12.4.0 + +artifact-root: "https://www.apache.org/dyn/closer.lua/nuttx/12.4.0; +checksum-root: "https://downloads.apache.org/nuttx/12.4.0; +key-file: "https://downloads.apache.org/nuttx/KEYS; + +source-os-dist: +- "apache-nuttx-12.4.0.tar.gz" +source-app-dist: +- "apache-nuttx-apps-12.4.0.tar.gz" + +--- + + + + +{% include JB/setup %} + +# Apache NuttX-12.4.0 Release Notes +* TOC +{:toc} + +What's New In This Release +Improvements to Core OS +sched +* [#11944](https://github.com/apache/nuttx/pull/11944) sched: Fix user task exception handling +* [#11498](https://github.com/apache/nuttx/pull/11498) sched: move etc romfs mount from nsh to sched/init +* [#11846](https://github.com/apache/nuttx/pull/11846) sched: remove unused group link node +* [#11950](https://github.com/apache/nuttx/pull/11950) sched: replace some global variables to macro +* [#11769](https://github.com/apache/nuttx/pull/11769) sched: rw_sem: replace mutex with spinlock +* [#11818](https://github.com/apache/nuttx/pull/11818) sched.h: fix CPU_EQUAL(s1, s2) write error +* [#11949](https://github.com/apache/nuttx/pull/11949) sched/cpu: replace up_cpu_index() to this_cpu() +* [#11816](https://github.com/apache/nuttx/pull/11816) sched/cpuload: remove ciritical_section() to fix recursive +* [#11839](https://github.com/apache/nuttx/pull/11839) sched/environ: check envcp validity before hold sched_lock() +* [#11848](https://github.com/apache/nuttx/pull/11848) sched/group: change type of task group member to single queue +* [#11832](https://github.com/apache/nuttx/pull/11832) sched/group: move task group into task_tcb_s to improve performance +* [#11838](https://github.com/apache/nuttx/pull/11838) sched/group: replace group_findbypid to task_getgroup +* [#11885](https://github.com/apache/nuttx/pull/11885) sched/group: set clear flag if the group is not really needed +* [#11971](https://github.com/apache/nuttx/pull/11971) sched/init: move task list table from data to bss +* [#11542](https://github.com/apache/nuttx/pull/11542) sched/logging: add task activation/exit logs +* [#11854](https://github.com/apache/nuttx/pull/11854) sched/pthread: fix memory leak of pthread_tcb_s +* [#11898](https://github.com/apache/nuttx/pull/11898) sched/pthread/join: refactor pthread join to support join task +* [#11890](https://github.com/apache/nuttx/pull/11890) sched/pthread/join: remove unused joininfo +* [#11891](https://github.com/apache/nuttx/pull/11891) sched/pthread: replace pthread_sem_give() to nxsem_post() to unify the post method +* [#11972](https://github.com/apache/nuttx/pull/11972) sched/signal: merge allocate of signal pool +* [#11916](https://github.com/apache/nuttx/pull/11916) sched/signal: move unblock signal info to stack +* [#11925](https://github.com/apache/nuttx/pull/11925) sched/stdio/file: unify group file list to common single queue +* [#11840](https://github.com/apache/nuttx/pull/11840) sched/task: save argument counter to avoid limit check +* [#11948](https://github.com/apache/nuttx/pull/11948) sched/tasklist: replace task status list with macro definition +* [#11774](https://github.com/apache/nuttx/pull/11774) sched/tcb: add preserved tcb flag to support static tcb +* [#11777](https://github.com/apache/nuttx/pull/11777) sched/tls: inline group info in flat mode to improve performance +* [#11953](https://github.com/apache/nuttx/pull/11953) sched/wqueue: replace some global variables to macro +mm +* [#11921](https://github.com/apache/nuttx/pull/11921) mm: Using Macros Instead of Memory to Fill Labels +* [#11884](https://github.com/apache/nuttx/pull/11884) mm/kconfig: fix typo in MM_DEFAULT_ALIGNMENT +libs +* [#11526](https://github.com/apache/nuttx/pull/11526) libc.csv: Fix qsort signature with unexpected quotation mark +* [#11977](https://github.com/apache/nuttx/pull/11977) libc/uname: Add option to disable uname timestamp +* [#11772](https://github.com/apache/nuttx/pull/11772) libm/newlib: fix support for x86_64 +* [#11889](https://github.com/apache/nuttx/pull/11889) libs/libc/string: fix memmem() boundary case when needle
Re: [PR] Add NuttX 12.5.0 release [nuttx-website]
acassis merged PR #111: URL: https://github.com/apache/nuttx-website/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add NuttX 12.5.0 release [nuttx-website]
jerpelea commented on PR #111: URL: https://github.com/apache/nuttx-website/pull/111#issuecomment-2039595617 please merge those release notes so that I can continue with 12.5.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org