Re: [PR] arch/kconfig: revise kernel space mapping configs [nuttx]

2024-04-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #12154: URL: https://github.com/apache/nuttx/pull/12154#discussion_r1566681922 ## arch/Kconfig: ## @@ -722,6 +722,10 @@ config ARCH_VMA_MAPPING bool "Support runtime memory mapping into SHM area" default n +config

Re: [PR] arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call [nuttx]

2024-04-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #12081: URL: https://github.com/apache/nuttx/pull/12081#discussion_r1566675584 ## arch/arm/src/samv7/sam_qencoder.c: ## @@ -270,11 +316,139 @@ static int sam_reset(struct qe_lowerhalf_s *lower) static int sam_ioctl(struct qe_lowerhalf_s

Re: [PR] Documentation: Add NuttX Logo page [nuttx]

2024-04-15 Thread via GitHub
xiaoxiang781216 merged PR #12152: URL: https://github.com/apache/nuttx/pull/12152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated: Documentation: Add NuttX Logo page

2024-04-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new a5572d8281 Documentation: Add NuttX Logo page

[PR] rv-virt/knsh32: enable debugging options [nuttx]

2024-04-15 Thread via GitHub
yf13 opened a new pull request, #12155: URL: https://github.com/apache/nuttx/pull/12155 ## Summary This enables debugging options for `rv-virt/knsh32` as it is more convenient for debugging and testing. ## Impact rv-virt/knsh32 ## Testing CI checking QEMU

Re: [PR] mtd_config_fs: support align size test [nuttx-apps]

2024-04-15 Thread via GitHub
zhaoxingyu12 commented on PR #2354: URL: https://github.com/apache/nuttx-apps/pull/2354#issuecomment-2058069771 > @zhaoxingyu12 please consider submitting a basic documentation about this testing tool ok, where should I submit it to? -- This is an automated message from the Apache

[PR] arch/kconfig: revise kernel space mapping configs [nuttx]

2024-04-15 Thread via GitHub
yf13 opened a new pull request, #12154: URL: https://github.com/apache/nuttx/pull/12154 ## Summary This treats kernel space virtual memory allocation based mappings similar to that of the user space: - Add ARCH_KVMA_MAPPING to guard kernel mapping configs. - Set dependency

(nuttx-website) branch asf-site updated: Publishing web: ce5ab6cc062dbbe6065b26acd6a7b45062848749 docs: b0504f1e5e2f65fbac623d8357b5cd5e82544c21

2024-04-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 2bdbdfa60 Publishing web:

[PR] tools/uncrustify: disable leading space removal for block comment [nuttx]

2024-04-15 Thread via GitHub
yf13 opened a new pull request, #12153: URL: https://github.com/apache/nuttx/pull/12153 ## Summary This patch disables leading spaces removal for block comments so that to avoid changing well-formatted blocking comments. Without this well-formmated leading blocking

[PR] Documentation: Add NuttX Logo page [nuttx]

2024-04-15 Thread via GitHub
acassis opened a new pull request, #12152: URL: https://github.com/apache/nuttx/pull/12152 ## Summary This commit add a page where users can find the NuttX Logos in PNG and SVG format. ## Impact Users now can find the NuttX Logo for use on WebSites and other places. ## Testing

Re: [PR] arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call [nuttx]

2024-04-15 Thread via GitHub
ppisa commented on code in PR #12081: URL: https://github.com/apache/nuttx/pull/12081#discussion_r1566426663 ## arch/arm/src/samv7/sam_qencoder.c: ## @@ -270,11 +316,139 @@ static int sam_reset(struct qe_lowerhalf_s *lower) static int sam_ioctl(struct qe_lowerhalf_s *lower,

Re: [PR] arm64/imx9: Add LPI2C driver [nuttx]

2024-04-15 Thread via GitHub
pussuw commented on PR #12149: URL: https://github.com/apache/nuttx/pull/12149#issuecomment-2057727317 > Maybe you need to include the right header: > > ``` > Error: chip/imx9_lpi2c.c:758:3: error: implicit declaration of function 'modifyreg32'; did you mean 'modreg32'?

Re: [PR] arm64/imx9: Add LPI2C driver [nuttx]

2024-04-15 Thread via GitHub
acassis commented on PR #12149: URL: https://github.com/apache/nuttx/pull/12149#issuecomment-2057563190 Maybe you need to include the right header: ``` Error: chip/imx9_lpi2c.c:758:3: error: implicit declaration of function 'modifyreg32'; did you mean 'modreg32'?

Re: [PR] fix nxstyle [nuttx]

2024-04-15 Thread via GitHub
acassis merged PR #12151: URL: https://github.com/apache/nuttx/pull/12151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated: fix nxstyle

2024-04-15 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b0504f1e5e fix nxstyle b0504f1e5e is described

Re: [PR] arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call [nuttx]

2024-04-15 Thread via GitHub
zdebanos commented on code in PR #12081: URL: https://github.com/apache/nuttx/pull/12081#discussion_r1566046596 ## arch/arm/src/samv7/sam_qencoder.c: ## @@ -270,10 +296,139 @@ static int sam_reset(struct qe_lowerhalf_s *lower) static int sam_ioctl(struct qe_lowerhalf_s *lower,

Re: [PR] arm64/imx9: Add LPI2C driver [nuttx]

2024-04-15 Thread via GitHub
acassis commented on code in PR #12149: URL: https://github.com/apache/nuttx/pull/12149#discussion_r1566044179 ## boards/arm64/imx9/imx93-evk/src/imx9_i2c.c: ## @@ -0,0 +1,77 @@ +/ + *

Re: [PR] arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call [nuttx]

2024-04-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #12081: URL: https://github.com/apache/nuttx/pull/12081#discussion_r1566042641 ## arch/arm/src/samv7/sam_qencoder.c: ## @@ -270,10 +296,139 @@ static int sam_reset(struct qe_lowerhalf_s *lower) static int sam_ioctl(struct qe_lowerhalf_s

Re: [PR] arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call [nuttx]

2024-04-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #12081: URL: https://github.com/apache/nuttx/pull/12081#discussion_r1566042182 ## arch/arm/src/samv7/sam_qencoder.c: ## @@ -270,11 +316,139 @@ static int sam_reset(struct qe_lowerhalf_s *lower) static int sam_ioctl(struct qe_lowerhalf_s

Re: [PR] arm64/imx9: Add LPI2C driver [nuttx]

2024-04-15 Thread via GitHub
pussuw commented on code in PR #12149: URL: https://github.com/apache/nuttx/pull/12149#discussion_r1566031919 ## boards/arm64/imx9/imx93-evk/src/imx9_i2c.c: ## @@ -0,0 +1,77 @@ +/ + *

Re: [PR] fix nxstyle [nuttx]

2024-04-15 Thread via GitHub
acassis commented on PR #12151: URL: https://github.com/apache/nuttx/pull/12151#issuecomment-2057061734 @simbit18 thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] arch/arm64: Add atomic modifyregXX [nuttx]

2024-04-15 Thread via GitHub
acassis merged PR #12146: URL: https://github.com/apache/nuttx/pull/12146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated (5e3cbd1165 -> 2e638f6f19)

2024-04-15 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5e3cbd1165 stm32h7/linum-stm32h753bi: Add support to littlefs and nxffs with flash mem. via quadspi add

Re: [PR] arm64/imx9: Add LPI2C driver [nuttx]

2024-04-15 Thread via GitHub
acassis commented on code in PR #12149: URL: https://github.com/apache/nuttx/pull/12149#discussion_r1565930768 ## boards/arm64/imx9/imx93-evk/src/imx9_i2c.c: ## @@ -0,0 +1,77 @@ +/ + *

[PR] fix nxstyle [nuttx]

2024-04-15 Thread via GitHub
simbit18 opened a new pull request, #12151: URL: https://github.com/apache/nuttx/pull/12151 ## Summary fix Relative file path does not match actual file. ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] mm/gran: remove size limitation [nuttx]

2024-04-15 Thread via GitHub
acassis commented on PR #12095: URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2057042220 > @acassis thanks for mentioning the uncrustify.cfg thing! The tool can save us a lot time. However, it seems that the latest version of `tools/uncrustify.cfg` is wrong about block

Re: [PR] mtd_config_fs: support align size test [nuttx-apps]

2024-04-15 Thread via GitHub
acassis commented on PR #2354: URL: https://github.com/apache/nuttx-apps/pull/2354#issuecomment-2057005127 @zhaoxingyu12 please consider submitting a basic documentation about this testing tool -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] When i use cmake to build sim:libcxxtest, it display undefined reference to `NXpthread_setspecific' [nuttx]

2024-04-15 Thread via GitHub
raiden00pl commented on issue #12127: URL: https://github.com/apache/nuttx/issues/12127#issuecomment-2056935884 @xuxin930 great ! thanks for solving the issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] imx9_gpioirq: Fix bug in reading port number [nuttx]

2024-04-15 Thread via GitHub
pussuw commented on PR #12148: URL: https://github.com/apache/nuttx/pull/12148#issuecomment-2056896877 More issues with the driver, needs more testing still. I'll bundle the fixes into 1 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] When i use cmake to build sim:libcxxtest, it display undefined reference to `NXpthread_setspecific' [nuttx]

2024-04-15 Thread via GitHub
xuxin930 commented on issue #12127: URL: https://github.com/apache/nuttx/issues/12127#issuecomment-2056865220 > I haven't had a chance to look for the cause of this problem yet. I'm not sure if this problem only occurs for me on arch linux hi @raiden00pl there are two errors:

Re: [PR] mtd_config_fs: support align size test [nuttx-apps]

2024-04-15 Thread via GitHub
zhaoxingyu12 commented on PR #2354: URL: https://github.com/apache/nuttx-apps/pull/2354#issuecomment-2056648229 > please add commit message add commit message done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] arch/arm64_cache.c: Fix cache invalidation [nuttx]

2024-04-15 Thread via GitHub
pussuw closed pull request #12147: arch/arm64_cache.c: Fix cache invalidation URL: https://github.com/apache/nuttx/pull/12147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] arch/arm64_cache.c: Fix cache invalidation [nuttx]

2024-04-15 Thread via GitHub
pussuw commented on PR #12147: URL: https://github.com/apache/nuttx/pull/12147#issuecomment-2056560928 I was trying to look into why the invalidate command issues a clean + invalidate when the start / end address of the range is not properly aligned but could not find a specific reason why

[PR] arm64/imx9: Add LPI2C driver [nuttx]

2024-04-15 Thread via GitHub
pussuw opened a new pull request, #12149: URL: https://github.com/apache/nuttx/pull/12149 ## Summary Adds LPI2C driver (fork-lifted from IMXRT) for IMX93 ## Impact Add new driver for IMX93. Both polling and DMA modes work, but eDMA driver will be added later! ## Testing

[PR] imx9_gpioirq: Fix bug in reading port number [nuttx]

2024-04-15 Thread via GitHub
pussuw opened a new pull request, #12148: URL: https://github.com/apache/nuttx/pull/12148 ## Summary The port is passed as (void *)port, so reading from *port will return garbage and most likely result in page fault. ## Impact Fix bug in the gpioirq driver ## Testing

[PR] arch/arm64_cache.c: Fix cache invalidation [nuttx]

2024-04-15 Thread via GitHub
pussuw opened a new pull request, #12147: URL: https://github.com/apache/nuttx/pull/12147 ## Summary When a cache invalidation is requested, a cache clean + invalidate must _NOT_ be performed, as this can result in data loss, corruption or most likely both. There is a separate

[PR] arch/arm64: Add atomic modifyregXX [nuttx]

2024-04-15 Thread via GitHub
pussuw opened a new pull request, #12146: URL: https://github.com/apache/nuttx/pull/12146 ## Summary These are needed by drivers ## Impact Add atomic modifyreg for arm64 ## Testing imx93 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] arch/arm/src/samv7/sam_qencoder.c: add support for GETINDEX ioctl call [nuttx]

2024-04-15 Thread via GitHub
ppisa commented on code in PR #12081: URL: https://github.com/apache/nuttx/pull/12081#discussion_r1564994273 ## arch/arm/src/samv7/sam_qencoder.c: ## @@ -229,10 +270,15 @@ static int sam_shutdown(struct qe_lowerhalf_s *lower) static int sam_position(struct qe_lowerhalf_s

Re: [PR] Add NuttX 12.5.1 release [nuttx-website]

2024-04-15 Thread via GitHub
xiaoxiang781216 merged PR #113: URL: https://github.com/apache/nuttx-website/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx-website) branch master updated: Add NuttX 12.5.1 release

2024-04-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/master by this push: new ce5ab6cc0 Add NuttX 12.5.1 release

Re: [PR] driver: There is no need to use sched_[un]lock [nuttx]

2024-04-15 Thread via GitHub
hujun260 commented on PR #12139: URL: https://github.com/apache/nuttx/pull/12139#issuecomment-2056173889 purpose: 1 sched_lock is very time-consuming, and reducing its invocations can improve performance. 2 sched_lock is prone to misuse, and narrowing its scope of use is to

Re: [PR] sched_lock: we can remove these sched_lock, [nuttx]

2024-04-15 Thread via GitHub
hujun260 commented on PR #12140: URL: https://github.com/apache/nuttx/pull/12140#issuecomment-2056133348 purpose: 1 sched_lock is very time-consuming, and reducing its invocations can improve performance. 2 sched_lock is prone to misuse, and narrowing its scope of use is to

Re: [PR] sched/wqueue: There is no need to use sched_[un]lock [nuttx]

2024-04-15 Thread via GitHub
hujun260 commented on PR #12142: URL: https://github.com/apache/nuttx/pull/12142#issuecomment-2056125906 purpose: 1 sched_lock is very time-consuming, and reducing its invocations can improve performance. 2 sched_lock is prone to misuse, and narrowing its scope of use is to prevent

Re: [PR] sched/sched: There is no need to use sched_[un]lock [nuttx]

2024-04-15 Thread via GitHub
anchao commented on code in PR #12141: URL: https://github.com/apache/nuttx/pull/12141#discussion_r1565281647 ## sched/sched/sched_setparam.c: ## @@ -87,12 +87,6 @@ int nxsched_set_param(pid_t pid, FAR const struct sched_param *param) return -EINVAL; } - /*

[PR] Add NuttX 12.5.1 release [nuttx-website]

2024-04-15 Thread via GitHub
jerpelea opened a new pull request, #113: URL: https://github.com/apache/nuttx-website/pull/113 ## Summary Add NuttX 12.5.1 release ## Impact RELEASE ## Testing NONE -- This is an automated message from the Apache Git Service. To respond to the message, please

svn commit: r68522 - in /release/nuttx/12.5.1: ./ apache-nuttx-12.5.1.tar.gz apache-nuttx-12.5.1.tar.gz.asc apache-nuttx-12.5.1.tar.gz.sha512 apache-nuttx-apps-12.5.1.tar.gz apache-nuttx-apps-12.5.1.t

2024-04-15 Thread jerpelea
Author: jerpelea Date: Mon Apr 15 06:42:12 2024 New Revision: 68522 Log: Add apache-nuttx-12.5.1 release Added: release/nuttx/12.5.1/ release/nuttx/12.5.1/apache-nuttx-12.5.1.tar.gz (with props) release/nuttx/12.5.1/apache-nuttx-12.5.1.tar.gz.asc

Re: [PR] sched/sched: There is no need to use sched_[un]lock [nuttx]

2024-04-15 Thread via GitHub
hujun260 commented on PR #12141: URL: https://github.com/apache/nuttx/pull/12141#issuecomment-2055627411 purpose: 1 sched_lock is very time-consuming, and reducing its invocations can improve performance. 2 sched_lock is prone to misuse, and narrowing its scope of use is to prevent

(nuttx-apps) annotated tag nuttx-12.5.1 updated (63dd3547f -> 334ebc26c)

2024-04-15 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-12.5.1 in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git *** WARNING: tag nuttx-12.5.1 was modified! *** from 63dd3547f (commit) to 334ebc26c (tag)

(nuttx) annotated tag nuttx-12.5.1 updated (9e8753d625 -> 29305cae92)

2024-04-15 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to annotated tag nuttx-12.5.1 in repository https://gitbox.apache.org/repos/asf/nuttx.git *** WARNING: tag nuttx-12.5.1 was modified! *** from 9e8753d625 (commit) to 29305cae92 (tag) tagging