[GitHub] [incubator-nuttx] yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY

2020-03-03 Thread GitBox
yamt commented on issue #413: esp32-core: Fix BOARD_CLOCK_FREQUENCY URL: https://github.com/apache/incubator-nuttx/pull/413#issuecomment-594288758 @jerpelea i won't until i understand why it should be (2 * BOARD_XTAL_FREQUENCY). maybe i will try to ask espressif.

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #426: boards/x86_64: correct qemu intel64 Kconfig path to fix build break

2020-03-03 Thread GitBox
xiaoxiang781216 merged pull request #426: boards/x86_64: correct qemu intel64 Kconfig path to fix build break URL: https://github.com/apache/incubator-nuttx/pull/426 This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #428: arch: esp32: Fix compile error with xtensa-esp32-elf-gcc 8.2.0

2020-03-04 Thread GitBox
xiaoxiang781216 merged pull request #428: arch: esp32: Fix compile error with xtensa-esp32-elf-gcc 8.2.0 URL: https://github.com/apache/incubator-nuttx/pull/428 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] juniskane commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-27 Thread GitBox
juniskane commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591924495 Does not even compile, or am I missing an interim patch? ``` syslog/syslog_device.c: In function

[GitHub] [incubator-nuttx] bjbrandt opened a new pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-02-27 Thread GitBox
bjbrandt opened a new pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391 Add progmen flash block mapping for the STM32[F2/F4] family. This is based on the STM32F7 flash driver

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-27 Thread GitBox
xiaoxiang781216 commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591931624 > Does not even compile, or am I missing an interim patch? > > ``` > syslog/syslog_device.c:

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #392: Add DISCLAIMER, LICENSE and NOTICE files. The content of COPYING is duplicated in LICENSE, so it got deleted.

2020-02-27 Thread GitBox
Ouss4 opened a new pull request #392: Add DISCLAIMER, LICENSE and NOTICE files. The content of COPYING is duplicated in LICENSE, so it got deleted. URL: https://github.com/apache/incubator-nuttx/pull/392 This is an

[GitHub] [incubator-nuttx-apps] acassis merged pull request #106: exmaples/module/dirvers and examples/nxflat/tests: Ensure "build" before "install"

2020-02-27 Thread GitBox
acassis merged pull request #106: exmaples/module/dirvers and examples/nxflat/tests: Ensure "build" before "install" URL: https://github.com/apache/incubator-nuttx-apps/pull/106 This is an automated message from the Apache

[GitHub] [incubator-nuttx] juniskane commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-27 Thread GitBox
juniskane commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591947244 Ok, now it seems be working as before. This

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-27 Thread GitBox
xiaoxiang781216 commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591952795 @patacongo this patch is ready to merege now.

[GitHub] [incubator-nuttx-apps] liuguo09 opened a new pull request #106: exmaples/module/dirvers and examples/nxflat/tests: Ensure "build" before "install"

2020-02-27 Thread GitBox
liuguo09 opened a new pull request #106: exmaples/module/dirvers and examples/nxflat/tests: Ensure "build" before "install" URL: https://github.com/apache/incubator-nuttx-apps/pull/106 This is an automated message from the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #108: Fix some wrong state handler in _negotiate

2020-02-27 Thread GitBox
xiaoxiang781216 commented on issue #108: Fix some wrong state handler in _negotiate URL: https://github.com/apache/incubator-nuttx-apps/pull/108#issuecomment-592271726 @patacongo the style modification here syntax error:

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #109: telnet: Fix compile error by commit 39bf19d

2020-02-27 Thread GitBox
xiaoxiang781216 opened a new pull request #109: telnet: Fix compile error by commit 39bf19d URL: https://github.com/apache/incubator-nuttx-apps/pull/109 Signed-off-by: Xiang Xiao This is an automated message from the Apache

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #110: testing: ostest: Add workaround for SMP in cond.c

2020-02-28 Thread GitBox
masayuki2009 opened a new pull request #110: testing: ostest: Add workaround for SMP in cond.c URL: https://github.com/apache/incubator-nuttx-apps/pull/110 ### Summary - This PR adds workaround for SMP in cond.c to avoid error messages in cond_test. ### Impact - Only

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #109: telnet: Fix compile error by commit 39bf19d

2020-02-27 Thread GitBox
xiaoxiang781216 commented on issue #109: telnet: Fix compile error by commit 39bf19d URL: https://github.com/apache/incubator-nuttx-apps/pull/109#issuecomment-592314674 https://github.com/apache/incubator-nuttx-apps/pull/108

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #395: Disable net local

2020-02-27 Thread GitBox
masayuki2009 opened a new pull request #395: Disable net local URL: https://github.com/apache/incubator-nuttx/pull/395 ### Summary - Remove CONFIG_NET_LOCAL=y from wifi configurations (spresense:wifi and stm32f4discovery:wifi), because the interface is not used. ### Impact

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #388: boards: spresense: Change CONFIG_FAT_MAXFNAME and CONFIG_NAME_MAX

2020-02-26 Thread GitBox
masayuki2009 opened a new pull request #388: boards: spresense: Change CONFIG_FAT_MAXFNAME and CONFIG_NAME_MAX URL: https://github.com/apache/incubator-nuttx/pull/388 ### Summary - This PR changes CONFIG_FAT_MAXFNAME to 255 and CONFIG_NAME_MAX to 765 which can support max file

[GitHub] [incubator-nuttx] juniskane commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-26 Thread GitBox
juniskane commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591804411 This is completely unacceptable. I have applications that call syslog_file_channel() based on run-time

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #394: include: audio: Remove packed_struct from struct ap_buffer_s

2020-02-27 Thread GitBox
masayuki2009 opened a new pull request #394: include: audio: Remove packed_struct from struct ap_buffer_s URL: https://github.com/apache/incubator-nuttx/pull/394 ### Summary - Remove begin_packed_struct and end_packed_struct from struct_ap_buffer_s. - This change suppresses

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #394: include: audio: Remove packed_struct from struct ap_buffer_s

2020-02-27 Thread GitBox
xiaoxiang781216 merged pull request #394: include: audio: Remove packed_struct from struct ap_buffer_s URL: https://github.com/apache/incubator-nuttx/pull/394 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] patacongo merged pull request #396: sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT

2020-02-28 Thread GitBox
patacongo merged pull request #396: sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT URL: https://github.com/apache/incubator-nuttx/pull/396 This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] patacongo merged pull request #398: xtensa: Fix up_schedule_sigaction

2020-02-28 Thread GitBox
patacongo merged pull request #398: xtensa: Fix up_schedule_sigaction URL: https://github.com/apache/incubator-nuttx/pull/398 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
xiaoxiang781216 commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592522078 > This change is apaplling. I don't thing it should be merged. Let's keep the name Makefile.

[GitHub] [incubator-nuttx] bjbrandt commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-02-28 Thread GitBox
bjbrandt commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#issuecomment-592500639 > I think we need to step back and look at the API. It seems to have become very corrupted.

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #110: testing: ostest: Add workaround for SMP in cond.c

2020-02-28 Thread GitBox
patacongo merged pull request #110: testing: ostest: Add workaround for SMP in cond.c URL: https://github.com/apache/incubator-nuttx-apps/pull/110 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] davids5 commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-02-28 Thread GitBox
davids5 commented on issue #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#issuecomment-592470656 @bjbrandt - I think we need to step back and look at the API. It seems to have become very

[GitHub] [incubator-nuttx] patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592519979 This change is apaplling. I don't thing it should be merged. Let's keep the name Makefile.

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #111: apps: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
patacongo commented on issue #111: apps: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx-apps/pull/111#issuecomment-592523387 See pr399 This is an automated

[GitHub] [incubator-nuttx-apps] patacongo closed pull request #111: apps: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
patacongo closed pull request #111: apps: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx-apps/pull/111 This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592523040 I still don't like it. I have no concern for other open source projects.

[GitHub] [incubator-nuttx] patacongo closed pull request #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
patacongo closed pull request #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399 This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
xiaoxiang781216 edited a comment on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592522078 > This change is apaplling. I don't thing it should be merged. Let's keep the name

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #109: telnet: Fix compile error by commit 39bf19d

2020-02-28 Thread GitBox
patacongo merged pull request #109: telnet: Fix compile error by commit 39bf19d URL: https://github.com/apache/incubator-nuttx-apps/pull/109 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo commented on issue #392: Add DISCLAIMER, LICENSE and NOTICE files. The content of COPYING is duplicated in LICENSE, so it got deleted.

2020-02-27 Thread GitBox
patacongo commented on issue #392: Add DISCLAIMER, LICENSE and NOTICE files. The content of COPYING is duplicated in LICENSE, so it got deleted. URL: https://github.com/apache/incubator-nuttx/pull/392#issuecomment-592015553 Looks good to me

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-02-27 Thread GitBox
davids5 commented on a change in pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#discussion_r385117465 ## File path: arch/arm/src/stm32/stm32f20xxf40xx_flash.c ## @@

[GitHub] [incubator-nuttx] patacongo merged pull request #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-27 Thread GitBox
patacongo merged pull request #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] bjbrandt commented on a change in pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping.

2020-02-27 Thread GitBox
bjbrandt commented on a change in pull request #391: arch/arm/src/stm32/stm32f20xxf40xx_flash.c: Add progmen flash block mapping. URL: https://github.com/apache/incubator-nuttx/pull/391#discussion_r385129510 ## File path: arch/arm/src/stm32/stm32f20xxf40xx_flash.c ## @@

[GitHub] [incubator-nuttx] patacongo commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel

2020-02-27 Thread GitBox
patacongo commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591984773 > I have applications that call syslog_file_channel() based on run-time command-line arguments, You

[GitHub] [incubator-nuttx] yamt opened a new pull request #397: xtensa: Fix typos and comments

2020-02-28 Thread GitBox
yamt opened a new pull request #397: xtensa: Fix typos and comments URL: https://github.com/apache/incubator-nuttx/pull/397 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] Ouss4 merged pull request #397: xtensa: Fix typos and comments

2020-02-28 Thread GitBox
Ouss4 merged pull request #397: xtensa: Fix typos and comments URL: https://github.com/apache/incubator-nuttx/pull/397 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #111: apps: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
anchao opened a new pull request #111: apps: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx-apps/pull/111 Rename "Makefile" to "Nuttx.mk" to ensure the uniqueness of "Makefile" in different projects, which is meaningful

[GitHub] [incubator-nuttx] anchao opened a new pull request #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
anchao opened a new pull request #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399 Rename "Makefile" to "Nuttx.mk" to ensure the uniqueness of "Makefile" in different projects, which is meaningful

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #396: sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT

2020-02-28 Thread GitBox
liuguo09 opened a new pull request #396: sama5/serial: correct usage of USE_SERIALDRIVER and USE_EARLYSERIALINIT URL: https://github.com/apache/incubator-nuttx/pull/396 Also fix the following build warning: chip/sam_serialinit.c: In function 'sam_earlyserialinit':

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build

2020-02-28 Thread GitBox
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385582063 ## File path: arch/arm/src/Makefile ## @@ -80,6 +80,10 @@ endif # The "head" object HEAD_OBJ =

[GitHub] [incubator-nuttx] yamt opened a new pull request #398: xtensa: Fix up_schedule_sigaction

2020-02-28 Thread GitBox
yamt opened a new pull request #398: xtensa: Fix up_schedule_sigaction URL: https://github.com/apache/incubator-nuttx/pull/398 This fixes various crashes in ostest. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build

2020-02-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385589116 ## File path: arch/arm/src/Makefile ## @@ -80,6 +80,10 @@ endif # The "head" object

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build

2020-02-28 Thread GitBox
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385594289 ## File path: arch/arm/src/Makefile ## @@ -80,6 +80,10 @@ endif # The "head" object HEAD_OBJ =

[GitHub] [incubator-nuttx] jerpelea merged pull request #395: Disable net local

2020-02-28 Thread GitBox
jerpelea merged pull request #395: Disable net local URL: https://github.com/apache/incubator-nuttx/pull/395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build

2020-02-28 Thread GitBox
yamt commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385595813 ## File path: arch/arm/src/Makefile ## @@ -80,6 +80,10 @@ endif # The "head" object HEAD_OBJ =

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build

2020-02-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #380: arm: Fix "make export" for KERNEL build URL: https://github.com/apache/incubator-nuttx/pull/380#discussion_r385610442 ## File path: arch/arm/src/Makefile ## @@ -80,6 +80,10 @@ endif # The "head" object

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #65: Initial checkin apps github action CI workflow

2020-02-28 Thread GitBox
xiaoxiang781216 commented on issue #65: Initial checkin apps github action CI workflow URL: https://github.com/apache/incubator-nuttx-apps/pull/65#issuecomment-592534637 > Can we close this now? No, Haitao is preparing the final patch.

[GitHub] [incubator-nuttx] patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep

2020-02-28 Thread GitBox
patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592536135 Thie impacts of a change like this are too great. This cannot be accepted. A change like this

[GitHub] [incubator-nuttx-apps] patacongo commented on issue #65: Initial checkin apps github action CI workflow

2020-02-28 Thread GitBox
patacongo commented on issue #65: Initial checkin apps github action CI workflow URL: https://github.com/apache/incubator-nuttx-apps/pull/65#issuecomment-592533919 Can we close this now? This is an automated message from the

[GitHub] [incubator-nuttx] patacongo opened a new pull request #378: net/icmp/icmp_input.c: Clear sin_zero

2020-02-25 Thread GitBox
patacongo opened a new pull request #378: net/icmp/icmp_input.c: Clear sin_zero URL: https://github.com/apache/incubator-nuttx/pull/378 This should have been part of commit 861efdf8a3f7960119c2fc84c8333c75fea1434c but was overlooked.

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends

2020-02-25 Thread GitBox
adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#discussion_r383946147 ## File path:

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends

2020-02-25 Thread GitBox
adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#discussion_r383945971 ## File path:

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends

2020-02-25 Thread GitBox
adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#discussion_r383946269 ## File path:

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends

2020-02-25 Thread GitBox
adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#discussion_r383946466 ## File path:

[GitHub] [incubator-nuttx] adamfeuer commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends

2020-02-25 Thread GitBox
adamfeuer commented on issue #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends URL: https://github.com/apache/incubator-nuttx/pull/372#issuecomment-590920663 @patacongo @Ouss4 I will run nxstyle and fix the problems

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #378: net/icmp/icmp_input.c: Clear sin_zero

2020-02-25 Thread GitBox
xiaoxiang781216 merged pull request #378: net/icmp/icmp_input.c: Clear sin_zero URL: https://github.com/apache/incubator-nuttx/pull/378 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593973 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_spi.c ## @@ -0,0 +1,194 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593896 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_pwm.c ## @@ -0,0 +1,162 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388594257 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_usbmsc.c ## @@ -0,0 +1,108 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593555 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_hsmci.c ## @@ -0,0 +1,344 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593823 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ostest.c ## @@ -0,0 +1,114 @@

[GitHub] [incubator-nuttx] patacongo opened a new pull request #443: z20x: Correct RAM wait states.

2020-03-05 Thread GitBox
patacongo opened a new pull request #443: z20x: Correct RAM wait states. URL: https://github.com/apache/incubator-nuttx/pull/443 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593634 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_i2schar.c ## @@ -0,0 +1,126 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593741 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_nandflash.c ## @@ -0,0 +1,234 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592952 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_adc.c ## @@ -0,0 +1,101 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593267 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ethernet.c ## @@ -0,0 +1,343 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592910 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_at25.c ## @@ -0,0 +1,143 @@

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593179 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_can.c ## @@ -0,0 +1,115 @@

[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
adamfeuer opened a new pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444 ### Summary * SAMA5D27 USB Host support working * Other peripherals added as a work in progress, but not tested * Minor nxstyle

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working

2020-03-05 Thread GitBox
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592223 ## File path: boards/arm/sama5/sama5d2-xult/include/board_498mhz.h ## @@ -0,0 +1,217 @@

[GitHub] [incubator-nuttx] patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.

2020-03-05 Thread GitBox
patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442#issuecomment-595443228 Another option is to use a 'define POSTBUILD' in tools/Config.mk. That definition would be empty , but

[GitHub] [incubator-nuttx] acassis merged pull request #443: z20x: Correct RAM wait states.

2020-03-05 Thread GitBox
acassis merged pull request #443: z20x: Correct RAM wait states. URL: https://github.com/apache/incubator-nuttx/pull/443 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] igrr commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU

2020-03-05 Thread GitBox
igrr commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388416984 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp

[GitHub] [incubator-nuttx] yamt commented on issue #447: ESP32 module support

2020-03-05 Thread GitBox
yamt commented on issue #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#issuecomment-595569920 @patacongo this pr includes a commit https://github.com/apache/incubator-nuttx/pull/447/commits/243427296613dcbe650138fb248d8009012832f6 which modifies your

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388699113 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388709203 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh +

[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595625436 > @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is

[GitHub] [incubator-nuttx] yamt opened a new pull request #447: Esp32 module

2020-03-05 Thread GitBox
yamt opened a new pull request #447: Esp32 module URL: https://github.com/apache/incubator-nuttx/pull/447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595569258 > This looks great overall. I am excited to get this in and then work on getting the mac and windows configurations going. >

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #437: Support to run NuttX on ESP32 QEMU

2020-03-05 Thread GitBox
masayuki2009 commented on issue #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#issuecomment-595576729 @maht, thanks for sending this PR. I confirmed that nuttx works on ESP32 QEMU. (SMP configuration also works!) However, I noticed

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388692212 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #448: Add a sample of git pre-commit hook

2020-03-05 Thread GitBox
yamt commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388701099 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh +

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #450: arch: xtensa: Call the waiti instruction in up_idle()

2020-03-05 Thread GitBox
masayuki2009 opened a new pull request #450: arch: xtensa: Call the waiti instruction in up_idle() URL: https://github.com/apache/incubator-nuttx/pull/450 ### Summary - This PR calls the waiti (wait for interrupt) instruction in up_idle() to reduce power consumption. ###

[GitHub] [incubator-nuttx] yamt opened a new pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…

2020-03-05 Thread GitBox
yamt opened a new pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid… URL: https://github.com/apache/incubator-nuttx/pull/453 … some false alarms was causing real style problems from being reported." If we are going to use this tool for things

[GitHub] [incubator-nuttx] yamt opened a new pull request #454: nuttx/arch.h: Several nxstyle fixes

2020-03-05 Thread GitBox
yamt opened a new pull request #454: nuttx/arch.h: Several nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/454 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook

2020-03-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388691596 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh +

[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388694067 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow

2020-03-05 Thread GitBox
xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595593159 Yes, we can select some images(sim, x86, x86-64, qemu for arm/riscv/xtens..) as build artifacts and run the testsuite on

[GitHub] [incubator-nuttx] yamt commented on issue #450: arch: xtensa: Call the waiti instruction in up_idle()

2020-03-05 Thread GitBox
yamt commented on issue #450: arch: xtensa: Call the waiti instruction in up_idle() URL: https://github.com/apache/incubator-nuttx/pull/450#issuecomment-595620856 lgtm. i have had the identical change in my local tree for a while. i haven't noticed any negative effect at least on qemu.

[GitHub] [incubator-nuttx] patacongo merged pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr

2020-03-05 Thread GitBox
patacongo merged pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr URL: https://github.com/apache/incubator-nuttx/pull/446 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] yamt opened a new pull request #452: nxstyle: Don't warn on a preprocessor directive after comment

2020-03-05 Thread GitBox
yamt opened a new pull request #452: nxstyle: Don't warn on a preprocessor directive after comment URL: https://github.com/apache/incubator-nuttx/pull/452 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] yamt commented on issue #452: nxstyle: Don't warn on a preprocessor directive after comment

2020-03-05 Thread GitBox
yamt commented on issue #452: nxstyle: Don't warn on a preprocessor directive after comment URL: https://github.com/apache/incubator-nuttx/pull/452#issuecomment-595619505 oops, wrong branch This is an automated message from

[GitHub] [incubator-nuttx] yamt closed pull request #452: nxstyle: Don't warn on a preprocessor directive after comment

2020-03-05 Thread GitBox
yamt closed pull request #452: nxstyle: Don't warn on a preprocessor directive after comment URL: https://github.com/apache/incubator-nuttx/pull/452 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] yamt opened a new pull request #448: Add a sample of git pre-commit hook

2020-03-05 Thread GitBox
yamt opened a new pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #448: Add a sample of git pre-commit hook

2020-03-05 Thread GitBox
yamt commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388695824 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh +

[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #449: Add Apache 2.0 License headers to SAMA5 files — no code changes

2020-03-05 Thread GitBox
adamfeuer opened a new pull request #449: Add Apache 2.0 License headers to SAMA5 files — no code changes URL: https://github.com/apache/incubator-nuttx/pull/449 ### Summary * Adds Apache 2.0 License headers to SAMA5 — no code changes. * Some non-UTF-characters were removed or

<    1   2   3   4   5   6   7   8   9   10   >