[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-10-07 Thread GitBox
codecov-io edited a comment on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-532548562 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4608?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-10-07 Thread GitBox
chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r332295609 ## File path:

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4685: [TE] handle data insufficient exceptions in the detection pipeline

2019-10-07 Thread GitBox
jihaozh opened a new pull request #4685: [TE] handle data insufficient exceptions in the detection pipeline URL: https://github.com/apache/incubator-pinot/pull/4685 When new metrics are on-boarded into ThirdEye, we expect the detector to throw a checked exception on the case that the data

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-10-07 Thread GitBox
chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r332288358 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated (18a9f2f -> 2d20c64)

2019-10-07 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 18a9f2f Use guava cache for instance admin endpoints (#4678) add 2d20c64 Possible fix for NPE seen

[GitHub] [incubator-pinot] mcvsubbu merged pull request #4684: Possible fix for NPE seen in this test.

2019-10-07 Thread GitBox
mcvsubbu merged pull request #4684: Possible fix for NPE seen in this test. URL: https://github.com/apache/incubator-pinot/pull/4684 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] kishoreg edited a comment on issue #4590: Disallowing multiple inputs in preprocess

2019-10-07 Thread GitBox
kishoreg edited a comment on issue #4590: Disallowing multiple inputs in preprocess URL: https://github.com/apache/incubator-pinot/pull/4590#issuecomment-539227739 Why are we doing this. What happens today if multiple input paths are provided. Is this LinkedIn specific?

[GitHub] [incubator-pinot] kishoreg commented on issue #4590: Disallowing multiple inputs in preprocess

2019-10-07 Thread GitBox
kishoreg commented on issue #4590: Disallowing multiple inputs in preprocess URL: https://github.com/apache/incubator-pinot/pull/4590#issuecomment-539227739 Why are we doing this? This is an automated message from the Apache

[GitHub] [incubator-pinot] codecov-io commented on issue #4684: Possible fix for NPE seen in this test.

2019-10-07 Thread GitBox
codecov-io commented on issue #4684: Possible fix for NPE seen in this test. URL: https://github.com/apache/incubator-pinot/pull/4684#issuecomment-539223903 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4684?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332257680 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #4684: Possible fix for NPE seen in this test.

2019-10-07 Thread GitBox
mcvsubbu opened a new pull request #4684: Possible fix for NPE seen in this test. URL: https://github.com/apache/incubator-pinot/pull/4684 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332239992 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332223055 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r33014 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java ## @@

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-10-07 Thread GitBox
npawar commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332221377 ## File path:

[GitHub] [incubator-pinot] jenniferdai closed pull request #4591: Deleting preprocess output post segment creation

2019-10-07 Thread GitBox
jenniferdai closed pull request #4591: Deleting preprocess output post segment creation URL: https://github.com/apache/incubator-pinot/pull/4591 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch deletepreprocessoutput deleted (was 24d551c)

2019-10-07 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch deletepreprocessoutput in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 24d551c Deleting preprocess output post segment creation The revisions that were on

[GitHub] [incubator-pinot] jenniferdai closed pull request #4590: Disallowing multiple inputs in preprocess

2019-10-07 Thread GitBox
jenniferdai closed pull request #4590: Disallowing multiple inputs in preprocess URL: https://github.com/apache/incubator-pinot/pull/4590 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch paths deleted (was fa31be6)

2019-10-07 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch paths in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was fa31be6 Disallowing multiple inputs in preprocess The revisions that were on this branch are still

[GitHub] [incubator-pinot] jackjlli closed pull request #4662: Add wait for condition for toggle test

2019-10-07 Thread GitBox
jackjlli closed pull request #4662: Add wait for condition for toggle test URL: https://github.com/apache/incubator-pinot/pull/4662 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] jackjlli commented on issue #4662: Add wait for condition for toggle test

2019-10-07 Thread GitBox
jackjlli commented on issue #4662: Add wait for condition for toggle test URL: https://github.com/apache/incubator-pinot/pull/4662#issuecomment-539184674 This PR isn't needed any more. Closing this PR. This is an automated

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4683: [TE] frontend - harleyjj/packages - update node and front end packages

2019-10-07 Thread GitBox
harleyjj opened a new pull request #4683: [TE] frontend - harleyjj/packages - update node and front end packages URL: https://github.com/apache/incubator-pinot/pull/4683 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] jackjlli merged pull request #4678: Use guava cache for instance admin endpoints

2019-10-07 Thread GitBox
jackjlli merged pull request #4678: Use guava cache for instance admin endpoints URL: https://github.com/apache/incubator-pinot/pull/4678 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated (aa04c57 -> 18a9f2f)

2019-10-07 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from aa04c57 Remove validation for config controller.host (#4681) add 18a9f2f Use guava cache for instance

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4680: Ensure segment converter not fail for schemas without time fieldSpec

2019-10-07 Thread GitBox
Jackie-Jiang commented on issue #4680: Ensure segment converter not fail for schemas without time fieldSpec URL: https://github.com/apache/incubator-pinot/pull/4680#issuecomment-539135699 @fx19880617 For real-time table, time field is mandatory. It should fail without time field.

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-10-07 Thread GitBox
Jackie-Jiang commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r332159608 ## File path:

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4682: [TE] [notification] JIRA alerting framework

2019-10-07 Thread GitBox
akshayrai opened a new pull request #4682: [TE] [notification] JIRA alerting framework URL: https://github.com/apache/incubator-pinot/pull/4682 Changes: * Laid out the framework for filing alerts via JIRA tickets * Added jira template for Metric Alerts - (TODO: template for Entity