[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-10-09 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324936447 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java ###

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324935988 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/CombineGroupByOrderByOperator.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-16 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324935815 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java ###

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411518 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java ###

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411766 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/CombineGroupByOrderByOperator.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411811 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java ## @@ -

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411231 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411786 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.ja

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411567 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java ###

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411445 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java ###

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411303 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ##