[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r693645689 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -55,14 +57,25 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691550554 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -54,14 +55,27 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r692440213 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -29,21 +33,31 @@ @ThreadSafe public abstract

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691665938 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -54,14 +55,27 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691665938 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -54,14 +55,27 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691549932 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,111

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691551005 ## File path: pinot-common/src/main/java/org/apache/pinot/common/messages/RunPeriodicTaskMessage.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691550086 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerMessageHandlerFactory.java ## @@ -0,0 +1,106 @@ +/** + * Licensed to

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691549932 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,111

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691549686 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTaskScheduler.java ## @@ -108,4 +111,62 @@ public synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691549537 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTaskScheduler.java ## @@ -108,4 +111,62 @@ public synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691549392 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTask.java ## @@ -28,6 +29,10 @@ @ThreadSafe public interface

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691549206 ## File path: pinot-common/src/main/java/org/apache/pinot/common/messages/RunPeriodicTaskMessage.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r691548743 ## File path: pinot-common/src/main/java/org/apache/pinot/common/messages/RunPeriodicTaskMessage.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to the

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r689233690 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -111,22 +126,47 @@ protected void setUpTask() {

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r688796021 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -111,22 +126,49 @@ protected void setUpTask() {

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r68792 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,96

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687923968 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -54,14 +54,22 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687923747 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -54,14 +54,22 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687923335 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -111,22 +126,49 @@ protected void setUpTask() {

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687923127 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -111,22 +126,49 @@ protected void setUpTask() {

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687920039 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTaskScheduler.java ## @@ -108,4 +111,59 @@ public synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687919497 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTaskScheduler.java ## @@ -108,4 +111,59 @@ public synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687915699 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTaskScheduler.java ## @@ -108,4 +111,59 @@ public synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687249727 ## File path: pinot-core/src/test/java/org/apache/pinot/core/periodictask/PeriodicTaskSchedulerTest.java ## @@ -104,4 +105,79 @@ protected void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687075618 ## File path: pinot-core/src/test/java/org/apache/pinot/core/periodictask/PeriodicTaskSchedulerTest.java ## @@ -104,4 +105,79 @@ protected void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r687075235 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java ## @@ -54,14 +54,22 @@

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685681601 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTask.java ## @@ -59,6 +59,12 @@ @Override void run(); + /** +

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685686310 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerMessageHandlerFactory.java ## @@ -0,0 +1,91 @@ +/** + * Licensed to

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685683806 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,104

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685681601 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/PeriodicTask.java ## @@ -59,6 +59,12 @@ @Override void run(); + /** +

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685681272 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,104

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685681176 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerMessageHandlerFactory.java ## @@ -0,0 +1,91 @@ +/** + * Licensed to

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685680810 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -149,27 +182,17 @@ public final synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685680723 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,104

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685680622 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerMessageHandlerFactory.java ## @@ -0,0 +1,91 @@ +/** + * Licensed to

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r685680308 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/MinionInstancesCleanupTask.java ## @@ -54,8 +54,11 @@ public

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r684412812 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,84

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r684412812 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,84

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r684412586 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/MinionInstancesCleanupTask.java ## @@ -54,8 +54,11 @@ public

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r684385072 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerPeriodicTaskRestletResource.java ## @@ -0,0 +1,84

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r684366753 ## File path: pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java ## @@ -87,13 +94,16 @@ public final synchronized void

[GitHub] [pinot] amrishlal commented on a change in pull request #7174: Manually trigger PeriodicTask

amrishlal commented on a change in pull request #7174: URL: https://github.com/apache/pinot/pull/7174#discussion_r684366315 ## File path: pinot-common/src/main/java/org/apache/pinot/common/messages/RunPeriodicTaskMessage.java ## @@ -0,0 +1,64 @@ +/** + * Licensed to the