[GitHub] [incubator-pinot] katewang0710 commented on issue #4052: skip .swp files for vim users

2019-04-03 Thread GitBox
katewang0710 commented on issue #4052: skip .swp files for vim users URL: https://github.com/apache/incubator-pinot/pull/4052#issuecomment-479358548 Thanks @snleee @jackjlli ! I am very interested in Pinot. Hope to contribute more to the community. Are there any features or bugs I can

[GitHub] [incubator-pinot] jihaozh merged pull request #4046: [TE] frontend - harleyjj/alert-overview - display dash and n/a when v…

2019-04-03 Thread GitBox
jihaozh merged pull request #4046: [TE] frontend - harleyjj/alert-overview - display dash and n/a when v… URL: https://github.com/apache/incubator-pinot/pull/4046 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/alert-overview - display dash and n/a when value is undefined (#4046)

2019-04-03 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8121927 [TE] frontend -

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271854336 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271854266 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271851972 ## File path: pinot-common/src/main/java/org/apache/pinot/annotations/InterfaceAudience.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271854441 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271854132 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271852238 ## File path: pinot-common/src/main/java/org/apache/pinot/annotations/InterfaceAudience.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271854403 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
mayankshriv commented on a change in pull request #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#discussion_r271883667 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4066: [TE] frontend - harleyjj/anomalies - prototype anomalies route replac…

2019-04-03 Thread GitBox
harleyjj opened a new pull request #4066: [TE] frontend - harleyjj/anomalies - prototype anomalies route replac… URL: https://github.com/apache/incubator-pinot/pull/4066 …ement 1) Implements Anomalies route in Ember to replace legacy code in Apache FreeMarker 2) Route can be

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #3852: add support for parquet reader

2019-04-03 Thread GitBox
Jackie-Jiang commented on issue #3852: add support for parquet reader URL: https://github.com/apache/incubator-pinot/pull/3852#issuecomment-479671496 @WangGuangxin We should not add parquet dependency into **pinot-common**. I'll move the parquet related classes into a new package

[GitHub] [incubator-pinot] fx19880617 commented on issue #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
fx19880617 commented on issue #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#issuecomment-479669805 > Last time I added an exit to this class, all sorts of things broke. It was fixed in this commit >

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271912337 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on issue #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
mayankshriv commented on issue #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#issuecomment-479675493 One way to address this could be how PerfBenchmarkDriver starts the cluster without the PinotAdmin.

[GitHub] [incubator-pinot] tangdian commented on issue #4067: [TE] Holt Winters detector

2019-04-03 Thread GitBox
tangdian commented on issue #4067: [TE] Holt Winters detector URL: https://github.com/apache/incubator-pinot/pull/4067#issuecomment-479632194 > This is amazing. Can you write up README on how this detection spec can be configured. Thanks. Yes, I will write an detailed README in

[GitHub] [incubator-pinot] snleee opened a new pull request #4069: Revert "add support for parquet reader"

2019-04-03 Thread GitBox
snleee opened a new pull request #4069: Revert "add support for parquet reader" URL: https://github.com/apache/incubator-pinot/pull/4069 Reverts apache/incubator-pinot#3852 This is an automated message from the Apache Git

[incubator-pinot] 01/01: Revert "add support for parquet reader (#3852)"

2019-04-03 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch revert-3852-parquet_reader in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit bb57c1053c2c2e96da14da8e8103f057b9b938c5 Author: Seunghyun Lee AuthorDate: Wed Apr 3

[incubator-pinot] branch revert-3852-parquet_reader created (now bb57c10)

2019-04-03 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch revert-3852-parquet_reader in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at bb57c10 Revert "add support for parquet reader (#3852)" This branch includes the

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271945008 ## File path: pinot-common/src/main/java/org/apache/pinot/annotations/InterfaceStability.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271944264 ## File path: pinot-common/src/main/java/org/apache/pinot/annotations/InterfaceStability.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271942842 ## File path: pinot-common/src/main/java/org/apache/pinot/annotations/InterfaceAudience.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271943378 ## File path: pinot-common/src/main/java/org/apache/pinot/annotations/InterfaceAudience.java

[GitHub] [incubator-pinot] akshayrai merged pull request #4064: [TE] Deprecate and remove thirdeye-hadoop module

2019-04-03 Thread GitBox
akshayrai merged pull request #4064: [TE] Deprecate and remove thirdeye-hadoop module URL: https://github.com/apache/incubator-pinot/pull/4064 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: [TE] Disable thirdeye-hadoop (#4064)

2019-04-03 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new fdd9b92 [TE] Disable

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
mcvsubbu commented on issue #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#issuecomment-479642485 Last time I added an exit to this class, all sorts of things broke. It was fixed in this commit

[GitHub] [incubator-pinot] snleee closed pull request #4069: Revert "add support for parquet reader"

2019-04-03 Thread GitBox
snleee closed pull request #4069: Revert "add support for parquet reader" URL: https://github.com/apache/incubator-pinot/pull/4069 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-pinot] branch revert-3852-parquet_reader deleted (was bb57c10)

2019-04-03 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch revert-3852-parquet_reader in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was bb57c10 Revert "add support for parquet reader (#3852)" The revisions that were on

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271955457 ## File path:

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4068: [TE] frontend - harleyjj/yaml-editor - surface error message in put

2019-04-03 Thread GitBox
harleyjj opened a new pull request #4068: [TE] frontend - harleyjj/yaml-editor - surface error message in put URL: https://github.com/apache/incubator-pinot/pull/4068 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271913552 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
sunithabeeram commented on a change in pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#discussion_r271913577 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
sunithabeeram commented on issue #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063#issuecomment-479663679 Travis failure is unrelated. Following up with @snleee to see if the newly introduced travis wait is able to

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/yaml-editor - surface error message in put (#4068)

2019-04-03 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new f66c342 [TE] frontend -

[incubator-pinot] branch master updated: [TE] Clean up logging messages; remove default ref links (#4059)

2019-04-03 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8c3edbb [TE] Clean up logging

[GitHub] [incubator-pinot] mcvsubbu commented on issue #3849: Using PinotFS interface instead of local file to download a segment f…

2019-04-03 Thread GitBox
mcvsubbu commented on issue #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#issuecomment-479587869 Also, the servers should pull from the URI that is there in the metadata. The way we should solve this

[GitHub] [incubator-pinot] mcvsubbu closed issue #73: About stable version

2019-04-03 Thread GitBox
mcvsubbu closed issue #73: About stable version URL: https://github.com/apache/incubator-pinot/issues/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] mcvsubbu commented on issue #73: About stable version

2019-04-03 Thread GitBox
mcvsubbu commented on issue #73: About stable version URL: https://github.com/apache/incubator-pinot/issues/73#issuecomment-479551145 there is one now This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4060: Fix minute speedup

2019-04-03 Thread GitBox
xiaohui-sun merged pull request #4060: Fix minute speedup URL: https://github.com/apache/incubator-pinot/pull/4060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-04-03 Thread GitBox
tangdian commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r271814435 ## File path:

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
fx19880617 opened a new pull request #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065 For better integration with scripting languages. This is an automated

[GitHub] [incubator-pinot] mcvsubbu commented on issue #3351: When will the release version be issued?

2019-04-03 Thread GitBox
mcvsubbu commented on issue #3351: When will the release version be issued? URL: https://github.com/apache/incubator-pinot/issues/3351#issuecomment-479548178 Release 0.1.0 available now This is an automated message from

[GitHub] [incubator-pinot] mcvsubbu closed issue #3315: push data

2019-04-03 Thread GitBox
mcvsubbu closed issue #3315: push data URL: https://github.com/apache/incubator-pinot/issues/3315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4064: [TE] Deprecate and remove thirdeye-hadoop module

2019-04-03 Thread GitBox
xiaohui-sun commented on issue #4064: [TE] Deprecate and remove thirdeye-hadoop module URL: https://github.com/apache/incubator-pinot/pull/4064#issuecomment-479609687 Can you hold the deletion for now? I am looking into how this is used in UMP. We need a plan to retire them completely.

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
sunithabeeram commented on issue #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061#issuecomment-479547731 Would be also good to add a test. This is an automated

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3849: Using PinotFS interface instead of local file to download a segment f…

2019-04-03 Thread GitBox
mcvsubbu commented on a change in pull request #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#discussion_r271809995 ## File path:

[GitHub] [incubator-pinot] mcvsubbu closed issue #1635: About coding style

2019-04-03 Thread GitBox
mcvsubbu closed issue #1635: About coding style URL: https://github.com/apache/incubator-pinot/issues/1635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] mcvsubbu commented on issue #1635: About coding style

2019-04-03 Thread GitBox
mcvsubbu commented on issue #1635: About coding style URL: https://github.com/apache/incubator-pinot/issues/1635#issuecomment-479550534 https://pinot.readthedocs.io/en/latest/dev_env.html This is an automated message from

[GitHub] [incubator-pinot] mcvsubbu closed issue #1525: Images on Wiki pages are not viewable

2019-04-03 Thread GitBox
mcvsubbu closed issue #1525: Images on Wiki pages are not viewable URL: https://github.com/apache/incubator-pinot/issues/1525 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4063: Introduce interface stability and audience annotations

2019-04-03 Thread GitBox
sunithabeeram opened a new pull request #4063: Introduce interface stability and audience annotations URL: https://github.com/apache/incubator-pinot/pull/4063 Implementation for https://github.com/apache/incubator-pinot/issues/4031. I have annotated couple of interfaces as an example.

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4064: [TE] Deprecate and remove thirdeye-hadoop module

2019-04-03 Thread GitBox
akshayrai opened a new pull request #4064: [TE] Deprecate and remove thirdeye-hadoop module URL: https://github.com/apache/incubator-pinot/pull/4064 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
sunithabeeram commented on issue #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061#issuecomment-479547367 Do we already have checks in the path where the config is being set to not allow invalid configs? (I understand someone can

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-04-03 Thread GitBox
tangdian commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r271814435 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4059: [TE] Improve logging messages; put default ref links only when empty

2019-04-03 Thread GitBox
xiaohui-sun commented on a change in pull request #4059: [TE] Improve logging messages; put default ref links only when empty URL: https://github.com/apache/incubator-pinot/pull/4059#discussion_r271828358 ## File path:

[GitHub] [incubator-pinot] tangdian commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-04-03 Thread GitBox
tangdian commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r271828177 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #3849: Using PinotFS interface instead of local file to download a segment f…

2019-04-03 Thread GitBox
npawar commented on a change in pull request #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#discussion_r271831467 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272012101 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4068: [TE] frontend - harleyjj/yaml-editor - surface error message in put

2019-04-03 Thread GitBox
xiaohui-sun merged pull request #4068: [TE] frontend - harleyjj/yaml-editor - surface error message in put URL: https://github.com/apache/incubator-pinot/pull/4068 This is an automated message from the Apache Git Service.

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-04-03 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r271972979 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-04-03 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r271975504 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-04-03 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r271970786 ## File path:

[GitHub] [incubator-pinot] chenboat commented on issue #3849: Using PinotFS interface instead of local file to download a segment f…

2019-04-03 Thread GitBox
chenboat commented on issue #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#issuecomment-479703907 > Also, the servers should pull from the URI that is there in the metadata. The way we should solve

[GitHub] [incubator-pinot] fx19880617 commented on issue #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
fx19880617 commented on issue #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#issuecomment-479718803 I thought it’s intentional to have ChaosMonkey test here to start processes for sending signal? I added a check

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
Jackie-Jiang opened a new pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073 Create a new package: pinot-parquet for all Parquet related classes Remove the dependency of parquet-avro from pinot-common

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #3852: add support for parquet reader

2019-04-03 Thread GitBox
Jackie-Jiang commented on issue #3852: add support for parquet reader URL: https://github.com/apache/incubator-pinot/pull/3852#issuecomment-479737767 > > @WangGuangxin We should not add parquet dependency into **pinot-common**. I'll move the parquet related classes into a new package

[GitHub] [incubator-pinot] snleee edited a comment on issue #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
snleee edited a comment on issue #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061#issuecomment-479752162 @sunithabeeram There's a `POST /tenants` API that tries to assign tags for untagged servers/brokers using a configured number

[GitHub] [incubator-pinot] snleee edited a comment on issue #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
snleee edited a comment on issue #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061#issuecomment-479752162 @sunithabeeram There's a `POST /tenants` API that tries to assign tags for untagged servers/brokers using a configured number

[GitHub] [incubator-pinot] codecov-io commented on issue #4074: Always enable default column feature, remove the configuration

2019-04-03 Thread GitBox
codecov-io commented on issue #4074: Always enable default column feature, remove the configuration URL: https://github.com/apache/incubator-pinot/pull/4074#issuecomment-479752325 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4074?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
codecov-io edited a comment on issue #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061#issuecomment-479337121 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4061?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [incubator-pinot] snleee commented on issue #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
snleee commented on issue #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061#issuecomment-479752162 @sunithabeeram There's a `POST /tenants` API that tries to assign tags for untagged servers/brokers using a configured number of

[GitHub] [incubator-pinot] snleee commented on issue #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
snleee commented on issue #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#issuecomment-479743389 TODO: Let's add the documentation on adding a new record reader and link orc/parquet prs as examples.

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
snleee commented on a change in pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272011649 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
snleee commented on a change in pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272010618 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReaderFactory.java

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
snleee commented on a change in pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272008628 ## File path: pinot-parquet/src/main/java/org/apache/pinot/parquet/data/readers/ParquetUtils.java

[incubator-pinot] 01/01: Remove stale test RealtimeTableDataManagerTest

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch remove_old_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 18282623c2691148fa4d3c9341b2cb517a07004f Author: Jackie (Xiaotian) Jiang AuthorDate: Wed Apr 3

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4075: Remove stale test RealtimeTableDataManagerTest

2019-04-03 Thread GitBox
Jackie-Jiang opened a new pull request #4075: Remove stale test RealtimeTableDataManagerTest URL: https://github.com/apache/incubator-pinot/pull/4075 RealtimeTableDataManagerTest is a stale test class and does not have any test enabled The test itself does not reflect to the data file,

[incubator-pinot] branch remove_old_test created (now 1828262)

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch remove_old_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 1828262 Remove stale test RealtimeTableDataManagerTest This branch includes the following new

[incubator-pinot] branch master updated: Move Parquet related classes to the new package (#4073)

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8036bff Move Parquet related classes

[GitHub] [incubator-pinot] codecov-io commented on issue #4075: Remove stale test RealtimeTableDataManagerTest

2019-04-03 Thread GitBox
codecov-io commented on issue #4075: Remove stale test RealtimeTableDataManagerTest URL: https://github.com/apache/incubator-pinot/pull/4075#issuecomment-479751988 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4075?src=pr=h1) Report > Merging

[incubator-pinot] branch fix_parquet deleted (was 4f6600e)

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_parquet in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 4f6600e Move Parquet related classes to the new package The revisions that were on this branch are

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
Jackie-Jiang merged pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #3849: Using PinotFS interface instead of local file to download a segment f…

2019-04-03 Thread GitBox
chenboat commented on a change in pull request #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#discussion_r271981037 ## File path:

[GitHub] [incubator-pinot] WangGuangxin commented on issue #3852: add support for parquet reader

2019-04-03 Thread GitBox
WangGuangxin commented on issue #3852: add support for parquet reader URL: https://github.com/apache/incubator-pinot/pull/3852#issuecomment-479721979 > @WangGuangxin We should not add parquet dependency into **pinot-common**. I'll move the parquet related classes into a new package

[incubator-pinot] 01/01: Always enable default column feature, remove the configuration

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch default_column in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit a68fe47869ac0e052b24873e01a5edee1eb57721 Author: Jackie (Xiaotian) Jiang AuthorDate: Wed Apr 3

[incubator-pinot] branch default_column created (now a68fe47)

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch default_column in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at a68fe47 Always enable default column feature, remove the configuration This branch includes the

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4074: Always enable default column feature, remove the configuration

2019-04-03 Thread GitBox
Jackie-Jiang opened a new pull request #4074: Always enable default column feature, remove the configuration URL: https://github.com/apache/incubator-pinot/pull/4074 The configuration is introduced to test the default column feature. Since it has been tested thoroughly for years, remove

[incubator-pinot] branch fix_parquet created (now 4f6600e)

2019-04-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_parquet in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 4f6600e Move Parquet related classes to the new package No new revisions were added by this update.

[GitHub] [incubator-pinot] icefury71 commented on issue #4029: Failure to retrieve data after adding column to table schema.

2019-04-03 Thread GitBox
icefury71 commented on issue #4029: Failure to retrieve data after adding column to table schema. URL: https://github.com/apache/incubator-pinot/issues/4029#issuecomment-479708075 I believe we need to enable this config in the servers "enable.default.columns=true" . This is necessary

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3849: Using PinotFS interface instead of local file to download a segment f…

2019-04-03 Thread GitBox
codecov-io edited a comment on issue #3849: Using PinotFS interface instead of local file to download a segment f… URL: https://github.com/apache/incubator-pinot/pull/3849#issuecomment-465449456 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3849?src=pr=h1) Report >

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272011917 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4073: Move Parquet related classes to the new package

2019-04-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #4073: Move Parquet related classes to the new package URL: https://github.com/apache/incubator-pinot/pull/4073#discussion_r272012030 ## File path:

[GitHub] [incubator-pinot] snleee closed pull request #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
snleee closed pull request #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] snleee opened a new pull request #4061: Fix 500 issue with 'GET /tenants' API call

2019-04-03 Thread GitBox
snleee opened a new pull request #4061: Fix 500 issue with 'GET /tenants' API call URL: https://github.com/apache/incubator-pinot/pull/4061 When a server has a wrong formatted tag, current implemantation would return 500 error for GET /tenants call. In that case, we should not fail

[GitHub] [incubator-pinot] sunithabeeram opened a new issue #4070: Handle errors in consuming from streams consistent across: especially across HL and LLRealtimeSegmentDataManagers

2019-04-03 Thread GitBox
sunithabeeram opened a new issue #4070: Handle errors in consuming from streams consistent across: especially across HL and LLRealtimeSegmentDataManagers URL: https://github.com/apache/incubator-pinot/issues/4070 We can have the errors in the following phases during realtime consumption:

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4071: [TE] frontend - harleyjj/yaml-editor - if there is no existing subscr…

2019-04-03 Thread GitBox
harleyjj opened a new pull request #4071: [TE] frontend - harleyjj/yaml-editor - if there is no existing subscr… URL: https://github.com/apache/incubator-pinot/pull/4071 …iption group, the user can create one on edit-alert 1) Makes it possible to define a subscription group for an

[GitHub] [incubator-pinot] codecov-io commented on issue #4065: Exit 1 when caught exception in Pinot Admin command.

2019-04-03 Thread GitBox
codecov-io commented on issue #4065: Exit 1 when caught exception in Pinot Admin command. URL: https://github.com/apache/incubator-pinot/pull/4065#issuecomment-479706993 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4065?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang edited a comment on issue #4029: Failure to retrieve data after adding column to table schema.

2019-04-03 Thread GitBox
Jackie-Jiang edited a comment on issue #4029: Failure to retrieve data after adding column to table schema. URL: https://github.com/apache/incubator-pinot/issues/4029#issuecomment-479742898 @icefury71 is right. We introduced this configuration to test out the default column feature long

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4029: Failure to retrieve data after adding column to table schema.

2019-04-03 Thread GitBox
Jackie-Jiang commented on issue #4029: Failure to retrieve data after adding column to table schema. URL: https://github.com/apache/incubator-pinot/issues/4029#issuecomment-479742898 @icefury71 is right. We introduced this configuration to test out the default column feature long time