[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO)

2019-06-25 Thread GitBox
sunithabeeram commented on a change in pull request #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO) URL: https://github.com/apache/incubator-pinot/pull/4356#discussion_r297224946 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO)

2019-06-25 Thread GitBox
sunithabeeram commented on a change in pull request #4356: Emit metrics to track performance against specific Service-Level-Objectives (SLO) URL: https://github.com/apache/incubator-pinot/pull/4356#discussion_r297223971 ## File path:

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4358: Raise the threshold of using MMAP for inverted index creation from 100M to 2G

2019-06-25 Thread GitBox
sunithabeeram commented on issue #4358: Raise the threshold of using MMAP for inverted index creation from 100M to 2G URL: https://github.com/apache/incubator-pinot/pull/4358#issuecomment-505473549 Did we run any tests to verify the hypothesis/claims? It would be great if we can validate

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

2019-06-25 Thread GitBox
sunithabeeram commented on issue #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API URL: https://github.com/apache/incubator-pinot/pull/4362#issuecomment-505476440 Do you have numbers from tests for this?

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4363: When initializing mutable dictionary, preserve 20% buffer for cardinality to reduce the chance of re-sizing the dictionary

2019-06-25 Thread GitBox
sunithabeeram commented on issue #4363: When initializing mutable dictionary, preserve 20% buffer for cardinality to reduce the chance of re-sizing the dictionary URL: https://github.com/apache/incubator-pinot/pull/4363#issuecomment-505476793 Please add numbers from testing for PRs like

[GitHub] [incubator-pinot] akshayrai merged pull request #4359: [TE] Tuning of Composite alert - Store metric refs in component spec

2019-06-25 Thread GitBox
akshayrai merged pull request #4359: [TE] Tuning of Composite alert - Store metric refs in component spec URL: https://github.com/apache/incubator-pinot/pull/4359 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] Tuning of Composite alert - Store metric refs in component spec (#4359)

2019-06-25 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 859c68c [TE] Tuning of Composite

[GitHub] [incubator-pinot] mayankshriv commented on issue #4325: Upgrade fastutil to 8.2.3

2019-06-25 Thread GitBox
mayankshriv commented on issue #4325: Upgrade fastutil to 8.2.3 URL: https://github.com/apache/incubator-pinot/pull/4325#issuecomment-505512320 @xueyumusic Also, I was curious as to what triggered this change? Did you run into an issue and identified that it was fixed in the newer version,

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297302153 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297302096 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297302182 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

2019-06-25 Thread GitBox
mayankshriv commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API URL: https://github.com/apache/incubator-pinot/pull/4362#discussion_r297266649 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

2019-06-25 Thread GitBox
mcvsubbu commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API URL: https://github.com/apache/incubator-pinot/pull/4362#discussion_r297273221 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4363: When initializing mutable dictionary, preserve 20% buffer for cardinality to reduce the chance of re-sizing the diction

2019-06-25 Thread GitBox
mcvsubbu commented on a change in pull request #4363: When initializing mutable dictionary, preserve 20% buffer for cardinality to reduce the chance of re-sizing the dictionary URL: https://github.com/apache/incubator-pinot/pull/4363#discussion_r297260962 ## File path:

[GitHub] [incubator-pinot] mayankshriv commented on issue #4325: Upgrade fastutil to 8.2.3

2019-06-25 Thread GitBox
mayankshriv commented on issue #4325: Upgrade fastutil to 8.2.3 URL: https://github.com/apache/incubator-pinot/pull/4325#issuecomment-505511308 @xueyumusic Thanks for clarifying. For future, best to have separate PR's for unrelated changes. Or if the changes are small (and unrelated to the

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297302081 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
jihaozh commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297332562 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
jihaozh commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297330539 ## File path:

[GitHub] [incubator-pinot] kishoreg merged pull request #4346: Adding support for udfs in Selection

2019-06-25 Thread GitBox
kishoreg merged pull request #4346: Adding support for udfs in Selection URL: https://github.com/apache/incubator-pinot/pull/4346 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4346: Adding support for udfs in Selection

2019-06-25 Thread GitBox
kishoreg commented on a change in pull request #4346: Adding support for udfs in Selection URL: https://github.com/apache/incubator-pinot/pull/4346#discussion_r297336600 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -81,15

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297349982 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai commented on a change in pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354#discussion_r297349972 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on issue #4346: Adding support for udfs in Selection

2019-06-25 Thread GitBox
kishoreg commented on issue #4346: Adding support for udfs in Selection URL: https://github.com/apache/incubator-pinot/pull/4346#issuecomment-505570038 > Please also update the documentation. thanks Will do this in another PR along with the filter udf

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4364: [TE] update detection health

2019-06-25 Thread GitBox
jihaozh opened a new pull request #4364: [TE] update detection health URL: https://github.com/apache/incubator-pinot/pull/4364 Update the detection health to include task counts for different task status. Including, COMPLETED, TIMEOUT, FAILED, WAITING tasks.

[GitHub] [incubator-pinot] kishoreg opened a new pull request #4365: Adding support for udf/expression in filter predicates

2019-06-25 Thread GitBox
kishoreg opened a new pull request #4365: Adding support for udf/expression in filter predicates URL: https://github.com/apache/incubator-pinot/pull/4365 Support for expressions/udf in the filter predicates. select count(*) from baseballStats where numberOfGames = 100

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4361: Fix NPE when there is no aggregation results in prettyPrintResponse

2019-06-25 Thread GitBox
jackjlli commented on a change in pull request #4361: Fix NPE when there is no aggregation results in prettyPrintResponse URL: https://github.com/apache/incubator-pinot/pull/4361#discussion_r297414122 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4361: Fix NPE when there is no aggregation results in prettyPrintResponse

2019-06-25 Thread GitBox
jackjlli commented on a change in pull request #4361: Fix NPE when there is no aggregation results in prettyPrintResponse URL: https://github.com/apache/incubator-pinot/pull/4361#discussion_r297414196 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

2019-06-25 Thread GitBox
Jackie-Jiang commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API URL: https://github.com/apache/incubator-pinot/pull/4362#discussion_r297416628 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API

2019-06-25 Thread GitBox
Jackie-Jiang commented on a change in pull request #4362: Optimize MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API URL: https://github.com/apache/incubator-pinot/pull/4362#discussion_r297418269 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4361: Fix to wait until all docs loaded in quick start

2019-06-25 Thread GitBox
codecov-io commented on issue #4361: Fix to wait until all docs loaded in quick start URL: https://github.com/apache/incubator-pinot/pull/4361#issuecomment-505650114 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4361?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations (#4354)

2019-06-25 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new ab6dd9f [TE] Trigger expression

[GitHub] [incubator-pinot] akshayrai merged pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations

2019-06-25 Thread GitBox
akshayrai merged pull request #4354: [TE] Trigger expression based grouping of anomalies - AND, OR and combinations URL: https://github.com/apache/incubator-pinot/pull/4354 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4366: [TE] frontend - harleyjj/alert-overview - dont use anomalies from bou…

2019-06-25 Thread GitBox
harleyjj opened a new pull request #4366: [TE] frontend - harleyjj/alert-overview - dont use anomalies from bou… URL: https://github.com/apache/incubator-pinot/pull/4366 …nds endpoint in Alert Overview This is an automated

[GitHub] [incubator-pinot] npawar opened a new pull request #4367: CompletionConfig for realtime tables

2019-06-25 Thread GitBox
npawar opened a new pull request #4367: CompletionConfig for realtime tables URL: https://github.com/apache/incubator-pinot/pull/4367 Based on discussion in https://github.com/apache/incubator-pinot/issues/4345 This is an

[incubator-pinot] branch deletePush updated (1c750a6 -> ad3a112)

2019-06-25 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch deletePush in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1c750a6 Changing constant discard c6d9c4f Addressing comments discard 64a732d Adding util

[GitHub] [incubator-pinot] jihaozh merged pull request #4364: [TE] update detection health

2019-06-25 Thread GitBox
jihaozh merged pull request #4364: [TE] update detection health URL: https://github.com/apache/incubator-pinot/pull/4364 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-pinot] branch master updated: [TE] update detection health (#4364)

2019-06-25 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 4ce688e [TE] update detection health

[GitHub] [incubator-pinot] codecov-io commented on issue #4365: Adding support for udf/expression in filter predicates

2019-06-25 Thread GitBox
codecov-io commented on issue #4365: Adding support for udf/expression in filter predicates URL: https://github.com/apache/incubator-pinot/pull/4365#issuecomment-505682637 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4365?src=pr=h1) Report > Merging

[incubator-pinot] 01/01: initial

2019-06-25 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch increase-wait-time in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 09e87203dae8b154b7b3f4f3064d197e4bd105d1 Author: Seunghyun Lee AuthorDate: Tue Jun 25 17:00:21 2019

[incubator-pinot] branch increase-wait-time created (now 09e8720)

2019-06-25 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch increase-wait-time in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 09e8720 initial This branch includes the following new commits: new 09e8720 initial