[incubator-pinot] branch realtimetest updated: Refactoring

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a commit to branch realtimetest in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/realtimetest by this push: new 104825e Refactoring

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-06 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321870818 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java ##

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4568: Replace Hashmap to Object2IntOpenHashMap in OnHeapStringDictionary

2019-09-06 Thread GitBox
codecov-io edited a comment on issue #4568: Replace Hashmap to Object2IntOpenHashMap in OnHeapStringDictionary URL: https://github.com/apache/incubator-pinot/pull/4568#issuecomment-526762827 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4568?src=pr=h1) Report >

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-06 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321870731 ## File path: pinot-core/src/test/resources/data/test_presence_vector_data.json ## @@ -0,0 +1,12 @@ +{ Review comment:

[GitHub] [incubator-pinot] chenboat commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

2019-09-06 Thread GitBox
chenboat commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-528948926 > @chenboat It may or may not change the EV. If, as a result of the gc activity, zookeeper

[incubator-pinot] branch paths updated (273658f -> fa31be6)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch paths in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 273658f Disallowing multiple inputs in preprocess add fa31be6 Disallowing multiple inputs in

[incubator-pinot] branch realtimetest updated (104825e -> 968b1eb)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch realtimetest in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 104825e Refactoring add 968b1eb Refactoring This update added new revisions after

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4591: Deleting preprocess output post segment creation

2019-09-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #4591: Deleting preprocess output post segment creation URL: https://github.com/apache/incubator-pinot/pull/4591#discussion_r321852321 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4545: Add APIs to get leader for all tables or a given table

2019-09-06 Thread GitBox
codecov-io edited a comment on issue #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545#issuecomment-523237858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4545?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jackjlli commented on issue #4568: Replace Hashmap to Object2IntOpenHashMap in OnHeapStringDictionary

2019-09-06 Thread GitBox
jackjlli commented on issue #4568: Replace Hashmap to Object2IntOpenHashMap in OnHeapStringDictionary URL: https://github.com/apache/incubator-pinot/pull/4568#issuecomment-529028012 I've updated the test and here are the results comparing `Object2IntOpenHashMap` with `HashMap`.

[incubator-pinot] 01/01: Disallowing multiple inputs in preprocess

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a commit to branch paths in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 9a3988198ab9de3fc1bf01f215a6f321a0475fb6 Author: Jennifer Dai AuthorDate: Fri Sep 6 10:42:03 2019 -0700

[incubator-pinot] branch paths created (now 9a39881)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch paths in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9a39881 Disallowing multiple inputs in preprocess This branch includes the following new commits:

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4593: Do not update download URL and crypter when segment is not refreshed

2019-09-06 Thread GitBox
Jackie-Jiang opened a new pull request #4593: Do not update download URL and crypter when segment is not refreshed URL: https://github.com/apache/incubator-pinot/pull/4593 When segment is not refreshed (same crc so no need to refresh), segment file won't be persisted, so should not

[incubator-pinot] branch fix_download_uri created (now 7dea9a1)

2019-09-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch fix_download_uri in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 7dea9a1 Do not update download URL and crypter when segment is not refreshed No new revisions

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-06 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321862314 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/NullValueTransformer.java ## @@ -33,17

[GitHub] [incubator-pinot] codecov-io commented on issue #4590: Disallowing multiple inputs in preprocess

2019-09-06 Thread GitBox
codecov-io commented on issue #4590: Disallowing multiple inputs in preprocess URL: https://github.com/apache/incubator-pinot/pull/4590#issuecomment-528972966 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4590?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-06 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321864108 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ## @@ -479,6

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-06 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321863828 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ## @@ -479,6

[GitHub] [incubator-pinot] codecov-io commented on issue #4591: Deleting preprocess output post segment creation

2019-09-06 Thread GitBox
codecov-io commented on issue #4591: Deleting preprocess output post segment creation URL: https://github.com/apache/incubator-pinot/pull/4591#issuecomment-528971712 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4591?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar opened a new issue #4589: Benchmarking for Order By implementations

2019-09-06 Thread GitBox
npawar opened a new issue #4589: Benchmarking for Order By implementations URL: https://github.com/apache/incubator-pinot/issues/4589 We have introduced a new Table data structure. The structure has methods upsert (inserts and aggregates the Record), merge(Table), iterator. We are

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4590: Disallowing multiple inputs in preprocess

2019-09-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #4590: Disallowing multiple inputs in preprocess URL: https://github.com/apache/incubator-pinot/pull/4590#discussion_r321851374 ## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java

[GitHub] [incubator-pinot] jenniferdai opened a new pull request #4592: Refactor Realtime Segment Data Manager to remove repeat logic

2019-09-06 Thread GitBox
jenniferdai opened a new pull request #4592: Refactor Realtime Segment Data Manager to remove repeat logic URL: https://github.com/apache/incubator-pinot/pull/4592 * Allows for tests specifically targeting the controller portion of split commit

[incubator-pinot] branch deletepreprocessoutput created (now 24d551c)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch deletepreprocessoutput in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 24d551c Deleting preprocess output post segment creation This branch includes the

[incubator-pinot] 01/01: Deleting preprocess output post segment creation

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a commit to branch deletepreprocessoutput in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 24d551c890322ecef1aaa75454ffe903c7a519f4 Author: Jennifer Dai AuthorDate: Fri Sep 6

[GitHub] [incubator-pinot] fx19880617 commented on issue #4035: Need a tool to display realtime status of a table on a server

2019-09-06 Thread GitBox
fx19880617 commented on issue #4035: Need a tool to display realtime status of a table on a server URL: https://github.com/apache/incubator-pinot/issues/4035#issuecomment-528950923 @kishoreg ^^ We may also wanna fetch upstream status, e.g. Kafka topic information(#partitions,

[GitHub] [incubator-pinot] jenniferdai opened a new pull request #4591: Deleting preprocess output post segment creation

2019-09-06 Thread GitBox
jenniferdai opened a new pull request #4591: Deleting preprocess output post segment creation URL: https://github.com/apache/incubator-pinot/pull/4591 * If the preprocessed output dir is defined, we will delete it after segment creation succeeds.

[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

2019-09-06 Thread GitBox
icefury71 commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321862314 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/NullValueTransformer.java ## @@ -33,17

[GitHub] [incubator-pinot] jenniferdai opened a new pull request #4590: Disallowing multiple inputs in preprocess

2019-09-06 Thread GitBox
jenniferdai opened a new pull request #4590: Disallowing multiple inputs in preprocess URL: https://github.com/apache/incubator-pinot/pull/4590 * We cannot support this in preprocess because mapreduce takes complete control of the output path(s). In order to support this, we would need

[incubator-pinot] branch paths updated (9a39881 -> 273658f)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch paths in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 9a39881 Disallowing multiple inputs in preprocess add 273658f Disallowing multiple inputs in

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4594: [TE] fix create alert error message null pointer exception

2019-09-06 Thread GitBox
jihaozh opened a new pull request #4594: [TE] fix create alert error message null pointer exception URL: https://github.com/apache/incubator-pinot/pull/4594 This PR fixes the create alert error message null pointer exception.

[GitHub] [incubator-pinot] codecov-io commented on issue #4595: Implement all transform function APIs for MapValueTransformFunction

2019-09-06 Thread GitBox
codecov-io commented on issue #4595: Implement all transform function APIs for MapValueTransformFunction URL: https://github.com/apache/incubator-pinot/pull/4595#issuecomment-529062008 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4595?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4595: Implement all transform function APIs for MapValueTransformFunction

2019-09-06 Thread GitBox
kishoreg commented on a change in pull request #4595: Implement all transform function APIs for MapValueTransformFunction URL: https://github.com/apache/incubator-pinot/pull/4595#discussion_r321950598 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4595: Implement all transform function APIs for MapValueTransformFunction

2019-09-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #4595: Implement all transform function APIs for MapValueTransformFunction URL: https://github.com/apache/incubator-pinot/pull/4595#discussion_r321951994 ## File path:

[incubator-pinot] branch map_transform updated (7068e7d -> 416e8d4)

2019-09-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch map_transform in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7068e7d Implement all transform function APIs for MapValueTransformFunction add 416e8d4

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4595: Implement all transform function APIs for MapValueTransformFunction

2019-09-06 Thread GitBox
codecov-io edited a comment on issue #4595: Implement all transform function APIs for MapValueTransformFunction URL: https://github.com/apache/incubator-pinot/pull/4595#issuecomment-529062008 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4595?src=pr=h1) Report >

[GitHub] [incubator-pinot] snleee opened a new issue #4596: Add documentation on schema

2019-09-06 Thread GitBox
snleee opened a new issue #4596: Add documentation on schema URL: https://github.com/apache/incubator-pinot/issues/4596 We currently don't have a good documentation on schema. We should add one at https://pinot.readthedocs.io/en/latest 1. What are dimensions, metrics and time column

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4583: Support default value for Byte column

2019-09-06 Thread GitBox
jackjlli commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r321939628 ## File path: pinot-core/src/test/resources/data/newColumnsSchema3.json ## @@ -16,6 +16,11 @@ {

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4583: Support default value for Byte column

2019-09-06 Thread GitBox
jackjlli commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r321940046 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4583: Support default value for Byte column

2019-09-06 Thread GitBox
jackjlli commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r321940046 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4585: Presence vector

2019-09-06 Thread GitBox
codecov-io edited a comment on issue #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-528121925 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4585?src=pr=h1) Report > Merging

[incubator-pinot] branch k8s-quickstart updated (53c2383 -> ef03017)

2019-09-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch k8s-quickstart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 53c2383 Adding license add ef03017 address comments No new revisions were added by this

[incubator-pinot] branch map_transform created (now 7068e7d)

2019-09-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch map_transform in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 7068e7d Implement all transform function APIs for MapValueTransformFunction This branch includes

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4595: Implement all transform function APIs for MapValueTransformFunction

2019-09-06 Thread GitBox
Jackie-Jiang opened a new pull request #4595: Implement all transform function APIs for MapValueTransformFunction URL: https://github.com/apache/incubator-pinot/pull/4595 - Change function name to "mapValue" to follow the convention - Add documentation for MapValue transform function

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4545: Add APIs to get leader for all tables or a given table

2019-09-06 Thread GitBox
jackjlli commented on a change in pull request #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545#discussion_r321821985 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4545: Add APIs to get leader for all tables or a given table

2019-09-06 Thread GitBox
jackjlli commented on a change in pull request #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545#discussion_r321821948 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on issue #4545: Add APIs to get leader for all tables or a given table

2019-09-06 Thread GitBox
jackjlli commented on issue #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545#issuecomment-528929151 @mcvsubbu design doc updated. This is an automated

[incubator-pinot] branch master updated (76e0c62 -> 68092ab)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 76e0c62 Adding Predicate supports for Bytes Column without dictionary (#4586) add 68092ab

[incubator-pinot] branch cleanup deleted (was 084edf3)

2019-09-06 Thread jenniferdai
This is an automated email from the ASF dual-hosted git repository. jenniferdai pushed a change to branch cleanup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 084edf3 Fixing error The revisions that were on this branch are still contained in other

[GitHub] [incubator-pinot] jenniferdai merged pull request #4577: Adding integration test for Hadoop pre-process job

2019-09-06 Thread GitBox
jenniferdai merged pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

2019-09-06 Thread GitBox
mcvsubbu commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-528934199 @chenboat It may or may not change the EV. If, as a result of the gc activity, zookeeper