[GitHub] [incubator-pinot] kishoreg commented on issue #4380: Define SLO config for tables

2019-07-09 Thread GitBox
kishoreg commented on issue #4380: Define SLO config for tables URL: https://github.com/apache/incubator-pinot/pull/4380#issuecomment-509916190 I missed the previous comment. SLOConfig is probably not the right name if we are not going to guarantee these latency numbers. I feel

[incubator-pinot] branch helix_debug created (now 5b9cfaf)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch helix_debug in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 5b9cfaf Improve controller tests This branch includes the following new commits: new 5b9cfaf

[incubator-pinot] 01/01: Improve controller tests

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch helix_debug in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 5b9cfaff5aabe4195220191902b5f4cfb5d58e87 Author: Jackie (Xiaotian) Jiang AuthorDate: Tue Jul 9 22:32:04

[incubator-pinot] branch old_helix_test deleted (was 6e6bc67)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch old_helix_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 6e6bc67 Test helix 0.8.2 The revisions that were on this branch are still contained in other

[GitHub] [incubator-pinot] Jackie-Jiang closed pull request #4411: Test helix 0.8.2

2019-07-09 Thread GitBox
Jackie-Jiang closed pull request #4411: Test helix 0.8.2 URL: https://github.com/apache/incubator-pinot/pull/4411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4380: Define SLO config for tables

2019-07-09 Thread GitBox
sunithabeeram commented on issue #4380: Define SLO config for tables URL: https://github.com/apache/incubator-pinot/pull/4380#issuecomment-509900678 @kishoreg - do you have further thoughts/comments on this? This is an

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4415: Move tests for API resources to a different package

2019-07-09 Thread GitBox
Jackie-Jiang merged pull request #4415: Move tests for API resources to a different package URL: https://github.com/apache/incubator-pinot/pull/4415 This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch move_resources_test deleted (was 2f67b67)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch move_resources_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 2f67b67 Move tests for API resources to a different package The revisions that were on this

[incubator-pinot] branch master updated: Move tests for API resources to a different package (#4415)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 07e2c72 Move tests for API resources

[GitHub] [incubator-pinot] codecov-io commented on issue #4415: Move tests for API resources to a different package

2019-07-09 Thread GitBox
codecov-io commented on issue #4415: Move tests for API resources to a different package URL: https://github.com/apache/incubator-pinot/pull/4415#issuecomment-509893439 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4415?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301853485 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301853446 ## File path: pinot-common/pom.xml ## @@ -96,6 +96,10 @@

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4412: Fix codecov link from old url to new

2019-07-09 Thread GitBox
Jackie-Jiang merged pull request #4412: Fix codecov link from old url to new URL: https://github.com/apache/incubator-pinot/pull/4412 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated: Fix codecov link from old url to new (#4412)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 0b8af63 Fix codecov link from old url

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4415: Move tests for API resources to a different package

2019-07-09 Thread GitBox
Jackie-Jiang opened a new pull request #4415: Move tests for API resources to a different package URL: https://github.com/apache/incubator-pinot/pull/4415 To prevent the API application to load the test files which can cause class not found exception

[incubator-pinot] branch move_resources_test created (now 2f67b67)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch move_resources_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 2f67b67 Move tests for API resources to a different package No new revisions were added by

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-09 Thread GitBox
siddharthteotia commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-509859008 @jackjlli . @mayankshriv , @mcvsubbu Got a clean build. Please review the changes

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4413: [TE] frontend - harleyjj/detection-health - UI for model performance

2019-07-09 Thread GitBox
jihaozh commented on a change in pull request #4413: [TE] frontend - harleyjj/detection-health - UI for model performance URL: https://github.com/apache/incubator-pinot/pull/4413#discussion_r301842394 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-509297732 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr=h1) Report

[GitHub] [incubator-pinot] codecov-io commented on issue #4412: Fix codecov link from old url to new

2019-07-09 Thread GitBox
codecov-io commented on issue #4412: Fix codecov link from old url to new URL: https://github.com/apache/incubator-pinot/pull/4412#issuecomment-509849619 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4412?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] [incubator-pinot] akshayrai merged pull request #4414: [TE] Do not authorize when auth is disabled

2019-07-09 Thread GitBox
akshayrai merged pull request #4414: [TE] Do not authorize when auth is disabled URL: https://github.com/apache/incubator-pinot/pull/4414 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-pinot] branch master updated: [TE] Do not authorize when auth is disabled (#4414)

2019-07-09 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e71ac1b [TE] Do not authorize

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (be991f7 -> 480f49d)

2019-07-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit be991f7 Address PR comments add 480f49d Address PR comments This

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4414: [TE] Do not authorize when auth is disabled

2019-07-09 Thread GitBox
akshayrai opened a new pull request #4414: [TE] Do not authorize when auth is disabled URL: https://github.com/apache/incubator-pinot/pull/4414 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (09a5cff -> be991f7)

2019-07-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 09a5cff Address PR comments add be991f7 Address PR comments This

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr=h1) Report >

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr=h1) Report >

[GitHub] [incubator-pinot] harleyjj commented on issue #4413: [TE] frontend - harleyjj/detection-health - UI for model performance

2019-07-09 Thread GitBox
harleyjj commented on issue #4413: [TE] frontend - harleyjj/detection-health - UI for model performance URL: https://github.com/apache/incubator-pinot/pull/4413#issuecomment-509815325 https://user-images.githubusercontent.com/10106733/60924143-4da3a180-a255-11e9-90a7-97e6c83d01b7.png;>

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4413: [TE] frontend - harleyjj/detection-health - UI for model performance

2019-07-09 Thread GitBox
harleyjj opened a new pull request #4413: [TE] frontend - harleyjj/detection-health - UI for model performance URL: https://github.com/apache/incubator-pinot/pull/4413 1) Implements new detection health component for alert overview and preview with alert id 2) Corrects some comment and

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (79394b7 -> 09a5cff)

2019-07-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 79394b7 Address PR comments add 09a5cff Address PR comments This

[GitHub] [incubator-pinot] akshayrai merged pull request #4410: [TE] Add Merger after metric grouper; other minor clean up

2019-07-09 Thread GitBox
akshayrai merged pull request #4410: [TE] Add Merger after metric grouper; other minor clean up URL: https://github.com/apache/incubator-pinot/pull/4410 This is an automated message from the Apache Git Service. To respond

[incubator-pinot] branch master updated: [TE] Add Merger after metric grouper; other minor clean up (#4410)

2019-07-09 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 7df1a43 [TE] Add Merger after

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (e5df01f -> 79394b7)

2019-07-09 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit e5df01f Address PR comments add 79394b7 Address PR comments This

[GitHub] [incubator-pinot] jackjlli edited a comment on issue #3957: Controller Separation

2019-07-09 Thread GitBox
jackjlli edited a comment on issue #3957: Controller Separation URL: https://github.com/apache/incubator-pinot/issues/3957#issuecomment-509733878 This is the PR for adding logic for lead controller resource: https://github.com/apache/incubator-pinot/pull/4323 Test Plans: 1. Testing

[GitHub] [incubator-pinot] autumnust opened a new pull request #4412: Fix codecov link from old url to new

2019-07-09 Thread GitBox
autumnust opened a new pull request #4412: Fix codecov link from old url to new URL: https://github.com/apache/incubator-pinot/pull/4412 Change `https://codecov.io/github/linkedin/pinot` to `https://codecov.io/github/apache/incubator-pinot` as I happened to notice the issue when I try to

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #4396: make kafka version number controlled by config number

2019-07-09 Thread GitBox
jamesyfshao commented on a change in pull request #4396: make kafka version number controlled by config number URL: https://github.com/apache/incubator-pinot/pull/4396#discussion_r301774869 ## File path: pinot-integration-tests/pom.xml ## @@ -192,7 +192,7 @@

[incubator-pinot] 01/01: Test helix 0.8.2

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch old_helix_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 6e6bc67c2f93a52bb18c43d1902fbc46475a09a1 Author: Jackie (Xiaotian) Jiang AuthorDate: Tue Jul 9

[incubator-pinot] branch old_helix_test created (now 6e6bc67)

2019-07-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch old_helix_test in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 6e6bc67 Test helix 0.8.2 This branch includes the following new commits: new 6e6bc67 Test

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4396: make kafka version number controlled by config number

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4396: make kafka version number controlled by config number URL: https://github.com/apache/incubator-pinot/pull/4396#issuecomment-507952318 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4396?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4410: [TE] Add Merger after metric grouper; other minor clean up

2019-07-09 Thread GitBox
jihaozh commented on a change in pull request #4410: [TE] Add Merger after metric grouper; other minor clean up URL: https://github.com/apache/incubator-pinot/pull/4410#discussion_r301747639 ## File path:

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4410: [TE] Add Merger after metric grouper; other minor clean up

2019-07-09 Thread GitBox
akshayrai opened a new pull request #4410: [TE] Add Merger after metric grouper; other minor clean up URL: https://github.com/apache/incubator-pinot/pull/4410 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301727582 ## File path: pinot-common/pom.xml ## @@ -96,6 +96,10 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301730355 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301730026 ## File path:

[incubator-pinot] branch master updated: [TE] Make email template and subject pluggable under email alert scheme (#4409)

2019-07-09 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new de62d8e [TE] Make email template

[GitHub] [incubator-pinot] akshayrai merged pull request #4409: [TE] Make email template and subject pluggable under email alert scheme

2019-07-09 Thread GitBox
akshayrai merged pull request #4409: [TE] Make email template and subject pluggable under email alert scheme URL: https://github.com/apache/incubator-pinot/pull/4409 This is an automated message from the Apache Git Service.

[GitHub] [incubator-pinot] jackjlli edited a comment on issue #3957: Controller Separation

2019-07-09 Thread GitBox
jackjlli edited a comment on issue #3957: Controller Separation URL: https://github.com/apache/incubator-pinot/issues/3957#issuecomment-509733878 This is the PR for adding logic for lead controller resource: https://github.com/apache/incubator-pinot/pull/4323 Test Plans: 1. Testing

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301727582 ## File path: pinot-common/pom.xml ## @@ -96,6 +96,10 @@

[GitHub] [incubator-pinot] jackjlli edited a comment on issue #3957: Controller Separation

2019-07-09 Thread GitBox
jackjlli edited a comment on issue #3957: Controller Separation URL: https://github.com/apache/incubator-pinot/issues/3957#issuecomment-509733878 This is the PR for adding logic for lead controller resource: https://github.com/apache/incubator-pinot/pull/4323 Test Plans: 1. Testing

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301727069 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on issue #3957: Controller Separation

2019-07-09 Thread GitBox
jackjlli commented on issue #3957: Controller Separation URL: https://github.com/apache/incubator-pinot/issues/3957#issuecomment-509733878 This is the PR for adding logic for lead controller resource: https://github.com/apache/incubator-pinot/pull/4323 Test Plans: 1. Testing dual

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4409: [TE] Make email template and subject pluggable under email alert scheme

2019-07-09 Thread GitBox
akshayrai opened a new pull request #4409: [TE] Make email template and subject pluggable under email alert scheme URL: https://github.com/apache/incubator-pinot/pull/4409 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] tysaito commented on a change in pull request #4404: Added support for Vertica as data source

2019-07-09 Thread GitBox
tysaito commented on a change in pull request #4404: Added support for Vertica as data source URL: https://github.com/apache/incubator-pinot/pull/4404#discussion_r301700158 ## File path:

[GitHub] [incubator-pinot] vasilije90 opened a new issue #4408: Thirdeye anomaly page breaks after manually registering anomaly

2019-07-09 Thread GitBox
vasilije90 opened a new issue #4408: Thirdeye anomaly page breaks after manually registering anomaly URL: https://github.com/apache/incubator-pinot/issues/4408 Hi, After manually registering anomaly, the Thirdeye anomaly page breaks with GET

[GitHub] [incubator-pinot] vasilije90 opened a new issue #4407: Alert screen breaks in Thirdeye

2019-07-09 Thread GitBox
vasilije90 opened a new issue #4407: Alert screen breaks in Thirdeye URL: https://github.com/apache/incubator-pinot/issues/4407 When using jdbc connection and making sure that registered alert is present and inspecting anomalies, the tool breaks. Due to my understanding, this is due to

[GitHub] [incubator-pinot] vasilije90 opened a new issue #4406: No documentation on setting up email alerts in Thirdeye

2019-07-09 Thread GitBox
vasilije90 opened a new issue #4406: No documentation on setting up email alerts in Thirdeye URL: https://github.com/apache/incubator-pinot/issues/4406 Hi, I am having difficulties testing Thirdeye alerting and receiving emails on my test alerts. There is not much documentation

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#issuecomment-507069745 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4387?src=pr=h1) Report >

[GitHub] [incubator-pinot] codecov-io commented on issue #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
codecov-io commented on issue #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#issuecomment-509544466 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4399?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4397: Adding Support for Kafka 2.0 Consumer

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#issuecomment-508060135 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4397?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301449931 ## File path: pinot-common/pom.xml ## @@ -96,6 +96,10 @@

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301444541 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301442327 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301440806 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301440740 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301440036 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301440133 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301439512 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo…

2019-07-09 Thread GitBox
kishoreg commented on a change in pull request #4399: Moving handling of NULL values from RecordReaders to NullValueTransfo… URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301439217 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301438542 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

2019-07-09 Thread GitBox
fx19880617 commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301431577 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-09 Thread GitBox
codecov-io edited a comment on issue #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-509297732 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4368?src=pr=h1) Report