[incubator-pinot] branch kafka_2.0 updated (72d7f59 -> 91e00ad)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch kafka_2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 72d7f59 address comments discard ee87138 fixing the bytes type conversion and adding consumer test d

[GitHub] [incubator-pinot] codecov-io commented on issue #4440: Fix the potential resource leak from NettyServer

codecov-io commented on issue #4440: Fix the potential resource leak from NettyServer URL: https://github.com/apache/incubator-pinot/pull/4440#issuecomment-512074370 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4440?src=pr&el=h1) Report > :exclamation: No coverage uplo

[GitHub] [incubator-pinot] codecov-io commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

codecov-io commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#issuecomment-512069722 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4438?src=pr&el=h1) Report >

[incubator-pinot] branch netty_release created (now a0198a1)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch netty_release in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at a0198a1 Fix the potential resource leak from NettyServer No new revisions were added by this update

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4440: Fix the potential resource leak from NettyServer

Jackie-Jiang opened a new pull request #4440: Fix the potential resource leak from NettyServer URL: https://github.com/apache/incubator-pinot/pull/4440 - Release the ByteBuf immediately after reading the bytes - Change RequestHandler.processRequest() to directly take byte[] instead of t

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304182545 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/LeadControlle

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

jackjlli commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304181910 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelp

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304175468 ## File path: pinot-transport/src/test/java/org/apache/pinot/tran

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304143275 ## File path: pinot-transport/src/test/java/org/apache/pinot/tran

[incubator-pinot] branch server_instance updated (f52affb -> 32f718a)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit f52affb Clean up the ServerInstance class and remove the un-necessary ip address stored add

[incubator-pinot] branch server_instance updated (40b3e46 -> f52affb)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 40b3e46 Clean up the ServerInstance class and remove the un-necessary ip address stored add

[GitHub] [incubator-pinot] JihaoZhang commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

JihaoZhang commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304172632 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrappe

[GitHub] [incubator-pinot] JihaoZhang commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

JihaoZhang commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304172632 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrappe

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304171672 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304171677 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/alert/content/Con

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304171698 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/tools/RunAdhocDat

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304171703 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/alert/content/Ent

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304171686 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/tools/RunAdhocDat

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#issuecomment-512041900 @mcvsubbu Actually the domain name expects the host name instead of the ip address, so I'll

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304163618 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/alert/content/Entit

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304162983 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/alert/content/Entit

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304161724 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/tools/RunAdhocDatab

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304161099 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/alert/content/Conte

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304162018 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/tools/RunAdhocDatab

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304160113 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/C

[incubator-pinot] branch kafka_2.0 updated (bc96302 -> 72d7f59)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch kafka_2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard bc96302 address comments add 72d7f59 address comments This update added new revisions after undo

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

akshayrai commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304159539 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/alert/content/Ent

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter

jihaozh commented on a change in pull request #4433: [TE] Adding Entity GroupKey Anomalies Email Reporter URL: https://github.com/apache/incubator-pinot/pull/4433#discussion_r304158512 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/alert/content/Entit

[GitHub] [incubator-pinot] fx19880617 edited a comment on issue #3998: Upgrade to use Kafka release 2.1.1

fx19880617 edited a comment on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-512029703 The above PR tries to add the implementation of Kafka 2.0. However something is still missing: 1. pinot-tools and pinot-in

[GitHub] [incubator-pinot] fx19880617 edited a comment on issue #3998: Upgrade to use Kafka release 2.1.1

fx19880617 edited a comment on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-512029703 The above PR tries to add the implementation of Kafka 2.0. However something is still missing: 1. pinot-tools and pinot-in

[GitHub] [incubator-pinot] fx19880617 commented on issue #3998: Upgrade to use Kafka release 2.1.1

fx19880617 commented on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-512029703 The above PR tries to add the implementation of Kafka 2.0. However something is still missing: 1. pinot-tools and pinot-integrati

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4392: Allow customized metrics prefix in pinot controller/broker/server

codecov-io edited a comment on issue #4392: Allow customized metrics prefix in pinot controller/broker/server URL: https://github.com/apache/incubator-pinot/pull/4392#issuecomment-507921757 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4392?src=pr&el=h1) Report > Mergin

[GitHub] [incubator-pinot] akshayrai merged pull request #4439: [TE] Renamed some classes to making it accurate and consistent

akshayrai merged pull request #4439: [TE] Renamed some classes to making it accurate and consistent URL: https://github.com/apache/incubator-pinot/pull/4439 This is an automated message from the Apache Git Service. To respon

[incubator-pinot] branch master updated: [TE] Renamed some classes to making it accurate and consistent (#4439)

This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 625482a [TE] Renamed some classes

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304154881 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/st

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304154347 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerSta

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304151443 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLea

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304152501 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLea

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304150968 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerSta

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304150564 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerCon

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304155412 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/LeadControlle

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304153103 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/LeadControlle

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304150845 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerLea

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304154089 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerSta

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on a change in pull request #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#discussion_r304137578 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelp

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4439: [TE] Renamed some classes to making it accurate and consistent

akshayrai opened a new pull request #4439: [TE] Renamed some classes to making it accurate and consistent URL: https://github.com/apache/incubator-pinot/pull/4439 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304143275 ## File path: pinot-transport/src/test/java/org/apache/pinot/tran

[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #4392: Allow customized metrics prefix in pinot controller/broker/server

jamesyfshao commented on a change in pull request #4392: Allow customized metrics prefix in pinot controller/broker/server URL: https://github.com/apache/incubator-pinot/pull/4392#discussion_r304139143 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonCon

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4323: [Controller Separation] Add logic for lead controller resource

mcvsubbu commented on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-511998411 I would wait for at least one other review on the API. Perhaps the API can be a separate checkin. One tho

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

jackjlli commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304128116 ## File path: pinot-transport/src/test/java/org/apache/pinot/transpor

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4392: Allow customized metrics prefix in pinot controller/broker/server

mcvsubbu commented on issue #4392: Allow customized metrics prefix in pinot controller/broker/server URL: https://github.com/apache/incubator-pinot/pull/4392#issuecomment-511993091 Sorry, that was not an approve. Misclicked. Please wait unti merge, -

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4392: Allow customized metrics prefix in pinot controller/broker/server

mcvsubbu commented on a change in pull request #4392: Allow customized metrics prefix in pinot controller/broker/server URL: https://github.com/apache/incubator-pinot/pull/4392#discussion_r304125347 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConsta

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#issuecomment-511987118 @mcvsubbu We never fetch the ip address from the server instance. The reason why we have th

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304117366 ## File path: pinot-transport/src/test/java/org/apache/pinot/tran

[incubator-pinot] branch server_instance updated (844589f -> 40b3e46)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch server_instance in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 844589f Clean up the ServerInstance class and remove the un-necessary ip address stored add

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

mcvsubbu commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#issuecomment-511982460 Or, maybe it was in the context of caching the IP address while using connection pools. Are we

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

mcvsubbu commented on issue #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#issuecomment-511979292 I think the IP addresses are there for a reason. Perhaps azure/kubernetes clusters? I remember

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4294: Fixing some issues docs/getting_started.rst

jackjlli commented on a change in pull request #4294: Fixing some issues docs/getting_started.rst URL: https://github.com/apache/incubator-pinot/pull/4294#discussion_r304111025 ## File path: docs/getting_started.rst ## @@ -41,7 +41,8 @@ Pinot requires JDK 8 or later and Ap

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

Jackie-Jiang commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304110981 ## File path: pinot-common/src/main/java/org/apache/pinot/common/

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

jackjlli commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304106872 ## File path: pinot-transport/src/test/java/org/apache/pinot/transpor

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored

jackjlli commented on a change in pull request #4438: Clean up the ServerInstance class and remove the un-necessary ip address stored URL: https://github.com/apache/incubator-pinot/pull/4438#discussion_r304104905 ## File path: pinot-common/src/main/java/org/apache/pinot/common/resp

[incubator-pinot] branch master updated: 3891: Check for validity of segment start/end time during segment generation (#4368)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 7b1715c 3891: Check for validity of segm

[GitHub] [incubator-pinot] jackjlli merged pull request #4368: 3891: Check for validity of segment start/end time during segment generation

jackjlli merged pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368 This is an automated message from the Apache Git Servi

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (2858350 -> e06a908)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 2858350 Address PR comments add e06a908 Address PR comments This updat

[incubator-pinot] branch master updated: add download excel (#4403)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d2b2981 add download excel (#4403) d2b29

[GitHub] [incubator-pinot] jackjlli merged pull request #4403: Download query result as excel on query console

jackjlli merged pull request #4403: Download query result as excel on query console URL: https://github.com/apache/incubator-pinot/pull/4403 This is an automated message from the Apache Git Service. To respond to the message

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (f7132cd -> 2858350)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard f7132cd Address PR comments discard 43c7e73 Add logic for lead controller r

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4434: Remove the massive console print and log from CalciteSqlCompilerTest

mayankshriv commented on a change in pull request #4434: Remove the massive console print and log from CalciteSqlCompilerTest URL: https://github.com/apache/incubator-pinot/pull/4434#discussion_r30402 ## File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/Calcite

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation

siddharthteotia commented on issue #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-511880217 It looks like the build (for integration tests) was stalled. The log seems to indicate it w