fx19880617 commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439214719
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -184,6 +192,18 @@ public B
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch pinot_query_literal_only
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard dbb957f Address comments
discard 7cdd8d6 Support Selection Literal only queries
a
jackjlli commented on a change in pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#discussion_r439202555
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##
@@ -29,21 +29,28 @@
import org.apache.pinot.com
codecov-commenter edited a comment on pull request #5547:
URL: https://github.com/apache/incubator-pinot/pull/5547#issuecomment-643058130
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5547?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(
fx19880617 commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439201178
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##
@@ -317,6 +317,43
codecov-commenter commented on pull request #5547:
URL: https://github.com/apache/incubator-pinot/pull/5547#issuecomment-643058130
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5547?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master
haibow opened a new pull request #5547:
URL: https://github.com/apache/incubator-pinot/pull/5547
## Description
Update year in NOTICE-binary
Ref: https://github.com/apache/spark/blob/master/NOTICE-binary
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Ass
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a change to branch update_license_binary
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at fe1d02f Update year in NOTICE-binary
This branch includes the following new commits:
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch update_license_binary
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit fe1d02f044864a29b2bb97fd22641eb0c4c80a08
Author: haibow
AuthorDate: Thu Jun 11 20:37:18 2020 -07
codecov-commenter edited a comment on pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#issuecomment-643034473
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(
codecov-commenter commented on pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544#issuecomment-643034473
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master
snleee commented on a change in pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#discussion_r439176537
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##
@@ -40,6 +40,7 @@
public static final String L
codecov-commenter commented on pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master
Jackie-Jiang opened a new pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546
## Description
Currently the case sensitivity handling only applies to the BrokerRequest,
but not to the PinotQuery inside the BrokerRequest.
This will cause inconsistent and unexpec
Jackie-Jiang commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439156588
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -184,6 +192,18 @@ public
akshayrai opened a new pull request #5545:
URL: https://github.com/apache/incubator-pinot/pull/5545
Subscription pipeline has an issue of skipping some anomaly notification
when one/more of the subscribed detections are disabled. This PR fixes this bug.
---
codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr&el=h1)
Report
> Merging
[#5483](https://codecov.io/gh/apache/incubator-pin
codecov-commenter edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr&el=h1)
Report
> Merging
[#5483](https://codecov.io/gh/apache/incubator-pin
Jackie-Jiang opened a new pull request #5544:
URL: https://github.com/apache/incubator-pinot/pull/5544
## Description
Inside query engine, scalar function is modeled as TransformFunction
(ScalarTransformFunctionWrapper)
Add SCALAR type into TransformFunctionType so that
FunctionDefin
kishoreg closed issue #5356:
URL: https://github.com/apache/incubator-pinot/issues/5356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kishoreg commented on issue #5356:
URL:
https://github.com/apache/incubator-pinot/issues/5356#issuecomment-642992726
Not an issue
This is an automated message from the Apache Git Service.
To respond to the message, please lo
kishoreg commented on issue #5475:
URL:
https://github.com/apache/incubator-pinot/issues/5475#issuecomment-642992198
@snleee is this valid?
This is an automated message from the Apache Git Service.
To respond to the message
Jackie-Jiang commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439136268
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##
@@ -317,6 +317,
Jackie-Jiang commented on a change in pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439135181
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -278,7 +278,9 @@ private static PinotQuery
Jackie-Jiang commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r439133541
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/FunctionInfo.java
##
@@ -0,0 +1,97 @@
+/**
+ * Licensed t
kishoreg commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r439082867
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/FunctionInfo.java
##
@@ -0,0 +1,97 @@
+/**
+ * Licensed to th
mcvsubbu commented on a change in pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#discussion_r439132149
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##
@@ -29,21 +29,28 @@
import org.apache.pinot.com
daniellavoie commented on pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#issuecomment-642984859
Thank you for the helix context @mcvsubbu! This is helpful. This PR is still
a wip, I need to fix some licensing issues and some unit tests regression. I
shared its
mcvsubbu commented on pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#issuecomment-642983139
Controller instance ID is used in the (older) way of running helix
controller as well as Pinot controller in the same host (Dual mode). Or, when
running helix controlle
kishoreg commented on pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#issuecomment-642968387
Thanks @daniellavoie
Can you paste sample configurations for the following scenarios
- Current code
- After this PR with new properties and old properties
daniellavoie opened a new pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543
## Description
Introduced new properties to define dynamic listeners to HttpServer. The
`controller.port` property is still available and intended to remain supported
until future
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 55b4ddc Change default segment load mode to MMAP. (#5539)
add f1f1c41 Changed the stream and metada
mcvsubbu merged pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mcvsubbu commented on a change in pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542#discussion_r439088617
##
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
##
@@ -77,7
mcvsubbu commented on a change in pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542#discussion_r439069170
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -893,20 +
mcvsubbu commented on a change in pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542#discussion_r439068418
##
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
##
@@ -77,7
kishoreg commented on a change in pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542#discussion_r439062405
##
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java
##
@@ -77,7
codecov-commenter commented on pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542#issuecomment-642905349
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5542?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master
mcvsubbu opened a new pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542
Changed the interface exposed by streams to return StreamPartitionMsgOffset
instead of long.
Also changed the LLCRealtimeSegmentZKMetadat class to return String instead
of long off
Jackie-Jiang commented on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642848504
> It seems like we are adding some duplicate code (like Predicate,
FilterInfo). We already have them.
>
> I agree that on server we can move to QueryRequest a
Jackie-Jiang commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438974956
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java
##
@@ -0,0 +1,199 @@
+/**
+ * Licensed
Jackie-Jiang commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438971580
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/FilterInfo.java
##
@@ -0,0 +1,116 @@
+/**
+ * Licensed to
Jackie-Jiang commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438971580
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/FilterInfo.java
##
@@ -0,0 +1,116 @@
+/**
+ * Licensed to
Jackie-Jiang commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438964215
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/Expression.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to
Jackie-Jiang commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438964215
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/Expression.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to
kishoreg commented on pull request #5539:
URL: https://github.com/apache/incubator-pinot/pull/5539#issuecomment-642810922
sorry missed this. why do we have another variable for read mode, I thought
we already had something in table config called load mode and it was MMAP by
default
-
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 55b4ddc Change default segment load m
mayankshriv merged pull request #5539:
URL: https://github.com/apache/incubator-pinot/pull/5539
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
siddharthteotia edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642662988
It seems like we are adding some duplicate code (like Predicate,
FilterInfo). We already have them.
I agree that on server we can move to QueryRequ
siddharthteotia edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642662988
It seems like we are adding some duplicate code (like Predicate,
FilterInfo). We already have them.
I agree that on server we can move to QueryRequ
haibow closed issue #5540:
URL: https://github.com/apache/incubator-pinot/issues/5540
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
siddharthteotia commented on pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642662988
It seems like we are adding a some duplicate code (like Predicate,
FilterInfo). We already have them.
I agree that on server we can move to QueryRequest a
siddharthteotia commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438794993
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/FilterInfo.java
##
@@ -0,0 +1,116 @@
+/**
+ * Licensed
siddharthteotia commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438794883
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/Expression.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed
snleee merged pull request #5541:
URL: https://github.com/apache/incubator-pinot/pull/5541
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3c42e5e Remove '/docker', '/kubernetes'
codecov-commenter edited a comment on pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1)
Report
> Merging
[#5513](https://codecov.io/gh/apache/incubator-pin
codecov-commenter edited a comment on pull request #5513:
URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1)
Report
> Merging
[#5513](https://codecov.io/gh/apache/incubator-pin
codecov-commenter commented on pull request #5541:
URL: https://github.com/apache/incubator-pinot/pull/5541#issuecomment-642531728
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5541?src=pr&el=h1)
Report
> Merging
[#5541](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-commenter edited a comment on pull request #5534:
URL: https://github.com/apache/incubator-pinot/pull/5534#issuecomment-642525270
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5534?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(
codecov-commenter commented on pull request #5534:
URL: https://github.com/apache/incubator-pinot/pull/5534#issuecomment-642525270
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5534?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch pinot_query_literal_only
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard c682c95 Address comments
discard 6cc878c Support Selection Literal only queries
a
snleee commented on issue #5540:
URL:
https://github.com/apache/incubator-pinot/issues/5540#issuecomment-642502255
Addressed in the #5541 please take a look
This is an automated message from the Apache Git Service.
To respon
snleee opened a new pull request #5541:
URL: https://github.com/apache/incubator-pinot/pull/5541
According to #5540, our source release included some binary files
and it has been flagged during the review process for the release.
We have decided to exclude some dirs from the source
64 matches
Mail list logo
