[GitHub] [pulsar] Jason918 commented on issue #10757: Pulsar websocket client still getting result ok when websocket ProducerHandler throw an error

2021-06-23 Thread GitBox
Jason918 commented on issue #10757: URL: https://github.com/apache/pulsar/issues/10757#issuecomment-867388494 @xqianwang Hi, can you add more detailed info about how to set up websocket client to reproduce this issue ? I am using cmd `bin/pulsar-client produce -n 1000 -r 1000` and set

[GitHub] [pulsar] 315157973 commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
315157973 commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657665348 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -171,10 +168,12 @@ public void testReacquireLeadership

[GitHub] [pulsar] lhotari commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
lhotari commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657664022 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -183,9 +182,10 @@ public void testReacquireLeadershipAft

[GitHub] [pulsar] robshep commented on issue #8429: Cannot parse schema

2021-06-23 Thread GitBox
robshep commented on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-867379082 Hi No, sadly I cannot recreate this issue in isolation. But It occurs on ~50% of redeploys and requires repeated restarts of the application to clear it. We use TestCo

[GitHub] [pulsar] lhotari commented on pull request #11026: [Security] Use adoptopenjdk:11-jdk base image for Pulsar docker images

2021-06-23 Thread GitBox
lhotari commented on pull request #11026: URL: https://github.com/apache/pulsar/pull/11026#issuecomment-867374901 Another choice for the adoptopenjdk base image would be to use the official ubuntu:20.04 base image and install the openjdk-11-jdk package in the container. This would also res

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657660423 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -171,10 +168,12 @@ public void testReacquireLeaders

[GitHub] [pulsar] mattisonchao commented on a change in pull request #10934: Fixed #fixed incorrect use toString method.

2021-06-23 Thread GitBox
mattisonchao commented on a change in pull request #10934: URL: https://github.com/apache/pulsar/pull/10934#discussion_r657658305 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java ## @@ -414,7 +414,7 @@ private int consumeFromWebSocke

[GitHub] [pulsar] 315157973 commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
315157973 commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657658026 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -171,10 +168,12 @@ public void testReacquireLeadership

[GitHub] [pulsar] lhotari commented on pull request #11026: [Security] Use adoptopenjdk:11-jdk base image for Pulsar docker images

2021-06-23 Thread GitBox
lhotari commented on pull request #11026: URL: https://github.com/apache/pulsar/pull/11026#issuecomment-867368769 > who maintains adoptopenjdk? The JDK, [AdoptOpenJDK itself has moved to Eclipse Foundation and has been renamed to Adoptium](https://blog.adoptopenjdk.net/2021/03/trans

[GitHub] [pulsar] Anonymitaet commented on pull request #11060: [docs] Capitalize sidebar headers

2021-06-23 Thread GitBox
Anonymitaet commented on pull request #11060: URL: https://github.com/apache/pulsar/pull/11060#issuecomment-867367620 @Jennifer88huang sure, we need to keep consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] eolivelli commented on a change in pull request #10934: Fixed #fixed incorrect use toString method.

2021-06-23 Thread GitBox
eolivelli commented on a change in pull request #10934: URL: https://github.com/apache/pulsar/pull/10934#discussion_r657655082 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdConsume.java ## @@ -414,7 +414,7 @@ private int consumeFromWebSocket(S

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657654741 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -171,10 +168,12 @@ public void testReacquireLeaders

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657654706 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -183,9 +182,10 @@ public void testReacquireLeadersh

[GitHub] [pulsar] mattisonchao opened a new issue #11066: Flaky-test: AdminApiTest.testDeleteTenantForcefully

2021-06-23 Thread GitBox
mattisonchao opened a new issue #11066: URL: https://github.com/apache/pulsar/issues/11066 AdminApiTest is flaky. The testDeleteTenantForcefully method fails sporadically. ```java Error: Tests run: 140, Failures: 1, Errors: 0, Skipped: 108, Time elapsed: 227.296 s <<< FAILURE! -

[GitHub] [pulsar] eolivelli commented on a change in pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
eolivelli commented on a change in pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#discussion_r657652356 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java ## @@ -183,9 +182,10 @@ public void testReacquireLeadershipA

[GitHub] [pulsar] mattisonchao commented on pull request #11046: [Broker] Fixed the incorrectly used string format method.

2021-06-23 Thread GitBox
mattisonchao commented on pull request #11046: URL: https://github.com/apache/pulsar/pull/11046#issuecomment-867344166 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] ericsyh commented on pull request #11065: fix: markdown indentation in getting-started-helm

2021-06-23 Thread GitBox
ericsyh commented on pull request #11065: URL: https://github.com/apache/pulsar/pull/11065#issuecomment-867343730 @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar] mattisonchao commented on pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao commented on pull request #11062: URL: https://github.com/apache/pulsar/pull/11062#issuecomment-867343429 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] ericsyh opened a new pull request #11065: fix: markdown indentation in getting-started-helm

2021-06-23 Thread GitBox
ericsyh opened a new pull request #11065: URL: https://github.com/apache/pulsar/pull/11065 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

2021-06-23 Thread GitBox
mattisonchao commented on a change in pull request #11059: URL: https://github.com/apache/pulsar/pull/11059#discussion_r657632207 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java ## @@ -615,21 +615,16 @@ public void testInvalidDynamicC

[GitHub] [pulsar-client-go] freeznet commented on pull request #551: #550 fix race condition when resend pendingItems

2021-06-23 Thread GitBox
freeznet commented on pull request #551: URL: https://github.com/apache/pulsar-client-go/pull/551#issuecomment-867320754 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[pulsar-helm-chart] branch master updated: Feature/fix typo in readme (#129)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new f00c66a Feature/fix typo in readme (#

[pulsar-helm-chart] branch master updated (11a1d57 -> 7516970)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git. from 11a1d57 Fix indentation issue on `checksum/config` (#117) add 7516970 add enableAdminApi for prometh

[pulsar-helm-chart] branch master updated: Fix indentation issue on `checksum/config` (#117)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 11a1d57 Fix indentation issue on `che

[GitHub] [pulsar-client-go] freeznet commented on pull request #551: #550 fix race condition when resend pendingItems

2021-06-23 Thread GitBox
freeznet commented on pull request #551: URL: https://github.com/apache/pulsar-client-go/pull/551#issuecomment-867317364 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] esadek opened a new issue #11064: Nav bar backgroud color

2021-06-23 Thread GitBox
esadek opened a new issue #11064: URL: https://github.com/apache/pulsar/issues/11064 **Describe the bug** For screens with a width below 1024px, the nav bar on the pulsar website has a dark green background. **To Reproduce** Steps to reproduce the behavior: 1. Go to https://

[pulsar-helm-chart] branch master updated: Updates internal issuer cert to include duration and renew configs (#131)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new d6d240a Updates internal issuer cert

[GitHub] [pulsar] 315157973 commented on a change in pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

2021-06-23 Thread GitBox
315157973 commented on a change in pull request #11059: URL: https://github.com/apache/pulsar/pull/11059#discussion_r657607116 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java ## @@ -615,21 +615,16 @@ public void testInvalidDynamicConf

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11063: [docs] Capitalize cli menu item

2021-06-23 Thread GitBox
Anonymitaet commented on a change in pull request #11063: URL: https://github.com/apache/pulsar/pull/11063#discussion_r657607032 ## File path: site2/website/static/js/custom.js ## @@ -110,7 +110,7 @@ window.addEventListener('load', function () { const cli = document.queryS

[GitHub] [pulsar] Anonymitaet commented on pull request #11060: [docs] Capitalize sidebar headers

2021-06-23 Thread GitBox
Anonymitaet commented on pull request #11060: URL: https://github.com/apache/pulsar/pull/11060#issuecomment-867315271 @esadek thanks for your contribution. Could you please help update [all affected versions](https://github.com/apache/pulsar/tree/master/site2/website/versioned_sidebars)?

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11051: Add authoritative flag for topic policy to avoid redirect loop

2021-06-23 Thread GitBox
codelipenghui commented on a change in pull request #11051: URL: https://github.com/apache/pulsar/pull/11051#discussion_r657606337 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -2686,13 +2652,8 @@ private Retentio

[GitHub] [pulsar-client-go] freeznet opened a new pull request #551: #550 fix race condition when resend pendingItems

2021-06-23 Thread GitBox
freeznet opened a new pull request #551: URL: https://github.com/apache/pulsar-client-go/pull/551 Fixes #550 ### Modifications When resending `pendingItems`, reset the `pendingItem`'s `sentAt` and put the `pendingItem` to the back of `pendingItems` queue. ### Verifying

[GitHub] [pulsar] codelipenghui commented on a change in pull request #11051: Add authoritative flag for topic policy to avoid redirect loop

2021-06-23 Thread GitBox
codelipenghui commented on a change in pull request #11051: URL: https://github.com/apache/pulsar/pull/11051#discussion_r657605357 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java ## @@ -390,7 +390,6 @@ public

[GitHub] [pulsar-client-go] freeznet opened a new issue #550: data race when reconnecting to broker and resending `pendingItems`

2021-06-23 Thread GitBox
freeznet opened a new issue #550: URL: https://github.com/apache/pulsar-client-go/issues/550 Race condition happened when reconnecting to broker and resending `pendingItems`. If `pendingItem` just timeout and complete by `failTimeoutMessages`, the `pendingItem`'s buffer will be put back in

[GitHub] [pulsar] esadek opened a new pull request #11063: [docs] Capitalize cli menu item

2021-06-23 Thread GitBox
esadek opened a new pull request #11063: URL: https://github.com/apache/pulsar/pull/11063 ### Motivation Improve documentation by fixing improperly capitalized acronym. ### Modifications Change menu item from "Cli" to "CLI". -- This is an automated message from the Ap

[pulsar] branch master updated (f72f83b -> 624bb8b)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f72f83b Update the instructions for building individual modules in README (#11030) add 624bb8b Use testng inst

[pulsar] branch master updated: Update the instructions for building individual modules in README (#11030)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f72f83b Update the instructions for building ind

[GitHub] [pulsar] mattisonchao opened a new pull request #11062: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao opened a new pull request #11062: URL: https://github.com/apache/pulsar/pull/11062 Fixes #11032 Master Issue: #11032 Motivation In some cases, testing errors occurred due to Zookeeper's notification delay. Modifications Waiting async notice until timeo

[GitHub] [pulsar] sijie merged pull request #11027: Use testng instead of junit

2021-06-23 Thread GitBox
sijie merged pull request #11027: URL: https://github.com/apache/pulsar/pull/11027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] sijie merged pull request #11030: Update the instructions for building individual modules in README

2021-06-23 Thread GitBox
sijie merged pull request #11030: URL: https://github.com/apache/pulsar/pull/11030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] mattisonchao closed pull request #11061: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao closed pull request #11061: URL: https://github.com/apache/pulsar/pull/11061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] mattisonchao opened a new pull request #11061: [ Issue 11032 ] Fixed flaky test ZKSessionTest.. #11032

2021-06-23 Thread GitBox
mattisonchao opened a new pull request #11061: URL: https://github.com/apache/pulsar/pull/11061 Fixes #11032 Master Issue: #11032 ### Motivation In some cases, testing errors occurred due to Zookeeper's notification delay. ### Modifications - Waiting asyn

[GitHub] [pulsar] esadek opened a new pull request #11060: [docs] Capitalize sidebar headers

2021-06-23 Thread GitBox
esadek opened a new pull request #11060: URL: https://github.com/apache/pulsar/pull/11060 ### Motivation Improve documentation consistency. ### Modifications Change capitalization of sidebar headers to title case. -- This is an automated message from the Apache Git Se

[GitHub] [pulsar] mattisonchao commented on issue #11032: Flaky-test: ZKSessionTest.testReacquireLeadershipAfterSessionLost

2021-06-23 Thread GitBox
mattisonchao commented on issue #11032: URL: https://github.com/apache/pulsar/issues/11032#issuecomment-867304248 I want to fix it. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar] 315157973 commented on a change in pull request #11051: Add authoritative flag for topic policy to avoid redirect loop

2021-06-23 Thread GitBox
315157973 commented on a change in pull request #11051: URL: https://github.com/apache/pulsar/pull/11051#discussion_r657594717 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java ## @@ -390,7 +390,6 @@ public voi

[GitHub] [pulsar] 315157973 commented on a change in pull request #11051: Add authoritative flag for topic policy to avoid redirect loop

2021-06-23 Thread GitBox
315157973 commented on a change in pull request #11051: URL: https://github.com/apache/pulsar/pull/11051#discussion_r657584505 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -2686,13 +2652,8 @@ private RetentionPol

[GitHub] [pulsar] mattisonchao commented on pull request #10934: Fixed #fixed incorrect use toString method.

2021-06-23 Thread GitBox
mattisonchao commented on pull request #10934: URL: https://github.com/apache/pulsar/pull/10934#issuecomment-867295635 @sijie If you have time, can you help me review the code? : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] mattisonchao opened a new pull request #11059: [ Issue 11049 ] Fixed flaky test AdminApiTest

2021-06-23 Thread GitBox
mattisonchao opened a new pull request #11059: URL: https://github.com/apache/pulsar/pull/11059 Fixes #11049 Master Issue: #11049 ### Motivation At certain moments, due to zookeeper delayed notification, the number of retry waiting times exceeded. ### Modific

[pulsar] branch master updated: [Python] Fixed import when AvroSchema is not being used (#11034)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b4fa411 [Python] Fixed import when AvroSchema is

[GitHub] [pulsar] sijie merged pull request #11034: [Python] Fixed import when AvroSchema is not being used

2021-06-23 Thread GitBox
sijie merged pull request #11034: URL: https://github.com/apache/pulsar/pull/11034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] sijie closed issue #10929: Python pulsar-client 2.8.0 raise ModuleNotFoundError No module named 'fastavro'

2021-06-23 Thread GitBox
sijie closed issue #10929: URL: https://github.com/apache/pulsar/issues/10929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [pulsar] massakam commented on a change in pull request #10762: [broker] Fix issue that message ordering could be broken when redelivering messages on Key_Shared subscription

2021-06-23 Thread GitBox
massakam commented on a change in pull request #10762: URL: https://github.com/apache/pulsar/pull/10762#discussion_r657585484 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java ## @@ -142,6

[GitHub] [pulsar] mattisonchao opened a new pull request #11058: [ Issue 11050 ] Fixed flaky test ServerCnxTest.

2021-06-23 Thread GitBox
mattisonchao opened a new pull request #11058: URL: https://github.com/apache/pulsar/pull/11058 Fixes #11050 Master Issue: #11050 ### Motivation Since there is a delay in creating an object in the middle of concurrent requests, it may cause the first request to have

[GitHub] [pulsar] mattisonchao commented on issue #11050: Flaky-test: ServerCnxTest.testDuplicateConcurrentSubscribeCommand

2021-06-23 Thread GitBox
mattisonchao commented on issue #11050: URL: https://github.com/apache/pulsar/issues/11050#issuecomment-867278325 I want to fix this flaky test. : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] tomyouyou opened a new pull request #11057: 'createLedgerAfterClosed' do nothing when state is at 'State.Creating…

2021-06-23 Thread GitBox
tomyouyou opened a new pull request #11057: URL: https://github.com/apache/pulsar/pull/11057 …Ledger' For the previous 'ledgerClosed' might have started to create a new ledger. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pulsar] dhinesherode91 edited a comment on issue #8429: Cannot parse schema

2021-06-23 Thread GitBox
dhinesherode91 edited a comment on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-867272525 Hey, I am facing a similar issue. I am running pulsar 2.7.1 and I have a topic with AVRO schema where my producers push avro messages and consumer receives and

[GitHub] [pulsar] dhinesherode91 edited a comment on issue #8429: Cannot parse schema

2021-06-23 Thread GitBox
dhinesherode91 edited a comment on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-867272525 Hey, I am facing a similar issue. I am running pulsar 2.7.1 and I have a topic with AVRO schema where my producers push avro messages and consumer receives and

[GitHub] [pulsar] dhinesherode91 edited a comment on issue #8429: Cannot parse schema

2021-06-23 Thread GitBox
dhinesherode91 edited a comment on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-867272525 Hey, I am facing a similar issue. I am running pulsar 2.7.1 and I have a topic with AVRO schema where my producers push avro messages and consumer receives and

[GitHub] [pulsar] dhinesherode91 edited a comment on issue #8429: Cannot parse schema

2021-06-23 Thread GitBox
dhinesherode91 edited a comment on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-867272525 Hey, I am facing a similar issue. I am running pulsar 2.7.1 and I have a topic with AVRO schema where my producers push avro messages and consumer receives and

[GitHub] [pulsar] dhinesherode91 commented on issue #8429: Cannot parse schema

2021-06-23 Thread GitBox
dhinesherode91 commented on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-867272525 Hey, I am facing a similar issue. I am running pulsar 2.7.1 and I have a topic with AVRO schema where my producers push avro messages and consumer receives and process

[GitHub] [pulsar] tuteng commented on pull request #11042: Made the PulsarClusterMetadataTeardown deletes idempotent

2021-06-23 Thread GitBox
tuteng commented on pull request #11042: URL: https://github.com/apache/pulsar/pull/11042#issuecomment-867271933 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] yangl commented on pull request #10597: Fix pulsar-client & pulsar-client-admin shaded jar missing code source

2021-06-23 Thread GitBox
yangl commented on pull request #10597: URL: https://github.com/apache/pulsar/pull/10597#issuecomment-867262753 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] rdhabalia commented on issue #10021: Websocket Encryption

2021-06-23 Thread GitBox
rdhabalia commented on issue #10021: URL: https://github.com/apache/pulsar/issues/10021#issuecomment-867206490 websocket just pass through message payload with key to client without modifying anything. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] merlimat commented on pull request #11012: PIP-45: Migrate OwnershipCache to use MetadataStore

2021-06-23 Thread GitBox
merlimat commented on pull request #11012: URL: https://github.com/apache/pulsar/pull/11012#issuecomment-867198628 > @merlimat thanks for your contribution. For this PR, do we need to update docs? No docs updates, this is just an internal refactoring. -- This is an automated messa

[GitHub] [pulsar] nlu90 opened a new pull request #11056: [pulsar-io] pass pulsar client via context to connector

2021-06-23 Thread GitBox
nlu90 opened a new pull request #11056: URL: https://github.com/apache/pulsar/pull/11056 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] mattisonchao commented on pull request #11019: [Tests] Add test for TimeAverageBrokerData

2021-06-23 Thread GitBox
mattisonchao commented on pull request #11019: URL: https://github.com/apache/pulsar/pull/11019#issuecomment-867190978 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] mattisonchao commented on pull request #11046: [Broker] Fixed the incorrectly used string format method.

2021-06-23 Thread GitBox
mattisonchao commented on pull request #11046: URL: https://github.com/apache/pulsar/pull/11046#issuecomment-867187212 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] mattisonchao commented on pull request #11047: [Broker] Fixed the incorrectly used logger.

2021-06-23 Thread GitBox
mattisonchao commented on pull request #11047: URL: https://github.com/apache/pulsar/pull/11047#issuecomment-867186277 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] mattisonchao commented on pull request #11047: [Broker] Fixed the incorrectly used logger.

2021-06-23 Thread GitBox
mattisonchao commented on pull request #11047: URL: https://github.com/apache/pulsar/pull/11047#issuecomment-867185880 @lhotari I will do that, thanks to you ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] brummetj opened a new issue #11055: linker error for curl when using pulsar lib

2021-06-23 Thread GitBox
brummetj opened a new issue #11055: URL: https://github.com/apache/pulsar/issues/11055 **Describe the bug** Can anyone help me here? I built the pulsar-client-cpp from source, but when i try to compile my project with the libpulsar.a files, i get linker errors all over. I was ab

[GitHub] [pulsar] lhotari commented on issue #10870: Flaky-test: BatchSourceExecutorTest.testLifeCycle

2021-06-23 Thread GitBox
lhotari commented on issue #10870: URL: https://github.com/apache/pulsar/issues/10870#issuecomment-867170976 [another failure](https://github.com/apache/pulsar/pull/11026/checks?check_run_id=2898206737#step:9:5139) ``` Error: Tests run: 30, Failures: 1, Errors: 0, Skipped: 28, Time e

[GitHub] [pulsar] lhotari edited a comment on issue #11032: Flaky-test: ZKSessionTest.testReacquireLeadershipAfterSessionLost

2021-06-23 Thread GitBox
lhotari edited a comment on issue #11032: URL: https://github.com/apache/pulsar/issues/11032#issuecomment-867169921 [another failure in testReacquireLocksAfterSessionLost method](https://github.com/apache/pulsar/pull/11026/checks?check_run_id=2898206737#step:9:6817) ``` Error: Te

[GitHub] [pulsar] lhotari commented on issue #11032: Flaky-test: ZKSessionTest.testReacquireLeadershipAfterSessionLost

2021-06-23 Thread GitBox
lhotari commented on issue #11032: URL: https://github.com/apache/pulsar/issues/11032#issuecomment-867169921 [yet another](https://github.com/apache/pulsar/pull/11026/checks?check_run_id=2898206737#step:9:6817) -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] lhotari opened a new issue #11054: Flaky-test: KeyValueSchemaTest.testKeyValueSchemaSeparatedEncoding

2021-06-23 Thread GitBox
lhotari opened a new issue #11054: URL: https://github.com/apache/pulsar/issues/11054 KeyValueSchemaTest is flaky. The testKeyValueSchemaSeparatedEncodingtest method fails sporadically. [example failure](https://github.com/apache/pulsar/pull/11026/checks?check_run_id=2898206737#

[GitHub] [pulsar] shaunek commented on issue #5672: [C++ client] Deadletter queue functionality

2021-06-23 Thread GitBox
shaunek commented on issue #5672: URL: https://github.com/apache/pulsar/issues/5672#issuecomment-867146923 This functionality would be much appreciated. I'm mainly interested because adding functionality to the C++ client would enable the functionality in the nodejs client as well. -- T

[pulsar] branch master updated: [Tests] Fix flaky test ResourceGroupConfigListenerTest (#11048)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b3545cc [Tests] Fix flaky test ResourceGroupConf

[GitHub] [pulsar] sijie merged pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

2021-06-23 Thread GitBox
sijie merged pull request #11048: URL: https://github.com/apache/pulsar/pull/11048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] sijie closed issue #11045: Flaky-test: ResourceGroupConfigListenerTest.testResourceGroupAttachToNamespace

2021-06-23 Thread GitBox
sijie closed issue #11045: URL: https://github.com/apache/pulsar/issues/11045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[pulsar] branch master updated: [Functions] reorganize the context hierarchy for functions (#10631)

2021-06-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 999329a [Functions] reorganize the context hiera

[GitHub] [pulsar] sijie merged pull request #10631: [Functions] reorganize the context hierarchy for functions

2021-06-23 Thread GitBox
sijie merged pull request #10631: URL: https://github.com/apache/pulsar/pull/10631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] xuamao opened a new issue #11053: start apache-pulsar-2.7.2 get Exception

2021-06-23 Thread GitBox
xuamao opened a new issue #11053: URL: https://github.com/apache/pulsar/issues/11053 **Describe the bug** run "bin/pulsar standalone" in terminal getting the following Exception. 21:25:19.829 [main] INFO org.apache.zookeeper.server.NIOServerCnxnFactory - binding to port 0.0.0.0/0

[GitHub] [pulsar] gaoran10 opened a new pull request #11052: [Broker] Fix async response filter

2021-06-23 Thread GitBox
gaoran10 opened a new pull request #11052: URL: https://github.com/apache/pulsar/pull/11052 ### Motivation Currently, the response filter couldn't process async responses correctlly, the response interceptor may be called before the async response returning. ### Modifications

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

2021-06-23 Thread GitBox
bharanic-dev commented on pull request #11048: URL: https://github.com/apache/pulsar/pull/11048#issuecomment-867020012 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

2021-06-23 Thread GitBox
bharanic-dev commented on pull request #11048: URL: https://github.com/apache/pulsar/pull/11048#issuecomment-867019873 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] codelipenghui opened a new pull request #11051: Add authoritative flag for topic policy to avoid redirect loop

2021-06-23 Thread GitBox
codelipenghui opened a new pull request #11051: URL: https://github.com/apache/pulsar/pull/11051 ### Motivation 1. Add authoritative flag for topic policy to avoid redirect loop 2. Prevent set topic policy on a non-existing topic 3. Prevent set topic policy on a partition of a p

[GitHub] [pulsar] eolivelli commented on pull request #11026: [Security] Use adoptopenjdk:11-jdk base image for Pulsar docker images

2021-06-23 Thread GitBox
eolivelli commented on pull request #11026: URL: https://github.com/apache/pulsar/pull/11026#issuecomment-866954690 @michaeljmarshall @sijie @rdhabalia @jerrypeng @codelipenghui PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] congbobo184 commented on a change in pull request #11023: [Transaction] Fix delete sub then delete pending ack.

2021-06-23 Thread GitBox
congbobo184 commented on a change in pull request #11023: URL: https://github.com/apache/pulsar/pull/11023#discussion_r657232811 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -955,7 +956,31 @@ private void rese

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

2021-06-23 Thread GitBox
bharanic-dev commented on pull request #11048: URL: https://github.com/apache/pulsar/pull/11048#issuecomment-866940999 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] bharanic-dev commented on pull request #11048: [Tests] Fix flaky test ResourceGroupConfigListenerTest

2021-06-23 Thread GitBox
bharanic-dev commented on pull request #11048: URL: https://github.com/apache/pulsar/pull/11048#issuecomment-866938095 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pulsar] bharanic-dev commented on pull request #10657: [PIP-82] [pulsar-broker] Add resource-group configuration listener.

2021-06-23 Thread GitBox
bharanic-dev commented on pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#issuecomment-866937127 @lhotari apologies, I did not see test failures in my local runs. Thank you for making the tests more robust. -- This is an automated message from the Apache Git Service

[GitHub] [pulsar] coute commented on a change in pull request #7887: [Issue 5869][deploy] Bump AWS terraform deployment to Terraform 0.13 and AWS provider 3.3.0

2021-06-23 Thread GitBox
coute commented on a change in pull request #7887: URL: https://github.com/apache/pulsar/pull/7887#discussion_r657183371 ## File path: deployment/terraform-ansible/aws/variables.tf ## @@ -62,7 +62,7 @@ variable "num_proxy_nodes" { } variable "instance_types" { - type = "ma

[pulsar] branch master updated (cad0542 -> 1a80429)

2021-06-23 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cad0542 fix testng assertEquals parameter order (#11035) add 1a80429 fix flaky test in AdminApiOffloadTest

[GitHub] [pulsar] eolivelli merged pull request #11028: fix flaky test in AdminApiOffloadTest

2021-06-23 Thread GitBox
eolivelli merged pull request #11028: URL: https://github.com/apache/pulsar/pull/11028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[pulsar] branch master updated (e092fb3 -> cad0542)

2021-06-23 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e092fb3 [Transaction] Fix broker init transaction related topic. (#11022) add cad0542 fix testng assertEqu

[GitHub] [pulsar] eolivelli merged pull request #11035: fix testng assertEquals parameter order

2021-06-23 Thread GitBox
eolivelli merged pull request #11035: URL: https://github.com/apache/pulsar/pull/11035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[pulsar] branch master updated (ef4a275 -> e092fb3)

2021-06-23 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from ef4a275 fix flaky AdminApiTest (#11039) add e092fb3 [Transaction] Fix broker init transaction related topic

[GitHub] [pulsar] eolivelli merged pull request #11022: [Transaction] Fix broker init transaction related topic.

2021-06-23 Thread GitBox
eolivelli merged pull request #11022: URL: https://github.com/apache/pulsar/pull/11022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[pulsar] branch master updated (dac74fd -> ef4a275)

2021-06-23 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from dac74fd Issue #11037: Fix flaky test PrimitiveSchemaTest (#11038) add ef4a275 fix flaky AdminApiTest (#1103

[GitHub] [pulsar] eolivelli merged pull request #11039: fix flaky AdminApiTest

2021-06-23 Thread GitBox
eolivelli merged pull request #11039: URL: https://github.com/apache/pulsar/pull/11039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] coute commented on a change in pull request #7887: [Issue 5869][deploy] Bump AWS terraform deployment to Terraform 0.13 and AWS provider 3.3.0

2021-06-23 Thread GitBox
coute commented on a change in pull request #7887: URL: https://github.com/apache/pulsar/pull/7887#discussion_r657185740 ## File path: deployment/terraform-ansible/aws/versions.tf ## @@ -0,0 +1,12 @@ +terraform { + required_providers { +aws = { + source = "hashicorp/a

  1   2   >