[GitHub] [pulsar] codelipenghui commented on issue #11652: deadLetterPolicy is not working with key shared subscription

2021-08-16 Thread GitBox
codelipenghui commented on issue #11652: URL: https://github.com/apache/pulsar/issues/11652#issuecomment-92766 @srouthu1 Have you tried a new Pulsar Client version? I noticed the client version is 2.6.0 which released almost 2 years ago. -- This is an automated message from the

[pulsar] branch master updated (1d1f633 -> 43ded59)

2021-08-16 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1d1f633 [docs] [ISSUE 11380] Update code example and description (#11653) add 43ded59 Fix race condition in

[GitHub] [pulsar] sijie closed issue #11605: Race condition in concurrent schema deletion

2021-08-16 Thread GitBox
sijie closed issue #11605: URL: https://github.com/apache/pulsar/issues/11605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie merged pull request #11606: Fix race condition in concurrent schema deletion

2021-08-16 Thread GitBox
sijie merged pull request #11606: URL: https://github.com/apache/pulsar/pull/11606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (de86f4f -> 1d1f633)

2021-08-16 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from de86f4f [pulsar-admin] allow create functions with package URL (#11666) add 1d1f633 [docs] [ISSUE 11380]

[GitHub] [pulsar] sijie merged pull request #11653: [docs] [ISSUE 11380] Update code example and description

2021-08-16 Thread GitBox
sijie merged pull request #11653: URL: https://github.com/apache/pulsar/pull/11653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie closed issue #11380: CLI in TTL config is not clear

2021-08-16 Thread GitBox
sijie closed issue #11380: URL: https://github.com/apache/pulsar/issues/11380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (fbfbd0e -> de86f4f)

2021-08-16 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fbfbd0e Fix typos in concepts-transactions.md (#11676) add de86f4f [pulsar-admin] allow create functions with

[GitHub] [pulsar] sijie closed issue #11665: `pulsar-admin functions` cannot use package URL to create function

2021-08-16 Thread GitBox
sijie closed issue #11665: URL: https://github.com/apache/pulsar/issues/11665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] sijie merged pull request #11666: [pulsar-admin] allow create functions with package URL

2021-08-16 Thread GitBox
sijie merged pull request #11666: URL: https://github.com/apache/pulsar/pull/11666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] murong00 commented on pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-16 Thread GitBox
murong00 commented on pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#issuecomment-899941008 Almost completed. I will resolve the conflicting files later and please help to take a review if you are available, thanks. -- This is an automated message from the Apache

[GitHub] [pulsar] equanz edited a comment on pull request #10534: [PIP 79][common,broker,client] Change PartitionedTopicStats to support partial partitioned producer

2021-08-16 Thread GitBox
equanz edited a comment on pull request #10534: URL: https://github.com/apache/pulsar/pull/10534#issuecomment-899931286 @Vanlightly > Moreover, it looks to me like the current strategy is already broken seeing as the numbers won't always match (neither numbers nor order) such as when

[GitHub] [pulsar] equanz commented on pull request #10534: [PIP 79][common,broker,client] Change PartitionedTopicStats to support partial partitioned producer

2021-08-16 Thread GitBox
equanz commented on pull request #10534: URL: https://github.com/apache/pulsar/pull/10534#issuecomment-899931286 @Vanlightly > Moreover, it looks to me like the current strategy is already broken seeing as the numbers won't always match (neither numbers nor order) such as when

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689972100 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689972100 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689967367 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -1903,9 +1905,28 @@ public

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689967293 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java ## @@ -145,14 +149,17 @@ private void

[GitHub] [pulsar-client-go] xige-16 commented on issue #593: consume stuck after seekByTiime

2021-08-16 Thread GitBox
xige-16 commented on issue #593: URL: https://github.com/apache/pulsar-client-go/issues/593#issuecomment-899925496 > Which client version are you using? v0.5.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689964478 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java ## @@ -145,14 +149,17 @@ private void

[GitHub] [pulsar] Technoboy- commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
Technoboy- commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689963705 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-08-16 Thread GitBox
Anonymitaet edited a comment on pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#issuecomment-899907330 Doc is done here: https://github.com/apache/pulsar/pull/11602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] Anonymitaet commented on pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-08-16 Thread GitBox
Anonymitaet commented on pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#issuecomment-899907330 Doc: https://github.com/apache/pulsar/pull/11602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Anonymitaet commented on pull request #11238: [Issue 11007] add a version of AUTO_PRODUCE_BYTES that doesn't validate the message in `encode`

2021-08-16 Thread GitBox
Anonymitaet commented on pull request #11238: URL: https://github.com/apache/pulsar/pull/11238#issuecomment-899906463 > > @Zhen-hao thanks for your great work. Would you like to add docs accordingly? Then you can ping me to review, thanks > > That's the plan. I was overwhelmed by

[pulsar] branch master updated (b8dce10 -> fbfbd0e)

2021-08-16 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b8dce10 Replace bookkeper with bookkeeper in bin/bookkeeper (#11675) add fbfbd0e Fix typos in

[GitHub] [pulsar] Anonymitaet merged pull request #11676: Fix typos in concepts-transactions.md

2021-08-16 Thread GitBox
Anonymitaet merged pull request #11676: URL: https://github.com/apache/pulsar/pull/11676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on pull request #11666: [pulsar-admin] allow create functions with package URL

2021-08-16 Thread GitBox
Anonymitaet commented on pull request #11666: URL: https://github.com/apache/pulsar/pull/11666#issuecomment-899903588 > @Anonymitaet thanks, we can start the doc once this PR is merged. @freeznet please ping me if you submit a doc PR, thanks -- This is an automated message from

[GitHub] [pulsar-client-go] cckellogg commented on issue #593: consume stuck after seekByTiime

2021-08-16 Thread GitBox
cckellogg commented on issue #593: URL: https://github.com/apache/pulsar-client-go/issues/593#issuecomment-899895682 Which client version are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] oversearch commented on pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-16 Thread GitBox
oversearch commented on pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#issuecomment-899865518 Still working on this... built it in clang and found some more warnings that popped up which are actually potentially serious bugs (dangling references). Trying to

[GitHub] [pulsar] bharanic-dev commented on pull request #11679: [Issue 11678 ] [pulsar-functions] When the action has no 'continueOn', continue to invoke subsequent actions

2021-08-16 Thread GitBox
bharanic-dev commented on pull request #11679: URL: https://github.com/apache/pulsar/pull/11679#issuecomment-899863904 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] bharanic-dev commented on pull request #11679: [Issue 11678 ] [pulsar-functions] When the action has no 'continueOn', continue to invoke subsequent actions

2021-08-16 Thread GitBox
bharanic-dev commented on pull request #11679: URL: https://github.com/apache/pulsar/pull/11679#issuecomment-899820437 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] michaeljmarshall commented on pull request #11468: [Function worker] Load ServiceConfiguration from file, not from Worke…

2021-08-16 Thread GitBox
michaeljmarshall commented on pull request #11468: URL: https://github.com/apache/pulsar/pull/11468#issuecomment-899816400 @jerrypeng - thank you for taking a look. It seems to me that solution 2 is more consistent with the way the broker and proxy load their configurations. Let me know

[GitHub] [pulsar] eolivelli commented on issue #11548: Pulsar server non-tls ports are still listening when TLS in-transit encryption is enabled

2021-08-16 Thread GitBox
eolivelli commented on issue #11548: URL: https://github.com/apache/pulsar/issues/11548#issuecomment-899815526 So your problem is that you cannot disable non TLS ports? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] zbentley commented on issue #11324: Missing python wheel for Mac Os 11.4 for both 2.7.2 and 2.8.0

2021-08-16 Thread GitBox
zbentley commented on issue #11324: URL: https://github.com/apache/pulsar/issues/11324#issuecomment-899794441 This may be fixed by https://github.com/apache/pulsar/issues/11203; if convenient, could you re-test? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] hpvd commented on issue #11677: keep performance up: performance regression testing

2021-08-16 Thread GitBox
hpvd commented on issue #11677: URL: https://github.com/apache/pulsar/issues/11677#issuecomment-899735864 @eolivelli many thanks for pointing to this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] michaeljmarshall commented on pull request #11172: [broker] fix `GetTopicsOfNamespace` with binary lookup service not check auth

2021-08-16 Thread GitBox
michaeljmarshall commented on pull request #11172: URL: https://github.com/apache/pulsar/pull/11172#issuecomment-899734952 @hangc0276 - I believe this commit should be cherry picked to `branch-2.7` as well. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] bharanic-dev commented on pull request #11582: [Issue 11581][broker] feat:pass the executor to RateLimiter in ResourceGroupPublishLimiter

2021-08-16 Thread GitBox
bharanic-dev commented on pull request #11582: URL: https://github.com/apache/pulsar/pull/11582#issuecomment-899712869 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] eolivelli commented on issue #11677: keep performance up: performance regression testing

2021-08-16 Thread GitBox
eolivelli commented on issue #11677: URL: https://github.com/apache/pulsar/issues/11677#issuecomment-899712681 You may be interested in this work I am doing about Performance regression testing for Pulsar https://www.youtube.com/watch?v=NZnlLBT3BBY

[GitHub] [pulsar] bharanic-dev commented on pull request #11582: [Issue 11581][broker] feat:pass the executor to RateLimiter in ResourceGroupPublishLimiter

2021-08-16 Thread GitBox
bharanic-dev commented on pull request #11582: URL: https://github.com/apache/pulsar/pull/11582#issuecomment-899712433 @leizhiyuan Thank you for taking care of this. Passing the Executor was one of the tasks in my TODO list (which I why I left the comment in the code). Glad you were able

[GitHub] [pulsar] bharanic-dev commented on pull request #11679: [Issue 11678 ] [pulsar-functions] When the action has no 'continueOn', continue to invoke subsequent actions

2021-08-16 Thread GitBox
bharanic-dev commented on pull request #11679: URL: https://github.com/apache/pulsar/pull/11679#issuecomment-899696260 @jerrypeng PTAL when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] bharanic-dev opened a new pull request #11679: [Issue 11678 ] [pulsar-functions] When the action has no 'continueOn', continue to invoke subsequent actions

2021-08-16 Thread GitBox
bharanic-dev opened a new pull request #11679: URL: https://github.com/apache/pulsar/pull/11679 Fixes #11678 ### Motivation terminateFunction does not clean up batch source intermediate topics, resulting in topic leak. ### Modifications If an action does not

[GitHub] [pulsar] rdhabalia commented on a change in pull request #11671: [server] Allow broker to start with default backlogquota in bytes

2021-08-16 Thread GitBox
rdhabalia commented on a change in pull request #11671: URL: https://github.com/apache/pulsar/pull/11671#discussion_r689722778 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerTest.java ## @@ -1211,5 +1218,45 @@ public void

[GitHub] [pulsar] merlimat commented on a change in pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-16 Thread GitBox
merlimat commented on a change in pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#discussion_r689719433 ## File path: pulsar-client-cpp/lib/Commands.cc ## @@ -644,6 +644,7 @@ std::string Commands::messageType(BaseCommand_Type type) { return

[GitHub] [pulsar] bharanic-dev opened a new issue #11678: Pulsar functions terminateFunction doesn't clean up intermediate topics created for batchSource.

2021-08-16 Thread GitBox
bharanic-dev opened a new issue #11678: URL: https://github.com/apache/pulsar/issues/11678 **Describe the bug** The cleanupBatchSource() tries to delete the intermediate topic here:

[GitHub] [pulsar] oversearch commented on pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-16 Thread GitBox
oversearch commented on pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#issuecomment-899656153 Note that this PR is not quite ready yet (hence the "draft"). I just wanted to run it through the CI checks and not lose the message I typed up. I hadn't compiled in

[GitHub] [pulsar] oversearch commented on a change in pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-16 Thread GitBox
oversearch commented on a change in pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#discussion_r689693314 ## File path: pulsar-client-cpp/lib/Commands.cc ## @@ -644,6 +644,7 @@ std::string Commands::messageType(BaseCommand_Type type) { return

[GitHub] [pulsar] oversearch commented on a change in pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-16 Thread GitBox
oversearch commented on a change in pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#discussion_r689686002 ## File path: pulsar-client-cpp/CMakeLists.txt ## @@ -288,6 +288,10 @@ if (NOT APPLE AND NOT MSVC) set(CMAKE_CXX_FLAGS_PYTHON

[pulsar] branch branch-2.8 updated: If a topic has compaction policies configured, we must ensure the subscription is always pre-created (#11672)

2021-08-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 118ad6c If a topic has compaction

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
gaoran10 commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689612419 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] gaoran10 commented on a change in pull request #11564: Add compacted topic metrics for TopicStats in CLI

2021-08-16 Thread GitBox
gaoran10 commented on a change in pull request #11564: URL: https://github.com/apache/pulsar/pull/11564#discussion_r689607897 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactorMXBeanImpl.java ## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] hpvd opened a new issue #11677: keep performance up: performance regression testing

2021-08-16 Thread GitBox
hpvd opened a new issue #11677: URL: https://github.com/apache/pulsar/issues/11677 **Is your enhancement request related to a problem? Please describe.** When Pulsar grew, it always becomes a little more complex with more lines of code. Many of these steps could influence the

[GitHub] [pulsar] wuzhanpeng commented on pull request #11606: Fix race condition in concurrent schema deletion

2021-08-16 Thread GitBox
wuzhanpeng commented on pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#issuecomment-899438017 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] eolivelli commented on pull request #3823: [Issue 3822] [pulsar-io] Add a Pulsar IO connector for Alluxio sink

2021-08-16 Thread GitBox
eolivelli commented on pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#issuecomment-899412521 @murong00 what is the status of this work ? it looks like an interesting addition to Pulsar IO -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] eolivelli commented on pull request #7329: Added ability to delete and update records in ElasticSearch sink connector

2021-08-16 Thread GitBox
eolivelli commented on pull request #7329: URL: https://github.com/apache/pulsar/pull/7329#issuecomment-899412137 This patch is probably superseded by the recent changes in the ElasticSearch connector. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wuzhanpeng commented on pull request #11606: Fix race condition in concurrent schema deletion

2021-08-16 Thread GitBox
wuzhanpeng commented on pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#issuecomment-899404068 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Vanlightly commented on pull request #10534: [PIP 79][common,broker,client] Change PartitionedTopicStats to support partial partitioned producer

2021-08-16 Thread GitBox
Vanlightly commented on pull request #10534: URL: https://github.com/apache/pulsar/pull/10534#issuecomment-899386900 @equanz Let me know if I understand correctly. We publish aggregated stats, where we aggregate by partitioned producer, and optionally we also publish stats per partition

[GitHub] [pulsar] wuzhanpeng commented on a change in pull request #11640: [Enhancement] avoid duplicate deletion of schema

2021-08-16 Thread GitBox
wuzhanpeng commented on a change in pull request #11640: URL: https://github.com/apache/pulsar/pull/11640#discussion_r689395561 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java ## @@ -1472,6 +1474,60 @@ public void

[GitHub] [pulsar] eolivelli commented on a change in pull request #11640: [Enhancement] avoid duplicate deletion of schema

2021-08-16 Thread GitBox
eolivelli commented on a change in pull request #11640: URL: https://github.com/apache/pulsar/pull/11640#discussion_r689390887 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java ## @@ -1472,6 +1474,60 @@ public void

[GitHub] [pulsar] wuzhanpeng commented on pull request #11640: [Enhancement] avoid duplicate deletion of schema

2021-08-16 Thread GitBox
wuzhanpeng commented on pull request #11640: URL: https://github.com/apache/pulsar/pull/11640#issuecomment-899367078 @eolivelli @hangc0276 Sorry for the late. I supplemented a test case. PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] wuzhanpeng commented on pull request #11606: Fix race condition in concurrent schema deletion

2021-08-16 Thread GitBox
wuzhanpeng commented on pull request #11606: URL: https://github.com/apache/pulsar/pull/11606#issuecomment-899366052 > LGTM! could you please add some tests for it? Sorry for the late. I supplemented a test case. PTAL~ @congbobo184 -- This is an automated message from the Apache

[GitHub] [pulsar] eolivelli commented on pull request #11627: PIP-91: Separate lookup timeout from operation timeout

2021-08-16 Thread GitBox
eolivelli commented on pull request #11627: URL: https://github.com/apache/pulsar/pull/11627#issuecomment-899365068 IIUC @rdhabalia left some comments on the ML @rdhabalia do you mind to official write your position about this PR ? it also looks like that @jerrypeng initially

[GitHub] [pulsar] hangc0276 commented on pull request #11555: [Offload] Add offload performance metrics for tiered storage.

2021-08-16 Thread GitBox
hangc0276 commented on pull request #11555: URL: https://github.com/apache/pulsar/pull/11555#issuecomment-899358808 I doubt why not choose provide `OpStatsLogger` (pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/metrics/DataSketchesOpStatsLogger.java) to generate

[GitHub] [pulsar] hangc0276 commented on a change in pull request #11555: [Offload] Add offload performance metrics for tiered storage.

2021-08-16 Thread GitBox
hangc0276 commented on a change in pull request #11555: URL: https://github.com/apache/pulsar/pull/11555#discussion_r689339248 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java ## @@ -172,6 +172,9 @@ @Configuration

[GitHub] [pulsar] wuzhanpeng commented on pull request #11640: [Enhancement] avoid duplicate deletion of schema

2021-08-16 Thread GitBox
wuzhanpeng commented on pull request #11640: URL: https://github.com/apache/pulsar/pull/11640#issuecomment-899342199 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (9577b84 -> b8dce10)

2021-08-16 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9577b84 [Issue 11496][C++] Allow partitioned producers to start lazily (#11570) add b8dce10 Replace bookkeper

[GitHub] [pulsar] wolfstudy edited a comment on pull request #11675: Replace bookkeper with bookkeeper in bin/bookkeeper

2021-08-16 Thread GitBox
wolfstudy edited a comment on pull request #11675: URL: https://github.com/apache/pulsar/pull/11675#issuecomment-899332618 > What about cherry pick to 2.8.1? +1 @hangc0276 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] wolfstudy merged pull request #11675: Replace bookkeper with bookkeeper in bin/bookkeeper

2021-08-16 Thread GitBox
wolfstudy merged pull request #11675: URL: https://github.com/apache/pulsar/pull/11675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wolfstudy commented on pull request #11675: Replace bookkeper with bookkeeper in bin/bookkeeper

2021-08-16 Thread GitBox
wolfstudy commented on pull request #11675: URL: https://github.com/apache/pulsar/pull/11675#issuecomment-899332618 > What about cherry pick to 2.8.1? +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] sijia-w commented on issue #8671: [Doc] hardware recommodations (Cores, RAM, storage) for dev

2021-08-16 Thread GitBox
sijia-w commented on issue #8671: URL: https://github.com/apache/pulsar/issues/8671#issuecomment-899329010 @codelipenghui Any recommendations for the numbers? From Ran: "We usually give recommendations according to the user requirements in POC, then they run tests in this environment

[GitHub] [pulsar] wongxingjun commented on pull request #11540: Update concepts-transactions.md

2021-08-16 Thread GitBox
wongxingjun commented on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-899321683 > @wongxingjun all your PRs submit same doc changes for the same doc version, please update versioned docs here

[GitHub] [pulsar] wongxingjun opened a new pull request #11676: Fix typos in concepts-transactions.md

2021-08-16 Thread GitBox
wongxingjun opened a new pull request #11676: URL: https://github.com/apache/pulsar/pull/11676 fix typos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pulsar] wongxingjun closed pull request #11673: Update concepts-transactions.md

2021-08-16 Thread GitBox
wongxingjun closed pull request #11673: URL: https://github.com/apache/pulsar/pull/11673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wongxingjun closed pull request #11674: Update concepts-transactions.md

2021-08-16 Thread GitBox
wongxingjun closed pull request #11674: URL: https://github.com/apache/pulsar/pull/11674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] xige-16 opened a new issue #593: consume stuck after seekByTiime

2021-08-16 Thread GitBox
xige-16 opened a new issue #593: URL: https://github.com/apache/pulsar-client-go/issues/593 Expected behavior consume success after seekByTime Actual behavior After running the for loop a few times, step msg := <-consumer.Chan() will be blocked. Steps

[GitHub] [pulsar] sijia-w commented on pull request #11648: [Doc] [ISSUE 11291] Update Pulsar Dashboard relevant content

2021-08-16 Thread GitBox
sijia-w commented on pull request #11648: URL: https://github.com/apache/pulsar/pull/11648#issuecomment-899301145 @codelipenghui Any suggestions for a new link for `Pulsar-java-tutorial`? Many thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] lhotari closed issue #11637: [Broker] Failed to process metadata store notification

2021-08-16 Thread GitBox
lhotari closed issue #11637: URL: https://github.com/apache/pulsar/issues/11637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari commented on issue #11637: [Broker] Failed to process metadata store notification

2021-08-16 Thread GitBox
lhotari commented on issue #11637: URL: https://github.com/apache/pulsar/issues/11637#issuecomment-899296289 Closing since this is fixed by #11656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] sijia-w commented on pull request #11667: [docs] [ISSUE 11625] Update the intro of Messaging doc

2021-08-16 Thread GitBox
sijia-w commented on pull request #11667: URL: https://github.com/apache/pulsar/pull/11667#issuecomment-899294615 @Huanli-Meng Thanks for your comments. Updated. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Technoboy- commented on issue #11637: [Broker] Failed to process metadata store notification

2021-08-16 Thread GitBox
Technoboy- commented on issue #11637: URL: https://github.com/apache/pulsar/issues/11637#issuecomment-899287966 > This problem seems to be fixed by #11656 . @Technoboy- can you confirm? Yes, I think so. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wuzhanpeng commented on pull request #11640: [Enhancement] avoid duplicate deletion of schema

2021-08-16 Thread GitBox
wuzhanpeng commented on pull request #11640: URL: https://github.com/apache/pulsar/pull/11640#issuecomment-899284986 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] ca-simone-chiorazzo commented on issue #11203: 2.8.0 Python client library for Mac OS Big Sur won't load due to absolute linker paths left over from build environment

2021-08-16 Thread GitBox
ca-simone-chiorazzo commented on issue #11203: URL: https://github.com/apache/pulsar/issues/11203#issuecomment-899276799 The new 2.8.0.post0 release does not contain a wheel for many Linux, breaking dockerized application that uses the python pulsar client. Are you aware of this issue?

[GitHub] [pulsar] lhotari commented on pull request #10918: [Build] Fix java-test-functions dependencies and packaging

2021-08-16 Thread GitBox
lhotari commented on pull request #10918: URL: https://github.com/apache/pulsar/pull/10918#issuecomment-899269946 @eolivelli I rebased this PR. Let's see what the test results are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] eolivelli commented on pull request #10918: [Build] Fix java-test-functions dependencies and packaging

2021-08-16 Thread GitBox
eolivelli commented on pull request #10918: URL: https://github.com/apache/pulsar/pull/10918#issuecomment-899268506 @lhotari you want to try to rebase this patch to latest master ? we committed the changes to DefaultImplementation about loading Pulsar Client Impl (mostly) without

[GitHub] [pulsar] Anonymitaet commented on pull request #11540: Update concepts-transactions.md

2021-08-16 Thread GitBox
Anonymitaet commented on pull request #11540: URL: https://github.com/apache/pulsar/pull/11540#issuecomment-899267940 @wongxingjun all your PRs submit same doc changes for the same doc version, please update versioned docs here

[GitHub] [pulsar] wolfstudy opened a new pull request #11675: Replace bookkeper with bookkeeper in bin/bookkeeper

2021-08-16 Thread GitBox
wolfstudy opened a new pull request #11675: URL: https://github.com/apache/pulsar/pull/11675 Signed-off-by: xiaolongran ### Motivation ![image](https://user-images.githubusercontent.com/20965307/129522786-1621dd8f-5d3a-48ab-82b3-437857a45ac8.png) ###

[GitHub] [pulsar] eolivelli commented on a change in pull request #11666: [pulsar-admin] allow create functions with package URL

2021-08-16 Thread GitBox
eolivelli commented on a change in pull request #11666: URL: https://github.com/apache/pulsar/pull/11666#discussion_r689277408 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/functions/Utils.java ## @@ -34,7 +36,9 @@ public static boolean