[GitHub] [pulsar] gaozhangmin commented on pull request #12302: reset-cursor support earliest or latest

2021-10-25 Thread GitBox
gaozhangmin commented on pull request #12302: URL: https://github.com/apache/pulsar/pull/12302#issuecomment-951587074 @michaeljmarshall PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mingyifei edited a comment on issue #12495: no properties discovered to create BeanSerializer

2021-10-25 Thread GitBox
mingyifei edited a comment on issue #12495: URL: https://github.com/apache/pulsar/issues/12495#issuecomment-951585384 我认为发消息时默认应该允许属性为空的对象 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#issuecomment-951585371 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] mingyifei commented on issue #12495: no properties discovered to create BeanSerializer

2021-10-25 Thread GitBox
mingyifei commented on issue #12495: URL: https://github.com/apache/pulsar/issues/12495#issuecomment-951585384 我认为发消息时应该允许属性为空的对象 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] mingyifei opened a new issue #12495: no properties discovered to create BeanSerializer

2021-10-25 Thread GitBox
mingyifei opened a new issue #12495: URL: https://github.com/apache/pulsar/issues/12495 背景:客户端启动完毕,构建消息时报错 代码: 生产者客户端: Producer producer = pulsarClient.newProducer(Schema.JSON(RequestWrapper.class)) ... .create();

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736163522 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] 315157973 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
315157973 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736158232 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736153293 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] BewareMyPower commented on pull request #12473: Remove deprecated tlsEnabled config from broker and functions worker

2021-10-25 Thread GitBox
BewareMyPower commented on pull request #12473: URL: https://github.com/apache/pulsar/pull/12473#issuecomment-951563574 It looks like there're still some test failures about Pulsar Functions with TLS, I'll investigate soon. ``` Error: Failures: Error:

[pulsar] branch master updated: [C++] Fixed connection read error logging (#12492)

2021-10-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6edcaa7 [C++] Fixed connection read error

[GitHub] [pulsar] merlimat merged pull request #12492: [C++] Fixed connection read error logging

2021-10-25 Thread GitBox
merlimat merged pull request #12492: URL: https://github.com/apache/pulsar/pull/12492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] 315157973 commented on a change in pull request #12132: [Broker] Fix prefix setting in JWT authn and avoid multi calls for the getProperty

2021-10-25 Thread GitBox
315157973 commented on a change in pull request #12132: URL: https://github.com/apache/pulsar/pull/12132#discussion_r736127056 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -54,7 +54,7 @@

[GitHub] [pulsar] Shoothzj commented on issue #12399: Topic partition's segmented storage space calculation error

2021-10-25 Thread GitBox
Shoothzj commented on issue #12399: URL: https://github.com/apache/pulsar/issues/12399#issuecomment-951532298 > > > > en max entries have been written to the ledger and at least > > > > > > > > > > > > However, the actual storage space exceeds the configured threshold

[GitHub] [pulsar] xuesongxs commented on issue #12399: Topic partition's segmented storage space calculation error

2021-10-25 Thread GitBox
xuesongxs commented on issue #12399: URL: https://github.com/apache/pulsar/issues/12399#issuecomment-951522598 > > > en max entries have been written to the ledger and at least > > > > > > However, the actual storage space exceeds the configured threshold too much. Is this

[pulsar] branch branch-2.8 updated: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order (#12456)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new cfec2c9 [Java Client] Remove data

[pulsar] 09/09: Fix the retry topic's `REAL_TOPIC` & `ORIGIN_MESSAGE_ID` property should not be modified once it has been written. (#12451)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 8bea3cd5ec18ef6fb9d89dfbf261f486b59c7095 Author: YANGLiiN AuthorDate: Mon Oct 25 12:17:57 2021 +0800 Fix the

[pulsar] 08/09: #12429 only fixed the compactor skips data issue, but the normal reader/consumer (#12464)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 39ee36cf3e33002a6e8bc5ba7eb5060e239da7c2 Author: lipenghui AuthorDate: Sun Oct 24 23:11:15 2021 +0800 #12429

[pulsar] 07/09: fix the race of delete subscription and delete topic (#12240)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit f07a87d0926f73a5f8cb62e4560b332f3718232f Author: ZhangJian He AuthorDate: Mon Oct 25 08:41:05 2021 +0800 fix

[pulsar] 06/09: Optimize the code: remove extra spaces (#12470)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 83d941f238b488b42618e3178ac298a1e6fa433c Author: chenlin <1572139...@qq.com> AuthorDate: Sun Oct 24 12:28:29 2021

[pulsar] 03/09: broker resource group test optimize fail msg (#12438)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 9aadc7ea4b676296a3a2daf04a0cf5983208b6ae Author: ZhangJian He AuthorDate: Sun Oct 24 12:41:55 2021 +0800

[pulsar] 05/09: fix a typo in UnAckedMessageTracker (#12467)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4884fb7d2bc785e0197234b4ecf0a7fc1d00bd1e Author: ZhangJian He AuthorDate: Sun Oct 24 12:32:29 2021 +0800 fix

[pulsar] 02/09: optimize SecurityUtility code flow (#12431)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 232d61b5e01807cfdaff943b93aeb61ef6d9fef7 Author: ZhangJian He AuthorDate: Sun Oct 24 12:24:06 2021 +0800

[pulsar] branch branch-2.8 updated (1a869ef -> 8bea3cd)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1a869ef Add debug log for WebSocket. (#12458) new eb91b36 Future completed twice in the method of

[pulsar] 04/09: [Pulsar SQL] Pulsar SQL support query big entry data (#12448)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit e7c3bfb8bb8b3a97d4da65fa6093356151c5ec7b Author: ran AuthorDate: Tue Oct 26 08:24:33 2021 +0800 [Pulsar SQL]

[pulsar] 01/09: Future completed twice in the method of impl.MLPendingAckStore#closeAsync (#12362)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit eb91b363eadd2077ed8b9a659b7e7781600728f3 Author: chenlin <1572139...@qq.com> AuthorDate: Fri Oct 22 16:23:42 2021

[GitHub] [pulsar] congbobo184 opened a new issue #12494: [Transaction] Fix when topic transaction buffer recover produce `ledger not exist error`

2021-10-25 Thread GitBox
congbobo184 opened a new issue #12494: URL: https://github.com/apache/pulsar/issues/12494 **Describe the bug** When topic transaction buffer recover produce `ledger not exist error`, it will recover in loop and don't quit.

[GitHub] [pulsar] 315157973 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
315157973 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r736103094 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/ConsumerImplTest.java ## @@ -187,4 +187,17 @@ public void

[GitHub] [pulsar] eolivelli commented on pull request #12493: [Broker] Fix messageDedup delete inactive producer name

2021-10-25 Thread GitBox
eolivelli commented on pull request #12493: URL: https://github.com/apache/pulsar/pull/12493#issuecomment-951508467 @congbobo184:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] eolivelli commented on pull request #12493: [Broker] Fix messageDedup delete inactive producer name

2021-10-25 Thread GitBox
eolivelli commented on pull request #12493: URL: https://github.com/apache/pulsar/pull/12493#issuecomment-951508249 @congbobo184:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] congbobo184 opened a new pull request #12493: [Broker] Fix messageDedup delete inactive producer name

2021-10-25 Thread GitBox
congbobo184 opened a new pull request #12493: URL: https://github.com/apache/pulsar/pull/12493 ## Motivation fix https://github.com/apache/pulsar/issues/12478 ## Implement when message deup recover, put producerName into inactiveProduceName map, if producer connect to, it will

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12471: Optimize ThresholdShedder strategy

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12471: URL: https://github.com/apache/pulsar/pull/12471#discussion_r736079979 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java ## @@ -78,7 +78,7 @@ final

[GitHub] [pulsar] liangyepianzhou commented on pull request #11933: [Transaction] Add transaction perf

2021-10-25 Thread GitBox
liangyepianzhou commented on pull request #11933: URL: https://github.com/apache/pulsar/pull/11933#issuecomment-951475812 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12481: Add the pulsar java property memory allocator doc

2021-10-25 Thread GitBox
Anonymitaet commented on a change in pull request #12481: URL: https://github.com/apache/pulsar/pull/12481#discussion_r736073231 ## File path: site2/website-next/docs/client-libraries-java.md ## @@ -151,6 +151,16 @@ Check out the Javadoc for the {@inject:

[GitHub] [pulsar] merlimat opened a new pull request #12492: [C++] Fixed connection read error logging

2021-10-25 Thread GitBox
merlimat opened a new pull request #12492: URL: https://github.com/apache/pulsar/pull/12492 ### Motivation Fixed the logging statement when dealing with a read error to include the actual `err` object for context, since it was removed after #11882 -- This is an automated message

[GitHub] [pulsar] merlimat opened a new pull request #12491: Fixed getting children of parent nodes in LocalMemoryMetadataStore

2021-10-25 Thread GitBox
merlimat opened a new pull request #12491: URL: https://github.com/apache/pulsar/pull/12491 ### Motivation In `LocalMemoryMetadataStore` the semantic of navigating children of nodes was not respected when the intermediate nodes are not existing. Fixed the behavior and added tests

[GitHub] [pulsar] tsturzl closed pull request #12487: [Issue #12485][Python Client] and [Issue #12486][Python Client]

2021-10-25 Thread GitBox
tsturzl closed pull request #12487: URL: https://github.com/apache/pulsar/pull/12487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tsturzl opened a new pull request #12490: [Issue #12486][Python Client]

2021-10-25 Thread GitBox
tsturzl opened a new pull request #12490: URL: https://github.com/apache/pulsar/pull/12490 Fixes #12486 ### Motivation JsonSchemas delete part of the Record which makes it impossible to reuse a Record. Resulting in a KeyError anytime you encode the message

[GitHub] [pulsar] tsturzl opened a new pull request #12489: [Issue #12486][Python Client]

2021-10-25 Thread GitBox
tsturzl opened a new pull request #12489: URL: https://github.com/apache/pulsar/pull/12489 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #12486 ### Motivation There were some None checks which were too inclusive and didn't allow the use of 0

[pulsar] branch master updated (6a2e3a1 -> a8f0788)

2021-10-25 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6a2e3a1 [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order (#12456)

[GitHub] [pulsar] codelipenghui merged pull request #12448: [Pulsar SQL] Pulsar SQL support query big entry data

2021-10-25 Thread GitBox
codelipenghui merged pull request #12448: URL: https://github.com/apache/pulsar/pull/12448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo commented on pull request #12322: [pulsar-admin] Add corresponding get command for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12322: URL: https://github.com/apache/pulsar/pull/12322#issuecomment-951430909 @merlimat @eolivelli @315157973 @congbobo184 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] liangyepianzhou commented on pull request #11933: [Transaction] Add transaction perf

2021-10-25 Thread GitBox
liangyepianzhou commented on pull request #11933: URL: https://github.com/apache/pulsar/pull/11933#issuecomment-951430447 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yuruguo commented on pull request #12392: [pulsar-admin] Add remove-subscription-types-enabled command for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12392: URL: https://github.com/apache/pulsar/pull/12392#issuecomment-951427210 @merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] yuruguo removed a comment on pull request #12392: [pulsar-admin] Add remove-subscription-types-enabled command for namespace

2021-10-25 Thread GitBox
yuruguo removed a comment on pull request #12392: URL: https://github.com/apache/pulsar/pull/12392#issuecomment-951426672 @merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @congbobo184 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] yuruguo removed a comment on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-10-25 Thread GitBox
yuruguo removed a comment on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-950423691 @merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @congbobo184 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] yuruguo commented on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-951426943 @merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] yuruguo removed a comment on pull request #12392: [pulsar-admin] Add remove-subscription-types-enabled command for namespace

2021-10-25 Thread GitBox
yuruguo removed a comment on pull request #12392: URL: https://github.com/apache/pulsar/pull/12392#issuecomment-950423270 @merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @congbobo184 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] yuruguo commented on pull request #12392: [pulsar-admin] Add remove-subscription-types-enabled command for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12392: URL: https://github.com/apache/pulsar/pull/12392#issuecomment-951426672 @merlimat @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @congbobo184 @hangc0276 @gaoran10 PTAL -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12483: URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951422935 @eolivelli @aahmed-se @k2la @codelipenghui @315157973 @hangc0276 @gaoran10 @freeznet please take a look, thx! -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] LCVcode opened a new issue #12488: Documentation falsely says that metadata needs to be initialized from a machine in the "zookeeper cluster".

2021-10-25 Thread GitBox
LCVcode opened a new issue #12488: URL: https://github.com/apache/pulsar/issues/12488 Please answer the following questions before submitting your doc issue. Thanks! # What issue do you find in Pulsar docs? Documentation falsely states that metadata needs to be initialized

[GitHub] [pulsar] smazurov commented on pull request #12065: Fix k8s pulsar functions containers not exposing metrics port for scraping

2021-10-25 Thread GitBox
smazurov commented on pull request #12065: URL: https://github.com/apache/pulsar/pull/12065#issuecomment-951413352 can this be reviewed/merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] merlimat commented on pull request #12487: [Issue #12485][Python Client] and [Issue #12486][Python Client]

2021-10-25 Thread GitBox
merlimat commented on pull request #12487: URL: https://github.com/apache/pulsar/pull/12487#issuecomment-951403461 > Fixes #12485 > Fixes #12486 @tsturzl Thanks for the fixes. Ideally, we try to always have different fixes in different PRs, to make the review process easier.

[GitHub] [pulsar] merlimat commented on a change in pull request #12487: [Issue #12485][Python Client] and [Issue #12486][Python Client]

2021-10-25 Thread GitBox
merlimat commented on a change in pull request #12487: URL: https://github.com/apache/pulsar/pull/12487#discussion_r736027335 ## File path: pulsar-client-cpp/python/pulsar/functions/context.py ## @@ -42,151 +42,161 @@ """ from abc import abstractmethod + class

[GitHub] [pulsar] alexsapps commented on issue #12053: Docs clarification needed for concepts-messaging/#retry-letter-topic

2021-10-25 Thread GitBox
alexsapps commented on issue #12053: URL: https://github.com/apache/pulsar/issues/12053#issuecomment-951395768 I was able to answer most of the questions myself after reading the original PR that introduced the feature - [6449](https://github.com/apache/pulsar/pull/6449/files). >

[GitHub] [pulsar] eolivelli commented on pull request #12487: [Issue #12485][Python Client] and [Issue #12486][Python Client]

2021-10-25 Thread GitBox
eolivelli commented on pull request #12487: URL: https://github.com/apache/pulsar/pull/12487#issuecomment-951376824 @tsturzl:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] eolivelli commented on pull request #12487: [Issue #12485][Python Client] and [Issue #12486][Python Client]

2021-10-25 Thread GitBox
eolivelli commented on pull request #12487: URL: https://github.com/apache/pulsar/pull/12487#issuecomment-951376404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] tsturzl opened a new pull request #12487: [Issue #12485][Python Client] and [Issue #12486][Python Client]

2021-10-25 Thread GitBox
tsturzl opened a new pull request #12487: URL: https://github.com/apache/pulsar/pull/12487 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #12485 Fixes #12486 ### Motivation I found several issues in the python client. First there were some

[GitHub] [pulsar] tsturzl opened a new issue #12486: Python Client, JsonSchema encoding is not idempotent

2021-10-25 Thread GitBox
tsturzl opened a new issue #12486: URL: https://github.com/apache/pulsar/issues/12486 **Describe the bug** The JsonSchema throws a KeyError exception during on `encode` method if you call it more than once. The keys that get deleted on encoding don't exist the second time and there is

[pulsar] branch master updated: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order (#12456)

2021-10-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6a2e3a1 [Java Client] Remove data race in

[GitHub] [pulsar] merlimat merged pull request #12456: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order

2021-10-25 Thread GitBox
merlimat merged pull request #12456: URL: https://github.com/apache/pulsar/pull/12456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: Allow to have different instances LocalMemoryMetadataStore that share the same state (#12390)

2021-10-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9f25843 Allow to have different instances

[GitHub] [pulsar] eolivelli merged pull request #12390: Allow to have different instances LocalMemoryMetadataStore that share the same state

2021-10-25 Thread GitBox
eolivelli merged pull request #12390: URL: https://github.com/apache/pulsar/pull/12390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tsturzl opened a new issue #12485: Python Client has very unexpected behavior, cannot use any value that evaludates to False

2021-10-25 Thread GitBox
tsturzl opened a new issue #12485: URL: https://github.com/apache/pulsar/issues/12485 **Describe the bug** Python client does very bad things with values `0`, `False`, and empty strings/dicts/lists/etc. Basically any value that evaluates to False cannot be used as the value for a

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12302: reset-cursor support earliest or latest

2021-10-25 Thread GitBox
michaeljmarshall commented on a change in pull request #12302: URL: https://github.com/apache/pulsar/pull/12302#discussion_r735801083 ## File path: site2/docs/reference-pulsar-admin.md ## @@ -2331,7 +2331,7 @@ Options |---|---|---| |`-s`, `--subscription`|Subscription to

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #646: optimize/producer: normally handle UnknownError to avoid crazy reconnection and sending messages for same message

2021-10-25 Thread GitBox
cckellogg commented on a change in pull request #646: URL: https://github.com/apache/pulsar-client-go/pull/646#discussion_r735791787 ## File path: pulsar/internal/connection.go ## @@ -784,6 +784,9 @@ func (c *connection) handleSendError(sendError *pb.CommandSendError) {

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #648: [feature] expose error to user when producer reconnect to broker failed

2021-10-25 Thread GitBox
cckellogg commented on a change in pull request #648: URL: https://github.com/apache/pulsar-client-go/pull/648#discussion_r735780659 ## File path: pulsar/producer_partition.go ## @@ -350,13 +353,14 @@ func (p *partitionProducer) reconnectToBroker() {

[GitHub] [pulsar] flowchartsman commented on issue #5138: [Go Function API] Ability to store state

2021-10-25 Thread GitBox
flowchartsman commented on issue #5138: URL: https://github.com/apache/pulsar/issues/5138#issuecomment-951106908 Linking @wolfstudy's apache/bookkeeper#2750 commit here after closing my [old issue.](https://github.com/apache/pulsar/issues/10560). -- This is an automated message from the

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #12456: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order

2021-10-25 Thread GitBox
michaeljmarshall commented on a change in pull request #12456: URL: https://github.com/apache/pulsar/pull/12456#discussion_r735764999 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -269,7 +269,7 @@ private void

[GitHub] [pulsar] flowchartsman closed issue #10560: [Go Functions] support state storage API

2021-10-25 Thread GitBox
flowchartsman closed issue #10560: URL: https://github.com/apache/pulsar/issues/10560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] flowchartsman commented on issue #10560: [Go Functions] support state storage API

2021-10-25 Thread GitBox
flowchartsman commented on issue #10560: URL: https://github.com/apache/pulsar/issues/10560#issuecomment-951091551 Duplicate of #5138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] yuruguo removed a comment on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace

2021-10-25 Thread GitBox
yuruguo removed a comment on pull request #12483: URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951074923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12483: URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951076048 /pulsarbot run-failure-check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yuruguo commented on pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace

2021-10-25 Thread GitBox
yuruguo commented on pull request #12483: URL: https://github.com/apache/pulsar/pull/12483#issuecomment-951074923 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] merlimat opened a new pull request #12484: [Branch-2.7] Fixed deadlock on metadata cache missing while doing che…

2021-10-25 Thread GitBox
merlimat opened a new pull request #12484: URL: https://github.com/apache/pulsar/pull/12484 ### Motivation After the changes in #12340, there were still a couple of places making blocking calls. These calls occupy all the ordered scheduler threads preventing the callbacks to

[GitHub] [pulsar] congbobo184 commented on issue #8429: Cannot parse schema

2021-10-25 Thread GitBox
congbobo184 commented on issue #8429: URL: https://github.com/apache/pulsar/issues/8429#issuecomment-951052930 @dhinesherode91 hi, this issue problem solved? if not, could you please provide the broker version and client version. Do your consumers consume multiple topics? look at the

[GitHub] [pulsar] lordcheng10 commented on pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#issuecomment-951024034 ConsumerImplTest.testClose method has been added. Please review again,thanks! @codelipenghui -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #12469: Add close method in the class of NegativeAcksTracker

2021-10-25 Thread GitBox
lordcheng10 commented on a change in pull request #12469: URL: https://github.com/apache/pulsar/pull/12469#discussion_r735695756 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -979,6 +979,7 @@ private void closeConsumerTasks()

[GitHub] [pulsar] yuruguo opened a new pull request #12483: [pulsar-admin] Check validity of --compatibility for namespace

2021-10-25 Thread GitBox
yuruguo opened a new pull request #12483: URL: https://github.com/apache/pulsar/pull/12483 ### Motivation We should check the validity of the `--compatibility` and give a more friendly prompt message when set schema compatibility strategy for namespace through `./bin/pulsar-admin

[GitHub] [pulsar] liangyepianzhou commented on pull request #12449: [Transaction] Offload transaction data

2021-10-25 Thread GitBox
liangyepianzhou commented on pull request #12449: URL: https://github.com/apache/pulsar/pull/12449#issuecomment-951002071 > @liangyepianzhou the links in the description as not accessible. > can you create the relevant issue in this repository ? Thank you for your reminder, I have

[GitHub] [pulsar] liangyepianzhou opened a new issue #12482: [Transaction]Offload Transaction Data

2021-10-25 Thread GitBox
liangyepianzhou opened a new issue #12482: URL: https://github.com/apache/pulsar/issues/12482 **Is your enhancement request related to a problem? Please describe.** Filter out redundant entries, including transaction marks and aborted messages. **Describe the solution you'd like**

[GitHub] [pulsar] lhotari commented on pull request #12456: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order

2021-10-25 Thread GitBox
lhotari commented on pull request #12456: URL: https://github.com/apache/pulsar/pull/12456#issuecomment-950944707 > > @michaeljmarshall can you allow edits for maintainers for this PR? I'd like to push the test case ([lhotari@1b0ad24](https://github.com/lhotari/pulsar/commit/1b0ad24b)) to

[GitHub] [pulsar] michaeljmarshall commented on pull request #12456: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order

2021-10-25 Thread GitBox
michaeljmarshall commented on pull request #12456: URL: https://github.com/apache/pulsar/pull/12456#issuecomment-950941793 > @michaeljmarshall can you allow edits for maintainers for this PR? I'd like to push the test case

[GitHub] [pulsar] lhotari commented on pull request #12456: [Java Client] Remove data race in MultiTopicsConsumerImpl to ensure correct message order

2021-10-25 Thread GitBox
lhotari commented on pull request #12456: URL: https://github.com/apache/pulsar/pull/12456#issuecomment-950916919 @michaeljmarshall can you allow edits for maintainers for this PR? I'd like to push the test case (https://github.com/lhotari/pulsar/commit/1b0ad24b) to be part of this PR.

[pulsar] branch master updated (b1ef8be -> 464a9cd)

2021-10-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b1ef8be [website][upgrade]feat: docs migration - version-2.7.2 Pulsar Schema (#12393) add 464a9cd Remove

[GitHub] [pulsar] eolivelli merged pull request #12472: optimization:remove unused isTxnMessage

2021-10-25 Thread GitBox
eolivelli merged pull request #12472: URL: https://github.com/apache/pulsar/pull/12472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] eolivelli commented on pull request #12449: [Transaction] Offload transaction data

2021-10-25 Thread GitBox
eolivelli commented on pull request #12449: URL: https://github.com/apache/pulsar/pull/12449#issuecomment-950878946 @liangyepianzhou the links in the description as not accessible. can you create the relevant issue in this repository ? -- This is an automated message from the Apache

[pulsar-test-infra] branch master updated: CI: Update docbot robot script - not need for botname (#23)

2021-10-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git The following commit(s) were added to refs/heads/master by this push: new 6729981 CI: Update docbot robot

[GitHub] [pulsar] eolivelli commented on pull request #12481: Add the pulsar java property memory allocator doc

2021-10-25 Thread GitBox
eolivelli commented on pull request #12481: URL: https://github.com/apache/pulsar/pull/12481#issuecomment-950853679 @Shoothzj:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] eolivelli commented on pull request #12481: Add the pulsar java property memory allocator doc

2021-10-25 Thread GitBox
eolivelli commented on pull request #12481: URL: https://github.com/apache/pulsar/pull/12481#issuecomment-950852993 @Shoothzj:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] Shoothzj opened a new pull request #12481: Add the pulsar java property memory allocator doc

2021-10-25 Thread GitBox
Shoothzj opened a new pull request #12481: URL: https://github.com/apache/pulsar/pull/12481 ### Modifications Add the pulsar java property memory allocator doc ### Documentation Need to update docs? - [ ] `doc` This is a doc PR. --

[GitHub] [pulsar-client-go] wolfstudy closed issue #513: BatchingMaxMessages option is ignored

2021-10-25 Thread GitBox
wolfstudy closed issue #513: URL: https://github.com/apache/pulsar-client-go/issues/513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy merged pull request #528: [issue 513] fix batch size limit validation

2021-10-25 Thread GitBox
wolfstudy merged pull request #528: URL: https://github.com/apache/pulsar-client-go/pull/528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >