[GitHub] [pulsar] eolivelli commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
eolivelli commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048525313 We can go with the current form from my opinion. I would like to see the 'applied' version of the function some day. Let's unblock the release. -- This

[GitHub] [pulsar] eolivelli commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

2022-02-22 Thread GitBox
eolivelli commented on a change in pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#discussion_r812626278 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationDataBasic.java ## @@ -29,10 +29,13 @@ private static

[GitHub] [pulsar] zcola opened a new issue #14427: NPE error

2022-02-22 Thread GitBox
zcola opened a new issue #14427: URL: https://github.com/apache/pulsar/issues/14427 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: KoP 2.9.2.3 pulsar 2.9.2 ``` 16:02:48.983

[GitHub] [pulsar] Technoboy- commented on issue #14413: ConsumerBuilderImpl.subscribeAsync blocks calling thread

2022-02-22 Thread GitBox
Technoboy- commented on issue #14413: URL: https://github.com/apache/pulsar/issues/14413#issuecomment-1048517390 I will check and try to working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] yaalsn commented on pull request #14390: [CI]Label stale issues and PRs

2022-02-22 Thread GitBox
yaalsn commented on pull request #14390: URL: https://github.com/apache/pulsar/pull/14390#issuecomment-1048515482 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] dlg99 commented on issue #14311: creat ledger timeout and thread BookKeeperClientWorker in stuck

2022-02-22 Thread GitBox
dlg99 commented on issue #14311: URL: https://github.com/apache/pulsar/issues/14311#issuecomment-1048514697 @fu-turer is there anything in the logs related to not being able to connect to bookies because of e.g. a TLS issue? Or attempt to use TLS 1.3? see

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new af86428 update af86428 is described below

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new d48551e update d48551e is described below

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new a46e7b0 update a46e7b0 is described below

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 03dc14f update 03dc14f is described below

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 3ca641a update 3ca641a is described below

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new d557185 update d557185 is described below

[pulsar-site] branch main updated: update

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 73b2c64 update 73b2c64 is described below

[pulsar-site] branch main updated: crowdin download test

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new fd93ee0 crowdin download test fd93ee0 is

[GitHub] [pulsar] gaozhangmin commented on pull request #14411: [Broker] Remove dead brokers timeaverage data

2022-02-22 Thread GitBox
gaozhangmin commented on pull request #14411: URL: https://github.com/apache/pulsar/pull/14411#issuecomment-1048493215 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Technoboy- commented on issue #14365: [DISCUSS] Standardize Admin REST API

2022-02-22 Thread GitBox
Technoboy- commented on issue #14365: URL: https://github.com/apache/pulsar/issues/14365#issuecomment-1048487501 > Is it better to combine this one and #14353 want to do to one PIP such as PIP-142? WDYT? @Technoboy- @lhotari @merlimat > > The advantage is that we can provide a

[GitHub] [pulsar] czhfe opened a new issue #14426: broker No such entry

2022-02-22 Thread GitBox
czhfe opened a new issue #14426: URL: https://github.com/apache/pulsar/issues/14426 **Describe the bug** The consumer is unable to subscribe and has the following error when viewing the broker component: ``` time="2022-02-18T17:34:44+08:00" level=info msg="[Connecting to broker]"

[GitHub] [pulsar] RocMarshal commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.

2022-02-22 Thread GitBox
RocMarshal commented on pull request #14385: URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1048485134 @codelipenghui @yuruguo Glad to do it. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] michaeljmarshall opened a new pull request #14425: Update .asf.yaml: keep stale reviews on PRs targeting master

2022-02-22 Thread GitBox
michaeljmarshall opened a new pull request #14425: URL: https://github.com/apache/pulsar/pull/14425 ### Motivation In https://github.com/apache/pulsar/pull/14226, I set this value to `true`. The previous setting was false. Mailing list discussion: ### Modifications

[GitHub] [pulsar] Shoothzj commented on pull request #14421: [security] Remove sensitive msg from log

2022-02-22 Thread GitBox
Shoothzj commented on pull request #14421: URL: https://github.com/apache/pulsar/pull/14421#issuecomment-1048476115 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui commented on issue #14365: [DISCUSS] Standardize Admin REST API

2022-02-22 Thread GitBox
codelipenghui commented on issue #14365: URL: https://github.com/apache/pulsar/issues/14365#issuecomment-1048475738 Is it better to combine this one and https://github.com/apache/pulsar/pull/14353 want to do to one PIP such as PIP-142? WDYT? @Technoboy- @lhotari @merlimat The

[GitHub] [pulsar] ZiyaoWei commented on pull request #14408: Fix TableViewImpl not retrying partition update on exceptions

2022-02-22 Thread GitBox
ZiyaoWei commented on pull request #14408: URL: https://github.com/apache/pulsar/pull/14408#issuecomment-1048467723 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] ZiyaoWei removed a comment on pull request #14408: Fix TableViewImpl not retrying partition update on exceptions

2022-02-22 Thread GitBox
ZiyaoWei removed a comment on pull request #14408: URL: https://github.com/apache/pulsar/pull/14408#issuecomment-1048467382 [](https://github.com/merlimat)/pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] ZiyaoWei commented on pull request #14408: Fix TableViewImpl not retrying partition update on exceptions

2022-02-22 Thread GitBox
ZiyaoWei commented on pull request #14408: URL: https://github.com/apache/pulsar/pull/14408#issuecomment-1048467382 [](https://github.com/merlimat)/pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] michaeljmarshall commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048467366 @wangjialing218 - great, I thought those methods looked similar, but I didn't look closely enough to see the one was a duplicate. Thanks for fixing that. -- This

[GitHub] [pulsar] wangjialing218 commented on a change in pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
wangjialing218 commented on a change in pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#discussion_r812576040 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java ## @@ -293,6 +293,9 @@ protected Policies

[GitHub] [pulsar] wangjialing218 commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
wangjialing218 commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048466907 > > I believe this solution is incomplete. I think we also need to update this method defined on line 517 in the same class: > > ```java > > protected Policies

[pulsar] branch master updated (22a0beb -> 6c34217)

2022-02-22 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 22a0beb Fix await condition error in testMultiTopicsConsumerImplPauseForPartitionNumberChange (#14405) add

[GitHub] [pulsar] Anonymitaet merged pull request #14406: [Doc] Add `maxSubscriptionsPerTopic` to broker and standalone configurations

2022-02-22 Thread GitBox
Anonymitaet merged pull request #14406: URL: https://github.com/apache/pulsar/pull/14406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch branch-2.10 updated: Revert "[PIP 97] Update Authentication Interfaces to Include Async Authentication Methods (#12104)" (#14424)

2022-02-22 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new b822d6f Revert "[PIP 97] Update

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14398: Added 2.10.0 release note

2022-02-22 Thread GitBox
michaeljmarshall commented on a change in pull request #14398: URL: https://github.com/apache/pulsar/pull/14398#discussion_r812572867 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,300 @@ ## Apache Pulsar Release Notes +### 2.10.0 + 2022-02-28 + +###

[GitHub] [pulsar] michaeljmarshall merged pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

2022-02-22 Thread GitBox
michaeljmarshall merged pull request #14424: URL: https://github.com/apache/pulsar/pull/14424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14424: URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1048463601 @codelipenghui - I had opened this PR with the intention of making sure tests pass. Apparently, we don't have tests configured to run on these PRs--I thought we did.

[GitHub] [pulsar] yaalsn commented on a change in pull request #14390: [CI]Label stable issues and PRs

2022-02-22 Thread GitBox
yaalsn commented on a change in pull request #14390: URL: https://github.com/apache/pulsar/pull/14390#discussion_r812570010 ## File path: .github/workflows/ci-stable-issue-pr.yaml ## @@ -0,0 +1,18 @@ +name: 'Stale issues and PRs' +on: + schedule: +- cron: '30 1 * * *' +

[GitHub] [pulsar] aparajita89 commented on a change in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-02-22 Thread GitBox
aparajita89 commented on a change in pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r812566069 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java ## @@ -221,6 +210,35 @@ public

[GitHub] [pulsar] aparajita89 commented on a change in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-02-22 Thread GitBox
aparajita89 commented on a change in pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r812565989 ## File path: conf/standalone.conf ## @@ -431,15 +435,15 @@ brokerClientTlsCiphers= brokerClientTlsProtocols= # Enable or disable system topic

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14424: URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1048455485 I am looking into why non of the tests ran. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] michaeljmarshall commented on pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14424: URL: https://github.com/apache/pulsar/pull/14424#issuecomment-1048455364 @codelipenghui - since we need to do a second RC for 2.10.0, I realized I should revert PIP 97 while I have the chance. I plan to complete the work soon, but it

[pulsar] branch master updated (720de94 -> 22a0beb)

2022-02-22 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 720de94 [Doc][SQL] add explanations for how to get last message in topics (#14412) add 22a0beb Fix await

[GitHub] [pulsar] freeznet commented on pull request #12316: [Issue 12314][Go Functions] Remove extra call to gi.stats.incrTotalProcessedSuccessfully()

2022-02-22 Thread GitBox
freeznet commented on pull request #12316: URL: https://github.com/apache/pulsar/pull/12316#issuecomment-1048455219 @nlu90 please help to review this PR when you have time, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] aparajita89 commented on a change in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-02-22 Thread GitBox
aparajita89 commented on a change in pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r812559749 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -117,7 +117,7 @@ public void

[GitHub] [pulsar] codelipenghui merged pull request #14405: [test] Fix await condition error in testMultiTopicsConsumerImplPauseForPartionNumberChange

2022-02-22 Thread GitBox
codelipenghui merged pull request #14405: URL: https://github.com/apache/pulsar/pull/14405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall opened a new pull request #14424: Revert "[PIP 97] Update Authentication Interfaces to Include Async Au…

2022-02-22 Thread GitBox
michaeljmarshall opened a new pull request #14424: URL: https://github.com/apache/pulsar/pull/14424 …thentication Methods (#12104)" This reverts commit 58680252b9c9d1be67474148130f0746d0feda6b. Master Issue: https://github.com/apache/pulsar/issues/12105 ### Motivation

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14390: [CI]Label stable issues and PRs

2022-02-22 Thread GitBox
codelipenghui commented on a change in pull request #14390: URL: https://github.com/apache/pulsar/pull/14390#discussion_r812561006 ## File path: .github/workflows/ci-stable-issue-pr.yaml ## @@ -0,0 +1,18 @@ +name: 'Stale issues and PRs' +on: + schedule: +- cron: '30 1 * *

[GitHub] [pulsar] michaeljmarshall commented on pull request #14410: [broker] Fix IllegalStateException in ServerCnx#handleRedeliverUnacknowledged

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14410: URL: https://github.com/apache/pulsar/pull/14410#issuecomment-1048449818 @codelipenghui - great point. I didn't realize this was for a new field. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] aparajita89 commented on a change in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-02-22 Thread GitBox
aparajita89 commented on a change in pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r812559749 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java ## @@ -117,7 +117,7 @@ public void

[GitHub] [pulsar] codelipenghui commented on pull request #14388: [pulsar-client-tools] Change IllegalArgumentException to ParameterException in CLI

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14388: URL: https://github.com/apache/pulsar/pull/14388#issuecomment-1048448524 Just link more context here about the [github_stale](https://github.com/actions/stale) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14411: [Broker] Remove dead brokers timeaverage data

2022-02-22 Thread GitBox
gaozhangmin removed a comment on pull request #14411: URL: https://github.com/apache/pulsar/pull/14411#issuecomment-1047621574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] codelipenghui commented on pull request #14390: [CI]Label stable issues and PRs

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14390: URL: https://github.com/apache/pulsar/pull/14390#issuecomment-1048448145 Cool, thanks @yaalsn Could you please also help put an update in https://lists.apache.org/thread/0lm9tyjqtgtvwkfowkfhbxy24nh8tyxh? Great news! --

[GitHub] [pulsar] gaozhangmin commented on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl

2022-02-22 Thread GitBox
gaozhangmin commented on pull request #14197: URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1048447159 ping @codelipenghui also PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] codelipenghui commented on pull request #14387: [Broker]Dynamic update topic broker-level publish-rate

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14387: URL: https://github.com/apache/pulsar/pull/14387#issuecomment-1048446861 +1 please add test for the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14197: Change deprecated setZookeeperServers to setMetadataStoreUrl

2022-02-22 Thread GitBox
gaozhangmin removed a comment on pull request #14197: URL: https://github.com/apache/pulsar/pull/14197#issuecomment-1046958085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] codelipenghui commented on pull request #14385: [pulsar-client-tools] Adjust PulsarAdminException to ParameterException in cli.

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14385: URL: https://github.com/apache/pulsar/pull/14385#issuecomment-1048446391 @RocMarshal The change looks good to me, could you please help add a unit test? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] michaeljmarshall commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048445848 > > the applied option should be false by default? > > This default value is just for backward compatible. And we can even deprecate method `getPolicies(String

[GitHub] [pulsar] codelipenghui commented on pull request #14384: Make stadnalone use setMetadataStoreUrl

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14384: URL: https://github.com/apache/pulsar/pull/14384#issuecomment-1048445803 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] michaeljmarshall commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-104879 > I believe this solution is incomplete. I think we also need to update this method defined on line 517 in the same class: > > ```java > protected Policies

[GitHub] [pulsar] Anonymitaet commented on issue #14423: [Doc] Zookeeper metrics are incorrect

2022-02-22 Thread GitBox
Anonymitaet commented on issue #14423: URL: https://github.com/apache/pulsar/issues/14423#issuecomment-1048440243 Hi @momo-jun could you please work with @Technoboy- to update the docs? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] Anonymitaet opened a new issue #14423: [Doc] Zookeeper metrics are incorrect

2022-02-22 Thread GitBox
Anonymitaet opened a new issue #14423: URL: https://github.com/apache/pulsar/issues/14423 Doc: https://pulsar.apache.org/docs/en/2.8.2/deploy-monitoring/#zookeeper-stats Context: https://www.mail-archive.com/commits@pulsar.apache.org/msg76624.html -- This is an automated message

[pulsar] branch master updated (33a0783 -> 720de94)

2022-02-22 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 33a0783 Fix Field 'consumer_epoch' is not set in ServerCnx (#14410) add 720de94 [Doc][SQL] add explanations

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
codelipenghui commented on a change in pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#discussion_r812550895 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java ## @@ -293,6 +293,9 @@ protected Policies

[GitHub] [pulsar] Anonymitaet merged pull request #14412: [Doc][SQL] add explanations for how to get last message in topics

2022-02-22 Thread GitBox
Anonymitaet merged pull request #14412: URL: https://github.com/apache/pulsar/pull/14412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on pull request #14410: [broker] Fix IllegalStateException in ServerCnx#handleRedeliverUnacknowledged

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14410: URL: https://github.com/apache/pulsar/pull/14410#issuecomment-1048437487 I believe this one needs to be contained in the 2.10.0 release, otherwise, if upgrade the broker to 2.10.0 but the client still using 2.9.x or 2.8.x, the issue will

[GitHub] [pulsar] RobertIndie opened a new pull request #14422: [Broker] Add deprecated to `subscriptionKeySharedEnable`

2022-02-22 Thread GitBox
RobertIndie opened a new pull request #14422: URL: https://github.com/apache/pulsar/pull/14422 ### Motivation `subscriptionKeySharedEnable` is deprecated in #9401. Need to add the deprecated annotation to it in the `ServiceConfiguration`. ### Modifications * Add

[GitHub] [pulsar] michaeljmarshall commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048435688 @codelipenghui - thanks for tagging me. Looking now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] codelipenghui commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048434900 @gaoran10 @michaeljmarshall Please help check this PR, which is fixing a breaking change in the ongoing release 2.8.3, 2.9.2, and 2.10.0. And @wangjialing218 also

[GitHub] [pulsar] aparajita89 commented on a change in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-02-22 Thread GitBox
aparajita89 commented on a change in pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r812546006 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1266,6 +1267,12 @@ private SchemaStorage

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14400: [PIP-74] Dependency of consumer client memory limit: support dynamic limit of consumer receiver queue

2022-02-22 Thread GitBox
michaeljmarshall commented on a change in pull request #14400: URL: https://github.com/apache/pulsar/pull/14400#discussion_r812545471 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -1610,6 +1607,16 @@ public void

[GitHub] [pulsar] codelipenghui commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
codelipenghui commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048433468 > This default value is just for backward compatible. And we can even deprecate method getPolicies(String namespace). For user with new version of client and broker,

[pulsar] branch master updated (8e9fa9d -> 33a0783)

2022-02-22 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8e9fa9d Exclude more files from src package (#14415) add 33a0783 Fix Field 'consumer_epoch' is not set in

[GitHub] [pulsar] Jason918 commented on pull request #14409: Make sure policies.is_allow_auto_update_schema not null

2022-02-22 Thread GitBox
Jason918 commented on pull request #14409: URL: https://github.com/apache/pulsar/pull/14409#issuecomment-1048430616 > the applied option should be false by default? This default value is just for backward compatible. And we can even deprecate method `getPolicies(String namespace)`.

[GitHub] [pulsar] michaeljmarshall merged pull request #14410: [broker] Fix IllegalStateException in ServerCnx#handleRedeliverUnacknowledged

2022-02-22 Thread GitBox
michaeljmarshall merged pull request #14410: URL: https://github.com/apache/pulsar/pull/14410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall commented on pull request #14410: [broker] Fix IllegalStateException in ServerCnx#handleRedeliverUnacknowledged

2022-02-22 Thread GitBox
michaeljmarshall commented on pull request #14410: URL: https://github.com/apache/pulsar/pull/14410#issuecomment-1048429894 @Jason918 - I believe he is referring to this PR https://github.com/apache/pulsar/pull/12899, and possibly others. -- This is an automated message from the Apache

[GitHub] [pulsar] Anonymitaet commented on pull request #14391: Add document for enabling get the last message in sql

2022-02-22 Thread GitBox
Anonymitaet commented on pull request #14391: URL: https://github.com/apache/pulsar/pull/14391#issuecomment-1048415895 Close this since doc is submitted here: https://github.com/apache/pulsar/pull/14412 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Anonymitaet closed pull request #14391: Add document for enabling get the last message in sql

2022-02-22 Thread GitBox
Anonymitaet closed pull request #14391: URL: https://github.com/apache/pulsar/pull/14391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14414: [Doc] [Do-not-Merge] Add a new metric for managed-ledger add latency

2022-02-22 Thread GitBox
Anonymitaet commented on a change in pull request #14414: URL: https://github.com/apache/pulsar/pull/14414#discussion_r812530502 ## File path: site2/docs/reference-metrics.md ## @@ -274,14 +274,16 @@ All the managedLedger metrics are labelled with the following labels: |

[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14350: [CheckStyle] Enable pulsar-functions-instance checkstyle

2022-02-22 Thread GitBox
gaozhangmin edited a comment on pull request #14350: URL: https://github.com/apache/pulsar/pull/14350#issuecomment-1047659958 ping @eolivelli @Shoothzj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14351: [CheckStyle]Enable pulsar-functions-worker checkstyle

2022-02-22 Thread GitBox
gaozhangmin edited a comment on pull request #14351: URL: https://github.com/apache/pulsar/pull/14351#issuecomment-1047660195 ping @eolivelli @Shoothzj @BewareMyPower -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar-site] branch main updated: feat: multi language build workflow support

2022-02-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 3dde387 feat: multi language build workflow

[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14352: [CheckStyle]Enable CheckStyle of rest of modules of pulsar-functions

2022-02-22 Thread GitBox
gaozhangmin edited a comment on pull request #14352: URL: https://github.com/apache/pulsar/pull/14352#issuecomment-1047660321 ping @eolivelli @Shoothzj @BewareMyPower -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Jason918 commented on a change in pull request #14200: Broker: support dynamic update log level at runtime

2022-02-22 Thread GitBox
Jason918 commented on a change in pull request #14200: URL: https://github.com/apache/pulsar/pull/14200#discussion_r812525236 ## File path: conf/log4j2.yaml ## @@ -134,7 +134,6 @@ Configuration: additivity: true AppenderRef: - ref:

[GitHub] [pulsar] merlimat commented on a change in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-02-22 Thread GitBox
merlimat commented on a change in pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#discussion_r812522821 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -1266,6 +1267,12 @@ private SchemaStorage

[GitHub] [pulsar] Anonymitaet commented on pull request #14398: Added 2.10.0 release note

2022-02-22 Thread GitBox
Anonymitaet commented on pull request #14398: URL: https://github.com/apache/pulsar/pull/14398#issuecomment-1048405554 @DaveDuggins could you please help review? Thanks FYI @momo-jun @D-2-Ed -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Shoothzj opened a new pull request #14421: [security] Remove sensitive msg from log

2022-02-22 Thread GitBox
Shoothzj opened a new pull request #14421: URL: https://github.com/apache/pulsar/pull/14421 ### Motivation Currently, we are print `ClientConfiguration`& `ServerConfiguration` password field in to log. ### Modifications - remove the sensitive field from toString - fix a

[GitHub] [pulsar] Shoothzj closed pull request #14420: [security] Remove sensitive msg from log

2022-02-22 Thread GitBox
Shoothzj closed pull request #14420: URL: https://github.com/apache/pulsar/pull/14420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] github-actions[bot] removed a comment on pull request #14420: [security] Remove sensitive msg from log

2022-02-22 Thread GitBox
github-actions[bot] removed a comment on pull request #14420: URL: https://github.com/apache/pulsar/pull/14420#issuecomment-1048403421 @Shoothzj:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] github-actions[bot] commented on pull request #14420: [security] Remove sensitive msg from log

2022-02-22 Thread GitBox
github-actions[bot] commented on pull request #14420: URL: https://github.com/apache/pulsar/pull/14420#issuecomment-1048403421 @Shoothzj:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] Shoothzj opened a new pull request #14420: [security] Remove sensitive msg from log

2022-02-22 Thread GitBox
Shoothzj opened a new pull request #14420: URL: https://github.com/apache/pulsar/pull/14420 ### Motivation Currently, we are print `ClientConfiguration`& `ServerConfiguration` password field in to log. ### Modifications - remove the sensitive field from toString - fix a

[GitHub] [pulsar] ethqunzhong commented on a change in pull request #14200: Broker: support dynamic update log level at runtime

2022-02-22 Thread GitBox
ethqunzhong commented on a change in pull request #14200: URL: https://github.com/apache/pulsar/pull/14200#discussion_r812518287 ## File path: conf/log4j2.yaml ## @@ -134,7 +134,6 @@ Configuration: additivity: true AppenderRef: - ref:

[GitHub] [pulsar] tuteng commented on pull request #14044: [broker][authentication]Support pass http auth status

2022-02-22 Thread GitBox
tuteng commented on pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#issuecomment-1048399224 > LGTM. > > @tuteng - thanks for addressing my many comments. Also, I took a look at your bug report in #14404, and I personally don't think this can be classified as a

[pulsar] branch master updated (958fc78 -> 8e9fa9d)

2022-02-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 958fc78 [C++] Fix GCC compilation failure caused by warning macro (#14402) add 8e9fa9d Exclude more files

[GitHub] [pulsar] merlimat merged pull request #14415: [Build] Exclude more files from src package

2022-02-22 Thread GitBox
merlimat merged pull request #14415: URL: https://github.com/apache/pulsar/pull/14415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated: [C++] Fix GCC compilation failure caused by warning macro (#14402)

2022-02-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 958fc78 [C++] Fix GCC compilation failure

[GitHub] [pulsar] merlimat merged pull request #14402: [C++] Fix GCC compilation failure caused by warning macro

2022-02-22 Thread GitBox
merlimat merged pull request #14402: URL: https://github.com/apache/pulsar/pull/14402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat commented on a change in pull request #14408: Fix TableViewImpl not retrying partition update on exceptions

2022-02-22 Thread GitBox
merlimat commented on a change in pull request #14408: URL: https://github.com/apache/pulsar/pull/14408#discussion_r812378928 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java ## @@ -106,6 +106,7 @@ private void

[pulsar] branch asf-site updated: Use new source: GitHub feature

2022-02-22 Thread wave
This is an automated email from the ASF dual-hosted git repository. wave pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 41b0c8a Use new source: GitHub feature

[GitHub] [pulsar] rdhabalia commented on a change in pull request #14382: [pulsar-broker] support client configurable message chunk size

2022-02-22 Thread GitBox
rdhabalia commented on a change in pull request #14382: URL: https://github.com/apache/pulsar/pull/14382#discussion_r812254050 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java ## @@ -168,7 +168,8 @@ * will fail unless

[GitHub] [pulsar] flowchartsman commented on pull request #12316: [Issue 12314][Go Functions] Remove extra call to gi.stats.incrTotalProcessedSuccessfully()

2022-02-22 Thread GitBox
flowchartsman commented on pull request #12316: URL: https://github.com/apache/pulsar/pull/12316#issuecomment-1047895387 @freeznet done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] ericsyh opened a new pull request #14419: fix(docs): fix yaml formal in mongo-sink

2022-02-22 Thread GitBox
ericsyh opened a new pull request #14419: URL: https://github.com/apache/pulsar/pull/14419 Signed-off-by: Eric Shen ### Motivation Like the https://github.com/apache/pulsar/pull/14418, fix the yaml formal issue in mongo-sink docs. ### Modifications Fix

[GitHub] [pulsar] gaozhangmin commented on pull request #14411: [Broker] Remove dead brokers timeaverage data

2022-02-22 Thread GitBox
gaozhangmin commented on pull request #14411: URL: https://github.com/apache/pulsar/pull/14411#issuecomment-1047878206 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] ericsyh opened a new pull request #14418: fix(docs): wrong yaml format in docs

2022-02-22 Thread GitBox
ericsyh opened a new pull request #14418: URL: https://github.com/apache/pulsar/pull/14418 Signed-off-by: Eric Shen ### Motivation The `mongo-sink-config.yaml` in [How to debug Pulsar connectors](https://pulsar.apache.org/docs/en/io-debug/#debug-in-cluster-mode)

  1   2   >