[GitHub] [pulsar] yaalsn edited a comment on issue #14401: Speed up CI workflows

2022-03-17 Thread GitBox
yaalsn edited a comment on issue #14401: URL: https://github.com/apache/pulsar/issues/14401#issuecomment-1071753851 >Do you mean `Github Action Artifacts` ? No. I mean the GitHub Actions Cache. The cache is 5GB scoped for each fork which makes it optimal for caching build

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829699012 ## File path: conf/functions_worker.yml ## @@ -26,6 +26,13 @@ workerHostname: localhost workerPort: 6750 workerPortTls: 6751 +# The metadata

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829699012 ## File path: conf/functions_worker.yml ## @@ -26,6 +26,13 @@ workerHostname: localhost workerPort: 6750 workerPortTls: 6751 +# The metadata

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829709921 ## File path: conf/functions_worker.yml ## @@ -26,6 +26,13 @@ workerHostname: localhost workerPort: 6750 workerPortTls: 6751 +# The metadata

[GitHub] [pulsar] AnonHxy commented on pull request #14387: [Broker]Dynamic update topic broker-level publish-rate

2022-03-17 Thread GitBox
AnonHxy commented on pull request #14387: URL: https://github.com/apache/pulsar/pull/14387#issuecomment-1072050634 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829703439 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -780,14 +780,14 @@ public void start() throws

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829700363 ## File path: conf/functions_worker.yml ## @@ -45,6 +52,10 @@ metadataStoreCacheExpirySeconds: 300 # Function

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829699012 ## File path: conf/functions_worker.yml ## @@ -26,6 +26,13 @@ workerHostname: localhost workerPort: 6750 workerPortTls: 6751 +# The metadata

[GitHub] [pulsar] github-actions[bot] commented on pull request #14740: Fixed duplicated delayed messages when all consumers disconnect

2022-03-17 Thread GitBox
github-actions[bot] commented on pull request #14740: URL: https://github.com/apache/pulsar/pull/14740#issuecomment-1072033379 @merlimat:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] merlimat opened a new pull request #14740: Fixed duplicated delayed messages when all consumers disconnect

2022-03-17 Thread GitBox
merlimat opened a new pull request #14740: URL: https://github.com/apache/pulsar/pull/14740 ### Motivation When all consumers are disconnected (eg: for a moment there's no consumer connected) and then reconnect, the delayed messages on that topic can be delivered twice. The

[pulsar] branch master updated: Fix failed initialized METADATA_STORE_SCHEME (#14708)

2022-03-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0a38fce6 Fix failed initialized

[GitHub] [pulsar] merlimat closed issue #14690: Failed to initialize DNS Resolver org.apache.pulsar.bookie.rackawareness.BookieRackAffinityMapping

2022-03-17 Thread GitBox
merlimat closed issue #14690: URL: https://github.com/apache/pulsar/issues/14690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] merlimat merged pull request #14708: Fix failed initialized METADATA_STORE_SCHEME

2022-03-17 Thread GitBox
merlimat merged pull request #14708: URL: https://github.com/apache/pulsar/pull/14708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin removed a comment on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1072023006 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] gaozhangmin commented on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin commented on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1072027555 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Jason918 commented on pull request #14566: [client] Optimize pause when creating sub consumers in multi-topic consumer

2022-03-17 Thread GitBox
Jason918 commented on pull request #14566: URL: https://github.com/apache/pulsar/pull/14566#issuecomment-1072025973 > After creating a new `ConsumerImpl` for a topic partition, before sending `FLOW` command, client will check > > ```java > if (!(firstTimeConnect &&

[GitHub] [pulsar] Jason918 commented on a change in pull request #14566: [client] Optimize pause when creating sub consumers in multi-topic consumer

2022-03-17 Thread GitBox
Jason918 commented on a change in pull request #14566: URL: https://github.com/apache/pulsar/pull/14566#discussion_r829690543 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -1036,6 +1037,8 @@ private void

[GitHub] [pulsar] gaozhangmin commented on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin commented on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1072023006 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] lordcheng10 commented on pull request #14739: trim tokenSecretKey file path.

2022-03-17 Thread GitBox
lordcheng10 commented on pull request #14739: URL: https://github.com/apache/pulsar/pull/14739#issuecomment-1072022115 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] lordcheng10 commented on pull request #14645: Fix bug: markdelete position not moving forward when skipping lost entries

2022-03-17 Thread GitBox
lordcheng10 commented on pull request #14645: URL: https://github.com/apache/pulsar/pull/14645#issuecomment-1072022080 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] aloyszhang commented on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
aloyszhang commented on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1072021609 Ohh, I see, pulsar register the `metadata-store` scheme from broker side -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] github-actions[bot] commented on pull request #14738: [Transaction] Fix transaction pending ack store managed ledger WriteFail state

2022-03-17 Thread GitBox
github-actions[bot] commented on pull request #14738: URL: https://github.com/apache/pulsar/pull/14738#issuecomment-1072012821 @congbobo184:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[pulsar] branch master updated (c4e4ddd -> 601fbdd)

2022-03-17 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c4e4ddd [Transaction] Fix transaction buffer recover BrokerMetadataException close topic (#14709) add 601fbdd

[GitHub] [pulsar] wolfstudy merged pull request #14706: Process maxRedeliverCount is 0 of DeadLeddterPolicy

2022-03-17 Thread GitBox
wolfstudy merged pull request #14706: URL: https://github.com/apache/pulsar/pull/14706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] wolfstudy closed issue #14704: DeadLetterPolicy should not allow Redelivery Count to be set to 0

2022-03-17 Thread GitBox
wolfstudy closed issue #14704: URL: https://github.com/apache/pulsar/issues/14704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lordcheng10 opened a new pull request #14739: trim tokenSecretKey file path.

2022-03-17 Thread GitBox
lordcheng10 opened a new pull request #14739: URL: https://github.com/apache/pulsar/pull/14739 ### Motivation trim tokenSecretKey file path. ### Documentation Check the box below or label this PR directly (if you have committer privilege). Need to update docs?

[GitHub] [pulsar] github-actions[bot] commented on pull request #14738: [Transaction] Fix transaction pending ack store managed ledger WriteFail state

2022-03-17 Thread GitBox
github-actions[bot] commented on pull request #14738: URL: https://github.com/apache/pulsar/pull/14738#issuecomment-1072009879 @congbobo184:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] congbobo184 opened a new pull request #14738: [Transaction] Fix transaction pending ack store managed ledger WriteFail state

2022-03-17 Thread GitBox
congbobo184 opened a new pull request #14738: URL: https://github.com/apache/pulsar/pull/14738 like #10711 ![image](https://user-images.githubusercontent.com/39078850/158935056-e9c2d989-e209-4777-a89d-ed88e6973465.png) ## Motivation when transaction pending ack managed ledger

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14727: when consumer close and create frequently, delay message will be duplicated

2022-03-17 Thread GitBox
codelipenghui commented on a change in pull request #14727: URL: https://github.com/apache/pulsar/pull/14727#discussion_r829676764 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -307,6 +307,8 @@ public

[GitHub] [pulsar] gaozhangmin commented on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin commented on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1072000890 Unit test added. @codelipenghui @315157973 @eolivelli @aloyszhang -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] AnonHxy opened a new pull request #14737: [Broker]Move normalize to DispatchRateImpl

2022-03-17 Thread GitBox
AnonHxy opened a new pull request #14737: URL: https://github.com/apache/pulsar/pull/14737 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] Demogorgon314 commented on pull request #14727: when consumer close and create frequently, delay message will be duplicated

2022-03-17 Thread GitBox
Demogorgon314 commented on pull request #14727: URL: https://github.com/apache/pulsar/pull/14727#issuecomment-1071989566 Can we add a units test to cover this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] zymap commented on issue #14734: package still exists after calling `pulsar-admin packages delete`

2022-03-17 Thread GitBox
zymap commented on issue #14734: URL: https://github.com/apache/pulsar/issues/14734#issuecomment-1071989088 The root cause of this issue is we only introduce delete one version of the packages. When we deleted all the versions of the package, the package name still exists but no versions

[GitHub] [pulsar] Technoboy- commented on issue #14652: Subscription replication did not take effect

2022-03-17 Thread GitBox
Technoboy- commented on issue #14652: URL: https://github.com/apache/pulsar/issues/14652#issuecomment-1071988854 Hi, @468120308 , I will check. And reply later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] poorbarcode commented on issue #14734: package still exists after calling `pulsar-admin packages delete`

2022-03-17 Thread GitBox
poorbarcode commented on issue #14734: URL: https://github.com/apache/pulsar/issues/14734#issuecomment-1071987759 I can help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] mattisonchao removed a comment on issue #14734: package still exists after calling `pulsar-admin packages delete`

2022-03-17 Thread GitBox
mattisonchao removed a comment on issue #14734: URL: https://github.com/apache/pulsar/issues/14734#issuecomment-1071983474 @nlu90 I can help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] rueian edited a comment on issue #14688: Infinite loop in BlobStoreBackedReadHandleImpl

2022-03-17 Thread GitBox
rueian edited a comment on issue #14688: URL: https://github.com/apache/pulsar/issues/14688#issuecomment-1071987537 Hi, are the above stacktraces helpful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] rueian commented on issue #14688: Infinite loop in BlobStoreBackedReadHandleImpl

2022-03-17 Thread GitBox
rueian commented on issue #14688: URL: https://github.com/apache/pulsar/issues/14688#issuecomment-1071987537 Hi, is the above stack trace helpful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (3ff05b2 -> c4e4ddd)

2022-03-17 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3ff05b2 [C++ Client] Add braces around initialization of subobject (#14735) add c4e4ddd [Transaction] Fix

[GitHub] [pulsar] mattisonchao commented on issue #14734: package still exists after calling `pulsar-admin packages delete`

2022-03-17 Thread GitBox
mattisonchao commented on issue #14734: URL: https://github.com/apache/pulsar/issues/14734#issuecomment-1071983474 @nlu90 I can help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] congbobo184 merged pull request #14709: [Transaction] Fix transaction buffer recover BrokerMetadataException close topic

2022-03-17 Thread GitBox
congbobo184 merged pull request #14709: URL: https://github.com/apache/pulsar/pull/14709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#discussion_r829663601 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java ## @@ -244,7 +244,8 @@ public static void main(String[]

[GitHub] [pulsar] gaozhangmin commented on a change in pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin commented on a change in pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#discussion_r829661507 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java ## @@ -244,7 +244,8 @@ public static void main(String[]

[GitHub] [pulsar] gaozhangmin commented on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
gaozhangmin commented on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1071976491 > Mabye these is another problem if set `MetadataServiceUri` with a prefix `metadata-store:` > > ```java > bkConf.setMetadataServiceUri("metadata-store:" +

[GitHub] [pulsar] wangjialing218 commented on issue #14732: IPv6 Support for broker and proxy with bindAddress

2022-03-17 Thread GitBox
wangjialing218 commented on issue #14732: URL: https://github.com/apache/pulsar/issues/14732#issuecomment-1071971887 I have already test IPV6 connections between pulasr client and broker, as long as kafka client and kop, with `-Djava.net.preferIPv4Stack=false`, there seems no problem.

[GitHub] [pulsar] zcola edited a comment on issue #14728: [Question] will pulsar roll over if there is only one topic in a namespace

2022-03-17 Thread GitBox
zcola edited a comment on issue #14728: URL: https://github.com/apache/pulsar/issues/14728#issuecomment-1071970558 Ok, I will open another issue,However, if you only unload one of the topics of the namespace, although there is no actual practice online, then the unload namespace is an

[GitHub] [pulsar] zcola closed issue #14728: [Question] will pulsar roll over if there is only one topic in a namespace

2022-03-17 Thread GitBox
zcola closed issue #14728: URL: https://github.com/apache/pulsar/issues/14728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] zcola commented on issue #14728: [Question] will pulsar roll over if there is only one topic in a namespace

2022-03-17 Thread GitBox
zcola commented on issue #14728: URL: https://github.com/apache/pulsar/issues/14728#issuecomment-1071970558 Ok, I will open another issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] momo-jun commented on issue #13585: [Doc] add docs for "how to develop plugin" in "development" guide

2022-03-17 Thread GitBox
momo-jun commented on issue #13585: URL: https://github.com/apache/pulsar/issues/13585#issuecomment-1071965266 @codelipenghui Does this new doc-required PR #14729 have dependency on this issue? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] wangjialing218 commented on a change in pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-03-17 Thread GitBox
wangjialing218 commented on a change in pull request #14702: URL: https://github.com/apache/pulsar/pull/14702#discussion_r829649359 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java ## @@ -89,7 +89,8 @@ public void

[GitHub] [pulsar] Technoboy- commented on a change in pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-03-17 Thread GitBox
Technoboy- commented on a change in pull request #14702: URL: https://github.com/apache/pulsar/pull/14702#discussion_r829643604 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Brokers.java ## @@ -32,6 +32,41 @@ * Admin interface for

[GitHub] [pulsar] Technoboy- commented on a change in pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-03-17 Thread GitBox
Technoboy- commented on a change in pull request #14702: URL: https://github.com/apache/pulsar/pull/14702#discussion_r829643380 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/BrokersImpl.java ## @@ -42,14 +42,24 @@ public

[GitHub] [pulsar] Technoboy- commented on a change in pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-03-17 Thread GitBox
Technoboy- commented on a change in pull request #14702: URL: https://github.com/apache/pulsar/pull/14702#discussion_r829643219 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java ## @@ -104,6 +105,21 @@ public void

[GitHub] [pulsar] Technoboy- commented on a change in pull request #14702: [PulsarAdmin] add get active brokers api without cluster name

2022-03-17 Thread GitBox
Technoboy- commented on a change in pull request #14702: URL: https://github.com/apache/pulsar/pull/14702#discussion_r829642912 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java ## @@ -89,7 +89,8 @@ public void

[GitHub] [pulsar] Jason918 commented on a change in pull request #14387: [Broker]Dynamic update topic broker-level publish-rate

2022-03-17 Thread GitBox
Jason918 commented on a change in pull request #14387: URL: https://github.com/apache/pulsar/pull/14387#discussion_r829641873 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PrecisTopicPublishRateThrottleTest.java ## @@ -140,4 +141,64 @@ public void

[GitHub] [pulsar] github-actions[bot] commented on issue #14263: org.apache.pulsar.shade.io.netty.channel.ConnectTimeoutException: connection timed out

2022-03-17 Thread GitBox
github-actions[bot] commented on issue #14263: URL: https://github.com/apache/pulsar/issues/14263#issuecomment-1071946566 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #14284: when Consumer close,retryLetterProducer and deadLetterProducer will not close

2022-03-17 Thread GitBox
github-actions[bot] commented on issue #14284: URL: https://github.com/apache/pulsar/issues/14284#issuecomment-1071946551 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #14285: [Doc search] Missing search results in 2.9.1 Documentation

2022-03-17 Thread GitBox
github-actions[bot] commented on issue #14285: URL: https://github.com/apache/pulsar/issues/14285#issuecomment-1071946542 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #14295: Adding Ectd integration tests

2022-03-17 Thread GitBox
github-actions[bot] commented on issue #14295: URL: https://github.com/apache/pulsar/issues/14295#issuecomment-1071946532 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] madhavan-narayanan commented on pull request #14613: pulsar-broker: Intercept transaction begin and end events for observability

2022-03-17 Thread GitBox
madhavan-narayanan commented on pull request #14613: URL: https://github.com/apache/pulsar/pull/14613#issuecomment-1071943693 > @madhavan-narayanan Maybe we could add a new param `Object context` for method `onPulsarCommand` to make it‘s suitable for more cases. I'm concerned that we need

[GitHub] [pulsar] anant-ahuja commented on issue #14548: Pulsar Client can connect to Pulsar Proxy but not the Pulsar brokers

2022-03-17 Thread GitBox
anant-ahuja commented on issue #14548: URL: https://github.com/apache/pulsar/issues/14548#issuecomment-1071886442 @lhotari Pulsar 2.7.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] drunksaint commented on issue #6477: Python client `consumer.reveive()` call suspends processing of interrupts within the program

2022-03-17 Thread GitBox
drunksaint commented on issue #6477: URL: https://github.com/apache/pulsar/issues/6477#issuecomment-1071841607 i'm facing the same problem in 2.9.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] aloyszhang edited a comment on pull request #14686: Fix error setMetadataServiceUri

2022-03-17 Thread GitBox
aloyszhang edited a comment on pull request #14686: URL: https://github.com/apache/pulsar/pull/14686#issuecomment-1070806113 Mabye these is another problem if set `MetadataServiceUri` with a prefix `metadata-store:` ```java bkConf.setMetadataServiceUri("metadata-store:" +

[GitHub] [pulsar] yaalsn commented on issue #14401: Speed up CI workflows

2022-03-17 Thread GitBox
yaalsn commented on issue #14401: URL: https://github.com/apache/pulsar/issues/14401#issuecomment-1071753851 > @yaalsn There's a proposal and proof-of-concept that I performed about a year ago: https://docs.google.com/document/d/1FNEWD3COdnNGMiryO9qBUW_83qtzAhqjDI5wwmPD-YE/edit . I'll

[GitHub] [pulsar] michaeljmarshall commented on issue #13429: Release procedure: Building OSX packages is broken, at least in 2.9.1

2022-03-17 Thread GitBox
michaeljmarshall commented on issue #13429: URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1071734304 @BewareMyPower - thanks for your note. That was very helpful. I was able to build the clients for MacOS 10.12 and 10.13 by removing that argument.

[pulsar] branch branch-2.7 updated: [C++ Client] Add braces around initialization of subobject (#14735)

2022-03-17 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new 475994a [C++ Client] Add braces

[pulsar] branch branch-2.9 updated: [C++ Client] Add braces around initialization of subobject (#14735)

2022-03-17 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.9 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.9 by this push: new 131b455 [C++ Client] Add braces

[pulsar] branch branch-2.8 updated: [C++ Client] Add braces around initialization of subobject (#14735)

2022-03-17 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new 906603d [C++ Client] Add braces

[pulsar] branch branch-2.10 updated: [C++ Client] Add braces around initialization of subobject (#14735)

2022-03-17 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 6dc733b [C++ Client] Add braces

[pulsar] branch master updated (a269053 -> 3ff05b2)

2022-03-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a269053 Support JAVA_HOME in env file when check java version (#14711) add 3ff05b2 [C++ Client] Add braces

[GitHub] [pulsar] merlimat merged pull request #14735: [C++ Client] Add braces around initialization of subobject

2022-03-17 Thread GitBox
merlimat merged pull request #14735: URL: https://github.com/apache/pulsar/pull/14735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] utahkay opened a new issue #14736: [2.10] After zookeeper reconnect, brokers get caught in a loop revalidating locks, slowing message delivery and consuming heap until OOM

2022-03-17 Thread GitBox
utahkay opened a new issue #14736: URL: https://github.com/apache/pulsar/issues/14736 **Describe the bug** Pulsar 2.10 introduces the zookeeperSessionExpiredPolicy=reconnect option. If the zookeeper session is disconnected, the brokers will continue running with as much functionality

[GitHub] [pulsar] michaeljmarshall commented on pull request #14735: [C++ Client] Add braces around initialization of subobject

2022-03-17 Thread GitBox
michaeljmarshall commented on pull request #14735: URL: https://github.com/apache/pulsar/pull/14735#issuecomment-1071310831 @BewareMyPower @merlimat @oversearch - are you able to confirm that this is a correct change? I am just following the compiler instructions. -- This is an

[GitHub] [pulsar] michaeljmarshall opened a new pull request #14735: [C++ Client] Add braces around initialization of subobject

2022-03-17 Thread GitBox
michaeljmarshall opened a new pull request #14735: URL: https://github.com/apache/pulsar/pull/14735 Master Issue: https://github.com/apache/pulsar/issues/13429 ### Motivation While preparing the 2.8.3 python client release, I encountered the following error: ```

[GitHub] [pulsar] lhotari commented on a change in pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari commented on a change in pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#discussion_r829310927 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java ## @@ -123,67 +128,52 @@ protected void

[GitHub] [pulsar] lhotari edited a comment on pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari edited a comment on pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#issuecomment-1071114661 The channel writability change feature in Netty can be configured with `setWriteBufferWaterMark` or `setWriteBufferLowWaterMark`/`setWriteBufferHighWaterMark` methods.

[GitHub] [pulsar] lhotari commented on pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari commented on pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#issuecomment-1071114661 The channel writability change can be configured with `setWriteBufferWaterMark` or `setWriteBufferLowWaterMark`/`setWriteBufferHighWaterMark` methods. By default, the low

[GitHub] [pulsar] nlu90 opened a new issue #14734: package still exists after calling `pulsar-admin packages delete`

2022-03-17 Thread GitBox
nlu90 opened a new issue #14734: URL: https://github.com/apache/pulsar/issues/14734 **Describe the bug** After using `admin packages` delete a package, I can still list the deleted package: ``` ➜ apache-pulsar-2.9.1 ./bin/pulsar-admin packages delete

[GitHub] [pulsar] nlu90 commented on a change in pull request #14450: [Function] Integrate package management service to pulsar functionWorker

2022-03-17 Thread GitBox
nlu90 commented on a change in pull request #14450: URL: https://github.com/apache/pulsar/pull/14450#discussion_r829289750 ## File path: conf/functions_worker.yml ## @@ -26,6 +26,13 @@ workerHostname: localhost workerPort: 6750 workerPortTls: 6751 +# The metadata store URL

[GitHub] [pulsar] lhotari commented on pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari commented on pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#issuecomment-1071102605 @merlimat I have implemented the solution for flow control in a04aa5f . Please review -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14729: [Client] Support Reader Interceptor

2022-03-17 Thread GitBox
gaoran10 commented on a change in pull request #14729: URL: https://github.com/apache/pulsar/pull/14729#discussion_r829281990 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderBuilderImpl.java ## @@ -229,4 +230,26 @@ private

[GitHub] [pulsar] gaoran10 commented on pull request #14729: [Client] Support Reader Interceptor

2022-03-17 Thread GitBox
gaoran10 commented on pull request #14729: URL: https://github.com/apache/pulsar/pull/14729#issuecomment-1071098637 @315157973 Yes, normally, we'd better separate the auto-update partition configurations to another PR, but it's a little hard to check the `onPartitionsChange` event because

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14729: [Client] Support Reader Interceptor

2022-03-17 Thread GitBox
gaoran10 commented on a change in pull request #14729: URL: https://github.com/apache/pulsar/pull/14729#discussion_r829281990 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderBuilderImpl.java ## @@ -229,4 +230,26 @@ private

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14729: [Client] Support Reader Interceptor

2022-03-17 Thread GitBox
gaoran10 commented on a change in pull request #14729: URL: https://github.com/apache/pulsar/pull/14729#discussion_r829280353 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderInterceptorUtil.java ## @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] BewareMyPower commented on pull request #14604: [C++] add chunk message id

2022-03-17 Thread GitBox
BewareMyPower commented on pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#issuecomment-1071075013 I will check the compile failure on Windows x64 soon. But your code doesn't pass the format check as well, please format the code via `clang-format`. -- This

[GitHub] [pulsar] lhotari commented on pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari commented on pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#issuecomment-1071056333 I asked for feedback in the community meeting from @merlimat . Based on the discussion there was the conclusion that backpressure is needed to prevent a situation where the

[GitHub] [pulsar] lhotari edited a comment on pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari edited a comment on pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#issuecomment-1071027004 I ended up increasing the scope of this PR and added the fix to a connection stalling issue. Please review again @eolivelli @codelipenghui @michaeljmarshall

[GitHub] [pulsar] eolivelli commented on a change in pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
eolivelli commented on a change in pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#discussion_r829232363 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java ## @@ -123,67 +128,52 @@ protected void

[GitHub] [pulsar] lhotari commented on pull request #14713: [Proxy] Refactor Proxy code and fix connection stalling by switching to auto read mode

2022-03-17 Thread GitBox
lhotari commented on pull request #14713: URL: https://github.com/apache/pulsar/pull/14713#issuecomment-1071027004 I ended up increasing the scope of this PR and add the fix to a connection stalling issue. Please review again @eolivelli @codelipenghui @michaeljmarshall @nicoloboschi

[GitHub] [pulsar] kezhenxu94 commented on pull request #14005: Add arm64 Docker images

2022-03-17 Thread GitBox
kezhenxu94 commented on pull request #14005: URL: https://github.com/apache/pulsar/pull/14005#issuecomment-1071025733 > @kezhenxu94 Is there anything that can be done to help get things working? I think the build should be working. Just need to get the CI passed. Kind of busy

[GitHub] [pulsar] lhotari commented on issue #14401: Speed up CI workflows

2022-03-17 Thread GitBox
lhotari commented on issue #14401: URL: https://github.com/apache/pulsar/issues/14401#issuecomment-1071002899 @yaalsn There's a proposal and proof-of-concept that I performed about a year ago: https://docs.google.com/document/d/1FNEWD3COdnNGMiryO9qBUW_83qtzAhqjDI5wwmPD-YE/edit . I'll

[GitHub] [pulsar] lhotari commented on issue #14548: Pulsar Client can connect to Pulsar Proxy but not the Pulsar brokers

2022-03-17 Thread GitBox
lhotari commented on issue #14548: URL: https://github.com/apache/pulsar/issues/14548#issuecomment-1070998246 @anant-ahuja What version of Pulsar are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] sit commented on pull request #14005: Add arm64 Docker images

2022-03-17 Thread GitBox
sit commented on pull request #14005: URL: https://github.com/apache/pulsar/pull/14005#issuecomment-1070987762 @kezhenxu94 Is there anything that can be done to help get things working? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] gaoran10 commented on pull request #14613: pulsar-broker: Intercept transaction begin and end events for observability

2022-03-17 Thread GitBox
gaoran10 commented on pull request #14613: URL: https://github.com/apache/pulsar/pull/14613#issuecomment-1070981362 @madhavan-narayanan Maybe we could add a new param `Object context` for method `onPulsarCommand` to make it‘s suitable for more cases. I'm concerned that we need to add too

[GitHub] [pulsar] lhotari commented on issue #14714: cpp-tests job is flaky: python pulsar_test.py fails with Segmentation fault

2022-03-17 Thread GitBox
lhotari commented on issue #14714: URL: https://github.com/apache/pulsar/issues/14714#issuecomment-1070960229 > I'm going to work on these cpp tests first. Thank you @BewareMyPower -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] eolivelli commented on issue #14732: IPv6 Support for broker and proxy with bindAddress

2022-03-17 Thread GitBox
eolivelli commented on issue #14732: URL: https://github.com/apache/pulsar/issues/14732#issuecomment-1070942935 I believe that it is only because support for IPV6 is not fully available in many libraries (like parsing addresses..) and no one dares to enable it. If you are able to

[GitHub] [pulsar] bpereto commented on issue #14732: IPv6 Support for broker and proxy with bindAddress

2022-03-17 Thread GitBox
bpereto commented on issue #14732: URL: https://github.com/apache/pulsar/issues/14732#issuecomment-1070939771 jup, this works. set `bindAddress=0.0.0.0` in proxy.conf and removing `-Djava.net.preferIPv4Stack=true` in `bin/pulsar` is indeed working. why is the setting

[GitHub] [pulsar] asardaes opened a new issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

2022-03-17 Thread GitBox
asardaes opened a new issue #14733: URL: https://github.com/apache/pulsar/issues/14733 I'm using an admin client configured with a cert/key pair file and a trusted certificate file, the latter of which is a bundle with multiple certificates. From what I can tell, the client is created

[pulsar] branch master updated (bcbeb53 -> a269053)

2022-03-17 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bcbeb53 Fix update replication cluster but not update replicator. (#14570) add a269053 Support JAVA_HOME

[GitHub] [pulsar] eolivelli commented on issue #14732: IPv6 Support for broker and proxy with bindAddress

2022-03-17 Thread GitBox
eolivelli commented on issue #14732: URL: https://github.com/apache/pulsar/issues/14732#issuecomment-1070916536 if I remove all the occurrences of "-Djava.net.preferIPv4Stack=true" inside "bin" (or you can set it to "false") then I am able to boot Pulsar standalone and the proxy on my

  1   2   >