[GitHub] [pulsar] eolivelli commented on pull request #15142: WIP: Pulsar with Bk 4.15 (4.16-snapshot currently, as a placeholder for rc1 of 4.15)

2022-04-12 Thread GitBox
eolivelli commented on PR #15142: URL: https://github.com/apache/pulsar/pull/15142#issuecomment-1097576575 You can add the repository for bk 4.15.0 rc0 Like I did here

[GitHub] [pulsar-client-go] crossoverJie commented on a diff in pull request #753: [Issue 664] fix ReconsumeLater panic

2022-04-12 Thread GitBox
crossoverJie commented on code in PR #753: URL: https://github.com/apache/pulsar-client-go/pull/753#discussion_r849090255 ## pulsar/consumer_test.go: ## @@ -3017,3 +3017,59 @@ func TestEncryptDecryptRedeliveryOnFailure(t *testing.T) { assert.NotNil(t, msg)

[GitHub] [pulsar-client-go] crossoverJie commented on a diff in pull request #753: [Issue 664] fix ReconsumeLater panic

2022-04-12 Thread GitBox
crossoverJie commented on code in PR #753: URL: https://github.com/apache/pulsar-client-go/pull/753#discussion_r849090157 ## pulsar/consumer_test.go: ## @@ -3017,3 +3017,59 @@ func TestEncryptDecryptRedeliveryOnFailure(t *testing.T) { assert.NotNil(t, msg)

[pulsar] branch master updated: log transaction rest api error on broker side (#15081)

2022-04-12 Thread zhangmingao
This is an automated email from the ASF dual-hosted git repository. zhangmingao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 19120e6b00e log transaction rest api

[GitHub] [pulsar] gaozhangmin merged pull request #15081: [improve][transaction] Add logs for REST API in transaction

2022-04-12 Thread GitBox
gaozhangmin merged PR #15081: URL: https://github.com/apache/pulsar/pull/15081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] mattisonchao commented on pull request #15062: [fix] [broker] fix duplicate calculation for msgRateIn and msgThroughputIn in replication PROM metric

2022-04-12 Thread GitBox
mattisonchao commented on PR #15062: URL: https://github.com/apache/pulsar/pull/15062#issuecomment-1097566849 Hi @HQebupt This issue's root cause looks like we add `msgRateIn` and `msgThroughputIn` status twice. the code is shown below: Position 1:

[GitHub] [pulsar] Shoothzj closed pull request #14651: Bump netty version to 4.1.75

2022-04-12 Thread GitBox
Shoothzj closed pull request #14651: Bump netty version to 4.1.75 URL: https://github.com/apache/pulsar/pull/14651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] Shoothzj commented on pull request #14651: Bump netty version to 4.1.75

2022-04-12 Thread GitBox
Shoothzj commented on PR #14651: URL: https://github.com/apache/pulsar/pull/14651#issuecomment-1097563124 we need to update bookkeeper to bump netty version, closed this for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Shawyeok commented on pull request #15145: [pulsar-client-tools] Ability to send a message with null body

2022-04-12 Thread GitBox
Shawyeok commented on PR #15145: URL: https://github.com/apache/pulsar/pull/15145#issuecomment-1097556976 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15140: [transaction][monitor] Add metrics for transaction

2022-04-12 Thread GitBox
congbobo184 commented on code in PR #15140: URL: https://github.com/apache/pulsar/pull/15140#discussion_r849060142 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java: ## @@ -42,6 +42,9 @@ class TopicStats { long bytesOutCounter;

[GitHub] [pulsar] liudezhi2098 commented on pull request #14756: [metrics] Metrics http interface unified authentication configuration

2022-04-12 Thread GitBox
liudezhi2098 commented on PR #14756: URL: https://github.com/apache/pulsar/pull/14756#issuecomment-1097542321 @gaozhangmin Please help review this PR again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-client-go] wolfstudy commented on a diff in pull request #734: [Issue 718] Fix nil pointer dereference in TopicNameWithoutPartitionPart

2022-04-12 Thread GitBox
wolfstudy commented on code in PR #734: URL: https://github.com/apache/pulsar-client-go/pull/734#discussion_r849052252 ## pulsar/internal/topic_name.go: ## @@ -107,6 +107,9 @@ func ParseTopicName(topic string) (*TopicName, error) { } func TopicNameWithoutPartitionPart(tn

[GitHub] [pulsar-client-go] wolfstudy commented on a diff in pull request #734: [Issue 718] Fix nil pointer dereference in TopicNameWithoutPartitionPart

2022-04-12 Thread GitBox
wolfstudy commented on code in PR #734: URL: https://github.com/apache/pulsar-client-go/pull/734#discussion_r849051366 ## pulsar/internal/topic_name.go: ## @@ -107,6 +107,9 @@ func ParseTopicName(topic string) (*TopicName, error) { } func TopicNameWithoutPartitionPart(tn

[GitHub] [pulsar] Shawyeok opened a new pull request, #15145: [pulsar-client-tools] Ability to send a message with null body

2022-04-12 Thread GitBox
Shawyeok opened a new pull request, #15145: URL: https://github.com/apache/pulsar/pull/15145 ### Motivation Now it's not possible use `pulsar-client produce` send a message with `null` body, but it's needed in some scenes, e.g. delete topic policy manually or test topic compaction.

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #737: [issue 679][oauth2] Fix macos compiler warnings, remove store impleme…

2022-04-12 Thread GitBox
wolfstudy commented on PR #737: URL: https://github.com/apache/pulsar-client-go/pull/737#issuecomment-1097527139 cc @zymap Please take a look thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-go] wolfstudy commented on issue #752: Update license txt files to reflect updated dependency (go-rate)

2022-04-12 Thread GitBox
wolfstudy commented on issue #752: URL: https://github.com/apache/pulsar-client-go/issues/752#issuecomment-1097524716 > Good point. I think we need to have a tool that automatically updates this license file from the dependencies and we should check in the PR that it's consistent.

[pulsar-client-go] branch master updated (0b0b312 -> 5ced071)

2022-04-12 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git from 0b0b312 Dlq producer on topic with schema (#723) add 5ced071 fix annotation typo (#758) No new

[GitHub] [pulsar-client-go] wolfstudy merged pull request #758: fix annotation typo in consumer.go

2022-04-12 Thread GitBox
wolfstudy merged PR #758: URL: https://github.com/apache/pulsar-client-go/pull/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #753: [Issue 664] fix ReconsumeLater panic

2022-04-12 Thread GitBox
wolfstudy commented on PR #753: URL: https://github.com/apache/pulsar-client-go/pull/753#issuecomment-1097524096 > @shileiyu It's a good idea. If `RetryEnable==true` in the Java SDK, a default policy is created.

[GitHub] [pulsar-client-go] wolfstudy commented on a diff in pull request #753: [Issue 664] fix ReconsumeLater panic

2022-04-12 Thread GitBox
wolfstudy commented on code in PR #753: URL: https://github.com/apache/pulsar-client-go/pull/753#discussion_r849044794 ## pulsar/consumer_test.go: ## @@ -3017,3 +3017,59 @@ func TestEncryptDecryptRedeliveryOnFailure(t *testing.T) { assert.NotNil(t, msg)

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #750: [Issue 749]Fix panic caused by flushing current batch with an incorrect internal function.

2022-04-12 Thread GitBox
wolfstudy commented on PR #750: URL: https://github.com/apache/pulsar-client-go/pull/750#issuecomment-1097521388 @shileiyu Greate jobs! Can we add unit test to cover this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar-client-go] branch master updated: Dlq producer on topic with schema (#723)

2022-04-12 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 0b0b312 Dlq producer on topic with

[GitHub] [pulsar-client-go] wolfstudy merged pull request #723: Dlq producer on topic with schema

2022-04-12 Thread GitBox
wolfstudy merged PR #723: URL: https://github.com/apache/pulsar-client-go/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tjiuming commented on a diff in pull request #13833: Offloader metrics

2022-04-12 Thread GitBox
tjiuming commented on code in PR #13833: URL: https://github.com/apache/pulsar/pull/13833#discussion_r849033916 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloaderStats.java: ## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pulsar] BewareMyPower commented on pull request #15144: [enhence] [client-consumer] Always handle notifyPendingReceivedCallback in internalPinnedExecutor.

2022-04-12 Thread GitBox
BewareMyPower commented on PR #15144: URL: https://github.com/apache/pulsar/pull/15144#issuecomment-1097502964 Currently, zero queue consumer cannot receive batched messages. It is intended, otherwise it should be a consumer whose queue size is 1. The

[pulsar] branch branch-2.8 updated: Fix MemoryLimitTest for branch-2.8 (#15138)

2022-04-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.8 by this push: new bb7670b20d8 Fix MemoryLimitTest for

[GitHub] [pulsar] codelipenghui merged pull request #15138: [fix][test] Fix MemoryLimitTest for branch-2.8

2022-04-12 Thread GitBox
codelipenghui merged PR #15138: URL: https://github.com/apache/pulsar/pull/15138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on pull request #15064: [feat][connector] Support 4paradigm/OpenMLDB jdbc sink connector

2022-04-12 Thread GitBox
codelipenghui commented on PR #15064: URL: https://github.com/apache/pulsar/pull/15064#issuecomment-1097501546 @vagetablechicken could you please help check the failed `OWASP Dependency Check` test? I'm not sure if it was introduced by new dependencies, maybe you can try to rebase to the

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #15139: [fix][broker]Fix create topic fail deadlock

2022-04-12 Thread GitBox
gaozhangmin commented on code in PR #15139: URL: https://github.com/apache/pulsar/pull/15139#discussion_r849028068 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -1443,10 +1443,10 @@ public void openLedgerComplete(ManagedLedger ledger,

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #14756: [metrics] Metrics http interface unified authentication configuration

2022-04-12 Thread GitBox
gaozhangmin commented on code in PR #14756: URL: https://github.com/apache/pulsar/pull/14756#discussion_r849026358 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -2288,6 +2288,12 @@ public class ServiceConfiguration implements

[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #14756: [metrics] Metrics http interface unified authentication configuration

2022-04-12 Thread GitBox
gaozhangmin commented on code in PR #14756: URL: https://github.com/apache/pulsar/pull/14756#discussion_r849026358 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -2288,6 +2288,12 @@ public class ServiceConfiguration implements

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15139: [fix][broker]Fix create topic fail deadlock

2022-04-12 Thread GitBox
HQebupt commented on code in PR #15139: URL: https://github.com/apache/pulsar/pull/15139#discussion_r849026303 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -1443,10 +1443,10 @@ public void openLedgerComplete(ManagedLedger ledger,

[GitHub] [pulsar] gaozhangmin commented on pull request #15139: [fix][broker]Fix create topic fail deadlock

2022-04-12 Thread GitBox
gaozhangmin commented on PR #15139: URL: https://github.com/apache/pulsar/pull/15139#issuecomment-1097495881 LGTM, I'd like to point out that `createNonPersistentTopic` had fix this bug already.

[GitHub] [pulsar] nodece commented on pull request #14798: [improve][security] Add load multiple certificates support

2022-04-12 Thread GitBox
nodece commented on PR #14798: URL: https://github.com/apache/pulsar/pull/14798#issuecomment-1097494862 @michaeljmarshall Good catch, this PR has been changed, could you review this PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] zymap commented on pull request #15063: [improve][tiered storage] Reduce cpu usage when offloading the ledger

2022-04-12 Thread GitBox
zymap commented on PR #15063: URL: https://github.com/apache/pulsar/pull/15063#issuecomment-1097493054 @hangc0276 @horizonzy Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[pulsar] branch master updated: [fix][security] Remove log4j for CVE-2022-23307 (#15109)

2022-04-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a4c4aea993a [fix][security] Remove log4j for

[GitHub] [pulsar] codelipenghui merged pull request #15109: [fix][security] Remove log4j for CVE-2022-23307

2022-04-12 Thread GitBox
codelipenghui merged PR #15109: URL: https://github.com/apache/pulsar/pull/15109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] jiazhai commented on pull request #14756: [metrics] Metrics http interface unified authentication configuration

2022-04-12 Thread GitBox
jiazhai commented on PR #14756: URL: https://github.com/apache/pulsar/pull/14756#issuecomment-1097482854 [cpp test](https://github.com/apache/pulsar/runs/5983558878?check_suite_focus=true) failed with error, restart the ci ``` [225/287]

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #14398: Added 2.10.0 release note

2022-04-12 Thread GitBox
Anonymitaet commented on code in PR #14398: URL: https://github.com/apache/pulsar/pull/14398#discussion_r848998528 ## site2/website/release-notes.md: ## @@ -1,6 +1,301 @@ ## Apache Pulsar Release Notes +### 2.10.0 + 2022-04-13 + +### Important notice +- Remove

[GitHub] [pulsar] github-actions[bot] commented on pull request #15144: [enhence] [client-consumer] Always handle notifyPendingReceivedCallback in internalPinnedExecutor.

2022-04-12 Thread GitBox
github-actions[bot] commented on PR #15144: URL: https://github.com/apache/pulsar/pull/15144#issuecomment-1097476240 @horizonzy:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] github-actions[bot] commented on pull request #15144: [enhence] [client-consumer] Always handle notifyPendingReceivedCallback in internalPinnedExecutor.

2022-04-12 Thread GitBox
github-actions[bot] commented on PR #15144: URL: https://github.com/apache/pulsar/pull/15144#issuecomment-1097474886 @horizonzy:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] horizonzy commented on pull request #15144: [enhence] [client-consumer] Always handle notifyPendingReceivedCallback in internalPinnedExecutor.

2022-04-12 Thread GitBox
horizonzy commented on PR #15144: URL: https://github.com/apache/pulsar/pull/15144#issuecomment-1097471001 @BewareMyPower @michaeljmarshall cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] horizonzy opened a new pull request, #15144: [enhence] [client-consumer] Always handle notifyPendingReceivedCallback in internalPinnedExecutor.

2022-04-12 Thread GitBox
horizonzy opened a new pull request, #15144: URL: https://github.com/apache/pulsar/pull/15144 ### Motivation Handle notifyPendingReceivedCallback in internalPinnedExecutor. ### Documentation - [ ] `no-need-doc` -- This is an automated message from the Apache Git Service.

[pulsar-manager] branch master updated: Add support for casdoor (#446)

2022-04-12 Thread guangning
This is an automated email from the ASF dual-hosted git repository. guangning pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git The following commit(s) were added to refs/heads/master by this push: new 4ab8811 Add support for casdoor

[GitHub] [pulsar] Anonymitaet commented on pull request #15140: [transaction][monitor] Add metrics for transaction

2022-04-12 Thread GitBox
Anonymitaet commented on PR #15140: URL: https://github.com/apache/pulsar/pull/15140#issuecomment-1097468432 @momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] liangyepianzhou closed pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic

2022-04-12 Thread GitBox
liangyepianzhou closed pull request #14911: [Fix][Transaction] Optimize log when create transaction systemTopic URL: https://github.com/apache/pulsar/pull/14911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] horizonzy closed issue #15106: message maybe discard when pending receives all done.

2022-04-12 Thread GitBox
horizonzy closed issue #15106: message maybe discard when pending receives all done. URL: https://github.com/apache/pulsar/issues/15106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] horizonzy commented on pull request #15107: [enhance] [client-consumer] Enhance robustness in consumer executeNotifyCallback.

2022-04-12 Thread GitBox
horizonzy commented on PR #15107: URL: https://github.com/apache/pulsar/pull/15107#issuecomment-1097465147 Thanks all reviewd, I got it. This enhancement looks unnecessary, close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] horizonzy closed pull request #15107: [enhance] [client-consumer] Enhance robustness in consumer executeNotifyCallback.

2022-04-12 Thread GitBox
horizonzy closed pull request #15107: [enhance] [client-consumer] Enhance robustness in consumer executeNotifyCallback. URL: https://github.com/apache/pulsar/pull/15107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] codelipenghui commented on pull request #14756: [metrics] Metrics http interface unified authentication configuration

2022-04-12 Thread GitBox
codelipenghui commented on PR #14756: URL: https://github.com/apache/pulsar/pull/14756#issuecomment-1097462498 @eolivelli Please help review this PR again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] liudezhi2098 commented on pull request #15129: [Authenticate] optimization getHostName correct when use broker ip in Kerberos authentication

2022-04-12 Thread GitBox
liudezhi2098 commented on PR #15129: URL: https://github.com/apache/pulsar/pull/15129#issuecomment-1097457422 > Thanks, @liudezhi2098 for the help. Why this change will fix this issue? Would you please help provide more information in the PR description? such as the reason behind the

[GitHub] [pulsar] liudezhi2098 commented on a diff in pull request #15121: [Authenticate] fix Invalid signature error when use Kerberos Authentication

2022-04-12 Thread GitBox
liudezhi2098 commented on code in PR #15121: URL: https://github.com/apache/pulsar/pull/15121#discussion_r848991282 ## conf/broker.conf: ## @@ -767,6 +767,9 @@ saslJaasClientAllowedIds= # Default value `SaslConstants.JAAS_DEFAULT_BROKER_SECTION_NAME`, which is "Broker".

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15121: [Authenticate] fix Invalid signature error when use Kerberos Authentication

2022-04-12 Thread GitBox
codelipenghui commented on code in PR #15121: URL: https://github.com/apache/pulsar/pull/15121#discussion_r848990644 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -1438,6 +1438,12 @@ public class ServiceConfiguration implements

[GitHub] [pulsar] jiazhai commented on pull request #15129: [Authenticate] optimization getHostName correct when use broker ip in Kerberos authentication

2022-04-12 Thread GitBox
jiazhai commented on PR #15129: URL: https://github.com/apache/pulsar/pull/15129#issuecomment-1097453543 Thanks, @liudezhi2098 for the help. Why this change will fix this issue? Would you please help provide more information in the PR description? such as the reason behind the original

[pulsar] branch master updated: fix debug log authenticate role error (#14784)

2022-04-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 97b7e77a907 fix debug log authenticate role

[GitHub] [pulsar] codelipenghui merged pull request #14784: [Authenticate] fix debug log authenticate role error

2022-04-12 Thread GitBox
codelipenghui merged PR #14784: URL: https://github.com/apache/pulsar/pull/14784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] github-actions[bot] commented on pull request #15143: [pulsar-client] Add message chunking configuration for reader

2022-04-12 Thread GitBox
github-actions[bot] commented on PR #15143: URL: https://github.com/apache/pulsar/pull/15143#issuecomment-1097414878 @rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] rdhabalia opened a new pull request, #15143: [pulsar-client] Add message chunking configuration for reader

2022-04-12 Thread GitBox
rdhabalia opened a new pull request, #15143: URL: https://github.com/apache/pulsar/pull/15143 ### Motivation Pulsar readers can also read large message and can utilize message chunking feature. however, reader doesn't have chunking config to tune message-chunking feature based on

[GitHub] [pulsar] dlg99 opened a new pull request, #15142: WIP: Pulsar with Bk 4.15 (4.16-snapshot currently, as a placeholder for rc1 of 4.15)

2022-04-12 Thread GitBox
dlg99 opened a new pull request, #15142: URL: https://github.com/apache/pulsar/pull/15142 ### Modifications DRAFT. do not merge. Upgraded BK to 4.15 (4.16-snapshot currently, as a placeholder for rc1 of 4.15) Upgraded dependendencies, where applicable (license check to

[GitHub] [pulsar] github-actions[bot] commented on pull request #15141: [pulsar-broker] Fix delete empty namespace with partitioned-topic metadata

2022-04-12 Thread GitBox
github-actions[bot] commented on PR #15141: URL: https://github.com/apache/pulsar/pull/15141#issuecomment-1097277313 @rdhabalia:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] rdhabalia opened a new pull request, #15141: [pulsar-broker] Fix delete empty namespace with partitioned-topic metadata

2022-04-12 Thread GitBox
rdhabalia opened a new pull request, #15141: URL: https://github.com/apache/pulsar/pull/15141 ### Motivation Right now, broker gives below error while deleting empty namespace without any topic under the namespace but namespace was having partitioned-topic metadata. ```

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #14798: [improve][security] Add load multiple certificates support

2022-04-12 Thread GitBox
michaeljmarshall commented on code in PR #14798: URL: https://github.com/apache/pulsar/pull/14798#discussion_r848710067 ## pulsar-common/src/test/java/org/apache/pulsar/common/util/TrustManagerProxyTest.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software

[GitHub] [pulsar] michaeljmarshall commented on pull request #15107: [enhance] [client-consumer] Enhance robustness in consumer executeNotifyCallback.

2022-04-12 Thread GitBox
michaeljmarshall commented on PR #15107: URL: https://github.com/apache/pulsar/pull/15107#issuecomment-1097037259 @horizonzy - given that there is no race because the use of a single thread for updating `pendingRecieves` is intentionally part of this class's design, I don't think there is

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#ec38211)

2022-04-12 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new aacd25ffc9 Docs sync done from

[GitHub] [pulsar] github-actions[bot] commented on pull request #15140: [transaction][monitor] Add metrics for transaction

2022-04-12 Thread GitBox
github-actions[bot] commented on PR #15140: URL: https://github.com/apache/pulsar/pull/15140#issuecomment-1097018691 @tjiuming:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] github-actions[bot] commented on pull request #15140: [transaction][monitor] Add metrics for transaction

2022-04-12 Thread GitBox
github-actions[bot] commented on PR #15140: URL: https://github.com/apache/pulsar/pull/15140#issuecomment-1097018239 @tjiuming:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] tjiuming commented on pull request #15140: [transaction][monitor] Add metrics for transaction

2022-04-12 Thread GitBox
tjiuming commented on PR #15140: URL: https://github.com/apache/pulsar/pull/15140#issuecomment-1096997618 Tests to be completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] tjiuming opened a new pull request, #15140: [transaction][monitor] Add metrics for transaction

2022-04-12 Thread GitBox
tjiuming opened a new pull request, #15140: URL: https://github.com/apache/pulsar/pull/15140 ### Motivation Add metrics for transaction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] dave2wave commented on issue #14934: Twitter Source Working and Documentation

2022-04-12 Thread GitBox
dave2wave commented on issue #14934: URL: https://github.com/apache/pulsar/issues/14934#issuecomment-1096994334 Do your credentials have a maximum messages per month? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] michaeljmarshall commented on pull request #15122: Add a cache of versioned KeyValueSchemaImpl

2022-04-12 Thread GitBox
michaeljmarshall commented on PR #15122: URL: https://github.com/apache/pulsar/pull/15122#issuecomment-1096985919 @cbornet - in that case, I don't think this PR should be labeled as fixing #15118. It seems you've identified two problems, and we should fix both. One question about

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15067: [ML] Follow up on race condition fixes in ManagedCursorImpl #15031

2022-04-12 Thread GitBox
michaeljmarshall commented on code in PR #15067: URL: https://github.com/apache/pulsar/pull/15067#discussion_r848638415 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -1793,6 +1830,34 @@ protected void

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #15067: [ML] Follow up on race condition fixes in ManagedCursorImpl #15031

2022-04-12 Thread GitBox
michaeljmarshall commented on code in PR #15067: URL: https://github.com/apache/pulsar/pull/15067#discussion_r848638415 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java: ## @@ -1793,6 +1830,34 @@ protected void

[GitHub] [pulsar] lhotari commented on pull request #15067: [ML] Follow up on race condition fixes in ManagedCursorImpl #15031

2022-04-12 Thread GitBox
lhotari commented on PR #15067: URL: https://github.com/apache/pulsar/pull/15067#issuecomment-1096955264 > > **This is wrong since the meaning of the field is not what one would expect it to be.** > > @lhotari - are you able to describe the meaning of the field more? I was

[GitHub] [pulsar] AnonHxy opened a new pull request, #15139: [fix][broker]Fix create topic fail deadlock

2022-04-12 Thread GitBox
AnonHxy opened a new pull request, #15139: URL: https://github.com/apache/pulsar/pull/15139 Fixs #15131 ### Motivation Fix #15131 ### Modifications `topics` remove in another thread ### Verifying this change - [x] Make sure that the change

[GitHub] [pulsar] michaeljmarshall commented on pull request #15067: [ML] Follow up on race condition fixes in ManagedCursorImpl #15031

2022-04-12 Thread GitBox
michaeljmarshall commented on PR #15067: URL: https://github.com/apache/pulsar/pull/15067#issuecomment-1096925368 > **This is wrong since the meaning of the field is not what one would expect it to be.** @lhotari - are you able to describe the meaning of the field more? -- This is

[GitHub] [pulsar] codelipenghui opened a new pull request, #15138: Fix MemoryLimitTest for branch-2.8

2022-04-12 Thread GitBox
codelipenghui opened a new pull request, #15138: URL: https://github.com/apache/pulsar/pull/15138 Fixed the failed MemoryLimitTest for branch-2.8 ``` Error: Tests run: 8, Failures: 2, Errors: 0, Skipped: 6, Time elapsed: 16.627 s <<< FAILURE! - in

[GitHub] [pulsar] liangyepianzhou commented on issue #15073: [PIP-153] Optimize metadataPositions in MLPendingAckStore

2022-04-12 Thread GitBox
liangyepianzhou commented on issue #15073: URL: https://github.com/apache/pulsar/issues/15073#issuecomment-1096915534 I think we should let maxAckPosition as key, and logPosition as value, that is because: 1. They are all incremental 2. maxAckPosition can be same, but logPosition

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #15137: [PIP-153][optimize][txn] Optimize metadataPositions in MLPendingAckStore

2022-04-12 Thread GitBox
liangyepianzhou opened a new pull request, #15137: URL: https://github.com/apache/pulsar/pull/15137 Master Issue: https://github.com/apache/pulsar/issues/15073 ### Motivation Reduce the memory occupied by metadataPositions and avoid OOM ### Modification Regularly store a small

[GitHub] [pulsar] AnonHxy commented on issue #15131: Get deadlock if create topic fails

2022-04-12 Thread GitBox
AnonHxy commented on issue #15131: URL: https://github.com/apache/pulsar/issues/15131#issuecomment-1096897621 I will try to fix this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] michaeljmarshall commented on pull request #15084: Add KeyStore support in WebSocket, Function Worker HTTPS Servers

2022-04-12 Thread GitBox
michaeljmarshall commented on PR #15084: URL: https://github.com/apache/pulsar/pull/15084#issuecomment-1096885089 Rebased to resolve conflicts. I didn't make any code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] eolivelli opened a new pull request, #15136: Tiered Storage: add OkHttp based provider for JClouds

2022-04-12 Thread GitBox
eolivelli opened a new pull request, #15136: URL: https://github.com/apache/pulsar/pull/15136 ### Motivation In some test environment I have seen a problem using Apache HC based Driver. I have filed this bug https://issues.apache.org/jira/browse/JCLOUDS-1605 Unfortunately the

[GitHub] [pulsar] michaeljmarshall closed pull request #15044: [branch-2.8] Fix license files

2022-04-12 Thread GitBox
michaeljmarshall closed pull request #15044: [branch-2.8] Fix license files URL: https://github.com/apache/pulsar/pull/15044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] michaeljmarshall commented on pull request #15044: [branch-2.8] Fix license files

2022-04-12 Thread GitBox
michaeljmarshall commented on PR #15044: URL: https://github.com/apache/pulsar/pull/15044#issuecomment-1096856816 Thank you @codelipenghui. Closing this, since the underlying issue is now resolved. @nicoloboschi - is it correct to assume that we're seeing this on branch-2.9 and

[GitHub] [pulsar] lhotari commented on issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2022-04-12 Thread GitBox
lhotari commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-1096855336 #15031 and #15067 resolve an issue with a similar symptom, where subscriptions freeze. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lhotari commented on pull request #8634: Perform periodic flush of ManagedCursor mark-delete posistions

2022-04-12 Thread GitBox
lhotari commented on PR #8634: URL: https://github.com/apache/pulsar/pull/8634#issuecomment-1096848148 #15031 and #15067 are needed to fix some race conditions caused by the periodic flushing. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] lhotari commented on pull request #15067: [ML] Follow up on race condition fixes in ManagedCursorImpl #15031

2022-04-12 Thread GitBox
lhotari commented on PR #15067: URL: https://github.com/apache/pulsar/pull/15067#issuecomment-1096845306 the periodic flushing added in #8634 will cause problems unless this fix is applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[pulsar] branch master updated: [Broker][Proxy][Function worker] Fix backpressure handling in Jetty web server configuration (#14353)

2022-04-12 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ec382117661 [Broker][Proxy][Function worker]

[GitHub] [pulsar] lhotari merged pull request #14353: [Broker][Proxy][Function worker] Fix backpressure handling in Jetty web server configuration

2022-04-12 Thread GitBox
lhotari merged PR #14353: URL: https://github.com/apache/pulsar/pull/14353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar-client-go] branch master updated: fix: add service not ready check (#757)

2022-04-12 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 64bfd32 fix: add service not ready

[GitHub] [pulsar-client-go] BewareMyPower merged pull request #757: fix: add service not ready check

2022-04-12 Thread GitBox
BewareMyPower merged PR #757: URL: https://github.com/apache/pulsar-client-go/pull/757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] frankjkelly commented on issue #13864: [Client][Python] Release Manager does not push a release for Mac python clients

2022-04-12 Thread GitBox
frankjkelly commented on issue #13864: URL: https://github.com/apache/pulsar/issues/13864#issuecomment-1096808304 Thanks again. So I did ``` $ wget

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #14723: [Broker] Improve SchemaRegistry logs and metrics

2022-04-12 Thread GitBox
Technoboy- commented on code in PR #14723: URL: https://github.com/apache/pulsar/pull/14723#discussion_r848493768 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java: ## @@ -112,26 +120,64 @@ public CompletableFuture

[GitHub] [pulsar] yaalsn commented on issue #13864: [Client][Python] Release Manager does not push a release for Mac python clients

2022-04-12 Thread GitBox
yaalsn commented on issue #13864: URL: https://github.com/apache/pulsar/issues/13864#issuecomment-1096781604 Yes, @b0mbays is right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pulsar] branch master updated: [broker] fix parameter saslJaasBrokerSectionName in broker.conf (#15110)

2022-04-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8ff87ac9523 [broker] fix parameter

[GitHub] [pulsar] codelipenghui merged pull request #15110: [broker] fix parameter saslJaasBrokerSectionName in broker.conf

2022-04-12 Thread GitBox
codelipenghui merged PR #15110: URL: https://github.com/apache/pulsar/pull/15110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] b0mbays commented on issue #13864: [Client][Python] Release Manager does not push a release for Mac python clients

2022-04-12 Thread GitBox
b0mbays commented on issue #13864: URL: https://github.com/apache/pulsar/issues/13864#issuecomment-1096763578 > I think @yaalsn proposed downloading [this

[GitHub] [pulsar] poorbarcode opened a new pull request, #15135: [cleanup] [client] Remove unnecessary code #PersistentAcknowledgments…

2022-04-12 Thread GitBox
poorbarcode opened a new pull request, #15135: URL: https://github.com/apache/pulsar/pull/15135 Fixes #15134 Master Issue: #15134 ### Motivation Remove unnecessary code #PersistentAcknowledgmentsGroupingTracker ### Documentation - [ ] `doc-required` -

[GitHub] [pulsar] poorbarcode opened a new issue, #15134: Remove useless code to reduce confusion

2022-04-12 Thread GitBox
poorbarcode opened a new issue, #15134: URL: https://github.com/apache/pulsar/issues/15134 **Describe the bug**

[GitHub] [pulsar] HQebupt commented on pull request #15132: [broker]Tidy up update subscribeRateLimiter

2022-04-12 Thread GitBox
HQebupt commented on PR #15132: URL: https://github.com/apache/pulsar/pull/15132#issuecomment-1096735221 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #14149: [Broker]make revokePermissionsOnTopic method async

2022-04-12 Thread GitBox
Technoboy- commented on code in PR #14149: URL: https://github.com/apache/pulsar/pull/14149#discussion_r848436678 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -198,8 +199,14 @@ public void revokePermissionsOnTopic(

  1   2   >