[GitHub] [pulsar] coderzc commented on a diff in pull request #20031: [fix] [cli] Fix Broker crashed by too much memory usage of pulsar tools

2023-04-09 Thread via GitHub
coderzc commented on code in PR #20031: URL: https://github.com/apache/pulsar/pull/20031#discussion_r1161472533 ## conf/pulsar_tools_env.sh: ## @@ -42,6 +42,18 @@ # PULSAR_GLOBAL_ZK_CONF= # Extra options to be passed to the jvm +# Discard parameter "-Xms" of $PULSAR_MEM, whi

[GitHub] [pulsar] Anonymitaet commented on issue #20036: [Doc] color code

2023-04-09 Thread via GitHub
Anonymitaet commented on issue #20036: URL: https://github.com/apache/pulsar/issues/20036#issuecomment-1501469268 @momo-jun OK, thanks! Updating the color text to black text is a better way since black text and the image in NEXT and 2.11.x matches our current design style (while the

[GitHub] [pulsar] tisonkun commented on issue #19912: PIP-261: Restructure Getting Started section

2023-04-09 Thread via GitHub
tisonkun commented on issue #19912: URL: https://github.com/apache/pulsar/issues/19912#issuecomment-1501458624 Hi @asafm! Thanks for starting this thread. I reviewed this proposal in two aspects. ## Content For three journeys in the proposal, we have contents for two of t

[GitHub] [pulsar] coderzc commented on a diff in pull request #20031: [fix] [cli] Fix Broker crashed by too much memory usage of pulsar tools

2023-04-09 Thread via GitHub
coderzc commented on code in PR #20031: URL: https://github.com/apache/pulsar/pull/20031#discussion_r1161472533 ## conf/pulsar_tools_env.sh: ## @@ -42,6 +42,18 @@ # PULSAR_GLOBAL_ZK_CONF= # Extra options to be passed to the jvm +# Discard parameter "-Xms" of $PULSAR_MEM, whi

[GitHub] [pulsar] momo-jun commented on issue #20036: [Doc] color code

2023-04-09 Thread via GitHub
momo-jun commented on issue #20036: URL: https://github.com/apache/pulsar/issues/20036#issuecomment-1501426407 @Anonymitaet I've no idea about this one and didn't notice this image change. My commit related to message retention was about the [cookbook](https://github.com/apache/pulsar/pull/

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-09 Thread via GitHub
mattisonchao commented on code in PR #20050: URL: https://github.com/apache/pulsar/pull/20050#discussion_r1161447439 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/MetaStoreImpl.java: ## @@ -302,16 +302,17 @@ public void asyncRemoveCursor(String ledgerName, S

[GitHub] [pulsar] elysian-gc edited a comment on the discussion: when a etcd down, bookkeeper cannot boot.

2023-04-09 Thread GitBox
GitHub user elysian-gc edited a comment on the discussion: when a etcd down, bookkeeper cannot boot. > Hello, Are you using the Etcd driver in production? Or are you only testing > it? > > Are you on k8s? > > (Tagging @merlimat who tested etcd support) @eolivelli thank your reply, because

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-09 Thread via GitHub
liangyepianzhou commented on code in PR #20006: URL: https://github.com/apache/pulsar/pull/20006#discussion_r1161433555 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java: ## @@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean bat

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-09 Thread via GitHub
liangyepianzhou commented on code in PR #20006: URL: https://github.com/apache/pulsar/pull/20006#discussion_r1161432704 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java: ## @@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean bat

[pulsar-site] branch main updated: [fix] typo omissions concepts-messaging.md (#508)

2023-04-09 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new f3e40ca832a [fix] typo omissions concepts-messag

[GitHub] [pulsar-site] tisonkun merged pull request #508: [fix] typo omissions concepts-messaging.md

2023-04-09 Thread via GitHub
tisonkun merged PR #508: URL: https://github.com/apache/pulsar-site/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar-site] tisonkun commented on pull request #508: Update typo omissions concepts-messaging.md

2023-04-09 Thread via GitHub
tisonkun commented on PR #508: URL: https://github.com/apache/pulsar-site/pull/508#issuecomment-1501382273 Thank you! Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pulsar] congbobo184 commented on pull request #18833: [fix] [tx] Transaction buffer recover blocked by readNext

2023-04-09 Thread via GitHub
congbobo184 commented on PR #18833: URL: https://github.com/apache/pulsar/pull/18833#issuecomment-1501374389 @3286360470 This reproduction requires steps to delete topics, otherwise it cannot be reproduced -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-09 Thread via GitHub
Technoboy- commented on code in PR #20050: URL: https://github.com/apache/pulsar/pull/20050#discussion_r1161419606 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/MetaStoreImpl.java: ## @@ -309,7 +309,11 @@ public void asyncRemoveCursor(String ledgerName, Stri

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-09 Thread via GitHub
BewareMyPower commented on code in PR #19972: URL: https://github.com/apache/pulsar/pull/19972#discussion_r1161415761 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1727,8 +1745,8 @@ CompletableFuture removeReplicator(Stri

[GitHub] [pulsar-site] markacola commented on pull request #508: Update typo omissions concepts-messaging.md

2023-04-09 Thread via GitHub
markacola commented on PR #508: URL: https://github.com/apache/pulsar-site/pull/508#issuecomment-1501367260 Whoops! All updated - thanks @tisonkun :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-09 Thread via GitHub
mattisonchao commented on code in PR #20050: URL: https://github.com/apache/pulsar/pull/20050#discussion_r1161413607 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/MetaStoreImpl.java: ## @@ -309,7 +309,11 @@ public void asyncRemoveCursor(String ledgerName, St

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #20044: [improve][client] Add retry when readTailMessages fails

2023-04-09 Thread via GitHub
heesung-sn commented on code in PR #20044: URL: https://github.com/apache/pulsar/pull/20044#discussion_r1161409510 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java: ## @@ -266,18 +270,15 @@ private void readTailMessages(Reader reader) {

[GitHub] [pulsar-client-go] BewareMyPower commented on a diff in pull request #1002: [feat][txn]Implement transactional consumer/producer API

2023-04-09 Thread via GitHub
BewareMyPower commented on code in PR #1002: URL: https://github.com/apache/pulsar-client-go/pull/1002#discussion_r1161405910 ## pulsar/client_impl.go: ## @@ -195,6 +195,11 @@ func newClient(options ClientOptions) (Client, error) { return c, nil } +func (c *client) Ne

svn commit: r61143 [1/2] - in /dev/pulsar/pulsar-2.9.5-candidate-3: ./ connectors/

2023-04-09 Thread zhaocong
Author: zhaocong Date: Mon Apr 10 03:37:47 2023 New Revision: 61143 Log: Staging artifacts and signature for Pulsar release 2.9.5 Added: dev/pulsar/pulsar-2.9.5-candidate-3/ dev/pulsar/pulsar-2.9.5-candidate-3/apache-pulsar-2.9.5-bin.tar.gz (with props) dev/pulsar/pulsar-2.9.5-cand

svn commit: r61143 [2/2] - in /dev/pulsar/pulsar-2.9.5-candidate-3: ./ connectors/

2023-04-09 Thread zhaocong
Added: dev/pulsar/pulsar-2.9.5-candidate-3/connectors/pulsar-io-mongo-2.9.5.nar.asc == --- dev/pulsar/pulsar-2.9.5-candidate-3/connectors/pulsar-io-mongo-2.9.5.nar.asc (added) +++ dev/pulsar/pulsar-2.9.5-candidate-3/con

[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #236: Speed up the process to start standalone for tests

2023-04-09 Thread via GitHub
BewareMyPower merged PR #236: URL: https://github.com/apache/pulsar-client-cpp/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pulsar-client-cpp] branch main updated: Speed up the process to start standalone for tests (#236)

2023-04-09 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 2f61c62 Speed up the process to start stand

[pulsar-site] branch main updated: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions (#504)

2023-04-09 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 923ec4c5c1b [improve][doc] relocate "Get Started

[GitHub] [pulsar] Anonymitaet closed issue #20024: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions

2023-04-09 Thread via GitHub
Anonymitaet closed issue #20024: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions URL: https://github.com/apache/pulsar/issues/20024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar-site] Anonymitaet merged pull request #504: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions

2023-04-09 Thread via GitHub
Anonymitaet merged PR #504: URL: https://github.com/apache/pulsar-site/pull/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[GitHub] [pulsar] EronWright commented on a diff in pull request #19849: [feat] PIP-257: Add AuthenticationProviderOpenID

2023-04-09 Thread via GitHub
EronWright commented on code in PR #19849: URL: https://github.com/apache/pulsar/pull/19849#discussion_r1161384802 ## pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/OpenIDProviderMetadataCache.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the

[GitHub] [pulsar] Anonymitaet commented on pull request #19939: [feat][client] Support configure MessageCrypto in ProducerBuilder

2023-04-09 Thread via GitHub
Anonymitaet commented on PR #19939: URL: https://github.com/apache/pulsar/pull/19939#issuecomment-1501336847 @tisonkun thanks for introducing this improvement! I see this PR was labeled with `doc-required`, so from the doc perspective: - Java Client API doc: it has been added.

[GitHub] [pulsar] NiuBlibing commented on issue #19917: [Bug] partitioned topic offload failed

2023-04-09 Thread via GitHub
NiuBlibing commented on issue #19917: URL: https://github.com/apache/pulsar/issues/19917#issuecomment-1501324883 I didn't find useful log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar-client-go] shibd commented on pull request #1002: [feat][txn]Implement transactional consumer/producer API

2023-04-09 Thread via GitHub
shibd commented on PR #1002: URL: https://github.com/apache/pulsar-client-go/pull/1002#issuecomment-1501322563 > Adding more detailed examples to the documentation might be more appropriate? Yes, the documentation can be described step by step, and complete examples are placed in th

[GitHub] [pulsar] Anonymitaet commented on issue #20036: [Doc] color code

2023-04-09 Thread via GitHub
Anonymitaet commented on issue #20036: URL: https://github.com/apache/pulsar/issues/20036#issuecomment-1501317838 Hi @momo-jun I've checked the commit history and found that seems you're the author of this change? If so, can you give us more context? -- This is an automated message from

[GitHub] [pulsar] xiaogang-sn opened a new issue, #20051: [Doc] Missing broker.conf entry for GEO replicated subscription

2023-04-09 Thread via GitHub
xiaogang-sn opened a new issue, #20051: URL: https://github.com/apache/pulsar/issues/20051 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? In the

[GitHub] [pulsar] poorbarcode closed pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-09 Thread via GitHub
poorbarcode closed pull request #20050: [fix] [ml] Fix uncompleted future when remove cursor URL: https://github.com/apache/pulsar/pull/20050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #504: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions

2023-04-09 Thread via GitHub
Anonymitaet commented on code in PR #504: URL: https://github.com/apache/pulsar-site/pull/504#discussion_r1161386488 ## docs/admin-get-started.md: ## @@ -9,102 +9,245 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; -This guide walks you through

[GitHub] [pulsar] 3286360470 commented on pull request #18833: [fix] [tx] Transaction buffer recover blocked by readNext

2023-04-09 Thread via GitHub
3286360470 commented on PR #18833: URL: https://github.com/apache/pulsar/pull/18833#issuecomment-1501311859 Are there steps to reproduce this issue stably? I have restarted the broker many times locally and still haven't reproduced the snapshot stuck situation. -- This is an automated mes

[GitHub] [pulsar-client-go] liangyepianzhou commented on pull request #1002: [feat][txn]Implement transactional consumer/producer API

2023-04-09 Thread via GitHub
liangyepianzhou commented on PR #1002: URL: https://github.com/apache/pulsar-client-go/pull/1002#issuecomment-1501311543 >Is this the last PR about transactions? It's better to add some sample code to examples. Yes, this is the last PR concerning transactions. In the tests I've added

[GitHub] [pulsar] poorbarcode opened a new pull request, #20050: [fix] [ml] Fix uncompleted future when remove cursor

2023-04-09 Thread via GitHub
poorbarcode opened a new pull request, #20050: URL: https://github.com/apache/pulsar/pull/20050 ### Motivation `SafeRunnable.safeRun(() -> callback.operationFailed(getException(ex)));` just create a runnable, but will not execute it. ### Modifications do run the task

[GitHub] [pulsar-client-node] BewareMyPower commented on a diff in pull request #309: [Fix] Fix message listener doesn't respect receiver queue size

2023-04-09 Thread via GitHub
BewareMyPower commented on code in PR #309: URL: https://github.com/apache/pulsar-client-node/pull/309#discussion_r1161384949 ## src/Consumer.cc: ## @@ -55,21 +56,34 @@ void Consumer::Init(Napi::Env env, Napi::Object exports) { struct MessageListenerProxyData { std::shared_

[GitHub] [pulsar-client-node] BewareMyPower commented on a diff in pull request #309: [Fix] Fix message listener doesn't respect receiver queue size

2023-04-09 Thread via GitHub
BewareMyPower commented on code in PR #309: URL: https://github.com/apache/pulsar-client-node/pull/309#discussion_r1161384461 ## src/Consumer.cc: ## @@ -82,9 +96,15 @@ void MessageListener(pulsar_consumer_t *rawConsumer, pulsar_message_t *rawMessag return; } - Messa

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #504: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions

2023-04-09 Thread via GitHub
Anonymitaet commented on code in PR #504: URL: https://github.com/apache/pulsar-site/pull/504#discussion_r1161382304 ## docs/admin-get-started.md: ## @@ -9,102 +9,245 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; -This guide walks you through

[GitHub] [pulsar-client-go] shibd commented on pull request #1002: [feat][txn]Implement transactional consumer/producer API

2023-04-09 Thread via GitHub
shibd commented on PR #1002: URL: https://github.com/apache/pulsar-client-go/pull/1002#issuecomment-1501296070 Is this the last PR about transactions? It's better to add some sample code to examples. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #504: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions

2023-04-09 Thread via GitHub
Anonymitaet commented on code in PR #504: URL: https://github.com/apache/pulsar-site/pull/504#discussion_r1161379214 ## docs/admin-get-started.md: ## @@ -9,102 +9,245 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; -This guide walks you through

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-09 Thread via GitHub
Technoboy- commented on code in PR #19972: URL: https://github.com/apache/pulsar/pull/19972#discussion_r1161379180 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1727,8 +1745,8 @@ CompletableFuture removeReplicator(String

[GitHub] [pulsar] github-actions[bot] commented on issue #19061: Flaky-test: ResourceGroupUsageAggregationTest.testProduceConsumeUsageOnRG

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19061: URL: https://github.com/apache/pulsar/issues/19061#issuecomment-1501292585 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19786: [transactions] Add admin API to abort forcibly a transaction

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19786: URL: https://github.com/apache/pulsar/issues/19786#issuecomment-1501291809 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19780: [feat] [perf] Support for transaction consistence test with PerformanceProducer.

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19780: URL: https://github.com/apache/pulsar/issues/19780#issuecomment-1501291868 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19785: [Bug] pulsar admin client in pulsar-client-all logs a ClassNotFoundException at startup

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19785: URL: https://github.com/apache/pulsar/issues/19785#issuecomment-1501291841 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19774: [Bug] [Perf] PerformanceProducer do not produce expected number of messages.

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19774: URL: https://github.com/apache/pulsar/issues/19774#issuecomment-1501291899 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19747: [Bug] [txn] callback of commit/abort is not accurate in transaction

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19747: URL: https://github.com/apache/pulsar/issues/19747#issuecomment-1501291914 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19698: PIP-253: Expose `ProducerStats` for `deadLetterProducer` & `retryLetterProducer` in java client

2023-04-09 Thread via GitHub
github-actions[bot] commented on issue #19698: URL: https://github.com/apache/pulsar/issues/19698#issuecomment-1501291964 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar-site] Huanli-Meng commented on a diff in pull request #504: [improve][doc] relocate "Get Started" (pulsar-admin) to admin API and correct inaccurate descriptions

2023-04-09 Thread via GitHub
Huanli-Meng commented on code in PR #504: URL: https://github.com/apache/pulsar-site/pull/504#discussion_r1161374085 ## docs/admin-get-started.md: ## @@ -9,102 +9,245 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; -This guide walks you through

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #20044: [improve][client] Add retry when readTailMessages fails

2023-04-09 Thread via GitHub
Demogorgon314 commented on code in PR #20044: URL: https://github.com/apache/pulsar/pull/20044#discussion_r1161371766 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java: ## @@ -266,18 +270,15 @@ private void readTailMessages(Reader reader) {

[GitHub] [pulsar] elysian-gc added a comment to the discussion: when a etcd down, bookkeeper cannot boot.

2023-04-09 Thread GitBox
GitHub user elysian-gc added a comment to the discussion: when a etcd down, bookkeeper cannot boot. > Hello, Are you using the Etcd driver in production? Or are you only testing > it? > > Are you on k8s? > > (Tagging @merlimat who tested etcd support) because other applications use etcd clu

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-09 Thread via GitHub
mattisonchao commented on code in PR #19737: URL: https://github.com/apache/pulsar/pull/19737#discussion_r1161365306 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1009,17 +1057,15 @@ private CompletableFuture getNonDurab

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-09 Thread via GitHub
mattisonchao commented on code in PR #19737: URL: https://github.com/apache/pulsar/pull/19737#discussion_r1161365306 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1009,17 +1057,15 @@ private CompletableFuture getNonDurab

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19737: [improve] [broker] PIP-240: new public method unloadSubscription in PersistentTopic

2023-04-09 Thread via GitHub
mattisonchao commented on code in PR #19737: URL: https://github.com/apache/pulsar/pull/19737#discussion_r1161364879 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -430,6 +433,51 @@ public AtomicLong getPendingWriteOps() {

[GitHub] [pulsar-client-node] mguay22 commented on issue #132: `AlreadyClosed` exception when using `topicsPattern`

2023-04-09 Thread via GitHub
mguay22 commented on issue #132: URL: https://github.com/apache/pulsar-client-node/issues/132#issuecomment-1501234469 We're still seeing this behavior on the latest version `v1.8.1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] vineeth1995 commented on pull request #19605: [feat] [broker] PIP-188 support blue-green cluster migration [part-2]

2023-04-09 Thread via GitHub
vineeth1995 commented on PR #19605: URL: https://github.com/apache/pulsar/pull/19605#issuecomment-1501227302 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[pulsar-site] branch main updated: feat: js doc generator (#509)

2023-04-09 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 830d79e8d73 feat: js doc generator (#509) 830d79

[GitHub] [pulsar-site] tisonkun merged pull request #509: feat: js doc generator

2023-04-09 Thread via GitHub
tisonkun merged PR #509: URL: https://github.com/apache/pulsar-site/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar-site] tisonkun commented on pull request #509: feat: js doc generator

2023-04-09 Thread via GitHub
tisonkun commented on PR #509: URL: https://github.com/apache/pulsar-site/pull/509#issuecomment-1501154360 Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [pulsar-site] tisonkun opened a new pull request, #509: feat: js doc generator

2023-04-09 Thread via GitHub
tisonkun opened a new pull request, #509: URL: https://github.com/apache/pulsar-site/pull/509 cc @shibd You can test with: ```shell cd tools/pytools poetry run bin/js-apidoc-generator.py 1.8.2-rc.1 ``` Release process can be updated later. ### Documentati

[GitHub] [pulsar] codecov-commenter commented on pull request #20049: [improve] [broker] Upgrade the BookKeeper dependency to 4.16.0

2023-04-09 Thread via GitHub
codecov-commenter commented on PR #20049: URL: https://github.com/apache/pulsar/pull/20049#issuecomment-1501129869 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/20049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

svn commit: r61135 - /dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.2-rc.1/

2023-04-09 Thread baodi
Author: baodi Date: Sun Apr 9 12:55:12 2023 New Revision: 61135 Log: Staging artifacts and signature for Pulsar Node.js client release 1.8.2-rc.1 Added: dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.2-rc.1/ dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.2-rc.1/apache-pulsar

[pulsar-client-node] annotated tag v1.8.2-rc.1 updated (769d7cc -> 8c7f2e1)

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to annotated tag v1.8.2-rc.1 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git *** WARNING: tag v1.8.2-rc.1 was modified! *** from 769d7cc (commit) to 8c7f2e1 (tag) tagg

[pulsar-client-node] 06/06: Release v1.8.2

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit 769d7cc512c092a771a4333b75e3a3159762390b Author: Baodi Shi AuthorDate: Sun Apr 9 20:00:41 2023 +0800

[pulsar-client-node] 04/06: [fix] Add tests for produce and consume with TLS enabled (#313)

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit 8598e3101d7f5d4e83afcd540d07c8a52ec37311 Author: Masahiro Sakamoto AuthorDate: Thu Apr 6 18:36:18 2023 +0

[pulsar-client-node] 02/06: [Fix] Wrap c++ exception when creating client. (#307)

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit 659ff623cf9da9eef2b0f71ea9c913c089ec1432 Author: Baodi Shi AuthorDate: Tue Mar 21 17:10:29 2023 +0800

[pulsar-client-node] 03/06: Fix symbols conflict of OpenSSL. (#310)

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit ac4ddc926998689bacad78167fb54e6b5810c890 Author: Baodi Shi AuthorDate: Thu Apr 6 10:54:16 2023 +0800

[pulsar-client-node] 01/06: [fix] not compatible with alpine 3.15 env (#304)

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a commit to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git commit df81b7c6b9f075b65b63e7d4d8d3e420a5b376b9 Author: Baodi Shi AuthorDate: Fri Mar 10 11:59:22 2023 +0800

[pulsar-client-node] branch branch-1.8 updated (f0a5e0b -> 769d7cc)

2023-04-09 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to branch branch-1.8 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git from f0a5e0b [doc] Optimize release process. (#298) new df81b7c [fix] not compatible with alpine 3.15

[GitHub] [pulsar-client-cpp] shibd opened a new pull request, #247: [feat] Support set consumer regex subscription mode for C client.

2023-04-09 Thread via GitHub
shibd opened a new pull request, #247: URL: https://github.com/apache/pulsar-client-cpp/pull/247 ### Motivation - Support set consumer regex subscription mode for C client. ### Modifications - Add get and set `pulsar_consumer_regex_subscription_mode` method. ### Ve

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #230: [feat] Support consumer batch receive on C client.

2023-04-09 Thread via GitHub
shibd commented on code in PR #230: URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1161269875 ## include/pulsar/c/consumer_configuration.h: ## @@ -304,6 +304,28 @@ PULSAR_PUBLIC void pulsar_consumer_configuration_set_start_message_id_inclusive( PULSAR_PU

[GitHub] [pulsar] hangc0276 opened a new pull request, #20049: [improve] [broker] Upgrade the BookKeeper dependency to 4.16.0

2023-04-09 Thread via GitHub
hangc0276 opened a new pull request, #20049: URL: https://github.com/apache/pulsar/pull/20049 Fixes #xyz Master Issue: #xyz PIP: #xyz ### Motivation Upgrade the BookKeeper dependency to 4.16.0 ### Modifications