[GitHub] [pulsar] codecov-commenter commented on pull request #19234: [improve][broker] Follow up #19230 to tighten the validation scope

2023-01-14 Thread GitBox
codecov-commenter commented on PR #19234: URL: https://github.com/apache/pulsar/pull/19234#issuecomment-1383039220 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19234?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] mattisonchao closed pull request #19234: [improve][broker] Follow up #19230 to tighten the validation scope

2023-01-14 Thread GitBox
mattisonchao closed pull request #19234: [improve][broker] Follow up #19230 to tighten the validation scope URL: https://github.com/apache/pulsar/pull/19234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] mattisonchao commented on pull request #19234: [improve][broker] Follow up #19230 to tighten the validation scope

2023-01-14 Thread GitBox
mattisonchao commented on PR #19234: URL: https://github.com/apache/pulsar/pull/19234#issuecomment-1383035477 Thanks to @yuruguo. Could you help to review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] mattisonchao opened a new pull request, #19234: [improve][broker] Follow up #19230 to tighten the validation scope

2023-01-14 Thread GitBox
mattisonchao opened a new pull request, #19234: URL: https://github.com/apache/pulsar/pull/19234 ### Motivation This PR is following up #19230 As @yuruguo mentioned https://github.com/apache/pulsar/pull/19230#issuecomment-1382865057, we can tighten the validation scope.

[GitHub] [pulsar] github-actions[bot] commented on pull request #18688: [fix] [ml] There are two same-named managed ledgers in the one broker

2023-01-14 Thread GitBox
github-actions[bot] commented on PR #18688: URL: https://github.com/apache/pulsar/pull/18688#issuecomment-1383023608 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on pull request #18936: [improve] [broker] filter system topics while shedding

2023-01-14 Thread GitBox
github-actions[bot] commented on PR #18936: URL: https://github.com/apache/pulsar/pull/18936#issuecomment-1383023562 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] github-actions[bot] commented on issue #18939: [Bug][Java client] Possible race condition in consumer's clearIncomingMessages which causes a leak in memory limit controller and direc

2023-01-14 Thread GitBox
github-actions[bot] commented on issue #18939: URL: https://github.com/apache/pulsar/issues/18939#issuecomment-1383023539 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18938: [Bug][Java client] Possible race condition in closing consumer which causes a leak in memory limit controller and direct memory with po

2023-01-14 Thread GitBox
github-actions[bot] commented on issue #18938: URL: https://github.com/apache/pulsar/issues/18938#issuecomment-1383023552 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on issue #18942: [Bug] boot broker failed with etcd

2023-01-14 Thread GitBox
github-actions[bot] commented on issue #18942: URL: https://github.com/apache/pulsar/issues/18942#issuecomment-1383023530 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] mattisonchao commented on pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-14 Thread GitBox
mattisonchao commented on PR #19230: URL: https://github.com/apache/pulsar/pull/19230#issuecomment-1383001914 > `Whether the deletTopic can delete topic with the keyword -partition- ?` Please take a look at the test. We not only need to delete the topic but also topic metadata.

[GitHub] [pulsar] nicoloboschi merged pull request #19233: [fix][ci] Pick ubuntu mirror that uses http://

2023-01-14 Thread GitBox
nicoloboschi merged PR #19233: URL: https://github.com/apache/pulsar/pull/19233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] yuruguo commented on pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-14 Thread GitBox
yuruguo commented on PR #19230: URL: https://github.com/apache/pulsar/pull/19230#issuecomment-1382865057 1. Whether the `deletTopic` can delete topic with the keyword `-partition-` ?

[GitHub] [pulsar] nodece commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-14 Thread GitBox
nodece commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070302760 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -172,6 +174,16 @@ protected static String getErrorMessage(Exception

[GitHub] [pulsar] lhotari commented on issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-14 Thread GitBox
lhotari commented on issue #19214: URL: https://github.com/apache/pulsar/issues/19214#issuecomment-1382821836 This problem seems to remain after the PR. https://github.com/apache/pulsar/actions/runs/3918969732/jobs/6699757621#step:11:537 . @heesung-sn Please check -- This is an

[GitHub] [pulsar] codecov-commenter commented on pull request #19233: [fix][ci] Pick ubuntu mirror that uses http://

2023-01-14 Thread GitBox
codecov-commenter commented on PR #19233: URL: https://github.com/apache/pulsar/pull/19233#issuecomment-1382814471 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19233?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari opened a new pull request, #19233: [fix][ci] Pick ubuntu mirror that uses http://

2023-01-14 Thread GitBox
lhotari opened a new pull request, #19233: URL: https://github.com/apache/pulsar/pull/19233 ### Motivation - docker image building fails with https:// mirrors because of missing ca-certificates package - follow up on #19225 changes example failure:

[GitHub] [pulsar] Technoboy- closed pull request #19232: [branch-2.11][ci] Fix license check issue

2023-01-14 Thread GitBox
Technoboy- closed pull request #19232: [branch-2.11][ci] Fix license check issue URL: https://github.com/apache/pulsar/pull/19232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] Technoboy- opened a new pull request, #19232: [branch-2.11][ci] Fix license check issue

2023-01-14 Thread GitBox
Technoboy- opened a new pull request, #19232: URL: https://github.com/apache/pulsar/pull/19232 ### Motivation Fix license check issues that occur in #19206, and #19205. This may introduce by #17779 ``` Run src/check-binary-license.sh

[GitHub] [pulsar-client-go] reugn opened a new pull request, #943: Update the Cobra library to significantly reduce the dependency tree

2023-01-14 Thread GitBox
reugn opened a new pull request, #943: URL: https://github.com/apache/pulsar-client-go/pull/943 ### Motivation As of [v1.4.0](https://github.com/spf13/cobra/releases/tag/v1.4.0), the core Cobra library no longer requires Viper and all of its indirect dependencies. This greatly reduces

[GitHub] [pulsar-client-go] reugn opened a new pull request, #942: Migrate from the deprecated io/ioutil package

2023-01-14 Thread GitBox
reugn opened a new pull request, #942: URL: https://github.com/apache/pulsar-client-go/pull/942 ### Motivation The `io/ioutil` package has been deprecated in go1.16, see the [release notes](https://go.dev/doc/go1.16#ioutil). This PR replaces the existing `io/ioutil` calls with their new

[GitHub] [pulsar] Technoboy- merged pull request #19156: [fix][broker] Support zookeeper read-only config.

2023-01-14 Thread GitBox
Technoboy- merged PR #19156: URL: https://github.com/apache/pulsar/pull/19156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- closed issue #16489: Pulsar no longer works when zookeeper global goes into read only

2023-01-14 Thread GitBox
Technoboy- closed issue #16489: Pulsar no longer works when zookeeper global goes into read only URL: https://github.com/apache/pulsar/issues/16489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-14 Thread GitBox
Technoboy- commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070240482 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -172,6 +174,16 @@ protected static String

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-14 Thread GitBox
Technoboy- commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070240482 ## pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java: ## @@ -172,6 +174,16 @@ protected static String

[GitHub] [pulsar] codecov-commenter commented on pull request #19228: [improve][misc] Follow up on ObjectMapper sharing changes

2023-01-14 Thread GitBox
codecov-commenter commented on PR #19228: URL: https://github.com/apache/pulsar/pull/19228#issuecomment-1382698331 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19228?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] Technoboy- closed pull request #19206: [branch-2.11][cherry-pick] Elasticsearch sink: Support loading config from secrets

2023-01-14 Thread GitBox
Technoboy- closed pull request #19206: [branch-2.11][cherry-pick] Elasticsearch sink: Support loading config from secrets URL: https://github.com/apache/pulsar/pull/19206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Technoboy- closed pull request #19205: [branch-2.11][cherry-pick] Debezium sources: Support loading config from secrets

2023-01-14 Thread GitBox
Technoboy- closed pull request #19205: [branch-2.11][cherry-pick] Debezium sources: Support loading config from secrets URL: https://github.com/apache/pulsar/pull/19205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Technoboy- closed pull request #19228: [improve][misc] Follow up on ObjectMapper sharing changes

2023-01-14 Thread GitBox
Technoboy- closed pull request #19228: [improve][misc] Follow up on ObjectMapper sharing changes URL: https://github.com/apache/pulsar/pull/19228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] yuruguo commented on pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-13 Thread GitBox
yuruguo commented on PR #19230: URL: https://github.com/apache/pulsar/pull/19230#issuecomment-1382685300 This method should support deleting partitioned topics with the keyword `-partition-` ?

[GitHub] [pulsar-site] nicoloboschi merged pull request #384: Add Pulsar shell to the download page

2023-01-13 Thread GitBox
nicoloboschi merged PR #384: URL: https://github.com/apache/pulsar-site/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] tisonkun closed issue #19231: [Bug] python client version is inconsistent in document and pypi

2023-01-13 Thread GitBox
tisonkun closed issue #19231: [Bug] python client version is inconsistent in document and pypi URL: https://github.com/apache/pulsar/issues/19231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] tisonkun commented on issue #19231: [Bug] python client version is inconsistent in document and pypi

2023-01-13 Thread GitBox
tisonkun commented on issue #19231: URL: https://github.com/apache/pulsar/issues/19231#issuecomment-1382675636 Close as a duplicate of https://github.com/apache/pulsar/issues/19121. I don't have time to prepare a patch yet, but can be in this month. @labuladong you're welcome to

[GitHub] [pulsar] liudezhi2098 closed pull request #15129: [fix][broker] optimization getHostName correct when use broker ip in Kerberos authentication

2023-01-13 Thread GitBox
liudezhi2098 closed pull request #15129: [fix][broker] optimization getHostName correct when use broker ip in Kerberos authentication URL: https://github.com/apache/pulsar/pull/15129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] labuladong opened a new issue, #19231: [Bug] python client version is inconsistent in document and pypi

2023-01-13 Thread GitBox
labuladong opened a new issue, #19231: URL: https://github.com/apache/pulsar/issues/19231 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 2.11.0 ### Minimal reproduce

[GitHub] [pulsar] tjiuming commented on a diff in pull request #19157: [fix][broker] Close transactionBuffer after MessageDeduplication#checkStatus failed

2023-01-13 Thread GitBox
tjiuming commented on code in PR #19157: URL: https://github.com/apache/pulsar/pull/19157#discussion_r1070221367 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java: ## @@ -86,4 +98,50 @@ public void

[GitHub] [pulsar] mattisonchao merged pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-13 Thread GitBox
mattisonchao merged PR #19230: URL: https://github.com/apache/pulsar/pull/19230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Jason918 commented on pull request #19147: [fix][broker] catch exception for brokerInterceptor

2023-01-13 Thread GitBox
Jason918 commented on PR #19147: URL: https://github.com/apache/pulsar/pull/19147#issuecomment-1382646132 > @Jason918 It could make things more complicated. It's unsafe to give an interceptor the power to terminate the broker. @BewareMyPower This can not be simply categorized as

[GitHub] [pulsar] github-actions[bot] commented on issue #16578: Flaky-test: PulsarSinkE2ETest.testPulsarSinkDLQ

2023-01-13 Thread GitBox
github-actions[bot] commented on issue #16578: URL: https://github.com/apache/pulsar/issues/16578#issuecomment-1382631722 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] github-actions[bot] commented on pull request #18917: [cherry-pick][branch-2.9] Fix incorrect Nic usage collected by pulsar #18882

2023-01-13 Thread GitBox
github-actions[bot] commented on PR #18917: URL: https://github.com/apache/pulsar/pull/18917#issuecomment-1382630887 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Demogorgon314 commented on pull request #18810: [improve][broker] PIP-192: Implement broker registry for new load manager

2023-01-13 Thread GitBox
Demogorgon314 commented on PR #18810: URL: https://github.com/apache/pulsar/pull/18810#issuecomment-1382617644 > nit: > > Why not use `LoadDataStore + TableView` for this broker registry service? > > `LoadDataStore.keySet()` can return available brokers. > >

[GitHub] [pulsar] heesung-sn commented on pull request #15762: [improve][deploy] changed the default GC options to ZGC from G1GC

2023-01-13 Thread GitBox
heesung-sn commented on PR #15762: URL: https://github.com/apache/pulsar/pull/15762#issuecomment-1382577358 > hi @heesung-sn, when add the `-XX:+PerfDisableSharedMem` ,which makes the `jps` `jstat` commands unusable. What is the purpose of turning on this parameter in the first place?

[GitHub] [pulsar-helm-chart] anant-ahuja opened a new issue, #346: Zookeeper exception and Bookie stuck on Init on EKS install

2023-01-13 Thread GitBox
anant-ahuja opened a new issue, #346: URL: https://github.com/apache/pulsar-helm-chart/issues/346 Using the 3.0.0 Helm release, when trying to install Pulsar on an EKS cluster I get the following errors. Zookeeper exception: `2023-01-13T22:15:18,697+ [SessionTracker] INFO

[GitHub] [pulsar] vitosans commented on issue #16105: Why Roles do not support concurrent authorization?

2023-01-13 Thread GitBox
vitosans commented on issue #16105: URL: https://github.com/apache/pulsar/issues/16105#issuecomment-1382427320 We are running into this issue as well now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] lhotari closed issue #19214: Flaky-test: CompactionReaderImplTest.test

2023-01-13 Thread GitBox
lhotari closed issue #19214: Flaky-test: CompactionReaderImplTest.test URL: https://github.com/apache/pulsar/issues/19214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] lhotari merged pull request #19222: [fix][test] Fix flaky test CompactionReaderImplTest

2023-01-13 Thread GitBox
lhotari merged PR #19222: URL: https://github.com/apache/pulsar/pull/19222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari closed issue #19227: Build fails with "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
lhotari closed issue #19227: Build fails with "An error has occurred in JaCoCo report generation" URL: https://github.com/apache/pulsar/issues/19227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] lhotari merged pull request #19229: [fix][build] Fix "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
lhotari merged PR #19229: URL: https://github.com/apache/pulsar/pull/19229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nodece commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-13 Thread GitBox
nodece commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1069880315 ## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19203: [improve][websocket] Add ping support

2023-01-13 Thread GitBox
poorbarcode commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1069856287 ## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pulsar] lhotari merged pull request #19226: [improve][ci] Revisit the TestNG FailFastNotifier changes to fix NPEs when a test fails

2023-01-13 Thread GitBox
lhotari merged PR #19226: URL: https://github.com/apache/pulsar/pull/19226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codecov-commenter commented on pull request #19229: [fix][build] Fix "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
codecov-commenter commented on PR #19229: URL: https://github.com/apache/pulsar/pull/19229#issuecomment-1382200849 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19229?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] codecov-commenter commented on pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-13 Thread GitBox
codecov-commenter commented on PR #19230: URL: https://github.com/apache/pulsar/pull/19230#issuecomment-1382196342 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19230?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19204: [improve][broker] Add metric to indicates the max size of managed ledger cache size

2023-01-13 Thread GitBox
congbobo184 commented on code in PR #19204: URL: https://github.com/apache/pulsar/pull/19204#discussion_r1069765923 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/ManagedLedgerCacheMetrics.java: ## @@ -48,6 +48,7 @@ public synchronized List generate() {

[GitHub] [pulsar] lhotari commented on pull request #19229: [fix][build] Fix "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
lhotari commented on PR #19229: URL: https://github.com/apache/pulsar/pull/19229#issuecomment-1382179914 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] david-streamlio commented on pull request #16179: [improve][pulsar-io] Added support for generic record and raw JSON string schemas to CassandraSink

2023-01-13 Thread GitBox
david-streamlio commented on PR #16179: URL: https://github.com/apache/pulsar/pull/16179#issuecomment-1382178440 @tisonkun @eolivelli I would appreciate another review when you have the time. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] lhotari closed pull request #19222: [fix][test] Fix flaky test CompactionReaderImplTest

2023-01-13 Thread GitBox
lhotari closed pull request #19222: [fix][test] Fix flaky test CompactionReaderImplTest URL: https://github.com/apache/pulsar/pull/19222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] mattisonchao closed pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-13 Thread GitBox
mattisonchao closed pull request #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-` URL: https://github.com/apache/pulsar/pull/19230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] mattisonchao opened a new pull request, #19230: [fix][broker] Support deleting partitioned topics with the keyword `-partition-`

2023-01-13 Thread GitBox
mattisonchao opened a new pull request, #19230: URL: https://github.com/apache/pulsar/pull/19230 ### Motivation We allow users to use the client to create the partitioned topic when they enable partitioned type auto-creation. But we didn't support deleting it. ###

[GitHub] [pulsar] lhotari commented on pull request #19229: [fix][build] Fix "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
lhotari commented on PR #19229: URL: https://github.com/apache/pulsar/pull/19229#issuecomment-1382165762 Code coverage was activated in #17382 . @yaalsn would you mind reviewing this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] lhotari opened a new pull request, #19229: [fix][build] Fix "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
lhotari opened a new pull request, #19229: URL: https://github.com/apache/pulsar/pull/19229 Fixes #19227 ### Motivation Builds fail sporadically with error message `An error has occurred in JaCoCo report generation. Error while creating report: Unknown block type 61.` in CI.

[GitHub] [pulsar] lhotari opened a new pull request, #19228: [improve][misc] Follow up on ObjectMapper sharing changes

2023-01-13 Thread GitBox
lhotari opened a new pull request, #19228: URL: https://github.com/apache/pulsar/pull/19228 ### Motivation Follow up on ObjectMapper sharing changes made in #19160. ### Modifications - use ObjectMapperFactory.create() to create a new ObjectMapper for JSONSchema -

[GitHub] [pulsar] lhotari opened a new issue, #19227: Build fails with "An error has occurred in JaCoCo report generation"

2023-01-13 Thread GitBox
lhotari opened a new issue, #19227: URL: https://github.com/apache/pulsar/issues/19227 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure

[GitHub] [pulsar] codecov-commenter commented on pull request #19226: [improve][ci] Revisit the TestNG FailFastNotifier changes to fix NPEs when a test fails

2023-01-13 Thread GitBox
codecov-commenter commented on PR #19226: URL: https://github.com/apache/pulsar/pull/19226#issuecomment-1382132642 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19226?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-13 Thread GitBox
congbobo184 commented on code in PR #19208: URL: https://github.com/apache/pulsar/pull/19208#discussion_r1069670795 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java: ## @@ -45,19 +62,50 @@ public static MetadataStoreExtended

[GitHub] [pulsar] andrasbeni commented on pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-13 Thread GitBox
andrasbeni commented on PR #19208: URL: https://github.com/apache/pulsar/pull/19208#issuecomment-1382057766 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari merged pull request #19225: [fix][ci] Fix CI issue where ubuntu apt repository azure.archive.ubuntu.com isn't available

2023-01-13 Thread GitBox
lhotari merged PR #19225: URL: https://github.com/apache/pulsar/pull/19225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari closed issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics

2023-01-13 Thread GitBox
lhotari closed issue #19216: Flaky-test: ProxyPrometheusMetricsTest.testMetrics URL: https://github.com/apache/pulsar/issues/19216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] lhotari merged pull request #19221: [fix][test] Fix ProxyPrometheusMetricsTest flakiness and consistently close JAX-RS clients in tests

2023-01-13 Thread GitBox
lhotari merged PR #19221: URL: https://github.com/apache/pulsar/pull/19221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] lhotari merged pull request #19160: [improve][misc] Use shared Jackson ObjectMapper to reduce overhead and remove ThreadLocal solution

2023-01-13 Thread GitBox
lhotari merged PR #19160: URL: https://github.com/apache/pulsar/pull/19160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codecov-commenter commented on pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-13 Thread GitBox
codecov-commenter commented on PR #19208: URL: https://github.com/apache/pulsar/pull/19208#issuecomment-1381975266 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19208?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar] lhotari opened a new pull request, #19226: [improve][ci] Revisit the TestNG FailFastNotifier changes to fix NPEs when a test fails

2023-01-13 Thread GitBox
lhotari opened a new pull request, #19226: URL: https://github.com/apache/pulsar/pull/19226 ### Motivation This is a follow up change for #19220 which contained a change to call cleanup methods when a test fails. This change causes problems for later tests which are skipped since

[GitHub] [pulsar] andrasbeni commented on pull request #19208: [improve][broker]Enable custom metadata stores

2023-01-13 Thread GitBox
andrasbeni commented on PR #19208: URL: https://github.com/apache/pulsar/pull/19208#issuecomment-1381924625 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-site] nicoloboschi commented on pull request #384: Add Pulsar shell to the download page

2023-01-13 Thread GitBox
nicoloboschi commented on PR #384: URL: https://github.com/apache/pulsar-site/pull/384#issuecomment-1381898626 > @nicoloboschi please attach a screenshot of preview :) done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-site] tisonkun commented on pull request #384: Add Pulsar shell to the download page

2023-01-13 Thread GitBox
tisonkun commented on PR #384: URL: https://github.com/apache/pulsar-site/pull/384#issuecomment-1381889603 @nicoloboschi please attach a screenshot of preview :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-client-cpp] shibd opened a new issue, #173: Flaky test: KeyBasedBatchingTest.testOrderingKeyPriority

2023-01-13 Thread GitBox
shibd opened a new issue, #173: URL: https://github.com/apache/pulsar-client-cpp/issues/173 [example failure](https://github.com/apache/pulsar-client-cpp/actions/runs/3911569384/jobs/6685111475) ``` FAILED TESTS (5/399): 255 ms: ./pulsar-tests ClientTest.testReferenceCount

[GitHub] [pulsar-client-cpp] armanjupriya-er opened a new issue, #172: Support for TLS 1.3 in Pulsar CPP Client

2023-01-13 Thread GitBox
armanjupriya-er opened a new issue, #172: URL: https://github.com/apache/pulsar-client-cpp/issues/172 From https://github.com/apache/pulsar-client-cpp/blob/a46da16421323d146c33d1e9d00a0352b50ace89/lib/ClientConnection.cc#L192, Pulsar CPP client supports only TLS 1.2 for communication.

[GitHub] [pulsar-site] Technoboy- merged pull request #383: Add 2.11.0 release note link

2023-01-13 Thread GitBox
Technoboy- merged PR #383: URL: https://github.com/apache/pulsar-site/pull/383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-python] astifter opened a new issue, #82: Pulsar Version 3.0.0 on https://pypi.org/project/pulsar-client/

2023-01-13 Thread GitBox
astifter opened a new issue, #82: URL: https://github.com/apache/pulsar-client-python/issues/82 Hi, you are publishing a verion 3.0.0 that is not correlated to the actual Pulsar versioning, is that on purpose? I have had a hard time tracking down issues because of this.

[GitHub] [pulsar] nicoloboschi merged pull request #19209: [fix][txn] Fix transactions disabled error message

2023-01-13 Thread GitBox
nicoloboschi merged PR #19209: URL: https://github.com/apache/pulsar/pull/19209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] nicoloboschi commented on pull request #384: Add Pulsar shell to the download page

2023-01-13 Thread GitBox
nicoloboschi commented on PR #384: URL: https://github.com/apache/pulsar-site/pull/384#issuecomment-1381849082 @Technoboy- please review, this is part of releasing Pulsar 2.11.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar-site] nicoloboschi opened a new pull request, #384: Add Pulsar shell to the download page

2023-01-13 Thread GitBox
nicoloboschi opened a new pull request, #384: URL: https://github.com/apache/pulsar-site/pull/384 Pulsar 2.11.0 contains Pulsar shell new artifacts and we need make the download links available. * Added after Pulsar distribution * One row for unix (.tar.gz) and one for Windows

[GitHub] [pulsar-client-cpp] shibd commented on a diff in pull request #157: [feat] Support auto download schema when create producer.

2023-01-13 Thread GitBox
shibd commented on code in PR #157: URL: https://github.com/apache/pulsar-client-cpp/pull/157#discussion_r1069423672 ## include/pulsar/Result.h: ## @@ -94,6 +94,7 @@ enum Result ResultInterrupted, /// Interrupted while waiting to dequeue ResultDisconnected, ///

[GitHub] [pulsar] codecov-commenter commented on pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-13 Thread GitBox
codecov-commenter commented on PR #19138: URL: https://github.com/apache/pulsar/pull/19138#issuecomment-1381817567 # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19138?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [pulsar-site] momo-jun merged pull request #367: [blog] Add 2.10.3 release blog

2023-01-13 Thread GitBox
momo-jun merged PR #367: URL: https://github.com/apache/pulsar-site/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] thetumbled commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-13 Thread GitBox
thetumbled commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1381808617 > if the TC does not exist in the broker, the op doesn't need to retry. #18924 may has fix this problem I have include this PR in my test enviroment, and exceptions above have

[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #81: Add a version attribute

2023-01-13 Thread GitBox
BewareMyPower commented on code in PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81#discussion_r1069399215 ## pulsar/__about__.py: ## @@ -0,0 +1,19 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [pulsar] congbobo184 commented on pull request #19201: [fix] [broker] fix timeout transaction.

2023-01-13 Thread GitBox
congbobo184 commented on PR #19201: URL: https://github.com/apache/pulsar/pull/19201#issuecomment-1381787751 if the TC does not exist in the broker, the op doesn't need to retry. https://github.com/apache/pulsar/pull/18924 may has fix this problem -- This is an automated message from the

[GitHub] [pulsar-dotpulsar] blankensteiner merged pull request #132: Zstd compression test fix

2023-01-13 Thread GitBox
blankensteiner merged PR #132: URL: https://github.com/apache/pulsar-dotpulsar/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-dotpulsar] kandersen82 opened a new pull request, #132: Zstd compression test fix

2023-01-13 Thread GitBox
kandersen82 opened a new pull request, #132: URL: https://github.com/apache/pulsar-dotpulsar/pull/132 Fixes zstd compression in the latest version is compiled to also work on linux # Description Fix test that was failing because it expected zstd compression not to work on

[GitHub] [pulsar] mattisonchao merged pull request #19223: [improve][broker] Copy subscription properties during updating the topic partition number.

2023-01-13 Thread GitBox
mattisonchao merged PR #19223: URL: https://github.com/apache/pulsar/pull/19223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-node] BewareMyPower merged pull request #285: Fix an issue where the latest client does not work on Rocky Linux 8

2023-01-13 Thread GitBox
BewareMyPower merged PR #285: URL: https://github.com/apache/pulsar-client-node/pull/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-python] BewareMyPower merged pull request #81: Add a version attribute

2023-01-13 Thread GitBox
BewareMyPower merged PR #81: URL: https://github.com/apache/pulsar-client-python/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-dotpulsar] blankensteiner merged pull request #130: Fix object pooling issue

2023-01-13 Thread GitBox
blankensteiner merged PR #130: URL: https://github.com/apache/pulsar-dotpulsar/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-dotpulsar] blankensteiner merged pull request #131: Updated changelog for SendChannel

2023-01-13 Thread GitBox
blankensteiner merged PR #131: URL: https://github.com/apache/pulsar-dotpulsar/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-node] ericallam commented on pull request #282: [fix] Use OAuth2 on macOX arm64 failed.

2023-01-13 Thread GitBox
ericallam commented on PR #282: URL: https://github.com/apache/pulsar-client-node/pull/282#issuecomment-1381722708 I pulled down your repository and followed your directions and I got this error (using Node.js v18.12.1) ``` node:internal/modules/cjs/loader:1243 return

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-13 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1069264203 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -144,7 +155,12 @@ private synchronized long

[GitHub] [pulsar] coderzc commented on a diff in pull request #19138: [feat][broker][PIP-195] Implement delayed message index bucket snapshot(merge/delete) - part8

2023-01-13 Thread GitBox
coderzc commented on code in PR #19138: URL: https://github.com/apache/pulsar/pull/19138#discussion_r1069262861 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java: ## @@ -308,6 +375,10 @@ public synchronized NavigableSet

[GitHub] [pulsar-dotpulsar] kandersen82 opened a new pull request, #131: Updated changelog for SendChannel

2023-01-13 Thread GitBox
kandersen82 opened a new pull request, #131: URL: https://github.com/apache/pulsar-dotpulsar/pull/131 Add changelog description of SendChannel addition # Description Update changelog, and minor code cleanup -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-dotpulsar] kandersen82 opened a new pull request, #130: Fix object pooling issue

2023-01-13 Thread GitBox
kandersen82 opened a new pull request, #130: URL: https://github.com/apache/pulsar-dotpulsar/pull/130 Fixes Object Pooling issue in SendChannelExtensions # Description When using the send extension for SendChannel, metadata objects retrieved from the object pool were returned

[GitHub] [pulsar-manager] malaskowski opened a new issue, #505: Starting Docker container pulsar-manager-0.3.0 with internal PostreSQL does not work

2023-01-13 Thread GitBox
malaskowski opened a new issue, #505: URL: https://github.com/apache/pulsar-manager/issues/505 Running Pulsar Manager with the default [Pulsar Helm Chart settings](https://github.com/apache/pulsar-helm-chart/blob/pulsar-3.0.0/charts/pulsar/values.yaml#L1051) ends with not working manager

<    6   7   8   9   10   11   12   13   14   15   >