[GitHub] [pulsar] laurent-chriqui opened a new issue #3926: Add option to delete counter in python functions state

2019-03-28 Thread GitBox
laurent-chriqui opened a new issue #3926: Add option to delete counter in python functions state URL: https://github.com/apache/pulsar/issues/3926 **Is your feature request related to a problem? Please describe.** It is possible to create a counter in a python pulsar functions using

[GitHub] [pulsar] chairmank commented on issue #3715: Pulsar functions worker fails to initialize

2019-03-28 Thread GitBox
chairmank commented on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-477584106 I see this problem only when triggering offload to tiered storage: ``` 14:13:53.419 [bookkeeper-ml-workers-OrderedExecutor-2-0]

[GitHub] [pulsar] jiazhai opened a new pull request #3924: [Pulsar IO]: Add a source connector for debezium postgres

2019-03-28 Thread GitBox
jiazhai opened a new pull request #3924: [Pulsar IO]: Add a source connector for debezium postgres URL: https://github.com/apache/pulsar/pull/3924 This PR try to add a source connector for debezium postgres. changes: - add debezium postges project; - add DebeziumSource, and

[GitHub] [pulsar] chairmank edited a comment on issue #3715: Pulsar functions worker fails to initialize

2019-03-28 Thread GitBox
chairmank edited a comment on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-477584106 I see this problem only when triggering offload to tiered storage: ``` 14:13:53.419

[GitHub] [pulsar] laurent-chriqui opened a new pull request #3930: [Issue 3926][functions] Add delete counter in python functions state_context

2019-03-28 Thread GitBox
laurent-chriqui opened a new pull request #3930: [Issue 3926][functions] Add delete counter in python functions state_context URL: https://github.com/apache/pulsar/pull/3930 Fixes #3926 ### Motivation Add possibility to delete a counter from a python function ###

[GitHub] [pulsar] codelipenghui opened a new pull request #3923: Fix comments of schema compatibility strategy.

2019-03-28 Thread GitBox
codelipenghui opened a new pull request #3923: Fix comments of schema compatibility strategy. URL: https://github.com/apache/pulsar/pull/3923 ### Motivation Fix comments of schema compatibility strategy. ### Modifications Change comment of

[GitHub] [pulsar] congbobo184 commented on a change in pull request #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269873516 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -83,6

[GitHub] [pulsar] srkukarni merged pull request #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work

2019-03-28 Thread GitBox
srkukarni merged pull request #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work URL: https://github.com/apache/pulsar/pull/3909 This is an automated message from the Apache Git Service.

[pulsar] branch master updated: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work (#3909)

2019-03-28 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 70cc682 Using Auto Consume consumer on a

[GitHub] [pulsar] rdhabalia commented on issue #3881: [pulsar-broker] add valid-readPosition check before setting readPosition at cursor

2019-03-28 Thread GitBox
rdhabalia commented on issue #3881: [pulsar-broker] add valid-readPosition check before setting readPosition at cursor URL: https://github.com/apache/pulsar/pull/3881#issuecomment-477724757 rerun java8 tests rerun integration tests

[GitHub] [pulsar] rdhabalia removed a comment on issue #3881: [pulsar-broker] add valid-readPosition check before setting readPosition at cursor

2019-03-28 Thread GitBox
rdhabalia removed a comment on issue #3881: [pulsar-broker] add valid-readPosition check before setting readPosition at cursor URL: https://github.com/apache/pulsar/pull/3881#issuecomment-475772960 rerun java8 tests rerun integration tests

[GitHub] [pulsar] rdhabalia removed a comment on issue #3921: clean-up unnecessary public from interface

2019-03-28 Thread GitBox
rdhabalia removed a comment on issue #3921: clean-up unnecessary public from interface URL: https://github.com/apache/pulsar/pull/3921#issuecomment-477724342 rerun cpp tests This is an automated message from the Apache Git

[pulsar] branch master updated: fix jcloud shaded in IDEA (#3912)

2019-03-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4a739e5 fix jcloud shaded in IDEA (#3912)

[GitHub] [pulsar] merlimat merged pull request #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR

2019-03-28 Thread GitBox
merlimat merged pull request #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR URL: https://github.com/apache/pulsar/pull/3929 This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: Include java-xmlbuilder in tiered-storage-jcloud NAR (#3928) (#3929)

2019-03-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 625649f Include java-xmlbuilder in

[GitHub] [pulsar] merlimat closed issue #3928: Ledger offload to tiered storage fails with NoClassDefFoundError: com/jamesmurty/utils/XMLBuilder

2019-03-28 Thread GitBox
merlimat closed issue #3928: Ledger offload to tiered storage fails with NoClassDefFoundError: com/jamesmurty/utils/XMLBuilder URL: https://github.com/apache/pulsar/issues/3928 This is an automated message from the Apache

[pulsar] branch master updated: Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. (#3911)

2019-03-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0487804 Support Kafka's

[GitHub] [pulsar] rdhabalia commented on issue #3921: clean-up unnecessary public from interface

2019-03-28 Thread GitBox
rdhabalia commented on issue #3921: clean-up unnecessary public from interface URL: https://github.com/apache/pulsar/pull/3921#issuecomment-477724342 rerun cpp tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] devinbost opened a new issue #3931: How to determine what a namespace contains

2019-03-28 Thread GitBox
devinbost opened a new issue #3931: How to determine what a namespace contains URL: https://github.com/apache/pulsar/issues/3931 How do we determine what objects still exist in our namespace? We are deleting everything we can find, but we're missing something; and, it's not clear what

[pulsar] branch master updated: [pulsar-broker] Fix: Deserialization failing for ZkIsolatedBookieEnsemblePlacementPolicy (#3918)

2019-03-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 012b818 [pulsar-broker] Fix: Deserialization

[GitHub] [pulsar] merlimat merged pull request #3912: [tiered-storage] fix jcloud-shaded version to build in IDEA

2019-03-28 Thread GitBox
merlimat merged pull request #3912: [tiered-storage] fix jcloud-shaded version to build in IDEA URL: https://github.com/apache/pulsar/pull/3912 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] merlimat merged pull request #3918: [pulsar-broker] Fix: Deserialization failing for ZkIsolatedBookieEnsemblePlacementPolicy

2019-03-28 Thread GitBox
merlimat merged pull request #3918: [pulsar-broker] Fix: Deserialization failing for ZkIsolatedBookieEnsemblePlacementPolicy URL: https://github.com/apache/pulsar/pull/3918 This is an automated message from the Apache Git

[GitHub] [pulsar] merlimat commented on a change in pull request #3912: [tiered-storage] fix jcloud-shaded version to build in IDEA

2019-03-28 Thread GitBox
merlimat commented on a change in pull request #3912: [tiered-storage] fix jcloud-shaded version to build in IDEA URL: https://github.com/apache/pulsar/pull/3912#discussion_r270184644 ## File path: tiered-storage/pom.xml ## @@ -32,6 +32,11 @@ tiered-storage-parent

[GitHub] [pulsar] rdhabalia commented on issue #3919: [pulsar-broker] zk-isolation placement policy should make sure isolation group bookies must not be excluded

2019-03-28 Thread GitBox
rdhabalia commented on issue #3919: [pulsar-broker] zk-isolation placement policy should make sure isolation group bookies must not be excluded URL: https://github.com/apache/pulsar/pull/3919#issuecomment-477758896 rerun cpp tests

[GitHub] [pulsar] merlimat closed issue #3908: Pulsar source/sink creation fails when using JSON config values

2019-03-28 Thread GitBox
merlimat closed issue #3908: Pulsar source/sink creation fails when using JSON config values URL: https://github.com/apache/pulsar/issues/3908 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated: Fix source/sink creation to use JSON config values. (#3922)

2019-03-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ee395ca Fix source/sink creation to use JSON

[GitHub] [pulsar] merlimat closed issue #1090: Allow to configure all options when using Kafka wrapper

2019-03-28 Thread GitBox
merlimat closed issue #1090: Allow to configure all options when using Kafka wrapper URL: https://github.com/apache/pulsar/issues/1090 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] merlimat merged pull request #3922: [Issue 3908] [pulsar-client-tool] Fix source/sink creation to use JSON config values

2019-03-28 Thread GitBox
merlimat merged pull request #3922: [Issue 3908] [pulsar-client-tool] Fix source/sink creation to use JSON config values URL: https://github.com/apache/pulsar/pull/3922 This is an automated message from the Apache Git

[GitHub] [pulsar] merlimat merged pull request #3911: Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer.

2019-03-28 Thread GitBox
merlimat merged pull request #3911: Support Kafka's ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG in PulsarKafkaConsumer. URL: https://github.com/apache/pulsar/pull/3911 This is an automated message from the Apache Git Service.

[GitHub] [pulsar] chairmank edited a comment on issue #3715: Pulsar functions worker fails to initialize

2019-03-28 Thread GitBox
chairmank edited a comment on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-477584106 I see this problem only when triggering offload to tiered storage: ``` 14:13:53.419

[GitHub] [pulsar] sijie commented on issue #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work

2019-03-28 Thread GitBox
sijie commented on issue #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work URL: https://github.com/apache/pulsar/pull/3909#issuecomment-477670665 I think if there is no topic, it should fail immediately since auto consume requires topic exists first.

[GitHub] [pulsar] jerrypeng merged pull request #3874: [ISSUE 3763] - Implementing Function authorization

2019-03-28 Thread GitBox
jerrypeng merged pull request #3874: [ISSUE 3763] - Implementing Function authorization URL: https://github.com/apache/pulsar/pull/3874 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] ivankelly commented on a change in pull request #3923: Fix comments of schema compatibility strategy.

2019-03-28 Thread GitBox
ivankelly commented on a change in pull request #3923: Fix comments of schema compatibility strategy. URL: https://github.com/apache/pulsar/pull/3923#discussion_r270049400 ## File path:

[GitHub] [pulsar] jerrypeng commented on issue #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work

2019-03-28 Thread GitBox
jerrypeng commented on issue #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work URL: https://github.com/apache/pulsar/pull/3909#issuecomment-477669334 @sijie @srkukarni should we have a discussion on what the correct behavior of auto consume consumer

[GitHub] [pulsar] srkukarni commented on issue #3865: Classloader choice for validating Source/Sink

2019-03-28 Thread GitBox
srkukarni commented on issue #3865: Classloader choice for validating Source/Sink URL: https://github.com/apache/pulsar/pull/3865#issuecomment-477824333 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] srkukarni merged pull request #3865: Classloader choice for validating Source/Sink

2019-03-28 Thread GitBox
srkukarni merged pull request #3865: Classloader choice for validating Source/Sink URL: https://github.com/apache/pulsar/pull/3865 This is an automated message from the Apache Git Service. To respond to the message, please

[pulsar] branch master updated: Classloader choice for validating Source/Sink (#3865)

2019-03-28 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f3095d8 Classloader choice for validating

[GitHub] [pulsar] jiazhai opened a new issue #3925: Meet schema error while using debezium source.

2019-03-28 Thread GitBox
jiazhai opened a new issue #3925: Meet schema error while using debezium source. URL: https://github.com/apache/pulsar/issues/3925 **Describe the bug** If a debezium source connector stop and start again. the internal PulsarSink's schema type is changed. In PulsarSink.open(), the

[GitHub] [pulsar] chairmank opened a new issue #3928: Ledger offload to tiered storage fails with NoClassDefFoundError: com/jamesmurty/utils/XMLBuilder

2019-03-28 Thread GitBox
chairmank opened a new issue #3928: Ledger offload to tiered storage fails with NoClassDefFoundError: com/jamesmurty/utils/XMLBuilder URL: https://github.com/apache/pulsar/issues/3928 We see this stacktrace on brokers when we trigger offload to tiered storage: ``` 13:35:26.044

[GitHub] [pulsar] chairmank opened a new pull request #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR

2019-03-28 Thread GitBox
chairmank opened a new pull request #3929: [3928][tiered-storage] Include java-xmlbuilder in tiered-storage-jcloud NAR URL: https://github.com/apache/pulsar/pull/3929 In the POM file for tiered-storage-jcloud, the dependency on com.jamesmurty.utils/java-xmlbuilder was marked with test

[pulsar-client-node] branch master updated: Support authentication

2019-03-28 Thread hrsakai
This is an automated email from the ASF dual-hosted git repository. hrsakai pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/master by this push: new 0dccd84 Support authentication

[GitHub] [pulsar] srkukarni commented on issue #3865: Classloader choice for validating Source/Sink

2019-03-28 Thread GitBox
srkukarni commented on issue #3865: Classloader choice for validating Source/Sink URL: https://github.com/apache/pulsar/pull/3865#issuecomment-477841423 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] ConcurrencyPractitioner commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy

2019-03-28 Thread GitBox
ConcurrencyPractitioner commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy URL: https://github.com/apache/pulsar/pull/3848#discussion_r270262854 ## File path:

[GitHub] [pulsar] ConcurrencyPractitioner commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy

2019-03-28 Thread GitBox
ConcurrencyPractitioner commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy URL: https://github.com/apache/pulsar/pull/3848#discussion_r270262854 ## File path:

[GitHub] [pulsar] sijie opened a new issue #3935: unload an non-existent topic returns 500

2019-03-28 Thread GitBox
sijie opened a new issue #3935: unload an non-existent topic returns 500 URL: https://github.com/apache/pulsar/issues/3935 **Describe the bug** unload an non-existent topic returns 500 ``` $ bin/pulsar-admin topics unload persistent://public/default/non-existent

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3932: Cleanup logic in JavaInstanceRunnable close method

2019-03-28 Thread GitBox
jerrypeng commented on a change in pull request #3932: Cleanup logic in JavaInstanceRunnable close method URL: https://github.com/apache/pulsar/pull/3932#discussion_r270201841 ## File path:

[GitHub] [pulsar] rdhabalia commented on issue #3919: [pulsar-broker] zk-isolation placement policy should make sure isolation group bookies must not be excluded

2019-03-28 Thread GitBox
rdhabalia commented on issue #3919: [pulsar-broker] zk-isolation placement policy should make sure isolation group bookies must not be excluded URL: https://github.com/apache/pulsar/pull/3919#issuecomment-477798283 rerun cpp tests

[GitHub] [pulsar] rdhabalia commented on issue #3933: [pulsar-broker] Introduce tenant based bookie isolation

2019-03-28 Thread GitBox
rdhabalia commented on issue #3933: [pulsar-broker] Introduce tenant based bookie isolation URL: https://github.com/apache/pulsar/pull/3933#issuecomment-477798209 rerun java8 tests This is an automated message from the

[GitHub] [pulsar] sijie commented on issue #3715: Pulsar functions worker fails to initialize

2019-03-28 Thread GitBox
sijie commented on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-477804457 @chairmank I think your problem is related to #3913 when offloader attempts to offload an empty ledger.

[GitHub] [pulsar] srkukarni commented on a change in pull request #3932: Cleanup logic in JavaInstanceRunnable close method

2019-03-28 Thread GitBox
srkukarni commented on a change in pull request #3932: Cleanup logic in JavaInstanceRunnable close method URL: https://github.com/apache/pulsar/pull/3932#discussion_r270212004 ## File path:

[GitHub] [pulsar] jerrypeng opened a new pull request #3934: fix submit function via url

2019-03-28 Thread GitBox
jerrypeng opened a new pull request #3934: fix submit function via url URL: https://github.com/apache/pulsar/pull/3934 ### Motivation Submitting a function in which the function package is a url is broker right now. If a user is submitting a function with a url package, he or she

[GitHub] [pulsar] merlimat commented on issue #3868: [Issue 3867] Provide the description of sink/source command for better usage

2019-03-28 Thread GitBox
merlimat commented on issue #3868: [Issue 3867] Provide the description of sink/source command for better usage URL: https://github.com/apache/pulsar/pull/3868#issuecomment-477815320 run java8 tests This is an automated

[GitHub] [pulsar] rdhabalia opened a new pull request #3933: [pulsar-broker] Introduce tenant based bookie isolation

2019-03-28 Thread GitBox
rdhabalia opened a new pull request #3933: [pulsar-broker] Introduce tenant based bookie isolation URL: https://github.com/apache/pulsar/pull/3933 ### Motivation Right now, broker has capability to set bookie isolation at broker level. Using which we can make broker to write into

[pulsar] branch master updated: clean-up unnecessary public from interface (#3921)

2019-03-28 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c11c48f clean-up unnecessary public from

[GitHub] [pulsar] merlimat merged pull request #3921: clean-up unnecessary public from interface

2019-03-28 Thread GitBox
merlimat merged pull request #3921: clean-up unnecessary public from interface URL: https://github.com/apache/pulsar/pull/3921 This is an automated message from the Apache Git Service. To respond to the message, please log

[pulsar] branch master updated: Cleanup logic in JavaInstanceRunnable close method (#3932)

2019-03-28 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5740699 Cleanup logic in

[GitHub] [pulsar] srkukarni commented on issue #3865: Classloader choice for validating Source/Sink

2019-03-28 Thread GitBox
srkukarni commented on issue #3865: Classloader choice for validating Source/Sink URL: https://github.com/apache/pulsar/pull/3865#issuecomment-477808278 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] sijie merged pull request #3868: [Issue 3867] Provide the description of sink/source command for better usage

2019-03-28 Thread GitBox
sijie merged pull request #3868: [Issue 3867] Provide the description of sink/source command for better usage URL: https://github.com/apache/pulsar/pull/3868 This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: [Issue 3867] Provide the description of sink/source command for better usage (#3868)

2019-03-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 07030e3 [Issue 3867] Provide the description of

[GitHub] [pulsar] jiazhai commented on issue #3927: Added information about generate key location for jwt.

2019-03-28 Thread GitBox
jiazhai commented on issue #3927: Added information about generate key location for jwt. URL: https://github.com/apache/pulsar/pull/3927#issuecomment-477872772 @skyrocknroll Thanks for the fix. would you please also update [version

[GitHub] [pulsar] sijie closed issue #3867: Provide the description of sink/source command for better usage

2019-03-28 Thread GitBox
sijie closed issue #3867: Provide the description of sink/source command for better usage URL: https://github.com/apache/pulsar/issues/3867 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] sijie commented on issue #3793: Update connector download URL

2019-03-28 Thread GitBox
sijie commented on issue #3793: Update connector download URL URL: https://github.com/apache/pulsar/pull/3793#issuecomment-477870827 I have verified the replacement happens correctly. we can go ahead on merging this first.

[GitHub] [pulsar] sijie commented on a change in pull request #3793: Update connector download URL

2019-03-28 Thread GitBox
sijie commented on a change in pull request #3793: Update connector download URL URL: https://github.com/apache/pulsar/pull/3793#discussion_r270280618 ## File path: site2/website/scripts/replace.js ## @@ -32,6 +32,8 @@ function binaryReleaseUrl(version) { function

[GitHub] [pulsar] sijie commented on issue #3915: (WIP) [PIP28][PROXY] Pulsar Proxy Gateway Improvement

2019-03-28 Thread GitBox
sijie commented on issue #3915: (WIP) [PIP28][PROXY] Pulsar Proxy Gateway Improvement URL: https://github.com/apache/pulsar/pull/3915#issuecomment-477871227 @foreversunyao I prepended `(WIP)` in the caption. feel free to remove it when it is ready for reviews.

[GitHub] [pulsar] jiazhai commented on issue #3930: [Issue 3926][functions] Add delete counter in python functions state_context

2019-03-28 Thread GitBox
jiazhai commented on issue #3930: [Issue 3926][functions] Add delete counter in python functions state_context URL: https://github.com/apache/pulsar/pull/3930#issuecomment-477871153 run java8 tests This is an automated

[GitHub] [pulsar] sijie commented on a change in pull request #3934: fix submit function via url

2019-03-28 Thread GitBox
sijie commented on a change in pull request #3934: fix submit function via url URL: https://github.com/apache/pulsar/pull/3934#discussion_r270278672 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java ## @@ -385,8 +385,7 @@ public

[GitHub] [pulsar] sijie commented on issue #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy

2019-03-28 Thread GitBox
sijie commented on issue #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy URL: https://github.com/apache/pulsar/pull/3848#issuecomment-477866972 @merlimat can you reply to @ConcurrencyPractitioner 's comment?

[GitHub] [pulsar] sijie commented on issue #3931: How to determine what a namespace contains

2019-03-28 Thread GitBox
sijie commented on issue #3931: How to determine what a namespace contains URL: https://github.com/apache/pulsar/issues/3931#issuecomment-477871586 @devinbost you can use `bin/pulsar-admin topics list /` to list all the topics within a namespace. if there are topics, you are

[GitHub] [pulsar] sijie commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy

2019-03-28 Thread GitBox
sijie commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy URL: https://github.com/apache/pulsar/pull/3848#discussion_r269868281 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java

[GitHub] [pulsar] congbobo184 commented on issue #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on issue #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#issuecomment-477468694 > @congbobo184 overall looks much clearer now. However I think we still need to push the reader and writer schema logic to `StructSchema`.

[GitHub] [pulsar] sijie commented on issue #3876: Add the multi version schema support

2019-03-28 Thread GitBox
sijie commented on issue #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#issuecomment-477469650 > I think we need to push the reader and writer, not reader schema and writer schema. @congbobo184 yes

[GitHub] [pulsar] congbobo184 commented on a change in pull request #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269873516 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -83,6

[GitHub] [pulsar] sijie commented on issue #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work

2019-03-28 Thread GitBox
sijie commented on issue #3909: Using Auto Consume consumer on a topic that doesn't have a schema doesn't work URL: https://github.com/apache/pulsar/pull/3909#issuecomment-477471543 @srkukarni @jerrypeng I think current change is the easiest way to fix the integration tests. alternatively

[GitHub] [pulsar] congbobo184 commented on a change in pull request #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269873516 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -83,6

[GitHub] [pulsar] sijie commented on issue #3921: clean-up unnecessary public from interface

2019-03-28 Thread GitBox
sijie commented on issue #3921: clean-up unnecessary public from interface URL: https://github.com/apache/pulsar/pull/3921#issuecomment-477471832 run cpp tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie commented on issue #3922: [Issue 3908] [pulsar-client-tool] Fix source/sink creation to use JSON config values

2019-03-28 Thread GitBox
sijie commented on issue #3922: [Issue 3908] [pulsar-client-tool] Fix source/sink creation to use JSON config values URL: https://github.com/apache/pulsar/pull/3922#issuecomment-477471778 run java8 tests This is an automated

[GitHub] [pulsar] congbobo184 commented on a change in pull request #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269873516 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -83,6

[GitHub] [pulsar] sijie merged pull request #3920: Fix: unloading namespace logging

2019-03-28 Thread GitBox
sijie merged pull request #3920: Fix: unloading namespace logging URL: https://github.com/apache/pulsar/pull/3920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] congbobo184 commented on a change in pull request #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269873516 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ## @@ -83,6

[pulsar] branch master updated: Fix: unloading namespace logging (#3920)

2019-03-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a4a53c7 Fix: unloading namespace logging

[GitHub] [pulsar] sijie closed issue #3831: [schema] support timestamp/date schema

2019-03-28 Thread GitBox
sijie closed issue #3831: [schema] support timestamp/date schema URL: https://github.com/apache/pulsar/issues/3831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar] branch master updated: [pulsar-client] add Date/Time/Timestamp schema (#3856)

2019-03-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bda6a9c [pulsar-client] add Date/Time/Timestamp

[GitHub] [pulsar] sijie merged pull request #3856: [pulsar-client] add Date/Time/Timestamp schema

2019-03-28 Thread GitBox
sijie merged pull request #3856: [pulsar-client] add Date/Time/Timestamp schema URL: https://github.com/apache/pulsar/pull/3856 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] sijie merged pull request #3907: Misc Function fixes

2019-03-28 Thread GitBox
sijie merged pull request #3907: Misc Function fixes URL: https://github.com/apache/pulsar/pull/3907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar] branch master updated: Misc Function fixes:- (#3907)

2019-03-28 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 19dd255 Misc Function fixes:- (#3907) 19dd255

[GitHub] [pulsar] congbobo184 commented on a change in pull request #3876: Add the multi version schema support

2019-03-28 Thread GitBox
congbobo184 commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269874938 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java ## @@ -30,26