[GitHub] [pulsar] PierreZ commented on issue #5735: Provide raw counters metrics

2019-12-03 Thread GitBox
PierreZ commented on issue #5735: Provide raw counters metrics URL: https://github.com/apache/pulsar/issues/5735#issuecomment-561520933 Thanks, I will do this  This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#discussion_r353585946 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,109 @@ ## Apache +###

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#discussion_r353586841 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,109 @@ ## Apache +###

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#discussion_r353586287 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,109 @@ ## Apache +###

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#discussion_r353585013 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,109 @@ ## Apache +###

[GitHub] [pulsar] wolfstudy commented on issue #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
wolfstudy commented on issue #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#issuecomment-561511425 @cckellogg fixed done, remove `PULSAR_PREFIX_` from `PULSAR_MEM`, `PULSAR_GC` and `PULSAR_EXTRA_OPTS `.

[GitHub] [pulsar] wolfstudy edited a comment on issue #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
wolfstudy edited a comment on issue #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#issuecomment-561511425 @cckellogg fixed done, remove `PULSAR_PREFIX_` from `PULSAR_MEM`, `PULSAR_GC` and `PULSAR_EXTRA_OPTS `. PTAL again, thanks.

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5570: Transaction log implemention

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#discussion_r353572944 ## File path:

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5570: Transaction log implemention

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5570: Transaction log implemention URL: https://github.com/apache/pulsar/pull/5570#discussion_r353572089 ## File path: pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/TransactionLog.java

[GitHub] [pulsar] wolfstudy commented on issue #5795: Update website for 2.4.2 release

2019-12-03 Thread GitBox
wolfstudy commented on issue #5795: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5795#issuecomment-561504274 @sijie @jiazhai @codelipenghui @merlimat PTAL, thanks. This is an automated message

[GitHub] [pulsar] wolfstudy opened a new pull request #5795: Update website for 2.4.2 release

2019-12-03 Thread GitBox
wolfstudy opened a new pull request #5795: Update website for 2.4.2 release URL: https://github.com/apache/pulsar/pull/5795 Signed-off-by: xiaolong.ran ### Modifications - Update website for 2.4.2 release This

[GitHub] [pulsar] wolfstudy commented on issue #5794: [release][website] Add release notes for Release 2.4.2

2019-12-03 Thread GitBox
wolfstudy commented on issue #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794#issuecomment-561499297 @sijie @jiazhai @codelipenghui @merlimat PTAL, thanks This is

[GitHub] [pulsar] wolfstudy opened a new pull request #5794: [release][website] Add release notes for Release 2.4.2

2019-12-03 Thread GitBox
wolfstudy opened a new pull request #5794: [release][website] Add release notes for Release 2.4.2 URL: https://github.com/apache/pulsar/pull/5794 Signed-off-by: xiaolong.ran ### Modifications - Add release notes for Release 2.4.2.

[GitHub] [pulsar] congbobo184 commented on issue #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema.

2019-12-03 Thread GitBox
congbobo184 commented on issue #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema. URL: https://github.com/apache/pulsar/pull/5782#issuecomment-561492611 run java8 tests This

svn commit: r37076 - /dev/pulsar/pulsar-2.4.2-candidate-3/ /release/pulsar/pulsar-2.4.2/

2019-12-03 Thread zhaijia
Author: zhaijia Date: Wed Dec 4 05:12:32 2019 New Revision: 37076 Log: xiaolong: pulsar 2.4.2 release Added: release/pulsar/pulsar-2.4.2/ - copied from r37075, dev/pulsar/pulsar-2.4.2-candidate-3/ Removed: dev/pulsar/pulsar-2.4.2-candidate-3/

[pulsar] annotated tag v2.4.2 updated (811dd45 -> 6b90a31)

2019-12-03 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to annotated tag v2.4.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git. *** WARNING: tag v2.4.2 was modified! *** from 811dd45 (commit) to 6b90a31 (tag) tagging

[GitHub] [pulsar] jiazhai commented on issue #5792: Extend autoSkipNonRecoverableData to apply to missing Schemas in Bookkeeper

2019-12-03 Thread GitBox
jiazhai commented on issue #5792: Extend autoSkipNonRecoverableData to apply to missing Schemas in Bookkeeper URL: https://github.com/apache/pulsar/issues/5792#issuecomment-561478596 Thanks @wmccarley for such a great github issue reporting. @wmccarley Would you like to contribute a

[GitHub] [pulsar] wolfstudy commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
wolfstudy commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#discussion_r353541860 ## File path: deployment/kubernetes/aws/broker.yaml ## @@ -25,15 +25,15 @@ metadata: data: #

[GitHub] [pulsar] kaykillyou commented on issue #5668: bookie server's log error: Failed to restore rocksdb 000000000000000000/000000000000000001/000000000000000000

2019-12-03 Thread GitBox
kaykillyou commented on issue #5668: bookie server's log error: Failed to restore rocksdb 00/01/00 URL: https://github.com/apache/pulsar/issues/5668#issuecomment-561465598 @jiazhai OK, look forward to the next version update.

[GitHub] [pulsar] kaykillyou closed issue #5668: bookie server's log error: Failed to restore rocksdb 000000000000000000/000000000000000001/000000000000000000

2019-12-03 Thread GitBox
kaykillyou closed issue #5668: bookie server's log error: Failed to restore rocksdb 00/01/00 URL: https://github.com/apache/pulsar/issues/5668 This is an automated message

[GitHub] [pulsar] wolfstudy commented on issue #5781: [Issue:4753] Add encryption docs to Functions develop

2019-12-03 Thread GitBox
wolfstudy commented on issue #5781: [Issue:4753] Add encryption docs to Functions develop URL: https://github.com/apache/pulsar/pull/5781#issuecomment-561453345 > I don't think that's what the original github issue asks for. The original issue asks for the documentation around security

[GitHub] [pulsar] congbobo184 commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-12-03 Thread GitBox
congbobo184 commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-561453917 run cpp tests This is an automated

[GitHub] [pulsar] congbobo184 commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-12-03 Thread GitBox
congbobo184 commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-561453776 run cpp tests This is an automated

[GitHub] [pulsar] congbobo184 removed a comment on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-12-03 Thread GitBox
congbobo184 removed a comment on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-561453701 run cpp tests This is an

[GitHub] [pulsar] congbobo184 removed a comment on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-12-03 Thread GitBox
congbobo184 removed a comment on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-561453776 run cpp tests This is an

[GitHub] [pulsar] congbobo184 commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.

2019-12-03 Thread GitBox
congbobo184 commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-561453701 run cpp tests This is an automated

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema.

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema. URL: https://github.com/apache/pulsar/pull/5782#discussion_r353522311 ## File path:

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema.

2019-12-03 Thread GitBox
codelipenghui commented on a change in pull request #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema. URL: https://github.com/apache/pulsar/pull/5782#discussion_r353524616 ## File path:

[GitHub] [pulsar] wolfstudy commented on issue #3813: [go client] Pointers vs. values in parameters

2019-12-03 Thread GitBox
wolfstudy commented on issue #3813: [go client] Pointers vs. values in parameters URL: https://github.com/apache/pulsar/issues/3813#issuecomment-56144 > @wolfstudy did we address the problem in native client implementation? No, in the native go client, we still have this

[GitHub] [pulsar] codelipenghui commented on issue #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema.

2019-12-03 Thread GitBox
codelipenghui commented on issue #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema. URL: https://github.com/apache/pulsar/pull/5782#issuecomment-561446618 @sijie Yes, it's better to be include in 2.5.0, if user disable schema

[GitHub] [pulsar] tuteng commented on issue #5417: Broker hangs and crashes when listing non-persistent topics

2019-12-03 Thread GitBox
tuteng commented on issue #5417: Broker hangs and crashes when listing non-persistent topics URL: https://github.com/apache/pulsar/issues/5417#issuecomment-561446569 Thank you for your reply. I will test it under the cluster and try to fix this problem.

[GitHub] [pulsar] sijie commented on a change in pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration

2019-12-03 Thread GitBox
sijie commented on a change in pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration URL: https://github.com/apache/pulsar/pull/5788#discussion_r353510004 ## File path:

[GitHub] [pulsar] sijie commented on issue #5735: Provide raw counters metrics

2019-12-03 Thread GitBox
sijie commented on issue #5735: Provide raw counters metrics URL: https://github.com/apache/pulsar/issues/5735#issuecomment-561433734 I don't think we have used Prometheus counter directly. I would suggest: - use LongAdder in AbstractTopic for counting only. - expose those

[GitHub] [pulsar] yjshen commented on a change in pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration

2019-12-03 Thread GitBox
yjshen commented on a change in pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration URL: https://github.com/apache/pulsar/pull/5788#discussion_r353508179 ## File path:

[GitHub] [pulsar] Jennifer88huang commented on issue #5465: [Pulsar Functions] User class constructor throws exception

2019-12-03 Thread GitBox
Jennifer88huang commented on issue #5465: [Pulsar Functions] User class constructor throws exception URL: https://github.com/apache/pulsar/issues/5465#issuecomment-561428379 Ok, when you fix the logic, if you need any support in writing docs, feel free to let me know.

[GitHub] [pulsar] Jennifer88huang edited a comment on issue #5465: [Pulsar Functions] User class constructor throws exception

2019-12-03 Thread GitBox
Jennifer88huang edited a comment on issue #5465: [Pulsar Functions] User class constructor throws exception URL: https://github.com/apache/pulsar/issues/5465#issuecomment-561428379 Ok, when you fix the logic, if you need any support in writing docs, feel free to contact me.

[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic

2019-12-03 Thread GitBox
zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#discussion_r353499759 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java

[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic

2019-12-03 Thread GitBox
zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#discussion_r353499759 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java

[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic

2019-12-03 Thread GitBox
zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#discussion_r353498429 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java

[GitHub] [pulsar] lovelle opened a new pull request #5793: Fixes some minor thread safety violations

2019-12-03 Thread GitBox
lovelle opened a new pull request #5793: Fixes some minor thread safety violations URL: https://github.com/apache/pulsar/pull/5793 *Motivation* Reading latest changes through pulsar code I found some minor thread safety violations. *Modifications* - Add

[GitHub] [pulsar] digi691 commented on issue #5417: Broker hangs and crashes when listing non-persistent topics

2019-12-03 Thread GitBox
digi691 commented on issue #5417: Broker hangs and crashes when listing non-persistent topics URL: https://github.com/apache/pulsar/issues/5417#issuecomment-561326130 What is the appropriate number? Like I said earlier, I currently have it set to 8. Which is the suggested default. What

[GitHub] [pulsar] sijie commented on a change in pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration

2019-12-03 Thread GitBox
sijie commented on a change in pull request #5788: [pulsar-java-client] Decouple partition switch frequency with maxPublishDelay in producer configuration URL: https://github.com/apache/pulsar/pull/5788#discussion_r35567 ## File path:

[GitHub] [pulsar] sijie merged pull request #5757: [Issue 5562][docs]Modify schema compatibility check doc

2019-12-03 Thread GitBox
sijie merged pull request #5757: [Issue 5562][docs]Modify schema compatibility check doc URL: https://github.com/apache/pulsar/pull/5757 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie closed issue #5562: Add the doc for new schema compatibility strategy.

2019-12-03 Thread GitBox
sijie closed issue #5562: Add the doc for new schema compatibility strategy. URL: https://github.com/apache/pulsar/issues/5562 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] sijie commented on issue #5757: [Issue 5562][docs]Modify schema compatibility check doc

2019-12-03 Thread GitBox
sijie commented on issue #5757: [Issue 5562][docs]Modify schema compatibility check doc URL: https://github.com/apache/pulsar/pull/5757#issuecomment-561282299 > @congbobo184 @Anonymitaet When you fix an issue, please add the issue number and component in the title, for example, "[Issue

[GitHub] [pulsar] sijie commented on issue #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema.

2019-12-03 Thread GitBox
sijie commented on issue #5782: Modify the logical in producer carry a schema to connect broker with isAllowAutoUpdateSchema. URL: https://github.com/apache/pulsar/pull/5782#issuecomment-561281558 @codelipenghui is this required for 2.5.0 release?

[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command

2019-12-03 Thread GitBox
sijie commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-561279653 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] dependabot[bot] commented on issue #5638: Bump jackson-databind from 2.9.9.3 to 2.10.1

2019-12-03 Thread GitBox
dependabot[bot] commented on issue #5638: Bump jackson-databind from 2.9.9.3 to 2.10.1 URL: https://github.com/apache/pulsar/pull/5638#issuecomment-561279738 Looks like com.fasterxml.jackson.core:jackson-databind is up-to-date now, so this is no longer needed.

[GitHub] [pulsar] dependabot[bot] closed pull request #5638: Bump jackson-databind from 2.9.9.3 to 2.10.1

2019-12-03 Thread GitBox
dependabot[bot] closed pull request #5638: Bump jackson-databind from 2.9.9.3 to 2.10.1 URL: https://github.com/apache/pulsar/pull/5638 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie commented on issue #5776: fix potential NPE and repeated conditional test

2019-12-03 Thread GitBox
sijie commented on issue #5776: fix potential NPE and repeated conditional test URL: https://github.com/apache/pulsar/pull/5776#issuecomment-561279110 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] sijie merged pull request #5758: Bump jackson libraries to 2.10.1

2019-12-03 Thread GitBox
sijie merged pull request #5758: Bump jackson libraries to 2.10.1 URL: https://github.com/apache/pulsar/pull/5758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[pulsar] branch master updated: Bump jackson libraries to 2.10.1 (#5758)

2019-12-03 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9ad9535 Bump jackson libraries to 2.10.1

[GitHub] [pulsar] sijie merged pull request #5785: Modify the logical for getting schema compatibility strategy

2019-12-03 Thread GitBox
sijie merged pull request #5785: Modify the logical for getting schema compatibility strategy URL: https://github.com/apache/pulsar/pull/5785 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated: Modify the logical for getting schema compatibility strategy (#5785)

2019-12-03 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c952b6b Modify the logical for getting schema

[GitHub] [pulsar] sijie commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library

2019-12-03 Thread GitBox
sijie commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592#issuecomment-561276427 @wolfstudy thank you for your clarification! @Sunkwan-Kwon thank you for your contribution!

[GitHub] [pulsar] sijie merged pull request #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library

2019-12-03 Thread GitBox
sijie merged pull request #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592 This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie closed issue #5589: Memory leak of pulsar-function-go library

2019-12-03 Thread GitBox
sijie closed issue #5589: Memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/issues/5589 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pulsar] branch master updated: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library (#5592)

2019-12-03 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 387e290 [Issue 5589][pulsar-function-go] Fix a

[GitHub] [pulsar] wmccarley opened a new issue #5792: Extend autoSkipNonRecoverableData to apply to missing Schemas in Bookkeeper

2019-12-03 Thread GitBox
wmccarley opened a new issue #5792: Extend autoSkipNonRecoverableData to apply to missing Schemas in Bookkeeper URL: https://github.com/apache/pulsar/issues/5792 **Background** Pulsar uses bookkeeper as the storage mechanism for data/cursors. In #1046 a flag was added by @rdhabalia :

[GitHub] [pulsar] cckellogg commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
cckellogg commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#discussion_r353257885 ## File path: deployment/kubernetes/aws/broker.yaml ## @@ -25,15 +25,15 @@ metadata: data: #

[GitHub] [pulsar] wolfstudy commented on issue #5465: [Pulsar Functions] User class constructor throws exception

2019-12-03 Thread GitBox
wolfstudy commented on issue #5465: [Pulsar Functions] User class constructor throws exception URL: https://github.com/apache/pulsar/issues/5465#issuecomment-561210484 > @wolfstudy Is it by design, or shall we add a note in the document? hello @Jennifer88huang the issue needs to be

[GitHub] [pulsar] Jennifer88huang commented on issue #5757: [Issue 5562][docs]Modify schema compatibility check doc

2019-12-03 Thread GitBox
Jennifer88huang commented on issue #5757: [Issue 5562][docs]Modify schema compatibility check doc URL: https://github.com/apache/pulsar/pull/5757#issuecomment-561190035 @congbobo184 @Anonymitaet When you fix an issue, please add the issue number and component in the title, for example,

[GitHub] [pulsar] wolfstudy commented on issue #5669: Pulsar Broker restart fail owing to create functions/assignments topic fail

2019-12-03 Thread GitBox
wolfstudy commented on issue #5669: Pulsar Broker restart fail owing to create functions/assignments topic fail URL: https://github.com/apache/pulsar/issues/5669#issuecomment-561174974 Thanks @laxpio feedback. > the logs are cleaned. Can you provide the operation way when

[GitHub] [pulsar] wolfstudy commented on issue #5781: [Issue:4753] Add encryption docs to Functions develop

2019-12-03 Thread GitBox
wolfstudy commented on issue #5781: [Issue:4753] Add encryption docs to Functions develop URL: https://github.com/apache/pulsar/pull/5781#issuecomment-561167088 run java8 tests This is an automated message from the Apache

[GitHub] [pulsar] tuteng commented on a change in pull request #5767: Support batch authorization of partitioned topic

2019-12-03 Thread GitBox
tuteng commented on a change in pull request #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#discussion_r353168621 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java ##

[GitHub] [pulsar] tuteng commented on a change in pull request #5767: Support batch authorization of partitioned topic

2019-12-03 Thread GitBox
tuteng commented on a change in pull request #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#discussion_r353166132 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java ##

[GitHub] [pulsar] tuteng commented on a change in pull request #5767: Support batch authorization of partitioned topic

2019-12-03 Thread GitBox
tuteng commented on a change in pull request #5767: Support batch authorization of partitioned topic URL: https://github.com/apache/pulsar/pull/5767#discussion_r353164610 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java

[GitHub] [pulsar] tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink

2019-12-03 Thread GitBox
tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink URL: https://github.com/apache/pulsar/pull/5635#issuecomment-561156011 run cpp tests run integration tests This is an automated

[GitHub] [pulsar] zymap commented on issue #5344: In Pulsar client, the effective value of NackRedeliveryDelay is about 1/3 of its specified value

2019-12-03 Thread GitBox
zymap commented on issue #5344: In Pulsar client, the effective value of NackRedeliveryDelay is about 1/3 of its specified value URL: https://github.com/apache/pulsar/issues/5344#issuecomment-561148510 Hi @Jesse-Zhang-Bose, I think exposing the `TimeInterval` might is not a good idea to

[GitHub] [pulsar] zymap opened a new pull request #5791: Add explanation about the v1 REST API

2019-12-03 Thread GitBox
zymap opened a new pull request #5791: Add explanation about the v1 REST API URL: https://github.com/apache/pulsar/pull/5791 --- Master Issue: #5683 *Motivation* There is a sample tenant that will auto-create when a user starts a standalone service. Sometimes a user

[GitHub] [pulsar] alphashaw commented on issue #5770: Pulsar Broker Sometimes does not return CommandSendReceipt/CommandSendError to prducer send CommandSend

2019-12-03 Thread GitBox
alphashaw commented on issue #5770: Pulsar Broker Sometimes does not return CommandSendReceipt/CommandSendError to prducer send CommandSend URL: https://github.com/apache/pulsar/issues/5770#issuecomment-561136400 Yeah. I realized that after some few tests. I was using a queue to hold the

[GitHub] [pulsar] zymap closed issue #4880: Cmake error when compiling pulsar-client-cpp

2019-12-03 Thread GitBox
zymap closed issue #4880: Cmake error when compiling pulsar-client-cpp URL: https://github.com/apache/pulsar/issues/4880 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] zymap commented on issue #5714: Add more info in the error messages

2019-12-03 Thread GitBox
zymap commented on issue #5714: Add more info in the error messages URL: https://github.com/apache/pulsar/pull/5714#issuecomment-561098054 @sijie I add a new method `wrap` to wrap the exception to enriching the exception message info. The wrap method will get the exception and wrap

[GitHub] [pulsar] wolfstudy commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
wolfstudy commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#discussion_r353076109 ## File path: deployment/kubernetes/generic/k8s-1-9-and-above/broker.yaml ## @@ -25,17 +25,17 @@

[GitHub] [pulsar] jiazhai commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
jiazhai commented on a change in pull request #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790#discussion_r353070939 ## File path: deployment/kubernetes/generic/k8s-1-9-and-above/broker.yaml ## @@ -25,17 +25,17 @@

[GitHub] [pulsar] sky-big commented on issue #5534: Pulsar Operator On Kubernetes

2019-12-03 Thread GitBox
sky-big commented on issue #5534: Pulsar Operator On Kubernetes URL: https://github.com/apache/pulsar/issues/5534#issuecomment-561082144 Operator add pulsar manager component success. This is an automated message from the

[GitHub] [pulsar] jiazhai commented on issue #5668: bookie server's log error: Failed to restore rocksdb 000000000000000000/000000000000000001/000000000000000000

2019-12-03 Thread GitBox
jiazhai commented on issue #5668: bookie server's log error: Failed to restore rocksdb 00/01/00 URL: https://github.com/apache/pulsar/issues/5668#issuecomment-561079276 Thanks @kaykillyou for your report. Since this is not a blocking issue.

[GitHub] [pulsar] wolfstudy opened a new pull request #5790: [Issue:5687] Add prefix for new keys from Env

2019-12-03 Thread GitBox
wolfstudy opened a new pull request #5790: [Issue:5687] Add prefix for new keys from Env URL: https://github.com/apache/pulsar/pull/5790 Signed-off-by: xiaolong.ran Fixes #5687 ### Motivation When the user wants to add new keys for Env, adding fails if no prefix is

[GitHub] [pulsar] lspgn edited a comment on issue #5695: Go: Segfault on messageId serialize after getting it from producer

2019-12-03 Thread GitBox
lspgn edited a comment on issue #5695: Go: Segfault on messageId serialize after getting it from producer URL: https://github.com/apache/pulsar/issues/5695#issuecomment-561059864 I created a branch with more debug:

[GitHub] [pulsar] lspgn edited a comment on issue #5695: Go: Segfault on messageId serialize after getting it from producer

2019-12-03 Thread GitBox
lspgn edited a comment on issue #5695: Go: Segfault on messageId serialize after getting it from producer URL: https://github.com/apache/pulsar/issues/5695#issuecomment-561059864 I created a branch with more debug:

[GitHub] [pulsar] lspgn commented on issue #5695: Go: Segfault on messageId serialize after getting it from producer

2019-12-03 Thread GitBox
lspgn commented on issue #5695: Go: Segfault on messageId serialize after getting it from producer URL: https://github.com/apache/pulsar/issues/5695#issuecomment-561059864 I created a branch with more debug:

[GitHub] [pulsar] Jennifer88huang closed issue #5222: 2.4.1 pulsar-admin should have 8 schema compatibility check strategies

2019-12-03 Thread GitBox
Jennifer88huang closed issue #5222: 2.4.1 pulsar-admin should have 8 schema compatibility check strategies URL: https://github.com/apache/pulsar/issues/5222 This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Anonymitaet commented on issue #4704: Add documentation for HDFS offloader

2019-12-03 Thread GitBox
Anonymitaet commented on issue #4704: Add documentation for HDFS offloader URL: https://github.com/apache/pulsar/issues/4704#issuecomment-561054680 Fixed in https://github.com/apache/pulsar/pull/5762. This is an automated