This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 3b118b6bd54 [fix][sec] Upgrade Spring
lhotari merged PR #20029:
URL: https://github.com/apache/pulsar/pull/20029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
houxiaoyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 8b0a0a388ad [improve][ml] Add Read cache
AnonHxy merged PR #20001:
URL: https://github.com/apache/pulsar/pull/20001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
mmarshall pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.10 by this push:
new 716db378453 [improve][txn] Cleanup
tisonkun closed issue #19876: [Doc] Add API doc for NodeJS client
URL: https://github.com/apache/pulsar/issues/19876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tisonkun merged PR #314:
URL: https://github.com/apache/pulsar-client-node/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun commented on PR #314:
URL:
https://github.com/apache/pulsar-client-node/pull/314#issuecomment-1499948433
Merging...
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michaeljmarshall commented on PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#issuecomment-1499943308
@lhotari - thanks for your review. I've refactored things a bit more. Would
you take another look? Thanks!
--
This is an automated message from the Apache Git Service.
To
Technoboy- closed pull request #20037: [fix][broker] Check replication cluster
before starting the replicator when policies are updated
URL: https://github.com/apache/pulsar/pull/20037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov-commenter commented on PR #20001:
URL: https://github.com/apache/pulsar/pull/20001#issuecomment-1499935476
##
[Codecov](https://codecov.io/gh/apache/pulsar/pull/20001?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
This is an automated email from the ASF dual-hosted git repository.
liuyu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new dfaf6f311f0 [feat][doc] Add Get Started for TXN
Anonymitaet merged PR #501:
URL: https://github.com/apache/pulsar-site/pull/501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
poorbarcode commented on code in PR #19737:
URL: https://github.com/apache/pulsar/pull/19737#discussion_r1160418196
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -430,6 +443,41 @@ public AtomicLong getPendingWriteOps() {
Technoboy- commented on code in PR #19737:
URL: https://github.com/apache/pulsar/pull/19737#discussion_r1160417473
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -430,6 +443,41 @@ public AtomicLong getPendingWriteOps() {
poorbarcode commented on PR #19737:
URL: https://github.com/apache/pulsar/pull/19737#issuecomment-1499904492
After discussing with @congbobo184, we feel it is too heavy to use a map to
track the running unload task, I will find another way to do this.
--
This is an automated message from
poorbarcode commented on PR #19514:
URL: https://github.com/apache/pulsar/pull/19514#issuecomment-1499900570
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
BewareMyPower commented on PR #20037:
URL: https://github.com/apache/pulsar/pull/20037#issuecomment-1499894825
Before this patch:
After this patch:
shibd commented on PR #314:
URL:
https://github.com/apache/pulsar-client-node/pull/314#issuecomment-1499893701
> Perhaps I'll pick this change to branch-1.8 and generate the first API
docs for hosting on our website.
Yes, I'll plan to release v1.8.2 next week. After this is merged,
BewareMyPower opened a new pull request, #20037:
URL: https://github.com/apache/pulsar/pull/20037
Fixes https://github.com/apache/pulsar/issues/20010
### Motivation
`PersistentTopicTest.testCreateTopicWithZombieReplicatorCursor` is flaky
because the cursor could still be
tisonkun commented on PR #314:
URL:
https://github.com/apache/pulsar-client-node/pull/314#issuecomment-1499890417
@BewareMyPower Make sense. I'll add one entry. Also I'll integrate this
function to `apache/pulsar-siite/tools/pytools` and update the release guide
(we should generate for
poorbarcode commented on code in PR #19841:
URL: https://github.com/apache/pulsar/pull/19841#discussion_r1160405999
##
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java:
##
@@ -231,7 +231,7 @@ public String getEncodedLocalName() {
}
public
poorbarcode commented on code in PR #19841:
URL: https://github.com/apache/pulsar/pull/19841#discussion_r1160405999
##
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java:
##
@@ -231,7 +231,7 @@ public String getEncodedLocalName() {
}
public
poorbarcode commented on code in PR #19841:
URL: https://github.com/apache/pulsar/pull/19841#discussion_r1160405999
##
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java:
##
@@ -231,7 +231,7 @@ public String getEncodedLocalName() {
}
public
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.11 by this push:
new c9ae4339a5c Fix cherry-pick #19934
poorbarcode commented on code in PR #19841:
URL: https://github.com/apache/pulsar/pull/19841#discussion_r1160401769
##
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java:
##
@@ -231,7 +231,7 @@ public String getEncodedLocalName() {
}
public
tisonkun commented on issue #505:
URL: https://github.com/apache/pulsar-manager/issues/505#issuecomment-1499871402
@tuteng Out of curiosity, are you working on v0.3.1 release based on current
master branch?
--
This is an automated message from the Apache Git Service.
To respond to the
tuteng commented on issue #505:
URL: https://github.com/apache/pulsar-manager/issues/505#issuecomment-1499870621
tisonkun commented on issue #20034:
URL: https://github.com/apache/pulsar/issues/20034#issuecomment-1499852134
Cherry-picking the result to here for anyone who encounter similar issue:
> Thanks for responding on the issues page. I found the root cause. There
was a bad guava sources
codelipenghui commented on code in PR #19841:
URL: https://github.com/apache/pulsar/pull/19841#discussion_r1160358589
##
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java:
##
@@ -231,7 +231,7 @@ public String getEncodedLocalName() {
}
public
tisonkun commented on issue #20036:
URL: https://github.com/apache/pulsar/issues/20036#issuecomment-1499840776
Hi @anguillanneuf! Thanks for reporting this issue.
Since you click the "I'm willing to submit a PR!" box, I'll double-check
that if you'll draw the diagram. This is not
BewareMyPower commented on code in PR #230:
URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1160378198
##
include/pulsar/c/consumer_configuration.h:
##
@@ -304,6 +304,28 @@ PULSAR_PUBLIC void
pulsar_consumer_configuration_set_start_message_id_inclusive(
github-actions[bot] commented on PR #19372:
URL: https://github.com/apache/pulsar/pull/19372#issuecomment-1499837731
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
github-actions[bot] commented on issue #19448:
URL: https://github.com/apache/pulsar/issues/19448#issuecomment-1499837609
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #19664:
URL: https://github.com/apache/pulsar/issues/19664#issuecomment-1499837119
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #19740:
URL: https://github.com/apache/pulsar/issues/19740#issuecomment-1499836469
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on issue #19739:
URL: https://github.com/apache/pulsar/issues/19739#issuecomment-1499836891
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
BewareMyPower commented on code in PR #230:
URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1160375148
##
include/pulsar/c/consumer_configuration.h:
##
@@ -304,6 +304,28 @@ PULSAR_PUBLIC void
pulsar_consumer_configuration_set_start_message_id_inclusive(
tisonkun commented on PR #20016:
URL: https://github.com/apache/pulsar/pull/20016#issuecomment-1499830318
@merlimat @Technoboy- This patch should be ready to review.
The only failed CI is about Spring dep CVE. We actually filter out all
pulsar-sql when running OWASP so it should be
This is an automated email from the ASF dual-hosted git repository.
urfree pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-site.git
The following commit(s) were added to refs/heads/main by this push:
new 0f78152e200 Docs sync done from apache/pulsar
shibd commented on code in PR #230:
URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1160365729
##
include/pulsar/c/consumer_configuration.h:
##
@@ -304,6 +304,28 @@ PULSAR_PUBLIC void
pulsar_consumer_configuration_set_start_message_id_inclusive(
Zand3r24 commented on issue #505:
URL: https://github.com/apache/pulsar-manager/issues/505#issuecomment-1499753391
Just wanted to say I'm also hitting this, and waiting for a new image to be
built with the fix.
--
This is an automated message from the Apache Git Service.
To respond to
anguillanneuf opened a new issue, #20036:
URL: https://github.com/apache/pulsar/issues/20036
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### What issue do you find in Pulsar docs?
Apurva007 commented on PR #473:
URL: https://github.com/apache/pulsar-site/pull/473#issuecomment-1499680896
@tisonkun/ @syk-coder I have made the requested changes.
PR to apache/pulsar for the code related changes:
https://github.com/apache/pulsar/pull/20035
Please let me know if
Apurva007 opened a new pull request, #20035:
URL: https://github.com/apache/pulsar/pull/20035
Fixes #17878
### Motivation
The Pulsar documentation currently states that partition update works only
for non-global topics. This statement seems to be incorrect as per
codecov-commenter commented on PR #20016:
URL: https://github.com/apache/pulsar/pull/20016#issuecomment-1499636130
##
[Codecov](https://codecov.io/gh/apache/pulsar/pull/20016?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Apurva007 closed issue #20034: [Bug] pulsar-client-all build failures due to
shaded sources
URL: https://github.com/apache/pulsar/issues/20034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Apurva007 commented on issue #20034:
URL: https://github.com/apache/pulsar/issues/20034#issuecomment-1499605505
@tisonkun Thanks for the response. Thats interesting. The sources jar
actually did not exist before the build. It was created after I ran the maven
build and then failed. It is
tisonkun commented on issue #20034:
URL: https://github.com/apache/pulsar/issues/20034#issuecomment-1499553870
Hi @Apurva007! I can build the whole project on the current master
f568c8f49828be42b8a7e81abea45a80cf4f93f4 with:
```
./mvnw clean install -DskipTests
```
For
tisonkun commented on issue #20034:
URL: https://github.com/apache/pulsar/issues/20034#issuecomment-1499553688
Hi @Apurva007! I can build the whole project on the current master
f568c8f49828be42b8a7e81abea45a80cf4f93f4 with:
```
./mvnw clean install -DskipTests
```
For
Apurva007 commented on issue #20034:
URL: https://github.com/apache/pulsar/issues/20034#issuecomment-1499548737
@tisonkun / @eolivelli Please can you clarify if you faced this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Apurva007 opened a new issue, #20034:
URL: https://github.com/apache/pulsar/issues/20034
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues)
and found nothing similar.
### Version
Mac OS: Ventura 13.2.1
Pulsar
michaeljmarshall commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160188680
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java:
##
@@ -131,33 +125,45 @@ public Map>
michaeljmarshall commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160162920
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/api/Component.java:
##
Review Comment:
Removing them.
--
This is
michaeljmarshall commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160161760
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/Authentication.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache
lhotari commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160110139
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/api/Component.java:
##
Review Comment:
the default implementations for the
lhotari commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160109325
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/api/Component.java:
##
Review Comment:
please remove the `@Deprecated`
lhotari commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160098813
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/api/Component.java:
##
Review Comment:
This change is a breaking change to
poorbarcode opened a new issue, #20033:
URL: https://github.com/apache/pulsar/issues/20033
### Motivation
Just auto-create no-partitioned DLQ/Retry Topic
If enabled the config `allowAutoTopicCreation,` Pulsar will auto-create a
topic when the client loads it; After setting
lhotari commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160093628
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java:
##
@@ -131,33 +125,45 @@ public Map>
getAssignments(String
lhotari commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160093628
##
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java:
##
@@ -131,33 +125,45 @@ public Map>
getAssignments(String
lhotari commented on code in PR #19975:
URL: https://github.com/apache/pulsar/pull/19975#discussion_r1160087448
##
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/Authentication.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
devinbost commented on issue #14861:
URL: https://github.com/apache/pulsar/issues/14861#issuecomment-1499391235
If a bookie is slow, if enough bookies are available, will the broker
automatically write to another bookie? It sounds like the workaround is to have
(total bookies + N) > WQ
tisonkun commented on PR #20016:
URL: https://github.com/apache/pulsar/pull/20016#issuecomment-1499352895
Still some compatibility issue. Convert to draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
heesung-sn commented on PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1499317178
Fixed one module: https://github.com/apache/pulsar/pull/19991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159997182
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -558,10 +559,10 @@ public void
BewareMyPower commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159990610
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1706,37 +1706,54 @@ private CompletableFuture
BewareMyPower commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159988483
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -558,10 +559,10 @@ public void
jak78 commented on PR #504:
URL: https://github.com/apache/pulsar-site/pull/504#issuecomment-1499266595
LGTM, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
congbobo184 commented on code in PR #501:
URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1159947724
##
docs/txn-advanced-features.md:
##
@@ -0,0 +1,45 @@
+---
+id: txn-advanced-features
+title: Advanced features
+sidebar_label: "Advanced features"
+---
+
+You
congbobo184 opened a new pull request, #20032:
URL: https://github.com/apache/pulsar/pull/20032
Master Issue:
Fixes client redeliver epoch bigger than broker consumer epoch.
Now redeliver method exists above race condition:
1. consumer reconnects
BewareMyPower commented on code in PR #230:
URL: https://github.com/apache/pulsar-client-cpp/pull/230#discussion_r1159902706
##
include/pulsar/c/consumer_configuration.h:
##
@@ -304,6 +304,28 @@ PULSAR_PUBLIC void
pulsar_consumer_configuration_set_start_message_id_inclusive(
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch branch-2.11
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.11 by this push:
new 644c6e43813 [fix][broker] Return
BewareMyPower commented on PR #236:
URL:
https://github.com/apache/pulsar-client-cpp/pull/236#issuecomment-1499163053
When I tried to write shell scripts for `pulsar-shell`, I found it's hard to
split it into two lines. For example, I met the following error:
```
[5/29] ? admin
BewareMyPower commented on PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#issuecomment-1499106385
Here is a failure from my local env:
[failure.log](https://github.com/apache/pulsar/files/11171288/failure.log)
--
This is an automated message from the Apache Git Service.
poorbarcode opened a new pull request, #20031:
URL: https://github.com/apache/pulsar/pull/20031
### Motivation
After #15868, we allow `PULSAR_MEM` & `PULSAR_GC` to be overridden in
`pulsar_tool_env.sh`. Many users set `-Xms` to `1G` or larger. This will make
the tools cost a lot memory.
poorbarcode commented on PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#issuecomment-1499101137
> Could you also change the title? The PR title is duplicated with
https://github.com/apache/pulsar/pull/19972.
Done
--
This is an automated message from the Apache Git
Technoboy- merged PR #19934:
URL: https://github.com/apache/pulsar/pull/19934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
from 067e3c038ed [feat][fn] PIP-257: Support mounting k8s ServiceAccount
for OIDC auth (#19888)
add 42a6969efc8
michaeljmarshall merged PR #19888:
URL: https://github.com/apache/pulsar/pull/19888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
mmarshall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 067e3c038ed [feat][fn] PIP-257: Support
BewareMyPower commented on PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#issuecomment-1499088792
@poorbarcode Could you also change the title? The PR title is duplicated
with https://github.com/apache/pulsar/pull/19972.
--
This is an automated message from the Apache
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159785692
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
gaoran10 opened a new pull request, #20030:
URL: https://github.com/apache/pulsar/pull/20030
### Motivation
The `reason` label of authentication metrics is a potential infinity string.
### Modifications
Add an enum class `ErrorCode` for Pulsar authentication, it
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159775613
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -558,10 +559,18 @@ public void
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159775220
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1706,37 +1706,53 @@ private CompletableFuture
BewareMyPower commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159773408
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159772007
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159767988
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159767988
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
poorbarcode commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159765202
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
lifepuzzlefun closed issue #18549: [Bug] [ml] ManagedLedger missing check all
pendingReadOps timeout.
URL: https://github.com/apache/pulsar/issues/18549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
BewareMyPower commented on PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#issuecomment-1499015526
I've fixed it locally. I will open another PR to test.
lhotari opened a new pull request, #20029:
URL: https://github.com/apache/pulsar/pull/20029
### Motivation
OWASP Dependency Check is failing with this error:
```
Error: One or more dependencies were identified with vulnerabilities that
have a CVSS score greater than or equal
BewareMyPower commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159737049
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
lhotari commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159734893
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -558,10 +559,18 @@ public void
lhotari commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159734893
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -558,10 +559,18 @@ public void
csthomas1 commented on PR #19584:
URL: https://github.com/apache/pulsar/pull/19584#issuecomment-1498987410
Sure!
On Wed, Apr 5, 2023 at 3:24 AM Nicolò Boschi ***@***.***>
wrote:
> ***@***. requested changes on this pull request.
>
> good catch! would you mind to
lhotari commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159733044
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##
@@ -1706,37 +1706,53 @@ private CompletableFuture
lhotari commented on code in PR #20025:
URL: https://github.com/apache/pulsar/pull/20025#discussion_r1159728548
##
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java:
##
@@ -577,15 +586,21 @@ public void
1 - 100 of 164 matches
Mail list logo
