[GitHub] jerrypeng commented on issue #2098: Context sink source

2018-07-05 Thread GitBox
jerrypeng commented on issue #2098: Context sink source URL: https://github.com/apache/incubator-pulsar/pull/2098#issuecomment-402929877 @rdhabalia I have added unit tests This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2096: Issue 1252: Enable bookie autorecovery daemon by default

2018-07-05 Thread GitBox
sijie commented on issue #2096: Issue 1252: Enable bookie autorecovery daemon by default URL: https://github.com/apache/incubator-pulsar/pull/2096#issuecomment-402925783 retest this please This is an automated message from

[GitHub] sijie commented on issue #2100: Issue 2077: SubscriptionInitialPosition doesn't work with multiple-topic type subscription

2018-07-05 Thread GitBox
sijie commented on issue #2100: Issue 2077: SubscriptionInitialPosition doesn't work with multiple-topic type subscription URL: https://github.com/apache/incubator-pulsar/pull/2100#issuecomment-402925739 retest this please

[GitHub] massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402924613 retest this please This is an

[GitHub] massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402907556 retest this please This is an

[GitHub] massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402916385 retest this please This is an

[GitHub] massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam removed a comment on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402895375 retest this please This is an

[GitHub] massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402924613 retest this please This is an automated

[GitHub] jerrypeng commented on a change in pull request #2098: Context sink source

2018-07-05 Thread GitBox
jerrypeng commented on a change in pull request #2098: Context sink source URL: https://github.com/apache/incubator-pulsar/pull/2098#discussion_r200547768 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java ## @@

[GitHub] nkurihar commented on issue #2085: Fix wget argument

2018-07-05 Thread GitBox
nkurihar commented on issue #2085: Fix wget argument URL: https://github.com/apache/incubator-pulsar/pull/2085#issuecomment-402920261 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402916385 retest this please This is an automated

[GitHub] massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402907556 retest this please This is an automated

[GitHub] aahmed-se opened a new pull request #2101: WIP migrate compaction test to testcontainers

2018-07-05 Thread GitBox
aahmed-se opened a new pull request #2101: WIP migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie opened a new pull request #2100: Issue 2077: SubscriptionInitialPosition doesn't work with multiple-topic type subscription

2018-07-05 Thread GitBox
sijie opened a new pull request #2100: Issue 2077: SubscriptionInitialPosition doesn't work with multiple-topic type subscription URL: https://github.com/apache/incubator-pulsar/pull/2100 *Motivation* Fixes #2077. The problem is the consumer configuration is copied to an

[GitHub] sijie closed pull request #2097: Move Smoke Test and Cli test to semantic package

2018-07-05 Thread GitBox
sijie closed pull request #2097: Move Smoke Test and Cli test to semantic package URL: https://github.com/apache/incubator-pulsar/pull/2097 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Move Smoke Test and Cli test to semantic package (#2097)

2018-07-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 268161c Move Smoke Test and Cli test

[GitHub] sijie commented on issue #2037: Initialization of cluster meta data fails while setting up a multi cluster pulsar instance

2018-07-05 Thread GitBox
sijie commented on issue #2037: Initialization of cluster meta data fails while setting up a multi cluster pulsar instance URL: https://github.com/apache/incubator-pulsar/issues/2037#issuecomment-402901760 sorry for late response. @dsambandam do you mind providing me the list of

[GitHub] sijie opened a new pull request #2099: Issue 1455: MessageID has always batch index 0 when sending messages in a batch

2018-07-05 Thread GitBox
sijie opened a new pull request #2099: Issue 1455: MessageID has always batch index 0 when sending messages in a batch URL: https://github.com/apache/incubator-pulsar/pull/2099 *Motivation* Fixes #1455. Pulsar uses a callback chain for completing the list of callbacks for

[GitHub] massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
massakam commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402895375 retest this please This is an automated

[GitHub] rdhabalia commented on issue #2098: Context sink source

2018-07-05 Thread GitBox
rdhabalia commented on issue #2098: Context sink source URL: https://github.com/apache/incubator-pulsar/pull/2098#issuecomment-402891959 is it possible to add unit test-cases for the changes? This is an automated message from

[GitHub] rdhabalia commented on a change in pull request #2098: Context sink source

2018-07-05 Thread GitBox
rdhabalia commented on a change in pull request #2098: Context sink source URL: https://github.com/apache/incubator-pulsar/pull/2098#discussion_r200524783 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java ## @@

[GitHub] hrsakai commented on issue #2086: Add std=c99 to CMAKE_C_FLAGS to avoid compile error with gcc-4.8

2018-07-05 Thread GitBox
hrsakai commented on issue #2086: Add std=c99 to CMAKE_C_FLAGS to avoid compile error with gcc-4.8 URL: https://github.com/apache/incubator-pulsar/pull/2086#issuecomment-402891073 retest this please This is an automated

[GitHub] jerrypeng opened a new pull request #2098: Context sink source

2018-07-05 Thread GitBox
jerrypeng opened a new pull request #2098: Context sink source URL: https://github.com/apache/incubator-pulsar/pull/2098 ### Motivation Add context to source and sink. Allows users to record custom metrics in custom sources and sinks

[GitHub] aahmed-se opened a new pull request #2097: Move Smoke Test and Cli test to semantic package

2018-07-05 Thread GitBox
aahmed-se opened a new pull request #2097: Move Smoke Test and Cli test to semantic package URL: https://github.com/apache/incubator-pulsar/pull/2097 Me are moving single test projects to unified location , eventually semantic will be renamed to a more general name handle , this is due to

[GitHub] sijie opened a new pull request #2096: Issue 1252: Enable bookie autorecovery daemon by default

2018-07-05 Thread GitBox
sijie opened a new pull request #2096: Issue 1252: Enable bookie autorecovery daemon by default URL: https://github.com/apache/incubator-pulsar/pull/2096 *Motivation* Fixes #1252 AutoRecovery daemon should be enabled by default for new users. *Changes* Turn on

[incubator-pulsar] branch master updated: Enhance Pulsar cluster with container logs (#2078)

2018-07-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 99892d7 Enhance Pulsar cluster with

[GitHub] sijie closed pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
sijie closed pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat closed pull request #2094: Fix Rackaware test

2018-07-05 Thread GitBox
merlimat closed pull request #2094: Fix Rackaware test URL: https://github.com/apache/incubator-pulsar/pull/2094 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Fix Rackaware test (#2094)

2018-07-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2f6dc80 Fix Rackaware test (#2094)

[GitHub] rdhabalia commented on issue #2093: Fix SequenceIdWithErrorTest

2018-07-05 Thread GitBox
rdhabalia commented on issue #2093: Fix SequenceIdWithErrorTest URL: https://github.com/apache/incubator-pulsar/pull/2093#issuecomment-402886048 @merlimat I didn't get chance to debug it fully but I think issue for

[GitHub] aahmed-se commented on a change in pull request #2095: Remove unused test annotation

2018-07-05 Thread GitBox
aahmed-se commented on a change in pull request #2095: Remove unused test annotation URL: https://github.com/apache/incubator-pulsar/pull/2095#discussion_r200519714 ## File path:

[GitHub] merlimat commented on a change in pull request #2095: Remove unused test annotation

2018-07-05 Thread GitBox
merlimat commented on a change in pull request #2095: Remove unused test annotation URL: https://github.com/apache/incubator-pulsar/pull/2095#discussion_r200518679 ## File path:

[GitHub] merlimat commented on issue #2093: Fix SequenceIdWithErrorTest

2018-07-05 Thread GitBox
merlimat commented on issue #2093: Fix SequenceIdWithErrorTest URL: https://github.com/apache/incubator-pulsar/pull/2093#issuecomment-402883963 @aahmed-se Tests stiil failed:

[incubator-pulsar] branch master updated: Added ReadOnlyCursor to ManagedLedger (#2041)

2018-07-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4eee5b1 Added ReadOnlyCursor to

[GitHub] merlimat closed pull request #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat closed pull request #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rdhabalia closed pull request #2091: source consumer ack message with retry to avoid ack-holes

2018-07-05 Thread GitBox
rdhabalia closed pull request #2091: source consumer ack message with retry to avoid ack-holes URL: https://github.com/apache/incubator-pulsar/pull/2091 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rdhabalia commented on issue #2091: source consumer ack message with retry to avoid ack-holes

2018-07-05 Thread GitBox
rdhabalia commented on issue #2091: source consumer ack message with retry to avoid ack-holes URL: https://github.com/apache/incubator-pulsar/pull/2091#issuecomment-402881440 I see.. somehow, our sink is acking all the messages but still we see ack-holes for the subscription. let me debug

[incubator-pulsar] branch master updated: avoid unnecessary reflection to create pulsar source instance (#2083)

2018-07-05 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f71f4ba avoid unnecessary

[GitHub] rdhabalia closed pull request #2083: avoid unnecessary reflection to create pulsar source instance

2018-07-05 Thread GitBox
rdhabalia closed pull request #2083: avoid unnecessary reflection to create pulsar source instance URL: https://github.com/apache/incubator-pulsar/pull/2083 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] aahmed-se opened a new pull request #2095: Remove unused test annotation

2018-07-05 Thread GitBox
aahmed-se opened a new pull request #2095: Remove unused test annotation URL: https://github.com/apache/incubator-pulsar/pull/2095 checkUpload has an incorrect testAnnotation that's not being used. This is an automated

[GitHub] merlimat commented on issue #2091: source consumer ack message with retry to avoid ack-holes

2018-07-05 Thread GitBox
merlimat commented on issue #2091: source consumer ack message with retry to avoid ack-holes URL: https://github.com/apache/incubator-pulsar/pull/2091#issuecomment-402879484 > umm.. but Consumer returns failed-future if consumer is not connected with broker and it will miss the acking of

[GitHub] sijie commented on issue #2092: Issue 2090: Links to connector source code are broken

2018-07-05 Thread GitBox
sijie commented on issue #2092: Issue 2090: Links to connector source code are broken URL: https://github.com/apache/incubator-pulsar/pull/2092#issuecomment-402878987 retest this please This is an automated message from the

[GitHub] zhaijack commented on issue #2065: WIP - GCS offload support(2): replace `s3client` api with `jclouds` related api

2018-07-05 Thread GitBox
zhaijack commented on issue #2065: WIP - GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#issuecomment-402878571 Seems integration test still have some issue, change back to Work In Progress

[GitHub] rdhabalia commented on issue #2091: source consumer ack message with retry to avoid ack-holes

2018-07-05 Thread GitBox
rdhabalia commented on issue #2091: source consumer ack message with retry to avoid ack-holes URL: https://github.com/apache/incubator-pulsar/pull/2091#issuecomment-402878283 > but even when disconnected from broker, the ack will never throw exception. umm.. but

[GitHub] rdhabalia removed a comment on issue #2083: avoid unnecessary reflection to create pulsar source instance

2018-07-05 Thread GitBox
rdhabalia removed a comment on issue #2083: avoid unnecessary reflection to create pulsar source instance URL: https://github.com/apache/incubator-pulsar/pull/2083#issuecomment-402864529 retest this please This is an

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-402876378 retest this please This is an automated

[GitHub] aahmed-se opened a new pull request #2094: Fix Rackaware test

2018-07-05 Thread GitBox
aahmed-se opened a new pull request #2094: Fix Rackaware test URL: https://github.com/apache/incubator-pulsar/pull/2094 Fix Rack Aware test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] aahmed-se opened a new pull request #2093: Fix SequenceIdWithErrorTest

2018-07-05 Thread GitBox
aahmed-se opened a new pull request #2093: Fix SequenceIdWithErrorTest URL: https://github.com/apache/incubator-pulsar/pull/2093 Fix SequenceIdWithErrorTest This is an automated message from the Apache Git Service. To respond

[GitHub] jerrypeng commented on issue #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
jerrypeng commented on issue #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#issuecomment-402870979 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #2091: source consumer ack message with retry to avoid ack-holes

2018-07-05 Thread GitBox
merlimat commented on issue #2091: source consumer ack message with retry to avoid ack-holes URL: https://github.com/apache/incubator-pulsar/pull/2091#issuecomment-402870884 @rdhabalia From 2.0, the `consumer.ack()` is not really throwing exception anymore. The signature was not changed

[GitHub] rdhabalia commented on issue #2083: avoid unnecessary reflection to create pulsar source instance

2018-07-05 Thread GitBox
rdhabalia commented on issue #2083: avoid unnecessary reflection to create pulsar source instance URL: https://github.com/apache/incubator-pulsar/pull/2083#issuecomment-402864529 retest this please This is an automated

[incubator-pulsar] branch master updated: Cleanup unused function resource (#2082)

2018-07-05 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d62cdd8 Cleanup unused function

[GitHub] rdhabalia closed pull request #2082: Cleanup unused function resource

2018-07-05 Thread GitBox
rdhabalia closed pull request #2082: Cleanup unused function resource URL: https://github.com/apache/incubator-pulsar/pull/2082 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-402858835 retest this please This is an automated

[GitHub] sijie opened a new pull request #2092: Issue 2090: Links to connector source code are broken

2018-07-05 Thread GitBox
sijie opened a new pull request #2092: Issue 2090: Links to connector source code are broken URL: https://github.com/apache/incubator-pulsar/pull/2092 *Motivation* Fixes #2090. Links to connector source code are broken *Changes* - Change package name from

[GitHub] merlimat commented on issue #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat commented on issue #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#issuecomment-402856228 retest this please This is an automated message from the Apache Git

[GitHub] aahmed-se commented on issue #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
aahmed-se commented on issue #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#issuecomment-402855657 retest this please This is an automated message from the Apache

[GitHub] rdhabalia opened a new pull request #2091: source consumer ack message with try to avoid ack-holes

2018-07-05 Thread GitBox
rdhabalia opened a new pull request #2091: source consumer ack message with try to avoid ack-holes URL: https://github.com/apache/incubator-pulsar/pull/2091 ### Motivation Right now, if Pulsar-source fails to ack message then it doesn't retry again which leads to ack-hole for

[GitHub] rdhabalia removed a comment on issue #2082: Cleanup unused function resource

2018-07-05 Thread GitBox
rdhabalia removed a comment on issue #2082: Cleanup unused function resource URL: https://github.com/apache/incubator-pulsar/pull/2082#issuecomment-402847199 retest this please This is an automated message from the Apache Git

[GitHub] rdhabalia removed a comment on issue #2083: avoid unnecessary reflection to create pulsar source instance

2018-07-05 Thread GitBox
rdhabalia removed a comment on issue #2083: avoid unnecessary reflection to create pulsar source instance URL: https://github.com/apache/incubator-pulsar/pull/2083#issuecomment-402847077 retest this please This is an

[GitHub] rdhabalia commented on issue #2082: Cleanup unused function resource

2018-07-05 Thread GitBox
rdhabalia commented on issue #2082: Cleanup unused function resource URL: https://github.com/apache/incubator-pulsar/pull/2082#issuecomment-402847199 retest this please This is an automated message from the Apache Git

[GitHub] rdhabalia commented on issue #2083: avoid unnecessary reflection to create pulsar source instance

2018-07-05 Thread GitBox
rdhabalia commented on issue #2083: avoid unnecessary reflection to create pulsar source instance URL: https://github.com/apache/incubator-pulsar/pull/2083#issuecomment-402847077 retest this please This is an automated

[GitHub] sijie closed pull request #2071: change JSONSchema to generate and store an avro schema

2018-07-05 Thread GitBox
sijie closed pull request #2071: change JSONSchema to generate and store an avro schema URL: https://github.com/apache/incubator-pulsar/pull/2071 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: change JSONSchema to generate and store an avro schema (#2071)

2018-07-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1893323 change JSONSchema to generate

[GitHub] sijie closed pull request #2050: Move Pulsar IO as a top-category section at the sidebar

2018-07-05 Thread GitBox
sijie closed pull request #2050: Move Pulsar IO as a top-category section at the sidebar URL: https://github.com/apache/incubator-pulsar/pull/2050 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Move Pulsar IO as a top-category section at the sidebar (#2050)

2018-07-05 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ec04dc0 Move Pulsar IO as a

[GitHub] sijie opened a new issue #2090: Links to connector source code are broken

2018-07-05 Thread GitBox
sijie opened a new issue #2090: Links to connector source code are broken URL: https://github.com/apache/incubator-pulsar/issues/2090 *Problem* The links to connector source code are broken. This problem comes from we renaming connector from `connect` to `io`.

[GitHub] merlimat commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-05 Thread GitBox
merlimat commented on issue #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087#issuecomment-402832810 retest this please This is an automated

[GitHub] rdhabalia removed a comment on issue #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
rdhabalia removed a comment on issue #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#issuecomment-402832717 retest this please This is an automated message from the

[GitHub] rdhabalia commented on issue #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
rdhabalia commented on issue #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#issuecomment-402832717 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on a change in pull request #2054: Package Pulsar IO connectors into separate tgz in form of nar archives

2018-07-05 Thread GitBox
merlimat commented on a change in pull request #2054: Package Pulsar IO connectors into separate tgz in form of nar archives URL: https://github.com/apache/incubator-pulsar/pull/2054#discussion_r200464029 ## File path: pulsar-io/kinesis/pom.xml ## @@ -83,36 +83,12 @@

[GitHub] sijie commented on issue #2083: avoid unnecessary reflection to create pulsar source instance

2018-07-05 Thread GitBox
sijie commented on issue #2083: avoid unnecessary reflection to create pulsar source instance URL: https://github.com/apache/incubator-pulsar/pull/2083#issuecomment-402826549 retest this please This is an automated message

[GitHub] sijie commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r200462042 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/EmbeddedPulsar.java

[GitHub] jerrypeng commented on issue #2082: Cleanup unused function resource

2018-07-05 Thread GitBox
jerrypeng commented on issue #2082: Cleanup unused function resource URL: https://github.com/apache/incubator-pulsar/pull/2082#issuecomment-402825691 retest this please This is an automated message from the Apache Git

[GitHub] aahmed-se commented on a change in pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
aahmed-se commented on a change in pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200461043 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
aahmed-se commented on a change in pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200460705 ## File path:

[GitHub] sijie commented on issue #1229: Documentation required for Pulsar Proxy and TLS changes

2018-07-05 Thread GitBox
sijie commented on issue #1229: Documentation required for Pulsar Proxy and TLS changes URL: https://github.com/apache/incubator-pulsar/issues/1229#issuecomment-402824656 @jai1 are you working on this? This is an automated

[GitHub] merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#discussion_r200460406 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ReadOnlyManagedLedgerImpl.java

[GitHub] aahmed-se commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
aahmed-se commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r200460017 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/EmbeddedPulsar.java

[GitHub] aahmed-se commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
aahmed-se commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r200459114 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/EmbeddedPulsar.java

[GitHub] sijie closed issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects?

2018-07-05 Thread GitBox
sijie closed issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects? URL: https://github.com/apache/incubator-pulsar/issues/1259 This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on issue #2089: RackAwareTest is flaky.

2018-07-05 Thread GitBox
merlimat commented on issue #2089: RackAwareTest is flaky. URL: https://github.com/apache/incubator-pulsar/issues/2089#issuecomment-402823568 Yes, noticed that. I'll take a look This is an automated message from the Apache

[GitHub] sijie commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects?

2018-07-05 Thread GitBox
sijie commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects? URL: https://github.com/apache/incubator-pulsar/issues/1259#issuecomment-402823611 Closed this issue since the question is answered.

[GitHub] merlimat commented on issue #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat commented on issue #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#issuecomment-402823268 > If possible, can we extend ManagedCursor here and probably add docs to the method skipEntries . @rdhabalia the `ReadOnlyCursor`

[GitHub] sijie commented on issue #1303: RateLimiterTest is flaky

2018-07-05 Thread GitBox
sijie commented on issue #1303: RateLimiterTest is flaky URL: https://github.com/apache/incubator-pulsar/issues/1303#issuecomment-402822589 thank you @mgodave . will take a look at this. This is an automated message from the

[GitHub] merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#discussion_r200457400 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ReadOnlyCursorImpl.java

[GitHub] merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#discussion_r200457042 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java

[GitHub] merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger

2018-07-05 Thread GitBox
merlimat commented on a change in pull request #2041: Added ReadOnlyCursor to ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/2041#discussion_r200456453 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java

[GitHub] merlimat commented on issue #2088: Fixed path for Postgres in dashboard docker image

2018-07-05 Thread GitBox
merlimat commented on issue #2088: Fixed path for Postgres in dashboard docker image URL: https://github.com/apache/incubator-pulsar/pull/2088#issuecomment-402819079 retest this please This is an automated message from the

[GitHub] sijie opened a new issue #2089: RackAwareTest is flaky.

2018-07-05 Thread GitBox
sijie opened a new issue #2089: RackAwareTest is flaky. URL: https://github.com/apache/incubator-pulsar/issues/2089 *Flaky Test* ``` [ERROR] org.apache.pulsar.broker.service.RackAwareTest.testPlacement(org.apache.pulsar.broker.service.RackAwareTest) [INFO] Run 1: PASS [ERROR]

[GitHub] sijie commented on issue #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
sijie commented on issue #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#issuecomment-402807721 @aahmed-se moving forward I would suggest separate code changes to change framework from actual tests (e.g. moving the smoke module

[GitHub] sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200437290 ## File path:

[GitHub] sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200439761 ## File path:

[GitHub] sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200440362 ## File path:

[GitHub] sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200438279 ## File path:

[GitHub] rdhabalia commented on a change in pull request #2079: Kinesis sink publish full json message

2018-07-05 Thread GitBox
rdhabalia commented on a change in pull request #2079: Kinesis sink publish full json message URL: https://github.com/apache/incubator-pulsar/pull/2079#discussion_r200439767 ## File path: pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/Utils.java ## @@ -0,0

[GitHub] sijie commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r200434593 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/EmbeddedPulsar.java

[GitHub] sijie commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
sijie commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-402801486 @jerrypeng and @merlimat can you review this?

[GitHub] sijie commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
sijie commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r200434862 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/EmbeddedPulsar.java

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-05 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-402800975 retest this please This is an automated

  1   2   >