sijie commented on a change in pull request #2078: Enhance Pulsar cluster with
container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200438279
##########
File path:
tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/containers/PulsarContainer.java
##########
@@ -97,9 +98,13 @@ public void start() {
this.withCreateContainerCmdModifier(createContainerCmd -> {
createContainerCmd.withHostName(hostname);
createContainerCmd.withName(getContainerName());
- createContainerCmd.withEntrypoint(serviceEntrypoint);
+ createContainerCmd.withEntrypoint(serviceEntryPoint);
});
+ if(Boolean.getBoolean("containerLogs")) {
Review comment:
`containerLogs` is too generic. who knows what does it really mean here?
I would prefer a more specific name `enableSlf4jLogConsumer` and prefixing
`pulsar.integration.tests.testcontainers` is even better (to avoid naming
conflicts).
`pulsar.integration.tests.testcontainers.enableSlf4jLogConsumer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
