[GitHub] sijie commented on issue #2417: update jclouds version to 2.1.1

2018-08-20 Thread GitBox
sijie commented on issue #2417: update jclouds version to 2.1.1 URL: https://github.com/apache/incubator-pulsar/pull/2417#issuecomment-414556837 Jia, I have done that in #2410 This is an automated message from the Apache Git

[GitHub] jiazhai opened a new pull request #2417: update jclouds version to 2.1.1

2018-08-20 Thread GitBox
jiazhai opened a new pull request #2417: update jclouds version to 2.1.1 URL: https://github.com/apache/incubator-pulsar/pull/2417 ### Motivation This is a part of tracking work in #2164. currently we use a snapshot version of jclouds for some jclouds bug fix. This change will

[GitHub] jerrypeng commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
jerrypeng commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211476487 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@

[GitHub] jerrypeng commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
jerrypeng commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211476103 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20

[GitHub] rdhabalia removed a comment on issue #2415: Add admin api stupport to stop function

2018-08-20 Thread GitBox
rdhabalia removed a comment on issue #2415: Add admin api stupport to stop function URL: https://github.com/apache/incubator-pulsar/pull/2415#issuecomment-414543807 rerun java8 tests This is an automated message from the

[GitHub] rdhabalia commented on issue #2415: Add admin api stupport to stop function

2018-08-20 Thread GitBox
rdhabalia commented on issue #2415: Add admin api stupport to stop function URL: https://github.com/apache/incubator-pulsar/pull/2415#issuecomment-414543807 rerun java8 tests This is an automated message from the Apache Git

[GitHub] massakam commented on issue #2401: Consumer often discards received messages

2018-08-20 Thread GitBox
massakam commented on issue #2401: Consumer often discards received messages URL: https://github.com/apache/incubator-pulsar/issues/2401#issuecomment-414543557 @merlimat Do you have any thoughts about what the cause might be?

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211460526 ## File path:

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211460211 ## File path:

[GitHub] rdhabalia opened a new pull request #2416: Fix: authorization while redirecting function admin call

2018-08-20 Thread GitBox
rdhabalia opened a new pull request #2416: Fix: authorization while redirecting function admin call URL: https://github.com/apache/incubator-pulsar/pull/2416 ### Motivation Right now, some of the admin api requires redirection/calling another worker and also requires auth support

[GitHub] rdhabalia opened a new pull request #2415: Add admin api stupport to stop function

2018-08-20 Thread GitBox
rdhabalia opened a new pull request #2415: Add admin api stupport to stop function URL: https://github.com/apache/incubator-pulsar/pull/2415 ### Motivation We have a usecase where we want to stop the function temporary to avoid draining on that function topics. So, adding an admin

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211458490 ## File path:

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211457932 ## File path:

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211457392 ## File path:

[GitHub] sijie closed pull request #2413: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages

2018-08-20 Thread GitBox
sijie closed pull request #2413: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages URL: https://github.com/apache/incubator-pulsar/pull/2413 This is a PR merged from a forked repository. As GitHub hides the original diff

[incubator-pulsar] branch master updated: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages (#2413)

2018-08-20 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c5c2a50 [functions][integration

[GitHub] jerrypeng opened a new pull request #2414: allow predicates concerning publish time to push down to pulsar

2018-08-20 Thread GitBox
jerrypeng opened a new pull request #2414: allow predicates concerning publish time to push down to pulsar URL: https://github.com/apache/incubator-pulsar/pull/2414 ### Motivation Since we can search through entries via publish time efficiently, we don't need to get return all the

[GitHub] jiazhai commented on issue #2398: [tiered storage] store driver name and driver specific metadata in original ledger metadata

2018-08-20 Thread GitBox
jiazhai commented on issue #2398: [tiered storage] store driver name and driver specific metadata in original ledger metadata URL: https://github.com/apache/incubator-pulsar/pull/2398#issuecomment-414509367 run integration tests

[GitHub] jiazhai commented on issue #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
jiazhai commented on issue #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#issuecomment-414507710 rerun java8 tests This is an automated message from the Apache Git Service. To

[GitHub] jiazhai commented on issue #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
jiazhai commented on issue #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#issuecomment-414507487 run integration tests This is an automated message from the Apache Git

[GitHub] srkukarni commented on issue #2413: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages

2018-08-20 Thread GitBox
srkukarni commented on issue #2413: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages URL: https://github.com/apache/incubator-pulsar/pull/2413#issuecomment-414500729 run integration tests

[GitHub] sijie opened a new pull request #2413: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages

2018-08-20 Thread GitBox
sijie opened a new pull request #2413: [functions][integration tests] Ensure function subscription exists before integration tests start producing messages URL: https://github.com/apache/incubator-pulsar/pull/2413 ### Motivation There is a race condition in functions integration

[GitHub] merlimat opened a new pull request #2412: Allow to configure number of IO and managed ledger threads

2018-08-20 Thread GitBox
merlimat opened a new pull request #2412: Allow to configure number of IO and managed ledger threads URL: https://github.com/apache/incubator-pulsar/pull/2412 ### Motivation Default number of thread in many cases is set to `2 * Runtime.getRuntime().availableProcessors()`. Allow to

[GitHub] srkukarni commented on issue #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on issue #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#issuecomment-414487320 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] srkukarni commented on issue #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on issue #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#issuecomment-414487343 run integration tests This is an automated message from the Apache Git

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211428642 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20

[GitHub] sijie commented on issue #2411: [functions] change instance id from string to int and expose number of instances in context

2018-08-20 Thread GitBox
sijie commented on issue #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411#issuecomment-414484405 @jerrypeng @merlimat @srkukarni @rdhabalia : please take a look at this change. the

[GitHub] sijie opened a new pull request #2411: [functions] change instance id from string to int and expose number of instances in context

2018-08-20 Thread GitBox
sijie opened a new pull request #2411: [functions] change instance id from string to int and expose number of instances in context URL: https://github.com/apache/incubator-pulsar/pull/2411 ### Motivation When writing a connector reading from a list of sources, it is hard for

[GitHub] merlimat commented on a change in pull request #2409: Added HDFS Sink

2018-08-20 Thread GitBox
merlimat commented on a change in pull request #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#discussion_r211421759 ## File path: pulsar-io/hdfs/src/main/java/org/apache/pulsar/io/hdfs/AbstractHdfsConfig.java ## @@ -0,0 +1,172 @@ +/** + *

[GitHub] sijie opened a new pull request #2410: [tiered storage] bump jclouds version to 2.1.1

2018-08-20 Thread GitBox
sijie opened a new pull request #2410: [tiered storage] bump jclouds version to 2.1.1 URL: https://github.com/apache/incubator-pulsar/pull/2410 This is an automated message from the Apache Git Service. To respond to the

[GitHub] david-streamlio opened a new pull request #2409: Added HDFS Sink

2018-08-20 Thread GitBox
david-streamlio opened a new pull request #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409 ### Motivation Added the HDFS Sink connector. ### Modifications Added the hfs module to the pulsar-io sub-module ### Result After

[incubator-pulsar] branch master updated: add slf4j handler to log web-server log (#2408)

2018-08-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0bf3494 add slf4j handler to log

[GitHub] merlimat closed pull request #2408: add slf4j handler to log web-server log

2018-08-20 Thread GitBox
merlimat closed pull request #2408: add slf4j handler to log web-server log URL: https://github.com/apache/incubator-pulsar/pull/2408 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211391542 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211391432 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211390843 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211390042 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211389810 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211389840 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -246,6

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211389789 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@

[GitHub] srkukarni commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211389769 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211366341 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -469,20

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211363297 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@ -246,6

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211364130 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211362546 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@ -621,12

[GitHub] sijie commented on a change in pull request #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211362689 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java ## @@ -649,9

[GitHub] sijie commented on issue #189: Dead-Letter Queues

2018-08-20 Thread GitBox
sijie commented on issue #189: Dead-Letter Queues URL: https://github.com/apache/incubator-pulsar/issues/189#issuecomment-414414418 #2400 is implementing dead letter topic. This is an automated message from the Apache Git

[GitHub] sijie commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211359421 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] sijie commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211359463 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] sijie commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211359011 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] sijie commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211357018 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] sijie commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
sijie commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211355980 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentRedeliveryTracker.java

[GitHub] srkukarni commented on issue #2397: Integrate Functions with Schema

2018-08-20 Thread GitBox
srkukarni commented on issue #2397: Integrate Functions with Schema URL: https://github.com/apache/incubator-pulsar/pull/2397#issuecomment-414409433 run integration tests This is an automated message from the Apache Git

[GitHub] sijie opened a new issue #2407: Make sure pulsar configuration files in-sync with the configuration definitions

2018-08-20 Thread GitBox
sijie opened a new issue #2407: Make sure pulsar configuration files in-sync with the configuration definitions URL: https://github.com/apache/incubator-pulsar/issues/2407 ### Problem It seems that following settings are missing at `proxy.conf`. ```

[incubator-pulsar] branch master updated: Make authentication parameters configurable on the pulsar-client-kafka (#2373)

2018-08-20 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6f692af Make authentication

[GitHub] sijie closed pull request #2373: Make authentication parameters configurable on the pulsar-client-kafka

2018-08-20 Thread GitBox
sijie closed pull request #2373: Make authentication parameters configurable on the pulsar-client-kafka URL: https://github.com/apache/incubator-pulsar/pull/2373 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: Fixed initialization order of acknowledgmentsGroupingTracker in ConsumerImpl (#2399)

2018-08-20 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 271c6ee Fixed initialization order of

[GitHub] sijie closed pull request #2399: Fixed initialization order of acknowledgmentsGroupingTracker in ConsumerImpl

2018-08-20 Thread GitBox
sijie closed pull request #2399: Fixed initialization order of acknowledgmentsGroupingTracker in ConsumerImpl URL: https://github.com/apache/incubator-pulsar/pull/2399 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] ivankelly opened a new pull request #2406: Fix flake in DiscoveryServiceTest (#1081)

2018-08-20 Thread GitBox
ivankelly opened a new pull request #2406: Fix flake in DiscoveryServiceTest (#1081) URL: https://github.com/apache/incubator-pulsar/pull/2406 This test was flaking because it was only waiting for 1 second for connection and message exchange to complete, which is not enough time when

[GitHub] ivankelly commented on issue #1126: Intermittent test failure in testSkipCorruptDataLedger

2018-08-20 Thread GitBox
ivankelly commented on issue #1126: Intermittent test failure in testSkipCorruptDataLedger URL: https://github.com/apache/incubator-pulsar/issues/1126#issuecomment-414308800 @merlimat Can this be closed? This is an

[GitHub] ivankelly closed issue #1229: Documentation required for Pulsar Proxy and TLS changes

2018-08-20 Thread GitBox
ivankelly closed issue #1229: Documentation required for Pulsar Proxy and TLS changes URL: https://github.com/apache/incubator-pulsar/issues/1229 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ivankelly commented on issue #1229: Documentation required for Pulsar Proxy and TLS changes

2018-08-20 Thread GitBox
ivankelly commented on issue #1229: Documentation required for Pulsar Proxy and TLS changes URL: https://github.com/apache/incubator-pulsar/issues/1229#issuecomment-414304646 Broke this down into more digestible issues: #1225 -> #2402 #1208 -> #2403 #1169 -> #2404 #1168

[GitHub] jiazhai edited a comment on issue #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai edited a comment on issue #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-414303859 rerun integration tests for org.apache.pulsar.tests.integration.cli.CLITest.pulsar-test-suite

[GitHub] ivankelly commented on issue #1002: Making Pulsar Proxy more secure

2018-08-20 Thread GitBox
ivankelly commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-414304153 @jai1 was the proxy auth action ever added? This is an automated message

[GitHub] jiazhai commented on issue #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai commented on issue #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-414303859 rerun integration tests This is an automated message from the Apache Git Service. To respond

[GitHub] ivankelly opened a new issue #2405: Document configuring the proxy without service discovery

2018-08-20 Thread GitBox
ivankelly opened a new issue #2405: Document configuring the proxy without service discovery URL: https://github.com/apache/incubator-pulsar/issues/2405 Feature was added in #1002 Configuring without service discovery is basically configuring with a broker URL rather than

[GitHub] ivankelly opened a new issue #2404: Document proxy auth data forwarding

2018-08-20 Thread GitBox
ivankelly opened a new issue #2404: Document proxy auth data forwarding URL: https://github.com/apache/incubator-pulsar/issues/2404 Added in #1169 Which auth providers does it work for? How does it interact with proxy roles? Ensure that it is supported in both the binary and

[GitHub] ivankelly opened a new issue #2403: Document hostname verification in TLS transport docs

2018-08-20 Thread GitBox
ivankelly opened a new issue #2403: Document hostname verification in TLS transport docs URL: https://github.com/apache/incubator-pulsar/issues/2403 #1208 Added the feature. Verify that it works, and add documentation to http://pulsar.apache.org/docs/en/security-tls-transport/

[GitHub] ivankelly opened a new issue #2402: Document TLS version and ciphersuite configuration for server and proxy

2018-08-20 Thread GitBox
ivankelly opened a new issue #2402: Document TLS version and ciphersuite configuration for server and proxy URL: https://github.com/apache/incubator-pulsar/issues/2402 #1225 added support for specifying the TLS version and ciphersuite to use when configuring the proxy and broker. However,

[GitHub] massakam commented on issue #2401: Consumer often discards received messages

2018-08-20 Thread GitBox
massakam commented on issue #2401: Consumer often discards received messages URL: https://github.com/apache/incubator-pulsar/issues/2401#issuecomment-414258929 It seems that this error does not occur if I revert the following change and deploy it to the broker side.

[GitHub] massakam opened a new issue #2401: Consumer often discards received messages

2018-08-20 Thread GitBox
massakam opened a new issue #2401: Consumer often discards received messages URL: https://github.com/apache/incubator-pulsar/issues/2401 When TLS is enabled, consumer often discards received messages. The following is the consumer log when a message is discarded. ``` 17:53:52.113

[GitHub] jiazhai commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211190516 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] jiazhai commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211190516 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] jiazhai commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211190516 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java

[GitHub] codelipenghui commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211182494 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@

[GitHub] jiazhai commented on a change in pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai commented on a change in pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211177988 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -867,9

[GitHub] jiazhai commented on issue #2400: Dead Letter Topic

2018-08-20 Thread GitBox
jiazhai commented on issue #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-414237342 @codelipenghui Please take a look of the ut error This is an automated message from the

[GitHub] codelipenghui opened a new pull request #2400: Dead Letter Topic

2018-08-20 Thread GitBox
codelipenghui opened a new pull request #2400: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400 ### Motivation When consumer got messages from pulsar, It's difficult to ensure every message can be consume success. Pulsar support message redelivery feature