[incubator-pulsar] branch master updated: remove unnecessary log message in sink cmd (#1770)

2018-05-14 Thread hrsakai
This is an automated email from the ASF dual-hosted git repository. hrsakai pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 553da65 remove unnecessary log

[GitHub] hrsakai closed pull request #1770: remove unnecessary log message in sink cmd

2018-05-14 Thread GitBox
hrsakai closed pull request #1770: remove unnecessary log message in sink cmd URL: https://github.com/apache/incubator-pulsar/pull/1770 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly commented on issue #1134: Docker compose files for pulsar

2018-05-14 Thread GitBox
ivankelly commented on issue #1134: Docker compose files for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1134#issuecomment-388743208 @raarts these compose files are for testing the current master code. We cannot push images for these to dockerhub, as they are not official

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187852225 ## File path:

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187851866 ## File path:

[GitHub] zhaijack commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
zhaijack commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187867468 ## File path:

[GitHub] zhaijack commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
zhaijack commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187867412 ## File path:

[incubator-pulsar] branch asf-site updated: Updated site at revision 553da65

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 2dea6a0 Updated site at revision

[GitHub] ivankelly commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
ivankelly commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#issuecomment-388793230 retest this please // containers took a too long to start for integration test

[GitHub] sijie commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
sijie commented on issue #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#issuecomment-388942727 retest this please This is an automated message from the

[GitHub] sijie commented on issue #1769: refactor source and sink classname to be pulsar source and sink when not set

2018-05-14 Thread GitBox
sijie commented on issue #1769: refactor source and sink classname to be pulsar source and sink when not set URL: https://github.com/apache/incubator-pulsar/pull/1769#issuecomment-388942456 retest this please This is an

[GitHub] ivankelly commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188082308 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java

[GitHub] merlimat closed pull request #1769: refactor source and sink classname to be pulsar source and sink when not set

2018-05-14 Thread GitBox
merlimat closed pull request #1769: refactor source and sink classname to be pulsar source and sink when not set URL: https://github.com/apache/incubator-pulsar/pull/1769 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[incubator-pulsar] branch master updated: refactor source and sink classname to be pulsar source and sink when not set (#1769)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d6a341f refactor source and sink

[GitHub] lucperkins opened a new pull request #1776: Fix NPE in Pulsar Functions CLI

2018-05-14 Thread GitBox
lucperkins opened a new pull request #1776: Fix NPE in Pulsar Functions CLI URL: https://github.com/apache/incubator-pulsar/pull/1776 As it stands, an NPE is thrown if you try to `create` or `localrun` a function with neither a class name nor a function name supplied, as the CLI will

[GitHub] ivankelly commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188082324 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java

[GitHub] merlimat closed pull request #1775: adding check for auto ack flag

2018-05-14 Thread GitBox
merlimat closed pull request #1775: adding check for auto ack flag URL: https://github.com/apache/incubator-pulsar/pull/1775 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: adding checkout for auto ack (#1775)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 212eb81 adding checkout for auto ack

[GitHub] merlimat commented on issue #1774: Removed multifunction.jar from sources

2018-05-14 Thread GitBox
merlimat commented on issue #1774: Removed multifunction.jar from sources URL: https://github.com/apache/incubator-pulsar/pull/1774#issuecomment-388941275 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1763: Document Python dependencies

2018-05-14 Thread GitBox
merlimat commented on issue #1763: Document Python dependencies URL: https://github.com/apache/incubator-pulsar/pull/1763#issuecomment-388956332 retest this please This is an automated message from the Apache Git Service. To

[GitHub] ivankelly commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188077936 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java

[GitHub] ivankelly commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188078014 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java

[GitHub] sijie commented on issue #1775: adding check for auto ack flag

2018-05-14 Thread GitBox
sijie commented on issue #1775: adding check for auto ack flag URL: https://github.com/apache/incubator-pulsar/pull/1775#issuecomment-388942352 retest this please This is an automated message from the Apache Git Service. To

[GitHub] jerrypeng commented on issue #1771: setting auto ack to be true for sources and sinks

2018-05-14 Thread GitBox
jerrypeng commented on issue #1771: setting auto ack to be true for sources and sinks URL: https://github.com/apache/incubator-pulsar/pull/1771#issuecomment-388953726 retest this please This is an automated message from the

[GitHub] merlimat closed pull request #1774: Removed multifunction.jar from sources

2018-05-14 Thread GitBox
merlimat closed pull request #1774: Removed multifunction.jar from sources URL: https://github.com/apache/incubator-pulsar/pull/1774 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Removed multifunction.jar from sources (#1774)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2c5f5dd Removed multifunction.jar

[GitHub] sijie closed pull request #1766: Implementing PushSource on top of Source

2018-05-14 Thread GitBox
sijie closed pull request #1766: Implementing PushSource on top of Source URL: https://github.com/apache/incubator-pulsar/pull/1766 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
sijie commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188059975 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java ##

[GitHub] sijie commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
sijie commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188060924 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java ##

[GitHub] sijie commented on a change in pull request #1774: Removed multifunction.jar from sources

2018-05-14 Thread GitBox
sijie commented on a change in pull request #1774: Removed multifunction.jar from sources URL: https://github.com/apache/incubator-pulsar/pull/1774#discussion_r188040395 ## File path:

[GitHub] jerrypeng commented on issue #1775: adding check for auto ack flag

2018-05-14 Thread GitBox
jerrypeng commented on issue #1775: adding check for auto ack flag URL: https://github.com/apache/incubator-pulsar/pull/1775#issuecomment-388910620 @srkukarni @sijie please review This is an automated message from the Apache

[GitHub] jerrypeng opened a new pull request #1775: adding check for auto ack flag

2018-05-14 Thread GitBox
jerrypeng opened a new pull request #1775: adding check for auto ack flag URL: https://github.com/apache/incubator-pulsar/pull/1775 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-pulsar] branch master updated: Implementing PushSource on top of Source (#1766)

2018-05-14 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0f84222 Implementing PushSource on

[incubator-pulsar] branch master updated: check record returned by source is not null (#1767)

2018-05-14 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5d6fee3 check record returned by

[GitHub] sijie closed pull request #1767: check record returned by source is not null

2018-05-14 Thread GitBox
sijie closed pull request #1767: check record returned by source is not null URL: https://github.com/apache/incubator-pulsar/pull/1767 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on a change in pull request #1774: Removed multifunction.jar from sources

2018-05-14 Thread GitBox
merlimat commented on a change in pull request #1774: Removed multifunction.jar from sources URL: https://github.com/apache/incubator-pulsar/pull/1774#discussion_r188044421 ## File path:

[GitHub] merlimat opened a new pull request #1774: Removed multifunction.jar from sources

2018-05-14 Thread GitBox
merlimat opened a new pull request #1774: Removed multifunction.jar from sources URL: https://github.com/apache/incubator-pulsar/pull/1774 ### Motivation Removing jar archive that was being included in src distribution.

[GitHub] sijie commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
sijie commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188057314 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java ##

[GitHub] sijie commented on a change in pull request #1768: InputStream to read from S3

2018-05-14 Thread GitBox
sijie commented on a change in pull request #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#discussion_r188056527 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/S3BackedInputStreamImpl.java ##

[GitHub] merlimat commented on issue #1764: WIP - Pulsar Go client library

2018-05-14 Thread GitBox
merlimat commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-388982480 @bruth @lucperkins some more polishing and added `context.Context` arg to `Send()`, `Receive()` and `Next()` calls. Please take another look.

[GitHub] lucperkins opened a new pull request #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins opened a new pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[incubator-pulsar] branch branch-2.0 updated: Functions API compatibility patch for 2.0 (#1777)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/branch-2.0 by this push: new 314f3fb Functions API

[incubator-pulsar] 02/02: Removed multifunction.jar from sources (#1774)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git commit e5d3bda9607703c2e012983c7ef64f5eb4118de7 Author: Matteo Merli AuthorDate: Mon May 14

[incubator-pulsar] 01/02: Encode the path for download (#1765)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git commit d9f48940208ff81c7f5375f45b47d1ea078c7b44 Author: Sanjeev Kulkarni AuthorDate: Thu

[incubator-pulsar] branch branch-2.0 updated (314f3fb -> e5d3bda)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. from 314f3fb Functions API compatibility patch for 2.0 (#1777) new d9f4894 Encode the path for

svn commit: r26903 - in /dev/incubator/pulsar: pulsar-2.0.0-rc1-incubating-candidate-3/ pulsar-2.0.0-rc1-incubating-candidate-4/

2018-05-14 Thread mmerli
Author: mmerli Date: Mon May 14 22:48:46 2018 New Revision: 26903 Log: Staging artifacts and signature for Pulsar release 2.0.0-rc1-incubating Added: dev/incubator/pulsar/pulsar-2.0.0-rc1-incubating-candidate-4/

[GitHub] jerrypeng opened a new pull request #1777: Functions API compatibility patch for 2.0

2018-05-14 Thread GitBox
jerrypeng opened a new pull request #1777: Functions API compatibility patch for 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1777 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jerrypeng commented on issue #1777: Functions API compatibility patch for 2.0

2018-05-14 Thread GitBox
jerrypeng commented on issue #1777: Functions API compatibility patch for 2.0 URL: https://github.com/apache/incubator-pulsar/pull/1777#issuecomment-388975597 @merlimat @sijie @srkukarni please review and make sure that all API breaking changes are in the PR

[GitHub] lucperkins closed pull request #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins closed pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] lucperkins opened a new pull request #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins opened a new pull request #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778 This PR adds vendored dependencies for the Pulsar Go client, in keeping with best practices for Go. The vendoring strategy here uses the

[GitHub] lucperkins commented on issue #1778: Vendored imports

2018-05-14 Thread GitBox
lucperkins commented on issue #1778: Vendored imports URL: https://github.com/apache/incubator-pulsar/pull/1778#issuecomment-388980736 This PR was meant to be targeted to @merlimat's local branch. Closing this PR here. This

[incubator-pulsar] annotated tag v2.0.0-rc1-incubating-candidate-4 updated (e5d3bda -> 553566e)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to annotated tag v2.0.0-rc1-incubating-candidate-4 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. *** WARNING: tag v2.0.0-rc1-incubating-candidate-4 was modified! *** from

[incubator-pulsar] branch master updated: setting auto ack to be true for sources and sinks (#1771)

2018-05-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 75643da setting auto ack to be true

[GitHub] merlimat closed pull request #1771: setting auto ack to be true for sources and sinks

2018-05-14 Thread GitBox
merlimat closed pull request #1771: setting auto ack to be true for sources and sinks URL: https://github.com/apache/incubator-pulsar/pull/1771 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie opened a new pull request #1779: Provide a vagrant file to launch a linux vm for running integration tests

2018-05-14 Thread GitBox
sijie opened a new pull request #1779: Provide a vagrant file to launch a linux vm for running integration tests URL: https://github.com/apache/incubator-pulsar/pull/1779 *Motivation* Currently all pulsar's integration tests and bc tests are docker based and written using

[GitHub] sijie commented on issue #1779: Provide a vagrant file to launch a linux vm for running integration tests

2018-05-14 Thread GitBox
sijie commented on issue #1779: Provide a vagrant file to launch a linux vm for running integration tests URL: https://github.com/apache/incubator-pulsar/pull/1779#issuecomment-389024374 This is same as apache/bookkeeper#1401

[GitHub] hrsakai commented on issue #1780: Move isConnected method into each interface class

2018-05-14 Thread GitBox
hrsakai commented on issue #1780: Move isConnected method into each interface class URL: https://github.com/apache/incubator-pulsar/pull/1780#issuecomment-389035885 retest this please This is an automated message from the

[GitHub] hrsakai opened a new pull request #1780: Move isConnected method into each interface class

2018-05-14 Thread GitBox
hrsakai opened a new pull request #1780: Move isConnected method into each interface class URL: https://github.com/apache/incubator-pulsar/pull/1780 ### Motivation We want to check connection status with a broker on an application side. ### Modifications Move

[GitHub] zhaijack commented on issue #1768: InputStream to read from S3

2018-05-14 Thread GitBox
zhaijack commented on issue #1768: InputStream to read from S3 URL: https://github.com/apache/incubator-pulsar/pull/1768#issuecomment-389039504 retest this please This is an automated message from the Apache Git Service. To

[GitHub] bruth commented on issue #1764: WIP - Pulsar Go client library

2018-05-14 Thread GitBox
bruth commented on issue #1764: WIP - Pulsar Go client library URL: https://github.com/apache/incubator-pulsar/pull/1764#issuecomment-389009412 @merlimat Looks good. I noticed that the `Ack` calls don't take a context, but they (in theory) should. Since they interface with C, I realize

[GitHub] sijie commented on issue #1776: Fix NPE in Pulsar Functions CLI

2018-05-14 Thread GitBox
sijie commented on issue #1776: Fix NPE in Pulsar Functions CLI URL: https://github.com/apache/incubator-pulsar/pull/1776#issuecomment-389024676 @jerrypeng @srkukarni ^^ This is an automated message from the Apache Git

[GitHub] jerrypeng opened a new pull request #1781: fixing behavior when configs are empty

2018-05-14 Thread GitBox
jerrypeng opened a new pull request #1781: fixing behavior when configs are empty URL: https://github.com/apache/incubator-pulsar/pull/1781 This is an automated message from the Apache Git Service. To respond to the