[GitHub] sijie closed pull request #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest

2018-04-13 Thread GitBox
sijie closed pull request #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest URL: https://github.com/apache/incubator-pulsar/pull/1576 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] sijie closed issue #1575: Intermittent failure in SubscriptionMessageDispatchThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling

2018-04-13 Thread GitBox
sijie closed issue #1575: Intermittent failure in SubscriptionMessageDispatchThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling URL: https://github.com/apache/incubator-pulsar/issues/1575 This is an automa

[incubator-pulsar] branch master updated: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest (#1576)

2018-04-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new afd4382 Fix for intermittent test fail

[GitHub] sijie closed pull request #1573: Set admin brokers content type.

2018-04-13 Thread GitBox
sijie closed pull request #1573: Set admin brokers content type. URL: https://github.com/apache/incubator-pulsar/pull/1573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Set admin brokers content type. (#1573)

2018-04-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4226d45 Set admin brokers content type

[GitHub] sijie closed pull request #1577: Fixed BatchMessageTest intermittent failures

2018-04-13 Thread GitBox
sijie closed pull request #1577: Fixed BatchMessageTest intermittent failures URL: https://github.com/apache/incubator-pulsar/pull/1577 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Fixed BatchMessageTest intermittent failures (#1577)

2018-04-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2d4a350 Fixed BatchMessageTest intermi

[incubator-pulsar.wiki] branch master updated: Updated PIP 7: Pulsar Failure domain and Anti affinity namespaces (markdown)

2018-04-13 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 2e488b6 Updated PIP 7: Pulsar

[GitHub] merlimat opened a new pull request #1578: Renamed "property" into "tenant"

2018-04-13 Thread GitBox
merlimat opened a new pull request #1578: Renamed "property" into "tenant" URL: https://github.com/apache/incubator-pulsar/pull/1578 ### Motivation Pulsar uses the term "property" to identify differents tenants. The term is a bit confusing to newcomers because it's not clear what a "

[GitHub] merlimat commented on issue #1573: Set admin brokers content type.

2018-04-13 Thread GitBox
merlimat commented on issue #1573: Set admin brokers content type. URL: https://github.com/apache/incubator-pulsar/pull/1573#issuecomment-381290681 retest this please This is an automated message from the Apache Git Service. T

[GitHub] merlimat commented on issue #1564: Support short topic name in cpp client

2018-04-13 Thread GitBox
merlimat commented on issue #1564: Support short topic name in cpp client URL: https://github.com/apache/incubator-pulsar/pull/1564#issuecomment-381289896 @sijie I think the c++ format check failed to validate. This is an auto

[incubator-pulsar] branch master updated: Fix bug that WebSocket proxy returns empty metrics (#1567)

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new aa9e306 Fix bug that WebSocket proxy

[GitHub] merlimat closed pull request #1567: Fix bug that WebSocket proxy returns empty metrics

2018-04-13 Thread GitBox
merlimat closed pull request #1567: Fix bug that WebSocket proxy returns empty metrics URL: https://github.com/apache/incubator-pulsar/pull/1567 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat commented on issue #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest

2018-04-13 Thread GitBox
merlimat commented on issue #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest URL: https://github.com/apache/incubator-pulsar/pull/1576#issuecomment-381287806 retest this please This is an

[GitHub] merlimat commented on issue #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest

2018-04-13 Thread GitBox
merlimat commented on issue #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest URL: https://github.com/apache/incubator-pulsar/pull/1576#issuecomment-381287806 retest this please This is an

[GitHub] merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574#issuecomment-381286460 retest this please This is an automated message from the A

[GitHub] merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574#issuecomment-381286460 retest this please This is an automated message from the A

[GitHub] merlimat opened a new pull request #1577: Fixed BatchMessageTest intermittent failures

2018-04-13 Thread GitBox
merlimat opened a new pull request #1577: Fixed BatchMessageTest intermittent failures URL: https://github.com/apache/incubator-pulsar/pull/1577 ### Motivation This test became flaky after the delayed acks changed went it. Basically, with delayed acks, the backlog doesn't go to 0 im

[GitHub] merlimat closed issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic

2018-04-13 Thread GitBox
merlimat closed issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic URL: https://github.com/apache/incubator-pulsar/issues/635 This is an automated message from the Apache Git Service. To re

[GitHub] merlimat closed issue #1517: Reader#hasMessageAvailable can report false when it should be true

2018-04-13 Thread GitBox
merlimat closed issue #1517: Reader#hasMessageAvailable can report false when it should be true URL: https://github.com/apache/incubator-pulsar/issues/1517 This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574#issuecomment-381276996 retest this please This is an automated message from the A

[GitHub] merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574#issuecomment-381250382 retest this please This is an automated message from the A

[GitHub] merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574#issuecomment-381276996 retest this please This is an automated message from the A

[GitHub] merlimat opened a new pull request #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest

2018-04-13 Thread GitBox
merlimat opened a new pull request #1576: Fix for intermittent test failure in SubscriptionMessageDispatchThrottlingTest URL: https://github.com/apache/incubator-pulsar/pull/1576 ### Motivation The test is failing intermittently because of interference between the different runs. Us

[incubator-pulsar] branch master updated: Provide unshaded pulsar-kafka-client (#1566)

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 31dae05 Provide unshaded pulsar-kafka

[GitHub] merlimat closed pull request #1566: Provide unshaded pulsar-kafka-client

2018-04-13 Thread GitBox
merlimat closed pull request #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] merlimat commented on issue #1546: Fix: handle failure of topic stat update

2018-04-13 Thread GitBox
merlimat commented on issue #1546: Fix: handle failure of topic stat update URL: https://github.com/apache/incubator-pulsar/pull/1546#issuecomment-381256007 retest this please This is an automated message from the Apache Git S

[GitHub] merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat commented on issue #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574#issuecomment-381250382 retest this please This is an automated message from the A

[GitHub] merlimat commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566#discussion_r181500014 ## File path: site/docs/latest/adaptors/KafkaWrapper.md ## @@ -60,6 +60,21 @@ thing that needs to be a

[incubator-pulsar] branch master updated: Introduce admin api to get broker and namespace-isolation policy map (#1565)

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fc67fe2 Introduce admin api to get br

[GitHub] merlimat closed pull request #1565: Introduce admin api to get broker and namespace-isolation policy map

2018-04-13 Thread GitBox
merlimat closed pull request #1565: Introduce admin api to get broker and namespace-isolation policy map URL: https://github.com/apache/incubator-pulsar/pull/1565 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[GitHub] merlimat opened a new issue #1575: Intermittent failure in SubscriptionMessageDispatchThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling

2018-04-13 Thread GitBox
merlimat opened a new issue #1575: Intermittent failure in SubscriptionMessageDispatchThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottling URL: https://github.com/apache/incubator-pulsar/issues/1575 Seen this test failing few times: https://builds.apache.org/job/pul

[GitHub] sijie commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client

2018-04-13 Thread GitBox
sijie commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566#discussion_r181497464 ## File path: site/docs/latest/adaptors/KafkaWrapper.md ## @@ -60,6 +60,21 @@ thing that needs to be adju

[GitHub] sijie commented on issue #1564: Support short topic name in cpp client

2018-04-13 Thread GitBox
sijie commented on issue #1564: Support short topic name in cpp client URL: https://github.com/apache/incubator-pulsar/pull/1564#issuecomment-381244122 @merlimat fixed the tests This is an automated message from the Apache Git

[incubator-pulsar] branch master updated: moving function worker service to pulsar service (#1568)

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new aba0d42 moving function worker servic

[GitHub] merlimat closed pull request #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
merlimat closed pull request #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] merlimat commented on issue #1565: Introduce admin api to get broker and namespace-isolation policy map

2018-04-13 Thread GitBox
merlimat commented on issue #1565: Introduce admin api to get broker and namespace-isolation policy map URL: https://github.com/apache/incubator-pulsar/pull/1565#issuecomment-381225959 There are some compilation errors: ``` 2018-04-12\T\23:34:40.670 [ERROR] Failed to execute goal or

[incubator-pulsar] branch master updated: Compaction CLI integration test (#1572)

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5c21b33 Compaction CLI integration te

[GitHub] merlimat commented on a change in pull request #1572: Compaction CLI integration test

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1572: Compaction CLI integration test URL: https://github.com/apache/incubator-pulsar/pull/1572#discussion_r181473157 ## File path: tests/integration/compaction/src/test/java/org/apache/pulsar/tests/integration/TestCompaction.java ##

[GitHub] merlimat closed pull request #1572: Compaction CLI integration test

2018-04-13 Thread GitBox
merlimat closed pull request #1572: Compaction CLI integration test URL: https://github.com/apache/incubator-pulsar/pull/1572 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] merlimat opened a new pull request #1574: Converted and duplicated AdminApiTest to v2 topics

2018-04-13 Thread GitBox
merlimat opened a new pull request #1574: Converted and duplicated AdminApiTest to v2 topics URL: https://github.com/apache/incubator-pulsar/pull/1574 ### Motivation Converted and duplicated AdminApiTest to v2 topics format. Fixed issues in Admin API when using new format.

[GitHub] cckellogg opened a new pull request #1573: Set admin brokers content type.

2018-04-13 Thread GitBox
cckellogg opened a new pull request #1573: Set admin brokers content type. URL: https://github.com/apache/incubator-pulsar/pull/1573 Add a content type to the brokers admin rest api endpoints. This is an automated message

[GitHub] jerrypeng commented on issue #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
jerrypeng commented on issue #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568#issuecomment-381210995 @merlimat thanks for the review. I have addressed your comment

[GitHub] jerrypeng commented on a change in pull request #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
jerrypeng commented on a change in pull request #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568#discussion_r181459655 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ##

[GitHub] merlimat commented on a change in pull request #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/1527#discussion_r181456643 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181449951 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java #

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181449813 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java #

[GitHub] sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
sijie commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181447810 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java #

[GitHub] merlimat commented on a change in pull request #1572: Compaction CLI integration test

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1572: Compaction CLI integration test URL: https://github.com/apache/incubator-pulsar/pull/1572#discussion_r181445921 ## File path: tests/integration/compaction/src/test/java/org/apache/pulsar/tests/integration/TestCompaction.java ##

[GitHub] merlimat commented on issue #1564: Support short topic name in cpp client

2018-04-13 Thread GitBox
merlimat commented on issue #1564: Support short topic name in cpp client URL: https://github.com/apache/incubator-pulsar/pull/1564#issuecomment-381192537 It looks there are still some tests failing : ``` FAILED TESTS (5/98): 45 ms: ./main TopicNameTest.testShortTopicName

[GitHub] ivankelly opened a new pull request #1572: Compaction CLI integration test

2018-04-13 Thread GitBox
ivankelly opened a new pull request #1572: Compaction CLI integration test URL: https://github.com/apache/incubator-pulsar/pull/1572 Integration test to exercise CLI based compaction from end to end. This is an automated m

[GitHub] merlimat commented on a change in pull request #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568#discussion_r181438813 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ##

[GitHub] merlimat commented on issue #1571: `No such ledger exists` error

2018-04-13 Thread GitBox
merlimat commented on issue #1571: `No such ledger exists` error URL: https://github.com/apache/incubator-pulsar/issues/1571#issuecomment-381185782 For the skipping part: ``` bin/pulsar admin persistent skip $TOPIC --subscription $SUBSCRIPTION --count 1 ``` -

[GitHub] merlimat commented on issue #1571: `No such ledger exists` error

2018-04-13 Thread GitBox
merlimat commented on issue #1571: `No such ledger exists` error URL: https://github.com/apache/incubator-pulsar/issues/1571#issuecomment-381185476 @bardock Skipping messages from that ledger should solve the issue. In particular you can get the internal stats for the topic:

[GitHub] merlimat commented on issue #784: Intermittent failure in C++ BasicEndToEndTest

2018-04-13 Thread GitBox
merlimat commented on issue #784: Intermittent failure in C++ BasicEndToEndTest URL: https://github.com/apache/incubator-pulsar/issues/784#issuecomment-381183340 @jai1 This test keeps failing in the C++ build. ``` log4cxx: Could not read configuration file [log4cxx.conf]. 

[GitHub] merlimat commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566#discussion_r181433714 ## File path: site/docs/latest/adaptors/KafkaWrapper.md ## @@ -60,6 +60,21 @@ thing that needs to be a

[GitHub] srkukarni commented on issue #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
srkukarni commented on issue #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568#issuecomment-381180723 retest this please This is an automated message from the Ap

[GitHub] merlimat commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client

2018-04-13 Thread GitBox
merlimat commented on a change in pull request #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566#discussion_r181433714 ## File path: site/docs/latest/adaptors/KafkaWrapper.md ## @@ -60,6 +60,21 @@ thing that needs to be a

[incubator-pulsar] branch master updated: Increase integration test service wait default timeouts (#1569)

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5d2c038 Increase integration test ser

[GitHub] merlimat closed pull request #1569: Increase integration test service wait default timeouts

2018-04-13 Thread GitBox
merlimat closed pull request #1569: Increase integration test service wait default timeouts URL: https://github.com/apache/incubator-pulsar/pull/1569 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] bardock opened a new issue #1571: `No such ledger exists` error

2018-04-13 Thread GitBox
bardock opened a new issue #1571: `No such ledger exists` error URL: https://github.com/apache/incubator-pulsar/issues/1571 A broker owner of a topic partition is always failing trying to read a ledger because ledger doesn't exist in bookkeeper (we checked using `bookkeeper shell ledger`).

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181416227 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181420020 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181392885 ## File path: managed-ledger/src/main/proto/MLDataFormats.proto ## @@ -27,6 +27,7 @@ messa

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181396437 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181391675 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181391482 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181392254 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181392411 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181395155 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181391727 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger

2018-04-13 Thread GitBox
ivankelly commented on a change in pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181392694 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.jav

[GitHub] massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics

2018-04-13 Thread GitBox
massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics URL: https://github.com/apache/incubator-pulsar/pull/1567#issuecomment-381132366 rretest this please This is an automated message from the

[GitHub] massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics

2018-04-13 Thread GitBox
massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics URL: https://github.com/apache/incubator-pulsar/pull/1567#issuecomment-381112709 retest this please This is an automated message from the A

[GitHub] ivankelly commented on issue #1569: Increase integration test service wait default timeouts

2018-04-13 Thread GitBox
ivankelly commented on issue #1569: Increase integration test service wait default timeouts URL: https://github.com/apache/incubator-pulsar/pull/1569#issuecomment-381138038 retest this please // SubscriptionMessageDispatchThrottlingTest.testBytesRateLimitingReceiveAllMessagesAfterThrottlin

[GitHub] ivankelly opened a new pull request #1570: Add metadata to compacted topic ledger on creation

2018-04-13 Thread GitBox
ivankelly opened a new pull request #1570: Add metadata to compacted topic ledger on creation URL: https://github.com/apache/incubator-pulsar/pull/1570 This can be used by ops to identify what the ledger is, and where it can be cleaned up. There are corner cases where a compacted topic

[GitHub] massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics

2018-04-13 Thread GitBox
massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics URL: https://github.com/apache/incubator-pulsar/pull/1567#issuecomment-381132366 rretest this please This is an automated message from the

[GitHub] massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics

2018-04-13 Thread GitBox
massakam commented on issue #1567: Fix bug that WebSocket proxy returns empty metrics URL: https://github.com/apache/incubator-pulsar/pull/1567#issuecomment-381112709 retest this please This is an automated message from the A

[GitHub] zhaijack commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic

2018-04-13 Thread GitBox
zhaijack commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/1527#issuecomment-381080436 @merlimat Thanks for the comments, updated it. ---

[GitHub] ivankelly opened a new pull request #1569: Increase integration test service wait default timeouts

2018-04-13 Thread GitBox
ivankelly opened a new pull request #1569: Increase integration test service wait default timeouts URL: https://github.com/apache/incubator-pulsar/pull/1569 The integration tests have a set utility methods to wait for all brokers or all proxy nodes to come up. The timeout on these

[incubator-pulsar] branch asf-site updated: Updated site at revision 616e2a2

2018-04-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 4b7e0a8 Updated site at revision

[GitHub] jerrypeng commented on issue #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
jerrypeng commented on issue #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568#issuecomment-381059149 @sijie @merlimat @srkukarni please review This is an automa

[GitHub] jerrypeng opened a new pull request #1568: moving function worker service to pulsar service

2018-04-13 Thread GitBox
jerrypeng opened a new pull request #1568: moving function worker service to pulsar service URL: https://github.com/apache/incubator-pulsar/pull/1568 ### Motivation Currently, function worker service is started after the pulsar service which also starts the web service server. This

[GitHub] massakam opened a new pull request #1567: Fix bug that WebSocket proxy returns empty metrics

2018-04-13 Thread GitBox
massakam opened a new pull request #1567: Fix bug that WebSocket proxy returns empty metrics URL: https://github.com/apache/incubator-pulsar/pull/1567 ### Motivation WebSocket proxy provides an endpoint for obtaining metrics. ``` /admin/proxy-stats/metrics ``` However, I

[GitHub] sijie commented on issue #1566: Provide unshaded pulsar-kafka-client

2018-04-13 Thread GitBox
sijie commented on issue #1566: Provide unshaded pulsar-kafka-client URL: https://github.com/apache/incubator-pulsar/pull/1566#issuecomment-381050322 @merlimat update the doc to include section how to use `pulsar-kafka-client-original` --

[GitHub] zhaijack commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic

2018-04-13 Thread GitBox
zhaijack commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/1527#issuecomment-381044020 retest this please Jenkins: C++ / Python Tests org.apache.pulsar.broker.service.ReplicatorT

[GitHub] zhaijack commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic

2018-04-13 Thread GitBox
zhaijack commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/1527#issuecomment-381044020 retest this please This is an aut