[royale-asjs] branch develop updated: SparkRoyale: Make similar behavior to Flex for components. If component has some viewport bead it will override clipAndEnableScrolling behavior. If doesn't have c
This is an automated email from the ASF dual-hosted git repository.
piotrz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 85a8b58 SparkRoyale: Make similar behavior to Flex for components. If
component has some viewport bead it will override clipAndEnableScrolling
behavior. If doesn't have clipAndEnableScrolling sets to false will sets
overflow to "visible" - which hopefully replicates Flex behavior
85a8b58 is described below
commit 85a8b586ee78015eec8dfe3d801f211b5231232d
Author: Piotr Zarzycki
AuthorDate: Thu Nov 26 08:00:37 2020 +0100
SparkRoyale: Make similar behavior to Flex for components. If component has
some viewport bead it will override clipAndEnableScrolling behavior. If doesn't
have clipAndEnableScrolling sets to false will sets overflow to "visible" -
which hopefully replicates Flex behavior
---
.../spark/components/beads/SparkSkinScrollingViewport.as| 13 +
.../royale/spark/components/supportClasses/GroupBase.as | 2 +-
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
index 6e2d296..5ecbdb2 100644
---
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
+++
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
@@ -86,18 +86,7 @@ public class SparkSkinScrollingViewport extends
SparkSkinViewport implements ISc
COMPILE::JS
protected function setScrollStyle():void
{
-var viewPortArea:IViewport = contentArea as IViewport;
-if (viewPortArea && !viewPortArea.clipAndEnableScrolling)
-{
-if (contentArea.element.style.overflow != "unset")
-{
-contentArea.element.style.overflow = "unset";
-}
-}
-else
-{
-contentArea.element.style.overflow = "auto";
-}
+contentArea.element.style.overflow = "auto";
}
COMPILE::SWF
diff --git
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
index 939079e..3ce13ff 100644
---
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
+++
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
@@ -790,7 +790,7 @@ public class GroupBase extends UIComponent implements
ILayoutParent, IContainer,
{
COMPILE::JS
{
-element.style.overflow = value ? "auto" : "unset";
+element.style.overflow = value ? "auto" : "visible";
}
COMPILE::SWF
{
[royale-asjs] branch develop updated: Adhere to event protocol in unimplemented effects
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new cc2002d Adhere to event protocol in unimplemented effects
cc2002d is described below
commit cc2002d8c473da4e79b2e4fa59306e1ae477542f
Author: Yishay Weiss
AuthorDate: Thu Nov 26 05:07:26 2020 +
Adhere to event protocol in unimplemented effects
---
.../SparkRoyale/src/main/royale/spark/effects/Resize.as| 8
.../SparkRoyale/src/main/royale/spark/effects/SetAction.as | 10 ++
2 files changed, 18 insertions(+)
diff --git
a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
index 46c5267..57c1835 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
@@ -19,6 +19,7 @@
package spark.effects
{
import mx.core.mx_internal;
+import mx.events.EffectEvent;
import mx.effects.IEffectInstance;
import spark.effects.supportClasses.ResizeInstance;
@@ -295,5 +296,12 @@ public class Resize extends Animate
return propertyChanges;
}
+// not implemented
+override public function play():void
+ {
+ // until this effect is implemented we don't want to get in the
way of transitions
+ dispatchEvent(new EffectEvent("effectEnd"));
+ }
+
}
}
diff --git
a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
index 8f1e89e..d00eec0 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
@@ -21,6 +21,7 @@ package spark.effects
{
import spark.effects.supportClasses.SetActionInstance;
+import mx.events.EffectEvent;
import mx.effects.Effect;
import mx.effects.IEffectInstance;
@@ -174,6 +175,15 @@ public class SetAction extends Effect
actionInstance.property = property;
actionInstance.value = value;
}
+
+
+// not implemented
+override public function play():void
+ {
+ // until this effect is implemented we don't want to get in the
way of transitions
+ dispatchEvent(new EffectEvent("effectEnd"));
+ }
+
}
}
[royale-asjs] branch develop updated: SparkRoyale: Make clipAndEnableScrolling true default temporary - discussing more proper approach - it helps properly working stuff in JS
This is an automated email from the ASF dual-hosted git repository. piotrz pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git The following commit(s) were added to refs/heads/develop by this push: new b31bc50 SparkRoyale: Make clipAndEnableScrolling true default temporary - discussing more proper approach - it helps properly working stuff in JS b31bc50 is described below commit b31bc50f9b6249be89c6de092428b1ee38523a69 Author: Piotr Zarzycki AuthorDate: Wed Nov 25 20:41:05 2020 +0100 SparkRoyale: Make clipAndEnableScrolling true default temporary - discussing more proper approach - it helps properly working stuff in JS --- .../src/main/royale/spark/components/supportClasses/GroupBase.as| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as index 3c36a34..939079e 100644 --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as @@ -759,7 +759,7 @@ public class GroupBase extends UIComponent implements ILayoutParent, IContainer, // clipAndEnableScrolling //-- -private var _clipAndEnableScrolling:Boolean = false; +private var _clipAndEnableScrolling:Boolean = true; /** * @copy spark.core.IViewport#clipAndEnableScrolling
[royale-asjs] branch develop updated: SparkRoyale: Start respecting clipAndEnableScrolling property provided by skin/IViewPort part of component - clipAndEnableScrolling set overflow to "unset" instea
This is an automated email from the ASF dual-hosted git repository.
piotrz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 00c5b6c SparkRoyale: Start respecting clipAndEnableScrolling property
provided by skin/IViewPort part of component - clipAndEnableScrolling set
overflow to "unset" instead "none" which is proper value for that property
00c5b6c is described below
commit 00c5b6c687fdf29164f58d4cc66d858bafd07dd5
Author: Piotr Zarzycki
AuthorDate: Wed Nov 25 19:54:42 2020 +0100
SparkRoyale: Start respecting clipAndEnableScrolling property provided by
skin/IViewPort part of component
- clipAndEnableScrolling set overflow to "unset" instead "none" which is
proper value for that property
---
.../components/beads/SparkSkinScrollingViewport.as | 18 --
.../spark/components/supportClasses/GroupBase.as | 2 +-
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
index 14ac721..6e2d296 100644
---
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
+++
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
@@ -21,7 +21,10 @@ package spark.components.beads
{
import mx.core.mx_internal;
-use namespace mx_internal;
+
+import spark.core.IViewport;
+
+use namespace mx_internal;
import spark.components.supportClasses.GroupBase;
import spark.components.supportClasses.SkinnableComponent;
@@ -83,7 +86,18 @@ public class SparkSkinScrollingViewport extends
SparkSkinViewport implements ISc
COMPILE::JS
protected function setScrollStyle():void
{
-contentArea.element.style.overflow = "auto";
+var viewPortArea:IViewport = contentArea as IViewport;
+if (viewPortArea && !viewPortArea.clipAndEnableScrolling)
+{
+if (contentArea.element.style.overflow != "unset")
+{
+contentArea.element.style.overflow = "unset";
+}
+}
+else
+{
+contentArea.element.style.overflow = "auto";
+}
}
COMPILE::SWF
diff --git
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
index 4b7a890..3c36a34 100644
---
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
+++
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
@@ -790,7 +790,7 @@ public class GroupBase extends UIComponent implements
ILayoutParent, IContainer,
{
COMPILE::JS
{
-element.style.overflow = value ? "auto" : "none";
+element.style.overflow = value ? "auto" : "unset";
}
COMPILE::SWF
{
