[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-17 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r456394839 ## File path: topi/python/topi/math.py ## @@ -612,6 +612,31 @@ def _compute(*indices): return tvm.te.max(tvm.te.min(value, const_max),

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454545412 ## File path: src/relay/qnn/op/requantize.cc ## @@ -153,9 +153,19 @@ Expr RequantizeLower(const Expr& input_tensor, const Expr& input_scale,

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454543214 ## File path: include/tvm/tir/op.h ## @@ -552,6 +552,24 @@ TVM_DLL PrimExpr trunc(PrimExpr x); */ TVM_DLL PrimExpr LargeUIntImm(DataType dtype,

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454477447 ## File path: topi/python/topi/arm_cpu/injective.py ## @@ -62,9 +62,13 @@ def schedule_injective(outs): outs = [outs] if isinstance(outs,

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454462182 ## File path: python/tvm/tir/op.py ## @@ -965,6 +965,34 @@ def popcount(x): """ return call_intrin(x.dtype, "tir.popcount", x) +def

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454423764 ## File path: src/target/intrin_rule.cc ## @@ -115,6 +115,51 @@ TVM_REGISTER_GLOBAL("tvm.intrin.rule.default.isinf") *rv =

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454420817 ## File path: src/relay/op/tensor/unary.cc ## @@ -274,6 +274,20 @@ TVM_REGISTER_GLOBAL("relay.op._make.clip").set_body_typed([](Expr a, double

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-14 Thread GitBox
giuseros commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454404831 ## File path: include/tvm/tir/builtin.h ## @@ -92,6 +92,14 @@ TVM_DLL const Op& shift_right(); */ TVM_DLL const Op& large_uint_imm(); +/*! +