kazum opened a new pull request #5494:
URL: https://github.com/apache/incubator-tvm/pull/5494
This is necessary to add tests for #5489.
@jroesch @nhynes @ehsanmok @tqchen Please help to review.
This is an automated mes
icemelon9 commented on a change in pull request #5357:
URL: https://github.com/apache/incubator-tvm/pull/5357#discussion_r418430603
##
File path: python/tvm/relay/op/strategy/x86.py
##
@@ -18,13 +18,17 @@
# pylint:
disable=invalid-name,unused-argument,wildcard-import,unused-w
tmoreau89 commented on a change in pull request #5:
URL: https://github.com/apache/incubator-tvm-vta/pull/5#discussion_r418425846
##
File path: apps/deploy/Makefile
##
@@ -0,0 +1,71 @@
+#licensed to the Apache Software Foundation (ASF) under one
Review comment:
`#licens
This is an automated email from the ASF dual-hosted git repository.
moreau pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm-vta.git
The following commit(s) were added to refs/heads/master by this push:
new 21937a0 [pynq_driver] fix device ear
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new 12e737f Make "none" DataType explicit (#
tqchen commented on pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#issuecomment-622250434
Thanks @kparzysz-quic !
This is an automated message from the Apache Git Service.
To respond to the message
spectrometerHBH edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622238350
To avoid making this page too long, I will edit&update the examples for
reference in the top comment if I change the format.
--
spectrometerHBH commented on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622238350
To avoid making this page too long, I will edit&update the examples for
reference in the top if I change the format.
-
spectrometerHBH commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418406985
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418401901
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
spectrometerHBH commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418401170
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
spectrometerHBH commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418400818
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
spectrometerHBH commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418378401
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
spectrometerHBH edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622203710
> Some comments:
>
> 1. There are more than one spaces before the left brace in the allocation
line
>```
>allocate(B.local, float32, [64
spectrometerHBH edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622203710
> Some comments:
>
> 1. There are more than one spaces before the left brace in the allocation
line
>```
>allocate(B.local, float32, [64
spectrometerHBH edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622203710
> Some comments:
>
> 1. There are more than one spaces before the left brace in the allocation
line
>```
>allocate(B.local, float32, [64
spectrometerHBH commented on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622203710
> Some comments:
>
> 1. There are more than one spaces before the left brace in the allocation
line
>```
>allocate(B.local, float32, [64]) {
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418371862
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418371548
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418370164
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418368333
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418368333
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418367759
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418367759
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418365372
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
junrushao1994 commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r418364252
##
File path: src/printer/tir_text_printer.cc
##
@@ -0,0 +1,735 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
lixiaoquan commented on a change in pull request #5429:
URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r418341379
##
File path: include/tvm/relay/op_attr_types.h
##
@@ -81,10 +81,16 @@ using TOpIsStateful = bool;
*/
using TNonComputational = bool;
+enum
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 9bbf58a Removing older Object detection TFlite test (#5477)
add 3aa103e [IR] Initial stab at std::strin
comaniac commented on pull request #5493:
URL: https://github.com/apache/incubator-tvm/pull/5493#issuecomment-622139182
Ah I think that's because I manually ran clang-format for the file. We
should definitely build style checker in CI.
-
zhiics commented on pull request #5493:
URL: https://github.com/apache/incubator-tvm/pull/5493#issuecomment-622129716
@mbrookhart please take a look for the mixed mutator pattern. BTW, we will
still need to refactor the infertype pass as it is the most frequently used
pass.
@comania
zhiics opened a new pull request #5493:
URL: https://github.com/apache/incubator-tvm/pull/5493
This PR refactors the partitioning pass by using non-recursive mutator. It
also removes the unnecessary mutators as we only need to look at begin/end
annotations which are definitely wrapped in c
kevinthesun commented on a change in pull request #5467:
URL: https://github.com/apache/incubator-tvm/pull/5467#discussion_r418284406
##
File path: src/relay/op/memory/memory.cc
##
@@ -360,12 +360,26 @@ bool ShapeFuncRel(const Array& types, int
num_inputs, const Attrs& attrs,
kevinthesun commented on a change in pull request #5467:
URL: https://github.com/apache/incubator-tvm/pull/5467#discussion_r418284406
##
File path: src/relay/op/memory/memory.cc
##
@@ -360,12 +360,26 @@ bool ShapeFuncRel(const Array& types, int
num_inputs, const Attrs& attrs,
jroesch commented on a change in pull request #5467:
URL: https://github.com/apache/incubator-tvm/pull/5467#discussion_r418270872
##
File path: src/relay/op/memory/memory.cc
##
@@ -360,12 +360,26 @@ bool ShapeFuncRel(const Array& types, int
num_inputs, const Attrs& attrs,
a
kparzysz-quic commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418270642
##
File path: include/tvm/runtime/data_type.h
##
@@ -211,6 +215,13 @@ class DataType {
static DataType Handle(int bits = 64, int lanes = 1)
tqchen commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418268635
##
File path: include/tvm/runtime/data_type.h
##
@@ -211,6 +215,13 @@ class DataType {
static DataType Handle(int bits = 64, int lanes = 1) {
jroesch commented on pull request #5489:
URL: https://github.com/apache/incubator-tvm/pull/5489#issuecomment-622091138
Could you actually add some kind of test which checks that we compile
correctly for WASM target?
This is
kparzysz-quic commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418263860
##
File path: include/tvm/runtime/data_type.h
##
@@ -211,6 +215,13 @@ class DataType {
static DataType Handle(int bits = 64, int lanes = 1)
tqchen commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418253950
##
File path: include/tvm/runtime/data_type.h
##
@@ -211,6 +215,13 @@ class DataType {
static DataType Handle(int bits = 64, int lanes = 1) {
ehsanmok commented on pull request #5489:
URL: https://github.com/apache/incubator-tvm/pull/5489#issuecomment-622074069
Thanks @kazum! LGTM.
This is an automated message from the Apache Git Service.
To respond to the message,
kparzysz-quic opened a new pull request #5492:
URL: https://github.com/apache/incubator-tvm/pull/5492
The driver (`sim_dev` executable) is the process running on the Hexagon
simulator that handles the Hexagon-side communication with the TVM runtime
running on x86. The x86-side is implemen
tqchen edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622071330
- Allocate `float32x32` is not the actual data type. Perhaps we can just
show allocate the flattened size since that is the semantics.
- eval is not necessary sin
tqchen edited a comment on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622071330
- Allocate `float32x32` is not the actual data type. Perhaps we can just
show allocate the flattened size since that is the semantics.
- eval is not necessary sin
tqchen commented on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-622071330
- Allocate `float32x32` is not the actual data type. Perhaps we can just
show allocate the flattened size since that is the semantics.
- eval is not necessary since they
kparzysz-quic opened a new pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491
The `None` data type is created when converting an empty string to
`DataType`.
Add functions to create it and recognize it. Convert it to the `void` LLVM
type in LLVM codegen (it wa
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 8d72496 [RUNTIME][uTVM] AutoTVM + uTVM for Cortex-M7 (#5417)
add 9bbf58a Removing older Object detectio
tqchen commented on issue #5221:
URL: https://github.com/apache/incubator-tvm/issues/5221#issuecomment-622051555
close as we have a printable version, see also
https://github.com/apache/incubator-tvm/pull/5483
This is an aut
tqchen commented on issue #5396:
URL: https://github.com/apache/incubator-tvm/issues/5396#issuecomment-622050912
All the docs change are landed by now
This is an automated message from the Apache Git Service.
To respond to t
tqchen commented on issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-622050597
cc @icemelon9 @jroesch @zhiics please chime in if you would like to take a
stab
This is an automated message fr
tqchen opened a new issue #5490:
URL: https://github.com/apache/incubator-tvm/issues/5490
This is an issue to track the progress of std::string -> String migration in
IR Nodes.
- [ ] Merge initial example https://github.com/apache/incubator-tvm/pull/5438
- [ ] Convert relay nodes
kazum commented on issue #5464:
URL: https://github.com/apache/incubator-tvm/issues/5464#issuecomment-622013436
It looks wrong and should be fixed, I think.
This is an automated message from the Apache Git Service.
To respond
tmoreau89 commented on pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#issuecomment-622010729
Thanks @areusch , @liangfu @weberlo @u99127 the PR has been merged
This is an automated message from the
kazum opened a new pull request #5489:
URL: https://github.com/apache/incubator-tvm/pull/5489
This PR fixes warnings and errors when targeting wasm32.
- Update the BackendPackedCFunc signature which was changed in #4637.
- Use derive_default() for bindgen to handle the generated paddin
huajsj commented on pull request #5:
URL: https://github.com/apache/incubator-tvm-vta/pull/5#issuecomment-621996958
@tmoreau89 , thanks for the kindly follow up, the code& test done, if you
have time, could you help to have a review? Thanks.
--
huajsj commented on pull request #7:
URL: https://github.com/apache/incubator-tvm-vta/pull/7#issuecomment-621981787
@remotego , thanks for the detailed explain, the logic make sense, code LGTM.
This is an automated me
kevinthesun commented on pull request #5457:
URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-621979744
Thanks @zhiics @MarisaKirisame
This is an automated message from the Apache Git Service.
To respond t
This is an automated email from the ASF dual-hosted git repository.
kevinthesun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new ae89afe [Fix] Add ConstantNode to I
kparzysz-quic commented on pull request #5487:
URL: https://github.com/apache/incubator-tvm/pull/5487#issuecomment-621974419
Yes, we have tested this change.
This is an automated message from the Apache Git Service.
To respon
tqchen commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-621962718
Please check the ci error
https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5436/4/pipeline
seems was due to changes to the cpu build config file.
--
maheshambule commented on a change in pull request #5474:
URL: https://github.com/apache/incubator-tvm/pull/5474#discussion_r418116057
##
File path: python/tvm/relay/frontend/tflite.py
##
@@ -774,6 +775,21 @@ def convert_square(self, op):
return out
+def get_te
FrozenGene commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-tvm/pull/5486#discussion_r418114942
##
File path: python/tvm/relay/frontend/tflite.py
##
@@ -2357,6 +2371,20 @@ def get_expr(self, input_tensor_idx):
def has_expr(self, input_t
u99127 commented on a change in pull request #5474:
URL: https://github.com/apache/incubator-tvm/pull/5474#discussion_r418110316
##
File path: python/tvm/relay/frontend/tflite.py
##
@@ -774,6 +775,21 @@ def convert_square(self, op):
return out
+def get_tensor_o
michalpiszczek commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-621939200
@tqchen I believe I've done that here:
https://github.com/apache/incubator-tvm/pull/5436/commits/530ee65c96db562745561092dcec43e136acbaec
. I followed the pattern f
FrozenGene commented on pull request #5487:
URL: https://github.com/apache/incubator-tvm/pull/5487#issuecomment-621936093
Thanks @kparzysz-quic . As we talked in
https://github.com/apache/incubator-tvm/pull/5353, you mention that if we
change to `in`, maybe cause cache/memory synchronizati
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 745c8a0 [RUNTIME] Improved Packed FFI for optional. (#5478)
add 5d75992 [VTA] Fix VTA compile issue (#5
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 7ea834f [team] add reviewer kparzysz-quic (#5482)
add 745c8a0 [RUNTIME] Improved Packed FFI for optiona
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new 7ea834f [team] add reviewer kparzysz-qui
dhruvaray opened a new pull request #5488:
URL: https://github.com/apache/incubator-tvm/pull/5488
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
MarisaKirisame commented on pull request #5457:
URL: https://github.com/apache/incubator-tvm/pull/5457#issuecomment-621884928
@zhiics the ANF pass is pretty fast, and it seems like if you sum the size
of the graph of all call to ANF, the size will be smaller then the original
graph. so i d
kparzysz-quic opened a new pull request #5487:
URL: https://github.com/apache/incubator-tvm/pull/5487
This changes the `scalar` and `stack` parameters to `kernel` to be input
parameters only, as suggested by @FrozenGene .
---
siju-samuel opened a new pull request #5486:
URL: https://github.com/apache/incubator-tvm/pull/5486
Added the support of `select` op in tflite frontend.
@FrozenGene @masahi please help me to review and merge this PR. TIA
Note: tflite `where` op is same as `select` in tflite.
Hzfengsy commented on pull request #5483:
URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-621810131
Some comments:
1. There are more than one spaces before the left brace in the allocation
line
```
allocate(B.local, float32, [64]) {
```
2
FrozenGene edited a comment on pull request #5485:
URL: https://github.com/apache/incubator-tvm/pull/5485#issuecomment-621791710
For performance, have you tried some other layouts on GPU? I have some exp
on CPU. The more suitable layout on CPU of NHWC input is:
```
input_tile: a
FrozenGene commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-tvm/pull/5485#discussion_r417960925
##
File path: topi/python/topi/cuda/conv2d_nhwc_winograd.py
##
@@ -0,0 +1,639 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
FrozenGene commented on pull request #5485:
URL: https://github.com/apache/incubator-tvm/pull/5485#issuecomment-621791710
For performance, have you tried some other layouts? I have some exp on CPU.
The more suitable layout on CPU of NHWC input is:
```
input_tile: alpha, alpha, P
wsl-inspur commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-tvm/pull/5485#discussion_r417902315
##
File path: topi/python/topi/cuda/conv2d_nhwc_winograd.py
##
@@ -0,0 +1,639 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
remotego edited a comment on pull request #7:
URL: https://github.com/apache/incubator-tvm-vta/pull/7#issuecomment-621724098
@huajsj Thank you for the reply. Let me explain more on this issue.
The original name of 0x18 (24) register of Compute Module is
XCOMPUTE_CONTROL_BUS_ADDR_DONE
remotego commented on pull request #7:
URL: https://github.com/apache/incubator-tvm-vta/pull/7#issuecomment-621724098
@huajsj Thank you for the reply. Let me explain more on this issue.
The original name of 0x18 (24) register of Compute Module is
XCOMPUTE_CONTROL_BUS_ADDR_DONE_O_DATA
mbaret commented on a change in pull request #5474:
URL: https://github.com/apache/incubator-tvm/pull/5474#discussion_r417873031
##
File path: python/tvm/relay/frontend/tflite.py
##
@@ -863,6 +845,21 @@ def convert_add(self, op):
return self._convert_elemwise(_qnn.
siju-samuel commented on a change in pull request #5474:
URL: https://github.com/apache/incubator-tvm/pull/5474#discussion_r417851626
##
File path: python/tvm/relay/frontend/tflite.py
##
@@ -863,6 +845,21 @@ def convert_add(self, op):
return self._convert_elemwise(
FrozenGene commented on a change in pull request #5485:
URL: https://github.com/apache/incubator-tvm/pull/5485#discussion_r417839497
##
File path: topi/python/topi/cuda/conv2d_nhwc_winograd.py
##
@@ -0,0 +1,639 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
FrozenGene commented on a change in pull request #5461:
URL: https://github.com/apache/incubator-tvm/pull/5461#discussion_r417832135
##
File path: python/tvm/relay/frontend/mxnet.py
##
@@ -1712,6 +1712,33 @@ def _get_bias_requantize_scale(_inputs, _data_scale,
_kernel_scale):
wsl-inspur opened a new pull request #5485:
URL: https://github.com/apache/incubator-tvm/pull/5485
- Optimization of Conv2d Winograd algorithm on Tensor Core for NHWC layout.
- Winograd with tensor core outperforms original winograd algorithm for all
the batchsizes.
- However, pe
This is an automated email from the ASF dual-hosted git repository.
zhaowu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 90b08f5 [intrin] a few more math functions (#5468)
add 095f565 [FRONTEND][TFLITE]Logical not op support
FrozenGene commented on pull request #5475:
URL: https://github.com/apache/incubator-tvm/pull/5475#issuecomment-621682464
Thanks @siju-samuel
This is an automated message from the Apache Git Service.
To respond to the messag
maheshambule commented on a change in pull request #5474:
URL: https://github.com/apache/incubator-tvm/pull/5474#discussion_r417808625
##
File path: tests/python/frontend/tflite/test_forward.py
##
@@ -1896,6 +1896,41 @@ def test_forward_mediapipe_hand_landmark():
tvm.t
86 matches
Mail list logo