[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

2020-01-14 Thread GitBox
liangfu commented on a change in pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#discussion_r366724818 ## File path: vta/python/vta/top/graphpack.py ## @@ -246

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

2020-01-14 Thread GitBox
liangfu commented on a change in pull request #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#discussion_r366724607 ## File path: vta/python/vta/top/graphpack.py ## @@ -246

[GitHub] [incubator-tvm] masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-14 Thread GitBox
masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-574517425 ok I found a dirty hack to remove prim::CallMethod. Add ```torch._C._jit_pass_inline(trace.graph)``` after tracing. This will move

[incubator-tvm] branch master updated (81e03ee -> 4eecd2a)

2020-01-14 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 81e03ee Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter (#4318)" (#4708)

[GitHub] [incubator-tvm] tqchen merged pull request #4713: link the math library by default

2020-01-14 Thread GitBox
tqchen merged pull request #4713: link the math library by default URL: https://github.com/apache/incubator-tvm/pull/4713 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-tvm] FrozenGene commented on issue #4713: link the math library by default

2020-01-14 Thread GitBox
FrozenGene commented on issue #4713: link the math library by default URL: https://github.com/apache/incubator-tvm/pull/4713#issuecomment-574487666 @tqchen could you help to merge it next? Thanks. This is an automated message

[GitHub] [incubator-tvm] FrozenGene commented on issue #4713: link the math library by default

2020-01-14 Thread GitBox
FrozenGene commented on issue #4713: link the math library by default URL: https://github.com/apache/incubator-tvm/pull/4713#issuecomment-574487438 Thanks @zhigaowu ! This is an automated message from the Apache Git Service. T

[GitHub] [incubator-tvm] zhigaowu opened a new pull request #4713: link the math library by default

2020-01-14 Thread GitBox
zhigaowu opened a new pull request #4713: link the math library by default URL: https://github.com/apache/incubator-tvm/pull/4713 Https://discuss.tvm.ai/t/cannot-locate-symbol-expf-error-on-android-host-system-ubuntu/5387 @FrozenGene link the math library by default --

[GitHub] [incubator-tvm] tqchen merged pull request #4708: Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter"

2020-01-14 Thread GitBox
tqchen merged pull request #4708: Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter" URL: https://github.com/apache/incubator-tvm/pull/4708 This is an automated message from the Apache Git Service

[incubator-tvm] branch master updated (7f7dc07 -> 81e03ee)

2020-01-14 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 7f7dc07 use packed func macro for external codegen (#4710) add 81e03ee Revert "[Relay][TOPI]Fix meaning

[GitHub] [incubator-tvm] zhigaowu closed pull request #4712: V0.6

2020-01-14 Thread GitBox
zhigaowu closed pull request #4712: V0.6 URL: https://github.com/apache/incubator-tvm/pull/4712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-tvm] zhigaowu opened a new pull request #4712: V0.6

2020-01-14 Thread GitBox
zhigaowu opened a new pull request #4712: V0.6 URL: https://github.com/apache/incubator-tvm/pull/4712 Https://discuss.tvm.ai/t/cannot-locate-symbol-expf-error-on-android-host-system-ubuntu/5387 @FrozenGene link the math library by default --

[GitHub] [incubator-tvm] yzhliu commented on issue #4710: [relay][external_codgen] use packed func macro for external codegen

2020-01-14 Thread GitBox
yzhliu commented on issue #4710: [relay][external_codgen] use packed func macro for external codegen URL: https://github.com/apache/incubator-tvm/pull/4710#issuecomment-574480750 Thanks @zhiics @tqchen This is an automated m

[incubator-tvm] branch master updated (ce807fe -> 7f7dc07)

2020-01-14 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from ce807fe [REFACTOR][IR] Unify IntImm and UIntImm (#4706) add 7f7dc07 use packed func macro for externa

[GitHub] [incubator-tvm] yzhliu merged pull request #4710: [relay][external_codgen] use packed func macro for external codegen

2020-01-14 Thread GitBox
yzhliu merged pull request #4710: [relay][external_codgen] use packed func macro for external codegen URL: https://github.com/apache/incubator-tvm/pull/4710 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-tvm] liaha opened a new pull request #4711: [Relay][Frontend][TF] fix _parse_param bug

2020-01-14 Thread GitBox
liaha opened a new pull request #4711: [Relay][Frontend][TF] fix _parse_param bug URL: https://github.com/apache/incubator-tvm/pull/4711 * fix parsing bug that DT_STRING Const name might not be defined in shape dictionary specified in from_tensorflow parameter * update test case --

[incubator-tvm] branch master updated (f4c4fde -> ce807fe)

2020-01-14 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f4c4fde [REFACTOR][IR] Polish ir/type (#4705) add ce807fe [REFACTOR][IR] Unify IntImm and UIntImm (#470

[GitHub] [incubator-tvm] tqchen merged pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm

2020-01-14 Thread GitBox
tqchen merged pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm URL: https://github.com/apache/incubator-tvm/pull/4706 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
zhiics commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r35208 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] zhiics commented on issue #4710: [relay][external_codgen] use packed func macro for external codegen

2020-01-14 Thread GitBox
zhiics commented on issue #4710: [relay][external_codgen] use packed func macro for external codegen URL: https://github.com/apache/incubator-tvm/pull/4710#issuecomment-574461129 cc @tqchen @comaniac This is an automated mes

[GitHub] [incubator-tvm] zhiics opened a new pull request #4710: [relay][external_codgen] use packed func macro for external codegen

2020-01-14 Thread GitBox
zhiics opened a new pull request #4710: [relay][external_codgen] use packed func macro for external codegen URL: https://github.com/apache/incubator-tvm/pull/4710 #4602 Simplify the wrapper using `TVM_DLL_EXPORT_TYPED_FUNC` macro. ---

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366648208 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to th

[GitHub] [incubator-tvm] tqchen opened a new pull request #4709: [REFACTOR][IR] attrs.h -> ir

2020-01-14 Thread GitBox
tqchen opened a new pull request #4709: [REFACTOR][IR] attrs.h -> ir URL: https://github.com/apache/incubator-tvm/pull/4709 This PR moves attrs.h into the ir folder as it can serve as a common infra for building ir dats structures. We also moved common container(FloatImm) into ir/e

[GitHub] [incubator-tvm] tqchen commented on issue #4709: [REFACTOR][IR] attrs.h -> ir

2020-01-14 Thread GitBox
tqchen commented on issue #4709: [REFACTOR][IR] attrs.h -> ir URL: https://github.com/apache/incubator-tvm/pull/4709#issuecomment-574436966 cc @yzhliu @zhiics @ZihengJiang This is an automated message from the Apache Git Serv

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366640373 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366639821 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366639821 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2020-01-14 Thread GitBox
icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-574434976 @abergeron @vinx13 @tmoreau89 I found two problems in this PR. 1. In this [line](https://gi

[GitHub] [incubator-tvm] icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2020-01-14 Thread GitBox
icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-574434976 @abergeron @vinx13 @tmoreau89 I found out two problems in this PR. 1. In this [line](https:

[GitHub] [incubator-tvm] icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2020-01-14 Thread GitBox
icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-574434976 @abergeron @vinx13 @tmoreau89 I found out two problems in this PR. 1. In this [line](https:

[incubator-tvm] 01/01: Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter (#4318)"

2020-01-14 Thread haichen
This is an automated email from the ASF dual-hosted git repository. haichen pushed a commit to branch revert-4318-conv2d_transpose_fix in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git commit ebfff4419fc714d173a1e365739badee1d79adfa Author: Haichen Shen AuthorDate: Tue Jan 14 1

[GitHub] [incubator-tvm] icemelon9 opened a new pull request #4708: Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter"

2020-01-14 Thread GitBox
icemelon9 opened a new pull request #4708: Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter" URL: https://github.com/apache/incubator-tvm/pull/4708 Reverts apache/incubator-tvm#4318 Bugs in the PR.

[incubator-tvm] branch revert-4318-conv2d_transpose_fix created (now ebfff44)

2020-01-14 Thread haichen
This is an automated email from the ASF dual-hosted git repository. haichen pushed a change to branch revert-4318-conv2d_transpose_fix in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. at ebfff44 Revert "[Relay][TOPI]Fix meaning of conv2d_transpose output_padding param

[GitHub] [incubator-tvm] icemelon9 commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2020-01-14 Thread GitBox
icemelon9 commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-574434976 @abergeron @vinx13 @tmoreau89 I found out two problems in this PR. 1. In this [line](https://githu

[GitHub] [incubator-tvm] hcho3 opened a new pull request #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant

2020-01-14 Thread GitBox
hcho3 opened a new pull request #4707: [Relay][Frontend][TF] Fix handling of 0D scalar Constant URL: https://github.com/apache/incubator-tvm/pull/4707 Consider the following snippet of a TensorFlow model: ``` node { name: "flatten_1/stack/0" op: "Const" attr { ke

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366634417 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to th

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)

2020-01-14 Thread GitBox
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-574416251 > Thanks @yongfeng-nv . One thing that I think worth considering, as in many viz tools, is the separation of visualization data source s

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366616774 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366616774 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366615883 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm

2020-01-14 Thread GitBox
zhiics commented on a change in pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm URL: https://github.com/apache/incubator-tvm/pull/4706#discussion_r366610155 ## File path: include/tvm/expr_operator.h ## @@ -597,6 +583,15 @@ TVM_DLL PrimExpr nearbyint(PrimExpr x)

[incubator-tvm] branch master updated (3f2abfb -> f4c4fde)

2020-01-14 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 3f2abfb [relay] Relay annotation and partitioning for external compilers (#4570) add f4c4fde [REFACTOR

[GitHub] [incubator-tvm] tqchen merged pull request #4705: [REFACTOR][IR] Polish ir/type

2020-01-14 Thread GitBox
tqchen merged pull request #4705: [REFACTOR][IR] Polish ir/type URL: https://github.com/apache/incubator-tvm/pull/4705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-tvm] masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-14 Thread GitBox
masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-574403934 I'm happy to merge this even if we can only support v1.3 models for now. I want to send other op converters I need. ---

[GitHub] [incubator-tvm] tqchen opened a new pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm

2020-01-14 Thread GitBox
tqchen opened a new pull request #4706: [REFACTOR][IR] Unify IntImm and UIntImm URL: https://github.com/apache/incubator-tvm/pull/4706 This PR unifies UIntImm and IntImm to simplify the codebase. Unsigned integer constants will also be stored as IntImm. For uint constant that does

[GitHub] [incubator-tvm] yzhliu commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
yzhliu commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574397147 https://discuss.tvm.ai/t/rfc-name-for-non-negative-variable ---

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366589820 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to th

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
comaniac commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366584308 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to th

[GitHub] [incubator-tvm] alexwong commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-14 Thread GitBox
alexwong commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-574383474 > @alexwong I tried your PR locally. With pytorch v1.3 it works, but they introduced big change in [#28408](https://github.com/pytorc

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366582394 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366581709 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366580897 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#discussion_r366580758 ## File path: docs/dev/relay_bring_your_own_codegen.rst ## @@ -0,0 +1,529 @@ +.. Licensed to the

[GitHub] [incubator-tvm] tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574380538 We can ask other's thoughts about it(perhaps list a few candidates and send an rfc?). TIndex seems to b

[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-14 Thread GitBox
masahi edited a comment on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-574076780 @alexwong I tried your PR locally. With pytorch v1.3 it works, but they introduced big change in [#28408](https://github.com/py

[incubator-tvm] branch master updated (d7d2a9b -> 3f2abfb)

2020-01-14 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from d7d2a9b [REFACTOR][IR] Initialize Unified IR Pass Infra. (#4702) add 3f2abfb [relay] Relay annotation and

[GitHub] [incubator-tvm] zhiics commented on issue #4570: [relay] Relay annotation and partitioning for external compilers

2020-01-14 Thread GitBox
zhiics commented on issue #4570: [relay] Relay annotation and partitioning for external compilers URL: https://github.com/apache/incubator-tvm/pull/4570#issuecomment-574338792 Thanks @tqchen @masahi @comaniac This is an auto

[GitHub] [incubator-tvm] zhiics merged pull request #4570: [relay] Relay annotation and partitioning for external compilers

2020-01-14 Thread GitBox
zhiics merged pull request #4570: [relay] Relay annotation and partitioning for external compilers URL: https://github.com/apache/incubator-tvm/pull/4570 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-tvm] comaniac commented on issue #4602: [Docs] Bring Your Own Codegen Guide -- Part 1

2020-01-14 Thread GitBox
comaniac commented on issue #4602: [Docs] Bring Your Own Codegen Guide -- Part 1 URL: https://github.com/apache/incubator-tvm/pull/4602#issuecomment-574337997 Should we merge this part first if no one wants to further review it for now? cc @masahi @tqchen ---

[GitHub] [incubator-tvm] huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

2020-01-14 Thread GitBox
huajsj edited a comment on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-574325187 Hi Liangfu, Thanks for the comments, the reason here to use operator name and indices

[GitHub] [incubator-tvm] zhiics commented on issue #4693: [runtime][refactor] Unify vm and interpreter objects

2020-01-14 Thread GitBox
zhiics commented on issue #4693: [runtime][refactor] Unify vm and interpreter objects URL: https://github.com/apache/incubator-tvm/pull/4693#issuecomment-574328741 ping reviewers. This is an automated message from the Apache

[GitHub] [incubator-tvm] huajsj commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack.

2020-01-14 Thread GitBox
huajsj commented on issue #4703: [VTA] Support network which have no unique operator as start/stop name for graph pack. URL: https://github.com/apache/incubator-tvm/pull/4703#issuecomment-574325187 Hi Liangfu, Thanks for the comments, the reason here to use operator name and indices is to

[GitHub] [incubator-tvm] yzhliu commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
yzhliu commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574323153 How about `TIndexVar` stands for tensor index variable? ---

[GitHub] [incubator-tvm] tqchen opened a new pull request #4705: [REFACTOR][IR] Polish ir/type

2020-01-14 Thread GitBox
tqchen opened a new pull request #4705: [REFACTOR][IR] Polish ir/type URL: https://github.com/apache/incubator-tvm/pull/4705 - Use consistent constructor style to construct objects. - Move env_func to ir as it is mainly used to construct IRs. - Make docs consistent. cc @zhiics @wwei

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
tqchen commented on a change in pull request #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r366473075 ## File path: include/tvm/expr.h ## @@ -115,6 +117,45 @@ class Var :

[GitHub] [incubator-tvm] tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape

2020-01-14 Thread GitBox
tqchen commented on issue #4684: [Arith] add ShapeVar representing non-neg valued variable in a tensor shape URL: https://github.com/apache/incubator-tvm/pull/4684#issuecomment-574285396 I don't have a better idea for name. Indeed shape could indicate a tuple rather than an integer.

[GitHub] [incubator-tvm] tqchen merged pull request #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra

2020-01-14 Thread GitBox
tqchen merged pull request #4702: [REFACTOR][IR] Initialize Unified IR Pass Infra URL: https://github.com/apache/incubator-tvm/pull/4702 This is an automated message from the Apache Git Service. To respond to the message, pl

[incubator-tvm] branch master updated (edc3674 -> d7d2a9b)

2020-01-14 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from edc3674 [REFACTOR][IR] Move error.h into ir (#4701) add d7d2a9b [REFACTOR][IR] Initialize Unified IR Pa

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess

2020-01-14 Thread GitBox
FrozenGene commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess URL: https://github.com/apache/incubator-tvm/pull/4543#discussion_r366438454 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -1113,6 +11

[GitHub] [incubator-tvm] mbarrett97 commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess

2020-01-14 Thread GitBox
mbarrett97 commented on a change in pull request #4543: [FRONTEND][TFLITE] Add support for TFLite_Detection_PostProcess URL: https://github.com/apache/incubator-tvm/pull/4543#discussion_r366410943 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -1113,6 +11

[GitHub] [incubator-tvm] inadob commented on issue #4704: [Relay][Frontend][TFLite] Add parser support for arg_min_max

2020-01-14 Thread GitBox
inadob commented on issue #4704: [Relay][Frontend][TFLite] Add parser support for arg_min_max URL: https://github.com/apache/incubator-tvm/pull/4704#issuecomment-574223969 can you please review this PR @anijain2305 @FrozenGene ---

[GitHub] [incubator-tvm] inadob opened a new pull request #4704: [Relay][Frontend][TFLite] Add parser support for arg_min_max

2020-01-14 Thread GitBox
inadob opened a new pull request #4704: [Relay][Frontend][TFLite] Add parser support for arg_min_max URL: https://github.com/apache/incubator-tvm/pull/4704 * this implementation supports only the case when the axis is a scalar * tflite 1.13 removes all dims of size 1, Relay doesn't do th

[GitHub] [incubator-tvm] masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser

2020-01-14 Thread GitBox
masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-574076780 @alexwong I tried your PR locally. With pytorch v1.3 it works, but they introduced big change in [#28408](https://github.com/pytorch/py