ANSHUMAN87 commented on pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-663817727
> This is a limited case of "loop unswitching". Please consider a more
general solution, where
>
> ```
> for (i = 0..N) {
> // statement A
> if (inva
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460369122
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460368833
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460367771
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460367606
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460367484
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new 00578b7 [TOPI] Fix CUDA Library Tuning
tqchen merged pull request #6132:
URL: https://github.com/apache/incubator-tvm/pull/6132
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Laurawly edited a comment on pull request #6121:
URL: https://github.com/apache/incubator-tvm/pull/6121#issuecomment-663803542
> Thanks for the contribution. I was wondering if this has been integrated
with Relay so that we can use it for quantized networks.
Thanks for your question.
Laurawly commented on pull request #6121:
URL: https://github.com/apache/incubator-tvm/pull/6121#issuecomment-663803542
> Thanks for the contribution. I was wondering if this has been integrated
with Relay so that we can use it for quantized networks.
The relay support is a collabora
Hzfengsy commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460354269
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-663779312
@pasqoc I do 100% agree with you about needing better documentation about
what boards are supported, and how the designs get generated (HLS, Chisel,
OpenCL etc.), and a wh
tmoreau89 commented on a change in pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r460335117
##
File path: src/intelfocl/intelfocl_device.cc
##
@@ -0,0 +1,185 @@
+#include
+#include
+#include
+#include "intelfocl_device.h"
+#include "aocl
tmoreau89 commented on a change in pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r460334828
##
File path: config/intelfocl_sample.json
##
@@ -0,0 +1,13 @@
+{
+ "TARGET" : "intelfocl",
+ "HW_VER" : "0.0.1",
+ "LOG_INP_WIDTH" : 3,
Review
tmoreau89 commented on a change in pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r460334614
##
File path: config/intelfocl_sample.json
##
@@ -0,0 +1,13 @@
+{
+ "TARGET" : "intelfocl",
Review comment:
thank you for clarifying, see m
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-663776880
thanks @remotego @liangfu @pasqoc for the insightful comments. I think that
all opinions expressed are very valid!
So far our approach to naming VTA target has been
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#issuecomment-663772661
I've also noticed that the issue with the CI is that the VTA submodule is
dependent on changes that haven't landed. We'll first merge the changes you
have made in incuba
tmoreau89 commented on pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#issuecomment-663772343
Thanks @zhanghaohit. This is converging nicely. I made some additional
comments.
In addition, I'd like to request further partitioning given the large size
of the
tmoreau89 commented on a change in pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#discussion_r460328729
##
File path: vta/tutorials/autotvm/tune_alu_vta.py
##
@@ -0,0 +1,317 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
tmoreau89 commented on a change in pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#discussion_r460328002
##
File path: src/tir/transforms/lower_tvm_builtin.cc
##
@@ -88,16 +88,6 @@ class BuiltinLower : public StmtExprMutator {
op = stmt.as();
tmoreau89 commented on a change in pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#discussion_r460327531
##
File path: src/relay/backend/compile_engine.cc
##
@@ -288,7 +288,7 @@ class ScheduleGetter : public
backend::MemoizedExprTranslator>
tvm::T
tmoreau89 commented on a change in pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#discussion_r460327463
##
File path: src/relay/backend/compile_engine.cc
##
@@ -230,7 +230,7 @@ class ScheduleGetter : public
backend::MemoizedExprTranslator>
tmoreau89 commented on a change in pull request #6126:
URL: https://github.com/apache/incubator-tvm/pull/6126#discussion_r460327072
##
File path: python/tvm/autotvm/task/topi_integration.py
##
@@ -227,17 +227,21 @@ def wrapper(outs, *args, **kwargs):
return _decorate
-
kparzysz-quic commented on pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-663767437
This is a limited case of "loop unswitching". Please consider a more
general solution, where
```
for (i = 0..N) {
// statement A
if (invariant-condit
kevinthesun merged pull request #6130:
URL: https://github.com/apache/incubator-tvm/pull/6130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
kevinthesun pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 922e0a0 [Relay][VM] Allow to config allocator type and refactor vm
code structure (#6105)
add 659f
kevinthesun commented on pull request #6130:
URL: https://github.com/apache/incubator-tvm/pull/6130#issuecomment-663766170
Thanks @ymwangg @comaniac
This is an automated message from the Apache Git Service.
To respond to the
kevinthesun commented on a change in pull request #6085:
URL: https://github.com/apache/incubator-tvm/pull/6085#discussion_r460322183
##
File path: python/tvm/relay/frontend/tensorflow.py
##
@@ -637,10 +637,11 @@ def _impl(inputs, attr, params, mod):
iou_threshold = np
kparzysz-quic commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460310403
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
This is an automated email from the ASF dual-hosted git repository.
zhic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new 922e0a0 [Relay][VM] Allow to config alloca
zhiics merged pull request #6105:
URL: https://github.com/apache/incubator-tvm/pull/6105
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
zhiics commented on pull request #6105:
URL: https://github.com/apache/incubator-tvm/pull/6105#issuecomment-663763564
Thanks @icemelon9 @jroesch
This is an automated message from the Apache Git Service.
To respond to the mes
junrushao1994 commented on pull request #6123:
URL: https://github.com/apache/incubator-tvm/pull/6123#issuecomment-663734364
Hey, could you retrigger the CI by pushing an empty commit? `git commit
--allow-empty -m "retrigger"`
--
tqchen commented on pull request #5892:
URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-663691736
@leonwanghui please send another commit to trigger the CI, @jroesch @nhynes
please followup and take another look
-
comaniac commented on pull request #6112:
URL: https://github.com/apache/incubator-tvm/pull/6112#issuecomment-663678802
Thanks for the PR! Since CLI itself serves as an infra, it would be better
to break this PR to a series of PRs like the following:
- PR1: The basic CLI infra mainly
tqchen closed issue #6136:
URL: https://github.com/apache/incubator-tvm/issues/6136
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tqchen commented on issue #6136:
URL: https://github.com/apache/incubator-tvm/issues/6136#issuecomment-663671162
For followup dicsussions like this, let us open new threads on the discuss
forum https://discuss.tvm.ai/
This i
antinucleon closed pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tqchen commented on issue #6136:
URL: https://github.com/apache/incubator-tvm/issues/6136#issuecomment-663670965
We support multiple entry by default by allowing the user to pick the name
of the function. For example
```python
mod["xyz"]
```
refers to the function xyz, then
tqchen edited a comment on issue #6136:
URL: https://github.com/apache/incubator-tvm/issues/6136#issuecomment-663670965
We support multiple entry by default by allowing the user to pick the name
of the function. For example
```python
mod["xyz"]
```
refers to the function xyz
antinucleon commented on pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135#issuecomment-663670817
@tqchen Sounds good.
This is an automated message from the Apache Git Service.
To respond to the messa
tqchen edited a comment on pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-663669923
cc @ZihengJiang @merrymercy @Hzfengsy @kevinthesun @junrushao1994
@spectrometerHBH @wpan11nv @kparzysz-quic please help to take a look
---
tqchen commented on pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-663669923
cc @ZihengJiang @merrymercy @Hzfengsy @kevinthesun @junrushao1994
@spectrometerHBH please help to take a look
---
tqchen commented on pull request #6128:
URL: https://github.com/apache/incubator-tvm/pull/6128#issuecomment-663668083
@hanzz2007 please fix the lint error
This is an automated message from the Apache Git Service.
To respond t
tqchen commented on pull request #6112:
URL: https://github.com/apache/incubator-tvm/pull/6112#issuecomment-663667667
cc @merrymercy @jroesch @ajtulloch @comaniac
This is an automated message from the Apache Git Service.
To
MarisaKirisame commented on a change in pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135#discussion_r460211589
##
File path: include/tvm/runtime/packed_func.h
##
@@ -371,6 +371,20 @@ class TVMPODValue_ {
TVM_CHECK_TYPE_CODE(type_code_, kDLFloat);
tqchen commented on pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135#issuecomment-663667292
Given that we already have operator double, let us simply ignore the float
and use the double as positional argument in the function signature(say
TypedPackedFunc, then con
zhiics commented on a change in pull request #6107:
URL: https://github.com/apache/incubator-tvm/pull/6107#discussion_r460197850
##
File path: src/auto_scheduler/compute_dag.h
##
@@ -114,6 +114,16 @@ class ComputeDAG : public ObjectRef {
*/
State InferBound(const State&
tkonolige commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r460174049
##
File path: src/relay/backend/compile_engine.cc
##
@@ -770,7 +770,7 @@ class CompileEngineImpl : public CompileEngineNode {
};
/*! \brief Th
jwfromm commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-663634086
@tkonolige, looks like the CI got aborted, can you rebase and push to
trigger a new run?
This is an autom
jwfromm commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r460172911
##
File path: src/relay/backend/compile_engine.cc
##
@@ -770,7 +770,7 @@ class CompileEngineImpl : public CompileEngineNode {
};
/*! \brief The
anijain2305 commented on pull request #6115:
URL: https://github.com/apache/incubator-tvm/pull/6115#issuecomment-663631764
@icemelon9 Can you please manage this PR?
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from edcd77d [Relay]Port eliminate_common_subexpr to non-recursive form
(#6134)
add 4a1089d [Flaky] TFLite
tqchen merged pull request #6084:
URL: https://github.com/apache/incubator-tvm/pull/6084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
antinucleon commented on a change in pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135#discussion_r460156172
##
File path: include/tvm/runtime/packed_func.h
##
@@ -371,6 +371,20 @@ class TVMPODValue_ {
TVM_CHECK_TYPE_CODE(type_code_, kDLFloat);
zhiics merged pull request #6134:
URL: https://github.com/apache/incubator-tvm/pull/6134
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
zhiics commented on pull request #6134:
URL: https://github.com/apache/incubator-tvm/pull/6134#issuecomment-663614440
Thanks @jiangzoi @MarisaKirisame
This is an automated message from the Apache Git Service.
To respond to t
This is an automated email from the ASF dual-hosted git repository.
zhic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 782190e [Relay] Keep fixed dim when unifying dynamic shape (#5795)
add edcd77d [Relay]Port eliminate_comm
roastduck commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460138057
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460128717
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
MarisaKirisame commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460117369
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460106726
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
MarisaKirisame commented on a change in pull request #6062:
URL: https://github.com/apache/incubator-tvm/pull/6062#discussion_r460090632
##
File path: include/tvm/relay/transform.h
##
@@ -223,10 +223,12 @@ TVM_DLL Pass CombineParallelConv2D(uint64_t
min_num_branches = 3);
*
MarisaKirisame commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460100741
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
MarisaKirisame merged pull request #5795:
URL: https://github.com/apache/incubator-tvm/pull/5795
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
marisa pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from bfa4eae Add 'get_num_inputs' to GraphRuntime (#6118)
add 782190e [Relay] Keep fixed dim when unifying d
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460096506
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
MarisaKirisame commented on a change in pull request #6086:
URL: https://github.com/apache/incubator-tvm/pull/6086#discussion_r460089408
##
File path: src/relay/backend/interpreter.cc
##
@@ -486,6 +487,9 @@ class Interpreter : public ExprFunctor,
// The output shape of s
MarisaKirisame commented on a change in pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135#discussion_r460087659
##
File path: include/tvm/runtime/packed_func.h
##
@@ -371,6 +371,20 @@ class TVMPODValue_ {
TVM_CHECK_TYPE_CODE(type_code_, kDLFloat);
This is an automated email from the ASF dual-hosted git repository.
marisa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new bfa4eae Add 'get_num_inputs' to GraphRun
MarisaKirisame merged pull request #6118:
URL: https://github.com/apache/incubator-tvm/pull/6118
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
roastduck commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460083344
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
MarisaKirisame opened a new issue #6136:
URL: https://github.com/apache/incubator-tvm/issues/6136
I noticed that tvm only assume a single "main" entry in the code. I dont
think this is a good design for training - when training a network, you will
switch between training, validation, and m
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460069525
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
roastduck commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r460019969
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459959421
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459955697
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
roastduck commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459934599
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
roastduck commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459932460
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459906470
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
ANSHUMAN87 commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#discussion_r459902322
##
File path: src/tir/transforms/hoist_if_then_else.cc
##
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
antinucleon opened a new pull request #6135:
URL: https://github.com/apache/incubator-tvm/pull/6135
Thanks for contributing to TVM! Please refer to guideline
https://tvm.apache.org/docs/contribute/ for useful information and tips. After
the pull request is submitted, please request code
82 matches
Mail list logo
