wrongtest commented on a change in pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#discussion_r737122899
##
File path: include/tvm/arith/int_set.h
##
@@ -249,12 +249,20 @@ IntSet UnionLowerBound(const Array& sets);
Array UnionRegionLowerBound(const Array>&
wrongtest commented on a change in pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#discussion_r737122899
##
File path: include/tvm/arith/int_set.h
##
@@ -249,12 +249,20 @@ IntSet UnionLowerBound(const Array& sets);
Array UnionRegionLowerBound(const Array>&
wrongtest commented on a change in pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#discussion_r737122899
##
File path: include/tvm/arith/int_set.h
##
@@ -249,12 +249,20 @@ IntSet UnionLowerBound(const Array& sets);
Array UnionRegionLowerBound(const Array>&
This is an automated email from the ASF dual-hosted git repository.
junrushao pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from cf6b16a Sync with upstream and use CreateDSOLibraryObject. (#9376)
add b606c4b [TensorIR][Tutorial] Blitz
junrushao1994 commented on pull request #9315:
URL: https://github.com/apache/tvm/pull/9315#issuecomment-952550201
Thank you all for the huge effort!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
junrushao1994 merged pull request #9315:
URL: https://github.com/apache/tvm/pull/9315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrushao1994 commented on pull request #9360:
URL: https://github.com/apache/tvm/pull/9360#issuecomment-952547274
I will do another round of review next week!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
junrushao1994 commented on pull request #9315:
URL: https://github.com/apache/tvm/pull/9315#issuecomment-952547107
Sounds great! Let's do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Hzfengsy commented on pull request #9315:
URL: https://github.com/apache/tvm/pull/9315#issuecomment-952546817
All comments are addressed. Let's merge it quickly if there is no more
comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from c559855 Fix typo in Git Usage Tips (#9377)
add cf6b16a Sync with upstream and use CreateDSOLibraryObject. (#9376)
masahi merged pull request #9376:
URL: https://github.com/apache/tvm/pull/9376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
masahi commented on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952485326
I've tried `index_put` approach before, it is available before PT 1.9. See
the discussion in
https://github.com/apache/tvm/pull/7231#issuecomment-756693366. My impression
back then
masahi edited a comment on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952485326
I've tried `index_put` approach before, it is available before PT 1.9. See
the discussion in
https://github.com/apache/tvm/pull/7231#issuecomment-756693366. My impression
jiangjiajun commented on pull request #9273:
URL: https://github.com/apache/tvm/pull/9273#issuecomment-952482340
Hi, @areusch Could you take your time to handle this pull request, I'm not
sure why the ci tests failed
--
This is an automated message from the Apache Git Service.
To
hgt312 edited a comment on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952479498
@comaniac @masahi I find that the output will not be correct due to
something like `a[...] = b`, like the previous issues.
In BART, it is from a function, the whole
hope51607 commented on pull request #9374:
URL: https://github.com/apache/tvm/pull/9374#issuecomment-952475916
@shingjan I have enabled these tests and confirmed that they passed.
@masahi I tried to add fp16 test, but in my environment it does not seem to
support half-precision floating
shengxinhu edited a comment on pull request #9329:
URL: https://github.com/apache/tvm/pull/9329#issuecomment-952455818
onnx and onnxruntime version need to be updated to version 1.10.1 and 1.9.0
respectively for Trilu operator,
--
This is an automated message from the Apache Git
shengxinhu commented on pull request #9329:
URL: https://github.com/apache/tvm/pull/9329#issuecomment-952455818
onnx/onnxruntime version need to be updated for Trilu operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from 64b58b1 [PyTest] Sort by test location, but not parametrization
(#9353)
add c559855 Fix typo in Git Usage Tips
masahi merged pull request #9377:
URL: https://github.com/apache/tvm/pull/9377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
masahi commented on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-95263
Yeah, users need to acknowledge that TVM cannot represent all PT models. It
is better to reject such models early than returning corrupted models.
Since this request comes up
comaniac commented on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952440654
Good suggestion. We should definitely do so for our use cases in particular,
although I guess the same issue may happen periodically when someone tries to
work on BART lol
--
masahi commented on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952436178
Yes we should definitely add a warning at least.
A safer alternative, which I'm more comfortable with, is make use of the
custom convert map
gromero edited a comment on pull request #9320:
URL: https://github.com/apache/tvm/pull/9320#issuecomment-949975658
@guberti Thanks for the review. Yes, please, if you can ~crack~ take a crack
at writing that it would cool.
--
This is an automated message from the Apache Git Service.
To
gromero edited a comment on pull request #9320:
URL: https://github.com/apache/tvm/pull/9320#issuecomment-949975658
@guberti Thanks for the review. Yes, please, if you can ~crack~ take a crack
at writing it it would cool.
--
This is an automated message from the Apache Git Service.
To
electriclilies commented on a change in pull request #9312:
URL: https://github.com/apache/tvm/pull/9312#discussion_r737004769
##
File path: src/relay/op/vm/vm.cc
##
@@ -195,6 +195,46 @@ RELAY_REGISTER_OP("vm.invoke_tvm_op")
return
comaniac commented on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952415153
Thanks for pointing out. @hgt312 should have verified that the output of
BART-base is correct with this change. Meanwhile, as you mentioned this is not
100% semantic equivalent,
anwang2009 commented on a change in pull request #9357:
URL: https://github.com/apache/tvm/pull/9357#discussion_r736991389
##
File path: tests/python/relay/test_fold_type_transformation.py
##
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
anwang2009 commented on a change in pull request #9357:
URL: https://github.com/apache/tvm/pull/9357#discussion_r736991002
##
File path: src/relay/transforms/fold_type_transformation.cc
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from 649ee20 [Hexagon] Launcher modifications to make use of the new
device API (#9356)
add 64b58b1 [PyTest] Sort by
masahi merged pull request #9353:
URL: https://github.com/apache/tvm/pull/9353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hogepodge opened a new pull request #9377:
URL: https://github.com/apache/tvm/pull/9377
Fixed a typo where Markdown syntax with mixed with RST syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
csullivan opened a new pull request #9376:
URL: https://github.com/apache/tvm/pull/9376
#9355 was merged quickly before updates applied by #9342 were synced. This
is a fixup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
electriclilies commented on a change in pull request #9357:
URL: https://github.com/apache/tvm/pull/9357#discussion_r736950950
##
File path: src/relay/transforms/fold_type_transformation.cc
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
tqchen commented on pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#issuecomment-952360879
Thanks @wrongtest in this case we might not rely on the difference(because
the sets can be overly relaxed). Instead, we know that for this case the size
won't go over the original
tqchen commented on a change in pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#discussion_r736952615
##
File path: include/tvm/arith/int_set.h
##
@@ -249,12 +249,20 @@ IntSet UnionLowerBound(const Array& sets);
Array UnionRegionLowerBound(const Array>&
jroesch commented on pull request #9357:
URL: https://github.com/apache/tvm/pull/9357#issuecomment-952352204
cc @electriclilies can you review this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jroesch commented on pull request #9333:
URL: https://github.com/apache/tvm/pull/9333#issuecomment-952351613
I would ideally wait to merge from @csullivan and @cconvey but LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
jroesch pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from 4152e33 [Hexagon] Introduce new DeviceAPI (#9355)
add 649ee20 [Hexagon] Launcher modifications to make use of the
This is an automated email from the ASF dual-hosted git repository.
jroesch pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from 404fbf7 [Hexagon] Refactor directory structure to accommodate new
runtime (#9354)
add 4152e33 [Hexagon]
jroesch merged pull request #9356:
URL: https://github.com/apache/tvm/pull/9356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jroesch merged pull request #9355:
URL: https://github.com/apache/tvm/pull/9355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
jroesch pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from f7430e9 Support runtime defined function wrapping of library module
packed functions (#9342)
add 404fbf7
jroesch merged pull request #9354:
URL: https://github.com/apache/tvm/pull/9354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jroesch commented on pull request #9355:
URL: https://github.com/apache/tvm/pull/9355#issuecomment-952347917
cc @mbs-octoml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jroesch commented on a change in pull request #9355:
URL: https://github.com/apache/tvm/pull/9355#discussion_r736940611
##
File path: src/runtime/hexagon/hexagon/hexagon_device_api_v2.h
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from 0df4edc [Torch] Add aten::roll support for Swin Transformer (#9371)
add f7430e9 Support runtime defined function
masahi merged pull request #9342:
URL: https://github.com/apache/tvm/pull/9342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
masahi commented on pull request #9374:
URL: https://github.com/apache/tvm/pull/9374#issuecomment-952329871
@hope51607 Can you also add fp16 tests? I've met the "type ambiguity" error
when trying to compile fp16 models for opencl before. I assume this patch fixes
such issue?
--
This
masahi edited a comment on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952273980
Please add tests.
Also, we need to discuss `aten::copy_`. There have been many requests to
support this op and attempts to support it.
masahi commented on pull request #9375:
URL: https://github.com/apache/tvm/pull/9375#issuecomment-952273980
Please add tests.
Also, we need to discuss `aten::copy_`. There have been many requests to
support this op and attempts to support it.
This is an automated email from the ASF dual-hosted git repository.
junrushao pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from ff43f99 [Relay] Introduce Executor and Runtime representations with
associated registries (#9246)
add 0df4edc
junrushao1994 merged pull request #9371:
URL: https://github.com/apache/tvm/pull/9371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrushao1994 closed issue #9368:
URL: https://github.com/apache/tvm/issues/9368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hgt312 opened a new pull request #9375:
URL: https://github.com/apache/tvm/pull/9375
- add support for `aten::new_zeros` & `aten::copy_`
- view of a constant scalar
This pr enables convert from 'bart_base' model in transformers
@comaniac
--
This is an automated message from
hope51607 opened a new pull request #9374:
URL: https://github.com/apache/tvm/pull/9374
I encountered the same max / min ambiguous issue caused by the ternary
operator as #2821 and #5090.
The reason is that the type of the ternary operator is not unchar.
The patch that
mehrdadh commented on pull request #9366:
URL: https://github.com/apache/tvm/pull/9366#issuecomment-952067006
@comaniac @tqchen @tmoreau89 @gromero @masahi thank you all!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stoa commented on a change in pull request #9363:
URL: https://github.com/apache/tvm/pull/9363#discussion_r736625985
##
File path: apps/microtvm/stm32/Src/Validation/pb_decode.c
##
@@ -0,0 +1,1528 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
pfk-beta removed a comment on issue #9373:
URL: https://github.com/apache/tvm/issues/9373#issuecomment-951994048
I think it may be difficult to modify maven configuration, so at least good
starting point is to mention about this issue in documentation, when building
tvm4j.
--
This is
pfk-beta commented on issue #9373:
URL: https://github.com/apache/tvm/issues/9373#issuecomment-951994048
I think it may be difficult to modify maven configuration, so at least good
starting point is to mention about this issue in documentation, when building
tvm4j.
--
This is an
pfk-beta opened a new issue #9373:
URL: https://github.com/apache/tvm/issues/9373
### Expected behavior
build tvm4j with runtime from custom build directory (currently I need to
modify assembly.xml inside jvm folder).
### Actual behavior
During `make jvmpackage` i'm
gromero commented on pull request #9366:
URL: https://github.com/apache/tvm/pull/9366#issuecomment-951922262
@mehrdadh Congrats!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
manupa-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736408874
##
File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc
##
@@ -0,0 +1,158 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
This is an automated email from the ASF dual-hosted git repository.
leandron pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from f0e8441 [COMMUNITY] Mark Shields -> Reviewer (#9369)
add ff43f99 [Relay] Introduce Executor and Runtime
leandron merged pull request #9246:
URL: https://github.com/apache/tvm/pull/9246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Hzfengsy commented on pull request #9372:
URL: https://github.com/apache/tvm/pull/9372#issuecomment-951784678
Thanks, @wrongtest. Will review it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wrongtest opened a new pull request #9372:
URL: https://github.com/apache/tvm/pull/9372
Hi there~ This PR aims to enhance the `CompactBufferRegion` and
`GetBlockAccessRegion` for conditional buffer accesses.
Currently, they are not aware of conditions, thus may produce non-tight
Hzfengsy commented on a change in pull request #9315:
URL: https://github.com/apache/tvm/pull/9315#discussion_r736354761
##
File path: gallery/tutorial/tensor_ir_blitz_course.py
##
@@ -0,0 +1,191 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
This is an automated email from the ASF dual-hosted git repository.
syfeng pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from 75a8fa1 Fix Arm(R) Ethos(TM)-U55 NPU Demo app (#9323)
add f0e8441 [COMMUNITY] Mark Shields -> Reviewer (#9369)
No
Hzfengsy merged pull request #9369:
URL: https://github.com/apache/tvm/pull/9369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ashutosh-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736338880
##
File path: src/relay/backend/contrib/cmsisnn/generate_constants.cc
##
@@ -0,0 +1,230 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF)
manupa-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736334994
##
File path: src/relay/backend/contrib/cmsisnn/generate_constants.cc
##
@@ -0,0 +1,230 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF)
manupa-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736331766
##
File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc
##
@@ -0,0 +1,158 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
manupa-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736330658
##
File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc
##
@@ -0,0 +1,158 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Mousius commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736327262
##
File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc
##
@@ -0,0 +1,158 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
manupa-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r736311645
##
File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc
##
@@ -0,0 +1,158 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mikepapadim commented on a change in pull request #9367:
URL: https://github.com/apache/tvm/pull/9367#discussion_r736292108
##
File path: tests/python/relay/test_pass_fold_constant.py
##
@@ -68,14 +72,14 @@ def expected():
x = relay.var("x", t)
c_folded =
mikepapadim commented on pull request #9367:
URL: https://github.com/apache/tvm/pull/9367#issuecomment-951714476
LTGM apart the 2 unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mikepapadim commented on a change in pull request #9367:
URL: https://github.com/apache/tvm/pull/9367#discussion_r736292108
##
File path: tests/python/relay/test_pass_fold_constant.py
##
@@ -68,14 +72,14 @@ def expected():
x = relay.var("x", t)
c_folded =
jiangjiajun opened a new pull request #9370:
URL: https://github.com/apache/tvm/pull/9370
All the activation function are implemented in `convert_unary_op`, and the
series of reduce operators are implemented in `convert_reduce`.
Thanks for contributing to TVM! Please refer to
ekalda commented on pull request #9299:
URL: https://github.com/apache/tvm/pull/9299#issuecomment-951667725
Hi @Mousius, I think you are actually right that we could test the ICHECK if
we wanted to without too much trouble, so apologies for the confusion there.
However, for what it's
mshr-h commented on pull request #9060:
URL: https://github.com/apache/tvm/pull/9060#issuecomment-951625409
Hi @leandron @areusch @jroesch @masahi , could you take a review for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Kyrie-Zhao commented on issue #9368:
URL: https://github.com/apache/tvm/issues/9368#issuecomment-951619728
> Can you show your script to trace the model? I got an error during tracing.
>
> > BTW, anyone can provide some guidance regarding the procedure of
implementing & registering
manupa-arm commented on pull request #9323:
URL: https://github.com/apache/tvm/pull/9323#issuecomment-951606263
Thanks @grant-arm @Mousius . Please do follow up with further concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
manupa pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git.
from c2a685e [COMMUNITY] Mehrdad Hessar -> Reviewer (#9366)
add 75a8fa1 Fix Arm(R) Ethos(TM)-U55 NPU Demo app (#9323)
manupa-arm merged pull request #9323:
URL: https://github.com/apache/tvm/pull/9323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
manupa-arm commented on pull request #9323:
URL: https://github.com/apache/tvm/pull/9323#issuecomment-951604156
I think this is good enough for the fix (lets get this in) and thanks
@grant-arm for quickly enabling it in the CI. I hope we can follow up with
further changes.
--
This is
87 matches
Mail list logo
