[GitHub] [incubator-tvm] jcf94 commented on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
jcf94 commented on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223 > @jcf94 Did our old rule affect the correctness of common operators? Yes, with those rules several other UTs will fail, they're actually not always correct. For

[GitHub] [incubator-tvm] jcf94 commented on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching

2020-06-26 Thread GitBox
jcf94 commented on pull request #5924: URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650022894 > Thanks @jcf94 we should add a testcase to test_arith_rewrite_simplify, by constructing the case and > > * verify each of the rule added in this PR. > * Use