feluelle opened a new pull request #4455: [AIRFLOW-3519] Fix example http
operator
URL: https://github.com/apache/airflow/pull/4455
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736002#comment-16736002
]
Felix Uellendall commented on AIRFLOW-3519:
---
I would rather change the response_check to
[
https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736002#comment-16736002
]
Felix Uellendall edited comment on AIRFLOW-3519 at 1/7/19 4:04 PM:
---
I
Tim Swast created AIRFLOW-3644:
--
Summary: AIP-8 Split Hooks/Operators out of core package and
repository
Key: AIRFLOW-3644
URL: https://issues.apache.org/jira/browse/AIRFLOW-3644
Project: Apache Airflow
Mokubyow edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the
functionality of "/health" endpoint
URL: https://github.com/apache/airflow/pull/4309#issuecomment-451993107
Emmanual Bard brought up a good point about the scheduler health check. What
you have only checks the last
feluelle commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12
URL: https://github.com/apache/airflow/pull/3723#issuecomment-451887370
I just tried to reproduce @r39132 error but I can't.
I ran `pip install .` from the current `master` branch and installed the
following
[
https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-3601 started by Yohei Onishi.
-
> update operators to BigQuery to support location
>
feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors
URL: https://github.com/apache/airflow/pull/4453#issuecomment-452019252
@yohei1126 , not sure which one you are looking at, but the master CI
passes(https://travis-ci.org/apache/airflow/builds/476197675).
feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger
URL: https://github.com/apache/airflow/pull/4407#issuecomment-452019084
@ffinfo , please let me know if you will investigate the issue. If not, I
prefer to revert this change until the flaky test is fixed. What do
morgendave opened a new pull request #4101: [AIRFLOW-3272] Add base grpc hook
URL: https://github.com/apache/airflow/pull/4101
Make sure you have checked all steps below.
Jira
My PR addresses the following Airflow Jira issues and references them in
the PR title. For example,
Kyle Hamlin created AIRFLOW-3645:
Summary: Use a base_executor_config and merge operator level
executor_config
Key: AIRFLOW-3645
URL: https://issues.apache.org/jira/browse/AIRFLOW-3645
Project:
[
https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736140#comment-16736140
]
ASF GitHub Bot commented on AIRFLOW-3272:
-
morgendave commented on pull request #4101:
[
https://issues.apache.org/jira/browse/AIRFLOW-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736141#comment-16736141
]
ASF GitHub Bot commented on AIRFLOW-3272:
-
morgendave commented on pull request #4101:
Tao Feng created AIRFLOW-3646:
-
Summary: Fix plugin manager test
Key: AIRFLOW-3646
URL: https://issues.apache.org/jira/browse/AIRFLOW-3646
Project: Apache Airflow
Issue Type: Bug
feng-tao edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes
operator with git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452075293
@kaxil, what is the issue?
This is an automated message
kaxil edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes operator
with git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452074777
Sorry, I merged it and had to revert which caused this piece to fail. May
well have to create a new PR.
feng-tao commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452075293
what is the issue @kaxil ?
This is an automated message from the
feluelle commented on a change in pull request #4455: [AIRFLOW-3519] Fix
example http operator
URL: https://github.com/apache/airflow/pull/4455#discussion_r245791673
##
File path: airflow/example_dags/example_http_operator.py
##
@@ -92,7 +92,7 @@
[
https://issues.apache.org/jira/browse/AIRFLOW-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736031#comment-16736031
]
ASF GitHub Bot commented on AIRFLOW-3519:
-
feluelle commented on pull request #4455:
kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example
http operator
URL: https://github.com/apache/airflow/pull/4455#discussion_r245784539
##
File path: airflow/example_dags/example_http_operator.py
##
@@ -92,7 +92,7 @@
benjamingregory commented on issue #3055: [AIRFLOW-2125] Using binary package
psycopg2-binary
URL: https://github.com/apache/airflow/pull/3055#issuecomment-452071229
@bern4rdelli @jgao54 @Fokko
Question as to why this was changed to `psychopg2-binary` given the
following warning
kaxil commented on a change in pull request #4455: [AIRFLOW-3519] Fix example
http operator
URL: https://github.com/apache/airflow/pull/4455#discussion_r245790529
##
File path: airflow/example_dags/example_http_operator.py
##
@@ -92,7 +92,7 @@
kaxil closed pull request #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
[
https://issues.apache.org/jira/browse/AIRFLOW-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736311#comment-16736311
]
ASF GitHub Bot commented on AIRFLOW-3281:
-
kaxil commented on pull request #:
kaxil closed pull request #4454: [AIRFLOW-3402] Port PR #4247 to 1.10-test
URL: https://github.com/apache/airflow/pull/4454
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
[
https://issues.apache.org/jira/browse/AIRFLOW-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736325#comment-16736325
]
ASF GitHub Bot commented on AIRFLOW-3402:
-
kaxil commented on pull request #4454:
feng-tao commented on issue #4399: [AIRFLOW-3594] Unify different License Header
URL: https://github.com/apache/airflow/pull/4399#issuecomment-452035908
PTAL @bolkedebruin
This is an automated message from the Apache Git
feluelle commented on a change in pull request #4455: [AIRFLOW-3519] Fix
example http operator
URL: https://github.com/apache/airflow/pull/4455#discussion_r245789254
##
File path: airflow/example_dags/example_http_operator.py
##
@@ -92,7 +92,7 @@
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452074777
Sorry, I merged it and had to revert. Let me know when it is ready
feng-tao commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors
URL: https://github.com/apache/airflow/pull/4453#issuecomment-452019385
@yohei1126 , I think this test is pretty flaky.
This is an automated message
jmcarp commented on issue #4436: [AIRFLOW-3631] Update flake8 and fix lint.
URL: https://github.com/apache/airflow/pull/4436#issuecomment-452143443
Updated.
This is an automated message from the Apache Git Service.
To respond
feng-tao commented on a change in pull request #4457: [AIRFLOW-XXX] Fix
TestTriggerDag flaky test
URL: https://github.com/apache/airflow/pull/4457#discussion_r245870276
##
File path: tests/www_rbac/test_views.py
##
@@ -1464,12 +1464,9 @@ def
feng-tao commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452079131
@kaxil, thanks for running the release :)
This is an automated
Fokko commented on issue #4320: [AIRFLOW-3515] Remove the run_duration option
URL: https://github.com/apache/airflow/pull/4320#issuecomment-452096465
I've rebased onto master and resolved the conflicts
This is an automated
felipegasparini commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept
plugins for views and links.
URL: https://github.com/apache/airflow/pull/4036#issuecomment-452113006
We also need to fix the example in the documentation
(https://airflow.apache.org/plugins.html#example). It is
feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?
URL: https://github.com/apache/airflow/pull/4421#issuecomment-452119383
@Fokko , I see your point. +1
This is an automated message from the Apache
feng-tao edited a comment on issue #4421: [AIRFLOW-3468] Remove
KnownEvent(Event)?
URL: https://github.com/apache/airflow/pull/4421#issuecomment-452174547
@Fokko , regarding not having a migration script, I wonder what will happen
for the following case:
assume we have three tables:
feng-tao commented on issue #4036: [AIRFLOW-2744] Allow RBAC to accept plugins
for views and links.
URL: https://github.com/apache/airflow/pull/4036#issuecomment-452093401
@oliviersm199 , it seems that PluginRBACTest fails(currently it is disabled)
if re-enable. Do you think you have time
Fokko commented on issue #4298: [AIRFLOW-3478] Make sure that the session is
closed
URL: https://github.com/apache/airflow/pull/4298#issuecomment-452096893
Rebased :-)
This is an automated message from the Apache Git
Fokko commented on issue #4378: AIRFLOW-3573 - Remove DagStat table
URL: https://github.com/apache/airflow/pull/4378#issuecomment-452100456
@ffinfo PTAL
This is an automated message from the Apache Git Service.
To respond to
galak75 removed a comment on issue #4292: [AIRFLOW-2508] Handle non string
types in Operators templatized fields
URL: https://github.com/apache/airflow/pull/4292#issuecomment-445222367
Everything went well on our fork (see
[
https://issues.apache.org/jira/browse/AIRFLOW-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736368#comment-16736368
]
Teresa Martyny edited comment on AIRFLOW-3292 at 1/7/19 9:25 PM:
-
Sorry
Fokko commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?
URL: https://github.com/apache/airflow/pull/4421#issuecomment-452095834
Rebased. @feng-tao I've looked into the Alembic script, but it becomes quite
nasty in my opinion. The upgrade will be a `DROP TABLE IF EXISTS`,
Fokko commented on issue #4383: [AIRFLOW-3475] Move ImportError out of models.py
URL: https://github.com/apache/airflow/pull/4383#issuecomment-452097714
@BasPH I've restarted the failed tests. Maybe do a rebase? It seems to fail
on k8s.
ArgentFalcon commented on issue #3533: [AIRFLOW-161] New redirect route and
extra links
URL: https://github.com/apache/airflow/pull/3533#issuecomment-452102290
Oh yeah, I should finish this up. I have to pull some more changes that we
did internally at Lyft that make it more versatile.
feluelle commented on issue #4405: [AIRFLOW-3598] Add tests for
MsSqlToHiveTransfer
URL: https://github.com/apache/airflow/pull/4405#issuecomment-452102237
Sure.
This is an automated message from the Apache Git Service.
To
Fokko commented on issue #4405: [AIRFLOW-3598] Add tests for MsSqlToHiveTransfer
URL: https://github.com/apache/airflow/pull/4405#issuecomment-452107449
Thanks!
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/AIRFLOW-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-3645 started by Kyle Hamlin.
> Use a base_executor_config and merge operator level executor_config
>
[
https://issues.apache.org/jira/browse/AIRFLOW-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kyle Hamlin reassigned AIRFLOW-3645:
Assignee: Kyle Hamlin
> Use a base_executor_config and merge operator level
feng-tao commented on issue #4407: [AIRFLOW-3600] Remove dagbag from trigger
URL: https://github.com/apache/airflow/pull/4407#issuecomment-452107835
@Fokko , looking at recent commit, this is the one that modifies this part
of the code. And the CI is not always fails with this
Ken Melms created AIRFLOW-3647:
--
Summary: Contributed SparkSubmitOperator doesn't honor --archives
configuration
Key: AIRFLOW-3647
URL: https://issues.apache.org/jira/browse/AIRFLOW-3647
Project: Apache
[
https://issues.apache.org/jira/browse/AIRFLOW-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Melms updated AIRFLOW-3647:
---
Description:
The contributed SparkSubmitOperator has no ability to honor the spark-submit
Fokko commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs
for index view.
URL: https://github.com/apache/airflow/pull/4390#discussion_r245817009
##
File path: airflow/www_rbac/compile_assets.sh
##
@@ -23,6 +23,6 @@ if [ -d airflow/www_rbac/static/dist
Fokko commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs
for index view.
URL: https://github.com/apache/airflow/pull/4390#discussion_r245817248
##
File path: airflow/models/__init__.py
##
@@ -240,6 +240,20 @@ def clear_task_instances(tis,
Fokko commented on issue #4399: [AIRFLOW-3594] Unify different License Header
URL: https://github.com/apache/airflow/pull/4399#issuecomment-452106547
@feluelle I've restarted the test, but due to the recent renaming, I'm not
sure if the status of the CI will propagate properly.
feng-tao commented on issue #4421: [AIRFLOW-3468] Remove KnownEvent(Event)?
URL: https://github.com/apache/airflow/pull/4421#issuecomment-452119451
but CI is failing.
This is an automated message from the Apache Git Service.
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452076833
Trying to resolve conflicts :D so that we can include
https://github.com/apache/incubator-airflow/pull/3770 and your DAG-level
feng-tao edited a comment on issue #: [AIRFLOW-3281] Fix Kubernetes
operator with git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452078774
hey @kaxil , that's great news. I think we may need to revert this
[
https://issues.apache.org/jira/browse/AIRFLOW-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736368#comment-16736368
]
Teresa Martyny commented on AIRFLOW-3292:
-
Sorry Ash, I just saw this response. We don't use
Fokko commented on issue #4351: [AIRFLOW-3554] Remove contrib folder from code
cov omit list
URL: https://github.com/apache/airflow/pull/4351#issuecomment-452098776
I'm okay with this as well. The contrib code should have tests as well.
feng-tao commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452078774
hey @kaxil , that's great news. I think we may need to revert this
Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure
that the session is closed
URL: https://github.com/apache/airflow/pull/4298#discussion_r245813920
##
File path: airflow/bin/cli.py
##
@@ -423,14 +418,11 @@ def unpause(args, dag=None):
def
[
https://issues.apache.org/jira/browse/AIRFLOW-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736462#comment-16736462
]
ASF GitHub Bot commented on AIRFLOW-3645:
-
Mokubyow commented on pull request #4456:
kaxil commented on issue #: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL: https://github.com/apache/airflow/pull/#issuecomment-452132314
@feng-tao I have included that commit as well.
@dimberman I have spent some time today and cherry-picked and resolved some
feluelle commented on a change in pull request #4449: [AIRFLOW-3638] Add tests
for PrestoToMySqlTransfer
URL: https://github.com/apache/airflow/pull/4449#discussion_r245590944
##
File path: tests/operators/test_presto_to_mysql.py
##
@@ -0,0 +1,37 @@
+import unittest
yohei1126 commented on issue #4453: [AIRFLOW-XXX] Fix existing flake8 errors
URL: https://github.com/apache/airflow/pull/4453#issuecomment-451875457
@feng-tao your build failed. Is this your test? please check
https://travis-ci.org/apache/airflow/jobs/476146347#L4902
```
jmcarp opened a new pull request #4458: [AIRFLOW-3648] Default to connection
project id in gcp cloud sql.
URL: https://github.com/apache/airflow/pull/4458
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
jmcarp commented on a change in pull request #4390: [AIRFLOW-3584] Use ORM DAGs
for index view.
URL: https://github.com/apache/airflow/pull/4390#discussion_r245878602
##
File path: airflow/www_rbac/compile_assets.sh
##
@@ -23,6 +23,6 @@ if [ -d
feng-tao commented on issue #4457: [AIRFLOW-3650] Skip running on mysql for the
flaky test
URL: https://github.com/apache/airflow/pull/4457#issuecomment-452203627
PTAL @kaxil @Fokko
I think the issue is not on the actual test itself, but on mysqlclient
library. The session can't
Tao Feng created AIRFLOW-3650:
-
Summary: Fix flaky test in TestTriggerDag
Key: AIRFLOW-3650
URL: https://issues.apache.org/jira/browse/AIRFLOW-3650
Project: Apache Airflow
Issue Type: Bug
70 matches
Mail list logo
