[GitHub] [airflow] codecov-io commented on issue #5390: [AIRFLOW-XXX] fix typos in README.md

codecov-io commented on issue #5390: [AIRFLOW-XXX] fix typos in README.md URL: https://github.com/apache/airflow/pull/5390#issuecomment-500106936 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5390?src=pr=h1) Report > Merging

[GitHub] [airflow] kurtqq opened a new pull request #5390: [AIRFLOW-XXX] fix typos in README.md

kurtqq opened a new pull request #5390: [AIRFLOW-XXX] fix typos in README.md URL: https://github.com/apache/airflow/pull/5390 fix typos This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mrshu commented on issue #5276: [AIRFLOW-4414] AWSAthenaOperator: Push QueryExecutionID to XCom

mrshu commented on issue #5276: [AIRFLOW-4414] AWSAthenaOperator: Push QueryExecutionID to XCom URL: https://github.com/apache/airflow/pull/5276#issuecomment-500108040 @feluelle Sorry it took me this long to get back to this. I've added a test as you suggested and also refactored

[GitHub] [airflow] BasPH merged pull request #5390: [AIRFLOW-XXX] fix typos in README.md

BasPH merged pull request #5390: [AIRFLOW-XXX] fix typos in README.md URL: https://github.com/apache/airflow/pull/5390 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] codecov-io commented on issue #5388: [AIRFLOW-4490] DagRun.conf returns empty dictionary by default

codecov-io commented on issue #5388: [AIRFLOW-4490] DagRun.conf returns empty dictionary by default URL: https://github.com/apache/airflow/pull/5388#issuecomment-500101598 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5388?src=pr=h1) Report > Merging

[GitHub] [airflow] BasPH commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible

BasPH commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r291817115 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing

[GitHub] [airflow] BasPH commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible

BasPH commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r291817115 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing

[GitHub] [airflow] BasPH commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

BasPH commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#discussion_r291817403 ## File path: airflow/example_dags/example_skip_dag.py ## @@ -30,21 +32,31 @@ # Create

[GitHub] [airflow] codecov-io commented on issue #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency

codecov-io commented on issue #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency URL: https://github.com/apache/airflow/pull/5363#issuecomment-500156020 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5363?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency

codecov-io commented on issue #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency URL: https://github.com/apache/airflow/pull/5363#issuecomment-500156021 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5363?src=pr=h1) Report > Merging

[GitHub] [airflow] BasPH commented on issue #4763: [AIRFLOW-3946] Deprecate utils.file.TemporaryDirectory

BasPH commented on issue #4763: [AIRFLOW-3946] Deprecate utils.file.TemporaryDirectory URL: https://github.com/apache/airflow/pull/4763#issuecomment-500158934 Good point :-) Removed all usage of `airflow.utils.file.TemporaryDirectory`.

[GitHub] [airflow] mik-laj commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

mik-laj commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#discussion_r291818634 ## File path: airflow/example_dags/example_skip_dag.py ## @@ -30,21 +32,31 @@ # Create

[GitHub] [airflow] mik-laj commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

mik-laj commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#discussion_r291818667 ## File path: airflow/example_dags/example_skip_dag.py ## @@ -30,21 +32,31 @@ # Create

[GitHub] [airflow] BasPH commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

BasPH commented on a change in pull request #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#discussion_r291818749 ## File path: airflow/example_dags/example_skip_dag.py ## @@ -30,21 +32,31 @@ # Create

[GitHub] [airflow] codecov-io edited a comment on issue #5302: [AIRFLOW-4374] Make enum-like-classes inherit from enum

codecov-io edited a comment on issue #5302: [AIRFLOW-4374] Make enum-like-classes inherit from enum URL: https://github.com/apache/airflow/pull/5302#issuecomment-493740734 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5302?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

codecov-io edited a comment on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#issuecomment-500166678 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5361?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

codecov-io commented on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#issuecomment-500166678 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5361?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

codecov-io edited a comment on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#issuecomment-500166678 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5361?src=pr=h1) Report > Merging

[GitHub] [airflow] kurtqq commented on issue #5356: [AIRFLOW-4363] Fix Json encoding error when retrieving `status` from cli in docker operator

kurtqq commented on issue #5356: [AIRFLOW-4363] Fix Json encoding error when retrieving `status` from cli in docker operator URL: https://github.com/apache/airflow/pull/5356#issuecomment-500130501 I remembered seeing similar report on Mac & docker:

[GitHub] [airflow] kurtqq commented on issue #5385: [AIRFLOW-4743] Add environment variables support to SSHOperator

kurtqq commented on issue #5385: [AIRFLOW-4743] Add environment variables support to SSHOperator URL: https://github.com/apache/airflow/pull/5385#issuecomment-500131106 You are probably gonna need to add/update the tests with the new parameter:

[GitHub] [airflow] ms32035 commented on issue #5385: [AIRFLOW-4743] Add environment variables support to SSHOperator

ms32035 commented on issue #5385: [AIRFLOW-4743] Add environment variables support to SSHOperator URL: https://github.com/apache/airflow/pull/5385#issuecomment-500138916 It defaults to `None`, so existing test should cover it, but added one test with a non default value. Whether these

[GitHub] [airflow] codecov-io commented on issue #5385: [AIRFLOW-4743] Add environment variables support to SSHOperator

codecov-io commented on issue #5385: [AIRFLOW-4743] Add environment variables support to SSHOperator URL: https://github.com/apache/airflow/pull/5385#issuecomment-500141643 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5385?src=pr=h1) Report > Merging

[GitHub] [airflow] kurtqq commented on issue #4520: [AIRFLOW-3703] Support DnsPolicy for KubernetesPodOperator

kurtqq commented on issue #4520: [AIRFLOW-3703] Support DnsPolicy for KubernetesPodOperator URL: https://github.com/apache/airflow/pull/4520#issuecomment-500145868 > > > > As a general comment, I think your new parameter should be called `dns_policy` instead of

[GitHub] [airflow] BasPH commented on a change in pull request #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency

BasPH commented on a change in pull request #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency URL: https://github.com/apache/airflow/pull/5363#discussion_r291816957 ## File path: setup.py ## @@ -171,7 +179,7 @@ def

[jira] [Commented] (AIRFLOW-4184) Add an AWS Athena Helper to insert into table

[ https://issues.apache.org/jira/browse/AIRFLOW-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859350#comment-16859350 ] ASF GitHub Bot commented on AIRFLOW-4184: - bryanyang0528 commented on pull request #4996:

[GitHub] [airflow] potiuk commented on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible

potiuk commented on issue #5361: [AIRFLOW-4670] Make airflow/example_dags Pylint compatible URL: https://github.com/apache/airflow/pull/5361#issuecomment-500186555 General comment: @BasPH - maybe we should disable the "pointless-statement" pylint check. It seems like heavily polluting the

[GitHub] [airflow] potiuk commented on issue #5275: [AIRFLOW-4505] New tag for only PY3 packages

potiuk commented on issue #5275: [AIRFLOW-4505] New tag for only PY3 packages URL: https://github.com/apache/airflow/pull/5275#issuecomment-500185049 @raphaelauv What regression ? I cannot see any scenario where it could break things ? If you are using py2 it will continue working as it

[GitHub] [airflow] potiuk commented on issue #5335: [AIRFLOW-4588] Add GoogleApiClientHook

potiuk commented on issue #5335: [AIRFLOW-4588] Add GoogleApiClientHook URL: https://github.com/apache/airflow/pull/5335#issuecomment-500186292 @feluelle - do you want to follow up on that ? My only concern with that one is that it introduces a new base GCP hook where we already have one.

[jira] [Commented] (AIRFLOW-4725) Make setup.py run without errors/warnings

[ https://issues.apache.org/jira/browse/AIRFLOW-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859366#comment-16859366 ] ASF subversion and git services commented on AIRFLOW-4725: -- Commit

[jira] [Commented] (AIRFLOW-4725) Make setup.py run without errors/warnings

[ https://issues.apache.org/jira/browse/AIRFLOW-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859364#comment-16859364 ] ASF subversion and git services commented on AIRFLOW-4725: -- Commit

[jira] [Resolved] (AIRFLOW-4725) Make setup.py run without errors/warnings

[ https://issues.apache.org/jira/browse/AIRFLOW-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4725. --- Resolution: Fixed Fix Version/s: 2.0.0 > Make setup.py run without errors/warnings

[GitHub] [airflow] milton0825 commented on a change in pull request #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions

milton0825 commented on a change in pull request #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions URL: https://github.com/apache/airflow/pull/5386#discussion_r291824346 ## File path: airflow/models/dagbag.py ## @@ -233,7 +235,8 @@ def process_file(self,

[GitHub] [airflow] milton0825 commented on a change in pull request #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions

milton0825 commented on a change in pull request #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions URL: https://github.com/apache/airflow/pull/5386#discussion_r291824342 ## File path: airflow/models/dagbag.py ## @@ -198,7 +199,8 @@ def process_file(self,

[jira] [Updated] (AIRFLOW-4725) Make setup.py run without errors/warnings

[ https://issues.apache.org/jira/browse/AIRFLOW-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4725: -- Fix Version/s: 1.10.4 > Make setup.py run without errors/warnings >

[GitHub] [airflow] potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible

potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r291827624 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing

[GitHub] [airflow] potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible

potiuk commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible URL: https://github.com/apache/airflow/pull/5362#discussion_r291827624 ## File path: airflow/dag/base_dag.py ## @@ -17,6 +17,8 @@ # specific language governing

[jira] [Commented] (AIRFLOW-4725) Make setup.py run without errors/warnings

[ https://issues.apache.org/jira/browse/AIRFLOW-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859363#comment-16859363 ] ASF GitHub Bot commented on AIRFLOW-4725: - potiuk commented on pull request #5363:

[GitHub] [airflow] potiuk merged pull request #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency

potiuk merged pull request #5363: [AIRFLOW-4725] Fix setup.py PEP440 & Sphinx-PyPI-upload dependency URL: https://github.com/apache/airflow/pull/5363 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table

bryanyang0528 commented on a change in pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table URL: https://github.com/apache/airflow/pull/4996#discussion_r291825956 ## File path: airflow/contrib/hooks/aws_athena_hook.py ## @@ -148,3 +156,105 @@ def

[GitHub] [airflow] bryanyang0528 closed pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table

bryanyang0528 closed pull request #4996: [AIRFLOW-4184] Add an athena helper to insert into table URL: https://github.com/apache/airflow/pull/4996 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] dossett commented on issue #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions

dossett commented on issue #5386: AIRFLOW-4748 Print stacktrace for dagbag process exceptions URL: https://github.com/apache/airflow/pull/5386#issuecomment-500177728 One of the test suites passed, some others failed, I can't tell if the failures are connected to this change or not.