[jira] [Created] (AIRFLOW-5160) Remove DAG count test

2019-08-10 Thread Bas Harenslak (JIRA)
Bas Harenslak created AIRFLOW-5160: -- Summary: Remove DAG count test Key: AIRFLOW-5160 URL: https://issues.apache.org/jira/browse/AIRFLOW-5160 Project: Apache Airflow Issue Type: Improvement

[GitHub] [airflow] BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template

2019-08-10 Thread GitBox
BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#issuecomment-520141652 @ashb any other remarks on this PR, or is it good to go? This is an automated mess

[GitHub] [airflow] BasPH opened a new pull request #5775: [AIRFLOW-5160] Remove example DAG count test

2019-08-10 Thread GitBox
BasPH opened a new pull request #5775: [AIRFLOW-5160] Remove example DAG count test URL: https://github.com/apache/airflow/pull/5775 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse

[jira] [Commented] (AIRFLOW-5160) Remove DAG count test

2019-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904409#comment-16904409 ] ASF GitHub Bot commented on AIRFLOW-5160: - BasPH commented on pull request #577

[GitHub] [airflow] potiuk commented on issue #5774: [AIRFLOW-5159] Checklicence image is not built when not needed

2019-08-10 Thread GitBox
potiuk commented on issue #5774: [AIRFLOW-5159] Checklicence image is not built when not needed URL: https://github.com/apache/airflow/pull/5774#issuecomment-520145968 This one will be helpful to get pre-commits working (follow-up PR) --

[GitHub] [airflow] mik-laj opened a new pull request #5776: [AIRFLOW-XXX] Add section in TOC with all reference guides

2019-08-10 Thread GitBox
mik-laj opened a new pull request #5776: [AIRFLOW-XXX] Add section in TOC with all reference guides URL: https://github.com/apache/airflow/pull/5776 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache

[jira] [Created] (AIRFLOW-5161) Add pre-commit hooks to run static checks for only changed files

2019-08-10 Thread Jarek Potiuk (JIRA)
Jarek Potiuk created AIRFLOW-5161: - Summary: Add pre-commit hooks to run static checks for only changed files Key: AIRFLOW-5161 URL: https://issues.apache.org/jira/browse/AIRFLOW-5161 Project: Apache

[GitHub] [airflow] potiuk merged pull request #5774: [AIRFLOW-5159] Checklicence image is not built when not needed

2019-08-10 Thread GitBox
potiuk merged pull request #5774: [AIRFLOW-5159] Checklicence image is not built when not needed URL: https://github.com/apache/airflow/pull/5774 This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (AIRFLOW-5159) Optimise checklicence image build (do not build if not needed)

2019-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904447#comment-16904447 ] ASF GitHub Bot commented on AIRFLOW-5159: - potiuk commented on pull request #57

[jira] [Commented] (AIRFLOW-5159) Optimise checklicence image build (do not build if not needed)

2019-08-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904449#comment-16904449 ] ASF subversion and git services commented on AIRFLOW-5159: -- Co

[jira] [Commented] (AIRFLOW-5159) Optimise checklicence image build (do not build if not needed)

2019-08-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904467#comment-16904467 ] ASF subversion and git services commented on AIRFLOW-5159: -- Co

[jira] [Resolved] (AIRFLOW-5159) Optimise checklicence image build (do not build if not needed)

2019-08-10 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-5159. --- Resolution: Fixed Fix Version/s: 1.10.5 > Optimise checklicence image build (do not

[GitHub] [airflow] potiuk opened a new pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
potiuk opened a new pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://is

[jira] [Commented] (AIRFLOW-5161) Add pre-commit hooks to run static checks for only changed files

2019-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904481#comment-16904481 ] ASF GitHub Bot commented on AIRFLOW-5161: - potiuk commented on pull request #57

[GitHub] [airflow] potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#issuecomment-520167375 Hey. While flying to NYC I managed to rebase, cleanup and trim-down pre-commit hook implementation for all our sta

[GitHub] [airflow] potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#issuecomment-520167962 @nuclearpinguin ^^ also you can help to see if that works as expected :) -

[GitHub] [airflow] potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
potiuk commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#issuecomment-520168998 All documentation and instructions are in https://github.com/PolideaInternal/airflow/blob/pre-commit-hooks/CONTRIB

[GitHub] [airflow] ashb commented on issue #5461: [AIRFLOW-4835] Refactor render_template

2019-08-10 Thread GitBox
ashb commented on issue #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#issuecomment-520175353 @bazph I took a week off, will look again in the morning This is an automated messa

[GitHub] [airflow] coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520179192 > Pending Issues: > > * We still have the issue of `SerializedBaseOperator` being displayed in Gr

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520179192 > Pending Issues: > > * We still have the issue of `SerializedBaseOperator` being displayed

[GitHub] [airflow] coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520182466 > Pending Issues: > > * Issue displaying SubDags: This bug is because subdags are not added

[GitHub] [airflow] coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant fields. We s

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant field

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant field

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant field

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant field

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant field

[GitHub] [airflow] coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-08-10 Thread GitBox
coufon edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-520183227 I saw two remaining issues: (1) Serialized DAGs/Operators are big with many redundant field

[jira] [Assigned] (AIRFLOW-2923) LatestOnlyOperator cascade skip through all_done and dummy

2019-08-10 Thread Cedrik Neumann (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cedrik Neumann reassigned AIRFLOW-2923: --- Assignee: Cedrik Neumann > LatestOnlyOperator cascade skip through all_done and du

[jira] [Assigned] (AIRFLOW-1784) SKIPPED status is being cascading wrongly

2019-08-10 Thread Cedrik Neumann (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cedrik Neumann reassigned AIRFLOW-1784: --- Assignee: Cedrik Neumann > SKIPPED status is being cascading wrongly > ---

[jira] [Commented] (AIRFLOW-2923) LatestOnlyOperator cascade skip through all_done and dummy

2019-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904526#comment-16904526 ] ASF GitHub Bot commented on AIRFLOW-2923: - m1racoli commented on pull request #

[GitHub] [airflow] m1racoli opened a new pull request #5778: [AIRFLOW-2923][AIRFLOW-1784] Let operators inherit from BaseBranchOperator

2019-08-10 Thread GitBox
m1racoli opened a new pull request #5778: [AIRFLOW-2923][AIRFLOW-1784] Let operators inherit from BaseBranchOperator URL: https://github.com/apache/airflow/pull/5778 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](http

[GitHub] [airflow] dimberman commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on issue #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#issuecomment-520195573 @potiuk dang that was a seriously productive flight. Looking over now :) --

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721183 ## File path: CONTRIBUTING.md ## @@ -583,67 +611,84 @@ class LoginForm(Form)

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721167 ## File path: CONTRIBUTING.md ## @@ -583,67 +611,84 @@ class LoginForm(Form)

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721101 ## File path: CONTRIBUTING.md ## @@ -430,6 +450,14 @@ See [Troubleshooting s

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721122 ## File path: CONTRIBUTING.md ## @@ -430,6 +450,14 @@ See [Troubleshooting s

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721078 ## File path: CONTRIBUTING.md ## @@ -348,17 +365,20 @@ they should give the

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721031 ## File path: CONTRIBUTING.md ## @@ -174,7 +184,14 @@ mkvirtualenv --python

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721141 ## File path: CONTRIBUTING.md ## @@ -583,67 +611,84 @@ class LoginForm(Form)

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721179 ## File path: CONTRIBUTING.md ## @@ -583,67 +611,84 @@ class LoginForm(Form)

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721024 ## File path: CONTRIBUTING.md ## @@ -174,7 +184,14 @@ mkvirtualenv --python

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721172 ## File path: CONTRIBUTING.md ## @@ -583,67 +611,84 @@ class LoginForm(Form)

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721158 ## File path: CONTRIBUTING.md ## @@ -583,67 +611,84 @@ class LoginForm(Form)

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721036 ## File path: CONTRIBUTING.md ## @@ -174,7 +184,14 @@ mkvirtualenv --python

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721107 ## File path: CONTRIBUTING.md ## @@ -430,6 +450,14 @@ See [Troubleshooting s

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721073 ## File path: CONTRIBUTING.md ## @@ -348,17 +365,20 @@ they should give the

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721116 ## File path: CONTRIBUTING.md ## @@ -430,6 +450,14 @@ See [Troubleshooting s

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721087 ## File path: CONTRIBUTING.md ## @@ -348,17 +365,20 @@ they should give the

[GitHub] [airflow] dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks

2019-08-10 Thread GitBox
dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721013 ## File path: CONTRIBUTING.md ## @@ -142,6 +149,9 @@ environment and you can