[jira] [Commented] (AIRFLOW-4983) DataflowPythonOperator should be able to submit pipelines with python3

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925387#comment-16925387 ] ASF GitHub Bot commented on AIRFLOW-4983: - mik-laj commented on pull request #5602:

[jira] [Commented] (AIRFLOW-4983) DataflowPythonOperator should be able to submit pipelines with python3

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925388#comment-16925388 ] ASF subversion and git services commented on AIRFLOW-4983: -- Commit

[GitHub] [airflow] potiuk commented on issue #6023: [AIRFLOW-5417] Fix DB disconnects during webserver startup

2019-09-09 Thread GitBox
potiuk commented on issue #6023: [AIRFLOW-5417] Fix DB disconnects during webserver startup URL: https://github.com/apache/airflow/pull/6023#issuecomment-529312661 Fair :). It's LGTM for me but maybe someone with more insight of Flask Can also take a look.

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports

2019-09-09 Thread GitBox
KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944#discussion_r322074650 ## File path: .pre-commit-config.yaml ## @@ -190,8 +190,16 @@ repos: language: system entry:

[GitHub] [airflow] mik-laj merged pull request #5602: [AIRFLOW-4983] Add ability for DataflowPythonOperator to submit jobs w/ python3

2019-09-09 Thread GitBox
mik-laj merged pull request #5602: [AIRFLOW-4983] Add ability for DataflowPythonOperator to submit jobs w/ python3 URL: https://github.com/apache/airflow/pull/5602 This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar

2019-09-09 Thread GitBox
potiuk commented on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar URL: https://github.com/apache/airflow/pull/6062#issuecomment-529377741 @dimberman - is this OK from the "production" point of view? I am not sure what was the design

[GitHub] [airflow] milton0825 merged pull request #6055: [AIRFLOW-XXX] Create KubernetesPodOperator guide

2019-09-09 Thread GitBox
milton0825 merged pull request #6055: [AIRFLOW-XXX] Create KubernetesPodOperator guide URL: https://github.com/apache/airflow/pull/6055 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] bharathpalaksha commented on a change in pull request #6026: [AIRFLOW-5419] - Use `sudo` to kill cleared tasks when running with impersonation

2019-09-09 Thread GitBox
bharathpalaksha commented on a change in pull request #6026: [AIRFLOW-5419] - Use `sudo` to kill cleared tasks when running with impersonation URL: https://github.com/apache/airflow/pull/6026#discussion_r322078865 ## File path: airflow/utils/helpers.py ## @@ -307,7 +308,7

[jira] [Created] (AIRFLOW-5446) Rewrite Google KMS Hook with Google Api Client

2019-09-09 Thread Tobiasz Kedzierski (Jira)
Tobiasz Kedzierski created AIRFLOW-5446: --- Summary: Rewrite Google KMS Hook with Google Api Client Key: AIRFLOW-5446 URL: https://issues.apache.org/jira/browse/AIRFLOW-5446 Project: Apache

[GitHub] [airflow] codecov-io commented on issue #6026: [AIRFLOW-5419] - Use `sudo` to kill cleared tasks when running with impersonation

2019-09-09 Thread GitBox
codecov-io commented on issue #6026: [AIRFLOW-5419] - Use `sudo` to kill cleared tasks when running with impersonation URL: https://github.com/apache/airflow/pull/6026#issuecomment-529366762 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6026?src=pr=h1) Report > :exclamation: No

[jira] [Commented] (AIRFLOW-5376) Codecov does not work for new CI :(

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925500#comment-16925500 ] ASF subversion and git services commented on AIRFLOW-5376: -- Commit

[jira] [Commented] (AIRFLOW-5368) Display DAG from the CLI

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925495#comment-16925495 ] ASF subversion and git services commented on AIRFLOW-5368: -- Commit

[jira] [Commented] (AIRFLOW-5436) Remove log from init in BigQuery operators

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925496#comment-16925496 ] ASF subversion and git services commented on AIRFLOW-5436: -- Commit

[jira] [Commented] (AIRFLOW-5437) When you run Breeze, no matter what image is build python 3.5 from checks overrides run version

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925498#comment-16925498 ] ASF subversion and git services commented on AIRFLOW-5437: -- Commit

[jira] [Commented] (AIRFLOW-5376) Codecov does not work for new CI :(

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925501#comment-16925501 ] ASF subversion and git services commented on AIRFLOW-5376: -- Commit

[jira] [Commented] (AIRFLOW-5376) Codecov does not work for new CI :(

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925499#comment-16925499 ] ASF subversion and git services commented on AIRFLOW-5376: -- Commit

[jira] [Commented] (AIRFLOW-5425) Use logging not printing in LoggingCommandExecutor

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925497#comment-16925497 ] ASF subversion and git services commented on AIRFLOW-5425: -- Commit

[jira] [Commented] (AIRFLOW-5446) Rewrite Google KMS Hook with Google Api Client

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925522#comment-16925522 ] ASF GitHub Bot commented on AIRFLOW-5446: - TobKed commented on pull request #6065:

[GitHub] [airflow] mik-laj commented on issue #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python

2019-09-09 Thread GitBox
mik-laj commented on issue #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6065#issuecomment-529384348 Travis likes to make surprises. This is an automated

[jira] [Commented] (AIRFLOW-5446) Rewrite Google KMS Hook with Google Api Client

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925521#comment-16925521 ] ASF GitHub Bot commented on AIRFLOW-5446: - mik-laj commented on pull request #6065:

[GitHub] [airflow] TobKed opened a new pull request #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python

2019-09-09 Thread GitBox
TobKed opened a new pull request #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6065 Use google-clooud-kms library in KMS Hook Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses

[GitHub] [airflow] mik-laj closed pull request #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python

2019-09-09 Thread GitBox
mik-laj closed pull request #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6065 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] codecov-io commented on issue #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling

2019-09-09 Thread GitBox
codecov-io commented on issue #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling URL: https://github.com/apache/airflow/pull/6034#issuecomment-529384229 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6034?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar

2019-09-09 Thread GitBox
potiuk commented on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar URL: https://github.com/apache/airflow/pull/6059#issuecomment-529381992 One watchout here @dimberman @mik-laj : I read recently an article advising against using alpine engine in production

[jira] [Closed] (AIRFLOW-4983) DataflowPythonOperator should be able to submit pipelines with python3

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-4983. -- Fix Version/s: 1.10.6 Resolution: Fixed > DataflowPythonOperator should be able to

[GitHub] [airflow] KevinYang21 commented on issue #6023: [AIRFLOW-5417] Fix DB disconnects during webserver startup

2019-09-09 Thread GitBox
KevinYang21 commented on issue #6023: [AIRFLOW-5417] Fix DB disconnects during webserver startup URL: https://github.com/apache/airflow/pull/6023#issuecomment-529311930 @potiuk thanks for reviewing and the idea. Actually I think the cost is actually less if we just remove the session. We

[jira] [Commented] (AIRFLOW-5444) action_logging missing important fields such as Dag Id and Task Id for POST actions

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925417#comment-16925417 ] ASF GitHub Bot commented on AIRFLOW-5444: - yuqian90 commented on pull request #6064:

[GitHub] [airflow] TobKed opened a new pull request #6065: [AIRFLOW-5446] Rewrite Google KMS Hook with Google Api Client

2019-09-09 Thread GitBox
TobKed opened a new pull request #6065: [AIRFLOW-5446] Rewrite Google KMS Hook with Google Api Client URL: https://github.com/apache/airflow/pull/6065 Use google-clooud-kms library in KMS Hook Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses

[jira] [Commented] (AIRFLOW-5446) Rewrite Google KMS Hook with Google Api Client

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925418#comment-16925418 ] ASF GitHub Bot commented on AIRFLOW-5446: - TobKed commented on pull request #6065:

[GitHub] [airflow] yuqian90 opened a new pull request #6064: [AIRFLOW-5444] Fix action_logging so that request.form for POST is logged

2019-09-09 Thread GitBox
yuqian90 opened a new pull request #6064: [AIRFLOW-5444] Fix action_logging so that request.form for POST is logged URL: https://github.com/apache/airflow/pull/6064 - Log request.form when request.method is POST - Add a test for action_logging Make sure you have checked _all_

[GitHub] [airflow] codecov-io edited a comment on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar

2019-09-09 Thread GitBox
codecov-io edited a comment on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar URL: https://github.com/apache/airflow/pull/6059#issuecomment-529288430 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6059?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on issue #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python

2019-09-09 Thread GitBox
potiuk commented on issue #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6065#issuecomment-529376968 Strange - for some reason the PR has started but there is no check in the conversation here Really strange...

[GitHub] [airflow] codecov-io edited a comment on issue #5976: [AIRFLOW-5369] [DO NOT MERGE YET] Add interactivity to pre-commits

2019-09-09 Thread GitBox
codecov-io edited a comment on issue #5976: [AIRFLOW-5369] [DO NOT MERGE YET] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5976: [AIRFLOW-5369] [DO NOT MERGE YET] Add interactivity to pre-commits

2019-09-09 Thread GitBox
codecov-io commented on issue #5976: [AIRFLOW-5369] [DO NOT MERGE YET] Add interactivity to pre-commits URL: https://github.com/apache/airflow/pull/5976#issuecomment-529314175 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5976?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-3601) update operators to BigQuery to support location

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925502#comment-16925502 ] ASF GitHub Bot commented on AIRFLOW-3601: - potiuk commented on pull request #6020:

[jira] [Commented] (AIRFLOW-3601) update operators to BigQuery to support location

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925503#comment-16925503 ] ASF subversion and git services commented on AIRFLOW-3601: -- Commit

[jira] [Resolved] (AIRFLOW-4575) Operators using BigQueryHook need to provide location field

2019-09-09 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4575. --- Fix Version/s: 2.0.0 Resolution: Fixed > Operators using BigQueryHook need to

[GitHub] [airflow] potiuk merged pull request #6020: [AIRFLOW-3601][AIRFLOW-4288][AIRFLOW-4287][AIRFLOW-4575] Update operators to BigQuery to support location

2019-09-09 Thread GitBox
potiuk merged pull request #6020: [AIRFLOW-3601][AIRFLOW-4288][AIRFLOW-4287][AIRFLOW-4575] Update operators to BigQuery to support location URL: https://github.com/apache/airflow/pull/6020 This is an automated message from

[GitHub] [airflow] TobKed commented on issue #5965: [AIRFLOW-5359] Update type annotations in BaseOperator

2019-09-09 Thread GitBox
TobKed commented on issue #5965: [AIRFLOW-5359] Update type annotations in BaseOperator URL: https://github.com/apache/airflow/pull/5965#issuecomment-529336322 cc @mik-laj @potiuk This is an automated message from the

[GitHub] [airflow] codecov-io commented on issue #6020: [AIRFLOW-3601][AIRFLOW-4288][AIRFLOW-4287][AIRFLOW-4575] Update operators to BigQuery to support location

2019-09-09 Thread GitBox
codecov-io commented on issue #6020: [AIRFLOW-3601][AIRFLOW-4288][AIRFLOW-4287][AIRFLOW-4575] Update operators to BigQuery to support location URL: https://github.com/apache/airflow/pull/6020#issuecomment-529372511 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6020?src=pr=h1)

[GitHub] [airflow] kaxil edited a comment on issue #6066: [AIRFLOW-XXX] Update to new logo

2019-09-09 Thread GitBox
kaxil edited a comment on issue #6066: [AIRFLOW-XXX] Update to new logo URL: https://github.com/apache/airflow/pull/6066#issuecomment-529431509 The only thing missing is probably a **large transparent Airflow logo**. We have a transparent image as emoji but not with bigger size.

[GitHub] [airflow] kaxil commented on issue #6066: [AIRFLOW-XXX] Update to new logo

2019-09-09 Thread GitBox
kaxil commented on issue #6066: [AIRFLOW-XXX] Update to new logo URL: https://github.com/apache/airflow/pull/6066#issuecomment-529431509 The only thing missing is probably a **large transparent Airflow logo** This is an

[jira] [Closed] (AIRFLOW-5443) Use alpine image in Kubernetes's sidecar

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5443. -- Fix Version/s: 1.10.6 Resolution: Fixed > Use alpine image in Kubernetes's sidecar >

[jira] [Commented] (AIRFLOW-5443) Use alpine image in Kubernetes's sidecar

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925650#comment-16925650 ] ASF GitHub Bot commented on AIRFLOW-5443: - mik-laj commented on pull request #6059:

[jira] [Commented] (AIRFLOW-5443) Use alpine image in Kubernetes's sidecar

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925651#comment-16925651 ] ASF subversion and git services commented on AIRFLOW-5443: -- Commit

[GitHub] [airflow] dimberman commented on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar

2019-09-09 Thread GitBox
dimberman commented on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar URL: https://github.com/apache/airflow/pull/6059#issuecomment-529469436 @potiuk I'm with @mik-laj here. If this starts becoming a problem we can address it, but I'd rather not add more branching

[jira] [Commented] (AIRFLOW-4593) Memory leak in Airflow scheduler

2019-09-09 Thread jack (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925600#comment-16925600 ] jack commented on AIRFLOW-4593: --- [~mmorawski] yep it was fixed by 

[GitHub] [airflow] potiuk merged pull request #6063: Add BigQuant to list of current users

2019-09-09 Thread GitBox
potiuk merged pull request #6063: Add BigQuant to list of current users URL: https://github.com/apache/airflow/pull/6063 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] ashb opened a new pull request #6066: [AIRFLOW-XXX] Update to new logo

2019-09-09 Thread GitBox
ashb opened a new pull request #6066: [AIRFLOW-XXX] Update to new logo URL: https://github.com/apache/airflow/pull/6066 I have removed the static/favicon.ico as this wasn't referenced in the templates, and wasn't configured to be served as `/favicon.ico` (only as

[GitHub] [airflow] codecov-io commented on issue #5990: [AIRFLOW-5390] Remove provide context

2019-09-09 Thread GitBox
codecov-io commented on issue #5990: [AIRFLOW-5390] Remove provide context URL: https://github.com/apache/airflow/pull/5990#issuecomment-529434837 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5990?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python

2019-09-09 Thread GitBox
codecov-io commented on issue #6065: [AIRFLOW-5446] Rewrite Google KMS Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6065#issuecomment-529443473 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6065?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4052) To allow filtering using "event" and "owner" in "Log" view

2019-09-09 Thread jack (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925599#comment-16925599 ] jack commented on AIRFLOW-4052: --- [~yuqian90]  The fix is only in Master not in 1.10.X Maybe you can

[jira] [Commented] (AIRFLOW-5402) Remove deprecated logger

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925677#comment-16925677 ] ASF subversion and git services commented on AIRFLOW-5402: -- Commit

[jira] [Commented] (AIRFLOW-5402) Remove deprecated logger

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925676#comment-16925676 ] ASF subversion and git services commented on AIRFLOW-5402: -- Commit

[GitHub] [airflow] Fokko merged pull request #6006: [AIRFLOW-5402] Remove deprecated logger

2019-09-09 Thread GitBox
Fokko merged pull request #6006: [AIRFLOW-5402] Remove deprecated logger URL: https://github.com/apache/airflow/pull/6006 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (AIRFLOW-5402) Remove deprecated logger

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925674#comment-16925674 ] ASF GitHub Bot commented on AIRFLOW-5402: - Fokko commented on pull request #6006:

[jira] [Resolved] (AIRFLOW-5402) Remove deprecated logger

2019-09-09 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-5402. --- Resolution: Fixed > Remove deprecated logger > > >

[GitHub] [airflow] Khrol commented on issue #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling

2019-09-09 Thread GitBox
Khrol commented on issue #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling URL: https://github.com/apache/airflow/pull/6034#issuecomment-529388255 Codecov report is confusing in terms of coverage. There are mainly code deletions here.

[GitHub] [airflow] mik-laj commented on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar

2019-09-09 Thread GitBox
mik-laj commented on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar URL: https://github.com/apache/airflow/pull/6062#issuecomment-529395028 All in all, I thought about it longer and we can turn off resource request at all. It is common practice for

[GitHub] [airflow] mik-laj edited a comment on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar

2019-09-09 Thread GitBox
mik-laj edited a comment on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar URL: https://github.com/apache/airflow/pull/6062#issuecomment-529395028 I thought about it longer and we can turn off resource request at all. It is common practice for this

[jira] [Commented] (AIRFLOW-5376) Codecov does not work for new CI :(

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925615#comment-16925615 ] ASF subversion and git services commented on AIRFLOW-5376: -- Commit

[jira] [Commented] (AIRFLOW-5376) Codecov does not work for new CI :(

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925616#comment-16925616 ] ASF subversion and git services commented on AIRFLOW-5376: -- Commit

[jira] [Commented] (AIRFLOW-5436) Remove log from init in BigQuery operators

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925611#comment-16925611 ] ASF subversion and git services commented on AIRFLOW-5436: -- Commit

[jira] [Commented] (AIRFLOW-5437) When you run Breeze, no matter what image is build python 3.5 from checks overrides run version

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925613#comment-16925613 ] ASF subversion and git services commented on AIRFLOW-5437: -- Commit

[jira] [Commented] (AIRFLOW-5425) Use logging not printing in LoggingCommandExecutor

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925612#comment-16925612 ] ASF subversion and git services commented on AIRFLOW-5425: -- Commit

[jira] [Commented] (AIRFLOW-5376) Codecov does not work for new CI :(

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925614#comment-16925614 ] ASF subversion and git services commented on AIRFLOW-5376: -- Commit

[jira] [Commented] (AIRFLOW-5368) Display DAG from the CLI

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925610#comment-16925610 ] ASF subversion and git services commented on AIRFLOW-5368: -- Commit

[GitHub] [airflow] KevinYang21 commented on issue #6023: [AIRFLOW-5417] Fix DB disconnects during webserver startup

2019-09-09 Thread GitBox
KevinYang21 commented on issue #6023: [AIRFLOW-5417] Fix DB disconnects during webserver startup URL: https://github.com/apache/airflow/pull/6023#issuecomment-529404419 TY! I'll keep it open for two more days then. This is

[GitHub] [airflow] mik-laj commented on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar

2019-09-09 Thread GitBox
mik-laj commented on issue #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar URL: https://github.com/apache/airflow/pull/6059#issuecomment-529454539 Kubernetes is very difficult to configure right now. I think we should wait for someone to report the problem and then solve

[GitHub] [airflow] mik-laj merged pull request #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar

2019-09-09 Thread GitBox
mik-laj merged pull request #6059: [AIRFLOW-5443] Use alpine image in Kubernetes's sidecar URL: https://github.com/apache/airflow/pull/6059 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] tooptoop4 commented on issue #5458: [AIRFLOW-4495] allow externally triggered dags to run for future 'Exe…

2019-09-09 Thread GitBox
tooptoop4 commented on issue #5458: [AIRFLOW-4495] allow externally triggered dags to run for future 'Exe… URL: https://github.com/apache/airflow/pull/5458#issuecomment-529782807 test updated This is an automated message

[GitHub] [airflow] codecov-io commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-09-09 Thread GitBox
codecov-io commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755236 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-09-09 Thread GitBox
codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-09-09 Thread GitBox
codecov-io commented on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] yuqian90 commented on issue #5458: [AIRFLOW-4495] allow externally triggered dags to run for future 'Exe…

2019-09-09 Thread GitBox
yuqian90 commented on issue #5458: [AIRFLOW-4495] allow externally triggered dags to run for future 'Exe… URL: https://github.com/apache/airflow/pull/5458#issuecomment-529768918 I like the idea in this change. I agree that the following check should be removed (at least for externally

[jira] [Commented] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925956#comment-16925956 ] Kamil Bregula commented on AIRFLOW-5418: Bucket cannot contain slash.  !Screenshot 2019-09-09

[jira] [Commented] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925961#comment-16925961 ] Kamil Bregula commented on AIRFLOW-5418: Can you show proof that a bucket can contain slash? >

[GitHub] [airflow] tiopi commented on a change in pull request #5407: [AIRFLOW-4741] Include Sentry into core Airflow

2019-09-09 Thread GitBox
tiopi commented on a change in pull request #5407: [AIRFLOW-4741] Include Sentry into core Airflow URL: https://github.com/apache/airflow/pull/5407#discussion_r322380054 ## File path: airflow/sentry.py ## @@ -0,0 +1,196 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the

[GitHub] [airflow] milton0825 merged pull request #6061: [AIRFLOW-5441] Ownership of package*.json file group write is fixed

2019-09-09 Thread GitBox
milton0825 merged pull request #6061: [AIRFLOW-5441] Ownership of package*.json file group write is fixed URL: https://github.com/apache/airflow/pull/6061 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (AIRFLOW-5441) When you force pull images with Breeze it rebuilds npm unnecessarily

2019-09-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925391#comment-16925391 ] ASF subversion and git services commented on AIRFLOW-5441: -- Commit

[jira] [Commented] (AIRFLOW-5441) When you force pull images with Breeze it rebuilds npm unnecessarily

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925390#comment-16925390 ] ASF GitHub Bot commented on AIRFLOW-5441: - milton0825 commented on pull request #6061:

[GitHub] [airflow] Khrol commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling

2019-09-09 Thread GitBox
Khrol commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling URL: https://github.com/apache/airflow/pull/6034#discussion_r322086884 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -125,11 +125,7 @@

[GitHub] [airflow] codecov-io commented on issue #6063: Add BigQuant to list of current users

2019-09-09 Thread GitBox
codecov-io commented on issue #6063: Add BigQuant to list of current users URL: https://github.com/apache/airflow/pull/6063#issuecomment-529328224 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6063?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4593) Memory leak in Airflow scheduler

2019-09-09 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925452#comment-16925452 ] Mikołaj Morawski commented on AIRFLOW-4593: --- Hi,   I upgraded Airflow to version 1.10.4 and

[GitHub] [airflow] bharathpalaksha commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling

2019-09-09 Thread GitBox
bharathpalaksha commented on a change in pull request #6034: [AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling URL: https://github.com/apache/airflow/pull/6034#discussion_r322133632 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -125,11

[jira] [Resolved] (AIRFLOW-4287) location support for BigQueryGetDataOperator

2019-09-09 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4287. --- Fix Version/s: 2.0.0 Resolution: Fixed > location support for

[jira] [Resolved] (AIRFLOW-3601) update operators to BigQuery to support location

2019-09-09 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-3601. --- Fix Version/s: 2.0.0 Resolution: Fixed > update operators to BigQuery to support

[jira] [Resolved] (AIRFLOW-4288) location support for BigQueryToBigQueryOperator

2019-09-09 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4288. --- Fix Version/s: 2.0.0 Resolution: Fixed > location support for

[jira] [Commented] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Leah (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925950#comment-16925950 ] Leah commented on AIRFLOW-5418: --- No - this is still an issue. Slash names in buckets are valid, and using

[jira] [Commented] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925960#comment-16925960 ] Kamil Bregula commented on AIRFLOW-5418: Bucket is a "root directory" Object is a directory

[jira] [Commented] (AIRFLOW-5448) Make Kubernetes Executor compatible with Istio service mesh

2019-09-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925940#comment-16925940 ] ASF GitHub Bot commented on AIRFLOW-5448: - sjmiller609 commented on pull request #6067:

[GitHub] [airflow] InigoSJ commented on a change in pull request #6058: [AIRFLOW-5439] Add 'schedule_interval' to 'default_args'

2019-09-09 Thread GitBox
InigoSJ commented on a change in pull request #6058: [AIRFLOW-5439] Add 'schedule_interval' to 'default_args' URL: https://github.com/apache/airflow/pull/6058#discussion_r322398397 ## File path: tests/models/test_dag.py ## @@ -890,3 +890,9 @@ def test_tree_view(self):

[GitHub] [airflow] sjmiller609 opened a new pull request #6067: [AIRFLOW-5448] Handle istio-proxy for Kubernetes Executor

2019-09-09 Thread GitBox
sjmiller609 opened a new pull request #6067: [AIRFLOW-5448] Handle istio-proxy for Kubernetes Executor URL: https://github.com/apache/airflow/pull/6067 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925948#comment-16925948 ] Kamil Bregula commented on AIRFLOW-5418: Yes. Even more interesting is when the name contains

[jira] [Updated] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula updated AIRFLOW-5418: --- Attachment: Screenshot 2019-09-09 at 19.46.26.png > bucket names with a slash in them

[GitHub] [airflow] codecov-io commented on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar

2019-09-09 Thread GitBox
codecov-io commented on issue #6062: [AIRFLOW-5445] Reduce the required resources for the Kubernetes's sideecar URL: https://github.com/apache/airflow/pull/6062#issuecomment-529618702 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6062?src=pr=h1) Report > Merging

[jira] [Updated] (AIRFLOW-5448) Make Kubernetes Executor compatible with Istio service mesh

2019-09-09 Thread Steven Miller (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Miller updated AIRFLOW-5448: --- Description: Istio service mesh is not compatible by default with Kubernetes Jobs. The

[jira] [Comment Edited] (AIRFLOW-5418) bucket names with a slash in them cause an error with the GCS Download Operator

2019-09-09 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925956#comment-16925956 ] Kamil Bregula edited comment on AIRFLOW-5418 at 9/9/19 5:49 PM: Bucket

[GitHub] [airflow] tiopi commented on a change in pull request #5407: [AIRFLOW-4741] Include Sentry into core Airflow

2019-09-09 Thread GitBox
tiopi commented on a change in pull request #5407: [AIRFLOW-4741] Include Sentry into core Airflow URL: https://github.com/apache/airflow/pull/5407#discussion_r320078094 ## File path: airflow/sentry.py ## @@ -0,0 +1,196 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the

[GitHub] [airflow] kanetkarster commented on issue #5812: [AIRFLOW-4449] updated default permission for custom roles to 'Viewer'

2019-09-09 Thread GitBox
kanetkarster commented on issue #5812: [AIRFLOW-4449] updated default permission for custom roles to 'Viewer' URL: https://github.com/apache/airflow/pull/5812#issuecomment-529490475 Right now, all custom roles have, as a base, all the permissions given to User. Whenever

  1   2   >