[jira] [Commented] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942682#comment-16942682 ] ASF subversion and git services commented on AIRFLOW-5362: -- Commit

[jira] [Commented] (AIRFLOW-5583) Extend the "DAG Details" page to display the start_date / end_date

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942685#comment-16942685 ] ASF GitHub Bot commented on AIRFLOW-5583: - visciang commented on pull request #6235:

[GitHub] [airflow] visciang opened a new pull request #6235: [AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date

2019-10-02 Thread GitBox
visciang opened a new pull request #6235: [AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date URL: https://github.com/apache/airflow/pull/6235 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] [airflow] ashb commented on issue #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler…

2019-10-02 Thread GitBox
ashb commented on issue #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler… URL: https://github.com/apache/airflow/pull/6231#issuecomment-53766 (this got closed as the branch you were targeting shouldn't be in github, so I removed it.) Please reopen against

[GitHub] [airflow] ashb closed pull request #6219: Dags filter by owner in RBAC

2019-10-02 Thread GitBox
ashb closed pull request #6219: Dags filter by owner in RBAC URL: https://github.com/apache/airflow/pull/6219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] ashb closed pull request #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler…

2019-10-02 Thread GitBox
ashb closed pull request #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler… URL: https://github.com/apache/airflow/pull/6231 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (AIRFLOW-5581) KubernetesJobWatcher dies prematurely with num_runs or run_duration

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942698#comment-16942698 ] ASF GitHub Bot commented on AIRFLOW-5581: - ashb commented on pull request #6231: AIRFLOW-5581:

[GitHub] [airflow] ashb commented on issue #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler…

2019-10-02 Thread GitBox
ashb commented on issue #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler… URL: https://github.com/apache/airflow/pull/6231#issuecomment-537444137 Bug fixes need to be against the master branch please.

[GitHub] [airflow] mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330519372 ## File path: airflow/gcp/example_dags/example_search_ads.py ## @@ -0,0 +1,74 @@ +# -*- coding:

[GitHub] [airflow] msumit commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries

2019-10-02 Thread GitBox
msumit commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries URL: https://github.com/apache/airflow/pull/6233#issuecomment-537436892 I wrote the exact piece of code earlier, but 1 test won't pass due to python's nature of not re-calculating function defaults

[GitHub] [airflow] kpathak13 commented on issue #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler…

2019-10-02 Thread GitBox
kpathak13 commented on issue #6231: AIRFLOW-5581: Join KubernetesJobWatcher in AirflowKubernetesScheduler… URL: https://github.com/apache/airflow/pull/6231#issuecomment-537476497 Thanks @ashb. I have opened a new [PR](https://github.com/apache/airflow/pull/6237).

[jira] [Work started] (AIRFLOW-5583) Extend the "DAG Details" page to display the start_date / end_date

2019-10-02 Thread Giovanni (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-5583 started by Giovanni. - > Extend the "DAG Details" page to display the start_date / end_date >

[GitHub] [airflow] blcksrx commented on issue #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on issue #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#issuecomment-537450200 @XD-DENG I didn't get why it should failed on `flake8` and `pylint` This is an

[jira] [Commented] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942686#comment-16942686 ] ASF subversion and git services commented on AIRFLOW-5362: -- Commit

[jira] [Resolved] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-5362. --- Fix Version/s: 1.10.6 Resolution: Fixed > Imports are not ordered properly >

[jira] [Commented] (AIRFLOW-5584) Initialise hook in execute not in ctor in Cloud SQL operators

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942744#comment-16942744 ] ASF GitHub Bot commented on AIRFLOW-5584: - nuclearpinguin commented on pull request #6236:

[GitHub] [airflow] nuclearpinguin opened a new pull request #6236: [AIRFLOW-5584] Initialise hook in execute in Cloud SQL operators

2019-10-02 Thread GitBox
nuclearpinguin opened a new pull request #6236: [AIRFLOW-5584] Initialise hook in execute in Cloud SQL operators URL: https://github.com/apache/airflow/pull/6236 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-5584) Initialise hook in execute not in ctor in Cloud SQL operators

2019-10-02 Thread Tomasz Urbaszek (Jira)
Tomasz Urbaszek created AIRFLOW-5584: Summary: Initialise hook in execute not in ctor in Cloud SQL operators Key: AIRFLOW-5584 URL: https://issues.apache.org/jira/browse/AIRFLOW-5584 Project:

[GitHub] [airflow] mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330520367 ## File path: airflow/gcp/operators/search_ads.py ## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*-

[GitHub] [airflow] saianupkumarp opened a new pull request #6238: Updated readme with "Who's using" information

2019-10-02 Thread GitBox
saianupkumarp opened a new pull request #6238: Updated readme with "Who's using" information URL: https://github.com/apache/airflow/pull/6238 We are using Airflow at King Abdullah Petroleum Studies and Research Center(KAPSARC)(www.kapsarc.org)

[jira] [Commented] (AIRFLOW-5581) KubernetesJobWatcher dies prematurely with num_runs or run_duration

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942778#comment-16942778 ] ASF GitHub Bot commented on AIRFLOW-5581: - kpathak13 commented on pull request #6237:

[GitHub] [airflow] kpathak13 opened a new pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call

2019-10-02 Thread GitBox
kpathak13 opened a new pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call URL: https://github.com/apache/airflow/pull/6237 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-5342) Can't run initdb using Microsoft SQL server

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942702#comment-16942702 ] ASF subversion and git services commented on AIRFLOW-5342: -- Commit

[jira] [Commented] (AIRFLOW-4939) Ability to specify default retries for all tasks

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942707#comment-16942707 ] ASF subversion and git services commented on AIRFLOW-4939: -- Commit

[jira] [Commented] (AIRFLOW-5556) Should not use dagbag_import_timeout to time out DagFileProcessor

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942701#comment-16942701 ] ASF subversion and git services commented on AIRFLOW-5556: -- Commit

[GitHub] [airflow] codecov-io commented on issue #6235: [AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date

2019-10-02 Thread GitBox
codecov-io commented on issue #6235: [AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date URL: https://github.com/apache/airflow/pull/6235#issuecomment-537444989 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6235?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-5484) PigCliHook has incorrect named parameter

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942706#comment-16942706 ] ASF subversion and git services commented on AIRFLOW-5484: -- Commit

[GitHub] [airflow] ashb commented on issue #6183: [AIRFLOW-5553] Bytes value check done based on the type of the variable

2019-10-02 Thread GitBox
ashb commented on issue #6183: [AIRFLOW-5553] Bytes value check done based on the type of the variable URL: https://github.com/apache/airflow/pull/6183#issuecomment-537444933 @criccomini Very roughly Q1 next year is my goal.

[jira] [Commented] (AIRFLOW-5280) aws_default's region_name defaults to us-east-1 which causes major confusion for connections that do not use this region

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942705#comment-16942705 ] ASF subversion and git services commented on AIRFLOW-5280: -- Commit

[jira] [Commented] (AIRFLOW-3971) Google Cloud Natural Language Operators

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942704#comment-16942704 ] ASF subversion and git services commented on AIRFLOW-3971: -- Commit

[jira] [Commented] (AIRFLOW-5561) Very old version of httplib2 installed when using gcp extra

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942703#comment-16942703 ] ASF subversion and git services commented on AIRFLOW-5561: -- Commit

[GitHub] [airflow] potiuk edited a comment on issue #5944: [AIRFLOW-5362] Reorder imports

2019-10-02 Thread GitBox
potiuk edited a comment on issue #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944#issuecomment-537432579 Thanks @KevinYang21 -> I merged and cherry-picked (I rerun isort) to v1-10-test. This way it will be easier to cherry-pick changes.

[GitHub] [airflow] potiuk commented on issue #5944: [AIRFLOW-5362] Reorder imports

2019-10-02 Thread GitBox
potiuk commented on issue #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944#issuecomment-537432579 Thanks @KevinYang21 -> I merged and cherry-picked (I rerun isort) to v1-10-test. This is

[jira] [Assigned] (AIRFLOW-4676) Make airflow/macros Pylint compatible

2019-10-02 Thread Arkadiusz Bach (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arkadiusz Bach reassigned AIRFLOW-4676: --- Assignee: Arkadiusz Bach > Make airflow/macros Pylint compatible >

[jira] [Created] (AIRFLOW-5583) Extend the "DAG Details" page to display the start_date / end_date

2019-10-02 Thread Giovanni (Jira)
Giovanni created AIRFLOW-5583: - Summary: Extend the "DAG Details" page to display the start_date / end_date Key: AIRFLOW-5583 URL: https://issues.apache.org/jira/browse/AIRFLOW-5583 Project: Apache

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330458675 ## File path: airflow/utils/db.py ## @@ -300,6 +300,17 @@ def initdb(): Connection(

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330459165 ## File path: airflow/hooks/drill_hook.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8 -*- +# +# Licensed to

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330458195 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[jira] [Commented] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942576#comment-16942576 ] ASF subversion and git services commented on AIRFLOW-5362: -- Commit

[GitHub] [airflow] potiuk merged pull request #5944: [AIRFLOW-5362] Reorder imports

2019-10-02 Thread GitBox
potiuk merged pull request #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942575#comment-16942575 ] ASF GitHub Bot commented on AIRFLOW-5362: - potiuk commented on pull request #5944:

[GitHub] [airflow] XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330455370 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330456329 ## File path: airflow/hooks/drill_hook.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8 -*- +# +# Licensed to

[GitHub] [airflow] XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330456069 ## File path: airflow/utils/db.py ## @@ -300,6 +300,17 @@ def initdb(): Connection(

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330458195 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] blcksrx opened a new pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx opened a new pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-5529) Support Apache Drill hook

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942651#comment-16942651 ] ASF GitHub Bot commented on AIRFLOW-5529: - blcksrx commented on pull request #6234:

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330459165 ## File path: airflow/hooks/drill_hook.py ## @@ -0,0 +1,72 @@ +# -*- coding: utf-8 -*- +# +# Licensed to

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330561364 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] ashb commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
ashb commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330571326 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] OmerJog commented on issue #6183: [AIRFLOW-5553] Bytes value check done based on the type of the variable

2019-10-02 Thread GitBox
OmerJog commented on issue #6183: [AIRFLOW-5553] Bytes value check done based on the type of the variable URL: https://github.com/apache/airflow/pull/6183#issuecomment-537510286 The title & description of the PR doesn't indicate that it's on MySqlToGoogleCloudStorageOperator. It will be

[GitHub] [airflow] kaxil opened a new pull request #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries

2019-10-02 Thread GitBox
kaxil opened a new pull request #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries URL: https://github.com/apache/airflow/pull/6233 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-4939) Ability to specify default retries for all tasks

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942861#comment-16942861 ] ASF GitHub Bot commented on AIRFLOW-4939: - kaxil commented on pull request #6233:

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330584730 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] blcksrx closed pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx closed pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (AIRFLOW-5542) Export a BigQuery query result to GCS

2019-10-02 Thread Mefta Sadat (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mefta Sadat closed AIRFLOW-5542. Resolution: Won't Do > Export a BigQuery query result to GCS >

[jira] [Commented] (AIRFLOW-5585) Docker-context file check gives only marginal improvements for build

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942885#comment-16942885 ] ASF GitHub Bot commented on AIRFLOW-5585: - potiuk commented on pull request #6239:

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration URL: https://github.com/apache/airflow/pull/6169#discussion_r33060 ## File path: airflow/gcp/operators/campaign_manager.py ## @@ -0,0 +1,382 @@ +#

[jira] [Commented] (AIRFLOW-5477) Rewrite Google PubSub Hook to Google Cloud Python

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942898#comment-16942898 ] ASF subversion and git services commented on AIRFLOW-5477: -- Commit

[jira] [Commented] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942900#comment-16942900 ] ASF subversion and git services commented on AIRFLOW-5362: -- Commit

[jira] [Commented] (AIRFLOW-5543) Tooltip in tree view and graph view disappears after page scrolls up

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942899#comment-16942899 ] ASF subversion and git services commented on AIRFLOW-5543: -- Commit

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330610929 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330601956 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330605859 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330602949 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330600316 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330598251 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330612114 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330615499 ## File path: airflow/gcp/sensors/display_video.py ## @@ -0,0 +1,74 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330614332 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330596479 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330602439 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330624439 ## File path: airflow/gcp/operators/search_ads.py ## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*-

[GitHub] [airflow] efolgar commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330626901 ## File path: airflow/gcp/sensors/search_ads.py ## @@ -0,0 +1,76 @@ +# -*- coding: utf-8 -*- +#

[GitHub] [airflow] efolgar commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330628123 ## File path: airflow/gcp/operators/search_ads.py ## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*-

[GitHub] [airflow] kimpers opened a new pull request #6241: [AIRFLOW-3014] Increase connection password length to match model

2019-10-02 Thread GitBox
kimpers opened a new pull request #6241: [AIRFLOW-3014] Increase connection password length to match model URL: https://github.com/apache/airflow/pull/6241 Make sure you have checked _all_ steps below. ### Jira - [X] My PR addresses the following [Airflow

[GitHub] [airflow] blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
blcksrx commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330561364 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] potiuk commented on issue #5944: [AIRFLOW-5362] Reorder imports

2019-10-02 Thread GitBox
potiuk commented on issue #5944: [AIRFLOW-5362] Reorder imports URL: https://github.com/apache/airflow/pull/5944#issuecomment-537513843 Turned out that sorting v1-10-test causes some circular imports which are rather difficult to fix without splitting some of the files as it was done in

[GitHub] [airflow] kaxil commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries

2019-10-02 Thread GitBox
kaxil commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries URL: https://github.com/apache/airflow/pull/6233#issuecomment-537521756  Yeah (not sure what I was thinking) - Fixed the test. This is an

[GitHub] [airflow] potiuk opened a new pull request #6239: [AIRFLOW-5585] Remove docker context from build

2019-10-02 Thread GitBox
potiuk opened a new pull request #6239: [AIRFLOW-5585] Remove docker context from build URL: https://github.com/apache/airflow/pull/6239 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] ryw opened a new pull request #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md

2019-10-02 Thread GitBox
ryw opened a new pull request #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md URL: https://github.com/apache/airflow/pull/6240 Make it clear that 1.10.5 was a minor release, and that there are no breaking changes in the release.

[GitHub] [airflow] kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call

2019-10-02 Thread GitBox
kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call URL: https://github.com/apache/airflow/pull/6237#discussion_r330625024 ## File path: airflow/executors/kubernetes_executor.py ## @@ -576,6 +576,7 @@ def

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
nuclearpinguin commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330636145 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301

[GitHub] [airflow] meftasadat closed pull request #6173: [AIRFLOW-5542] Added BQ query results export to GCS operator

2019-10-02 Thread GitBox
meftasadat closed pull request #6173: [AIRFLOW-5542] Added BQ query results export to GCS operator URL: https://github.com/apache/airflow/pull/6173 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
ashb commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330557551 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] kaxil commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries

2019-10-02 Thread GitBox
kaxil commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries URL: https://github.com/apache/airflow/pull/6233#issuecomment-537503173 huh, you are right, @msumit - Thanks, will close this PR. We are using this type of code in many places AFAIK, we should change

[GitHub] [airflow] ashb commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries

2019-10-02 Thread GitBox
ashb commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries URL: https://github.com/apache/airflow/pull/6233#issuecomment-537511280 Except an integer isn't mutable -- that caveat only applies to dicts and lists I thought?

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration URL: https://github.com/apache/airflow/pull/6169#discussion_r330591585 ## File path: airflow/gcp/operators/campaign_manager.py ## @@ -0,0 +1,347 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration URL: https://github.com/apache/airflow/pull/6169#discussion_r330556780 ## File path: airflow/gcp/operators/campaign_manager.py ## @@ -0,0 +1,347 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration URL: https://github.com/apache/airflow/pull/6169#discussion_r330572974 ## File path: airflow/gcp/operators/campaign_manager.py ## @@ -0,0 +1,347 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration URL: https://github.com/apache/airflow/pull/6169#discussion_r330553865 ## File path: airflow/gcp/operators/campaign_manager.py ## @@ -0,0 +1,382 @@ +#

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration URL: https://github.com/apache/airflow/pull/6169#discussion_r330553139 ## File path: airflow/gcp/operators/campaign_manager.py ## @@ -0,0 +1,382 @@ +#

[GitHub] [airflow] puhrez commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables

2019-10-02 Thread GitBox
puhrez commented on issue #4991: [AIRFLOW-4170] Serialize non-str value by JSON when importing Variables URL: https://github.com/apache/airflow/pull/4991#issuecomment-537558929 haha, I had done that on the GitHub releases page. Thank you!

[jira] [Commented] (AIRFLOW-3014) Password column on connection table should be longer

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942937#comment-16942937 ] ASF GitHub Bot commented on AIRFLOW-3014: - kimpers commented on pull request #6241:

[GitHub] [airflow] mik-laj removed a comment on issue #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj removed a comment on issue #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#issuecomment-537493694 Can you add this service to `integration.rst` file? This is

[GitHub] [airflow] mik-laj edited a comment on issue #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj edited a comment on issue #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#issuecomment-537493694 Can you add this service to `integration.rst` file? This is

[GitHub] [airflow] mik-laj commented on issue #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj commented on issue #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#issuecomment-537493694 Can you ad this service to `integration.rst` file? This is an

[jira] [Commented] (AIRFLOW-5542) Export a BigQuery query result to GCS

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942823#comment-16942823 ] ASF GitHub Bot commented on AIRFLOW-5542: - meftasadat commented on pull request #6173:

[GitHub] [airflow] ashb commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call

2019-10-02 Thread GitBox
ashb commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call URL: https://github.com/apache/airflow/pull/6237#discussion_r330564678 ## File path: airflow/executors/kubernetes_executor.py ## @@ -576,6 +576,7 @@ def

[jira] [Commented] (AIRFLOW-4939) Ability to specify default retries for all tasks

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942837#comment-16942837 ] ASF GitHub Bot commented on AIRFLOW-4939: - kaxil commented on pull request #6233:

  1   2   >