[jira] [Commented] (AIRFLOW-5783) Migrate AWS Redshift to /providers/aws [AIP-21]

2019-11-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976350#comment-16976350 ] ASF subversion and git services commented on AIRFLOW-5783: -- Commit

[GitHub] [airflow] potiuk commented on issue #6539: [AIRFLOW-5783] AIP-21 Move aws redshift into providers structure

2019-11-18 Thread GitBox
potiuk commented on issue #6539: [AIRFLOW-5783] AIP-21 Move aws redshift into providers structure URL: https://github.com/apache/airflow/pull/6539#issuecomment-554903489 Thanks @ratb3rt ! This is an automated message from

[GitHub] [airflow] potiuk merged pull request #6539: [AIRFLOW-5783] AIP-21 Move aws redshift into providers structure

2019-11-18 Thread GitBox
potiuk merged pull request #6539: [AIRFLOW-5783] AIP-21 Move aws redshift into providers structure URL: https://github.com/apache/airflow/pull/6539 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-5783) Migrate AWS Redshift to /providers/aws [AIP-21]

2019-11-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976347#comment-16976347 ] ASF GitHub Bot commented on AIRFLOW-5783: - potiuk commented on pull request #6539:

[GitHub] [airflow] codecov-io edited a comment on issue #6539: [AIRFLOW-5783] AIP-21 Move aws redshift into providers structure

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #6539: [AIRFLOW-5783] AIP-21 Move aws redshift into providers structure URL: https://github.com/apache/airflow/pull/6539#issuecomment-553662295 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6539?src=pr=h1) Report > :exclamation: No coverage

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347265949 ## File path: docs/lineage.rst ## @@ -50,40 +51,43 @@ works. f_final =

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347266115 ## File path: airflow/lineage/entity/dataset.py ## @@ -0,0 +1,25 @@ +# -*- coding:

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347266506 ## File path: airflow/models/baseoperator.py ## @@ -412,25 +412,12 @@ def __init__(

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347270280 ## File path: airflow/jobs/scheduler_job.py ## @@ -717,7 +718,10 @@ def

[GitHub] [airflow] ashb commented on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage

2019-11-18 Thread GitBox
ashb commented on issue #5079: [AIRFLOW-4285] Update task dependency context defination and usage URL: https://github.com/apache/airflow/pull/5079#issuecomment-554937383 @KevinYang21 ping This is an automated message from

[GitHub] [airflow] ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347294288 ## File path: tests/cli/commands/test_variable_command.py ## @@ -0,0 +1,132 @@ +# -*-

[GitHub] [airflow] ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347290868 ## File path: airflow/__init__.py ## @@ -37,7 +37,8 @@ from airflow.configuration

[GitHub] [airflow] mik-laj commented on issue #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
mik-laj commented on issue #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#issuecomment-554948221 @ashb yes. Fixed. This is an automated message from the

[GitHub] [airflow] ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347295415 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -34,6 +35,31 @@ class

[GitHub] [airflow] ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347292209 ## File path: airflow/bin/cli.py ## @@ -20,1703 +20,38 @@ """Command-line interface"""

[GitHub] [airflow] ashb commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
ashb commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#issuecomment-554953029 Oh, I think I see the issue with both of my comments: Because `airflow/__init__.py`

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347266789 ## File path: airflow/models/baseoperator.py ## @@ -316,8 +316,8 @@ def __init__(

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347282260 ## File path: airflow/executors/__init__.py ## @@ -57,31 +56,25 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347286274 ## File path: airflow/executors/dask_executor.py ## @@ -44,6 +42,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347286614 ## File path: airflow/dag_context_manager/__init__.py ## @@ -0,0 +1,23 @@ +# Licensed

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347285095 ## File path: tests/dags/test_subdag.py ## @@ -24,7 +24,7 @@ from datetime import

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347283883 ## File path: airflow/dag_context_manager/__init__.py ## @@ -0,0 +1,23 @@ +# Licensed

[GitHub] [airflow] potiuk commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#discussion_r347301975 ## File path: airflow/__init__.py ## @@ -29,15 +29,20 @@ #

[GitHub] [airflow] potiuk commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
potiuk commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#issuecomment-554916834 I think I nicely solved the problem of old imports. I figured out a nice way how to throw a

[jira] [Resolved] (AIRFLOW-5345) Extract SqlSensor's get_hook functionality to an auxiliary function

2019-11-18 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5345. Fix Version/s: 1.10.7 Resolution: Fixed > Extract SqlSensor's get_hook

[GitHub] [airflow] ashb commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#discussion_r347287849 ## File path: airflow/deprecations/airflow_exception_deprecated.py ##

[GitHub] [airflow] ashb commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#discussion_r347288225 ## File path: airflow/__init__.py ## @@ -29,15 +29,20 @@ #

[GitHub] [airflow] ashb commented on issue #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
ashb commented on issue #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#issuecomment-554944394 @mik-laj Did you reverse before and after in your PR description?

[GitHub] [airflow] mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347296205 ## File path: airflow/bin/cli.py ## @@ -20,1703 +20,38 @@ """Command-line

[GitHub] [airflow] ashb edited a comment on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
ashb edited a comment on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#issuecomment-554953029 Oh, I think I see the issue with both of my comments: Because `airflow/__init__.py`

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347265086 ## File path: airflow/lineage/__init__.py ## @@ -92,51 +115,43 @@ def

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347265570 ## File path: tests/lineage/test_lineage.py ## @@ -85,26 +85,26 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#discussion_r347299694 ## File path: airflow/deprecations/airflow_exception_deprecated.py

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347265086 ## File path: airflow/lineage/__init__.py ## @@ -92,51 +115,43 @@ def

[GitHub] [airflow] potiuk commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
potiuk commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#issuecomment-554938969 I think I found a nice (though a but hackish :) ) way of making the docs build @mik-laj and others.

[GitHub] [airflow] ashb edited a comment on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
ashb edited a comment on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#issuecomment-554953029 Oh, I think I see the issue with both of my comments: Because `airflow/__init__.py`

[jira] [Created] (AIRFLOW-6008) AWS Cloudformation Operator

2019-11-18 Thread James Wanderi (Jira)
James Wanderi created AIRFLOW-6008: -- Summary: AWS Cloudformation Operator Key: AIRFLOW-6008 URL: https://issues.apache.org/jira/browse/AIRFLOW-6008 Project: Apache Airflow Issue Type: New

[GitHub] [airflow-site] kgabryje opened a new pull request #176: Fix form input minimal width

2019-11-18 Thread GitBox
kgabryje opened a new pull request #176: Fix form input minimal width URL: https://github.com/apache/airflow-site/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow-site] kgabryje opened a new pull request #178: enable css autoprefixer

2019-11-18 Thread GitBox
kgabryje opened a new pull request #178: enable css autoprefixer URL: https://github.com/apache/airflow-site/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913#issuecomment-546476497 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5913?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913#issuecomment-546476497 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5913?src=pr=h1) Report > Merging

[GitHub] [airflow-site] ashb commented on issue #179: replace favicons with transparent versions

2019-11-18 Thread GitBox
ashb commented on issue #179: replace favicons with transparent versions URL: https://github.com/apache/airflow-site/pull/179#issuecomment-555004430 landing-pages/site/static/favicons/ms-icon-310x310.png looks blury FYI This

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347384080 ## File path: airflow/executors/__init__.py ## @@ -57,31 +56,25 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
ashb commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913#discussion_r347335462 ## File path: UPDATING.md ## @@ -41,6 +41,13 @@ assists users migrating to a new

[GitHub] [airflow-site] kgabryje opened a new pull request #177: make scrollbar in docs sidenav always visible

2019-11-18 Thread GitBox
kgabryje opened a new pull request #177: make scrollbar in docs sidenav always visible URL: https://github.com/apache/airflow-site/pull/177 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow-site] kgabryje opened a new pull request #179: replace favicons with transparent versions

2019-11-18 Thread GitBox
kgabryje opened a new pull request #179: replace favicons with transparent versions URL: https://github.com/apache/airflow-site/pull/179 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
bolkedebruin commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347266789 ## File path: airflow/models/baseoperator.py ## @@ -316,8 +316,8 @@ def __init__(

[GitHub] [airflow] mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347380516 ## File path: airflow/__init__.py ## @@ -37,7 +37,8 @@ from airflow.configuration

[GitHub] [airflow] codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913#issuecomment-546476497 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5913?src=pr=h1) Report > Merging

[GitHub] [airflow-site] kgabryje opened a new pull request #181: change Case studies to Use cases in navbar

2019-11-18 Thread GitBox
kgabryje opened a new pull request #181: change Case studies to Use cases in navbar URL: https://github.com/apache/airflow-site/pull/181 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347354000 ## File path: tests/cli/commands/test_variable_command.py ## @@ -0,0 +1,132 @@ +# -*-

[jira] [Created] (AIRFLOW-6009) Only kubernetes tests need travis_wait

2019-11-18 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-6009: - Summary: Only kubernetes tests need travis_wait Key: AIRFLOW-6009 URL: https://issues.apache.org/jira/browse/AIRFLOW-6009 Project: Apache Airflow Issue

[GitHub] [airflow-site] kgabryje commented on issue #179: replace favicons with transparent versions

2019-11-18 Thread GitBox
kgabryje commented on issue #179: replace favicons with transparent versions URL: https://github.com/apache/airflow-site/pull/179#issuecomment-555014548 > landing-pages/site/static/favicons/ms-icon-310x310.png looks blury FYI Updated, thanks for pointing that out!

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347385003 ## File path: airflow/executors/dask_executor.py ## @@ -44,6 +42,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347391606 ## File path: tests/dags/test_subdag.py ## @@ -24,7 +24,7 @@ from datetime import

[GitHub] [airflow] potiuk commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004]

2019-11-18 Thread GitBox
potiuk commented on issue #6597: [AIRFLOW-6005] Remove airflow airflow exception imports. Depends on [AIRFLOW-6004] URL: https://github.com/apache/airflow/pull/6597#issuecomment-554994571 @ashb - I will try those approaches. First I have to fix the #6596 which is the base for that one and

[GitHub] [airflow] mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#discussion_r347354180 ## File path: airflow/__init__.py ## @@ -37,7 +37,8 @@ from airflow.configuration

[GitHub] [airflow] ashb commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6564: [AIRFLOW-5911] Simplify lineage API and improve robustness URL: https://github.com/apache/airflow/pull/6564#discussion_r347363988 ## File path: airflow/models/baseoperator.py ## @@ -316,8 +316,8 @@ def __init__(

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347378096 ## File path: airflow/executors/dask_executor.py ## @@ -44,6 +42,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347382576 ## File path: airflow/dag_context_manager/__init__.py ## @@ -0,0 +1,23 @@ +# Licensed

[GitHub] [airflow] codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913#issuecomment-546476497 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5913?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913#issuecomment-546476497 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5913?src=pr=h1) Report > Merging

[GitHub] [airflow-site] kgabryje opened a new pull request #180: corrected meta titles and twitter image

2019-11-18 Thread GitBox
kgabryje opened a new pull request #180: corrected meta titles and twitter image URL: https://github.com/apache/airflow-site/pull/180 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347428185 ## File path: UPDATING.md ## @@ -41,6 +41,14 @@ assists users migrating to a

[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347428247 ## File path: UPDATING.md ## @@ -41,6 +41,14 @@ assists users migrating to a

[GitHub] [airflow-site] kgabryje opened a new pull request #183: Content/commiters fix

2019-11-18 Thread GitBox
kgabryje opened a new pull request #183: Content/commiters fix URL: https://github.com/apache/airflow-site/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] codecov-io edited a comment on issue #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands

2019-11-18 Thread GitBox
codecov-io edited a comment on issue #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands URL: https://github.com/apache/airflow/pull/6594#issuecomment-554772240 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6594?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete URL: https://github.com/apache/airflow/pull/6593#discussion_r347418648 ## File path: tests/cli/test_cli.py ## @@ -1329,6

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347422690 ## File path: airflow/executors/dask_executor.py ## @@ -44,6 +42,7 @@ def

[jira] [Created] (AIRFLOW-6010) The "from airflow import settings" is used far too often

2019-11-18 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-6010: - Summary: The "from airflow import settings" is used far too often Key: AIRFLOW-6010 URL: https://issues.apache.org/jira/browse/AIRFLOW-6010 Project: Apache Airflow

[GitHub] [airflow-site] kgabryje opened a new pull request #182: replace placeholder videos with apache airflow videos

2019-11-18 Thread GitBox
kgabryje opened a new pull request #182: replace placeholder videos with apache airflow videos URL: https://github.com/apache/airflow-site/pull/182 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347419320 ## File path: UPDATING.md ## @@ -41,6 +41,14 @@ assists users migrating to a new

[GitHub] [airflow] ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347419426 ## File path: UPDATING.md ## @@ -41,6 +41,14 @@ assists users migrating to a new

[GitHub] [airflow] acroos commented on issue #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
acroos commented on issue #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#issuecomment-555046572 oh no... that was not a successful rebase This is

[jira] [Created] (AIRFLOW-6011) Airflow treats local dependencies as DAG files if they contain the string "DAG"

2019-11-18 Thread Aaron Liblong (Jira)
Aaron Liblong created AIRFLOW-6011: -- Summary: Airflow treats local dependencies as DAG files if they contain the string "DAG" Key: AIRFLOW-6011 URL: https://issues.apache.org/jira/browse/AIRFLOW-6011

[GitHub] [airflow] mik-laj commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete URL: https://github.com/apache/airflow/pull/6593#discussion_r347458251 ## File path: tests/cli/test_cli.py ## @@ -1329,6

[GitHub] [airflow] mik-laj commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r347460576 ## File path: docs/best-practices.rst ## @@ -0,0 +1,271 @@ + .. Licensed to the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r347462189 ## File path: docs/best-practices.rst ## @@ -0,0 +1,271 @@ + .. Licensed to the Apache

[GitHub] [airflow] ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags URL: https://github.com/apache/airflow/pull/6489#discussion_r347464559 ## File path: airflow/models/dag.py ## @@ -1384,7 +1390,8 @@ def sync_to_db(self, owner=None,

[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result

2019-11-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976661#comment-16976661 ] ASF subversion and git services commented on AIRFLOW-5073: -- Commit

[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result

2019-11-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976657#comment-16976657 ] ASF GitHub Bot commented on AIRFLOW-5073: - ashb commented on pull request #5913: [AIRFLOW-5073]

[GitHub] [airflow] zacharya19 commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2019-11-18 Thread GitBox
zacharya19 commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags URL: https://github.com/apache/airflow/pull/6489#discussion_r347478431 ## File path: airflow/models/dag.py ## @@ -1384,7 +1390,8 @@ def sync_to_db(self,

[GitHub] [airflow] mattbowden-ookla commented on issue #6598: [AIRFLOW-6006] Remove dag out of airflow package import. Depends on [AIRFLOW-6004] [AIRFLOW-6005]

2019-11-18 Thread GitBox
mattbowden-ookla commented on issue #6598: [AIRFLOW-6006] Remove dag out of airflow package import. Depends on [AIRFLOW-6004] [AIRFLOW-6005] URL: https://github.com/apache/airflow/pull/6598#issuecomment-555093735 This seems like it's changing module locations - should a note be added to

[GitHub] [airflow] potiuk commented on issue #6598: [AIRFLOW-6006] Remove dag out of airflow package import. Depends on [AIRFLOW-6004] [AIRFLOW-6005]

2019-11-18 Thread GitBox
potiuk commented on issue #6598: [AIRFLOW-6006] Remove dag out of airflow package import. Depends on [AIRFLOW-6004] [AIRFLOW-6005] URL: https://github.com/apache/airflow/pull/6598#issuecomment-555095645 @mattbowden-ookla -> yep. I plan to update the UPDATING.md once we get to agreement if

[GitHub] [airflow] potiuk edited a comment on issue #6598: [AIRFLOW-6006] Remove dag out of airflow package import. Depends on [AIRFLOW-6004] [AIRFLOW-6005]

2019-11-18 Thread GitBox
potiuk edited a comment on issue #6598: [AIRFLOW-6006] Remove dag out of airflow package import. Depends on [AIRFLOW-6004] [AIRFLOW-6005] URL: https://github.com/apache/airflow/pull/6598#issuecomment-555095645 @mattbowden-ookla -> yep. I plan to update the UPDATING.md once we get to

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347483571 ## File path: airflow/executors/dask_executor.py ## @@ -44,6 +42,7 @@ def

[GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347483917 ## File path: airflow/executors/dask_executor.py ## @@ -44,6 +42,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r347486502 ## File path: tests/dags/test_subdag.py ## @@ -24,7 +24,7 @@ from datetime import

[GitHub] [airflow] ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags URL: https://github.com/apache/airflow/pull/6489#discussion_r347491899 ## File path: airflow/www/app.py ## @@ -65,6 +66,7 @@ def create_app(config=None, session=None,

[GitHub] [airflow] mik-laj commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6515: [AIRFLOW-XXX] GSoD: How to make DAGs production ready URL: https://github.com/apache/airflow/pull/6515#discussion_r347463773 ## File path: docs/best-practices.rst ## @@ -0,0 +1,271 @@ + .. Licensed to the Apache

[GitHub] [airflow] ashb merged pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

2019-11-18 Thread GitBox
ashb merged pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0' URL: https://github.com/apache/airflow/pull/5913 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete

2019-11-18 Thread GitBox
mik-laj commented on a change in pull request #6593: [AIRFLOW-6000] Fix the test randomly fail - TestCliConnections.test_cli_connections_add_delete URL: https://github.com/apache/airflow/pull/6593#discussion_r347471610 ## File path: tests/cli/test_cli.py ## @@ -1329,6

[jira] [Commented] (AIRFLOW-5144) Add confirmation dialog when deleting variable

2019-11-18 Thread Harshvardhan Chauhan (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976673#comment-16976673 ] Harshvardhan Chauhan commented on AIRFLOW-5144: --- Looks like this  

[GitHub] [airflow] ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347482612 ## File path: UPDATING.md ## @@ -93,6 +93,28 @@ delete this option. The

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347492605 ## File path: airflow/ti_deps/dep_context.py ## @@ -67,6 +67,8 @@ class DepContext:

[GitHub] [airflow] ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags URL: https://github.com/apache/airflow/pull/6489#discussion_r347492662 ## File path: airflow/www/utils.py ## @@ -471,9 +471,12 @@ def clean_column_names(): def

[GitHub] [airflow] ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags

2019-11-18 Thread GitBox
ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags URL: https://github.com/apache/airflow/pull/6489#discussion_r347492287 ## File path: airflow/www/templates/airflow/dags.html ## @@ -81,9 +92,17 @@ DAGs

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347493137 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +75,33 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347492605 ## File path: airflow/ti_deps/dep_context.py ## @@ -67,6 +67,8 @@ class DepContext:

[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request

2019-11-18 Thread GitBox
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST request URL: https://github.com/apache/airflow/pull/6380#discussion_r347497640 ## File path: UPDATING.md ## @@ -93,6 +93,28 @@ delete this option. The

  1   2   >