potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-593282253
Hello @vsoch - I spoke to co-organizer of Airflow Summit - @leahecole - and
I think we can figure out something with regards
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-590053213
I see, pity, let's see. It's the first-time event so we do not know what to
expect and for now do not foresee
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-590051343
BTW. @vsoch I am going to give a talk together with @aijamalnk on Diversity
and building even more welcoming community at
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-590050910
Indeed Awesome work . Likewise :). Thanks for cooperation on
that one !
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-590033385
one transient error - but I restarted it. Looks good !
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-590033396
:crossed_fingers:
This is an automated message from the
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-590026699
It could be a transient error or some temporary problem with master (despite
of the protections we have in place it breaks
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-589639710
> looks like the error linked above was one off - a later build didn't
trigger it.
Yeah. We still have some flaky
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-588461323
> One quick note about the docs for pylint - the files are now changed to
have pylint_main.sh and pylint_tests.sh. Also,
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-588435931
> How would you like me to address this?
>
> ```
>
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-587354436
Hey @vsoch a bit unrelated, but wanted you to know that we have just merged
this update to CONTRIBUTING documentation to
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-586675640
I think we do not have it explained very well - and I am not 100% sure
myself. But @mik-laj can help with that.
One
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-586641854
Sorry - devl...@airflow.apache.org - see CONTRIB.rst. I was typing it on my
tablet and autocomplete kicked in.
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-586640329
> Conflict resolved - it was the same line as before, another package was
added! I added a new line (it was getting too
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-586633715
and you need t rebase as well ontop of latest master & you have conflict
with setup.py
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-586633655
> Questions:
>
> * where does example_singularity_operator.py go - it used to be under
contrib/example_dags but now,
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-586169342
> High level feedback since this was a topic earlier:
>
> * the extra linting for the Dockerfile, which comes down to
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-585964299
> 1. installing Singularity as a binary inside a container (these bases
already exist)
> 2. running the container via
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-585943248
> okay just to clarify - you want a Singularity + Airflow container run via
a similar kind cluster? You said something about
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-585941481
> okay so I'm tracing the kubernetes (runtime) as an example, and I have a
quick question. In
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-585939693
Somehow I missed it completely. Sorry. Responding now.
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-579443300
> Could you give me some pointers about where to write the Dockerfile, what
example from the current codebase (link) is what
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-579315631
Thanks @vsoch ! Really sorry for not getting back before - I've been
travelling and missed that last comment.
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-576861320
That's OK!
This is an automated message from the Apache Git
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-576477396
> But one quick note - regardless of the testing troubles, the support on
this PR has been absolutely excellent, night and
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-576475634
> If it makes you feel better, just chock it up to me being an idiot and I
promise I’ll never bother this community again.
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-576470784
> The linting appears to be all set, but since Singularity is installed, the
tests are obviously going to fail. Let me know
potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add
singularity to airflow
URL: https://github.com/apache/airflow/pull/7191#issuecomment-576467652
> Also, could you give feedback on:
>
> > Title Validator — Wrong commit title: adding singularity operator and
tests
28 matches
Mail list logo
