[GitHub] tedmiston commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env

2018-08-08 Thread GitBox
tedmiston commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703#discussion_r208734436 ## File path: setup.py ## @@ -161,6 +164,7 @@ def write_version(filename=os.path.join(*['airflow',

[GitHub] codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-408263467 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-408263467 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

2018-08-08 Thread GitBox
codecov-io commented on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#issuecomment-411556404 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3722?src=pr=h1) Report >

[GitHub] codecov-io commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2018-08-08 Thread GitBox
codecov-io commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/incubator-airflow/pull/3723#issuecomment-411565604 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3723?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-408263467 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3648?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#issuecomment-411556404 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3722?src=pr=h1) Report

[GitHub] r39132 commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2018-08-08 Thread GitBox
r39132 commented on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/incubator-airflow/pull/3723#issuecomment-411582062 @Fokko I ran setup.py install on a branch based on this PR and I am getting exceptions when starting the scheduler: ```

[GitHub] Noremac201 commented on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-08 Thread GitBox
Noremac201 commented on issue #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#issuecomment-411556954 The tests are passing now, however instead of checking the POST response webpage, it checks the variables in

[jira] [Commented] (AIRFLOW-2876) Bump version of Tenacity

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573904#comment-16573904 ] ASF GitHub Bot commented on AIRFLOW-2876: - Fokko opened a new pull request #3723:

[GitHub] Fokko opened a new pull request #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2018-08-08 Thread GitBox
Fokko opened a new pull request #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/incubator-airflow/pull/3723 Tenacity 4.8 is not python 3.7 compatible because it contains reserved keywords in the code: ``` [2018-08-08 21:21:22,016] {models.py:366} ERROR -

[jira] [Commented] (AIRFLOW-2759) Simplify proxy server based access to external platforms like Google cloud

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573840#comment-16573840 ] ASF GitHub Bot commented on AIRFLOW-2759: - amohan34 opened a new pull request #3722:

[GitHub] amohan34 opened a new pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

2018-08-08 Thread GitBox
amohan34 opened a new pull request #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722 …level Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following

[GitHub] r39132 edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12

2018-08-08 Thread GitBox
r39132 edited a comment on issue #3723: [AIRFLOW-2876] Update Tenacity to 4.12 URL: https://github.com/apache/incubator-airflow/pull/3723#issuecomment-411582062 @Fokko I ran setup.py install on a branch based on this PR and I am getting exceptions when starting the scheduler.

[jira] [Created] (AIRFLOW-2876) Bump version of Tenacity

2018-08-08 Thread Fokko Driesprong (JIRA)
Fokko Driesprong created AIRFLOW-2876: - Summary: Bump version of Tenacity Key: AIRFLOW-2876 URL: https://issues.apache.org/jira/browse/AIRFLOW-2876 Project: Apache Airflow Issue Type:

[GitHub] codecov-io edited a comment on issue #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#issuecomment-408564225 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3658?src=pr=h1) Report > Merging

[jira] [Updated] (AIRFLOW-2872) Implement "Ad Hoc Query" in /www_rbac, and refine existing QueryView()

2018-08-08 Thread Xiaodong DENG (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaodong DENG updated AIRFLOW-2872: --- Description: To implement "Ad Hoc Query" in for RBAC in /www_rbac, based on the existing

[jira] [Resolved] (AIRFLOW-2861) Need index on log table

2018-08-08 Thread Vardan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vardan Gupta resolved AIRFLOW-2861. --- Resolution: Fixed Fix Version/s: 2.0.0 Change has been merged to Master. > Need

[GitHub] lxneng closed pull request #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone

2018-08-08 Thread GitBox
lxneng closed pull request #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone URL: https://github.com/apache/incubator-airflow/pull/3554 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] XD-DENG commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

2018-08-08 Thread GitBox
XD-DENG commented on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411634875 Hi @bolkedebruin , as suggested, I have implemented the **Ad Hoc Query** view for RBAC under

[GitHub] codecov-io edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook …

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3722: [AIRFLOW-2759] Add changes to extract proxy details at the base hook … URL: https://github.com/apache/incubator-airflow/pull/3722#issuecomment-411556404 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3722?src=pr=h1) Report

[GitHub] codecov-io edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView()

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3718: [AIRFLOW-2872] Implement 'Ad Hoc Query' for RBAC and Refine QueryView() URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411331261 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3718?src=pr=h1) Report

[jira] [Commented] (AIRFLOW-2686) Default Variables not base on default_timezone

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574189#comment-16574189 ] ASF GitHub Bot commented on AIRFLOW-2686: - lxneng closed pull request #3554: [AIRFLOW-2686] Fix

[GitHub] lxneng commented on issue #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone

2018-08-08 Thread GitBox
lxneng commented on issue #3554: [AIRFLOW-2686] Fix Default Variables not base on default_timezone URL: https://github.com/apache/incubator-airflow/pull/3554#issuecomment-411614674 Agree with @Fokko , That would be mush better.

[GitHub] feng-tao commented on a change in pull request #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing

2018-08-08 Thread GitBox
feng-tao commented on a change in pull request #3648: [AIRFLOW-2786] Fix editing Variable with empty key crashing URL: https://github.com/apache/incubator-airflow/pull/3648#discussion_r208799225 ## File path: tests/www_rbac/test_views.py ## @@ -172,6 +172,26 @@ def

[jira] [Closed] (AIRFLOW-2686) Default Variables not base on default_timezone

2018-08-08 Thread Eric Luo (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Luo closed AIRFLOW-2686. - Resolution: Fixed > Default Variables not base on default_timezone >

[GitHub] codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708#issuecomment-410963628 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3708?src=pr=h1) Report > Merging

[GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208483513 ## File path: airflow/contrib/operators/oracle_to_azure_data_lake_transfer.py

[GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208478718 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208483352 ## File path: airflow/contrib/operators/mongo_to_s3.py ## @@ -105,7

[GitHub] Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#discussion_r208486017 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -0,0 +1,239 @@ +# -*- coding: utf-8

[jira] [Commented] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572828#comment-16572828 ] Ash Berlin-Taylor commented on AIRFLOW-2871: One other thing that would be nice to do is to

[GitHub] Fokko commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703#discussion_r208478397 ## File path: setup.py ## @@ -161,6 +164,7 @@ def write_version(filename=os.path.join(*['airflow',

[GitHub] kaxil commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env

2018-08-08 Thread GitBox
kaxil commented on a change in pull request #3703: [AIRFLOW-2857] Fix broken RTD env URL: https://github.com/apache/incubator-airflow/pull/3703#discussion_r208502954 ## File path: setup.py ## @@ -161,6 +164,7 @@ def write_version(filename=os.path.join(*['airflow',

[jira] [Commented] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572901#comment-16572901 ] Ash Berlin-Taylor commented on AIRFLOW-2871: Oh - I so we do. I guess what I'd like then

[jira] [Updated] (AIRFLOW-2873) Improvements to Quick Start flow

2018-08-08 Thread G. Geijteman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] G. Geijteman updated AIRFLOW-2873: -- Description: Thank you for developing Airflow! Having ran through the Quick Start, i've

[jira] [Updated] (AIRFLOW-2873) Improvements to Quick Start flow

2018-08-08 Thread G. Geijteman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] G. Geijteman updated AIRFLOW-2873: -- Description: Thank you for developing Airflow! Having ran through the [Quick

[jira] [Commented] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572916#comment-16572916 ] Kaxil Naik commented on AIRFLOW-2871: - [~ashb] I will sort that out with a new PR and ping you once

[jira] [Commented] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572921#comment-16572921 ] Kaxil Naik commented on AIRFLOW-2871: - [~tedmiston] Few pointers: - We are using VirtualEnv setup

[GitHub] xnuinside commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
xnuinside commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208514928 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
ashb commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208515928 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208519487 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208519487 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] xnuinside commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
xnuinside commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208520636 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[jira] [Updated] (AIRFLOW-2874) Enable Flask App Builder theme support

2018-08-08 Thread Verdan Mahmood (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Verdan Mahmood updated AIRFLOW-2874: Description: To customize the look and feel of Apache Airflow (an effort towards making

[jira] [Created] (AIRFLOW-2874) Enable Flask App Builder theme support

2018-08-08 Thread Verdan Mahmood (JIRA)
Verdan Mahmood created AIRFLOW-2874: --- Summary: Enable Flask App Builder theme support Key: AIRFLOW-2874 URL: https://issues.apache.org/jira/browse/AIRFLOW-2874 Project: Apache Airflow

[jira] [Commented] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572898#comment-16572898 ] Kaxil Naik commented on AIRFLOW-2871: - We have also listed this at our confluence page at

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread Bolke de Bruin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572906#comment-16572906 ] Bolke de Bruin commented on AIRFLOW-2870: - or use with_entities, trying that > Migrations fail

[jira] [Comment Edited] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread Bolke de Bruin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572906#comment-16572906 ] Bolke de Bruin edited comment on AIRFLOW-2870 at 8/8/18 9:05 AM: - or

[jira] [Created] (AIRFLOW-2873) Improvements to Quick Start flow

2018-08-08 Thread G. Geijteman (JIRA)
G. Geijteman created AIRFLOW-2873: - Summary: Improvements to Quick Start flow Key: AIRFLOW-2873 URL: https://issues.apache.org/jira/browse/AIRFLOW-2873 Project: Apache Airflow Issue Type:

[jira] [Commented] (AIRFLOW-2873) Improvements to Quick Start flow

2018-08-08 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572914#comment-16572914 ] Ash Berlin-Taylor commented on AIRFLOW-2873: Thanks for reporting this. An easy quickstart

[jira] [Commented] (AIRFLOW-2873) Improvements to Quick Start flow

2018-08-08 Thread G. Geijteman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572924#comment-16572924 ] G. Geijteman commented on AIRFLOW-2873: --- [~ashb] Thank you, I could now run the installation

[GitHub] xnuinside edited a comment on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

2018-08-08 Thread GitBox
xnuinside edited a comment on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411349555 @kaxil , yeah, sure, first time I have done it the way as you write, but then found close PR with

[jira] [Comment Edited] (AIRFLOW-2416) executor_config column in task_instance isn't getting created

2018-08-08 Thread John Cheng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572886#comment-16572886 ] John Cheng edited comment on AIRFLOW-2416 at 8/8/18 8:42 AM: - It's not

[jira] [Updated] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-2871: Attachment: screenshot-2.png > Harden and improve Read the Docs build environment >

[jira] [Updated] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-2871: Attachment: screenshot-1.png > Harden and improve Read the Docs build environment >

[jira] [Commented] (AIRFLOW-2871) Harden and improve Read the Docs build environment

2018-08-08 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572895#comment-16572895 ] Kaxil Naik commented on AIRFLOW-2871: - [~ashb] We had documented this at

[GitHub] xnuinside commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

2018-08-08 Thread GitBox
xnuinside commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411349555 @kaxil , yeah, sure, first time I have done it the way as you write, but then found close PR with the

[GitHub] verdan opened a new pull request #3719: [AIRFLOW-2874] Enables FAB's theme support

2018-08-08 Thread GitBox
verdan opened a new pull request #3719: [AIRFLOW-2874] Enables FAB's theme support URL: https://github.com/apache/incubator-airflow/pull/3719 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-2874) Enable Flask App Builder theme support

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572989#comment-16572989 ] ASF GitHub Bot commented on AIRFLOW-2874: - verdan opened a new pull request #3719:

[GitHub] xnuinside commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

2018-08-08 Thread GitBox
xnuinside commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411360602 tests failed with ERROR [airflow.models.DagBag] Failed to bag_dag:

[GitHub] bolkedebruin closed pull request #3708: [AIRFLOW-2859] Implement own UtcDateTime

2018-08-08 Thread GitBox
bolkedebruin closed pull request #3708: [AIRFLOW-2859] Implement own UtcDateTime URL: https://github.com/apache/incubator-airflow/pull/3708 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[jira] [Commented] (AIRFLOW-2859) DateTimes returned from the database are not converted to UTC

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572715#comment-16572715 ] ASF GitHub Bot commented on AIRFLOW-2859: - bolkedebruin closed pull request #3708:

[jira] [Commented] (AIRFLOW-2859) DateTimes returned from the database are not converted to UTC

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572716#comment-16572716 ] ASF subversion and git services commented on AIRFLOW-2859: -- Commit

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread George Leslie-Waksman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572816#comment-16572816 ] George Leslie-Waksman commented on AIRFLOW-2870: The process to reproduce is as

[jira] [Commented] (AIRFLOW-2826) Add hook for Google Cloud KMS

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572848#comment-16572848 ] ASF subversion and git services commented on AIRFLOW-2826: -- Commit

[jira] [Commented] (AIRFLOW-2062) Support fine-grained Connection encryption

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572849#comment-16572849 ] ASF subversion and git services commented on AIRFLOW-2062: -- Commit

[jira] [Commented] (AIRFLOW-2826) Add hook for Google Cloud KMS

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572847#comment-16572847 ] ASF GitHub Bot commented on AIRFLOW-2826: - Fokko closed pull request #3677: [AIRFLOW-2826] Add

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread Bolke de Bruin (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572876#comment-16572876 ] Bolke de Bruin commented on AIRFLOW-2870: - Gotcha. The weakness of using orm in alembic. Column

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572883#comment-16572883 ] Ash Berlin-Taylor commented on AIRFLOW-2870: Direct SQL might be an option, or

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread George Leslie-Waksman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572834#comment-16572834 ] George Leslie-Waksman commented on AIRFLOW-2870: Exact steps to reproduce: {noformat}

[jira] [Reopened] (AIRFLOW-2848) dag_id is missing in metadata table "job" for LocalTaskJob

2018-08-08 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-2848: Re-opening so I can set Fix Version - it doesn't appear that this is doable without

[jira] [Created] (AIRFLOW-2872) Minor bugs in "Ad Hoc Query" view, and refinement

2018-08-08 Thread Xiaodong DENG (JIRA)
Xiaodong DENG created AIRFLOW-2872: -- Summary: Minor bugs in "Ad Hoc Query" view, and refinement Key: AIRFLOW-2872 URL: https://issues.apache.org/jira/browse/AIRFLOW-2872 Project: Apache Airflow

[jira] [Resolved] (AIRFLOW-2848) dag_id is missing in metadata table "job" for LocalTaskJob

2018-08-08 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-2848. Resolution: Fixed Fix Version/s: 2.0.0 > dag_id is missing in metadata

[jira] [Commented] (AIRFLOW-2869) Remove smart quote from default config

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572854#comment-16572854 ] ASF subversion and git services commented on AIRFLOW-2869: -- Commit

[jira] [Commented] (AIRFLOW-2416) executor_config column in task_instance isn't getting created

2018-08-08 Thread John Cheng (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572886#comment-16572886 ] John Cheng commented on AIRFLOW-2416: - It's not fixed yet. I try to change the executor_config in

[GitHub] Fokko closed pull request #3677: [AIRFLOW-2826] Add GoogleCloudKMSHook

2018-08-08 Thread GitBox
Fokko closed pull request #3677: [AIRFLOW-2826] Add GoogleCloudKMSHook URL: https://github.com/apache/incubator-airflow/pull/3677 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread George Leslie-Waksman (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572857#comment-16572857 ] George Leslie-Waksman commented on AIRFLOW-2870: If we instead upgrade from 1.8.1 ->

[jira] [Commented] (AIRFLOW-2140) Add Kubernetes Scheduler to Spark Submit Operator

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572855#comment-16572855 ] ASF subversion and git services commented on AIRFLOW-2140: -- Commit

[GitHub] kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines

2018-08-08 Thread GitBox
kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208498985 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -238,6

[GitHub] codecov-io commented on issue #3718: [AIRFLOW-2872] Fix and Refine 'Ad Hoc Query' View

2018-08-08 Thread GitBox
codecov-io commented on issue #3718: [AIRFLOW-2872] Fix and Refine 'Ad Hoc Query' View URL: https://github.com/apache/incubator-airflow/pull/3718#issuecomment-411331261 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3718?src=pr=h1) Report > Merging

[GitHub] Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#discussion_r208485615 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -0,0 +1,239 @@ +# -*- coding: utf-8

[GitHub] Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

2018-08-08 Thread GitBox
Fokko commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#discussion_r208486176 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -0,0 +1,239 @@ +# -*- coding: utf-8

[GitHub] XD-DENG opened a new pull request #3718: [AIRFLOW-2872] Fix and Refine 'Ad Hoc Query' View

2018-08-08 Thread GitBox
XD-DENG opened a new pull request #3718: [AIRFLOW-2872] Fix and Refine 'Ad Hoc Query' View URL: https://github.com/apache/incubator-airflow/pull/3718 ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and

[jira] [Commented] (AIRFLOW-2872) Minor bugs in "Ad Hoc Query" view, and refinement

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572840#comment-16572840 ] ASF GitHub Bot commented on AIRFLOW-2872: - XD-DENG opened a new pull request #3718:

[jira] [Commented] (AIRFLOW-2859) DateTimes returned from the database are not converted to UTC

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572863#comment-16572863 ] ASF subversion and git services commented on AIRFLOW-2859: -- Commit

[GitHub] kaxil commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators

2018-08-08 Thread GitBox
kaxil commented on issue #3717: [AIRFLOW-1874] use_legacy_sql added to BigQueryCheck operators URL: https://github.com/apache/incubator-airflow/pull/3717#issuecomment-411331977 As far as I know, there is a plan to deprecate args and kwargs keywords in Airflow. Can you instead just add

[GitHub] bolkedebruin commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration

2018-08-08 Thread GitBox
bolkedebruin commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration URL: https://github.com/apache/incubator-airflow/pull/3720#issuecomment-411468352 Ah let me fix that This is an automated message

[GitHub] codecov-io edited a comment on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration

2018-08-08 Thread GitBox
codecov-io edited a comment on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration URL: https://github.com/apache/incubator-airflow/pull/3720#issuecomment-411401924 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3720?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-2861) Need index on log table

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573530#comment-16573530 ] ASF GitHub Bot commented on AIRFLOW-2861: - bolkedebruin closed pull request #3709:

[jira] [Commented] (AIRFLOW-2861) Need index on log table

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573531#comment-16573531 ] ASF subversion and git services commented on AIRFLOW-2861: -- Commit

[GitHub] bolkedebruin closed pull request #3709: [AIRFLOW-2861] Added index on log table

2018-08-08 Thread GitBox
bolkedebruin closed pull request #3709: [AIRFLOW-2861] Added index on log table URL: https://github.com/apache/incubator-airflow/pull/3709 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[jira] [Updated] (AIRFLOW-2875) Env variables should have percent signs escaped before writing to tmp config

2018-08-08 Thread William Horton (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] William Horton updated AIRFLOW-2875: Description: I encountered this when I was using an environment variable for

[GitHub] wdhorton opened a new pull request #3721: [AIRFLOW-2875] Escape env vars in tmp config

2018-08-08 Thread GitBox
wdhorton opened a new pull request #3721: [AIRFLOW-2875] Escape env vars in tmp config URL: https://github.com/apache/incubator-airflow/pull/3721 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[jira] [Resolved] (AIRFLOW-2826) Add hook for Google Cloud KMS

2018-08-08 Thread Jasper Kahn (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jasper Kahn resolved AIRFLOW-2826. -- Resolution: Fixed > Add hook for Google Cloud KMS > - > >

[GitHub] troychen728 commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training

2018-08-08 Thread GitBox
troychen728 commented on a change in pull request #3658: [AIRFLOW-2524] Add Amazon SageMaker Training URL: https://github.com/apache/incubator-airflow/pull/3658#discussion_r208672024 ## File path: airflow/contrib/hooks/sagemaker_hook.py ## @@ -0,0 +1,239 @@ +# -*- coding:

[GitHub] bolkedebruin commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration

2018-08-08 Thread GitBox
bolkedebruin commented on issue #3720: [AIRFLOW-2870] Use abstract TaskInstance for migration URL: https://github.com/apache/incubator-airflow/pull/3720#issuecomment-411469023 @gwax done. PTAL This is an automated message

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573528#comment-16573528 ] ASF subversion and git services commented on AIRFLOW-2870: -- Commit

[jira] [Commented] (AIRFLOW-2870) Migrations fail when upgrading from below cc1e65623dc7_add_max_tries_column_to_task_instance

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573527#comment-16573527 ] ASF GitHub Bot commented on AIRFLOW-2870: - bolkedebruin closed pull request #3720:

[GitHub] bolkedebruin edited a comment on issue #3560: [AIRFLOW-2697] Drop snakebite in favour of hdfs3

2018-08-08 Thread GitBox
bolkedebruin edited a comment on issue #3560: [AIRFLOW-2697] Drop snakebite in favour of hdfs3 URL: https://github.com/apache/incubator-airflow/pull/3560#issuecomment-411484838 Can you revise and squash your commits? The we can (most likely :-) ) merge.

  1   2   >