[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=123718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123718
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 16/Jul/18 18:13
Start Date: 16/Jul/18 18:13
Worklog Time Spent: 10m 
  Work Description: Ardagan commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-405332630
 
 
   @lgajowy The doc is work-in progress. Dumped docs in my fork for now, will 
move them to corresponding wiki once we come up with one. Please see it here:
   https://github.com/Ardagan/beam/blob/JenkinsDoc/devdocstemp/jenkins.md
   
   Feel free to update doc if you find any bugs.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 123718)
Time Spent: 3h 20m  (was: 3h 10m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=123534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123534
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 16/Jul/18 08:35
Start Date: 16/Jul/18 08:35
Worklog Time Spent: 10m 
  Work Description: lgajowy closed pull request #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.test-infra/jenkins/common_job_properties.groovy 
b/.test-infra/jenkins/CommonProperties.groovy
similarity index 98%
rename from .test-infra/jenkins/common_job_properties.groovy
rename to .test-infra/jenkins/CommonProperties.groovy
index 81ec59bee18..1f3974eea5b 100644
--- a/.test-infra/jenkins/common_job_properties.groovy
+++ b/.test-infra/jenkins/CommonProperties.groovy
@@ -20,7 +20,7 @@
 // common properties that are shared among all Jenkins projects.
 // Code in this directory should conform to the Groovy style guide.
 //  http://groovy-lang.org/style-guide.html
-class common_job_properties {
+class CommonProperties {
 
   static String checkoutDir = 'src'
 
@@ -323,7 +323,7 @@ class common_job_properties {
 // Install Perfkit benchmark requirements.
 shell('.env/bin/pip install -r PerfKitBenchmarker/requirements.txt')
 // Install job requirements for Python SDK.
-shell('.env/bin/pip install -e ' + common_job_properties.checkoutDir + 
'/sdks/python/[gcp,test]')
+shell('.env/bin/pip install -e ' + CommonProperties.checkoutDir + 
'/sdks/python/[gcp,test]')
 // Launch performance test.
 shell(".env/bin/python PerfKitBenchmarker/pkb.py $pkbArgs")
 }
diff --git a/.test-infra/jenkins/job_Dependency_Check.groovy 
b/.test-infra/jenkins/DependencyCheck.groovy
similarity index 83%
rename from .test-infra/jenkins/job_Dependency_Check.groovy
rename to .test-infra/jenkins/DependencyCheck.groovy
index 6f3e1063347..448564ab65d 100644
--- a/.test-infra/jenkins/job_Dependency_Check.groovy
+++ b/.test-infra/jenkins/DependencyCheck.groovy
@@ -16,34 +16,34 @@
  * limitations under the License.
  */
 
-import common_job_properties
+import CommonProperties as commonProperties
 
 job('beam_Dependency_Check') {
   description('Runs Beam dependency check.')
 
   // Set common parameters.
-  common_job_properties.setTopLevelMainJobProperties(delegate)
+  commonProperties.setTopLevelMainJobProperties(delegate)
 
   // Allows triggering this build against pull requests.
-  common_job_properties.enablePhraseTriggeringFromPullRequest(
+  commonProperties.enablePhraseTriggeringFromPullRequest(
 delegate,
 'Beam Dependency Check',
 'Run Dependency Check')
 
   // This is a job that runs weekly.
-  common_job_properties.setAutoJob(
+  commonProperties.setAutoJob(
 delegate,
 '0 12 * * 1')
 
   steps {
 gradle {
-  rootBuildScriptDir(common_job_properties.checkoutDir)
+  rootBuildScriptDir(commonProperties.checkoutDir)
   tasks(':runBeamDependencyCheck')
-  common_job_properties.setGradleSwitches(delegate)
+  commonProperties.setGradleSwitches(delegate)
   switches('-Drevision=release')
 }
 
-shell('cd ' + common_job_properties.checkoutDir +
+shell('cd ' + commonProperties.checkoutDir +
 ' && bash .test-infra/jenkins/dependency_check/generate_report.sh')
   }
 
diff --git a/.test-infra/jenkins/job_Inventory.groovy 
b/.test-infra/jenkins/Inventory.groovy
similarity index 91%
rename from .test-infra/jenkins/job_Inventory.groovy
rename to .test-infra/jenkins/Inventory.groovy
index 8ec6ca059b8..b617546c902 100644
--- a/.test-infra/jenkins/job_Inventory.groovy
+++ b/.test-infra/jenkins/Inventory.groovy
@@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-import common_job_properties
+import CommonProperties as commonProperties
 
 // These jobs list details about each beam runner, to clarify what software
 // is on each machine.
@@ -27,13 +27,13 @@ nums.each {
 description("Run inventory on ${machine}")
 
 // Set common parameters.
-common_job_properties.setTopLevelMainJobProperties(delegate)
+commonProperties.setTopLevelMainJobProperties(delegate)
 
 // Sets that this is a cron job.
-common_job_properties.setCronJob(delegate, '45 18 * * *')
+commonProperties.setCronJob(delegate, '45 18 * * *')
 
 // Allows triggering this build against pull requests.
-common_job_properties.enablePhraseTriggeringFromPullRequest(
+commonProperties.enablePhraseTriggeringFromPullRequest(
   del

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=123533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-123533
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 16/Jul/18 08:35
Start Date: 16/Jul/18 08:35
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-405180076
 
 
   @Ardagan1 thanks for all the ideas and links you posted! I agree with all 
your points.
   
   I saw on the mailing list that you have a tutorial on spinning up Jenkins 
via Docker - really looking forward to this! While we have it it will be 
totally safe to test the options that are left (Jenkins files) and decide which 
way is best.  I'll stay tuned. 
   
   Meanwhile, I'm closing this PR (nothing more to do here). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 123533)
Time Spent: 3h  (was: 2h 50m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=122191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-122191
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 12/Jul/18 06:59
Start Date: 12/Jul/18 06:59
Worklog Time Spent: 10m 
  Work Description: Ardagan1 commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-404410014
 
 
   Hi Łukasz,
   Thank you for looking into this. Out of what I've seen so far: 
   
   If we stay in current JobDSL world: 
   I like your idea to generalize code for common job categories and define 
jobs via methods that accept map as parameters. If we can extract that map into 
separate file, that would be even better. 
   
   Current amount of files is just too huge for amount of work that is done. In 
the state of pre- and post- commit world it already moves in the direction of 
splitting job definition into logic and data files. I believe finishing this 
work would be a good thing to do.
   
   If we move to jenkinsfile world:
   
   I believe it is worth at least looking into before rejecting. Main reasons I 
would vote for switching to jenkinsfile is that it is jenkins native way of 
doing things. 
   
   Good [write 
up](https://marcesher.com/2016/08/04/jenkins-as-code-comparing-job-dsl-and-pipelines/)
 is mentioned on [job dsl 
wiki](https://github.com/jenkinsci/job-dsl-plugin/wiki/Talks-and-Blog-Posts).
   
   My opinion is that we should give jenkinsfile a try and make decision based 
on estimated amount of work required.
   
   One of the starting points can be [auto-convert 
plugin](https://wiki.jenkins.io/display/JENKINS/Convert+To+Pipeline+Plugin) 
that converts free-style jobs to jenkins pipeline.
   
   We can first try it on combination of forked repo and local jenkins docker 
instance to be safe.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 122191)
Time Spent: 2h 50m  (was: 2h 40m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121979
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 17:30
Start Date: 11/Jul/18 17:30
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5927: [BEAM-4691] Rename 
common_job_properties
URL: https://github.com/apache/beam/pull/5927#issuecomment-404249815
 
 
   Oh, I didn't know that. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121979)
Time Spent: 2h 40m  (was: 2.5h)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121976
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 17:29
Start Date: 11/Jul/18 17:29
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5927: [BEAM-4691] Rename 
common_job_properties
URL: https://github.com/apache/beam/pull/5927#issuecomment-404249654
 
 
   Oh, I didn't know that. Thanks!
   
   śr., 11 lip 2018, 19:14 użytkownik Lukasz Cwik 
   napisał:
   
   > Merged #5927 .
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or mute the
   > thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121976)
Time Spent: 2h 20m  (was: 2h 10m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121977
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 17:29
Start Date: 11/Jul/18 17:29
Worklog Time Spent: 10m 
  Work Description: lgajowy removed a comment on issue #5927: [BEAM-4691] 
Rename common_job_properties
URL: https://github.com/apache/beam/pull/5927#issuecomment-404249654
 
 
   Oh, I didn't know that. Thanks!
   
   śr., 11 lip 2018, 19:14 użytkownik Lukasz Cwik 
   napisał:
   
   > Merged #5927 .
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or mute the
   > thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121977)
Time Spent: 2.5h  (was: 2h 20m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121958
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 17:14
Start Date: 11/Jul/18 17:14
Worklog Time Spent: 10m 
  Work Description: lukecwik closed pull request #5927: [BEAM-4691] Rename 
common_job_properties
URL: https://github.com/apache/beam/pull/5927
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.test-infra/jenkins/common_job_properties.groovy 
b/.test-infra/jenkins/CommonJobProperties.groovy
similarity index 98%
rename from .test-infra/jenkins/common_job_properties.groovy
rename to .test-infra/jenkins/CommonJobProperties.groovy
index 81ec59bee18..42af9c1898a 100644
--- a/.test-infra/jenkins/common_job_properties.groovy
+++ b/.test-infra/jenkins/CommonJobProperties.groovy
@@ -20,7 +20,7 @@
 // common properties that are shared among all Jenkins projects.
 // Code in this directory should conform to the Groovy style guide.
 //  http://groovy-lang.org/style-guide.html
-class common_job_properties {
+class CommonJobProperties {
 
   static String checkoutDir = 'src'
 
@@ -323,7 +323,7 @@ class common_job_properties {
 // Install Perfkit benchmark requirements.
 shell('.env/bin/pip install -r PerfKitBenchmarker/requirements.txt')
 // Install job requirements for Python SDK.
-shell('.env/bin/pip install -e ' + common_job_properties.checkoutDir + 
'/sdks/python/[gcp,test]')
+shell('.env/bin/pip install -e ' + CommonJobProperties.checkoutDir + 
'/sdks/python/[gcp,test]')
 // Launch performance test.
 shell(".env/bin/python PerfKitBenchmarker/pkb.py $pkbArgs")
 }
diff --git a/.test-infra/jenkins/PostcommitJobBuilder.groovy 
b/.test-infra/jenkins/PostcommitJobBuilder.groovy
index ce41d265353..9ca88bca7fb 100644
--- a/.test-infra/jenkins/PostcommitJobBuilder.groovy
+++ b/.test-infra/jenkins/PostcommitJobBuilder.groovy
@@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-import common_job_properties as cjp
+import CommonJobProperties as commonJobProperties
 
 /**
  * This class is to be used for defining jobs for post- and pre-commit tests.
@@ -47,14 +47,14 @@ class PostcommitJobBuilder {
 
   void defineAutoPostCommitJob(name) {
 def autoBuilds = scope.job(name) {
-  cjp.setAutoJob delegate
+  commonJobProperties.setAutoJob delegate
 }
 autoBuilds.with(jobDefinition)
   }
 
   private void defineGhprbTriggeredJob(name, triggerPhrase, githubUiHint, 
triggerOnPrCommit) {
 def ghprbBuilds = scope.job(name) {
-  cjp.setPullRequestBuildTrigger(
+  commonJobProperties.setPullRequestBuildTrigger(
 delegate,
 githubUiHint,
 triggerPhrase,
diff --git a/.test-infra/jenkins/PrecommitJobBuilder.groovy 
b/.test-infra/jenkins/PrecommitJobBuilder.groovy
index cd4250e33e6..a7b3ad26f2d 100644
--- a/.test-infra/jenkins/PrecommitJobBuilder.groovy
+++ b/.test-infra/jenkins/PrecommitJobBuilder.groovy
@@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-import common_job_properties
+import CommonJobProperties as commonJobProperties
 
 /** This class defines PrecommitJobBuilder.build() helper for defining 
pre-comit jobs. */
 class PrecommitJobBuilder {
@@ -51,7 +51,7 @@ class PrecommitJobBuilder {
 def job = createBaseJob 'Cron'
 job.with {
   description buildDescription('on a daily schedule.')
-  common_job_properties.setAutoJob delegate
+  commonJobProperties.setAutoJob delegate
 }
 job.with additionalCustomization
   }
@@ -71,7 +71,7 @@ class PrecommitJobBuilder {
 job.with {
   description buildDescription('for each commit push.')
   concurrentBuild()
-  common_job_properties.setPullRequestBuildTrigger(delegate,
+  commonJobProperties.setPullRequestBuildTrigger(delegate,
 githubUiHint(),
 '',
 false,
@@ -85,7 +85,7 @@ class PrecommitJobBuilder {
 job.with {
   description buildDescription("on trigger phrase 
'${buildTriggerPhrase()}'.")
   concurrentBuild()
-  common_job_properties.setPullRequestBuildTrigger delegate, 
githubUiHint(), buildTriggerPhrase()
+  commonJobProperties.setPullRequestBuildTrigger delegate, githubUiHint(), 
buildTriggerPhrase()
 }
 job.with additionalCustomization
   }
@@ -93,15 +93,15 @@ class PrecommitJobBuilder {
   private Object createBaseJob(nameSuffix, usesRegionFilter = false) {
 def allowRemotePoll = !usesRegionFilter
 return scope.job("beam_PreCommit_${nameBase}_${nameSuffix}") {
-  common_job_properties.setTopLevelMainJobPrope

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121957&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121957
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 17:12
Start Date: 11/Jul/18 17:12
Worklog Time Spent: 10m 
  Work Description: lukecwik commented on issue #5927: [BEAM-4691] Rename 
common_job_properties
URL: https://github.com/apache/beam/pull/5927#issuecomment-404244575
 
 
   Scott is out on paternity leave, don't know if he will have time to take a 
look at this for a good period of time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121957)
Time Spent: 2h  (was: 1h 50m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121883
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 12:34
Start Date: 11/Jul/18 12:34
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5927: [BEAM-4691] Rename 
common_job_properties
URL: https://github.com/apache/beam/pull/5927#issuecomment-404152983
 
 
   @swegner after some turbulences with Jenkins and discovering obstacles I 
described [here](https://github.com/apache/beam/pull/5831), I decided to work 
on this issue more carefully and submit smaller pull requests. This one simply 
renames the common_job_properties to use the Groovy naming convention. The seed 
job succeeded so it works.
   
   Could you take a look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121883)
Time Spent: 1h 50m  (was: 1h 40m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121863
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 11/Jul/18 11:35
Start Date: 11/Jul/18 11:35
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-404138006
 
 
   I am also considering this as an alternative solution, but it would require 
much more effort (maybe worth it): 
https://jenkins.io/doc/book/pipeline/jenkinsfile/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121863)
Time Spent: 1h 40m  (was: 1.5h)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121444
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 10/Jul/18 15:20
Start Date: 10/Jul/18 15:20
Worklog Time Spent: 10m 
  Work Description: lgajowy edited a comment on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-403860530
 
 
   @swegner @Ardagan  ok, today I learned a little bit more about the 
possibilities we have. I've done another PR to dig into this from a different 
angle (https://github.com/apache/beam/pull/5915). 
   
   __I think we cannot have both:__ directories and common files (such as 
`CommonProperties.groovy`). I successfully moved `HadoopInputFormatIOIT` to a 
separate directory but no matter what I tried (keeping CommonProperties in 
.jenkins and import or moving it to a "common" directory and then import) I 
couldn't run the seed job successfully. 
   
   One last idea that comes to my mind is to merge job files that have the same 
category. We would then have `PerformanceTests.groovy`, `PostCommit.groovy`, 
`PreCommit.groovy`, etc. I consider this idea because: 
- we could have multiple jobs per one file
- we could extract some handy methods for creating jobs per each category. 
Such methods could be hidden in corresponding files (eg. method for creating a 
post-commit job would reside in PostCommit.groovy class)
- because we're using groovy here, methods for creating jobs could accept a 
map as a parameter. Such map can be very readable and clean. We do something 
like this in 
[FileBasedIOIT](https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PerformanceTests_FileBasedIO_IT.groovy)
- we could keep stuff like CommonProperties etc. where it is now and use it 
as before. At the same time, category specific methods can remain hidden in 
categories' files (eg. kubernetes related methods could be hidden in a 
PerformanceTests.groovy file). 
   
   The drawbacks I see: 
- it may be harder to find a specific job in a common file
- it may be easier to break many things at once due to common code (IMO, 
we're vulnerable to this either way)
- ???
   
   WDYT? I ask for your opinions first because you recently worked on some 
refactoring and maybe have some thoughts in this matter. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121444)
Time Spent: 1.5h  (was: 1h 20m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=121443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121443
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 10/Jul/18 15:17
Start Date: 10/Jul/18 15:17
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-403860530
 
 
   @swegner @Ardagan  ok, today I learned a little bit more about the 
possibilities we have. I've done another PR to dig into this from a different 
angle (https://github.com/apache/beam/pull/5915). 
   
   __I think we cannot have both:__ directories and common files. I 
successfully moved `HadoopInputFormatIOIT` to a separate directory but no 
matter what I tried (keeping CommonProperties in .jenkins and import or moving 
it to a "common" directory and then import) I couldn't run the seed job 
successfully. 
   
   One last idea that comes to my mind is to merge job files that have the same 
category. We would then have `PerformanceTests.groovy`, `PostCommit.groovy`, 
`PreCommit.groovy`, etc. I consider this idea because: 
- we could have multiple jobs per one file
- we could extract some handy methods for creating jobs per each category. 
Such methods could be hidden in corresponding files (eg. method for creating a 
post-commit job would reside in PostCommit.groovy class)
- because we're using groovy here, methods for creating jobs could accept a 
map as a parameter. Such map can be very readable and clean. We do something 
like this in 
[FileBasedIOIT](https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PerformanceTests_FileBasedIO_IT.groovy)
- we could keep stuff like CommonProperties etc. where it is now and use it 
as before. At the same time, category specific methods can remain hidden in 
categories' files (eg. kubernetes related methods could be hidden in a 
PerformanceTests.groovy file). 
   
   The drawbacks I see: 
- it may be harder to find a specific job in a common file
- it may be easier to break many things at once due to common code (IMO, 
we're vulnerable to this either way)
- ???
   
   WDYT? I ask for your opinions first because you recently worked on some 
refactoring and maybe have some thoughts in this matter. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 121443)
Time Spent: 1h 20m  (was: 1h 10m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118243
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 02/Jul/18 16:59
Start Date: 02/Jul/18 16:59
Worklog Time Spent: 10m 
  Work Description: swegner commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401869079
 
 
   This is awesome, thanks for working on this. A couple thoughts:
   
   > 1. I am not sure if I can change the job_00_seed.groovy name.
   
   I suspect this is a bootstrapping problem. i.e., remember that when you run 
the seed job, it's running the currently configured job from `master`, and 
generating and publishing new job definitions from it. The currently published 
job looks for `job_*`, so you might need a two-step process, i.e.:
   
   1. Rename the files as planned, but also keep the original 
`job_00_seed.groovy` version, and in that file add both glob patterns
   2. Run that job to generate the new seed job definition
   3. Once your change is merged to master and the new seed job is successfully 
running, submit the change to remove the old seed job.
   
   > 2. I cannot import CommonProperties everywhere when the directory 
structure is more than 1 level deep. 
   
   Bummer. thanks for investigating this.
   
   > 3. I think we should split the CommonProperties file (former 
common_job_properties). It's a "god object" to me and knows way too much.
   
   +:100: Any improvements we can make to this code is welcome. I recently 
stumbled up this page on [Design patterns in 
Groovy](http://groovy-lang.org/design-patterns.html)
   
   
   CC @Ardagan 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 118243)
Time Spent: 1h 10m  (was: 1h)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118173
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 02/Jul/18 13:33
Start Date: 02/Jul/18 13:33
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401805584
 
 
   I did a small test in order to check if we can refactor the code this way 
(split to directories, change to CamelCase). Below are some things I've found 
out:
   
   1. I am not sure if I can change the job_00_seed.groovy name. Jenkins didn't 
change the glob pattern used to search for other job definitions when the name 
was `Seed.groovy` (like it wasn't able to find the seed job when it's name 
changed). Am I missing something here? Is path to seed job hardcoded in the 
workspace/jenkins config (see: [the seed job run that cannot find jobs using 
the old "job_" 
pattern](https://builds.apache.org/view/A-D/view/Beam/job/beam_SeedJob/2133/console)).
   
   2. I cannot import CommonProperties everywhere when the directory structure 
is more than 1 level deep. This is described here:  
[LINK](https://github.com/jenkinsci/job-dsl-plugin/wiki/Real-World-Examples#import-other-files-ie-with-class-definitions-into-your-script).
 I will try to simplify the directory tree to be one level and check if it 
works for our case.
   
   3. I think we should split the CommonProperties file (former 
common_job_properties). It's a "god object" to me and knows way too much.
   
   Another good thing of having directories would be the possibility to hide 
PreCommitBuilder in pre_commit directory (and so on) - so this is more than 
just clean structure. 
   
   CC: @kennknowles @swegner request for comments :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 118173)
Time Spent: 1h  (was: 50m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118153
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 02/Jul/18 12:45
Start Date: 02/Jul/18 12:45
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401792393
 
 
   Run seed job


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 118153)
Time Spent: 50m  (was: 40m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118145
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 02/Jul/18 12:24
Start Date: 02/Jul/18 12:24
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401786970
 
 
   Run seed job


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 118145)
Time Spent: 40m  (was: 0.5h)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=118140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118140
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 02/Jul/18 12:07
Start Date: 02/Jul/18 12:07
Worklog Time Spent: 10m 
  Work Description: lgajowy commented on issue #5831: [BEAM-4691] 
(do-not-merge-yet!) Move perf tests to a separate directory and rename them 
(conventionally)
URL: https://github.com/apache/beam/pull/5831#issuecomment-401783039
 
 
   Run seed job


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 118140)
Time Spent: 0.5h  (was: 20m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=117431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117431
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 29/Jun/18 15:54
Start Date: 29/Jun/18 15:54
Worklog Time Spent: 10m 
  Work Description: lgajowy removed a comment on issue #5831: [BEAM-4691] 
Move perf tests to a separate directory and rename them (conventionally) 
URL: https://github.com/apache/beam/pull/5831#issuecomment-401349584
 
 
   Run seed job


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 117431)
Time Spent: 20m  (was: 10m)

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (BEAM-4691) Rename (and reorganize?) jenkins jobs

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=117430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117430
 ]

ASF GitHub Bot logged work on BEAM-4691:


Author: ASF GitHub Bot
Created on: 29/Jun/18 15:54
Start Date: 29/Jun/18 15:54
Worklog Time Spent: 10m 
  Work Description: lgajowy removed a comment on issue #5831: [BEAM-4691] 
Move perf tests to a separate directory and rename them (conventionally) 
URL: https://github.com/apache/beam/pull/5831#issuecomment-401351299
 
 
   Run seed job


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 117430)
Time Spent: 10m
Remaining Estimate: 0h

> Rename (and reorganize?) jenkins jobs
> -
>
> Key: BEAM-4691
> URL: https://issues.apache.org/jira/browse/BEAM-4691
> Project: Beam
>  Issue Type: Task
>  Components: build-system
>Reporter: Łukasz Gajowy
>Assignee: Łukasz Gajowy
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Link to discussion: 
> [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E]
> Since jobs are Groovy files their names should be CamelCase. We could also 
> place them in subdirectories instead of prefixing job names. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)