[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442019191 ## File path: core/src/main/java/org/apache/calcite/plan/ConventionTraitDef.java ## @@ -234,10 +234,10 @@ private ConversionData getConversionData(RelOp

[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

xndai commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442023404 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -66,7 +66,7 @@ assertNull(shortestPath(g, "A", "E"), "Ther

[GitHub] [calcite] xy2953396112 commented on pull request #1983: [CALCITE-4005] Support calc operator in RelMdAllPredicates and RelMdE…

xy2953396112 commented on pull request #1983: URL: https://github.com/apache/calcite/pull/1983#issuecomment-645837559 @chunweilei Please help review this pr when you have time. Thanks a lot. This is an automated message from

[calcite] branch master updated: [CALCITE-4020] Support Calc operator in RelFieldTrimmer (Xu Zhaohui)

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new d7eb31b [CALCITE-4020] Support Calc operator

[GitHub] [calcite] chunweilei merged pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

chunweilei merged pull request #1987: URL: https://github.com/apache/calcite/pull/1987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei merged pull request #2020: [CALCITE-4060] Supports implicit type coercion for NOT IN.

chunweilei merged pull request #2020: URL: https://github.com/apache/calcite/pull/2020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[calcite] branch master updated: [CALCITE-4060] Supports implicit type coercion for "NOT IN".

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 72f3322 [CALCITE-4060] Supports implicit type

[GitHub] [calcite] danny0405 commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

danny0405 commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r442079092 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +131,57 @@ SqlTypeCoercionRule.THREAD_PROVIDERS.set(

[GitHub] [calcite] danny0405 commented on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

danny0405 commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-645886776 > The code looks really redundant, cuz RelDistribution#getKeys is annotated as nonnull, and must return "List". > Or do I miss something? It is nonnull, but can it be

[GitHub] [calcite] wenhuitang commented on a change in pull request #1990: [CALCITE-4026] CassandraFilter has generated wrong condition expression for filter with non string literal

wenhuitang commented on a change in pull request #1990: URL: https://github.com/apache/calcite/pull/1990#discussion_r442085701 ## File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java ## @@ -25,6 +29,15 @@ private DateTimeStringUtils() {} + /**

[GitHub] [calcite] wenhuitang commented on a change in pull request #1990: [CALCITE-4026] CassandraFilter has generated wrong condition expression for filter with non string literal

wenhuitang commented on a change in pull request #1990: URL: https://github.com/apache/calcite/pull/1990#discussion_r442085701 ## File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java ## @@ -25,6 +29,15 @@ private DateTimeStringUtils() {} + /**

[GitHub] [calcite] wenhuitang commented on a change in pull request #1990: [CALCITE-4026] CassandraFilter has generated wrong condition expression for filter with non string literal

wenhuitang commented on a change in pull request #1990: URL: https://github.com/apache/calcite/pull/1990#discussion_r442085701 ## File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java ## @@ -25,6 +29,15 @@ private DateTimeStringUtils() {} + /**

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442101018 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -66,7 +66,7 @@ assertNull(shortestPath(g, "A", "E"), "

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442100756 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -134,7 +135,44 @@ public int size() { if (from.equals(to)) { Re

[GitHub] [calcite] wenhuitang commented on a change in pull request #1990: [CALCITE-4026] CassandraFilter has generated wrong condition expression for filter with non string literal

wenhuitang commented on a change in pull request #1990: URL: https://github.com/apache/calcite/pull/1990#discussion_r442101891 ## File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java ## @@ -25,6 +29,15 @@ private DateTimeStringUtils() {} + /**

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442105545 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442111462 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442112660 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442113348 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] danny0405 commented on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on pull request #2016: URL: https://github.com/apache/calcite/pull/2016#issuecomment-645923910 > Regarding my concern about memory usage, I was talking about `Digest` and the extra list used to store `items` which is kind of redundant with the `RelNode` itself. An alter

[GitHub] [calcite] danny0405 edited a comment on pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 edited a comment on pull request #2016: URL: https://github.com/apache/calcite/pull/2016#issuecomment-645923910 > Regarding my concern about memory usage, I was talking about `Digest` and the extra list used to store `items` which is kind of redundant with the `RelNode` itself. A

[GitHub] [calcite] yanlin-Lynn commented on pull request #2004: [CALCITE-4019] Visit SqlInsert with SqlShuttle cause NullPointerExcep…

yanlin-Lynn commented on pull request #2004: URL: https://github.com/apache/calcite/pull/2004#issuecomment-645967870 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [calcite] rubenada commented on pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

rubenada commented on pull request #1937: URL: https://github.com/apache/calcite/pull/1937#issuecomment-646119273 No problem @hsyuan , thanks for your review. As I said, this is a long-awaited feature that is currently blocking other issues on our side, so I'd rather merge this in the ne

[GitHub] [calcite] hsyuan commented on pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

hsyuan commented on pull request #1937: URL: https://github.com/apache/calcite/pull/1937#issuecomment-646124637 Thanks for understanding. Let's merge it sooner rather than later. I don't see any reason to wait for another 24 hours. As long as there is no -1 or fundamental design flaw, We c

[GitHub] [calcite] rubenada commented on pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

rubenada commented on pull request #1937: URL: https://github.com/apache/calcite/pull/1937#issuecomment-646127833 Ok, @hsyuan , you're right. I'll merge it right away. This is an automated message from the Apache Git Servi

[GitHub] [calcite] rubenada merged pull request #1937: [CALCITE-3951] Support different string comparison based on SqlCollation

rubenada merged pull request #1937: URL: https://github.com/apache/calcite/pull/1937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[calcite] branch master updated: [CALCITE-3951] Support different string comparison based on SqlCollation

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new fa83490 [CALCITE-3951] Support different stri

[GitHub] [calcite] amaliujia opened a new pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

amaliujia opened a new pull request #2035: URL: https://github.com/apache/calcite/pull/2035 …e (Rui Wang). See: https://jira.apache.org/jira/browse/CALCITE-4008 This is an automated message from the Apache Git

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r442416752 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public EnumerableSortedAg

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r442417140 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r442417140 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442598141 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepRelVertex.java ## @@ -75,8 +76,8 @@ return currentRel.getRowType(); } - @Ove

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442601203 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCorrelateTest.java ## @@ -96,11 +96,11 @@ planner.removeRule(

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442605829 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442607736 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442608886 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepRelVertex.java ## @@ -75,8 +76,8 @@ return currentRel.getRowType(); } - @Over

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442609306 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableCorrelateTest.java ## @@ -96,11 +96,11 @@ planner.removeRule(E

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442609677 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442610070 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442609980 ## File path: core/src/main/java/org/apache/calcite/rel/core/Window.java ## @@ -394,16 +394,24 @@ public RexWinAggCall( this.ignoreNulls = ignor

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442610541 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442598141 ## File path: core/src/main/java/org/apache/calcite/plan/hep/HepRelVertex.java ## @@ -75,8 +76,8 @@ return currentRel.getRowType(); } - @Ove

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442613841 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r442616115 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [calcite] XuQianJin-Stars commented on pull request #1964: Site: Add Tencent and TBDS logo in powered-by image

XuQianJin-Stars commented on pull request #1964: URL: https://github.com/apache/calcite/pull/1964#issuecomment-646419640 > Could you squash commits, @XuQianJin-Stars ? well ,Thks . This is an automated message from the

[GitHub] [calcite] danny0405 opened a new pull request #2036: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 opened a new pull request #2036: URL: https://github.com/apache/calcite/pull/2036 …ls) for RexNode and RelNode (part2) Tweak based on the review concerns. This is an automated message from the Apache Git Serv

[GitHub] [calcite] danny0405 closed pull request #2034: [CALCITE-4070] Add benchmark test for new Digest interface

danny0405 closed pull request #2034: URL: https://github.com/apache/calcite/pull/2034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [calcite] danny0405 commented on a change in pull request #1990: [CALCITE-4026] CassandraFilter has generated wrong condition expression for filter with non string literal

danny0405 commented on a change in pull request #1990: URL: https://github.com/apache/calcite/pull/1990#discussion_r442644527 ## File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java ## @@ -25,6 +29,15 @@ private DateTimeStringUtils() {} + /** T